Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

W dniu 2017-10-18 o 23:54, Eric Dumazet pisze: On Wed, 2017-10-18 at 23:49 +0200, Paweł Staszewski wrote: How far it is from applying this to the kernel ? So far im using this on all my servers from about 3 months now without problems It is a hack, and does not support properly

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

On Wed, 2017-10-18 at 23:49 +0200, Paweł Staszewski wrote: > How far it is from applying this to the kernel ? > > So far im using this on all my servers from about 3 months now without > problems It is a hack, and does not support properly bonding/team. ( If the real_dev->privflags

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

W dniu 2017-09-21 o 23:41, Florian Fainelli pisze: On 09/21/2017 02:26 PM, Paweł Staszewski wrote: W dniu 2017-08-15 o 11:11, Paweł Staszewski pisze: diff --git a/net/8021q/vlan_netlink.c b/net/8021q/vlan_netlink.c index

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

On Thu, 2017-09-21 at 15:07 -0700, Florian Fainelli wrote: > On 09/21/2017 02:54 PM, Eric Dumazet wrote: > > On Thu, 2017-09-21 at 14:41 -0700, Florian Fainelli wrote: > > > >> Would not this apply to pretty much any stacked device setup though? It > >> seems like any network device that just

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

On 09/21/2017 02:54 PM, Eric Dumazet wrote: > On Thu, 2017-09-21 at 14:41 -0700, Florian Fainelli wrote: > >> Would not this apply to pretty much any stacked device setup though? It >> seems like any network device that just queues up its packet on another >> physical device for actual

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

On Thu, 2017-09-21 at 14:41 -0700, Florian Fainelli wrote: > Would not this apply to pretty much any stacked device setup though? It > seems like any network device that just queues up its packet on another > physical device for actual transmission may need that (e.g: DSA, bond, > team, more.?)

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

W dniu 2017-09-21 o 23:41, Florian Fainelli pisze: On 09/21/2017 02:26 PM, Paweł Staszewski wrote: W dniu 2017-08-15 o 11:11, Paweł Staszewski pisze: diff --git a/net/8021q/vlan_netlink.c b/net/8021q/vlan_netlink.c index

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

On 09/21/2017 02:26 PM, Paweł Staszewski wrote: > > > W dniu 2017-08-15 o 11:11, Paweł Staszewski pisze: >> diff --git a/net/8021q/vlan_netlink.c b/net/8021q/vlan_netlink.c >> index >> 5e831de3103e2f7092c7fa15534def403bc62fb4..9472de846d5c0960996261cb2843032847fa4bf7 >> 100644 >> ---

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

W dniu 2017-09-21 o 23:34, Eric Dumazet pisze: On Thu, 2017-09-21 at 23:26 +0200, Paweł Staszewski wrote: W dniu 2017-08-15 o 11:11, Paweł Staszewski pisze: diff --git a/net/8021q/vlan_netlink.c b/net/8021q/vlan_netlink.c index

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

On Thu, 2017-09-21 at 23:26 +0200, Paweł Staszewski wrote: > > W dniu 2017-08-15 o 11:11, Paweł Staszewski pisze: > > diff --git a/net/8021q/vlan_netlink.c b/net/8021q/vlan_netlink.c > > index > > 5e831de3103e2f7092c7fa15534def403bc62fb4..9472de846d5c0960996261cb2843032847fa4bf7 > > > > 100644

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

W dniu 2017-08-15 o 11:11, Paweł Staszewski pisze: diff --git a/net/8021q/vlan_netlink.c b/net/8021q/vlan_netlink.c index 5e831de3103e2f7092c7fa15534def403bc62fb4..9472de846d5c0960996261cb2843032847fa4bf7 100644 --- a/net/8021q/vlan_netlink.c +++ b/net/8021q/vlan_netlink.c @@ -143,6 +143,7

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

Another test for this patch with linux-next tree with patch:  bwm-ng v0.6.1 (probing every 1.000s), press 'h' for help   input: /proc/net/dev type: rate   - iface   Rx Tx    Total ==  

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

Tested with connectx-5 Without patch 10Mpps - > 16 cores used    PerfTop:   66258 irqs/sec  kernel:99.3%  exact:  0.0% [4000Hz cycles],  (all, 32 CPUs)

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

Hi Are there any plans to have this fix normally in kernel ? Or it is mostly only hack - not longterm fix and need to be different ? All tests that was done shows that without this patch there is about 20-30% network forwarding performance degradation when using vlan interfaces Thanks

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

On Tue, 15 Aug 2017 12:05:37 +0200 Paweł Staszewski wrote: > W dniu 2017-08-15 o 12:02, Paweł Staszewski pisze: > > W dniu 2017-08-15 o 11:57, Jesper Dangaard Brouer pisze: > >> On Tue, 15 Aug 2017 11:30:43 +0200 Paweł Staszewski > >> wrote: >

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

W dniu 2017-08-15 o 12:02, Paweł Staszewski pisze: W dniu 2017-08-15 o 11:57, Jesper Dangaard Brouer pisze: On Tue, 15 Aug 2017 11:30:43 +0200 Paweł Staszewski wrote: W dniu 2017-08-15 o 11:23, Jesper Dangaard Brouer pisze: On Tue, 15 Aug 2017 02:38:56 +0200

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

On Tue, 15 Aug 2017 11:11:57 +0200 Paweł Staszewski wrote: > Yes it helped - now there is almost no difference when using vlans or not: > > 10.5Mpps - with vlan > > 11Mpps - without vlan Great! - it seems like we have pinpointed the root-cause. It also demonstrate

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

W dniu 2017-08-15 o 11:57, Jesper Dangaard Brouer pisze: On Tue, 15 Aug 2017 11:30:43 +0200 Paweł Staszewski wrote: W dniu 2017-08-15 o 11:23, Jesper Dangaard Brouer pisze: On Tue, 15 Aug 2017 02:38:56 +0200 Paweł Staszewski wrote: W dniu

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

On Tue, 15 Aug 2017 11:30:43 +0200 Paweł Staszewski wrote: > W dniu 2017-08-15 o 11:23, Jesper Dangaard Brouer pisze: > > On Tue, 15 Aug 2017 02:38:56 +0200 > > Paweł Staszewski wrote: > > > >> W dniu 2017-08-14 o 18:19, Jesper Dangaard Brouer

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

On Mon, 14 Aug 2017 18:57:50 +0200 Paolo Abeni wrote: > On Mon, 2017-08-14 at 18:19 +0200, Jesper Dangaard Brouer wrote: > > The output (extracted below) didn't show who called 'do_raw_spin_lock', > > BUT it showed another interesting thing. The kernel code > >

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

W dniu 2017-08-15 o 11:23, Jesper Dangaard Brouer pisze: On Tue, 15 Aug 2017 02:38:56 +0200 Paweł Staszewski wrote: W dniu 2017-08-14 o 18:19, Jesper Dangaard Brouer pisze: On Sun, 13 Aug 2017 18:58:58 +0200 Paweł Staszewski wrote: To

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

On Tue, 15 Aug 2017 02:38:56 +0200 Paweł Staszewski wrote: > W dniu 2017-08-14 o 18:19, Jesper Dangaard Brouer pisze: > > On Sun, 13 Aug 2017 18:58:58 +0200 Paweł Staszewski > > wrote: > > > >> To show some difference below comparision

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

With hack: 14.44% [kernel] [k] do_raw_spin_lock 8.30% [kernel] [k] page_frag_free 7.06% [mlx5_core][k] mlx5e_xmit 5.97% [kernel] [k] acpi_processor_ffh_cstate_enter 5.73% [kernel] [k] fib_table_lookup 4.81% [mlx5_core][k]

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

Hi Yes it helped - now there is almost no difference when using vlans or not: 10.5Mpps - with vlan 11Mpps - without vlan W dniu 2017-08-15 o 03:17, Eric Dumazet pisze: On Mon, 2017-08-14 at 18:07 -0700, Eric Dumazet wrote: Or try to hack the IFF_XMIT_DST_RELEASE flag on the vlan

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

On Mon, 2017-08-14 at 18:07 -0700, Eric Dumazet wrote: > Or try to hack the IFF_XMIT_DST_RELEASE flag on the vlan netdev. Something like : diff --git a/net/8021q/vlan_netlink.c b/net/8021q/vlan_netlink.c index 5e831de3103e2f7092c7fa15534def403bc62fb4..9472de846d5c0960996261cb2843032847fa4bf7

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

On Tue, 2017-08-15 at 02:45 +0200, Paweł Staszewski wrote: > > W dniu 2017-08-14 o 18:57, Paolo Abeni pisze: > > On Mon, 2017-08-14 at 18:19 +0200, Jesper Dangaard Brouer wrote: > >> The output (extracted below) didn't show who called 'do_raw_spin_lock', > >> BUT it showed another interesting

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

W dniu 2017-08-14 o 18:57, Paolo Abeni pisze: On Mon, 2017-08-14 at 18:19 +0200, Jesper Dangaard Brouer wrote: The output (extracted below) didn't show who called 'do_raw_spin_lock', BUT it showed another interesting thing. The kernel code __dev_queue_xmit() in might create route dst-cache

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

W dniu 2017-08-14 o 18:19, Jesper Dangaard Brouer pisze: On Sun, 13 Aug 2017 18:58:58 +0200 Paweł Staszewski wrote: To show some difference below comparision vlan/no-vlan traffic 10Mpps forwarded traffic vith no-vlan vs 6.9Mpps with vlan I'm trying to reproduce in

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

On Mon, 2017-08-14 at 18:19 +0200, Jesper Dangaard Brouer wrote: > The output (extracted below) didn't show who called 'do_raw_spin_lock', > BUT it showed another interesting thing. The kernel code > __dev_queue_xmit() in might create route dst-cache problem for itself(?), > as it will first call

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

On Mon, 2017-08-14 at 18:19 +0200, Jesper Dangaard Brouer wrote: > The output (extracted below) didn't show who called 'do_raw_spin_lock', > BUT it showed another interesting thing. The kernel code > __dev_queue_xmit() in might create route dst-cache problem for itself(?), > as it will first

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

On Sun, 13 Aug 2017 18:58:58 +0200 Paweł Staszewski wrote: > To show some difference below comparision vlan/no-vlan traffic > > 10Mpps forwarded traffic vith no-vlan vs 6.9Mpps with vlan I'm trying to reproduce in my testlab (with ixgbe). I do see, a performance

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

W dniu 2017-08-14 o 02:07, Alexander Duyck pisze: On Sat, Aug 12, 2017 at 10:27 AM, Paweł Staszewski wrote: Hi and thanks for reply W dniu 2017-08-12 o 14:23, Jesper Dangaard Brouer pisze: On Fri, 11 Aug 2017 19:51:10 +0200 Paweł Staszewski

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

On Sat, Aug 12, 2017 at 10:27 AM, Paweł Staszewski wrote: > Hi and thanks for reply > > > > W dniu 2017-08-12 o 14:23, Jesper Dangaard Brouer pisze: >> >> On Fri, 11 Aug 2017 19:51:10 +0200 Paweł Staszewski >> wrote: >> >>> Hi >>> >>> I made some

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

To show some difference below comparision vlan/no-vlan traffic 10Mpps forwarded traffic vith no-vlan vs 6.9Mpps with vlan (ixgbe in kernel driver kernel 4.13.0-rc4-next-20170811) ethtool settings for both tests: ethtool -K $ifc gro off tso off gso off sg on l2-fwd-offload off tx-nocache-copy

Re: Kernel 4.13.0-rc4-next-20170811 - IP Routing / Forwarding performance vs Core/RSS number / HT on

On Fri, 11 Aug 2017 19:51:10 +0200 Paweł Staszewski wrote: > Hi > > I made some tests for performance comparison. Thanks for doing this. Feel free to Cc me, if you do more of these tests (so I don't miss them on the mailing list). I don't understand stand if you are