The D-Link PCI-X board (and maybe others) can lie about status
ring entries. It seems it will update the register for last status
index before completing the DMA for the ring entry. To avoid reading
stale data, zap the old entry and check.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
Handle the corner case where budget is exhausted correctly.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
--- a/drivers/net/sky2.c2007-10-11 18:11:44.0 -0700
+++ b/drivers/net/sky2.c2007-10-11 18:12:50.0 -0700
@@ -2245,15 +2245,13 @@ static inline void
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Thu, 11 Oct 2007 18:19:52 -0700
Handle the corner case where budget is exhausted correctly.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Doesn't apply, I checked in my fixed version of your original patch
already.
You had to have some
On Thu, 11 Oct 2007 18:23:58 -0700 (PDT)
David Miller [EMAIL PROTECTED] wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Thu, 11 Oct 2007 18:19:52 -0700
Handle the corner case where budget is exhausted correctly.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Doesn't
Handle the corner case where budget is exhausted correctly.
And save unnecessary read of index register.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
--- a/drivers/net/sky2.c2007-10-11 18:26:56.0 -0700
+++ b/drivers/net/sky2.c2007-10-11 18:27:12.0 -0700
@@
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Thu, 11 Oct 2007 18:29:21 -0700
Handle the corner case where budget is exhausted correctly.
And save unnecessary read of index register.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
Applied.
You can submit the rest later, I deleted them
On Thu, 11 Oct 2007 18:31:46 -0700 (PDT)
David Miller [EMAIL PROTECTED] wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Thu, 11 Oct 2007 18:29:21 -0700
Handle the corner case where budget is exhausted correctly.
And save unnecessary read of index register.
Signed-off-by:
applied
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
The status interrupt flag should be cleared before processing,
not afterwards to avoid race. Need to process in poll routine
even if no new interrupt status. This is a normal occurrence when
more than 64 frames (NAPI weight) are processed in one poll routine.
Signed-off-by: Stephen Hemminger
Hi Stephen,
Are you finding sky2 to be stable in your own testing? I have been watching
the patches and your weblog, presumably the problems you found in 0.9 have
been fixed in 0.10?
I'm considering adding sky2 to Gentoo's upcoming 2.6.15 kernel releases. If I
were to do this, would you be
Stephen Hemminger wrote:
Yes 0.10 is relatively stable. All known problems have been fixed, but
it hasn't been tested on a wide range of hardware, I only have three
different boards; one is on Intel motherboard, one is on 1U VPN box,
and also a dual-port PCI-X card.
Ok, thats brill, thanks a
11 matches
Mail list logo