Re: FACK and CWND

2006-08-01 Thread David Miller
From: Ma Lin [EMAIL PROTECTED] Date: Fri, 28 Jul 2006 18:37:15 +0800 In FACK, the holes between SACK blocks are considered as loss. To a sender, when SACK comes in, loss_out would be non-zero. According to linux-2.6.17.7/net/ipv4/tcp_input.c, function tcp_time_to_recover(), this non-zero

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

2006-08-01 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Mon, 31 Jul 2006 20:36:58 +0200 Herbert Xu wrote: So I'd rather see a patch to disable the warnings for 2.6.18 so that the proper fix can be tested more thoroughly. We should remember that the 2.6.18 minus the warning is still going to be

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

2006-08-01 Thread Herbert Xu
On Tue, Aug 01, 2006 at 12:00:59AM -0700, David Miller wrote: I'm going to kill the warning for 2.6.18, using the patch below. We can queue up Patrick's changes for 2.6.19, just give me the word and I'll apply it to net-2.6.19 Thanks Dave. This should give us plenty of time to produce a

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

2006-08-01 Thread Patrick McHardy
Patrick McHardy wrote:--- [NETFILTER]: nf_queue: handle GSO packets Handle GSO packets in nf_queue by segmenting them before queueing to avoid breaking GSO in case they get mangled. While testing this patch I noticed that some meta-data is lost when segmenting packets. With the

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

2006-08-01 Thread Patrick McHardy
David Miller wrote: I'm going to kill the warning for 2.6.18, using the patch below. We can queue up Patrick's changes for 2.6.19, just give me the word and I'll apply it to net-2.6.19 Besides the problem I mentioned in the mail I just wrote everything looks good so far. I'll probably send

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

2006-08-01 Thread Herbert Xu
Hi Patrick: On Tue, Aug 01, 2006 at 09:19:34AM +0200, Patrick McHardy wrote: - nfct/nfctinfo/nfct_reasm: the xfrm output path does an immediate nf_reset, so they were not necessary until now. Queueing can happen on any hook, so we need to preserve them. - nf_bridge: needed for GSO on

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

2006-08-01 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Tue, 1 Aug 2006 17:23:58 +1000 - tc_verd/tc_index/input_dev: when directing a packet from a device supporting GSO to a device not supporting GSO using tc actions, these fields may be set. This doesn't look right though. GSO should occur just

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

2006-08-01 Thread Patrick McHardy
Herbert Xu wrote: - tc_verd/tc_index/input_dev: when directing a packet from a device supporting GSO to a device not supporting GSO using tc actions, these fields may be set. This doesn't look right though. GSO should occur just before hard_start_xmit (after all tc actions have taken

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

2006-08-01 Thread Herbert Xu
On Tue, Aug 01, 2006 at 12:36:14AM -0700, David Miller wrote: - tc_verd/tc_index/input_dev: when directing a packet from a device supporting GSO to a device not supporting GSO using tc actions, these fields may be set. This doesn't look right though. GSO should occur just

Re: [RFC 1/4] kevent: core files.

2006-08-01 Thread Ulrich Drepper
Herbert Xu wrote: The other to consider is that events don't come from the hardware. Events are written by the kernel. So if user-space is just reading the events that we've written, then there are no cache misses at all. Not quite true. The ring buffer can be written to from another

Re: [RFC 1/4] kevent: core files.

2006-08-01 Thread David Miller
From: Ulrich Drepper [EMAIL PROTECTED] Date: Tue, 01 Aug 2006 00:53:10 -0700 This is the case to keep in mind here. I thought Zach and the other involved in the discussions in Ottawa said this has been shown to be a problem and that a ring buffer implementation with something other than

Re: Linux TCP in the presence of delays or drops...

2006-08-01 Thread Ilpo Järvinen
On Mon, 31 Jul 2006, Oumer Teyeb wrote: -If multiple timeouts occur for one packet then even if we are using the timestamp option or FRTO TCP linux is not able to detect spurious retransmissions... and TCP linux is able to detect spurious retransmissions only for a single timeout for one

[take2 2/4] kevent: network AIO, socket notifications.

2006-08-01 Thread Evgeniy Polyakov
This patchset includes socket notifications and network asynchronous IO. Network AIO is based on kevent and works as usual kevent storage on top of inode. Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED] diff --git a/include/asm-i386/socket.h b/include/asm-i386/socket.h index 5755d57..d4d2f5c

[take2 3/4] kevent: AIO, aio_sendfile() implementation.

2006-08-01 Thread Evgeniy Polyakov
This patch includes asynchronous propagation of file's data into VFS cache and aio_sendfile() implementation. Network aio_sendfile() works lazily - it asynchronously populates pages into the VFS cache (which can be used for various tricks with adaptive readahead) and then uses usual -sendfile()

[take2 0/4] kevent: introduction.

2006-08-01 Thread Evgeniy Polyakov
I send this patchset for comments and review, it still contains AIO and aio_sendfile() implementation on top of get_block() abstraction, which was decided to postpone for a while (it is simpler right now to generate patchset as a whole, when kevent will be ready for merge, I will generate

[take2 1/4] kevent: core files.

2006-08-01 Thread Evgeniy Polyakov
This patch includes core kevent files: - userspace controlling - kernelspace interfaces - initialization - notification state machines It might also inlclude parts from other subsystem (like network related syscalls, so it is possible that it will not compile without other patches applied).

[take2 4/4] kevent: poll/select() notifications. Timer notifications.

2006-08-01 Thread Evgeniy Polyakov
This patch includes generic poll/select and timer notifications. kevent_poll works simialr to epoll and has the same issues (callback is invoked not from internal state machine of the caller, but through process awake). Timer notifications can be used for fine grained per-process time

Re: [RFC] gre: transparent ethernet bridging

2006-08-01 Thread Philip Craig
Stephen Hemminger wrote: I am not against making the bridge code smarter to handle other encapsulation. Do you mean something like this patch? The only drawback I see for this approach is that it means you can only encapsulate the ethernet header if the gre interface is bridged. That's not

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-08-01 Thread Christoph Hellwig
On Mon, Jul 31, 2006 at 01:51:31PM -0700, Michael Wu wrote: On Monday 31 July 2006 13:31, John W. Linville wrote: As usual I'll depend on Jiri to merge d80211 stack patches, then send me a pull request. If I apply your Switch drivers to d80211 series now, that will undoutedly cause a

e1000 speed/duplex error

2006-08-01 Thread a1
I'm trying to set my nic to force 100Mb/FD, but I'm constantly getting 100/HD on other side of the link. The command is: ethtool -s eth0 speed 100 duplex full autoneg off e1000 driver version 7.1.9 (latest) downloaded from sourceforge. Are there any problems? -- alkot

Re: e1000 speed/duplex error

2006-08-01 Thread Jeff Kirsher
On 8/1/06, a1 [EMAIL PROTECTED] wrote: I'm trying to set my nic to force 100Mb/FD, but I'm constantly getting 100/HD on other side of the link. The command is: ethtool -s eth0 speed 100 duplex full autoneg off e1000 driver version 7.1.9 (latest) downloaded from sourceforge. What are you

Re: Regarding offloading IPv6 addrconf and ndisc

2006-08-01 Thread Hugo Santos
David, So all of you userland control-plane fanatics, how will you handle things like NFS root with these daemon-required variants of NDISC and ARP? Do it in the initial ramdisk, we only need the daemon to setup the NDISC entries to talk to the NFS server. :-) There is obviously a

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

2006-08-01 Thread Herbert Xu
On Tue, Aug 01, 2006 at 09:19:34AM +0200, Patrick McHardy wrote: - nfct/nfctinfo/nfct_reasm: the xfrm output path does an immediate nf_reset, so they were not necessary until now. Queueing can happen on any hook, so we need to preserve them. This looks OK to me. However, we should do

Re: Linux TCP in the presence of delays or drops...

2006-08-01 Thread Oumer Teyeb
Thanks Ilpo for the info! I am trying out the tests now using timestamps only and without FRTO, and vice versa and see if there is any change. Actually, I have also noticed in some of the traces also this behaviour of FRTO where it mistook a loss as spurious which leads to further performance

Re: Regarding offloading IPv6 addrconf and ndisc

2006-08-01 Thread Hugo Santos
David, To drive this home even more, I do not believe that the people who advocate pushing NDISC and ARP policy into userspace would be very happy if something like the RAID transformations were moved into userspace and they were not able to access their disks if the RAID transformer process

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

2006-08-01 Thread Jamal Hadi Salim
On Tue, 2006-01-08 at 17:45 +1000, Herbert Xu wrote: On Tue, Aug 01, 2006 at 12:36:14AM -0700, David Miller wrote: - tc_verd/tc_index/input_dev: when directing a packet from a device supporting GSO to a device not supporting GSO using tc actions, these fields may be set.

Re[2]: e1000 speed/duplex error

2006-08-01 Thread a1
He, Jeff. Thank for quick reply. JK On 8/1/06, a1 [EMAIL PROTECTED] wrote: I'm trying to set my nic to force 100Mb/FD, but I'm constantly getting 100/HD on other side of the link. The command is: ethtool -s eth0 speed 100 duplex full autoneg off e1000 driver version 7.1.9 (latest)

Re: Linville's L2 rant... -- Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-08-01 Thread John W. Linville
On Mon, Jul 31, 2006 at 09:39:08PM -0400, Jamal Hadi Salim wrote: On Mon, 2006-31-07 at 08:30 -0400, John W. Linville wrote: Do we hold the view that our L2 code is on par with the rest of our code? Is there an appetite for a clean-up? Or is it just me? /rant If you made it this

Re: Regarding offloading IPv6 addrconf and ndisc

2006-08-01 Thread Hugo Santos
Jamal, nice to know ;- At least you can protect some apps if you need to. Only racoon and quagga are important for me. But what happens then if you have a beast that just chews memory forever? I suppose other poor apps will just get shot. You should push QoS and differentiation into the

Re: e1000 speed/duplex error

2006-08-01 Thread Andy Gospodarek
On Tue, Aug 01, 2006 at 04:03:28PM +0400, a1 wrote: He, Jeff. Thank for quick reply. JK On 8/1/06, a1 [EMAIL PROTECTED] wrote: I'm trying to set my nic to force 100Mb/FD, but I'm constantly getting 100/HD on other side of the link. The command is: ethtool -s eth0 speed 100

Re[4]: e1000 speed/duplex error

2006-08-01 Thread a1
Hi, Jeff. JK OPTION 2: Turn auto-negotiate on the e1000 card and tell it to only JK advertise 100 Full Duplex. This will allow negotiation between the JK two lnk partners and the e1000 will advertise that it is only able to JK do 100 Full duplex. Is there any way i could do this with ethtool?

Re: Re[2]: e1000 speed/duplex error

2006-08-01 Thread Jamal Hadi Salim
On Tue, 2006-01-08 at 16:03 +0400, a1 wrote: I thought the common behavior is that if one side force any particular parameter, other side should sense that and go to that mode too. You _cannot_ depend on that behavior at all. IOW, if one side is not forced the other side's setting is

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-08-01 Thread John W. Linville
On Tue, Aug 01, 2006 at 10:56:50AM +0100, Christoph Hellwig wrote: On Mon, Jul 31, 2006 at 01:51:31PM -0700, Michael Wu wrote: On Monday 31 July 2006 13:31, John W. Linville wrote: As usual I'll depend on Jiri to merge d80211 stack patches, then send me a pull request. If I apply your

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

2006-08-01 Thread Herbert Xu
On Mon, Jul 31, 2006 at 08:36:58PM +0200, Patrick McHardy wrote: [NETFILTER]: Get rid of HW checksum invalidation Signed-off-by: Patrick McHardy [EMAIL PROTECTED] It all looks great except for the csum update function. diff --git a/net/netfilter/core.c b/net/netfilter/core.c index

Re: [PATCH 2/2] forcedeth: mac address corrected

2006-08-01 Thread Andy Gospodarek
On Mon, Jul 31, 2006 at 12:05:01PM -0400, Ayaz Abdulla wrote: This patch will correct the mac address and set a flag to indicate that it is already corrected in case nv_probe is called again. For example, when you use kexec to restart the kernel. Signed-Off-By: Ayaz Abdulla [EMAIL

Re: Linville's L2 rant... -- Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-08-01 Thread Jamal Hadi Salim
On Tue, 2006-01-08 at 08:08 -0400, John W. Linville wrote: [..] There is no doubt that we need to be able to do all three (vlan, bridge, bond) at once. I'm just not convinced we need to support stacking them in every conceivable order. In theory there should be no issues stacking netdevices

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

2006-08-01 Thread Herbert Xu
On Tue, Aug 01, 2006 at 08:00:48AM -0400, Jamal Hadi Salim wrote: - tc_verd/tc_index/input_dev: when directing a packet from a device supporting GSO to a device not supporting GSO using tc actions, these fields may be set. This doesn't look right though. GSO should

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

2006-08-01 Thread Jamal Hadi Salim
On Tue, 2006-01-08 at 22:34 +1000, Herbert Xu wrote: What I'd like to know is do we really need to preserve tc_verd/tc_index/input_dev for a packet crossing loopback's xmit function? My instinctive reaction is to say no. Heres a (slightly complex) example: -- eth0(GSO ON) --- lo

Re: neigh_lookup lockdep bug.

2006-08-01 Thread Arjan van de Ven
On Mon, 2006-07-31 at 14:02 -0700, David Miller wrote: From: Dave Jones [EMAIL PROTECTED] Date: Mon, 31 Jul 2006 16:50:04 -0400 2.6.18rc2-gitSomething on my firewall box just triggered this.. Lockdep is perhaps confused. [515613.904945] swapper/0 is trying to acquire lock:

Re: [PATCH 2/2] forcedeth: mac address corrected

2006-08-01 Thread Andy Gospodarek
On Tue, Aug 01, 2006 at 08:27:27AM -0400, Andy Gospodarek wrote: On Mon, Jul 31, 2006 at 12:05:01PM -0400, Ayaz Abdulla wrote: This patch will correct the mac address and set a flag to indicate that it is already corrected in case nv_probe is called again. For example, when you use kexec

Re: [take2 1/4] kevent: core files.

2006-08-01 Thread James Morris
On Tue, 1 Aug 2006, Evgeniy Polyakov wrote: + u-ready_num = 0; +#ifdef CONFIG_KEVENT_USER_STAT + u-wait_num = u-im_num = u-total = 0; +#endif Generally, #ifdefs in the body of the kernel code are discouraged. Can you abstract these out as static inlines? - James -- James Morris

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-08-01 Thread Jiri Benc
On Tue, Aug 01, 2006 at 10:56:50AM +0100, Christoph Hellwig wrote: NACK again. Driver should continue to use the ieee80211.h header forever. When a patch that renames constants in d80211 is merged and d80211 stack is moved to ieee80211/ directory, there will be only slight changes (if any)

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-08-01 Thread John W. Linville
On Tue, Aug 01, 2006 at 03:58:37PM +0200, Jiri Benc wrote: Do you have a plan when you will merge rt2x00 patches so I can apply Michael's renaming patch(es) without risk of conflicts? Working on it ~now. I hit a snag in that Ivo's patches seem to rely on his radio button patch, which I had

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-08-01 Thread Ivo Van Doorn
Hi, Do you have a plan when you will merge rt2x00 patches so I can apply Michael's renaming patch(es) without risk of conflicts? Working on it ~now. I hit a snag in that Ivo's patches seem to rely on his radio button patch, which I had ignored until now. I'll probably pull that in this

Re: e1000 speed/duplex error

2006-08-01 Thread Auke Kok
Jeff Kirsher wrote: On 8/1/06, a1 [EMAIL PROTECTED] wrote: Hi, Jeff. JK OPTION 2: Turn auto-negotiate on the e1000 card and tell it to only JK advertise 100 Full Duplex. This will allow negotiation between the JK two lnk partners and the e1000 will advertise that it is only able to JK do 100

Re: Runtime power management for network interfaces

2006-08-01 Thread David Brownell
On Monday 31 July 2006 9:17 am, Stephen Hemminger wrote: On Tue, 25 Jul 2006 11:59:52 -0400 (EDT) Alan Stern [EMAIL PROTECTED] wrote: During a Power Management session at the Ottawa Linux Symposium, it was generally agreed that network interface drivers ought to automatically suspend

E1000: bug on error path in e1000_probe()

2006-08-01 Thread Stephane Doyon
Hi, The e1000_probe() function passes references to the netdev structure before it's actually registered. In the (admittedly obscure) case where the netdev registration fails, we are left with a dangling reference. Specifically, e1000_probe() calls netif_carrier_off(netdev); before

Re: Runtime power management for network interfaces

2006-08-01 Thread Lennert Buytenhek
On Mon, Jul 31, 2006 at 09:17:28AM -0700, Stephen Hemminger wrote: During a Power Management session at the Ottawa Linux Symposium, it was generally agreed that network interface drivers ought to automatically suspend their devices (if possible) whenever: (1) The interface is

Re: [take2 1/4] kevent: core files.

2006-08-01 Thread Evgeniy Polyakov
On Tue, Aug 01, 2006 at 09:46:58AM -0400, James Morris ([EMAIL PROTECTED]) wrote: On Tue, 1 Aug 2006, Evgeniy Polyakov wrote: + u-ready_num = 0; +#ifdef CONFIG_KEVENT_USER_STAT + u-wait_num = u-im_num = u-total = 0; +#endif Generally, #ifdefs in the body of the kernel code are

Re: [take2 1/4] kevent: core files.

2006-08-01 Thread James Morris
On Tue, 1 Aug 2006, Evgeniy Polyakov wrote: On Tue, Aug 01, 2006 at 09:46:58AM -0400, James Morris ([EMAIL PROTECTED]) wrote: On Tue, 1 Aug 2006, Evgeniy Polyakov wrote: + u-ready_num = 0; +#ifdef CONFIG_KEVENT_USER_STAT + u-wait_num = u-im_num = u-total = 0; +#endif

Re: [take2 1/4] kevent: core files.

2006-08-01 Thread Evgeniy Polyakov
On Tue, Aug 01, 2006 at 10:27:36AM -0400, James Morris ([EMAIL PROTECTED]) wrote: + u-ready_num = 0; +#ifdef CONFIG_KEVENT_USER_STAT + u-wait_num = u-im_num = u-total = 0; +#endif Generally, #ifdefs in the body of the kernel code are discouraged. Can you

Re: [IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls

2006-08-01 Thread Andrew Morton
On Mon, 31 Jul 2006 19:04:33 +1000 Herbert Xu [EMAIL PROTECTED] wrote: 2) There is something broken in the x86_64 unwind code which is causing it to panic just about everytime somebody calls dump_stack(). Andi, this is the second time I've seen a report where an otherwise harmless

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

2006-08-01 Thread Phil Oester
On Tue, Aug 01, 2006 at 12:00:59AM -0700, David Miller wrote: What we have now is infinitely better than the past, wherein all TSO packets were dropped due to corrupt checksums as soon at the NAT module was loaded. At what point did this problem begin? 2.6.18-rc or prior? Phil -

Re: Runtime power management for network interfaces

2006-08-01 Thread Stephen Hemminger
On Mon, 31 Jul 2006 17:29:41 -0700 David Brownell [EMAIL PROTECTED] wrote: On Monday 31 July 2006 9:17 am, Stephen Hemminger wrote: On Tue, 25 Jul 2006 11:59:52 -0400 (EDT) Alan Stern [EMAIL PROTECTED] wrote: During a Power Management session at the Ottawa Linux Symposium, it was

Re: [DSCAPE] rate_control needs some form of reference counting

2006-08-01 Thread Jiri Benc
On Tue, 1 Aug 2006 17:16:32 +0200, Karol Lewandowski wrote: Without that ieee80211_register_hw was returning value from previous check: I missed that. Thanks for spotting this. This fixes that oops. Problem remains, though. I suppose that oops would happen anyway if someone would do:

Re: Linville's L2 rant... -- Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-08-01 Thread Ben Greear
Jamal Hadi Salim wrote: On Tue, 2006-01-08 at 08:08 -0400, John W. Linville wrote: [..] There is no doubt that we need to be able to do all three (vlan, bridge, bond) at once. I'm just not convinced we need to support stacking them in every conceivable order. In theory there should be no

Re: Linville's L2 rant... -- Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-08-01 Thread Ben Greear
John W. Linville wrote: On Mon, Jul 31, 2006 at 09:39:08PM -0400, Jamal Hadi Salim wrote: On Mon, 2006-31-07 at 08:30 -0400, John W. Linville wrote: Do we hold the view that our L2 code is on par with the rest of our code? Is there an appetite for a clean-up? Or is it just me? /rant If

Re: Linville's L2 rant... -- Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-08-01 Thread John W. Linville
On Tue, Aug 01, 2006 at 08:33:34AM -0400, Jamal Hadi Salim wrote: On Tue, 2006-01-08 at 08:08 -0400, John W. Linville wrote: And, I think that a reconsideration of all three functions as a group could lead to better/cleaner functionality with easier support for extension (e.g. 802.1s).

Re: Linville's L2 rant... -- Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-08-01 Thread John W. Linville
On Tue, Aug 01, 2006 at 09:10:06AM -0700, Ben Greear wrote: Jamal Hadi Salim wrote: Agreed. I have some very strong opinions on this subject that i could share with you if you want. For example, IMO, I think it would be a lot reasonable to assume that a VLAN or VLANS are attributes of a

Re: Linville's L2 rant... -- Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-08-01 Thread Ben Greear
John W. Linville wrote: On Tue, Aug 01, 2006 at 09:10:06AM -0700, Ben Greear wrote: Jamal Hadi Salim wrote: Agreed. I have some very strong opinions on this subject that i could share with you if you want. For example, IMO, I think it would be a lot reasonable to assume that a VLAN or

Re: e1000 speed/duplex error

2006-08-01 Thread Rick Jones
I thought the common behavior is that if one side force any particular parameter, other side should sense that and go to that mode too. Nope. That is a common misconception and perhaps the source of many duplex mismatch problems today. Here is some boilerplate I bring-out from time to time

[PATCH] IPv6: only set err in rawv6_bind() when necessary

2006-08-01 Thread Brian Haley
The variable 'err' is set in rawv6_bind() before the address check fails instead of after, moved inside if() statement. Signed-off-by: Brian Haley [EMAIL PROTECTED] diff --git a/net/ipv6/raw.c b/net/ipv6/raw.c index 8a30cd8..072b28b 100644 --- a/net/ipv6/raw.c +++ b/net/ipv6/raw.c @@ -240,10

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-08-01 Thread John W. Linville
On Tue, Aug 01, 2006 at 04:25:05PM +0200, Ivo Van Doorn wrote: Hi, Do you have a plan when you will merge rt2x00 patches so I can apply Michael's renaming patch(es) without risk of conflicts? Working on it ~now. I hit a snag in that Ivo's patches seem to rely on his radio button patch,

Re: e1000 speed/duplex error

2006-08-01 Thread Jeff Kirsher
On 8/1/06, Auke Kok [EMAIL PROTECTED] wrote: Jeff Kirsher wrote: On 8/1/06, a1 [EMAIL PROTECTED] wrote: Hi, Jeff. JK OPTION 2: Turn auto-negotiate on the e1000 card and tell it to only JK advertise 100 Full Duplex. This will allow negotiation between the JK two lnk partners and the e1000

Re: Linville's L2 rant... -- Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-08-01 Thread Ben Greear
John W. Linville wrote: I'm just not sure that cleverness is worth the headache, especially since the most clever things usually only work by accident... Or, work by solid, modular design and small tweaks! Point taken. But stashing little hacks in the networking core for specific virtual

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-08-01 Thread Ivo van Doorn
On Tuesday 01 August 2006 19:11, John W. Linville wrote: On Tue, Aug 01, 2006 at 04:25:05PM +0200, Ivo Van Doorn wrote: Hi, Do you have a plan when you will merge rt2x00 patches so I can apply Michael's renaming patch(es) without risk of conflicts? Working on it ~now. I hit a

Re: [RFC 1/4] kevent: core files.

2006-08-01 Thread Zach Brown
I do not think if we do a ring buffer that events should be obtainable via a syscall at all. Rather, I think this system call should be purely sleep until ring is not empty. Mmm, yeah, of course. That's much simpler. I'm looking forward to Evgeniy's next patch set. The ring buffer size,

Re: [IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls

2006-08-01 Thread Andi Kleen
On Tuesday 01 August 2006 16:41, Andrew Morton wrote: On Mon, 31 Jul 2006 19:04:33 +1000 Herbert Xu [EMAIL PROTECTED] wrote: 2) There is something broken in the x86_64 unwind code which is causing it to panic just about everytime somebody calls dump_stack(). Andi, this is the second

[patch] RFC: matching interface groups

2006-08-01 Thread Balazs Scheidler
Hi, I would like to easily match a set of dynamically created interfaces from my packet filter rules. The attached patch forms the basis of my implementation and I would like to know whether something like this is mergeable to mainline. The use-case is as follows: * I have two different

Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

2006-08-01 Thread Scott Murray
On Tue, 1 Aug 2006, Steve Glendinning wrote: Attached is a driver patch for SMSC911x family of ethernet chips, generated against 2.6.18-rc1 sources. There's a similar driver in the tree; this one has been tested by SMSC on all flavors of the chip and claimed to be efficient. Updated after

Re: [patch] RFC: matching interface groups

2006-08-01 Thread Phil Oester
On Tue, Aug 01, 2006 at 07:10:09PM +0200, Balazs Scheidler wrote: Each interface can belong to a single group at a time, an interface comes up without being a member in any of the groups. Userspace can assign interfaces to groups after being created, this would typically be performed in

Re: E1000: bug on error path in e1000_probe()

2006-08-01 Thread Auke Kok
Stephane Doyon wrote: The e1000_probe() function passes references to the netdev structure before it's actually registered. In the (admittedly obscure) case where the netdev registration fails, we are left with a dangling reference. Specifically, e1000_probe() calls

[PATCH 1/5] d80211: make sleeping in hw-config possible

2006-08-01 Thread Jiri Benc
This patch makes sleeping in the hw-config callback possible by removing the only atomic caller. The atomic caller was a timer and is replaced by a workqueue. This is based on a patch from Michael Buesch [EMAIL PROTECTED]. Signed-off-by: Jiri Benc [EMAIL PROTECTED] --- net/d80211/ieee80211.c

[PATCH 2/5] d80211: return correct error codes for scan requests

2006-08-01 Thread Jiri Benc
Do not allow scanning when the network interface is down. Return 0 instead of -EBUSY when scanning is in progress on the same network interface. Signed-off-by: Jiri Benc [EMAIL PROTECTED] --- net/d80211/ieee80211_ioctl.c |6 ++ net/d80211/ieee80211_sta.c |5 - 2 files

Re: [PATCH dscape] d80211: Switch d80211.h to IEEE80211_ style names

2006-08-01 Thread Ulrich Kunitz
On 06-08-01 15:58 Jiri Benc wrote: pointing non-migrated drivers (ipw2[12]00, zd1211rw) at the old code, Yes. Rather than moving, zd1211 should be ported to d80211 - this will also allow using of more advanced features of the hw. I have currently no idea, when this will happen. Currently

[PATCH 3/5] d80211: return correct value when loading of rate control module fails

2006-08-01 Thread Jiri Benc
From: Karol Lewandowski [EMAIL PROTECTED] When loading of rate_control module fails, ieee80211_register_hw returns value from previous check. This patch fixes that. Signed-off-by: Jiri Benc [EMAIL PROTECTED] --- net/d80211/ieee80211.c |3 ++- 1 files changed, 2 insertions(+), 1

Re: E1000: bug on error path in e1000_probe()

2006-08-01 Thread Stephane Doyon
On Tue, 1 Aug 2006, Auke Kok wrote: Stephane Doyon wrote: The e1000_probe() function passes references to the netdev structure before it's actually registered. In the (admittedly obscure) case where the netdev registration fails, we are left with a dangling reference. Specifically,

Re: [PATCH] SMSC LAN911x and LAN921x vendor driver

2006-08-01 Thread Steve . Glendinning
Hi Scott Sorry to be coming in late, but I'm curious about why this work is being submitted as a separate driver, rather than as patches against the driver from Dustin McIntire that was added a few months ago. Is the intention to go forward with two different drivers for these chips? I

Re: Linville's L2 rant... -- Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-08-01 Thread Krzysztof Halasa
Ben Greear [EMAIL PROTECTED] writes: Basically, my point is that if VLANs are true devices, they will just work with all of the user-space protocols and they will easily handle abstractions such as bridges, (multiple) IP addresses, MAC addresses, net-filter, and all the rest. AOL mode I

[PATCH] ipv4: don't call upper-layer disconnect function if not connected

2006-08-01 Thread Brian Haley
Calling connect() with AF_UNSPEC will disconnect a socket, but we don't need to do any work if the socket isn't currently connected. Signed-off-by: Brian Haley [EMAIL PROTECTED] diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index c84a320..b294b92 100644 --- a/net/ipv4/af_inet.c +++

Re: [PATCH] NET: fix kernel panic from no dev-hard_header_len space

2006-08-01 Thread Alexey Kuznetsov
Hello! Alexey, any suggestions on how to handle this kind of thing? Device, which adds something at head must check for space. Anyone, who adds something at head, must check. Otherwise, it will remain buggy forever. What's wrong with my patch? As I already said there is nothing wrong with

Re: [PATCH] NET: fix kernel panic from no dev-hard_header_len space

2006-08-01 Thread Alexey Kuznetsov
Hello! Do the semantics (I'm not talking about bugs) allow skb passed to dev-hard_header() (if defined) No. dev-hard_header() should get enough of space, which is dev-hard_header_len. Actually, it is historical hole in design, inherited from ancient times. Calling conventions of

[PATCH 5/6] zd1211rw: Fixed endianess issue with length info tag detection

2006-08-01 Thread Ulrich Kunitz
Discovered a problem while accessing www.python.org on my PPC32. The problem was pretty consistent for all sticks. The reason was that while testing for the length info tag, I ignored the endianess of the host system. Please recognize that converting the constant to little endian, we create

[PATCH 2/6] zd1211rw: Pass more management frame types up to host

2006-08-01 Thread Ulrich Kunitz
From: Daniel Drake [EMAIL PROTECTED] We'll be needing these at some point... Signed-off-by: Daniel Drake [EMAIL PROTECTED] Signed-off-by: Ulrich Kunitz [EMAIL PROTECTED] --- drivers/net/wireless/zd1211rw/zd_chip.h |4 +++- drivers/net/wireless/zd1211rw/zd_mac.c |6 -- 2 files

[PATCH 1/6] zd1211rw: Fixes radiotap header

2006-08-01 Thread Ulrich Kunitz
There has been a problem in the radiotap header. Monitor mode works now with tcpdump 3.94 + libpcap 0.9.4. ethereal 0.99.0 + libpcap 0.9.4 is broken, because it doesn't find the right offset for the IEEE 802.11 header. Signed-off-by: Ulrich Kunitz [EMAIL PROTECTED] ---

[PATCH 3/6] zd1211rw: Fix software encryption/decryption

2006-08-01 Thread Ulrich Kunitz
From: Daniel Drake [EMAIL PROTECTED] Apparently the ZD1211 doesn't mind, but the ZD1211B absolutely must be told that encryption is happening in software. Signed-off-by: Daniel Drake [EMAIL PROTECTED] Signed-off-by: Ulrich Kunitz [EMAIL PROTECTED] --- drivers/net/wireless/zd1211rw/zd_mac.c |

[PATCH] zd1211rw: six urgent upstream fixes

2006-08-01 Thread Ulrich Kunitz
Here are six fixes for the zd1211rw driver. They fix - radiotap issues for the monitor mode - WEP encryption - an endianess problem in the rx path - reassociation after disassociation be the AP If possible these patches should be included in 2.6.18 -- Uli - To unsubscribe from this list:

[PATCH 4/6] zd1211rw: Remove bogus assert

2006-08-01 Thread Ulrich Kunitz
From: Daniel Drake [EMAIL PROTECTED] This function is never called in interrupt context, and it doesn't matter if it is called in IRQ context or not. Signed-off-by: Daniel Drake [EMAIL PROTECTED] Signed-off-by: Ulrich Kunitz [EMAIL PROTECTED] --- drivers/net/wireless/zd1211rw/zd_usb.c |1 -

[PATCH 6/6] zd1211rw: Packet filter fix for managed (STA) mode

2006-08-01 Thread Ulrich Kunitz
I had problems with my AVM Fritz!Box access point. It appeared that the AP deauthorized me and the softmac didn't reconnect me. This patch handles the problem. Signed-off-by: Ulrich Kunitz [EMAIL PROTECTED] --- drivers/net/wireless/zd1211rw/zd_chip.c |4 ++--

Re: Regarding offloading IPv6 addrconf and ndisc

2006-08-01 Thread David Miller
From: Hugo Santos [EMAIL PROTECTED] Date: Tue, 1 Aug 2006 12:50:02 +0100 I might have some cycles during the month to code up something in this direction, at least for an initial review, i'll try to do so. Great. I prefer to talk about code anyways :) Also, the reliability of a

Re: Regarding offloading IPv6 addrconf and ndisc

2006-08-01 Thread David Miller
From: Hugo Santos [EMAIL PROTECTED] Date: Tue, 1 Aug 2006 13:00:03 +0100 Resiliency to failure is not something that depends on the kernel. If the code in question is in the kernel, and it crashes, how will you recover? Developer momentum means that the kernel is likely to get fixed

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

2006-08-01 Thread Herbert Xu
On Tue, Aug 01, 2006 at 08:34:05AM -0700, Phil Oester wrote: On Tue, Aug 01, 2006 at 12:00:59AM -0700, David Miller wrote: What we have now is infinitely better than the past, wherein all TSO packets were dropped due to corrupt checksums as soon at the NAT module was loaded.

Re: BUG: warning at net/core/dev.c:1171/skb_checksum_help() 2.6.18-rc3

2006-08-01 Thread Herbert Xu
On Mon, Jul 31, 2006 at 08:36:58PM +0200, Patrick McHardy wrote: diff --git a/net/netfilter/nf_queue.c b/net/netfilter/nf_queue.c index 662a869..df1f4e5 100644 --- a/net/netfilter/nf_queue.c +++ b/net/netfilter/nf_queue.c I presume we need similar patches for the old ipv4/ipv6 versions as

Re: [PATCH] IPv6: only set err in rawv6_bind() when necessary

2006-08-01 Thread David Miller
From: Brian Haley [EMAIL PROTECTED] Date: Tue, 01 Aug 2006 13:06:03 -0400 The variable 'err' is set in rawv6_bind() before the address check fails instead of after, moved inside if() statement. Signed-off-by: Brian Haley [EMAIL PROTECTED] This is a common C idiom in the kernel:

Re: [PATCH] ipv4: don't call upper-layer disconnect function if not connected

2006-08-01 Thread David Miller
From: Brian Haley [EMAIL PROTECTED] Date: Tue, 01 Aug 2006 15:48:54 -0400 Calling connect() with AF_UNSPEC will disconnect a socket, but we don't need to do any work if the socket isn't currently connected. Signed-off-by: Brian Haley [EMAIL PROTECTED] The socket could have been bind()'d

[RFC 1/3] secid reconciliation on inbound

2006-08-01 Thread Venkat Yekkirala
Currently a packet accumulates multiple security identifiers, each of a different class, as it enters the system. This patch set reconciles these identifiers into a single identifier while also allowing LSM (SELinux is addressed in this patch set) to impose flow control checks based on the

[RFC 3/3] secid reconciliation on inbound: core networking changes

2006-08-01 Thread Venkat Yekkirala
Invoke the skb_policy_check LSM hook from within networking code. This is being done at the same time and as a part of checking xfrm policy. This is hopefully adequate (not anticipating IP protos that don't use xfrm). Signed-off-by: Venkat Yekkirala [EMAIL PROTECTED] --- xfrm.h | 50

Re: [RFC 2/3] secid reconciliation on inbound: add LSM hooks

2006-08-01 Thread James Morris
On Tue, 1 Aug 2006, Venkat Yekkirala wrote: - if (err) - goto out; + /* if (err) */ + /* goto out; */ - err = selinux_xfrm_sock_rcv_skb(sksec-sid, skb, ad); -out: + /* err = selinux_xfrm_sock_rcv_skb(sksec-sid, skb, ad); */ +out: return err;

Re: [RFC 1/3] secid reconciliation on inbound

2006-08-01 Thread James Morris
On Tue, 1 Aug 2006, Venkat Yekkirala wrote: +#define PACKET__COME_THRU 0x0008UL +#define PACKET__GO_THRU 0x0010UL These names seem awkward, and do we really need a separate perm for each direction? - James -- James Morris [EMAIL

[PATCH] Fix more per-cpu typos

2006-08-01 Thread Alexey Dobriyan
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- arch/x86_64/kernel/smp.c |2 +- include/net/netdma.h |2 +- net/core/dev.c |4 ++-- net/ipv4/tcp.c |2 +- 4 files changed, 5 insertions(+), 5 deletions(-) --- a/arch/x86_64/kernel/smp.c +++

  1   2   >