[RFC][PATCH -mm] Add genetlink utilities for payload length calculation

2006-09-11 Thread Balbir Singh
Add two utility helper functions genlmsg_msg_size() and genlmsg_total_size(). These functions are derived from their netlink counterparts. Signed-off-by: Balbir Singh [EMAIL PROTECTED] --- include/net/genetlink.h | 18 ++ 1 files changed, 18 insertions(+) diff -puN

[RFC][PATCH -mm] Fix getdelays.c - cpumask length and error reporting.

2006-09-11 Thread Balbir Singh
Fix the length passed while (un)registering cpumask. We were passing sizeof the array, make it strlen(). Error value printed in fatal errors should be derived from the message. The message contains an nlmsgerr embedded with an error value. We must report that value to the user. Signed-off-by:

[RFC][PATCH -mm] Fix taskstats size calculation (use the new genetlink utility functions)

2006-09-11 Thread Balbir Singh
The addition of the CSA patch pushed the size of struct taskstats to 256 bytes. This exposed a problem with prepare_reply(), we were not allocating space for the netlink and genetlink header. It worked earlier because alloc_skb() would align the skb to SMP_CACHE_BYTES, which added some additonal

Re: TG3 data corruption (TSO ?)

2006-09-11 Thread Benjamin Herrenschmidt
Ok, it seems like we might have more than just the missing barrier in TG3. Possibly some IOMMU problems on some machines as well. Unfortunately, I don't have a tg3 on a PCI-X or PCI-E card to test on a pSeries or some other machine. [Olof: I've disabled the new U4 DART invalidate code (reverted

Re: [RFC] Alternate WE-21 support (core API)

2006-09-11 Thread Johannes Berg
On Fri, 2006-09-08 at 09:13 -0700, Jean Tourrilhes wrote: And I don't believe nl80211 will address legacy driver and non-802.11 hardware. It'd help if you'd tell me what in WE specifically addresses non-802.11 legacy hardware. I don't really see anything that is completely orthogonal. johannes

Re: r8168, 2.6.17 et r8169.c

2006-09-11 Thread Corentin CHARY
With the 2.6.17 Patchs : xfport /usr/src/linux # insmod drivers/net/r8169.ko xfport /usr/src/linux # dmesg | tail r8169 Gigabit Ethernet driver 2.2LK loaded ACPI: PCI Interrupt :02:00.0[A] - GSI 16 (level, low) - IRQ 16 PCI: Setting latency timer of device :02:00.0 to 64 eth0:

Re: tiacx module fail

2006-09-11 Thread Carlos Martínn Nieto
On Sun, Sep 10, 2006 at 01:25:52PM +0200, VinX wrote: Hi, i have a little problem with dlink dwl650+ pcmcia. After I downloaded wireless-2.6.git with cogito, compiled, rebooted my laptop and loaded the acx_pci module. But my pcmcia don't work. If i give this command line: # iwlist scanning

Re: [PATCH 1/2] pcnet32: NAPI implementation

2006-09-11 Thread Jeff Garzik
Don Fry wrote: Implement NAPI changes to pcnet32 driver. Compile default is off. Listed as experimental. Len and Don both worked on a NAPI implementation and have both tested these changes. An e1000 blasting short packets to the pcnet32 will lockup Don's system until the receive storm

Re: [PATCH] Fix dm9000 release_resource

2006-09-11 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] skge: heck for PCI hotplug during IRQ

2006-09-11 Thread Jeff Garzik
applied - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2.6.17 0/9] NetXen: 1G/10G Ethernet Driver

2006-09-11 Thread Jeff Garzik
email me an all-in-one-patch, please. Jeff - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] sky2: tx pause bug fix

2006-09-11 Thread Jeff Garzik
Stephen Hemminger wrote: Fix problems with transmit pause frames. The driver was telling the GMAC to flush (not process) pause frames. Manually disabling pause wasn't working because of problems in the setup. This maybe the cause of the lockup under load.

Re: tiacx module fail

2006-09-11 Thread VinX
RE-POST... The dmesg with tiacx module is: -- snip acx: form factor 0x01 ((mini-)PCI / CardBus), radio type 0x0D (Maxim), EEPROM version 0x00, uploaded firmware 'Rev 1.9.10.0_A4' (0x01030505) creating /proc entry driver/acx_eth1 creating /proc entry driver/acx_eth1_diag creating /proc entry

Re: tiacx module fail

2006-09-11 Thread VinX
Carlos Martínn Nieto wrote: The error message says it is trying to scan with eth1, but the driver log says the card is on wlan0. Try doing `iwlist wlan0 scan`. That should work. No. The first dmesg is about tiacx module, this module set the name of my wireless card as eth1, but with acx

RE: LRO fix needed

2006-09-11 Thread Ananda Raju
Hi I was on leave for 3 weeks so couldn't answer to Questions. Current s2io driver won't use any hardware assistance for LRO. Present hardware Xframe-I and Xframe-II provides header separation functionality which can be used for LRO but not in use. Our next generation hardware will have more

Re: [Devel] Re: [RFC] network namespaces

2006-09-11 Thread Daniel Lezcano
Dmitry Mishin wrote: On Friday 08 September 2006 22:11, Herbert Poetzl wrote: actually the light-weight ip isolation runs perfectly fine _without_ CAP_NET_ADMIN, as you do not want the guest to be able to mess with the 'configured' ips at all (not to speak of interfaces here) It was only an

Re: [Devel] Re: [RFC] network namespaces

2006-09-11 Thread Herbert Poetzl
On Mon, Sep 11, 2006 at 04:40:59PM +0200, Daniel Lezcano wrote: Dmitry Mishin wrote: On Friday 08 September 2006 22:11, Herbert Poetzl wrote: actually the light-weight ip isolation runs perfectly fine _without_ CAP_NET_ADMIN, as you do not want the guest to be able to mess with the

Re: [Devel] Re: [RFC] network namespaces

2006-09-11 Thread Daniel Lezcano
Herbert Poetzl wrote: On Mon, Sep 11, 2006 at 04:40:59PM +0200, Daniel Lezcano wrote: I am currently working on this and I am finishing a prototype bringing isolation at the ip layer. The prototype code is very closed to Andrey's patches at TCP/UDP level. So the next step is to merge the

Re: [Devel] Re: [RFC] network namespaces

2006-09-11 Thread Dmitry Mishin
On Monday 11 September 2006 18:57, Herbert Poetzl wrote: I completely agree here, we need a separate namespace for that, so that we can combine isolation and virtualization as needed, unless the bind restrictions can be completely expressed with an additional mangle or filter table (as was

Re: [PATCH] FRV: do_gettimeofday() should no longer use tickadj

2006-09-11 Thread David Howells
Ingo Molnar [EMAIL PROTECTED] wrote: i cannot find Thomas' recent 2.6 one (Thomas, do you have a link to it?), but i did one 5 years ago: http://people.redhat.com/mingo/irq-rewrite-patches/irq-cleanup-2.4.15-B1.bz2 in general it's a large but otherwise pretty dumb patch. I wrote my own

[PATCH 0/3] pcnet32: reorg, NAPI, and cleanup

2006-09-11 Thread Don Fry
These patches to the pcnet32 driver implement NAPI and respond to some other suggestions found during NAPI development and testing. The NAPI code change was broken into two pieces, one is code-reorganization, and the second is the NAPI implementation. Tested with and without NAPI ia32 and ppc64

[PATCH 1/3] pcnet32: reorganize interrupt, tx, and rx processing

2006-09-11 Thread Don Fry
Reorganize code to facilitate NAPI changes. Tested ia32 and ppc64. Signed-off-by: Don Fry [EMAIL PROTECTED] --- linux-2.6.18-rc6/drivers/net/pcnet32.c.orig Fri Sep 8 14:02:12 2006 +++ linux-2.6.18-rc6/drivers/net/pcnet32.c Mon Sep 11 09:07:13 2006 @@ -299,7 +299,6 @@ static int

[PATCH 2/3] pcnet32: NAPI implementation

2006-09-11 Thread Don Fry
Implement NAPI changes to pcnet32 driver. Compile default is off. Listed as experimental. Len and Don both worked on a NAPI implementation and have both tested these changes. An e1000 blasting short packets to the pcnet32 will lockup Don's system until the receive storm stops. Without NAPI

[PATCH] pcnet32: Magic number cleanup

2006-09-11 Thread Don Fry
Initial magic number cleanup. Delete one unnecessary read and write. Tested ia32 and ppc64. Signed-off-by: Don Fry [EMAIL PROTECTED] --- linux-2.6.18-rc6/drivers/net/pcnet32.c.napi Fri Sep 8 14:04:47 2006 +++ linux-2.6.18-rc6/drivers/net/pcnet32.c Fri Sep 8 14:05:09 2006 @@ -213,7 +213,7

Re: [PATCH 1/3] [IrDA] af_irda.c cleanups

2006-09-11 Thread Jean Tourrilhes
On Mon, Sep 11, 2006 at 08:46:36AM +0300, Samuel Ortiz wrote: Hi Dave, We lock the socket when both releasing and getting a disconnected notification. In the latter case, we also ste the socket as orphan. This fixes a potential kernel bug that can be triggered when we get the disconnection

tg3 driver timeout problems

2006-09-11 Thread sunny12
Hi, we're experiencing serious problems on an productions system running fecora core5 ( 2.6.17-1.2157_FC5smp #1) and running the tg3 driver. Here is my dmesg output: tg3.c:v3.59 (June 8, 2006) ACPI: PCI Interrupt :02:00.0[A] - GSI 16 (level, low) - IRQ 169 PCI: Setting latency timer of

Re: [PATCH] bcm43xx-softmac: Init, shutdown and restart fixes

2006-09-11 Thread John W. Linville
On Mon, Aug 21, 2006 at 04:52:58PM +0200, Michael Buesch wrote: On Monday 21 August 2006 16:43, Larry Finger wrote: @@ -3537,11 +3536,10 @@ static int bcm43xx_init_board(struct bcm err = bcm43xx_select_wireless_core(bcm, -1); if (err) goto err_crystal_off;

[PATCH] [ATM] he: Fix __init/__devinit conflict

2006-09-11 Thread Roland Dreier
he_init_one() is declared __devinit, but calls lots of init functions that are marked __init. However, if CONFIG_HOTPLUG is enabled, __devinit functions go into normal .text, which leads to WARNING: drivers/atm/he.o - Section mismatch: reference to .init.text: from .text between 'he_start'

Re: [PATCH] bcm43xx-softmac: Init, shutdown and restart fixes

2006-09-11 Thread Larry Finger
John W. Linville wrote: Either move bcm43xx_periodic_tasks_setup after rng_init, or delete the periodic work again, if rng_init fails. Larry, will you be posting another patch to account for these comments? Yes - coming right after this message. Larry - To unsubscribe from this list: send

[PATCH] Correct out of sequence initialization step for bcm43xx-softmac

2006-09-11 Thread Larry Finger
John, Please apply the following patch to wireless-2.6. It addresses Michael Buesch's comments, which I seem to have missed, regarding the previous patch entitled bcm43xx-softmac: Init, shutdown and restart fixes. My copy of the wireless-2.6 indicates that the original patch has already

Re: tiacx module fail

2006-09-11 Thread Carlos Martínn Nieto
Did you bring the interface up (ifconfig eth1 up)? It won't work before that because parts of the card haven't been initialised. IIRC, the tiacx module in wireless-2.6 uses softmac and we never managed to get it working properly. There is a version with the devicescape stack which seems to

Re: r8168, 2.6.17 et r8169.c

2006-09-11 Thread Francois Romieu
you try against 2.6.18-rc6: http://www.fr.zoreil.com/people/francois/misc/20060911-2.6.18-rc6-r8169-test.patch If the driver does not work, which in itself would be fairly disappointing, revert (patch -R) 0009 found in the 2.6.18-rc5 directory and try again. If the driver still does not work

Re: tg3 driver timeout problems

2006-09-11 Thread Michael Chan
On Mon, 2006-09-11 at 11:18 -0700, sunny12 wrote: A restart of the network using /etc/init.d/network restart does the trick and the device works again. I dont think this is related to the TSO problem reported earlier because I believe its disabled by default. TSO may be on by default on

Re: tiacx module fail

2006-09-11 Thread VinX
Carlos Martínn Nieto wrote: Did you bring the interface up (ifconfig eth1 up)? It won't work before that because parts of the card haven't been initialised. ok, now it seems to work! IIRC, the tiacx module in wireless-2.6 uses softmac and we never managed to get it working properly. There is

[PATCH 1/1] Remove more unnecessary driver printk's

2006-09-11 Thread Andy Gospodarek
As I promised last week, here is the first pass at removing all unnecessary printk's that exist in network device drivers currently in promiscuous mode. The duplicate messages are not needed so they have been removed. Some of these drivers are quite old and might not need an update, but I did

Re: tiacx module fail

2006-09-11 Thread Carlos Martín Nieto
On Mon, Sep 11, 2006 at 11:05:26PM +0200, VinX wrote: Carlos Martínn Nieto wrote: Did you bring the interface up (ifconfig eth1 up)? It won't work before that because parts of the card haven't been initialised. ok, now it seems to work! IIRC, the tiacx module in wireless-2.6 uses

Please pull 'upstream' branch of wireless-2.6

2006-09-11 Thread John W. Linville
The following changes since commit 34fa0e319c760189f1fc226acc5b3b387dc58099: John W. Linville: Merge branch 'upstream-fixes' into upstream are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream Christian Steineck:

Please pull 'upstream-fixes' branch of wireless-2.6

2006-09-11 Thread John W. Linville
The following changes since commit 38f5745c5a90641079fd5b48600ae63f7ab6edcd: Jack Steiner: [IA64] SN fix for cpu hotplug/kexec are found in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git upstream-fixes Ulrich Kunitz: zd1211rw:

Re: [RFC] network namespaces

2006-09-11 Thread Eric W. Biederman
Dmitry Mishin [EMAIL PROTECTED] writes: On Sunday 10 September 2006 06:47, Herbert Poetzl wrote: well, I think it would be best to have both, as they are complementary to some degree, and IMHO both, the full virtualization _and_ the isolation will require a separate namespace to work,

Re: [RFC] network namespaces

2006-09-11 Thread Eric W. Biederman
Dmitry Mishin [EMAIL PROTECTED] writes: On Monday 11 September 2006 18:57, Herbert Poetzl wrote: I completely agree here, we need a separate namespace for that, so that we can combine isolation and virtualization as needed, unless the bind restrictions can be completely expressed with an

Re: RFC/T: Possible fix for bcm43xx periodic work bug

2006-09-11 Thread Erik Mouw
On Fri, Sep 08, 2006 at 08:36:36AM -0500, Larry Finger wrote: Erik Mouw wrote: Thanks for the information, pulled wireless-2.6 and recompiling kernel. If this really fixes the problem, can we try to get it merged before 2.6.18 closes? I don't know if vanilla 2.6.18-rc6 locks up on other

[PATCH] EtherIP tunnel driver (RFC 3378)

2006-09-11 Thread Joerg Roedel
This driver implements the tunneling of Ethernet packets over IPv4 networks for Linux. It uses the protocol defined in RFC 3378. The protocol is also implemented by various BSD derivates and the Linux driver is interoperable with them (tested with NetBSD). The driver is also tested on different

[PATCH] e1000: fix TX timout hang regression for 82542rev3

2006-09-11 Thread Auke Kok
Commit 581d708eb47cccb5f41bc0817e50c9b004011ba8 (oct. 5 2005) introduced partial Multiqueue support for e1000 which broke macro smartness in setting up head/tail registers for 82542 rev3 chipsets, making these adapters completely non-working since 2.6.15. This commit sets the proper head and tail

Re: [patch 01/10] [TULIP] Change tulip maintainer

2006-09-11 Thread Jeff Garzik
applied patches 1-8 of 10 to netdev-2.6.git#upstream. patch #9 did not apply, stopping the merge. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [2.6.19 PATCH 0/7] ehea: IBM eHEA Ethernet Device Driver

2006-09-11 Thread Jeff Garzik
Jan-Bernd Themann wrote: Hi, this is our current version of the IBM eHEA Ethernet Device Driver. We added minor bug fixes and changes to the last version. Jeff, this driver has been discussed on the netdev, linux-ppc and kernel mailing list. We didn't receive any further comments since our

[git patch] net driver fix

2006-09-11 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/dm9000.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Dirk Opfer: Fix dm9000 release_resource

What's in netdev-2.6.git

2006-09-11 Thread Jeff Garzik
The following stuff is queued for 2.6.19. A ton of driver updates. Nothing really stands out except the addition of the qla3xxx driver. The 'upstream' branch of git://git.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git contains the following updates:

Re: TG3 data corruption (TSO ?)

2006-09-11 Thread Segher Boessenkool
#define tw32_rx_mbox(reg, val) do { wmb(); tp-write32_rx_mbox(tp, reg, val); } while(0) #define tw32_tx_mbox(reg, val) do { wmb(); tp-write32_tx_mbox(tp, reg, val); } while(0) That should do it. I think we need those tcpdump after all. Can you send it to me? Looks like adding a sync

Re: RFC/T: Possible fix for bcm43xx periodic work bug

2006-09-11 Thread Larry Finger
Erik Mouw wrote: On Fri, Sep 08, 2006 at 08:36:36AM -0500, Larry Finger wrote: Erik Mouw wrote: Thanks for the information, pulled wireless-2.6 and recompiling kernel. If this really fixes the problem, can we try to get it merged before 2.6.18 closes? I don't know if vanilla 2.6.18-rc6 locks

Re: [PATCH 14/21] uml: enable scsi and add iscsi config

2006-09-11 Thread Jeff Dike
On Wed, Sep 06, 2006 at 03:16:44PM +0200, Peter Zijlstra wrote: Enable iSCSI on UML, dunno why SCSI was deemed broken, it works like a charm. Acked-by: Jeff Dike [EMAIL PROTECTED] Although it would be nice if we didn't have to copy bits of Kconfig files to do this.

Re: TG3 data corruption (TSO ?)

2006-09-11 Thread Michael Chan
On Mon, 2006-09-11 at 15:52 +1000, Benjamin Herrenschmidt wrote: Looks like adding a sync to writel does fix it though... I'm trying to figure out which specific writel in the driver makes a difference. I'll then look into slicing those tcpdumps. During runtime in the fast path, the only

RE: [PATCH] VIOC: New Network Device Driver

2006-09-11 Thread Misha Tomushev
-Original Message- From: Arnd Bergmann [mailto:[EMAIL PROTECTED] Sent: Sunday, September 10, 2006 2:39 PM To: Misha Tomushev Cc: [EMAIL PROTECTED]; netdev@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] VIOC: New Network Device Driver Am Friday 15 September 2006

[PATCH] net/dccp: Allow default/fallback service code

2006-09-11 Thread Gerrit Renker
[DCCP]: Allow default/fallback service code. This has been discussed on [EMAIL PROTECTED] and removes the necessity for applications to supply service codes in each and every case. If an application does not want to provide a service code, that's fine, it will be given 0. Otherwise, service

Re: [PATCH] VIOC: New Network Device Driver

2006-09-11 Thread Arnd Bergmann
On Monday 11 September 2006 19:58, Misha Tomushev wrote: The descriptor clean-up does not contribute anything to the performance of the driver, it just replenishes the memory pools. It almost does not need interrupts. Why would we want to add more cycles to the receive logic, when driver is

Re: [PATCH] fix for system lockups in 2.6.18-rcX caused by bcm43xx

2006-09-11 Thread John W. Linville
On Sat, Sep 09, 2006 at 11:04:59AM -0500, Larry Finger wrote: John W. Linville wrote: On Fri, Sep 08, 2006 at 08:47:54PM -0500, Larry Finger wrote: PLease send this upstream for inclusion in 2.6.18, if possible. This patch will not work for wireless-2.6. That patch will be sent to you

Re: [PATCH] fix for system lockups in 2.6.18-rcX caused by bcm43xx

2006-09-11 Thread Larry Finger
John W. Linville wrote: On Sat, Sep 09, 2006 at 11:04:59AM -0500, Larry Finger wrote: John W. Linville wrote: OK, I see now. The patch won't apply to the upstream branch at all due to the open-coded locking patch applied previously. The problem now is that if I send this up for 2.6.18 then

Re: [PATCH] fix for system lockups in 2.6.18-rcX caused by bcm43xx

2006-09-11 Thread John W. Linville
On Mon, Sep 11, 2006 at 02:59:01PM -0500, Larry Finger wrote: John W. Linville wrote: Also, if you could just use --- instead of a long line of ==, I think I would have to do less manual processing...thanks! Sorry about the === rather than ---. Is that documented somewhere? Not too

Re: [PATCH] fix for system lockups in 2.6.18-rcX caused by bcm43xx

2006-09-11 Thread Jeff Garzik
John W. Linville wrote: On Mon, Sep 11, 2006 at 02:59:01PM -0500, Larry Finger wrote: John W. Linville wrote: Also, if you could just use --- instead of a long line of ==, I think I would have to do less manual processing...thanks! Sorry about the === rather than ---. Is that documented