Re: PROBLEM: kernel BUG at net/ipv6/ip6_output.c:718

2006-10-03 Thread Herbert Xu
On Tue, Oct 03, 2006 at 03:49:35PM +1000, Herbert Xu wrote: OK, I think I've got the right bug this time. Here is the patch for the other bug that I found along the way: [UDP6]: Fix MSG_PROBE crash UDP tracks corking status through the pending variable. The IP layer also tracks it through

Re: [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

2006-10-03 Thread Jarek Poplawski
On Mon, Oct 02, 2006 at 04:49:38PM +0300, Ismail Donmez wrote: 02 Eki 2006 Pts 13:24 tarihinde, Jarek Poplawski şunlar?? yazm??şt??: On 30-09-2006 21:23, Ismail Donmez wrote: Hi, With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE changed behaviour so it

Re: [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

2006-10-03 Thread Jens Axboe
On Mon, Oct 02 2006, Jarek Poplawski wrote: On Mon, Oct 02, 2006 at 12:24:47PM +0200, Jarek Poplawski wrote: On 30-09-2006 21:23, Ismail Donmez wrote: Hi, With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE changed behaviour so it returns false when the node

Re: [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

2006-10-03 Thread Jens Axboe
On Mon, Oct 02 2006, Ismail Donmez wrote: 02 Eki 2006 Pts 13:24 tarihinde, Jarek Poplawski ??unlar?? yazmt??: On 30-09-2006 21:23, Ismail Donmez wrote: Hi, With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE changed behaviour so it returns false when the

Re: [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

2006-10-03 Thread Jarek Poplawski
On Tue, Oct 03, 2006 at 12:28:32PM +0200, Jens Axboe wrote: ... I don't see any missed changes. And you are right! I've checked the link from the first message of this thread and now I see it's not current enough. I'm sorry for this false alarm. Jarek P. - To unsubscribe from this list: send

[PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

2006-10-03 Thread Ismail Donmez
With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE changed behaviour so it returns true when the node is empty as expected. Hence Patrick McHardy's fix for sched_htb.c should be reverted. Signed-off-by: Ismail Donmez [EMAIL PROTECTED] diff --git a/net/sched/sch_htb.c

Re: [RFC][PATCH 1/3] enable bonding to enslave non ARPHRD_ETHER netdevices

2006-10-03 Thread Or Gerlitz
Jay Vosburgh wrote: Or Gerlitz [EMAIL PROTECTED] wrote: On 9/26/06, Jay Vosburgh [EMAIL PROTECTED] wrote: Or Gerlitz [EMAIL PROTECTED] wrote: [...] + bond-dev-mtu = new_active-dev-mtu; This won't generate a NETDEV_CHANGEMTU notifier event. What is actually the

Re: [RFC] [PATCH 3/3] enable IP multicast when bonding IPoIB devices

2006-10-03 Thread Or Gerlitz
Jay Vosburgh wrote: Or Gerlitz [EMAIL PROTECTED] wrote: On 9/27/06, Jay Vosburgh [EMAIL PROTECTED] wrote: Or Gerlitz [EMAIL PROTECTED] wrote: [...] You almost want to have some kind of call to induce a reload from scratch of the multicast filter settings (along with whatever else

Re: PROBLEM: kernel BUG at net/ipv6/ip6_output.c:718

2006-10-03 Thread James Morris
On Tue, 3 Oct 2006, Herbert Xu wrote: On Thu, Sep 28, 2006 at 10:40:18AM +0200, cagri coltekin wrote: No. Bug is the first after boot: OK, I think I've got the right bug this time. [UDP6]: Fix flowi clobbering The udp6_sendmsg function uses a shared buffer to store the flow without

Re: PROBLEM: kernel BUG at net/ipv6/ip6_output.c:718

2006-10-03 Thread cagri coltekin
On Tue, Oct 03, 2006 at 04:28:20PM +1000, Herbert Xu wrote: On Tue, Oct 03, 2006 at 03:49:35PM +1000, Herbert Xu wrote: OK, I think I've got the right bug this time. Here is the patch for the other bug that I found along the way: [UDP6]: Fix MSG_PROBE crash This one fixes. Thanks!

[patch 2/6] 2.6.18: sb1250-mac: Missing inclusions from linux/phy.h

2006-10-03 Thread Maciej W. Rozycki
Hello, The linux/phy.h uses some types and macros defined in linux/ethtool.h, linux/mii.h, linux/timer.h and linux/workqueue.h, but fails to include these headers. Please consider. Maciej Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] patch-mips-2.6.18-20060920-include-phy-16 diff

[patch 4/6] 2.6.18: sb1250-mac: The actual driver update

2006-10-03 Thread Maciej W. Rozycki
Hello, This is the actual driver update. It includes the following changes: 1. Some help text for Kconfig. 2. Removal of unused module options. 3. Phylib support and the resulting removal of generic bits for handling the PHY. 4. Proper reserving of device resources and using

[patch 3/6] 2.6.18: sb1250-mac: Phylib IRQ handling fixes

2006-10-03 Thread Maciej W. Rozycki
Hello, This patch fixes a couple of problems discovered with interrupt handling in the phylib core, namely: 1. The driver uses timer and workqueue calls, but does not include linux/timer.h nor linux/workqueue.h. 2. The driver uses schedule_work() for handling interrupts, but does not

[patch 1/6] 2.6.18: sb1250-mac: Broadcom PHY support

2006-10-03 Thread Maciej W. Rozycki
Hello, This patch adds support for interrupt-driven operation of the Broadcom Gigabit Ethernet PHYs. I have included device IDs for the parts used on Broadcom SiByte evaluation boards; more can be added as a need arises. They are apparently generally software-compatible with one another.

[patch 5/6] 2.6.18: sb1250-mac: Interrupt wiring for PHYs

2006-10-03 Thread Maciej W. Rozycki
Hello, This patch defines the wiring for the PHY interrupt lines for the supported Broadcom SiByte boards for which documentation is available. Please consider. Maciej Signed-off-by: Maciej W. Rozycki [EMAIL PROTECTED] patch-mips-2.6.18-20060920-sibyte-phy-irq-15 diff -up --recursive

[patch 0/6] 2.6.18: sb1250-mac: Driver model phylib update

2006-10-03 Thread Maciej W. Rozycki
Hello, Here is a set of patches that update the sb1250-mac driver used for the onchip Gigabit Ethernet interfaces of the Broadcom SiByte family of SOCs including the BCM1250 and a couple of other members. These are used, among others, on various Broadcom evaluation boards together with

[patch 6/6] 2.6.18: sb1250-mac: PHY interrupt polarity fixup

2006-10-03 Thread Maciej W. Rozycki
Hello, This change makes the PHY interrupt actually work as intended on the SWARM board, where the CFE firmware leaves the GPIO line at the power-on polarity, which is suitable for active-high interrupts, but not quite so for this one (the interrupt force bit in the PHY works much better for

[PATCH] mv643xx_eth: Fix ethtool stats

2006-10-03 Thread Maxime Bizon
Some stats reported by ethtool -S on mv643xx_eth device are cleared between each call. Is it the wanted behaviour ? If not, the attached patch fixes it. Signed-off-by: Maxime Bizon [EMAIL PROTECTED] --- linux-2.6.18/drivers/net/mv643xx_eth.c.orig 2006-10-03 18:29:14.0 +0200 +++

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-10-03 Thread Samuel Tardieu
Jean == Jean Tourrilhes [EMAIL PROTECTED] writes: Jean @@ -2500,9 +2501,9 @@ static int orinoco_hw_get_essid(struct o Jean len = le16_to_cpu(essidbuf.len); Jean BUG_ON(len IW_ESSID_MAX_SIZE); Jean Jean - memset(buf, 0, IW_ESSID_MAX_SIZE+1); Jean + memset(buf, 0, IW_ESSID_MAX_SIZE); Jean

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-10-03 Thread Jean Tourrilhes
On Tue, Oct 03, 2006 at 05:58:31PM +0200, Samuel Tardieu wrote: Jean == Jean Tourrilhes [EMAIL PROTECTED] writes: Jean @@ -2500,9 +2501,9 @@ static int orinoco_hw_get_essid(struct o Jean len = le16_to_cpu(essidbuf.len); Jean BUG_ON(len IW_ESSID_MAX_SIZE); Jean Jean -

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-10-03 Thread Samuel Tardieu
On 3/10, Jean Tourrilhes wrote: | I suggest that you revert the memset() to IW_ESSID_MAX_SIZE+1 so that | the last byte is cleared as well. Or am I missing something? | | No, that would bring back the slab/memory overflow we are | trying to get rid of. Then I am puzzled by the function

Re: Please pull bcm43xx-d80211 bugfixes and new features

2006-10-03 Thread Michael Buesch
On Tuesday 03 October 2006 05:44, Larry Finger wrote: Michael Buesch wrote: Hi John, Please pull from my tree git pull http://bu3sch.de/git/wireless-dev.git for-linville This will pull various bugfixes and feature improvements. Most noteably it will pull a bugfix for a crash

Re: Please pull bcm43xx-d80211 bugfixes and new features

2006-10-03 Thread Martin Langer
On Tue, Oct 03, 2006 at 01:58:33PM +0200, Michael Buesch wrote: On Tuesday 03 October 2006 05:44, Larry Finger wrote: kernel: ssb: Core 0 found: cc 0800, rev 02, vendor 4243 kernel: ssb: Core 1 found: cc 0812, rev 04, vendor 4243 kernel: ssb: Core 2 found: cc 080D, rev 01, vendor 4243

Re: Please pull bcm43xx-d80211 bugfixes and new features

2006-10-03 Thread Michael Buesch
On Tuesday 03 October 2006 14:36, Martin Langer wrote: On Tue, Oct 03, 2006 at 01:58:33PM +0200, Michael Buesch wrote: On Tuesday 03 October 2006 05:44, Larry Finger wrote: kernel: ssb: Core 0 found: cc 0800, rev 02, vendor 4243 kernel: ssb: Core 1 found: cc 0812, rev 04, vendor 4243

Re: Please pull bcm43xx-d80211 bugfixes and new features

2006-10-03 Thread Larry Finger
Michael Buesch wrote: kernel: bcm43xx_d80211: firmware revision FE84, patchlevel 90B4, date 2000-14-248 29:46:18 Uhm, which firmware are you running? The softmac version reports the following (The loaded messages are something I'm trying.): kernel: bcm43xx: Firmware: Microcode

Re: Please pull bcm43xx-d80211 bugfixes and new features

2006-10-03 Thread Michael Buesch
On Tuesday 03 October 2006 16:36, Larry Finger wrote: Michael Buesch wrote: kernel: bcm43xx_d80211: firmware revision FE84, patchlevel 90B4, date 2000-14-248 29:46:18 Uhm, which firmware are you running? The softmac version reports the following (The loaded messages are

Re: Please pull bcm43xx-d80211 bugfixes and new features

2006-10-03 Thread Larry Finger
Michael Buesch wrote: On Tuesday 03 October 2006 16:36, Larry Finger wrote: Michael Buesch wrote: kernel: bcm43xx_d80211: firmware revision FE84, patchlevel 90B4, date 2000-14-248 29:46:18 Uhm, which firmware are you running? The softmac version reports the following (The loaded messages

Re: Please pull bcm43xx-d80211 bugfixes and new features

2006-10-03 Thread Martin Langer
On Tue, Oct 03, 2006 at 04:48:04PM +0200, Michael Buesch wrote: On Tuesday 03 October 2006 16:36, Larry Finger wrote: Michael Buesch wrote: kernel: bcm43xx_d80211: firmware revision FE84, patchlevel 90B4, date 2000-14-248 29:46:18 Uhm, which firmware are you running? The

Re: Please pull bcm43xx-d80211 bugfixes and new features

2006-10-03 Thread Michael Buesch
On Tuesday 03 October 2006 17:12, Martin Langer wrote: On Tue, Oct 03, 2006 at 04:48:04PM +0200, Michael Buesch wrote: On Tuesday 03 October 2006 16:36, Larry Finger wrote: Michael Buesch wrote: kernel: bcm43xx_d80211: firmware revision FE84, patchlevel 90B4, date 2000-14-248

Re: 2.6.18-mm2 - oops in cache_alloc_refill()

2006-10-03 Thread Jean Tourrilhes
On Tue, Oct 03, 2006 at 06:45:35PM +0200, Samuel Tardieu wrote: On 3/10, Jean Tourrilhes wrote: | I suggest that you revert the memset() to IW_ESSID_MAX_SIZE+1 so that | the last byte is cleared as well. Or am I missing something? | | No, that would bring back the slab/memory overflow

[PATCH] mv643xx_eth: Fix ethtool stats

2006-10-03 Thread Dale Farnsworth
From: Maxime Bizon [EMAIL PROTECTED] Some stats reported by ethtool -S on mv643xx_eth device are cleared between each call. This patch fixes it. Signed-off-by: Maxime Bizon [EMAIL PROTECTED] Signed-off-by: Dale Farnsworth [EMAIL PROTECTED] --- Thanks Maxime. ---

[patch 4/5] d80211: retain PS frames for at least STA listen interval

2006-10-03 Thread David Kimdon
From: Jouni Malinen [EMAIL PROTECTED] Start using 2 * listen_int * beacon_int as a timeout for PS buffered unicast frames if that is longer than 10 seconds. Previously, we used fixed 10 second limit regardless of the listen interval. This fixes power saving for STAs that request very long listen

[patch 5/5] d80211: allow wireless vlan interface to have same MAC an AP interface

2006-10-03 Thread David Kimdon
Wireless vlan interfaces need to have the same mac address as AP interfaces. The STA must not see the change when it is bound to a specific vlan, so the address of the vlan interface must be the same as the address of the AP interface the station associated with. Signed-off-by: David Kimdon

[patch 3/5] d80211: remove rate limit code

2006-10-03 Thread David Kimdon
From: Elliot Schwartz [EMAIL PROTECTED] Remove unused and more or less pointless rate limiting code. This would have just dropped multicast frames arbitrarily when the limit is reached which is quite useless and does not really belong to 802.11 code. Signed-off-by: Elliot Schwartz [EMAIL

[patch 1/5] d80211: Fix overflow when creating AVS header

2006-10-03 Thread David Kimdon
Fix overflow when converting timespec to microseconds. Without this patch you can get an overflow during the multiplication which can result in a negative number. hostime is define here: 4.4 hosttime The hosttime field is set to the current value of the host maintained clock variable when the

[patch 2/5] d80211: remove unused xr structure members, interface, etc.

2006-10-03 Thread David Kimdon
From: Elliot Schwartz [EMAIL PROTECTED] This is all unused. Signed-off-by: Elliot Schwartz [EMAIL PROTECTED] Index: wireless-dev/include/net/d80211.h === --- wireless-dev.orig/include/net/d80211.h +++

Re: [PATCH] Customizable TCP backoff patch

2006-10-03 Thread Ben Woodard
David Miller wrote: From: Ben Woodard [EMAIL PROTECTED] Date: Wed, 27 Sep 2006 11:52:57 -0700 Because these are general utility clusters we run many different programs and so trying to fix this problem in the application is not possible since there are literally hundreds if not thousands of

Re: sky2 hangs, hw csum errors with 2.6.18

2006-10-03 Thread Martin Lucina
Hi Stephen, I'm still getting tx timeouts even after applying the patch you sent me and forcing tx flow control off: Sep 28 20:35:53 dezo kernel: NETDEV WATCHDOG: eth1: transmit timed out Sep 28 20:35:53 dezo kernel: sky2 eth1: tx timeout Sep 28 20:35:53 dezo kernel: sky2 eth1: transmit ring 420

[PATCH 2/5] ibmveth: Add netpoll function

2006-10-03 Thread Santiago Leon
From: Santiago Leon [EMAIL PROTECTED] This patch adds the net poll controller function to ibmveth to support netconsole and netdump. Signed-off-by: Santiago Leon [EMAIL PROTECTED] --- drivers/net/ibmveth.c | 11 +++ 1 file changed, 11 insertions(+) diff -urNp a/drivers/net/ibmveth.c

[PATCH 0/5] ibmveth: various fixes

2006-10-03 Thread Santiago Leon
Hi Jeff, Can you apply the following patches (hopefully for 2.6.19)? They are the hardening of the initialization for kexec, adding netpoll, and some small fixes for bugs that people have been running into. Thanks, -- Santiago A. Leon Power Linux Development IBM Linux Technology Center - To

[PATCH 3/5] ibmveth: kdump interrupt fix

2006-10-03 Thread Santiago Leon
From: Santiago Leon [EMAIL PROTECTED] This patch fixes a race that panics the kernel when opening the device after a kdump. Without this patch there is a window where the hypervisor can send an interrupt before all the structures for the kdump ibmveth module are ready (because the hypervisor

[PATCH 5/5] ibmveth: fix int rollover panic

2006-10-03 Thread Santiago Leon
From: Santiago Leon [EMAIL PROTECTED] This patch fixes a nasty bug that has been sitting there since the very first versions of the driver, but is generating a panic because we changed the number of 2K buffers for 2.6.16. The consumer_index and producer_index are u32's that get incremented on

[PATCH 1/5] ibmveth: Harden driver initilisation

2006-10-03 Thread Santiago Leon
From: Michael Ellerman [EMAIL PROTECTED] Hi Jeff, This patch has been floating around for a while now, Santi originally sent it in March: http://www.spinics.net/lists/netdev/msg00471.html You replied saying you thought it was bonkers, I think I explained why it wasn't, perhaps you disagree.

[PATCH 4/5] ibmveth: rename proc entry name

2006-10-03 Thread Santiago Leon
From: Santiago Leon [EMAIL PROTECTED] This patch changes the name of the proc file for each ibmveth adapter from the network device name to the slot number in the virtual bus. The proc file is created when the device is probed, so a change in the name of the device will not be reflected in the

Re: [Bugme-new] [Bug 7254] New: leaving IP multicast group with incorrect imr_address unexpectedly succeeded

2006-10-03 Thread David Stevens
If the index is set, it doesn't look up the address (which may be expensive). If you want to look up by address, the index must be 0. I wouldn't call that a bug. +-DLS - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: sky2 hangs, hw csum errors with 2.6.18

2006-10-03 Thread Stephen Hemminger
On Tue, 3 Oct 2006 20:21:20 +0200 Martin Lucina [EMAIL PROTECTED] wrote: Hi Stephen, I'm still getting tx timeouts even after applying the patch you sent me and forcing tx flow control off: What speed and duplex are you using? Also, I'm seeing a bunch of messages like this (in addition

Re: sky2 hangs, hw csum errors with 2.6.18

2006-10-03 Thread Martin Lucina
[EMAIL PROTECTED] said: On Tue, 3 Oct 2006 20:21:20 +0200 Martin Lucina [EMAIL PROTECTED] wrote: Hi Stephen, I'm still getting tx timeouts even after applying the patch you sent me and forcing tx flow control off: What speed and duplex are you using? 1000 Mbps, full duplex What

Re: sky2 hangs, hw csum errors with 2.6.18

2006-10-03 Thread Stephen Hemminger
On Tue, 3 Oct 2006 21:13:51 +0200 Martin Lucina [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] said: What speed and duplex are you using? 1000 Mbps, full duplex What MTU are you using. 1500 Are you sure? I assume you are using the latest driver from Linus's git

Re: sky2 hangs, hw csum errors with 2.6.18

2006-10-03 Thread Martin Lucina
Possibly related, could the TX hangs be due to extreme load / no free memory on the machine? I just realised that my application appears to be loading the machine to the max... (i.e. all 2GB RAM used + another couple GB in swap) -mato - To unsubscribe from this list: send the line unsubscribe

Re: sky2 hangs, hw csum errors with 2.6.18

2006-10-03 Thread Martin Lucina
[EMAIL PROTECTED] said: What speed and duplex are you using? 1000 Mbps, full duplex What MTU are you using. 1500 Are you sure? I assume you are using the latest driver from Linus's git repository. That version adds support for fragmented receive, but that code shouldn't be

Re: sky2 hangs, hw csum errors with 2.6.18

2006-10-03 Thread Martin Lucina
[EMAIL PROTECTED] said: If you are seeing truesize errors with the stock 2.6.18 kernel then some other protocol is messing with the skb's? Are you using IPV6? Or PPPoE or something like that. Only thing like that that is running here is OpenVPN which is using a tun interface. There's hardly

Re: [Bugme-new] [Bug 7254] New: leaving IP multicast group with incorrect imr_address unexpectedly succeeded

2006-10-03 Thread David Miller
From: David Stevens [EMAIL PROTECTED] Date: Tue, 3 Oct 2006 11:33:07 -0700 If the index is set, it doesn't look up the address (which may be expensive). If you want to look up by address, the index must be 0. I wouldn't call that a bug. Me neither, Andrew please close this. :) - To

Re: [PATCH] Revert [NET_SCHED]: HTB: fix incorrect use of RB_EMPTY_NODE

2006-10-03 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Tue, 03 Oct 2006 20:05:33 +0200 Ismail Donmez wrote: With commit 10fd48f2376db52f08bf0420d2c4f580e39269e1 [1] , RB_EMPTY_NODE changed behaviour so it returns true when the node is empty as expected. Hence Patrick McHardy's fix for

Re: [PATCH] neigh: always use hash_mask under tbl lock

2006-10-03 Thread David Miller
From: Julian Anastasov [EMAIL PROTECTED] Date: Tue, 3 Oct 2006 03:05:51 +0300 (EEST) Make sure hash_mask is protected with tbl-lock in all cases just like the hash_buckets. Signed-off-by: Julian Anastasov [EMAIL PROTECTED] Applied, thanks Julian. I'll push this to -stable too. - To

Re: [PATCH][XFRM] Fixes for net-2.6

2006-10-03 Thread David Miller
From: Masahide NAKAMURA [EMAIL PROTECTED] Date: Tue, 03 Oct 2006 12:29:54 +0900 [XFRM] POLICY: Fix per-direction policy counter after flushing. Currently when xfrm_policy_flush() is called per-direction policy counter is cleared. However flusing policy is performed for each

Re: [RFC] [PATCH 3/3] enable IP multicast when bonding IPoIB devices

2006-10-03 Thread Jay Vosburgh
Or Gerlitz [EMAIL PROTECTED] wrote: Sorry, but I don't follow... by saying would be ideal to do ***it*** this way in all cases what exactly is the it you are referring to? It refers to: You almost want to have some kind of call to induce a reload from scratch of the multicast

Re: [PATCH] Fix for IPsec leakage with SELinux enabled - V.02

2006-10-03 Thread David Miller
From: James Morris [EMAIL PROTECTED] Date: Mon, 2 Oct 2006 10:27:13 -0400 (EDT) Updated version of the patch, which return directly after a flow cache lookup error in xfrm_lookup rather than returing via the cleanup path (which was causing a spurious dst_release). This works for me,

Re: rewriting skb-truesize... good or bad idea

2006-10-03 Thread David Miller
From: Vlad Yasevich [EMAIL PROTECTED] Date: Mon, 02 Oct 2006 10:46:42 -0400 David Miller wrote: If, on the other hand, you know you have exclusive access to the skb and there are no other references, setting skb-truesize can be OK. However setting it to sizeof(struct sk_buff) doesn't make

Re: [PATCH 1/3][ATM]: kmalloc to kzalloc patches for drivers/atm

2006-10-03 Thread David Miller
From: chas williams - CONTRACTOR [EMAIL PROTECTED] Date: Sun, 01 Oct 2006 11:17:05 -0400 [ATM]: kmalloc to kzalloc patches for drivers/atm Signed-off-by: Om Narasimhan [EMAIL PROTECTED] Signed-off-by: Chas Williams [EMAIL PROTECTED] Applied, thanks Chas. - To unsubscribe from this list:

[PATCH 0/4]: Spidernet transmit patches

2006-10-03 Thread Linas Vepstas
The following set of four patches provide some more spidernet fixes. Most important are a pair of patches to stop the transmit queue when it is full, and to actually turn off transmit interrupts during NAPI(!) Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Cc: James K Lewis [EMAIL PROTECTED] Cc:

[PATCH 1/4]: Spidernet stop queue when queue is full

2006-10-03 Thread Linas Vepstas
Subject: [PATCH 1/4]: Spidernet stop queue when queue is full. This patch adds a call to netif_stop_queue() when there is no more room for more packets on the transmit queue. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Cc: James K Lewis [EMAIL PROTECTED] Cc: Arnd Bergmann [EMAIL PROTECTED]

[PATCH 3/4]: Spidernet transmit interupt mitigation

2006-10-03 Thread Linas Vepstas
For small packets, the transmit interrupt settings were accidentally generating too many interrupts. This patch turns off all transmit-related interrupts when the tx queue is mostly empty. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Cc: James K Lewis [EMAIL PROTECTED] Cc: Arnd Bergmann

[PATCH 2/4]: Spidernet fix register field definitions

2006-10-03 Thread Linas Vepstas
This patch fixes the names of a few fields in the DMA control register. There is no functional change. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Cc: James K Lewis [EMAIL PROTECTED] Cc: Arnd Bergmann [EMAIL PROTECTED] drivers/net/spider_net.c |2 +- drivers/net/spider_net.h |

[PATCH 4/4]: Spidernet module parm permissions

2006-10-03 Thread Linas Vepstas
The module param permsissions should bw read-only, not writable. Signed-off-by: James K Lewis [EMAIL PROTECTED] Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Cc: Arnd Bergmann [EMAIL PROTECTED] drivers/net/spider_net.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index:

Re: [PATCH 1/4]: Spidernet stop queue when queue is full

2006-10-03 Thread Arnd Bergmann
On Tuesday 03 October 2006 22:57, Linas Vepstas wrote: +   if ((chain-head-next == chain-tail-prev) || +      (spider_net_get_descr_status(descr) != SPIDER_NET_DESCR_NOT_IN_USE)) { result = NETDEV_TX_LOCKED; goto out; } ...  out: -   

Re: [PATCH] TIPC: fix printk warning

2006-10-03 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Sun, 1 Oct 2006 12:24:13 -0400 gcc spits out this warning: net/tipc/link.c: In function $,1rx(Blink_retransmit_failure$,1ry(B: net/tipc/link.c:1669: warning: cast from pointer to integer of different size More than a little bit ugly, storing

Re: [PATCH 3/3][ATM]: [zatm] always *pcr in alloc_shaper()

2006-10-03 Thread David Miller
From: chas williams - CONTRACTOR [EMAIL PROTECTED] Date: Sun, 01 Oct 2006 11:18:00 -0400 please consider for 2.6.18 -- thanks! [ATM]: [zatm] always *pcr in alloc_shaper() Signed-off-by: Chas Williams [EMAIL PROTECTED] Also applied, thanks a lot. - To unsubscribe from this list: send the

Re: [NET_SCHED]: Remove old estimator implementation

2006-10-03 Thread David Miller
Good spotting Patrick, applied. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3][ATM]: [ambassador] Change the return type to reflect reality

2006-10-03 Thread David Miller
From: chas williams - CONTRACTOR [EMAIL PROTECTED] Date: Sun, 01 Oct 2006 11:17:43 -0400 please consider for 2.6.19 -- thanks! [ATM]: [ambassador] Change the return type to reflect reality Signed-off-by: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Chas Williams [EMAIL PROTECTED]

[PATCH] sky2: incorrect length on receive packets

2006-10-03 Thread Stephen Hemminger
The previous change to do fragmented receive (post 2.6.18) introduced a bug where packets are passed up with size set to the size of the receive buffer not the actual received data. IP silently trims this so it didn't show up right away. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] ---

Re: [patch 4/6] 2.6.18: sb1250-mac: The actual driver update

2006-10-03 Thread Andrew Morton
On Tue, 3 Oct 2006 16:18:44 +0100 (BST) Maciej W. Rozycki [EMAIL PROTECTED] wrote: + sbmac_state_t sbm_state; /* current state */ argh. The reader looks at this and doesn't know if it's an integer, a void*, a struct usb_ac_header_descriptor** or what. enum

Re: [patch 4/6] 2.6.18: sb1250-mac: The actual driver update

2006-10-03 Thread Ralf Baechle
On Tue, Oct 03, 2006 at 04:42:53PM -0700, Andrew Morton wrote: On Tue, 3 Oct 2006 16:18:44 +0100 (BST) Maciej W. Rozycki [EMAIL PROTECTED] wrote: + sbmac_state_t sbm_state; /* current state */ argh. The reader looks at this and doesn't know if it's an integer, a

Re: [PATCH] Fix for IPsec leakage with SELinux enabled - V.02

2006-10-03 Thread James Morris
On Tue, 3 Oct 2006, David Miller wrote: I'm not saying either is wrong, I'm just pointing it out to make sure this is intentional. The socket policy behavior deserves some scrutiny. I say this because if a matching socket policy is avoided due to security layer error, this could

[PATCH] Add spinlocks to serialize ib_post_send/ib_post_recv

2006-10-03 Thread Tom Tucker
From: Tom Tucker [EMAIL PROTECTED] The AMSO driver was not thread-safe in the post WR code and had code that would sleep if the WR post FIFO was full. Since these functions can be called on interrupt level I changed the sleep to a udelay. Signed-off-by: Tom Tucker [EMAIL PROTECTED] ---

Re: [PATCH] Add spinlocks to serialize ib_post_send/ib_post_recv

2006-10-03 Thread Roland Dreier
Thanks, queued for 2.6.19 - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH][XFRM] Fixes for net-2.6

2006-10-03 Thread Masahide NAKAMURA
David Miller wrote: From: Masahide NAKAMURA [EMAIL PROTECTED] Date: Tue, 03 Oct 2006 12:29:54 +0900 [XFRM] POLICY: Fix per-direction policy counter after flushing. Currently when xfrm_policy_flush() is called per-direction policy counter is cleared. However flusing policy is

[PATCH 1/1] secid reconcialiation: Replace unlabeled_t with the network_t

2006-10-03 Thread Venkat Yekkirala
The following replaces unlabeled_t with network_t for better characterization of the flow out/in checks in SELinux, as well as to allow for mls packets to flow out/in from the network since network_t would allow the full range of MLS labels, as opposed to the unlabeled init sid that only allows

Re: sky2 (was Re: 2.6.18-mm2)

2006-10-03 Thread Matthias Hentges
Hello Stephen, Am Donnerstag, den 28.09.2006, 16:19 -0700 schrieb Stephen Hemminger: Here is the debug patch I sent to the first reporter of the problem. I know what the offset is supposed to be, so if the PCI subsystem is wrong, this will show. --- sky2.orig/drivers/net/sky2.c

[PATCH] ieee80211: Drop and count duplicate data frames to remove 'replay detected' log messages

2006-10-03 Thread Larry Finger
In the SoftMAC version of the IEEE 802.11 stack, not all duplicate messages are detected. For the most part, there is no difficulty; however ifor TKIP and CCMP encryption, the duplicates result in a replay detected log message where the received and previous values of the TSC are identical. This

Re: sky2 (was Re: 2.6.18-mm2)

2006-10-03 Thread Stephen Hemminger
On Wed, 04 Oct 2006 04:57:08 +0200 Matthias Hentges [EMAIL PROTECTED] wrote: Hello Stephen, Am Donnerstag, den 28.09.2006, 16:19 -0700 schrieb Stephen Hemminger: Here is the debug patch I sent to the first reporter of the problem. I know what the offset is supposed to be, so if the PCI

Re: [take19 0/4] kevent: Generic event handling mechanism.

2006-10-03 Thread Ulrich Drepper
On 9/27/06, Evgeniy Polyakov [EMAIL PROTECTED] wrote: \ I have been told in private what is signal masks about - just to wait until either signal or given condition is ready, but in that case just add additional kevent user like AIO complete or netwrok notification and wait until either

Re: [take19 0/4] kevent: Generic event handling mechanism.

2006-10-03 Thread Evgeniy Polyakov
On Tue, Oct 03, 2006 at 09:50:09PM -0700, Ulrich Drepper ([EMAIL PROTECTED]) wrote: On 9/27/06, Evgeniy Polyakov [EMAIL PROTECTED] wrote: \ I have been told in private what is signal masks about - just to wait until either signal or given condition is ready, but in that case just add

Re: [PATCH] Fix for IPsec leakage with SELinux enabled - V.02

2006-10-03 Thread Evgeniy Polyakov
On Mon, Oct 02, 2006 at 12:41:57PM -0400, James Morris ([EMAIL PROTECTED]) wrote: You can get recent policy packages via the devel repo, which I'd suggest if you're using development (or DIY) kernels. [EMAIL PROTECTED] ~]# uname -a Linux kano 2.6.18 #5 SMP Mon Oct 2 18:44:30 MSD 2006 i686