Re: [PATCH 04/18][SK_BUFF]: Introduce skb_reset_network_header(skb)

2007-03-12 Thread Christoph Hellwig
On Mon, Mar 12, 2007 at 01:26:52AM -0300, Arnaldo Carvalho de Melo wrote: For the common, open coded 'skb-nh.raw = skb-data' operation, so that we can later turn skb-nh.raw into a offset, reducing the size of struct sk_buff in 64bit land while possibly keeping it as a pointer on 32bit.

Re: [PATCH] spidernet: Fix problem sending IP fragments

2007-03-12 Thread Norbert Eicker
On Monday, 12. March 2007 09:28, Geert Uytterhoeven wrote: On Sat, 10 Mar 2007, Norbert Eicker wrote: On Friday, 9. March 2007 17:53, Jeff Garzik wrote: Linas Vepstas wrote: Please apply. The rather long patch description is from the submitter, Norbert Eicker, I don't know if that's

Re: [PATCH 04/18][SK_BUFF]: Introduce skb_reset_network_header(skb)

2007-03-12 Thread Arnaldo Carvalho de Melo
On 3/12/07, Christoph Hellwig [EMAIL PROTECTED] wrote: On Mon, Mar 12, 2007 at 01:26:52AM -0300, Arnaldo Carvalho de Melo wrote: For the common, open coded 'skb-nh.raw = skb-data' operation, so that we can later turn skb-nh.raw into a offset, reducing the size of struct sk_buff in 64bit land

Re: Fw: [Bugme-new] [Bug 8057] New: slab corruption running ip6sic

2007-03-12 Thread Jarek Poplawski
On 22-02-2007 22:49, Andrew Morton wrote: Begin forwarded message: Date: Thu, 22 Feb 2007 07:56:27 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 8057] New: slab corruption running ip6sic http://bugzilla.kernel.org/show_bug.cgi?id=8057

Re: Fw: [Bugme-new] [Bug 8057] New: slab corruption running ip6sic

2007-03-12 Thread Jarek Poplawski
On Mon, Mar 12, 2007 at 11:24:03AM +0100, Jarek Poplawski wrote: ... I think your diagnose is correct (all return -1 should be changed to return 0 in xfrm6_input.c). Sorry! Of course should be: I think your diagnose is correct (all return -1 should be changed to return 0 in xfrm6_rcv_spi()).

Re: [PATCH] spidernet: Fix problem sending IP fragments

2007-03-12 Thread Geert Uytterhoeven
On Mon, 12 Mar 2007, Norbert Eicker wrote: On Monday, 12. March 2007 09:28, Geert Uytterhoeven wrote: On Sat, 10 Mar 2007, Norbert Eicker wrote: On Friday, 9. March 2007 17:53, Jeff Garzik wrote: Linas Vepstas wrote: Please apply. The rather long patch description is from the

Re: [PATCH] spidernet: Fix problem sending IP fragments

2007-03-12 Thread Norbert Eicker
On Monday, 12. March 2007 11:44, Geert Uytterhoeven wrote: On Mon, 12 Mar 2007, Norbert Eicker wrote: On Monday, 12. March 2007 09:28, Geert Uytterhoeven wrote: On Sat, 10 Mar 2007, Norbert Eicker wrote: On Friday, 9. March 2007 17:53, Jeff Garzik wrote: Linas Vepstas wrote:

Re: [PATCH] natsemi: netpoll fixes

2007-03-12 Thread Sergei Shtylyov
Hello. Mark Brown wrote: Oops, I was going to recast the patch but my attention switched elsewhere for couple of days, and it slipped into mainline. I'm now preparing a better patch to also protect... Ah, I was also looking at it. I enclose my current patch which appears to work

[PATCH] NetLabel: parse the CIPSO ranged tag on incoming packets

2007-03-12 Thread Paul Moore
Commit 484b366932be0b73a22c74a82748ca10a721643e added support for the CIPSO ranged categories tag. However, it appears that I made a mistake when rebasing then patch to the latest upstream sources for submission and dropped the part of the patch that actually parses the tag on incoming packets.

Re: [PATCH 0/5] NetXen: Driver bug fixes

2007-03-12 Thread Jeff Garzik
Amit Kale wrote: On Saturday 10 March 2007 16:52, Jeff Garzik wrote: Amit Kale wrote: On Friday 09 March 2007 22:26, Jeff Garzik wrote: Linsys Contractor Mithlesh Thukral wrote: Hi All, I will be sending updates to NetXen: 1G/10G Ethernet driver in subsequent mails. The patches will be with

Re: [PATCH] NetLabel: parse the CIPSO ranged tag on incoming packets

2007-03-12 Thread James Morris
On Mon, 12 Mar 2007, Paul Moore wrote: Commit 484b366932be0b73a22c74a82748ca10a721643e added support for the CIPSO ranged categories tag. However, it appears that I made a mistake when rebasing then patch to the latest upstream sources for submission and dropped the part of the patch that

Re: [PATCH 1/2] NET: Multiple queue network device support

2007-03-12 Thread Jarek Poplawski
On 09-03-2007 14:40, Thomas Graf wrote: * Kok, Auke [EMAIL PROTECTED] 2007-02-08 16:09 diff --git a/net/core/dev.c b/net/core/dev.c index 455d589..42b635c 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -1477,6 +1477,49 @@ gso: skb-tc_verd = SET_TC_AT(skb-tc_verd,AT_EGRESS);

[patch 4/4] [TULIP] Rev tulip version

2007-03-12 Thread Valerie Henson
Rev tulip version... things have changed since 2002! Signed-off-by: Valerie Henson [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] --- drivers/net/tulip/tulip_core.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- tulip-2.6-mm-linux.orig/drivers/net/tulip/tulip_core.c

[patch 3/4] [TULIP] Fix SytemError typo

2007-03-12 Thread Valerie Henson
Fix an annoying typo - SytemError - SystemError Signed-off-by: Valerie Henson [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] --- drivers/net/tulip/interrupt.c |4 ++-- drivers/net/tulip/tulip.h |2 +- drivers/net/tulip/winbond-840.c |2 +- 3 files changed, 4

[patch 2/4] [TULIP] Quiet down tulip_stop_rxtx

2007-03-12 Thread Valerie Henson
Only print out debugging info for tulip_stop_rxtx if debug is on. Many cards (including at least two of my own) fail to stop properly during initialization according to this test with no apparent ill effects. Worse, it tends to spam logs when the driver doesn't work. Signed-off-by: Val Henson

[patch 1/4] [TULIP] fix for Lite-On 82c168 PNIC

2007-03-12 Thread Valerie Henson
From: Guido Classen [EMAIL PROTECTED] This small patch fixes two issues with the Lite-On 82c168 PNIC adapters. I've tested it with two cards in different machines both chip rev 17 The first is the wrong register address CSR6 for writing the MII register which instead is 0xB8 (this may get a

Re: [git patches] net driver fixes

2007-03-12 Thread Geert Uytterhoeven
On Tue, 6 Mar 2007, Jeff Garzik wrote: Jay Vosburgh (3): bonding: Improve IGMP join processing ip_mc_rejoin_group: Kill warning about unused variable `in_dev' when CONFIG_IP_MULTICAST is not set. Signed-off-by: Geert Uytterhoeven [EMAIL PROTECTED] diff --git a/net/ipv4/igmp.c

Re: [patch 4/4] [TULIP] Rev tulip version

2007-03-12 Thread Pekka Enberg
Hi, On 3/12/07, Valerie Henson [EMAIL PROTECTED] wrote: --- tulip-2.6-mm-linux.orig/drivers/net/tulip/tulip_core.c +++ tulip-2.6-mm-linux/drivers/net/tulip/tulip_core.c @@ -17,11 +17,11 @@ #define DRV_NAME tulip #ifdef CONFIG_TULIP_NAPI -#define DRV_VERSION1.1.14-NAPI /* Keep at

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-12 Thread Jarek Poplawski
On 09-03-2007 08:29, David Miller wrote: From: Amit Choudhary [EMAIL PROTECTED] Date: Thu, 8 Mar 2007 23:22:15 -0800 Description: Check the return value of kmalloc() in function wrandom_set_nhinfo(), in file net/ipv4/multipath_wrandom.c. Signed-off-by: Amit Choudhary [EMAIL PROTECTED]

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-12 Thread Pekka J Enberg
On 3/9/07, David Miller [EMAIL PROTECTED] wrote: The whole cahce-multipath subsystem has to have it's guts revamped for proper error handling. (Untested patch follows.) From: Amit Choudhary [EMAIL PROTECTED] Check the return value of kmalloc() in function wrandom_set_nhinfo(), in file

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-12 Thread Pekka Enberg
On 3/12/07, Jarek Poplawski [EMAIL PROTECTED] wrote: So, maybe it's less evil to check those NULLs where possible and add some WARN_ONs here and there... No, it's much better to oops rather than paper over a bug. - To unsubscribe from this list: send the line unsubscribe netdev in the body of

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-12 Thread Jarek Poplawski
On Mon, Mar 12, 2007 at 02:36:46PM +0200, Pekka Enberg wrote: On 3/12/07, Jarek Poplawski [EMAIL PROTECTED] wrote: So, maybe it's less evil to check those NULLs where possible and add some WARN_ONs here and there... No, it's much better to oops rather than paper over a bug. I'm not sure I

Re: [patch 4/4] [TULIP] Rev tulip version

2007-03-12 Thread Jeff Garzik
Pekka Enberg wrote: Hi, On 3/12/07, Valerie Henson [EMAIL PROTECTED] wrote: --- tulip-2.6-mm-linux.orig/drivers/net/tulip/tulip_core.c +++ tulip-2.6-mm-linux/drivers/net/tulip/tulip_core.c @@ -17,11 +17,11 @@ #define DRV_NAME tulip #ifdef CONFIG_TULIP_NAPI -#define DRV_VERSION

Re: 2.6.21-rc3-git4 ata1.00: qc timeout (cmd 0xef) (crashdump kernel)

2007-03-12 Thread Michal Piotrowski
Hi, Tejun Heo napisał(a): Michal Piotrowski wrote: Hi Jeff, I've got some problems with my SATA controller on crashdump kernel. Calling initcall 0xc1916081: fc_transport_init+0x0/0x35() Calling initcall 0xc19160b6: init_sd+0x0/0xbc() Calling initcall 0xc19161ec: piix_init+0x0/0x27()

Re: 2.6.21-rc3-git4 ata1.00: qc timeout (cmd 0xef) (crashdump kernel)

2007-03-12 Thread Tejun Heo
Michal Piotrowski wrote: Calling initcall 0xc19154d8: piix_ide_init+0x0/0xbb() Calling initcall 0xc19155b6: generic_ide_init+0x0/0x16() Calling initcall 0xc191572e: ide_init+0x0/0x81() Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2 ide: Assuming 33MHz system bus speed for PIO modes;

Re: 2.6.21-rc3-git4 ata1.00: qc timeout (cmd 0xef) (crashdump kernel)

2007-03-12 Thread Thomas Gleixner
On Mon, 2007-03-12 at 17:31 +0100, Michal Piotrowski wrote: Calling initcall 0xc19154d8: piix_ide_init+0x0/0xbb() Calling initcall 0xc19155b6: generic_ide_init+0x0/0x16() Calling initcall 0xc191572e: ide_init+0x0/0x81() Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2 ide: Assuming

Re: 2.6.21-rc3-git4 ata1.00: qc timeout (cmd 0xef) (crashdump kernel)

2007-03-12 Thread Thomas Gleixner
On Tue, 2007-03-13 at 01:37 +0900, Tejun Heo wrote: Michal Piotrowski wrote: Calling initcall 0xc19154d8: piix_ide_init+0x0/0xbb() Calling initcall 0xc19155b6: generic_ide_init+0x0/0x16() Calling initcall 0xc191572e: ide_init+0x0/0x81() Uniform Multi-Platform E-IDE driver Revision:

Re: 2.6.21-rc3-git4 ata1.00: qc timeout (cmd 0xef) (crashdump kernel)

2007-03-12 Thread Tejun Heo
Thomas Gleixner wrote: On Tue, 2007-03-13 at 01:37 +0900, Tejun Heo wrote: Michal Piotrowski wrote: Calling initcall 0xc19154d8: piix_ide_init+0x0/0xbb() Calling initcall 0xc19155b6: generic_ide_init+0x0/0x16() Calling initcall 0xc191572e: ide_init+0x0/0x81() Uniform Multi-Platform E-IDE

Re: need some help on a backport of r8169

2007-03-12 Thread pgs
Hello François, I've been a little long, but it's done, I've tested the last patch you sent me. It was the patch of the 28 Feb 2007. The result is the same as the previous. It has the time to send some packets but quickly blocks. Here are the ifcofnig + ethtool infos : eth0 Link

Re: wireless extensions vs. 64-bit architectures

2007-03-12 Thread Jean Tourrilhes
On Sun, Mar 11, 2007 at 06:40:01PM +0100, Johannes Berg wrote: On Fri, 2007-03-09 at 13:35 -0800, Jean Tourrilhes wrote: It's not as bad as it look like. All userspace programs nowadays use either the iwlib or wpa_supplicant. For example, NetworkManager gets its stuff through

Re: wireless extensions vs. 64-bit architectures

2007-03-12 Thread Jouni Malinen
On Mon, Mar 12, 2007 at 10:56:39AM -0700, Jean Tourrilhes wrote: I would guess that others use iwlib like that too. Which others ? The applications that process scan results can be counted on your fingers. And if you count the one actively developped, you can use one hand. Quick

[patch 2/6] [TULIP] From: Thibaut VARENE [EMAIL PROTECTED]

2007-03-12 Thread Valerie Henson
Fix a problem with Tulip 21142 HP branded PCI cards (PN#: B5509-66001), which feature a NatSemi DP83840A PHY. Without that patch, it is impossible to properly initialize the card's PHY, and it's thus impossible to monitor/configure it. [VAL: I'm happy with the 1.5 ms max delay; it doesn't seem

[patch 5/6] [TULIP] Fix SytemError typo

2007-03-12 Thread Valerie Henson
Fix an annoying typo - SytemError - SystemError Signed-off-by: Valerie Henson [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] --- drivers/net/tulip/interrupt.c |4 ++-- drivers/net/tulip/tulip.h |2 +- drivers/net/tulip/winbond-840.c |2 +- 3 files changed, 4

[patch 6/6] [TULIP] Rev tulip version

2007-03-12 Thread Valerie Henson
Rev tulip version... things have changed since 2002! Signed-off-by: Valerie Henson [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] --- drivers/net/tulip/tulip_core.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- pristine-linux.orig/drivers/net/tulip/tulip_core.c +++

[patch 1/6] [TULIP] From: Jim Gifford [EMAIL PROTECTED], Grant Grundler [EMAIL PROTECTED], Peter Horton [EMAIL PROTECTED]

2007-03-12 Thread Valerie Henson
With Grant's help I was able to get the tulip driver to work with 64 bit MIPS. [VAL: I'm happy with the 1.5 ms max delay; it doesn't seem excessive.] Signed-off-by: Valerie Henson [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] ---

[patch 3/6] [TULIP] fix for Lite-On 82c168 PNIC

2007-03-12 Thread Valerie Henson
From: Guido Classen [EMAIL PROTECTED] This small patch fixes two issues with the Lite-On 82c168 PNIC adapters. I've tested it with two cards in different machines both chip rev 17 The first is the wrong register address CSR6 for writing the MII register which instead is 0xB8 (this may get a

[patch 4/6] [TULIP] Quiet down tulip_stop_rxtx

2007-03-12 Thread Valerie Henson
Only print out debugging info for tulip_stop_rxtx if debug is on. Many cards (including at least two of my own) fail to stop properly during initialization according to this test with no apparent ill effects. Worse, it tends to spam logs when the driver doesn't work. Signed-off-by: Val Henson

Re: [PATCH] natsemi: netpoll fixes

2007-03-12 Thread Mark Huth
Mark Brown wrote: On Sat, Mar 10, 2007 at 11:25:05PM +0300, Sergei Shtylyov wrote: Oops, I was going to recast the patch but my attention switched elsewhere for couple of days, and it slipped into mainline. I'm now preparing a better patch to also protect... Ah, I was also

Re: [PATCH] natsemi: netpoll fixes

2007-03-12 Thread Mark Brown
On Mon, Mar 12, 2007 at 04:05:48PM +0300, Sergei Shtylyov wrote: Mark Brown wrote: hands_off is stronger than that - it's used for sync with some of the other code paths like suspend/resume and means don't touch the chip. I've added a new driver local flag instead. I'm not sure it was

Re: [PATCH] natsemi: netpoll fixes

2007-03-12 Thread Sergei Shtylyov
Hello, I wrote: Subject: natsemi: Fix NAPI for interrupt sharing To: Jeff Garzik [EMAIL PROTECTED] Cc: Sergei Shtylyov [EMAIL PROTECTED], Simon Blake [EMAIL PROTECTED], John Philips [EMAIL PROTECTED], netdev@vger.kernel.org The interrupt status register for the natsemi chips is clear on

Re: wireless extensions vs. 64-bit architectures

2007-03-12 Thread Jean Tourrilhes
On Mon, Mar 12, 2007 at 10:21:49AM -0800, Jouni Malinen wrote: On Mon, Mar 12, 2007 at 10:56:39AM -0700, Jean Tourrilhes wrote: I would guess that others use iwlib like that too. Which others ? The applications that process scan results can be counted on your fingers. And if you

[patch 1/4] network dev read_mostly

2007-03-12 Thread Stephen Hemminger
For Eric, mark packet type and network device watermarks as read mostly. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net/core/dev.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 3f0c468..c82a56b 100644 ---

[patch 3/4] net: show bound packet types

2007-03-12 Thread Stephen Hemminger
Show what protocols are bound to what packet types in /proc/net/ptype Uses kallsyms to decode function pointers if possible. Example: Type Device Function ALL eth1 packet_rcv_spkt+0x0 0800 ip_rcv+0x0 0806 arp_rcv+0x0 86dd

[patch 2/4] net: make seq_operations const

2007-03-12 Thread Stephen Hemminger
The seq_file operations stuff can be marked constant to get it out of dirty cache. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net/core/dev.c |4 ++-- net/core/dev_mcast.c |2 +- net/core/neighbour.c |2 +- net/core/sock.c |2 +- net/core/wireless.c |2

[patch 4/4] tcp: statistics not read_mostly

2007-03-12 Thread Stephen Hemminger
The TCP statistics shouldn't be located in the middle of the read_mostly section surrounded by sysctl values. Move EXPORT_SYMBOL next to data like other declarations near by. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net/ipv4/tcp.c |4 ++-- 1 file changed, 2 insertions(+), 2

Re: [patch 4/4] tcp: statistics not read_mostly

2007-03-12 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 14:08:21 -0700 The TCP statistics shouldn't be located in the middle of the read_mostly section surrounded by sysctl values. Move EXPORT_SYMBOL next to data like other declarations near by. Signed-off-by: Stephen Hemminger

Re: [PATCHES 00/18] skb-nh refactorings

2007-03-12 Thread David Miller
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 01:26:18 -0300 Paving the way for turning the layer headers offsets, to shrink struct sk_buff on 64bits (and perhaps on 32 bits too), this time for skb-nh, more on this layer still to come (ip_hdr(), etc).

Re: [patch 4/4] tcp: statistics not read_mostly

2007-03-12 Thread Stephen Hemminger
On Mon, 12 Mar 2007 14:15:50 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 14:08:21 -0700 The TCP statistics shouldn't be located in the middle of the read_mostly section surrounded by sysctl values. Move EXPORT_SYMBOL

Re: [patch 4/4] tcp: statistics not read_mostly

2007-03-12 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 14:26:47 -0700 On Mon, 12 Mar 2007 14:15:50 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: Look at the definition of DEFINE_SNMP_STAT(). Okay, that's confusing. And maybe the comment suggests future work: Indeed. /*

Re: [patch 1/4] network dev read_mostly

2007-03-12 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 14:08:18 -0700 For Eric, mark packet type and network device watermarks as read mostly. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [patch 2/4] net: make seq_operations const

2007-03-12 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 14:08:19 -0700 The seq_file operations stuff can be marked constant to get it out of dirty cache. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe netdev in

Re: [patch 3/4] net: show bound packet types

2007-03-12 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 14:08:20 -0700 Show what protocols are bound to what packet types in /proc/net/ptype Uses kallsyms to decode function pointers if possible. Example: Type Device Function ALL eth1 packet_rcv_spkt+0x0

Re: [PATCH] NetLabel: parse the CIPSO ranged tag on incoming packets

2007-03-12 Thread David Miller
From: James Morris [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 10:50:41 -0400 (EDT) On Mon, 12 Mar 2007, Paul Moore wrote: Commit 484b366932be0b73a22c74a82748ca10a721643e added support for the CIPSO ranged categories tag. However, it appears that I made a mistake when rebasing then

Re: [PATCH] skge: set mac address bonding fix

2007-03-12 Thread Chris Stromsoe
On Mon, 12 Mar 2007, Stephen Hemminger wrote: When bonding does fail over it calls set_mac_address. When this happens as the result of another port going down, the phy_mutex that is common to both ports is held, so it deadlocks. Setting the address doesn't need to do anything that needs the

bridge: faster compare for link local addresses

2007-03-12 Thread Stephen Hemminger
Use logic operations rather than memcmp() to compare destination address with link local multicast addresses. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net/bridge/br_input.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) --- netem-dev.orig/net/bridge/br_input.c +++

Re: bridge: faster compare for link local addresses

2007-03-12 Thread Rick Jones
Stephen Hemminger wrote: Use logic operations rather than memcmp() to compare destination address with link local multicast addresses. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net/bridge/br_input.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) ---

Re: bridge: faster compare for link local addresses

2007-03-12 Thread David Miller
From: Rick Jones [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 17:05:39 -0700 Being paranoid - are there no worries about the alignment of dest? If it's an issue, it's an issue elsewhere too, as the places where Stephen took this idiomatic code from is the code ethernet handling and that runs on

Re: [PATCH]: double SAs are created when using AH and ESP together

2007-03-12 Thread David Miller
From: Joy Latten [EMAIL PROTECTED] Date: Fri, 9 Mar 2007 17:14:54 -0600 I noticed that in xfrm_state_add we look for the larval SA in a few places without checking for protocol match. So when using both AH and ESP, whichever one gets added first, deletes the larval SA. It seems AH always

Re: [PATCH] natsemi: netpoll fixes

2007-03-12 Thread Mark Brown
On Mon, Mar 12, 2007 at 12:05:46PM -0700, Mark Huth wrote: Since the interrupts are enabled as the NAPI-callback exits, and the interrupts are disabled in the isr after the callback is scheduled, this fully avoids the potential race conditions, and requires no locking. If I've benchmarked

[PATCHES 0/6] Turn skb-nh into a union of just one member 8)

2007-03-12 Thread Arnaldo Carvalho de Melo
Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22 As the last csets says its just a temporary situation :-) - Arnaldo - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

[PATCH 1/6] [SK_BUFF] ipmr: Missed one conversion to skb_network_header()

2007-03-12 Thread Arnaldo Carvalho de Melo
We can't access skb-nh.raw directly anymore, it will become an offset. Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/ipv4/ipmr.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) From 6a25eaa8be613a28f7d2a73f754696661fdc55db Mon Sep 17 00:00:00 2001 From: Arnaldo

[PATCH 3/6] [IPMR]: Fix bug introduced when converting to skb_network_reset_header

2007-03-12 Thread Arnaldo Carvalho de Melo
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- net/ipv4/ipmr.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) From 69e23550a51ee47dbf0b2105874a0c79701a726f Mon Sep 17 00:00:00 2001 From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 20:09:36 -0300

[PATCH 5/6] [SK_BUFF]: Introduce arp_hdr(), remove skb-nh.arph

2007-03-12 Thread Arnaldo Carvalho de Melo
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] --- drivers/net/bonding/bond_main.c|2 +- drivers/net/chelsio/sge.c |2 +- include/linux/if_arp.h |9 + include/linux/skbuff.h |1 - net/bridge/br_netfilter.c |2 +-

Clarification required about select vs wake_up race condition

2007-03-12 Thread Ravinandan Arakali \(rarakali\)
Hi, I am facing following problem and was wondering if somebody could help me out. I reference our char driver below but the question I really have is about sleep/wake_up mechanism. So, I thought somebody who is aware of this can help me. BTW, this is 2.6.10. Our char driver(pretty much like all

Re: [PATCHES 0/6] Turn skb-nh into a union of just one member 8)

2007-03-12 Thread David Miller
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 22:27:06 -0300 Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22 As the last csets says its just a temporary situation :-) There is no stopping

Re: [PATCHES 0/6] Turn skb-nh into a union of just one member 8)

2007-03-12 Thread Arnaldo Carvalho de Melo
On 3/12/07, David Miller [EMAIL PROTECTED] wrote: From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 22:27:06 -0300 Hi David, Please consider pulling from: master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.22 As the last csets says its

Re: [PATCH 1/3] Remove ourselves from waitqueue when receiving a signal

2007-03-12 Thread David Miller
From: [EMAIL PROTECTED] Date: Sun, 11 Mar 2007 22:53:20 + Signed-off-by: Ralf Baechle [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] Convert to use modern wait queue API

2007-03-12 Thread David Miller
From: [EMAIL PROTECTED] Date: Sun, 11 Mar 2007 22:53:22 + Signed-off-by: Ralf Baechle [EMAIL PROTECTED] I'll stick this into net-2.6.22 after Linus pulls in today's fixes and I rebase net-2.6.22 using that. Thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the

Re: 2.6.21-rc3-git4 ata1.00: qc timeout (cmd 0xef) (crashdump kernel)

2007-03-12 Thread Tejun Heo
Thomas Gleixner wrote: On Mon, 2007-03-12 at 17:31 +0100, Michal Piotrowski wrote: Calling initcall 0xc19154d8: piix_ide_init+0x0/0xbb() Calling initcall 0xc19155b6: generic_ide_init+0x0/0x16() Calling initcall 0xc191572e: ide_init+0x0/0x81() Uniform Multi-Platform E-IDE driver Revision:

Re: 2.6.21-rc3-git4 ata1.00: qc timeout (cmd 0xef) (crashdump kernel)

2007-03-12 Thread Michal Piotrowski
On 12/03/07, Tejun Heo [EMAIL PROTECTED] wrote: Thomas Gleixner wrote: On Tue, 2007-03-13 at 01:37 +0900, Tejun Heo wrote: Michal Piotrowski wrote: Calling initcall 0xc19154d8: piix_ide_init+0x0/0xbb() Calling initcall 0xc19155b6: generic_ide_init+0x0/0x16() Calling initcall 0xc191572e:

Re: 2.6.21-rc3-git4 ata1.00: qc timeout (cmd 0xef) (crashdump kernel)

2007-03-12 Thread Stephen Hemminger
On Tue, 13 Mar 2007 01:56:36 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Thomas Gleixner wrote: On Mon, 2007-03-12 at 17:31 +0100, Michal Piotrowski wrote: Calling initcall 0xc19154d8: piix_ide_init+0x0/0xbb() Calling initcall 0xc19155b6: generic_ide_init+0x0/0x16() Calling initcall

Re: 2.6.21-rc3-git4 ata1.00: qc timeout (cmd 0xef) (crashdump kernel)

2007-03-12 Thread Tejun Heo
Stephen Hemminger wrote: 1. the controller has IRQ stuck high (infrequent but possible) 2. the IRQ is already requested by another device 3. the IRQ gets disabled due to screaming interrupts at the moment ata_piix does pci_enable_device(). I think we can be much more resilient to screaming

Re: 2.6.21-rc3-git4 ata1.00: qc timeout (cmd 0xef) (crashdump kernel)

2007-03-12 Thread Stephen Hemminger
On Tue, 13 Mar 2007 04:03:00 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Stephen Hemminger wrote: 1. the controller has IRQ stuck high (infrequent but possible) 2. the IRQ is already requested by another device 3. the IRQ gets disabled due to screaming interrupts at the moment ata_piix does

Re: 2.6.21-rc3-git4 ata1.00: qc timeout (cmd 0xef) (crashdump kernel)

2007-03-12 Thread Tejun Heo
Stephen Hemminger wrote: On Tue, 13 Mar 2007 04:03:00 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Stephen Hemminger wrote: 1. the controller has IRQ stuck high (infrequent but possible) 2. the IRQ is already requested by another device 3. the IRQ gets disabled due to screaming interrupts at

Re: [PATCH 0/5] NetXen: Driver bug fixes

2007-03-12 Thread Amit Kale
On Monday 12 March 2007 20:01, Jeff Garzik wrote: Amit Kale wrote: On Saturday 10 March 2007 16:52, Jeff Garzik wrote: Amit Kale wrote: On Friday 09 March 2007 22:26, Jeff Garzik wrote: Linsys Contractor Mithlesh Thukral wrote: Hi All, I will be sending updates to NetXen: 1G/10G

Re: [patch 1/4] network dev read_mostly

2007-03-12 Thread Eric Dumazet
Stephen Hemminger a écrit : For Eric, mark packet type and network device watermarks as read mostly. ;) static DEFINE_SPINLOCK(ptype_lock); -static struct list_head ptype_base[16];/* 16 way hashed list */ -static struct list_head ptype_all; /* Taps */ +static struct

Re: [PATCH 4/4] PPPoE: race between interface going down and release()

2007-03-12 Thread Florian Zumbiehl
Hi, Attached below is my take on how to address this problem. This addresses any concerns you may have had about checking po-pppoe_dev==NULL, because accesses to this field are now synchronized with pppoe_hash_lock. That indeed looks like a much cleaner solution, so I'd certainly prefer

RE: [PATCH 1/2] NET: Multiple queue network device support

2007-03-12 Thread Waskiewicz Jr, Peter P
-Original Message- From: Jarek Poplawski [mailto:[EMAIL PROTECTED] Sent: Monday, March 12, 2007 1:58 AM To: Thomas Graf Cc: Kok, Auke-jan H; David Miller; Garzik, Jeff; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Waskiewicz Jr, Peter P; Brandeburg, Jesse; Kok, Auke;

Removal of multipath cached (was Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.)

2007-03-12 Thread David Miller
From: Jarek Poplawski [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 12:51:37 +0100 But until then it'll unnecessarily spoil linux opinion as regards stability and waste time of developers to check error messages. So, maybe it's less evil to check those NULLs where possible and add some WARN_ONs

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-12 Thread David Miller
From: Pekka Enberg [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 14:36:46 +0200 On 3/12/07, Jarek Poplawski [EMAIL PROTECTED] wrote: So, maybe it's less evil to check those NULLs where possible and add some WARN_ONs here and there... No, it's much better to oops rather than paper over a bug.

Re: [PATCH] [REVISED] net/ipv4/multipath_wrandom.c: check kmalloc() return value.

2007-03-12 Thread David Miller
From: Pekka J Enberg [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 14:15:16 +0200 (EET) On 3/9/07, David Miller [EMAIL PROTECTED] wrote: The whole cahce-multipath subsystem has to have it's guts revamped for proper error handling. (Untested patch follows.) I'm not accepting untested patches,

Re: [PATCH] tcp_cubic: use 32 bit math

2007-03-12 Thread Stephen Hemminger
On Sat, 10 Mar 2007 12:48:26 +0100 Willy Tarreau [EMAIL PROTECTED] wrote: On Wed, Mar 07, 2007 at 07:51:35PM -0800, David Miller wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 07 Mar 2007 19:10:47 -0800 David Miller wrote: What about Willy Tarreau's supposedly even

Re: [git patches] net driver fixes

2007-03-12 Thread David Miller
From: Geert Uytterhoeven [EMAIL PROTECTED] Date: Mon, 12 Mar 2007 11:02:43 +0100 (CET) On Tue, 6 Mar 2007, Jeff Garzik wrote: Jay Vosburgh (3): bonding: Improve IGMP join processing ip_mc_rejoin_group: Kill warning about unused variable `in_dev' when CONFIG_IP_MULTICAST is not set.

Re: lockdep question (was Re: IPoIB caused a kernel: BUG: softlockup detected on CPU#0!)

2007-03-12 Thread Michael S. Tsirkin
Quoting Ingo Molnar [EMAIL PROTECTED]: Subject: Re: lockdep question (was Re: IPoIB caused a kernel: BUG: softlockup detected on CPU#0!) * Michael S. Tsirkin [EMAIL PROTECTED] wrote: could you turn on CONFIG_SLAB_DEBUG as well? that should catch certain types of use-after-free