Re: [PATCH] Fix race condition about network device name allocation

On Wed, Jun 13, 2007 at 09:36:31AM -0700, Stephen Hemminger wrote: On Wed, 13 Jun 2007 12:45:21 +0300 Dan Aloni [EMAIL PROTECTED] wrote: On Mon, May 14, 2007 at 08:58:40AM -0700, Stephen Hemminger wrote: Kenji Kaneshige found this race between device removal and registration. On

Re: [2/2] 2.6.22-rc4: known regressions with patches v3

A Wednesday 13 June 2007 21:35:02, Greg KH escreveu: On Wed, Jun 13, 2007 at 09:58:05PM +0200, Michal Piotrowski wrote: USB Subject: list_add corruption. prev-next should be next (f7d28794), but was f0df8ed4 (prev=f0df8ed4) Kernel Bug at lib/list_debug.c:33 References :

[PATCH] ehea: Whitespace cleanup

This patch fixes several whitespace issues. Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED] --- diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h index c0f81b5..abaf3ac 100644 --- a/drivers/net/ehea/ehea.h +++ b/drivers/net/ehea/ehea.h @@ -39,7 +39,7 @@ #include asm/io.h

[IPV6] addrconf: Fix IPv6 on tuntap tunnels

Hi Dave: [IPV6] addrconf: Fix IPv6 on tuntap tunnels The recent patch that added ipv6_hwtype is broken on tuntap tunnels. Indeed, it's broken on any device that does not pass the ipv6_hwtype test. The reason is that the original test only applies to autoconfiguration, not IPv6 support. IPv6

Re: Fwd: [PATCH] [-mm] ACPI: export ACPI events via netlink

Hi, Jamal, Now the genl utility can find the acpi event genetlink family. And a simple user space demo is finished for handling acpi event. I really appreciate your help. :) I think the patch which exposes ACPI events via netlink is ok. But I still have some problems on how to listen to

[PATCH] [TCP]: Add missing break to TCP option parsing code

This flaw does not affect any behavior (currently). Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] --- net/ipv4/tcp_input.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index d506bdc..aaf6f66 100644 ---

Re: [2/2] 2.6.22-rc4: known regressions v3

Hi All, They apear as soon as simpleinit starts up. Somtimes I get to a login prompt before seeing any. Other times, commands in the simpleinit rc script fail. They do apear to be random. If a command failes, you re-run the command and it is OK. Commands seen to fail are basic (depmod, rm

[PATCH]is_power_of_2-net/core/neighbour.c

Replacing (n (n-1)) in the context of power of 2 checks with is_power_of_2 Signed-off-by: vignesh babu [EMAIL PROTECTED] --- diff --git a/net/core/neighbour.c b/net/core/neighbour.c index 6f3bb73..e663999 100644 --- a/net/core/neighbour.c +++ b/net/core/neighbour.c @@ -33,6 +33,7 @@ #include

Re: [PATCH 2/2] qdisc_restart - couple of optimizations.

On Wed, Jun 13, 2007 at 02:10:49PM +0530, Krishna Kumar wrote: - BUG_ON((int) q-q.qlen 0) was a relic from old times when -1 meant more packets are available, and __qdisc_run used to loop when qdisc_restart() returned -1. During those days, it was necessary to make sure that qlen is

Re: [PATCH 2/2] qdisc_restart - couple of optimizations.

On Wed, Jun 13, 2007 at 10:51:00AM -0700, Waskiewicz Jr, Peter P wrote: I somewhat disagree here. The underlying driver can conceivably stop the device queue even if the stack holds the queue lock during an interrupt to clean Tx descriptors, and it finds it's out of them or needs to grab

Re: Fwd: [PATCH] [-mm] ACPI: export ACPI events via netlink

On Thu, 2007-14-06 at 16:59 +0800, Zhang Rui wrote: Hi, Jamal, Now the genl utility can find the acpi event genetlink family. And a simple user space demo is finished for handling acpi event. I really appreciate your help. :) np. I think the patch which exposes ACPI events via netlink is

Re: [PATCH] NET: Multiqueue network device support.

Hi Yi, On Thu, 2007-14-06 at 10:44 +0800, Zhu Yi wrote: On Wed, 2007-06-13 at 08:32 -0400, jamal wrote: The key arguement i make (from day one actually) is to leave the majority of the work to the driver. But it seems not feasible the Qdisc needs to know nothing about the hardware rings.

Re: [PATCH][RFC] network splice receive v2

On Wed, Jun 13, 2007 at 12:01:04PM +0400, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: I will rebase my tree, likely something was not merged correctly. Ok, I've just rebased a tree from recent git and pulled from brick - things seems to be settled. I've ran several tests with different

Re: [PATCH][RFC] network splice receive v2

On Thu, Jun 14 2007, Evgeniy Polyakov wrote: On Wed, Jun 13, 2007 at 12:01:04PM +0400, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: I will rebase my tree, likely something was not merged correctly. Ok, I've just rebased a tree from recent git and pulled from brick - things seems to be

Re: [PATCH]: ps3: gigabit ethernet driver for PS3

Hi Jeff, Thanks for your comment. I'll fix coding style issues. On Wed, 13 Jun 2007 16:27:32 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: --- a/drivers/net/Makefile +++ b/drivers/net/Makefile @@ -60,6 +60,8 @@ obj-$(CONFIG_TIGON3) += tg3.o obj-$(CONFIG_BNX2) += bnx2.o spidernet-y +=

Re: [2/2] 2.6.22-rc4: known regressions v3

On Thu, Jun 14, 2007 at 11:30:25AM +0100, Mark Fortescue wrote: They apear as soon as simpleinit starts up. Somtimes I get to a login prompt before seeing any. Other times, commands in the simpleinit rc script fail. They do apear to be random. If a command failes, you re-run the command

Re: [2/2] 2.6.22-rc4: known regressions v3

Benh's ptep_set_access_flags() patch needs to be applied in order to get anyware with sun4c for all kernels = linux-2.6.15. If not applied, you will be lucky to get sash running as your init and even that will have very limitit capabilities before it locks up the processor (power up reset

Re: Realtek r8168 slow outbound transfer - potential fix/workaround

What is the value of the MTU for your 8168 device ? Hi Francois, The MTU for the adapter is set at the default of 1500. A bit more background on how I came across this might be in order. I noticed it when performing very simple SQL queries against a postgres database on my server. I

Re: [2/2] 2.6.22-rc4: known regressions v3

On Thu, Jun 14, 2007 at 03:57:25PM +0100, Mark Fortescue wrote: Benh's ptep_set_access_flags() patch needs to be applied in order to get anyware with sun4c for all kernels = linux-2.6.15. If not applied, you will be lucky to get sash running as your init and even that will have very limitit

Re: r8169 tx problem (1s pause with ping)

Francois Romieu wrote: Benjamin LaHaise [EMAIL PROTECTED] : [...] I'm seeing something odd with r8169 on FC7: doing a ping -s 1600 alternates between a 1s latency and sub 1ms. Has anyone else seen anything like this? The system in question is an Asus M2A-VM with an onboard RTL8111 (I think).

RE: [PATCH 2/2] qdisc_restart - couple of optimizations.

IMHO this scenario occurs so infrequently that the check isn't worth it especially since the driver has to be able to deal with us calling it after netif_stop_queue() anyway. That sounds just fine to me. Thanks Krishna and Herbert for weighing in on this. -PJ Waskiewicz - To unsubscribe

Re: [PATCH] [TCP]: Add missing break to TCP option parsing code

From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Thu, 14 Jun 2007 12:37:22 +0300 (EEST) This flaw does not affect any behavior (currently). Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] Good catch, patch applied. Thanks! - To unsubscribe from this list: send the line unsubscribe netdev in the

Re: [IPV6] addrconf: Fix IPv6 on tuntap tunnels

From: Herbert Xu [EMAIL PROTECTED] Date: Thu, 14 Jun 2007 18:16:07 +1000 [IPV6] addrconf: Fix IPv6 on tuntap tunnels The recent patch that added ipv6_hwtype is broken on tuntap tunnels. Indeed, it's broken on any device that does not pass the ipv6_hwtype test. The reason is that the

Re: [GIT PATCHES] SCTP bugfixes

From: Vlad Yasevich [EMAIL PROTECTED] Date: Wed, 13 Jun 2007 17:23:03 -0400 Please pull the following SCTP patches from master.kernel.org:/pub/scm/linux/kernel/git/vxy/lksctp-dev.git Pulled, thanks a lot Vlad. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

[PATCH 2.6.22-rc4-git6] forcedeth: use unicast receive mode for WoL

I happened to notice that a system with an NVidia NIC using the forcedeth driver won't wake-on-LAN if the interface was in promiscuous mode when you power off. By experiment, it looks like the hardware needs to have NvRegPacketFilterFlags set to NVREG_PFF_ALWAYS|NVREG_PFF_MYADDR (i.e., receive

Re: [ANNOUNCE] new driver ixgbe for Intel(R) 10GbE PCI Express adapters.

Ayyappan Veeraiyan [EMAIL PROTECTED] : [...] netpoll_send_skb should not deadlock because ixgbe_xmit_frame should bail out because of this... if (!spin_trylock_irqsave(tx_ring-tx_lock, flags)) /* Collision - tell upper layer to requeue */ return

Re: [2/2] 2.6.22-rc4: known regressions v3

On Wed, 13 Jun 2007 21:57:56 +0200 Michal Piotrowski [EMAIL PROTECTED] wrote: Hi all, Here is a list of some known regressions in 2.6.22-rc4. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions Networking Subject: commit

Re: [PATCH 1/15] spidernet: null out skb pointer after its been used.

On Wed, Jun 13, 2007 at 04:10:17PM -0400, Jeff Garzik wrote: Linas Vepstas wrote: Avoid kernel crash in mm/slab.c due to double-free of pointer. If the ethernet interface is brought down while there is still RX traffic in flight, the device shutdown routine can end up trying to double-free

Re: r8169 tx problem (1s pause with ping)

David Gundersen [EMAIL PROTECTED] : [...] I might do some more thorough testing on the weekend to find out what the minimal changes required are to get things working. In your patch, the first chunk of data (which is handed back to the nic outside of rtl8169_xmit_frags) will not have is First

Re: [Cbe-oss-dev] [PATCH 0/15] spidernet driver bug fixes

On Wed, 2007-06-13 at 11:14 -0500, Linas Vepstas wrote: Some googling seems to show that git pull has a bug/feature of ignoring the branch that one is working in, and pulling master no matter what. I have no clue why; this seems broken to me. Branches are generally a PITA -- it's probably

Re: [Cbe-oss-dev] [PATCH 12/15] spidernet: increase the NAPI weight

On Wed, Jun 13, 2007 at 10:49:51PM +0200, Arnd Bergmann wrote: On Wednesday 13 June 2007, Jeff Garzik wrote: +/* We really really want to empty the ring buffer every time, + * so as to avoid the RX ram full bug. So set te napi wieght + * to the ring size. + */ +#define

Handling IPv6 RDNSS in RA

[Re-sending an earlier email, this time with a wider distribution and more details.] I'd like to get opinions on how DNS information packaged with IPv6 Router Advertisement packages should be handled. The OLPC project (laptop.org) is currently planning to use this for DNS autoconfiguration.

Re: [PATCH 4/15] spidernet: silence the ramfull messages

On Wed, Jun 13, 2007 at 04:12:00PM -0400, Jeff Garzik wrote: Linas Vepstas wrote: --- linux-2.6.22-rc1.orig/drivers/net/spider_net.c 2007-06-11 10:02:34.0 -0500 +++ linux-2.6.22-rc1/drivers/net/spider_net.c2007-06-11 11:45:25.0 -0500 @@ -1172,7 +1172,7 @@

Re: [Cbe-oss-dev] [PATCH 0/15] spidernet driver bug fixes

David Woodhouse wrote: On Wed, 2007-06-13 at 11:14 -0500, Linas Vepstas wrote: Some googling seems to show that git pull has a bug/feature of ignoring the branch that one is working in, and pulling master no matter what. I have no clue why; this seems broken to me. Branches are generally a

Re: [Cbe-oss-dev] [PATCH 0/15] spidernet driver bug fixes

On Thu, 2007-06-14 at 19:01 -0400, Jeff Garzik wrote: It makes diffing between lines of development more difficult, takes up more overall space, less cache friendly, ... All of which is much less true if you're sharing object directories or even using alternates. -- dwmw2 - To unsubscribe

Re: [Cbe-oss-dev] [PATCH 0/15] spidernet driver bug fixes

David Woodhouse wrote: On Thu, 2007-06-14 at 19:01 -0400, Jeff Garzik wrote: It makes diffing between lines of development more difficult, takes up more overall space, less cache friendly, ... All of which is much less true if you're sharing object directories or even using alternates.

Re: [Cbe-oss-dev] [PATCH 0/15] spidernet driver bug fixes

On Thu, 2007-06-14 at 19:04 -0400, Jeff Garzik wrote: Think about the actual kernel tree source code, not just the metadata... Disk is cheap. Waiting for the whole damn thing to rebuild after switching branches and back again is less so. Besides, checking it out is optional. -- dwmw2 - To

[PATCH] spidernet: Replace literal with const

Replace literal with const; add bit definitions. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] On Wed, Jun 13, 2007 at 04:12:00PM -0400, Jeff Garzik wrote: A follow-up patch needs to remove the above magic numbers (==numeric constants), replacing them with named constants Here it is.

Re: [Cbe-oss-dev] [PATCH 0/15] spidernet driver bug fixes

On Fri, 2007-06-15 at 00:07 +0100, David Woodhouse wrote: On Thu, 2007-06-14 at 19:04 -0400, Jeff Garzik wrote: Think about the actual kernel tree source code, not just the metadata... Disk is cheap. Waiting for the whole damn thing to rebuild after switching branches and back again is

Re: Fwd: [PATCH] [-mm] ACPI: export ACPI events via netlink

On Thu, 2007-06-14 at 07:28 -0400, jamal wrote: On Thu, 2007-14-06 at 16:59 +0800, Zhang Rui wrote: Hi, Jamal, Now the genl utility can find the acpi event genetlink family. And a simple user space demo is finished for handling acpi event. I really appreciate your help. :) np. I

Re: [PATCH] NET: Multiqueue network device support.

On Thu, 2007-06-14 at 07:48 -0400, jamal wrote: I dont have much time to followup for sometime to come. I have left my answer above. To clarify, incase i wasnt clear, I am saying: a) It is better to have the driver change via some strategy of when to open the tx path than trying to be generic.