Re: [PATCH 4/4] udp: memory accounting in IPv4

2007-12-10 Thread Herbert Xu
On Wed, Dec 05, 2007 at 11:28:34PM -0500, Hideo AOKI wrote: 1. Using sk_forward_alloc and adding socket lock UDP already uses a socket lock to send message. However, it doesn't use the lock to receive message. I wonder if we can also use the lock when sk_forward_alloc is updated in

routing policy based on u32 classifier

2007-12-10 Thread Marco Berizzi
Hello everybody. Kindly, I would like to know if the is any plan to add this feature to a future kernel release. I know that fwmark is able to do this, but there is the limitation in source ip address selection. TIA -- To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH 2/8] [TFRC]: Put RX/TX initialisation into tfrc.c

2007-12-10 Thread Gerrit Renker
| This separates RX/TX initialisation and puts all packet history / loss intervals | initialisation into tfrc.c. | The organisation is uniform: slab declaration - {rx,tx}_init() - {rx,tx}_exit() | | NAK, you can't call a __exit marked routine from a __init marked | routine. | Ok thanks,

Re: [PATCH 5/8] [TFRC]: Loss interval code needs the macros/inlines that were moved

2007-12-10 Thread Gerrit Renker
| |distcc[24516] ERROR: compile /root/.ccache/packet_his.tmp.aspire.home.net.24512.i on _tiptop failed |/usr/src/davem-2.6/net/dccp/ccids/lib/packet_history.c: In function '__one_after_loss': |/usr/src/davem-2.6/net/dccp/ccids/lib/packet_history.c:266: error: lvalue required as

[PATCH 0/3] UCC TDM driver for MPC83xx platforms

2007-12-10 Thread Aggrwal Poonam
There are three patches [PATCH 1/3] drivers/misc : UCC TDM driver for mpc83xx platforms. This driver is usable in VoIP iind of applications to interface with SLIC kind of devices to exchange TDM voice samples. [PATCH 2/3] arch/ : Platform changes - device tree entries for UCC TDM driver for

[PATCH 1/3] UCC based TDM driver for MPC83xx platforms.

2007-12-10 Thread Poonam_Aggrwal-b10812
From: Poonam Agarwal-b10812 [EMAIL PROTECTED] The UCC TDM driver basically multiplexes and demultiplexes data from different channels. It can interface with for example SLIC kind of devices to receive TDM data demultiplex it and send to upper applications. At the transmit end it receives data

[0/4] DST: Distributed storage.

2007-12-10 Thread Evgeniy Polyakov
Distributed storage. I'm pleased to announce the 11'th release of the distributed storage subsystem (DST). This is a maintenance release and includes bug fixes and simple feature extensions only. DST allows to form a storage on top of local and remote nodes and combine them into linear or

[1/4] DST: Distributed storage documentation.

2007-12-10 Thread Evgeniy Polyakov
Distributed storage documentation. Algorithms used in the system, userspace interfaces (sysfs dirs and files), design and implementation details are described here. Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED] diff --git a/Documentation/dst/algorithms.txt

[3/4] DST: Network state machine.

2007-12-10 Thread Evgeniy Polyakov
Network state machine. Includes network async processing state machine and related tasks. Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED] diff --git a/drivers/block/dst/kst.c b/drivers/block/dst/kst.c new file mode 100644 index 000..8fa3387 --- /dev/null +++ b/drivers/block/dst/kst.c @@

[4/4] DST: Algorithms used in distributed storage.

2007-12-10 Thread Evgeniy Polyakov
Algorithms used in distributed storage. Mirror and linear mapping code. Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED] diff --git a/drivers/block/dst/alg_linear.c b/drivers/block/dst/alg_linear.c new file mode 100644 index 000..9dc0976 --- /dev/null +++ b/drivers/block/dst/alg_linear.c

[2/4] DST: Core distributed storage files.

2007-12-10 Thread Evgeniy Polyakov
Core distributed storage files. Include userspace interfaces, initialization, block layer bindings and other core functionality. Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED] diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig index b4c8319..ca6592d 100644 ---

Re: [PATCH 5/8] [TFRC]: Loss interval code needs the macros/inlines that were moved

2007-12-10 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 10, 2007 at 11:31:53AM +, Gerrit Renker escreveu: | |distcc[24516] ERROR: compile /root/.ccache/packet_his.tmp.aspire.home.net.24512.i on _tiptop failed |/usr/src/davem-2.6/net/dccp/ccids/lib/packet_history.c: In function '__one_after_loss': |

[PATCH 0/3] UCC TDM driver for MPC83xx platforms

2007-12-10 Thread Aggrwal Poonam
There are three patches [PATCH 1/3] drivers/misc : UCC TDM driver for mpc83xx platforms. This driver is usable in VoIP iind of applications to interface with SLIC kind of devices to exchange TDM voice samples. [PATCH 2/3] arch/ : Platform changes - device tree entries for UCC TDM driver for

[PATCH 1/3] drivers/misc :UCC based TDM driver for MPC83xx platforms.

2007-12-10 Thread Poonam_Aggrwal-b10812
From: Poonam Aggrwal [EMAIL PROTECTED] The UCC TDM driver basically multiplexes and demultiplexes data from different channels. It can interface with for example SLIC kind of devices to receive TDM data demultiplex it and send to upper applications. At the transmit end it receives data for

[PATCH 2/3] arch/ : Platform changes for UCC TDM driver for MPC8323ERDB.Also includes related QE changes.

2007-12-10 Thread Poonam_Aggrwal-b10812
From: Poonam Aggrwal [EMAIL PROTECTED] This patch makes necessary changes in the QE and UCC framework to support TDM. It also adds support to configure the BRG properly through device tree entries. Includes the device tree changes for UCC TDM driver as well. It also includes device tree entries

[PATCH 3/3] Modified Documentation to explain dts entries for UCC TDM driver.

2007-12-10 Thread Poonam_Aggrwal-b10812
From: Poonam Aggrwal [EMAIL PROTECTED] Modified Documentation to explain new properties introduced for UCC TDM driver. Also two new nodes have been added brg and clocks to configure a BRG from device tree. Signed-off-by: Poonam Aggrwal [EMAIL PROTECTED] Signed-off-by: Ashish Kalra [EMAIL

Re: 2.6.24-rc4-mm1

2007-12-10 Thread Ilpo Järvinen
On Wed, 5 Dec 2007, Andrew Morton wrote: On Thu, 06 Dec 2007 17:59:37 +1100 Reuben Farrelly [EMAIL PROTECTED] wrote: This non fatal oops which I have just noticed may be related to this change then - certainly looks networking related. yep, but it isn't e1000. It's core TCP.

[PATCH] [TCP]: Bind fackets_out state to highest_sack more tightly

2007-12-10 Thread Ilpo Järvinen
Added checks will catch most of the errors if the current complex fack_count counting logic is flawed somewhere. Fackets_out should always be advancable if highest_sack is too because the fackets_out is nowadays accurate (and obviously it must be smaller than packets_out). Signed-off-by: Ilpo

Re: [PATCH] [TCP]: Bind fackets_out state to highest_sack more tightly

2007-12-10 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Mon, 10 Dec 2007 14:27:24 +0200 (EET) Added checks will catch most of the errors if the current complex fack_count counting logic is flawed somewhere. Fackets_out should always be advancable if highest_sack is too because the fackets_out is

Re: [PATCH] [TCP]: Bind fackets_out state to highest_sack more tightly

2007-12-10 Thread Ilpo Järvinen
On Mon, 10 Dec 2007, David Miller wrote: From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Mon, 10 Dec 2007 14:27:24 +0200 (EET) Added checks will catch most of the errors if the current complex fack_count counting logic is flawed somewhere. Fackets_out should always be advancable if

Re: [1/4] DST: Distributed storage documentation.

2007-12-10 Thread Kay Sievers
On Dec 10, 2007 12:47 PM, Evgeniy Polyakov [EMAIL PROTECTED] wrote: diff --git a/Documentation/dst/sysfs.txt b/Documentation/dst/sysfs.txt new file mode 100644 index 000..79d79dc --- /dev/null +++ b/Documentation/dst/sysfs.txt @@ -0,0 +1,30 @@ +This file describes sysfs files created

Re: [1/4] DST: Distributed storage documentation.

2007-12-10 Thread Evgeniy Polyakov
On Mon, Dec 10, 2007 at 01:51:43PM +0100, Kay Sievers ([EMAIL PROTECTED]) wrote: On Dec 10, 2007 12:47 PM, Evgeniy Polyakov [EMAIL PROTECTED] wrote: diff --git a/Documentation/dst/sysfs.txt b/Documentation/dst/sysfs.txt new file mode 100644 index 000..79d79dc --- /dev/null +++

[PATCH 0/4] [TFRC]: Revised Loss Intervals Patches (macro-less, new swap function)

2007-12-10 Thread Gerrit Renker
This revision updates earlier patches, following discussion, and adds one additional cleanup patch at the end. Patch #1: Revision of initialisation patch; fixed calling __exit function from __init function - identified by Arnaldo. Patch #2: Revision - re-converted

[PATCH 2/4] [PATCH v2] [TFRC]: Loss interval code needs the macros/inlines that were moved

2007-12-10 Thread Gerrit Renker
This moves the inlines (which were previously declared as macros) back into packet_history.h since the loss detection code needs to be able to read entries from the RX history in order to create the relevant loss entries: it needs at least tfrc_rx_hist_loss_prev() and tfrc_rx_hist_last_rcv(),

[PATCH 4/4] [CCID3]: Redundant debugging output / documentation

2007-12-10 Thread Gerrit Renker
Each time feedback is sent two lines are printed: ccid3_hc_rx_send_feedback: client ... - entry ccid3_hc_rx_send_feedback: Interval ...usec, X_recv=..., 1/p=... The first line is redundant and thus removed. Further, documentation of ccid3_hc_rx_sock (capitalisation) is made

[PATCH 1/4] [PATCH v2] [TFRC]: Put RX/TX initialisation into tfrc.c

2007-12-10 Thread Gerrit Renker
This separates RX/TX initialisation and puts all packet history / loss intervals initialisation into tfrc.c. The organisation is uniform: slab declaration - {rx,tx}_init() - {rx,tx}_exit() Signed-off-by: Gerrit Renker [EMAIL PROTECTED] --- net/dccp/ccids/lib/packet_history.c | 68

[PATCH 3/4] [PATCH v2] [TFRC]: Ringbuffer to track loss interval history

2007-12-10 Thread Gerrit Renker
A ringbuffer-based implementation of loss interval history is easier to maintain, allocate, and update. The `swap' routine to keep the RX history sorted is due to and was written by Arnaldo Carvalho de Melo, simplifying an earlier macro-based variant. Details: * access to the Loss Interval

Re: [1/4] DST: Distributed storage documentation.

2007-12-10 Thread Kay Sievers
On Mon, 2007-12-10 at 15:58 +0300, Evgeniy Polyakov wrote: On Mon, Dec 10, 2007 at 01:51:43PM +0100, Kay Sievers ([EMAIL PROTECTED]) wrote: On Dec 10, 2007 12:47 PM, Evgeniy Polyakov [EMAIL PROTECTED] wrote: diff --git a/Documentation/dst/sysfs.txt b/Documentation/dst/sysfs.txt new file

Re: [PATCH 0/2] netem: trace enhancement

2007-12-10 Thread Ariane Keller
I finally managed to rewrite the netem trace extension to use rtnetlink communication for the data transfer for user space to kernel space. The kernel patch is available here: http://www.tcn.hypert.net/tcn_kernel_2_6_23_rtnetlink and the iproute patch is here:

Re: [1/4] DST: Distributed storage documentation.

2007-12-10 Thread Evgeniy Polyakov
On Mon, Dec 10, 2007 at 03:31:48PM +0100, Kay Sievers ([EMAIL PROTECTED]) wrote: I meant that for each new device, it will be placed into /sys/devices/its_name, but it can also be accessed via /sys/bus/dst/devices/ Still, it looks like a path. :) Please don't reference any device

RE: routing policy based on u32 classifier

2007-12-10 Thread Brian S Julin
Marco wrote: Hello everybody. Kindly, I would like to know if the is any plan to add this feature to a future kernel release. I know that fwmark is able to do this, but there is the limitation in source ip address selection. Could you explain the limitation? My iptables manpage seems

Re: [1/4] DST: Distributed storage documentation.

2007-12-10 Thread Evgeniy Polyakov
On Mon, Dec 10, 2007 at 05:50:55PM +0300, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: Further questions: Why do you do your own refcounting instead of using kref? That's because I always used atomic operations as a reference counters and did not tried krefs :) They are the same actually

[patch 0/5] ipv6: make af_inet6 subsystems to return an error at init

2007-12-10 Thread Daniel Lezcano
This patchset continue the work to make the different af_inet6 subsystems initialization functions to return an error code and to handle the error to fails safely. It takes into account: * flowlabel * exthdrs * frag * udp * udplite * tcp *

[patch 2/5] ipv6: make extended headers to return an error at initialization

2007-12-10 Thread Daniel Lezcano
This patch factorize the code for the differents init functions for rthdr, nodata, destopt in a single function exthdrs_init. This function returns an error so the af_inet6 module can check correctly the initialization. Signed-off-by: Daniel Lezcano [EMAIL PROTECTED] --- include/net/transp_v6.h

[patch 5/5] ipv6: make the protocol initialization to return an error code

2007-12-10 Thread Daniel Lezcano
This patchset makes the different protocols to return an error code, so the af_inet6 module can check the initialization was correct or not. The raw6 was taken into account to be consistent with the rest of the protocols, but the registration is at the same place. Because the raw6 has its own

[patch 1/5] ipv6: make flowlabel to return an error

2007-12-10 Thread Daniel Lezcano
This patch makes the flowlab subsystem to return an error code and makes some cleanup with procfs ifdefs. The af_inet6 will use the flowlabel init return code to check the initialization was correct. Signed-off-by: Daniel Lezcano [EMAIL PROTECTED] --- include/net/ipv6.h |2 +-

[patch 3/5] ipv6: make frag to return an error at initialization

2007-12-10 Thread Daniel Lezcano
This patch makes the frag_init to return an error code, so the af_inet6 module can handle the error. Signed-off-by: Daniel Lezcano [EMAIL PROTECTED] --- include/net/transp_v6.h |3 ++- net/ipv6/af_inet6.c |8 ++-- net/ipv6/reassembly.c | 16 +--- 3 files changed,

[patch 4/5] ipv6: make inet6_register_protosw to return an error code

2007-12-10 Thread Daniel Lezcano
This patch makes the inet6_register_protosw to return an error code. The different protocols can be aware the registration was successful or not and can pass the error to the initial caller, af_inet6. Signed-off-by: Daniel Lezcano [EMAIL PROTECTED] --- include/net/protocol.h |2 +-

Re: routing policy based on u32 classifier

2007-12-10 Thread Marco Berizzi
Brian S Julin wrote: Marco wrote: Hello everybody. Kindly, I would like to know if the is any plan to add this feature to a future kernel release. I know that fwmark is able to do this, but there is the limitation in source ip address selection. Could you explain the limitation?

Re: [patch 0/5] ipv6: make af_inet6 subsystems to return an error at init

2007-12-10 Thread Daniel Lezcano
Daniel Lezcano wrote: This patchset continue the work to make the different af_inet6 subsystems initialization functions to return an error code and to handle the error to fails safely. It takes into account: * flowlabel * exthdrs * frag * udp * udplite

Re: routing policy based on u32 classifier

2007-12-10 Thread Marco Berizzi
Brian S Julin wrote: Almost clear... why can you not just add src ADSL IP to the fwmark route to set the default source address for locally originating packets? IIRC, it doesn't work because netfilter isn't called in ip source address selection. -- To unsubscribe from this list: send the

[PATCH 2.6.25] netns: struct net content re-work

2007-12-10 Thread Denis V. Lunev
Recently David Miller and Herbert Xu pointed out that struct net becomes overbloated and un-maintainable. There are two solutions: - provide a pointer to a network subsystem definition from struct net. This costs an additional dereferrence - place sub-system definition into the structure itself.

[PATCH 2.6.25] UNIX: remove unused declaration of sysctl_unix_max_dgram_qlen

2007-12-10 Thread Denis V. Lunev
Recently David Miller and Herbert Xu pointed out that struct net becomes overbloated and un-maintainable. There are two solutions: - provide a pointer to a network subsystem definition from struct net. This costs an additional dereferrence - place sub-system definition into the structure itself.

ip neigh show not showing arp cache entries?

2007-12-10 Thread Chris Friesen
I'm seeing some strange behaviour on a 2.6.14 ppc64 system. If I run ip neigh show it prints out nothing, but if I run arp then I see the other nodes on the local network. [EMAIL PROTECTED]:/root ip neigh show [EMAIL PROTECTED]:/root arp -n Address HWtype HWaddress

Re: [PATCH 2.6.25] netns: struct net content re-work

2007-12-10 Thread Daniel Lezcano
Denis V. Lunev wrote: Recently David Miller and Herbert Xu pointed out that struct net becomes overbloated and un-maintainable. There are two solutions: - provide a pointer to a network subsystem definition from struct net. This costs an additional dereferrence - place sub-system definition

htb and UDP packages bigger than 1500

2007-12-10 Thread Arkadiusz Miskiewicz
Hello, I noticed that HTB doesn't properly limit traffic if someone sends UDP packages bigger than 1500. Does HTB have some problems/known limits in this area? There is other traffic in that class and when I drop udp packets bigger than 1500 then remaining traffic is limited properly to

Re: [PATCH 2.6.25] netns: struct net content re-work

2007-12-10 Thread Kirill Korotaev
Daniel Lezcano wrote: Denis V. Lunev wrote: Recently David Miller and Herbert Xu pointed out that struct net becomes overbloated and un-maintainable. There are two solutions: - provide a pointer to a network subsystem definition from struct net. This costs an additional dereferrence - place

Re: ip neigh show not showing arp cache entries?

2007-12-10 Thread Chris Friesen
Chris Friesen wrote: I'm seeing some strange behaviour on a 2.6.14 ppc64 system. If I run ip neigh show it prints out nothing, but if I run arp then I see the other nodes on the local network. [EMAIL PROTECTED]:/root ip neigh show [EMAIL PROTECTED]:/root arp -n Address

[PATCH] IPv6 support for NFS server

2007-12-10 Thread Aurélien Charbon
Here is a cleanup for the ip_map caching patch in nfs server. It prepares for IPv6 text-based mounts and exports. Tests: tested with only IPv4 network and basic nfs ops (mount, file creation and modification) - Signed-off-by: Aurelien Charbon [EMAIL PROTECTED] diff -p -u -r -N

Re: [PATCH] IPv6 support for NFS server

2007-12-10 Thread J. Bruce Fields
On Mon, Dec 10, 2007 at 07:34:41PM +0100, Aurélien Charbon wrote: Here is a cleanup for the ip_map caching patch in nfs server. It prepares for IPv6 text-based mounts and exports. Tests: tested with only IPv4 network and basic nfs ops (mount, file creation and modification) Thanks! And

Re: [PATCH RFC] [3/9] modpost: Declare the modpost error functions as printf like

2007-12-10 Thread Sam Ravnborg
On Thu, Nov 22, 2007 at 03:43:08AM +0100, Andi Kleen wrote: This way gcc can warn for wrong format strings This loks good. Can I get i s-o-b then I will apply it. Sam --- scripts/mod/modpost.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) Index:

Re: [PATCH RFC] [4/9] modpost: Fix format string warnings

2007-12-10 Thread Sam Ravnborg
On Thu, Nov 22, 2007 at 03:43:09AM +0100, Andi Kleen wrote: Fix wrong format strings in modpost exposed by the previous patch. Including one missing argument -- some random data was printed instead. Looks good. Can I get a s-o-b then I will apply it. Sam ---

Re: [PATCH RFC] [3/9] modpost: Declare the modpost error functions as printf like

2007-12-10 Thread Andi Kleen
On Mon, Dec 10, 2007 at 07:50:08PM +0100, Sam Ravnborg wrote: On Thu, Nov 22, 2007 at 03:43:08AM +0100, Andi Kleen wrote: This way gcc can warn for wrong format strings This loks good. Can I get i s-o-b then I will apply it. Sorry must have been left out by mistake. Signed-off-by: Andi

Re: [1/4] DST: Distributed storage documentation.

2007-12-10 Thread Kay Sievers
On Mon, 2007-12-10 at 17:50 +0300, Evgeniy Polyakov wrote: On Mon, Dec 10, 2007 at 03:31:48PM +0100, Kay Sievers ([EMAIL PROTECTED]) wrote: I meant that for each new device, it will be placed into /sys/devices/its_name, but it can also be accessed via /sys/bus/dst/devices/ Still,

Re: [PATCH RFC] [5/9] modpost: Fix a buffer overflow in modpost

2007-12-10 Thread Sam Ravnborg
On Thu, Nov 22, 2007 at 03:43:10AM +0100, Andi Kleen wrote: When passing an file name 1k the stack could be overflowed. Not really a security issue, but still better plugged. Looks good. A s-o-b line again please. Although I am not so happy with the ue of gcc extensions. Sam

[PATCH] drivers/net/ipg: Remove local definition of TRUE/FALSE

2007-12-10 Thread Richard Knutsson
Remove local definition of TRUE/FALSE. Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- diff --git a/drivers/net/ipg.h b/drivers/net/ipg.h index d5d092c..4484778 100644 --- a/drivers/net/ipg.h +++ b/drivers/net/ipg.h @@ -490,38 +490,34 @@ enum ipg_regs { * Tune */ -/*

Re: [1/4] DST: Distributed storage documentation.

2007-12-10 Thread Evgeniy Polyakov
On Mon, Dec 10, 2007 at 08:02:28PM +0100, Kay Sievers ([EMAIL PROTECTED]) wrote: uganda:~/codes# ls -l /sys/devices/storage/n-0-81003ebc220/ total 0 drwxr-xr-x 2 root root0 2007-12-10 13:23 power -r--r--r-- 1 root root 4096 2007-12-10 13:30 size -r--r--r-- 1 root root 4096

[PATCH] iproute2: off by one in nested attribute parse

2007-12-10 Thread Stephen Hemminger
Fix off by one in nested attribute management. Fixes segv in: tc qdisc show dev eth1 due to uninitialized attribute table. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- lib/libnetlink.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/libnetlink.c

Re: [1/4] DST: Distributed storage documentation.

2007-12-10 Thread Kay Sievers
On Mon, 2007-12-10 at 22:33 +0300, Evgeniy Polyakov wrote: On Mon, Dec 10, 2007 at 08:02:28PM +0100, Kay Sievers ([EMAIL PROTECTED]) wrote: uganda:~/codes# ls -l /sys/devices/storage/n-0-81003ebc220/ total 0 drwxr-xr-x 2 root root0 2007-12-10 13:23 power -r--r--r-- 1 root

Re: [1/4] DST: Distributed storage documentation.

2007-12-10 Thread Evgeniy Polyakov
On Mon, Dec 10, 2007 at 08:44:55PM +0100, Kay Sievers ([EMAIL PROTECTED]) wrote: Actually not - I have to set reference counter to something other than 1 or +/- 1, and thus will have to call kref_get() in a loop, which is a very ugly step. Is there kref_set() or somethinglike that? At

Re: [PATCH] drivers/net/ipg: Remove local definition of TRUE/FALSE

2007-12-10 Thread Pekka Enberg
Hi Richard, On Dec 10, 2007 9:29 PM, Richard Knutsson [EMAIL PROTECTED] wrote: Remove local definition of TRUE/FALSE. This is already fixed in Francois' tree: http://git.kernel.org/?p=linux/kernel/git/romieu/netdev-2.6.git;a=commitdiff;h=2af61e99e3d1c959840ea007ff56b15db794fb99

Re: [1/4] DST: Distributed storage documentation.

2007-12-10 Thread Kay Sievers
On Mon, 2007-12-10 at 22:51 +0300, Evgeniy Polyakov wrote: On Mon, Dec 10, 2007 at 08:44:55PM +0100, Kay Sievers ([EMAIL PROTECTED]) wrote: Actually not - I have to set reference counter to something other than 1 or +/- 1, and thus will have to call kref_get() in a loop, which

Re: [PATCH RFC] [5/9] modpost: Fix a buffer overflow in modpost

2007-12-10 Thread Andi Kleen
On Monday 10 December 2007 20:32, Sam Ravnborg wrote: On Thu, Nov 22, 2007 at 03:43:10AM +0100, Andi Kleen wrote: When passing an file name 1k the stack could be overflowed. Not really a security issue, but still better plugged. Looks good. A s-o-b line again please. Signed-off-by: Andi

Re: [1/4] DST: Distributed storage documentation.

2007-12-10 Thread Evgeniy Polyakov
On Mon, Dec 10, 2007 at 08:56:49PM +0100, Kay Sievers ([EMAIL PROTECTED]) wrote: On Mon, 2007-12-10 at 22:51 +0300, Evgeniy Polyakov wrote: On Mon, Dec 10, 2007 at 08:44:55PM +0100, Kay Sievers ([EMAIL PROTECTED]) wrote: Actually not - I have to set reference counter to something other

Re: 2.6.24-rc4-mm1

2007-12-10 Thread Ilpo Järvinen
On Mon, 10 Dec 2007, Ilpo Järvinen wrote: Dave, please include this one to net-2.6.25. ... -- [PATCH] [TCP]: Fix fack_count miscountings (multiple places) I've better version of this coming up, so Dave please don't put this one into net-2.6.25 (noticed that both the original and the after

Re: [PATCH RFC] [5/9] modpost: Fix a buffer overflow in modpost

2007-12-10 Thread Sam Ravnborg
On Mon, Dec 10, 2007 at 08:57:28PM +0100, Andi Kleen wrote: On Monday 10 December 2007 20:32, Sam Ravnborg wrote: On Thu, Nov 22, 2007 at 03:43:10AM +0100, Andi Kleen wrote: When passing an file name 1k the stack could be overflowed. Not really a security issue, but still better plugged.

Re: [PATCH] drivers/net/ipg: Remove local definition of TRUE/FALSE

2007-12-10 Thread Richard Knutsson
Pekka Enberg wrote: Hi Richard, On Dec 10, 2007 9:29 PM, Richard Knutsson [EMAIL PROTECTED] wrote: Remove local definition of TRUE/FALSE. This is already fixed in Francois' tree:

Re: [PATCH 8/8] [PATCH v2] [CCID3]: Interface CCID3 code with newer Loss Intervals Database

2007-12-10 Thread Arnaldo Carvalho de Melo
Em Sat, Dec 08, 2007 at 10:06:28AM +, Gerrit Renker escreveu: This hooks up the TFRC Loss Interval database with CCID 3 packet reception. In addition, it makes the CCID-specific computation of the first loss interval (which requires access to all the guts of CCID3) local to ccid3.c. The

Re: 2.6.24-rc4-mm1

2007-12-10 Thread Andrew Morton
On Tue, 11 Dec 2007 01:48:39 +1100 Reuben Farrelly [EMAIL PROTECTED] wrote: On 5/12/2007 4:17 PM, Andrew Morton wrote: Temporarily at http://userweb.kernel.org/~akpm/2.6.24-rc4-mm1/ Will appear later at

[PATCH net-2.6.25] qdisc: new rate limiter (v2)

2007-12-10 Thread Stephen Hemminger
This is a time based rate limiter for use in network testing. When doing network tests it is often useful to test at reduced bandwidths. The existing Token Bucket Filter provides rate control, but causes bursty traffic that can cause different performance than real world. Another alternative is

[PATCH 0/4] Pull request for 'sis190' branch

2007-12-10 Thread Francois Romieu
Please pull from branch 'sis190' in repository git://git.kernel.org/pub/scm/linux/kernel/git/romieu/netdev-2.6.git sis190 to get the changes below. Distance from 'upstream-linus' (7962024e9d16e9349d76b553326f3fa7be64305e) -

[PATCH 2/4] sis190: remove duplicate INIT_WORK

2007-12-10 Thread Francois Romieu
It is already done in sis190_init_one. Signed-off-by: Francois Romieu [EMAIL PROTECTED] Cc: K.M. Liu [EMAIL PROTECTED] --- drivers/net/sis190.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index 51bbb60..f6a921c 100644 ---

[PATCH 3/4] sis190: mdio operation failure is not correctly detected

2007-12-10 Thread Francois Romieu
i ranges from 0 to 100 in the 'for' loop a few lines above. Reported by davem. Signed-off-by: Francois Romieu [EMAIL PROTECTED] Cc: K.M. Liu [EMAIL PROTECTED] --- drivers/net/sis190.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/sis190.c

[PATCH 1/4] sis190: add cmos ram access code for the SiS19x/968 chipset pair

2007-12-10 Thread Francois Romieu
More work is needed to handle correctly the PHY of the new devices when connected to a 10Mb link but this change already helps some users as is. Fix for: http://bugzilla.kernel.org/show_bug.cgi?id=9467 Signed-off-by: Francois Romieu [EMAIL PROTECTED] Cc: K.M. Liu [EMAIL PROTECTED] Cc: J.

[PATCH 4/4] sis190: scheduling while atomic error

2007-12-10 Thread Francois Romieu
sis190_tx_timeout - sis190_hw_start - sis190_soft_reset - msleep *splat* PCI transactions are correctly flushed here. The msleep() is probably useless. Signed-off-by: Francois Romieu [EMAIL PROTECTED] Cc: K.M. Liu [EMAIL PROTECTED] --- drivers/net/sis190.c |2 -- 1 files changed, 0

[IPv4] ESP: Discard dummy packets introduced in rfc4303

2007-12-10 Thread Thomas Graf
RFC4303 introduces dummy packets with a nexthdr value of 59 to implement traffic confidentiality. Such packets need to be dropped silently and the payload may not be attempted to be parsed as it consists of random chunk. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index:

[IPv6] ESP: Discard dummy packets introduced in rfc4303

2007-12-10 Thread Thomas Graf
RFC4303 introduces dummy packets with a nexthdr value of 59 to implement traffic confidentiality. Such packets need to be dropped silently and the payload may not be attempted to be parsed as it consists of random chunk. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index:

Re: [PATCH] [TCP]: Bind fackets_out state to highest_sack more tightly

2007-12-10 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Mon, 10 Dec 2007 14:39:46 +0200 (EET) On Mon, 10 Dec 2007, David Miller wrote: From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Mon, 10 Dec 2007 14:27:24 +0200 (EET) Added checks will catch most of the errors if the current complex fack_count

Re: [PATCH][Take3] PCI legacy I/O port free driver - Making Intel e1000 driver legacy I/O port free

2007-12-10 Thread Kok, Auke
Tomohiro Kusumi wrote: Dear Auke and e1000 maintainers Hi, this is the patch which makes the e1000 driver legacy I/O port free. I've received some advice from Auke quite long time ago, and submitted a patch (http://lkml.org/lkml/2007/8/10/11) which I think meets what Auke had told me.

Re: [PATCH 2/3] arch/ : Platform changes for UCC TDM driver for MPC8323ERDB.Also includes related QE changes.

2007-12-10 Thread Stephen Rothwell
On Mon, 10 Dec 2007 17:39:22 +0530 (IST) Poonam_Aggrwal-b10812 [EMAIL PROTECTED] wrote: +++ b/arch/powerpc/sysdev/qe_lib/qe.c @@ -149,22 +149,116 @@ EXPORT_SYMBOL(qe_issue_cmd); */ static unsigned int brg_clk = 0; -unsigned int get_brg_clk(void) +u32 get_brg_clk(enum qe_clock brgclk,

Re: [patch 0/5] ipv6: make af_inet6 subsystems to return an error at init

2007-12-10 Thread David Miller
From: Daniel Lezcano [EMAIL PROTECTED] Date: Mon, 10 Dec 2007 16:32:50 +0100 I just noticed that I forgot to put ipv6 under bracket. Sorry for that :( Should I resend the patchset ? This is not necessary. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [IPv4] ESP: Discard dummy packets introduced in rfc4303

2007-12-10 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Mon, 10 Dec 2007 23:17:03 +0100 RFC4303 introduces dummy packets with a nexthdr value of 59 to implement traffic confidentiality. Such packets need to be dropped silently and the payload may not be attempted to be parsed as it consists of random

Re: [IPv6] ESP: Discard dummy packets introduced in rfc4303

2007-12-10 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Mon, 10 Dec 2007 23:18:07 +0100 RFC4303 introduces dummy packets with a nexthdr value of 59 to implement traffic confidentiality. Such packets need to be dropped silently and the payload may not be attempted to be parsed as it consists of random

Re: [PATCH 1/3][BNX2]: Add PHY_DIS_EARLY_DAC workaround.

2007-12-10 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Sun, 09 Dec 2007 13:16:48 -0800 [BNX2]: Add PHY_DIS_EARLY_DAC workaround. 5709 Ax and Bx chips all need this workaround. Signed-off-by: Michael Chan [EMAIL PROTECTED] Applied. -- To unsubscribe from this list: send the line unsubscribe netdev in

Re: [PATCH 2/3][BNX2]: Fix RX packet rot.

2007-12-10 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Sun, 09 Dec 2007 13:17:14 -0800 [BNX2]: Fix RX packet rot. Packets can be left in the RX ring if the NAPI budget is reached. This is caused by storing the latest rx index at the beginning of bnx2_rx_int(). We may not process all the work up to

Re: [PATCH 3/3][BNX2]: Update version to 1.6.9.

2007-12-10 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Sun, 09 Dec 2007 13:18:02 -0800 [BNX2]: Update version to 1.6.9. Signed-off-by: Michael Chan [EMAIL PROTECTED] Applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH 4/4] udp: memory accounting in IPv4

2007-12-10 Thread Hideo AOKI
Herbert Xu wrote: On Wed, Dec 05, 2007 at 11:28:34PM -0500, Hideo AOKI wrote: 1. Using sk_forward_alloc and adding socket lock UDP already uses a socket lock to send message. However, it doesn't use the lock to receive message. I wonder if we can also use the lock when

[IPSEC]: Add xfrm_input_state helper

2007-12-10 Thread Herbert Xu
Hi Dave: This is the last patch we need before converting ESP over to crypto_aead. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --

Re: [PATCH 2.6.25] netns: struct net content re-work

2007-12-10 Thread Eric W. Biederman
The idea of separate structures make sense, and seems needed and useful. Denis V. Lunev [EMAIL PROTECTED] writes: diff --git a/include/net/netns/unix.h b/include/net/netns/unix.h new file mode 100644 index 000..27b4e7f --- /dev/null +++ b/include/net/netns/unix.h

[PATCH] NET : dst_ifdown() cleanup

2007-12-10 Thread Eric Dumazet
This cleanup shrinks size of net/core/dst.o on i386 from 1299 to 1289 bytes. (This is because dev_hold()/dev_put() are doing atomic_inc()/atomic_dec() and force compiler to re-evaluate memory contents.) Signed-off-by: Eric Dumazet [EMAIL PROTECTED] diff --git a/net/core/dst.c b/net/core/dst.c

Re: [PATCH 2.6.25] netns: struct net content re-work

2007-12-10 Thread Eric W. Biederman
Kirill Korotaev [EMAIL PROTECTED] writes: Daniel Lezcano wrote: Denis V. Lunev wrote: Recently David Miller and Herbert Xu pointed out that struct net becomes overbloated and un-maintainable. There are two solutions: - provide a pointer to a network subsystem definition from struct net.

Re: [PATCH 2.6.25] netns: struct net content re-work

2007-12-10 Thread David Miller
From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Mon, 10 Dec 2007 21:04:07 -0700 Kirill Korotaev [EMAIL PROTECTED] writes: Daniel Lezcano wrote: Denis V. Lunev wrote: Can you change this from unx to unix ? no, it won't compile. Guess why :) Hmm. It looks like it is a #define

[RFC 0/3] Add AEAD support to ESP

2007-12-10 Thread Herbert Xu
Hi Dave: This series of patches add AEAD support to ESP. Please don't merge it just yet because they depend on what's in the current cryptodev-2.6 tree. Once that tree has settled down I'll ask you to pull it and then these patches can go on top of that. Thanks, -- Visit Openswan at

[PATCH 2/3] [IPSEC]: Allow async algorithms

2007-12-10 Thread Herbert Xu
[IPSEC]: Allow async algorithms Now that ESP uses authenc we can turn on the support for async algorithms in IPsec. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- net/xfrm/xfrm_algo.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/xfrm/xfrm_algo.c

[PATCH 1/3] [IPSEC]: Use crypto_aead and authenc in ESP

2007-12-10 Thread Herbert Xu
[IPSEC]: Use crypto_aead and authenc in ESP This patch converts ESP to use the crypto_aead interface and in particular the authenc algorithm. This lays the foundations for future support of combined mode algorithms. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- include/net/esp.h | 54

[PATCH 3/3] [IPSEC]: Add support for combined mode algorithms

2007-12-10 Thread Herbert Xu
[IPSEC]: Add support for combined mode algorithms This patch adds support for combined mode algorithms with GCM being the first algorithm supported. Combined mode algorithms can be added through the xfrm_user interface using the new algorithm payload type XFRMA_ALG_AEAD. Each algorithms is

[PATCH] NETLINK : kzalloc() conversion

2007-12-10 Thread Eric Dumazet
nl_pid_hash_alloc() is renamed to nl_pid_hash_zalloc(). It is now returning zeroed memory to its callers. Signed-off-by: Eric Dumazet [EMAIL PROTECTED] diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 2e02b19..dbd7cad 100644 --- a/net/netlink/af_netlink.c +++

Re: [PATCH] NETLINK : kzalloc() conversion

2007-12-10 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Tue, 11 Dec 2007 06:40:18 +0100), Eric Dumazet [EMAIL PROTECTED] says: nl_pid_hash_alloc() is renamed to nl_pid_hash_zalloc(). It is now returning zeroed memory to its callers. I do think you do not need (and you should not) rename it because XXX_zalloc()

Re: [PATCH] NETLINK : kzalloc() conversion

2007-12-10 Thread Eric Dumazet
YOSHIFUJI Hideaki / 吉藤英明 a écrit : In article [EMAIL PROTECTED] (at Tue, 11 Dec 2007 06:40:18 +0100), Eric Dumazet [EMAIL PROTECTED] says: nl_pid_hash_alloc() is renamed to nl_pid_hash_zalloc(). It is now returning zeroed memory to its callers. I do think you do not need (and you should

Re: [PATCH 2.6.25] netns: struct net content re-work

2007-12-10 Thread Denis V. Lunev
Eric W. Biederman wrote: The idea of separate structures make sense, and seems needed and useful. Denis V. Lunev [EMAIL PROTECTED] writes: diff --git a/include/net/netns/unix.h b/include/net/netns/unix.h new file mode 100644 index 000..27b4e7f --- /dev/null +++

  1   2   >