Re: sis190 build breakage

2008-01-30 Thread Jeff Garzik
Sam Ravnborg wrote: On Tue, Jan 29, 2008 at 11:03:10PM +0100, Francois Romieu wrote: maximilian attems [EMAIL PROTECTED] : CC [M] drivers/net/sis190.o drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[5]: *** [drivers/net/sis190.o] Error 1 gcc

[PATCH] [1/2] Skip empty hash buckets faster in /proc/net/tcp

2008-01-30 Thread Andi Kleen
On most systems most of the TCP established/time-wait hash buckets are empty. When walking the hash table for /proc/net/tcp their read locks would always be aquired just to find out they're empty. This patch changes the code to check first if the buckets have any entries before taking the lock,

[IPV4] route cache: Introduce rt_genid for smooth cache invalidation

2008-01-30 Thread Eric Dumazet
Current ip route cache implementation is not suited to large caches. We can consume a lot of CPU when cache must be invalidated, since we currently need to evict all cache entries, and this eviction is sometimes asynchronous. min_delay max_delay can somewhat control this asynchronism behavior,

Re: [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver

2008-01-30 Thread Kamalesh Babulal
Gabriel C wrote: Kamalesh Babulal wrote: Hi, The 2.6.24-git6 kernel build fails on various x86_64 machines with the build failure drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[2]: *** [drivers/net/sis190.o] Error 1 # gcc --version (machine1) gcc

Re: [BUILD FAILURE]2.6.24-git6 build failure on sis190 ethernet driver

2008-01-30 Thread Kamalesh Babulal
Sam Ravnborg wrote: On Wed, Jan 30, 2008 at 09:11:36AM +0530, Kamalesh Babulal wrote: Hi, The 2.6.24-git6 kernel build fails on various x86_64 machines with the build failure drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type conflict make[2]: ***

Re: 2.6.24-git6 net build failure when SYSFS=n, PROC_FS=n

2008-01-30 Thread Daniel Lezcano
Randy Dunlap wrote: linux-2.6.24-git6/net/ipv4/fib_frontend.c: In function 'fib_net_init': linux-2.6.24-git6/net/ipv4/fib_frontend.c:1024: error: implicit declaration of function 'fib_proc_init' linux-2.6.24-git6/net/ipv4/fib_frontend.c: In function 'fib_net_exit':

[PATCH] [2/2] Remove some unnecessary gotos in established_get_first()

2008-01-30 Thread Andi Kleen
gcc does not generate different code for return foo vs bar = foo; goto x; x: return bar; So convert it all to direct returns for better readability. Signed-off-by: Andi Kleen [EMAIL PROTECTED] Index: linux/net/ipv4/tcp_ipv4.c ===

Re: [PATCH] [2/2] Remove some unnecessary gotos in established_get_first()

2008-01-30 Thread Oliver Neukum
Am Mittwoch, 30. Januar 2008 09:01:10 schrieb Andi Kleen: gcc does not generate different code for return foo vs bar = foo; goto x; x: return bar; So convert it all to direct returns for better readability. Now suppose somebody needs to change locking. He'll have to convert it back. IMHO a

Re: [PATCH] [2/2] Remove some unnecessary gotos in established_get_first()

2008-01-30 Thread Andi Kleen
Oliver Neukum [EMAIL PROTECTED] writes: Am Mittwoch, 30. Januar 2008 09:01:10 schrieb Andi Kleen: gcc does not generate different code for return foo vs bar = foo; goto x; x: return bar; So convert it all to direct returns for better readability. Now suppose somebody needs to change

Re: [PATCH] cxgb3: Remove incorrect __devinit annotations

2008-01-30 Thread Jeff Garzik
Roland Dreier wrote: When PCI error recovery was added to cxgb3, a function t3_io_slot_reset() was added. This function can call back into t3_prep_adapter() at any time, so t3_prep_adapter() can no longer be marked __devinit. This patch removes the __devinit annotation from t3_prep_adapter()

Re: [PATCH 1/7] bonding: fix parameter parsing

2008-01-30 Thread Jeff Garzik
Jay Vosburgh wrote: My last fix (commit ece95f7fefe3afae19e641e1b3f5e64b00d5b948) didn't handle one case correctly. This resolves that, and it will now correctly parse parameters with arbitrary white space, and either text names or mode values. Signed-off-by: Jay Vosburgh [EMAIL

Re: [PATCH 1/1 resend][arm/at91_ether.c] logical/bitand typo in function reset_phy() (inactive), drivers/net/arm/at91_ether.c

2008-01-30 Thread Jeff Garzik
Roel Kluin wrote: include/linux/mii.h:48:#define BMCR_RESET 0x8000 The function reset_phy() is in #if 0 inactivated code -- Replace logical by bit before BMCR_RESET Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/drivers/net/arm/at91_ether.c b/drivers/net/arm/at91_ether.c index

Re: [PATCH 1/5] forcedeth: reset register fix

2008-01-30 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch fixes the reset register definition from 0x3C to 0x34. Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] applied 1-5 -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] [NET]: Remove PowerPC code from fec.c

2008-01-30 Thread Jeff Garzik
Jochen Friedrich wrote: fec.c is only used on M68k Coldfire CPUs. Remove leftover PowerPC code from this driver. Signed-off-by: Jochen Friedrich [EMAIL PROTECTED] --- drivers/net/fec.c | 136 +--- 1 files changed, 3 insertions(+), 133

Re: [PATCH] forcedeth: mac address mcp77/79

2008-01-30 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch is a critical fix for MCP77 and MCP79 devices. The feature flags were missing the define for correct mac address (DEV_HAS_CORRECT_MACADDR). Signed-off-by: Ayaz Abdulla [EMAIL PROTECTED] applied (upstream) -- To unsubscribe from this list: send the line

Re: [PATCH] PHYLIB: Locking fixes for PHY I/O potentially sleeping

2008-01-30 Thread Jeff Garzik
Nate Case wrote: PHY read/write functions can potentially sleep (e.g., a PHY accessed via I2C). The following changes were made to account for this: * Change spin locks to mutex locks * Add a BUG_ON() to phy_read() phy_write() to warn against calling them from an interrupt

Re: [PATCH] natsemi: Update locking documentation

2008-01-30 Thread Jeff Garzik
Mark Brown wrote: The documentation regarding synchronisation at the head of the natsemi driver was badly bitrotted so replace it with a general statement about the techniques used which is less likely to bitrot. Also remove the note saying these chips are uncommon - it makes little difference

Re: [PATCH] phylib: Add Realtek 821x eth PHY support

2008-01-30 Thread Jeff Garzik
Kim Phillips wrote: this PHY present on the MPC8315E and MPC837xE RDB boards. Signed-off-by: Johnson Leung [EMAIL PROTECTED] Signed-off-by: Kevin Lam [EMAIL PROTECTED] Signed-off-by: Joe D'Abbraccio [EMAIL PROTECTED] Signed-off-by: Kim Phillips [EMAIL PROTECTED] --- drivers/net/phy/Kconfig |

Re: [PATCH] pci-skeleton: Misc fixes to build neatly

2008-01-30 Thread Jeff Garzik
Jike Song wrote: The pci-skeleton.c has several problems with compilation, such as missing args when calling synchronize_irq(). Fix it. Signed-off-by: Jike Song [EMAIL PROTECTED] --- drivers/net/pci-skeleton.c | 49 ++- 1 files changed, 25

Re: [PATCH] NET: constify data and function pointer tables

2008-01-30 Thread Jeff Garzik
Jan Engelhardt wrote: Signed-off-by: Jan Engelhardt [EMAIL PROTECTED] --- drivers/net/bonding/bond_main.c |2 +- drivers/net/hamradio/bpqether.c |2 +- drivers/net/hamradio/scc.c |2 +- drivers/net/hamradio/yam.c |2 +-

Re: ipcomp regression in 2.6.24

2008-01-30 Thread Marco Berizzi
Herbert Xu wrote: Marco Berizzi [EMAIL PROTECTED] wrote: With 2.6.24 IPSEC/ESP tunnels to older kernels establish fine, data flows in both directions, but no data comes out of the tunnel. Needed to disable ipcomp. Same problem here: linux 2.6.24 driven by openswan 2.4.11 on

Re: [PATCH 1/8] [Blackfin] EMAC driver: shorten the mdelay value to solve netperf performance issue

2008-01-30 Thread Jeff Garzik
Bryan Wu wrote: Signed-off-by: Bryan Wu [EMAIL PROTECTED] --- drivers/net/bfin_mac.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) applied 1-8 -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info

[PATCH 5/8] [Blackfin] EMAC driver: ADSP-BF52x arch/mach support

2008-01-30 Thread Bryan Wu
From: Michael Hennerich [EMAIL PROTECTED] Signed-off-by: Michael Hennerich [EMAIL PROTECTED] Signed-off-by: Bryan Wu [EMAIL PROTECTED] --- drivers/net/Kconfig|9 + drivers/net/bfin_mac.c |6 +++--- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git

[PATCH 8/8] [Blackfin] EMAC driver: Fix bug: The clock divisor is set to all ones at reset.

2008-01-30 Thread Bryan Wu
Signed-off-by: Kalle Pokki [EMAIL PROTECTED] Signed-off-by: Bryan Wu [EMAIL PROTECTED] --- drivers/net/bfin_mac.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c index 0a17fb4..c993a32 100644 --- a/drivers/net/bfin_mac.c

[PATCH 7/8] [Blackfin] EMAC driver: fix bug - invalidate data cache of new_skb-data range when cache is WB

2008-01-30 Thread Bryan Wu
From: Alexey Demin [EMAIL PROTECTED] It prevents overwritting new data from DMA. Signed-off-by: Alexey Demin [EMAIL PROTECTED] Signed-off-by: Bryan Wu [EMAIL PROTECTED] --- drivers/net/bfin_mac.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git

[PATCH 6/8] [Blackfin] EMAC driver: add power down mode

2008-01-30 Thread Bryan Wu
From: Vitja Makarov [EMAIL PROTECTED] This patch puts phy in power-down mode when interface is down. Also we should think about energy detect power-down mode, that will decrease power consumption when no link. Signed-off-by: Vitja Makarov [EMAIL PROTECTED] Signed-off-by: Bryan Wu [EMAIL

[PATCH 3/8] [Blackfin] EMAC driver: bf537 MAC multicast hash filtering patch

2008-01-30 Thread Bryan Wu
From: Aidan Williams [EMAIL PROTECTED] The bf537 Ethernet MAC driver in the 2007R1.1-RC3 kernel (and the current kernel) do not implement multicast hash filtering. This is a performance problem if you have lots of multicast on your network. This patch plugs the right bits into the multicast hash

[PATCH 0/8] [Blackfin] EMAC driver updates

2008-01-30 Thread Bryan Wu
Several bug fixing for this driver. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] sky2: restore multicast addresses after recovery

2008-01-30 Thread Jeff Garzik
Stephen Hemminger wrote: If the sky2 deadman timer forces a recovery, the multicast hash list is lost. Move the call to sky2_set_multicast to the end of sky2_up() so all paths that bring device up will restore multicast. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- Please apply for

[PATCH 2/8] [Blackfin] EMAC driver: define MDC_CLK=2.5MHz and caculate mdc_div according to SCLK.

2008-01-30 Thread Bryan Wu
Signed-off-by: Bryan Wu [EMAIL PROTECTED] --- drivers/net/bfin_mac.c | 16 1 files changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c index 4006a5d..ee39819 100644 --- a/drivers/net/bfin_mac.c +++ b/drivers/net/bfin_mac.c @@

[PATCH 1/8] [Blackfin] EMAC driver: shorten the mdelay value to solve netperf performance issue

2008-01-30 Thread Bryan Wu
Signed-off-by: Bryan Wu [EMAIL PROTECTED] --- drivers/net/bfin_mac.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c index eb97175..4006a5d 100644 --- a/drivers/net/bfin_mac.c +++ b/drivers/net/bfin_mac.c @@ -296,7 +296,7

[PATCH 4/8] [Blackfin] EMAC driver: use simpler comment headers and strip out information that is maintained in the scm's log

2008-01-30 Thread Bryan Wu
From: Mike Frysinger [EMAIL PROTECTED] Signed-off-by: Mike Frysinger [EMAIL PROTECTED] Signed-off-by: Bryan Wu [EMAIL PROTECTED] --- drivers/net/bfin_mac.c | 32 drivers/net/bfin_mac.h | 31 --- 2 files changed, 8 insertions(+), 55

[PATCH] [1/1] Deprecate tcp_tw_{reuse,recycle}

2008-01-30 Thread Andi Kleen
We've recently had a long discussion about the CVE-2005-0356 time stamp denial-of-service attack. It turned out that Linux is only vunerable to this problem when tcp_tw_recycle is enabled (which it is not by default). In general these two options are not really usable in today's internet

Re: net-2.6.25 is no more...

2008-01-30 Thread Daniel Lezcano
David Miller wrote: Now that the bulk has been merged over and we are actively working alongside Linus's tree I have moved all current patch applying to net-2.6 instead of net-2.6.25, so the current tree to use is: kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git This tree is

Re: sis190 build breakage

2008-01-30 Thread Sam Ravnborg
On Wed, Jan 30, 2008 at 03:22:51AM -0500, Jeff Garzik wrote: Sam Ravnborg wrote: On Tue, Jan 29, 2008 at 11:03:10PM +0100, Francois Romieu wrote: maximilian attems [EMAIL PROTECTED] : CC [M] drivers/net/sis190.o drivers/net/sis190.c:329: error: sis190_pci_tbl causes a section type

[PATCH] cls_u32 u32_classify()

2008-01-30 Thread Dzianis Kahanovich
Currently fine u32 hashkey ... at ... not work with relative offsets. There are simpliest fix to use eat. -- WBR, Denis Kaganovich, [EMAIL PROTECTED] http://mahatma.bspu.unibel.by diff -pruN linux-2.6.orig/net/sched/cls_u32.c linux-2.6/net/sched/cls_u32.c --- linux-2.6.orig/net/sched/cls_u32.c

Re: [PATCH] PHYLIB: Add BCM5482 PHY support

2008-01-30 Thread Maciej W. Rozycki
On Tue, 29 Jan 2008, Nate Case wrote: +static struct phy_driver bcm5482_driver = { +.phy_id = 0x0143bcb0, + .phy_id_mask= 0xfff0, Please check formatting above and also I am a bit curious as to why the ID is so different from the other ones -- the number is meant to

[PATCH] cls_u32 u32_classify() ++

2008-01-30 Thread Dzianis Kahanovich
Currently fine u32 hashkey ... at ... not work with relative offsets. There are simpliest fix to use eat. (sorry, i'm idiot) -- WBR, Denis Kaganovich, [EMAIL PROTECTED] http://mahatma.bspu.unibel.by diff -pruN linux-2.6.orig/net/sched/cls_u32.c linux-2.6/net/sched/cls_u32.c ---

[git patches] net driver fixes

2008-01-30 Thread Jeff Garzik
First pass through the queue that built up over the weekend (plus a few others that just missed 2.6.24 release), with a focus specifically on fixes. Please pull from 'upstream-davem' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-davem to receive the

[PATCH] cls_u32 u32_classify() +

2008-01-30 Thread Dzianis Kahanovich
Currently fine u32 hashkey ... at ... not work with relative offsets. There are simpliest fix to use eat. (sorry, v2) -- WBR, Denis Kaganovich, [EMAIL PROTECTED] http://mahatma.bspu.unibel.by diff -pruN linux-2.6.orig/net/sched/cls_u32.c linux-2.6/net/sched/cls_u32.c ---

Re: [git patches] net driver fixes

2008-01-30 Thread Sam Ravnborg
Jeff Garzik (1): [netdrvr] sis190: build fix But you did it wrong... sis190.c b/drivers/net/sis190.c index b570402..2e9e88b 100644 --- a/drivers/net/sis190.c +++ b/drivers/net/sis190.c @@ -326,7 +326,7 @@ static const struct { { SiS 191 PCI Gigabit Ethernet adapter }, };

Re: Mostly revert e1000/e1000e: Move PCI-Express device IDs over to e1000e

2008-01-30 Thread Jeff Garzik
Linus Torvalds wrote: On Tue, 29 Jan 2008, Randy Dunlap wrote: Andrew was concerned about this when the driver was in -mm. He asked for a patch that would set E1000E to same value as E1000 and I supplied that. Auke acked it IIRC. Other people vetoed it. :( Yeah, I've been discussing with

Re: [PATCH retry] bluetooth : add conn add/del workqueues to avoid connection fail

2008-01-30 Thread Marcel Holtmann
Hi Dave, The bluetooth hci_conn sysfs add/del executed in the default workqueue. If the del_conn is executed after the new add_conn with same target, add_conn will failed with warning of same kobject name. Here add btaddconn btdelconn workqueues, flush the btdelconn workqueue in the

Re: [git patches] net driver fixes

2008-01-30 Thread Jeff Garzik
Sam Ravnborg wrote: Jeff Garzik (1): [netdrvr] sis190: build fix But you did it wrong... sis190.c b/drivers/net/sis190.c index b570402..2e9e88b 100644 --- a/drivers/net/sis190.c +++ b/drivers/net/sis190.c @@ -326,7 +326,7 @@ static const struct { { SiS 191 PCI Gigabit Ethernet

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

2008-01-30 Thread Jan Engelhardt
On Jan 30 2008 11:53, Jonas Bonn wrote: This fixes build error as gcc complains about a section type conflict due to the const __devinitdata in sis190_get_mac_addr_from_apc(). -static struct pci_device_id sis190_pci_tbl[] __devinitdata = { +static const struct pci_device_id sis190_pci_tbl[]

b44 compile failure

2008-01-30 Thread maximilian attems
drivers/net/b44.c: In function 'b44_remove_one': drivers/net/b44.c:2231: error: implicit declaration of function 'ssb_pcihost_set_power_state' compiles fine on 64 bit x86, but not on 32, see log:

[PATCH] [SIS190] Constify data marked as __devinitdata

2008-01-30 Thread Jonas Bonn
This fixes build error as gcc complains about a section type conflict due to the const __devinitdata in sis190_get_mac_addr_from_apc(). --- drivers/net/sis190.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

2008-01-30 Thread Sam Ravnborg
On Wed, Jan 30, 2008 at 12:23:23PM +0100, Jan Engelhardt wrote: On Jan 30 2008 11:53, Jonas Bonn wrote: This fixes build error as gcc complains about a section type conflict due to the const __devinitdata in sis190_get_mac_addr_from_apc(). -static struct pci_device_id sis190_pci_tbl[]

[PATCH] [SIS190] Use _devinitconst for const data

2008-01-30 Thread Jonas Bonn
This fixes build error as gcc complains about a section type conflict due to the mixing of const and non-const data in same section. --- drivers/net/sis190.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

2008-01-30 Thread Jonas Bonn
instead? Because AFAIK, const *and* __sectionmarker does not mix. You're right... it's documented in linux/init.h that const and __sectionmarker do not mix. The compile error is due to the use of const and __section marker in the function sis190_get_mac_addr_from_apc(). -- To unsubscribe

Re: [PATCH] [SIS190] Use _devinitconst for const data

2008-01-30 Thread Sam Ravnborg
On Wed, Jan 30, 2008 at 12:57:16PM +0100, Jonas Bonn wrote: This fixes build error as gcc complains about a section type conflict due to the mixing of const and non-const data in same section. --- drivers/net/sis190.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

e1000 full-duplex TCP performance well below wire speed

2008-01-30 Thread Bruce Allen
(Pádraig Brady has suggested that I post this to Netdev. It was originally posted to LKML here: http://lkml.org/lkml/2008/1/30/141 ) Dear NetDev, We've connected a pair of modern high-performance boxes with integrated copper Gb/s Intel NICS, with an ethernet crossover cable, and have run

Re: net-2.6.25 is no more...

2008-01-30 Thread David Miller
From: Daniel Lezcano [EMAIL PROTECTED] Date: Wed, 30 Jan 2008 10:03:09 +0100 David Miller wrote: Now that the bulk has been merged over and we are actively working alongside Linus's tree I have moved all current patch applying to net-2.6 instead of net-2.6.25, so the current tree to use

Re: [PATCH] [2/2] Remove some unnecessary gotos in established_get_first()

2008-01-30 Thread David Miller
From: Oliver Neukum [EMAIL PROTECTED] Date: Wed, 30 Jan 2008 09:25:12 +0100 Now suppose somebody needs to change locking. He'll have to convert it back. IMHO a conditional return is worse than goto clearly_named_label I totally agree. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

2008-01-30 Thread Sam Ravnborg
On Wed, Jan 30, 2008 at 02:31:05PM +0100, Jan Engelhardt wrote: On Jan 30 2008 12:25, Sam Ravnborg wrote: We have just introduced __initconst, __cpuinitconst, __meminitconst for const data. So the patch is wrong. Oh joy, more tags. Is it actually possible to combine const with

Re: e1000 full-duplex TCP performance well below wire speed

2008-01-30 Thread Bruce Allen
Hi David, Thanks for your note. (The performance of a full duplex stream should be close to 1Gb/s in both directions.) This is not a reasonable expectation. ACKs take up space on the link in the opposite direction of the transfer. So the link usage in the opposite direction of the transfer

[drivers/net/bnx2.c] ADVERTISE_1000XPSE_ASYM

2008-01-30 Thread Roel Kluin
In drivers/net/bnx2.c:1285: it reads in function bnx2_setup_remote_phy(): if (pause_adv (ADVERTISE_1000XPSE_ASYM | ADVERTISE_1000XPSE_ASYM)) Note that the two are the same and this is therefore equivalent to if (pause_adv ADVERTISE_1000XPSE_ASYM) This appears to be incorrect, was maybe '|

[PATCH][net/sched/sch_teql.c] duplicate IFF_BROADCAST in FMASK, remove 2nd

2008-01-30 Thread Roel Kluin
Untested patch below, please confirm it's the right fix (should it be some other IFF_*?) -- duplicate IFF_BROADCAST, remove 2nd Signed-off-by: Roel Kluin [EMAIL PROTECTED] --- diff --git a/net/sched/sch_teql.c b/net/sched/sch_teql.c index c0ed06d..a53acf4 100644 --- a/net/sched/sch_teql.c +++

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

2008-01-30 Thread Jan Engelhardt
On Jan 30 2008 12:25, Sam Ravnborg wrote: We have just introduced __initconst, __cpuinitconst, __meminitconst for const data. So the patch is wrong. Oh joy, more tags. Is it actually possible to combine const with __devinitconst now? static const uint16_t foo[] __devinitconst = { ... }; -- To

Re: e1000 full-duplex TCP performance well below wire speed

2008-01-30 Thread David Miller
From: Bruce Allen [EMAIL PROTECTED] Date: Wed, 30 Jan 2008 03:51:51 -0600 (CST) [ netdev@vger.kernel.org added to CC: list, that is where kernel networking issues are discussed. ] (The performance of a full duplex stream should be close to 1Gb/s in both directions.) This is not a reasonable

[PATCH] [SIS190] Use __devinitconst for const devinit data

2008-01-30 Thread Jonas Bonn
Mixing const and __section was previously not allowed. New __devinitconst tag allows this. This fixes a gcc section type mismatch build error. --- drivers/net/sis190.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index

Re: [PATCH 1/3] netns netfilter: semi-rewrite of /proc/net/foo_tables_*

2008-01-30 Thread Patrick McHardy
Alexey Dobriyan wrote: Argh, there are many small but still wrong things with /proc/net/*_tables_* so I decided to do overhaul simultaneously making it more suitable for per-netns /proc/net/*_tables_* implementation. Fix a) xt_get_idx() duplicating now standard seq_list_start/seq_list_next

Re: [PATCH 2/3] netns netfilter: netns propagation for /proc/net/*_tables_names

2008-01-30 Thread Patrick McHardy
Alexey Dobriyan wrote: Propagate netns together with AF down to -start/-next/-stop iterators. Choose table based on netns and AF for showing. Applied. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 3/3] netns netfilter: create per-netns /proc/net/*_tables_*

2008-01-30 Thread Patrick McHardy
Alexey Dobriyan wrote: Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- include/linux/netfilter/x_tables.h |4 ++-- net/ipv4/netfilter/arp_tables.c| 21 ++--- net/ipv4/netfilter/ip_tables.c | 21 ++--- net/ipv6/netfilter/ip6_tables.c|

Re: e1000 full-duplex TCP performance well below wire speed

2008-01-30 Thread Stephen Hemminger
On Wed, 30 Jan 2008 08:01:46 -0600 (CST) Bruce Allen [EMAIL PROTECTED] wrote: Hi David, Thanks for your note. (The performance of a full duplex stream should be close to 1Gb/s in both directions.) This is not a reasonable expectation. ACKs take up space on the link in the

Re: Mostly revert e1000/e1000e: Move PCI-Express device IDs over to e1000e

2008-01-30 Thread Kok, Auke
Jeff Garzik wrote: Linus Torvalds wrote: On Tue, 29 Jan 2008, Randy Dunlap wrote: Andrew was concerned about this when the driver was in -mm. He asked for a patch that would set E1000E to same value as E1000 and I supplied that. Auke acked it IIRC. Other people vetoed it. :( Yeah, I've

Re: [PATCH] NET: constify data and function pointer tables

2008-01-30 Thread John W. Linville
On Wed, Jan 30, 2008 at 04:25:17AM -0500, Jeff Garzik wrote: Jan Engelhardt wrote: Signed-off-by: Jan Engelhardt [EMAIL PROTECTED] --- drivers/net/bonding/bond_main.c |2 +- drivers/net/hamradio/bpqether.c |2 +- drivers/net/hamradio/scc.c |2 +-

Re: b44 compile failure

2008-01-30 Thread John W. Linville
On Wed, Jan 30, 2008 at 11:59:26AM +0100, maximilian attems wrote: drivers/net/b44.c: In function 'b44_remove_one': drivers/net/b44.c:2231: error: implicit declaration of function 'ssb_pcihost_set_power_state' compiles fine on 64 bit x86, but not on 32, see log:

[BUILD FAILURE] 2.6.24-git7 section type conflict at various drivers on powerpc

2008-01-30 Thread Kamalesh Babulal
Hi, Following are the different build failure with 2.6.24-git7 kernel on the powerpc drivers/net/typhoon.c:181: error: typhoon_card_info causes a section type conflict make[2]: *** [drivers/net/typhoon.o] Error 1 drivers/net/natsemi.c:259: error: natsemi_pci_info causes a section type

Re: [RFC/PATCH] e100 driver didn't support any MII-less PHYs...

2008-01-30 Thread Kok, Auke
Andreas Mohr wrote: Hi, On Tue, Jan 29, 2008 at 03:09:25PM -0800, Kok, Auke wrote: Andreas Mohr wrote: Perhaps it's useful to file a bug/patch on http://sourceforge.net/projects/e1000/ ? Perhaps -mm testing? I wanted to push this though our testing labs first which has not happened due

Re: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure (was: Re: fixed phy support (warning related to FIXED_MII_100_FDX))

2008-01-30 Thread Kumar Gala
On Jan 21, 2008, at 2:49 PM, Anton Vorontsov wrote: On Mon, Jan 21, 2008 at 01:19:41PM -0600, Kumar Gala wrote: Anton, it looks like the TI AR7 CPMAC Ethernet support uses FIXED_PHY and was selecting FIXED_MII_100_FDX which is gone. Can you look into this. I get the following warning now:

Re: e1000 performance issue in 4 simultaneous links

2008-01-30 Thread Kok, Auke
Denys Fedoryshchenko wrote: Sorry. that i interfere in this subject. Do you recommend CONFIG_IRQBALANCE to be enabled? I certainly do not. Manual tweaking and pinning the irq's to the correct CPU will give the best performance (for specific loads). The userspace irqbalance daemon tries very

Re: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure

2008-01-30 Thread Jeff Garzik
Anton Vorontsov wrote: On Mon, Jan 21, 2008 at 01:19:41PM -0600, Kumar Gala wrote: Anton, it looks like the TI AR7 CPMAC Ethernet support uses FIXED_PHY and was selecting FIXED_MII_100_FDX which is gone. Can you look into this. I get the following warning now: scripts/kconfig/conf -s

Re: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure

2008-01-30 Thread Kumar Gala
On Jan 30, 2008, at 11:09 AM, Jeff Garzik wrote: Anton Vorontsov wrote: On Mon, Jan 21, 2008 at 01:19:41PM -0600, Kumar Gala wrote: Anton, it looks like the TI AR7 CPMAC Ethernet support uses FIXED_PHY and was selecting FIXED_MII_100_FDX which is gone. Can you look into this. I get

Re: [BUILD FAILURE] 2.6.24-git7 section type conflict at various drivers on powerpc

2008-01-30 Thread Sam Ravnborg
On Wed, Jan 30, 2008 at 09:49:59PM +0530, Kamalesh Babulal wrote: Hi, Following are the different build failure with 2.6.24-git7 kernel on the powerpc drivers/net/typhoon.c:181: error: typhoon_card_info causes a section type conflict make[2]: *** [drivers/net/typhoon.o] Error 1

Re: [PATCH] [1/2] Skip empty hash buckets faster in /proc/net/tcp

2008-01-30 Thread Roland Dreier
On a 2GB Core2 system here I see a time cat /proc/net/tcp /dev/null constently dropping from 0.44s to 0.4-0.8s system time with this change. Seems like there must be a typo in either the before or after times you report here? -- To unsubscribe from this list: send the line unsubscribe netdev

Re: [PATCH] [1/2] Skip empty hash buckets faster in /proc/net/tcp

2008-01-30 Thread Andi Kleen
On Wed, Jan 30, 2008 at 09:03:16AM -0800, Roland Dreier wrote: On a 2GB Core2 system here I see a time cat /proc/net/tcp /dev/null constently dropping from 0.44s to 0.4-0.8s system time with this change. Seems like there must be a typo in either the before or after times you report

RE: e1000 full-duplex TCP performance well below wire speed

2008-01-30 Thread Brandeburg, Jesse
Bruce Allen wrote: Details: Kernel version: 2.6.23.12 ethernet NIC: Intel 82573L ethernet driver: e1000 version 7.3.20-k2 motherboard: Supermicro PDSML-LN2+ (one quad core Intel Xeon X3220, Intel 3000 chipset, 8GB memory) Hi Bruce, The 82573L (a client NIC, regardless of the class of

Re: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure

2008-01-30 Thread Jeff Garzik
Kumar Gala wrote: On Jan 30, 2008, at 11:09 AM, Jeff Garzik wrote: Anton Vorontsov wrote: On Mon, Jan 21, 2008 at 01:19:41PM -0600, Kumar Gala wrote: Anton, it looks like the TI AR7 CPMAC Ethernet support uses FIXED_PHY and was selecting FIXED_MII_100_FDX which is gone. Can you look

Re: net-2.6.25 is no more...

2008-01-30 Thread Daniel Lezcano
David Miller wrote: From: Daniel Lezcano [EMAIL PROTECTED] Date: Wed, 30 Jan 2008 10:03:09 +0100 David Miller wrote: Now that the bulk has been merged over and we are actively working alongside Linus's tree I have moved all current patch applying to net-2.6 instead of net-2.6.25, so the

Strange commit 42a73808ed4f30b739eb52bcbb33a02fe62ceef5

2008-01-30 Thread Adrian Bunk
Commit 42a73808ed4f30b739eb52bcbb33a02fe62ceef5 ([RAW]: Consolidate proc interface.) did not only change raw6_seq_ops (including adding 3 EXPORT_SYMBOL_GPL's to net/ipv4/raw.c for accessing functions from there), it also removed the only user of raw6_seq_ops... cu Adrian -- Is there

Re: b44 compile failure

2008-01-30 Thread maximilian attems
On Wed, 30 Jan 2008, John W. Linville wrote: On Wed, Jan 30, 2008 at 11:59:26AM +0100, maximilian attems wrote: drivers/net/b44.c: In function 'b44_remove_one': drivers/net/b44.c:2231: error: implicit declaration of function 'ssb_pcihost_set_power_state' compiles fine on 64 bit

Re: net-2.6.25 is no more...

2008-01-30 Thread Arnaldo Carvalho de Melo
Em Wed, Jan 30, 2008 at 06:38:53PM +0100, Daniel Lezcano escreveu: David Miller wrote: From: Daniel Lezcano [EMAIL PROTECTED] Date: Wed, 30 Jan 2008 10:03:09 +0100 David Miller wrote: Now that the bulk has been merged over and we are actively working alongside Linus's tree I have moved all

Re: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure

2008-01-30 Thread Kumar Gala
Is this going through netdev or do you want me to pick it via the powerpc route? Based on your comments I sorta assumed it was most convenient to lump in with the rest of the powerpc changes... That's fine. I'll push it via the powerpc trees. - k -- To unsubscribe from this list: send

Re: e1000 full-duplex TCP performance well below wire speed

2008-01-30 Thread Rick Jones
As asked in LKML thread, please post the exact netperf command used to start the client/server, whether or not you're using irqbalanced (aka irqbalance) and what cat /proc/interrupts looks like (you ARE using MSI, right?) In particular, it would be good to know if you are doing two concurrent

Re: [drivers/net/bnx2.c] ADVERTISE_1000XPSE_ASYM

2008-01-30 Thread Michael Chan
On Wed, 2008-01-30 at 15:07 +0100, Roel Kluin wrote: In drivers/net/bnx2.c:1285: it reads in function bnx2_setup_remote_phy(): if (pause_adv (ADVERTISE_1000XPSE_ASYM | ADVERTISE_1000XPSE_ASYM)) Note that the two are the same and this is therefore equivalent to if (pause_adv

Re: net-2.6.25 is no more...

2008-01-30 Thread Daniel Lezcano
Arnaldo Carvalho de Melo wrote: Em Wed, Jan 30, 2008 at 06:38:53PM +0100, Daniel Lezcano escreveu: David Miller wrote: From: Daniel Lezcano [EMAIL PROTECTED] Date: Wed, 30 Jan 2008 10:03:09 +0100 David Miller wrote: Now that the bulk has been merged over and we are actively working

Re: [PATCH] [1/1] Deprecate tcp_tw_{reuse,recycle}

2008-01-30 Thread Ben Greear
Andi Kleen wrote: We've recently had a long discussion about the CVE-2005-0356 time stamp denial-of-service attack. It turned out that Linux is only vunerable to this problem when tcp_tw_recycle is enabled (which it is not by default). In general these two options are not really usable in

Re: e1000 full-duplex TCP performance well below wire speed

2008-01-30 Thread Ben Greear
Bruce Allen wrote: (Pádraig Brady has suggested that I post this to Netdev. It was originally posted to LKML here: http://lkml.org/lkml/2008/1/30/141 ) Dear NetDev, We've connected a pair of modern high-performance boxes with integrated copper Gb/s Intel NICS, with an ethernet crossover

[2.6 patch] via-rhine.c:rhine_hw_init() must be __devinit

2008-01-30 Thread Adrian Bunk
Thie patch fixes the following section mismatch: -- snip -- ... WARNING: drivers/net/built-in.o(.text+0xdd840): Section mismatch in reference from the function rhine_hw_init() to the function .devinit.text:rhine_reload_eeprom() ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL PROTECTED]

[2.6 patch] olympic_open() must be __devinit

2008-01-30 Thread Adrian Bunk
This patch fixes the following section mismatch: -- snip -- ... WARNING: drivers/net/built-in.o(.text+0x155573): Section mismatch in reference from the function olympic_open() to the function .devinit.text:olympic_init() ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL PROTECTED] ---

[2.6 patch] ibmlana_adapter_names[] must be __devinitdata

2008-01-30 Thread Adrian Bunk
This patch fixes the following section mismatch: -- snip -- ... WARNING: drivers/net/built-in.o(.devinit.text+0x1baa4): Section mismatch in reference from the function ibmlana_init_one() to the variable .init.data:ibmlana_adapter_names ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL

[2.6 patch] ibmlana_init_one() must be __devinit

2008-01-30 Thread Adrian Bunk
This patch fixes the following section mismatch: -- snip -- ... WARNING: drivers/net/built-in.o(.text+0x1148a5): Section mismatch in reference from the function ibmlana_init_one() to the variable .init.data:ibmlana_adapter_names ... -- snip -- Signed-off-by: Adrian Bunk [EMAIL PROTECTED]

[2.6 patch] net/xfrm/: remove unused exports

2008-01-30 Thread Adrian Bunk
This patch removes the following no longer used EXPORT_SYMBOL's: - xfrm_input.c: xfrm_parse_spi - xfrm_state.c: xfrm_replay_check - xfrm_state.c: xfrm_replay_advance Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- net/xfrm/xfrm_input.c |1 - net/xfrm/xfrm_state.c |2 -- 2 files

[2.6 patch] unexport sysctl_tcp_tso_win_divisor

2008-01-30 Thread Adrian Bunk
This patch removes the no longer used EXPORT_SYMBOL(sysctl_tcp_tso_win_divisor). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 4884e7997ba5f63f2efeaeead21ed2768fb3f4de diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index 89f0188..ed750f9 100644 --- a/net/ipv4/tcp_output.c +++

[2.6 patch] unexport ip6_find_1stfragopt

2008-01-30 Thread Adrian Bunk
This patch removes the no longer used EXPORT_SYMBOL_GPL(ip6_find_1stfragopt). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 961bcbf7370019e35920a75d2d34c91b71708dfe diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 15c4f6c..ca707c0 100644 --- a/net/ipv6/ip6_output.c +++

[2.6 patch] IBMLANA no longer has to depend on MCA_LEGACY

2008-01-30 Thread Adrian Bunk
This patch removes the no longer required dependency of IBMLANA on MCA_LEGACY. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- d83989118e59f403200ea9c71d2293337b49df01 diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index af40ff4..578ae2c 100644 --- a/drivers/net/Kconfig +++

[2.6 patch] e1000e/ethtool.c: make a function static

2008-01-30 Thread Adrian Bunk
This patch makes the needlessly global reg_pattern_test_array() static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- ed72e457f06311390d9a9e51a00c904939466aff diff --git a/drivers/net/e1000e/ethtool.c b/drivers/net/e1000e/ethtool.c index 6d9c27f..a2034cf 100644 ---

[2.6 patch] make struct ipv4_devconf static

2008-01-30 Thread Adrian Bunk
struct ipv4_devconf can now become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- include/linux/inetdevice.h |2 -- net/ipv4/devinet.c |2 +- 2 files changed, 1 insertion(+), 3 deletions(-) 20262a3317069b1bdbf2b37f4002fa5322445914 diff --git

[2.6 patch] make nf_ct_path[] static

2008-01-30 Thread Adrian Bunk
This patch makes the needlessly global nf_ct_path[] static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 6396fbcebe3eb61f7e6eb1a671920a515912b005 diff --git a/net/netfilter/nf_conntrack_standalone.c b/net/netfilter/nf_conntrack_standalone.c index 696074a..5bd38a6 100644 ---

  1   2   >