Re: [NETFILTER]: Introduce nf_inet_address

2008-02-22 Thread David Woodhouse
On Fri, 2008-02-22 at 16:52 +0900, David Woodhouse wrote: It looks like iptables is fairly broken anyway: make[1]: Entering directory `/home/dwmw2/working/extras/iptables/devel/iptables-1.4.0' Unable to resolve dependency on linux/compiler.h. Try 'make clean'. And if I move away the

Re: Linux 2.6.24.1 - kernel does not boot; IRQ trouble?

2008-02-22 Thread Kay Sievers
On Tue, Feb 19, 2008 at 9:47 AM, Kay Sievers [EMAIL PROTECTED] wrote: On Feb 18, 2008 9:06 PM, Stephen Hemminger [EMAIL PROTECTED] wrote: On Mon, 18 Feb 2008 19:42:25 + (GMT) Chris Rankin [EMAIL PROTECTED] wrote: --- Stephen Hemminger [EMAIL PROTECTED] wrote: sysfs:

[PATCH][NEIGH]: Fix race between neighbor lookup and table's hash_rnd update.

2008-02-22 Thread Pavel Emelyanov
The neigh_hash_grow() may update the tbl-hash_rnd value, which is used in all tbl-hash callbacks to calculate the hashval. Two lookup routines may race with this, since they call the -hash callback without the tbl-lock held. Since the hash_rnd is changed with this lock write-locked moving the

Re: Linux 2.6.24.1 - kernel does not boot; IRQ trouble?

2008-02-22 Thread Chris Rankin
--- Kay Sievers [EMAIL PROTECTED] wrote: Greg, it seems that: arch/x86/pci/legacy.c :: pci_legacy_init() tries to create already created bridge symlinks in 2.6.24. So we discover the same devices twice? Can this be a reason for the hang? No, it can't be because it's *not* hanging in this

Re: [RFC,PATCH] loopback: calls netif_receive_skb() instead of netif_rx()

2008-02-22 Thread Daniel Lezcano
Eric Dumazet wrote: Daniel Lezcano a écrit : Eric Dumazet wrote: Hi David This is an RFC, based on net-2.6 for convenience only. Thank you [RFC,PATCH] loopback: calls netif_receive_skb() instead of netif_rx() Loopback transmit function loopback_xmit() actually calls netif_rx() to queue a

[PATCH 00/04] smc91x: request bus width using platform data V2

2008-02-22 Thread Magnus Damm
These patches make it possible to request bus width in the platform data. Instead of keep on updating smc91x.h with board specific configuration, use platform data to pass along bus width and irq flags to the driver. This change is designed to be backwards-compatible, so all boards configured in

Re: lockdep warning

2008-02-22 Thread Jiri Kosina
On Fri, 22 Feb 2008, Anders Eriksson wrote: I found this is a newly booted 2.6.25-rc2's syslog. Feb 21 20:46:33 tippex BUG: rwlock wrong owner on CPU#0, runscript.sh/2633, d2c04084 Feb 21 20:46:33 tippex Pid: 2633, comm: runscript.sh Not tainted 2.6.25-rc2 #3 Feb 21 20:46:33 tippex

[PATCH 01/04] smc91x: pass along private data V2

2008-02-22 Thread Magnus Damm
Pass a private data pointer to macros and functions. This makes it easy to later on make run time decisions. This patch does not change any logic. These changes should be optimized away during compilation. V2 changes the macro argument name from priv to lp. Signed-off-by: Magnus Damm [EMAIL

[PATCH 03/04] smc91x: add insw/outsw to default config V2

2008-02-22 Thread Magnus Damm
This patch makes sure SMC_insw()/SMC_outsw() are defined for the default configuration. Without this change BUG()s will be triggered when using 16-bit only platform data and the default configuration. Signed-off-by: Magnus Damm [EMAIL PROTECTED] --- drivers/net/smc91x.h |2 ++ 1 file

[PATCH 04/04] smc91x: make superh use default config V2

2008-02-22 Thread Magnus Damm
Removes superh board specific configuration from the header file. These boards will instead be configured using platform data. Signed-off-by: Magnus Damm [EMAIL PROTECTED] --- drivers/net/smc91x.h | 30 -- 1 file changed, 30 deletions(-) ---

[PATCH 02/04] smc91x: introduce platform data flags V2

2008-02-22 Thread Magnus Damm
This patch introduces struct smc91x_platdata and modifies the driver so bus width is checked during run time using SMC_nBIT() instead of SMC_CAN_USE_nBIT. V2 keeps static configuration lean using SMC_DYNAMIC_BUS_CONFIG. Signed-off-by: Magnus Damm [EMAIL PROTECTED] --- drivers/net/smc91x.c |

Re: [PATCH] Fix multicast on VLAN interfaces

2008-02-22 Thread Patrick McHardy
Phil Oester wrote: In commit 56addd6eeeb4e11f5a0af7093ca078e0f29140e0 the VLAN multicast list handling was reworked. Unfortunately, a variable initialization was missed, and multicast over vlan devices has been broken since 2.6.23-rc1 (apparently not too many people use this). Trivial fix

Re: [RTNL]: Validate hardware and broadcast address attribute for RTM_NEWLINK

2008-02-22 Thread Patrick McHardy
Thomas Graf wrote: RTM_NEWLINK allows for already existing links to be modified. For this purpose do_setlink() is called which expects address attributes with a payload length of at least dev-addr_len. This patch adds the necessary validation for the RTM_NEWLINK case. The address length for

Taiwan's glory--computer industry

2008-02-22 Thread 『Taiwan News Express』
http://www.taiwannews.com.tw/static/express/080222-01.pdf http://www.taiwannews.com.tw/static/express/080222-02.pdf http://www.taiwannews.com.tw/static/express/080222-03.pdf http://www.taiwannews.com.tw/static/express/080222-04.pdf -- Powered by PHPlist, www.phplist.com -- -- To

[RTNL]: Validate hardware and broadcast address attribute for RTM_NEWLINK

2008-02-22 Thread Thomas Graf
RTM_NEWLINK allows for already existing links to be modified. For this purpose do_setlink() is called which expects address attributes with a payload length of at least dev-addr_len. This patch adds the necessary validation for the RTM_NEWLINK case. The address length for links to be created is

Re: lockdep warning

2008-02-22 Thread Jiri Kosina
On Fri, 22 Feb 2008, Anders Eriksson wrote: This needs to be CCed to netdev. Any chance that git revert 69cc64d8d92 makes this report go away? I'll have to install a git repo to check, or maybe you can send me the diff to reverse vs. 2.6.25-rc2? diff --git

[PATCH][NET] sock.c: sk_dst_lock lockdep keys and names per af_family

2008-02-22 Thread Jarek Poplawski
On Thu, Feb 21, 2008 at 09:53:56AM +, James Chapman wrote: ... The lockups still happen, but I think they are now due to a different problem, as you say. ... I hope, this patch should help to remove some possibly false lockdep warnings during this current testing. Regards, Jarek P.

[PATCH] iproute2: fix ip manpage typo (syntax error)

2008-02-22 Thread Andreas Henriksson
Hello Stephen! The patches branch of the debian packaging repo, at git://git.debian.org/git/collab-maint/pkg-iproute, now has four patches still pending. (Not resending, since they've all been posted multiple times before. Pick them up from the repo if you're interested.) Here's the latest

Re: [PATCH 01/04] smc91x: pass along private data V2

2008-02-22 Thread Nicolas Pitre
On Fri, 22 Feb 2008, Magnus Damm wrote: Pass a private data pointer to macros and functions. This makes it easy to later on make run time decisions. This patch does not change any logic. These changes should be optimized away during compilation. V2 changes the macro argument name from priv

Re: [PATCH 02/04] smc91x: introduce platform data flags V2

2008-02-22 Thread Nicolas Pitre
On Fri, 22 Feb 2008, Magnus Damm wrote: This patch introduces struct smc91x_platdata and modifies the driver so bus width is checked during run time using SMC_nBIT() instead of SMC_CAN_USE_nBIT. V2 keeps static configuration lean using SMC_DYNAMIC_BUS_CONFIG. Signed-off-by: Magnus Damm

Re: [PATCH 03/04] smc91x: add insw/outsw to default config V2

2008-02-22 Thread Nicolas Pitre
On Fri, 22 Feb 2008, Magnus Damm wrote: This patch makes sure SMC_insw()/SMC_outsw() are defined for the default configuration. Without this change BUG()s will be triggered when using 16-bit only platform data and the default configuration. Signed-off-by: Magnus Damm [EMAIL PROTECTED]

Re: [PATCH 04/04] smc91x: make superh use default config V2

2008-02-22 Thread Nicolas Pitre
On Fri, 22 Feb 2008, Magnus Damm wrote: Removes superh board specific configuration from the header file. These boards will instead be configured using platform data. Signed-off-by: Magnus Damm [EMAIL PROTECTED] Acked-by: Nicolas Pitre [EMAIL PROTECTED] --- drivers/net/smc91x.h | 30

Re: [NETFILTER]: Introduce nf_inet_address

2008-02-22 Thread Patrick McHardy
David Woodhouse wrote: On Tue, 2008-02-19 at 15:45 +0100, Patrick McHardy wrote: That would break iptables compilation, which already includes linux/in.h in some files. I guess the best fix for now is to include netinet/in.h in busybox and long-term clean this up properly. It looks like

Re: [NETFILTER]: Introduce nf_inet_address

2008-02-22 Thread Patrick McHardy
David Woodhouse wrote: On Fri, 2008-02-22 at 16:52 +0900, David Woodhouse wrote: It looks like iptables is fairly broken anyway: make[1]: Entering directory `/home/dwmw2/working/extras/iptables/devel/iptables-1.4.0' Unable to resolve dependency on linux/compiler.h. Try 'make clean'. And if I

[PATCH] ssb: Add CHIPCO IRQ access functions

2008-02-22 Thread Michael Buesch
From: Aurelien Jarno [EMAIL PROTECTED] This patch adds functions to setup and read the CHIPCO IRQ. Signed-off-by: Aurelien Jarno [EMAIL PROTECTED] Signed-off-by: Michael Buesch [EMAIL PROTECTED] --- For 2.6.26. drivers/ssb/driver_chipcommon.c | 10 ++

Marvell PHY driver fix

2008-02-22 Thread Alexandr Smirnov
Marvell PHY m88e (not sure about other models, but think they too) works in two modes: fiber and copper. In Marvell PHY driver (that we have in current community kernels) code supported only copper mode, and this is not configurable, bits for copper mode are simply written in registers during

Re: [NETFILTER]: Introduce nf_inet_address

2008-02-22 Thread Patrick McHardy
Pablo Neira Ayuso wrote: Patrick McHardy wrote: Yes, that was a bug in the lastest release. We need to release a 1.4.1 version or something like that, but I'm not too familiar with the release process, so I haven't done this so far. I can schedule one for this weekend, just send me an ACK.

Re: [NETFILTER]: Introduce nf_inet_address

2008-02-22 Thread Pablo Neira Ayuso
Patrick McHardy wrote: Yes, that was a bug in the lastest release. We need to release a 1.4.1 version or something like that, but I'm not too familiar with the release process, so I haven't done this so far. I can schedule one for this weekend, just send me an ACK. -- Los honestos son

[PATCH RFC] phylib: fix forced mode misbehaviour for aneg off case

2008-02-22 Thread Anton Vorontsov
When user disabled autonegotiation via ethtool, and no link is detected, phylib will place phy into forcing mode, and then will start calling phy_force_reduction(). This will break user expectations. For example, user asks for fixed speed 1000: ethtool -s eth0 autoneg off speed 1000 Without link

Re: [NETFILTER]: Introduce nf_inet_address

2008-02-22 Thread Jan Engelhardt
On Feb 22 2008 16:44, Patrick McHardy wrote: Pablo Neira Ayuso wrote: Patrick McHardy wrote: Yes, that was a bug in the lastest release. We need to release a 1.4.1 version or something like that, but I'm not too familiar with the release process, so I haven't done this so far. I can

Re: [NETFILTER]: Introduce nf_inet_address

2008-02-22 Thread Patrick McHardy
Pablo Neira Ayuso wrote: Patrick McHardy wrote: Pablo Neira Ayuso wrote: Patrick McHardy wrote: Yes, that was a bug in the lastest release. We need to release a 1.4.1 version or something like that, but I'm not too familiar with the release process, so I haven't done this so far. I can

Re: [NETFILTER]: Introduce nf_inet_address

2008-02-22 Thread Pablo Neira Ayuso
Patrick McHardy wrote: Pablo Neira Ayuso wrote: Patrick McHardy wrote: Yes, that was a bug in the lastest release. We need to release a 1.4.1 version or something like that, but I'm not too familiar with the release process, so I haven't done this so far. I can schedule one for this

Re: lockdep warning

2008-02-22 Thread Anders Eriksson
[EMAIL PROTECTED] said: Any chance that git revert 69cc64d8d92 makes this report go away? I've tested the patch and I no longer get that lock thing in my syslog. /A -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: lockdep warning

2008-02-22 Thread Jiri Kosina
On Fri, 22 Feb 2008, Anders Eriksson wrote: Any chance that git revert 69cc64d8d92 makes this report go away? I've tested the patch and I no longer get that lock thing in my syslog. Thanks for verification. Hmm, I don't immediately see how this patch could make neigh-lock owner

Re: 2.6.25-rc2-mm1 - several bugs and a crash

2008-02-22 Thread Paul E. McKenney
On Fri, Feb 22, 2008 at 01:52:53AM +0100, Tilman Schmidt wrote: Am 22.02.2008 01:40 schrieb Tilman Schmidt: [NETFILTER]: nf_conntrack: fix smp_processor_id() in preemptible code warning Yes, it does; and the system also survives substantially longer. (IOW, it hasn't crashed on

Re: Marvell PHY driver fix

2008-02-22 Thread Andy Fleming
On Feb 22, 2008, at 08:34, Alexandr Smirnov wrote: Marvell PHY m88e (not sure about other models, but think they too) works in two modes: fiber and copper. In Marvell PHY driver (that we have in current community kernels) code supported only copper mode, and this is not configurable,

Re: [PATCH RFC] phylib: fix forced mode misbehaviour for aneg off case

2008-02-22 Thread Andy Fleming
On Feb 22, 2008, at 09:55, Anton Vorontsov wrote: When user disabled autonegotiation via ethtool, and no link is detected, phylib will place phy into forcing mode, and then will start calling phy_force_reduction(). This will break user expectations. For example, user asks for fixed speed

[no subject]

2008-02-22 Thread 内藤 賢司
[EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH RFC] phylib: fix forced mode misbehaviour for aneg off case

2008-02-22 Thread Anton Vorontsov
On Fri, Feb 22, 2008 at 11:40:04AM -0600, Andy Fleming wrote: On Feb 22, 2008, at 09:55, Anton Vorontsov wrote: When user disabled autonegotiation via ethtool, and no link is detected, phylib will place phy into forcing mode, and then will start calling phy_force_reduction(). This will

Re: [PATCH] tg3: ethtool phys_id default (rev2)

2008-02-22 Thread Michael Chan
On Fri, 2008-02-22 at 10:24 -0800, Stephen Hemminger wrote: When asked to blink LEDs the tg3 driver behaves when using: ethtool -p ethX The default value for data is zero, and other drivers interpret this as blink forever (or at least a really long time). The tg3 driver interprets this

[PATCH 1/3][BNX2]: More 5706S link down workaround.

2008-02-22 Thread Michael Chan
[BNX2]: More 5706S link down workaround. The previous patches to workaround the 5706S on an HP blade were not sufficient. The link state still does not change properly in some cases. This patch adds polling to make it completely reliable. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff

[PATCH 2/3][BNX2]: Disable parallel detect on an HP blade.

2008-02-22 Thread Michael Chan
[BNX2]: Disable parallel detect on an HP blade. Because of some board issues, we need to disable parallel detect on an HP blade. Without this patch, the link state can become stuck when it goes into parallel detect mode. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git

[PATCH 3/3][BNX2]: Update version to 1.7.4.

2008-02-22 Thread Michael Chan
[BNX2]: Update version to 1.7.4. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 35356fb..15853be 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@ -56,8 +56,8 @@ #define DRV_MODULE_NAMEbnx2 #define PFX

[2.6 patch] unexport ip6_find_1stfragopt

2008-02-22 Thread Adrian Bunk
This patch removes the no longer used EXPORT_SYMBOL_GPL(ip6_find_1stfragopt). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- This patch has been sent on: - 30 Jan 2008 961bcbf7370019e35920a75d2d34c91b71708dfe diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c index 15c4f6c..ca707c0

[PATCH 01/08] [TIPC]: Update version to 1.6.3

2008-02-22 Thread Stephens, Allan
This patch updates TIPC's version number to 1.6.3. Signed-off-by: Allan Stephens [EMAIL PROTECTED] --- net/tipc/core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/tipc/core.c b/net/tipc/core.c index d2d7d32..9b9429e 100644 --- a/net/tipc/core.c +++

[PATCH 04/08] [TIPC]: Minor cleanup of message header code

2008-02-22 Thread Stephens, Allan
This patch eliminates some unused or duplicate message header symbols, and fixes up the comments and/or location of a few other symbols. Signed-off-by: Allan Stephens [EMAIL PROTECTED] --- net/tipc/link.c | 16 net/tipc/msg.c | 16 net/tipc/msg.h | 19

[PATCH 00/08] [TIPC]: Initial patch set for TIPC 1.6.3

2008-02-22 Thread Stephens, Allan
This is a patch set containing TIPC code developed as part of the TIPC 1.7 development project. This first set contains small enhancements and bug fixes only, and is thus being integrated under the current TIPC 1.6 designation. Patch set summary: 01 Update version to 1.6.3 02 Add argument

[PATCH 02/08] [TIPC]: Add argument validation for shutdown()

2008-02-22 Thread Stephens, Allan
This patch validates that the how argument to shutdown() is SHUT_RDWR, since this is the only form that TIPC supports. Signed-off-by: Allan Stephens [EMAIL PROTECTED] --- net/tipc/socket.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/net/tipc/socket.c

[PATCH 03/08] [TIPC]: Eliminate sparse warning in socket code

2008-02-22 Thread Stephens, Allan
This patch eliminates warnings about a pair of undeclared symbols. Signed-off-by: Allan Stephens [EMAIL PROTECTED] --- net/tipc/socket.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index e5a6983..356a18c 100644 ---

[PATCH 06/08] [TIPC]: Enhancements to message header field writing

2008-02-22 Thread Stephens, Allan
From d588668422a802166b8368104490c7f644e95271 Mon Sep 17 00:00:00 2001 From: Allan Stephens [EMAIL PROTECTED] Date: Fri, 22 Feb 2008 10:21:42 -0500 Subject: This patch makes two enhancements to the routine used to set bit fields within a TIPC message header: 1) It now ignores any bits of the

[PATCH 07/08] [TIPC]: Removal of obsolete message header option code

2008-02-22 Thread Stephens, Allan
This patch removes code associated with optional, user-specified fields of the TIPC message header. Such fields were never utilized by TIPC, and have now been removed from the protocol specification. Signed-off-by: Allan Stephens [EMAIL PROTECTED] --- include/net/tipc/tipc_port.h |7 ---

[PATCH 08/08] [TIPC]: TIPC network address handling cleanup

2008-02-22 Thread Stephens, Allan
This patch improves the code which manipulates TIPC network address (aka Z.C.N values). 1) Address format validation routines are generalized to accept any valid Z.C.N value. 2) Eliminated inlining of scope checking code to prevent needless code duplication in non-critical path areas. 3)

[PATCH 05/08] [TIPC]: Use correct bitmask when setting version in message

2008-02-22 Thread Stephens, Allan
This patch ensures that the 3-bit version field of the TIPC message header is masked correctly when written into a message. Signed-off-by: Allan Stephens [EMAIL PROTECTED] --- net/tipc/msg.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/tipc/msg.h b/net/tipc/msg.h

Re: [PATCH 03/08] [TIPC]: Eliminate sparse warning in socket code

2008-02-22 Thread Sam Ravnborg
On Fri, Feb 22, 2008 at 11:59:12AM -0800, Stephens, Allan wrote: This patch eliminates warnings about a pair of undeclared symbols. Hi Allan. Last I looked there where ~90 sparse warnings for tipc. I assume you are aware and that they are getting fixed. Sam - who would like to see an

RE: [PATCH 03/08] [TIPC]: Eliminate sparse warning in socket code

2008-02-22 Thread Stephens, Allan
Hi Sam: Yes and yes. Some fixes will occur naturally as the problematic code has already been rewritten in TIPC 1.7, but other fixes will need to be developed. I'll see what I can do to accelerate the process ... -- Al -Original Message- From: Sam Ravnborg [mailto:[EMAIL PROTECTED]

Re: [PATCH 00/08] [TIPC]: Initial patch set for TIPC 1.6.3

2008-02-22 Thread David Miller
Please only submit bug fixes for 2.6.25 at this time. Thank you. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Error on ip route replace command

2008-02-22 Thread Francesco Saverio Giudice
Hi All, I have a problem with kernel 2.6.24. Having a running configuration using Shorewall and restarting it I got follow error: RTNETLINK answers: File exists Tom Eastep, Shorewall creator, told me to inform you about the problem. Here is the mail:

Re: [NETFILTER]: Introduce nf_inet_address

2008-02-22 Thread David Woodhouse
On Fri, 2008-02-22 at 16:44 +0100, Patrick McHardy wrote: Pablo Neira Ayuso wrote: Patrick McHardy wrote: Yes, that was a bug in the lastest release. We need to release a 1.4.1 version or something like that, but I'm not too familiar with the release process, so I haven't done this so

[Patch] Crash (BUG()) when handling fragmented ESP packets

2008-02-22 Thread Dirk Nehring
Most likely all 2.6 series kernels crash with BUG() when receives a fragmented ESP packet where ESP header and IV are not in the first fragment. This patches fixes this behaviour by reassembling the fragmented packet into the sk_buff. Signed-off-by: Dirk Nehring [EMAIL PROTECTED] Signed-off-by:

[PATCH] sky2: fix LED management

2008-02-22 Thread Stephen Hemminger
Fix problems in LED management, so ethtool -p works correctly on Yukon-EC and other chips. The driver was incorrectly setting the PHY LED overide bits. Moral: read the spec sheet, not the vendor driver. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c | 99

[patch 2.6.25-rc2-git] rndis_host: fix transfer size negotiation

2008-02-22 Thread David Brownell
From: Jean-Christophe Dubois [EMAIL PROTECTED] This patch should resolve a problem that's troubled support for some RNDIS peripherals. It seems to have boiled down to using a variable to establish transfer size limits before it was assigned, which caused those devices to fallback to a default

Re: Error on ip route replace command

2008-02-22 Thread Joonwoo Park
2008/2/23, Francesco Saverio Giudice [EMAIL PROTECTED]: Hi All, I have a problem with kernel 2.6.24. Having a running configuration using Shorewall and restarting it I got follow error: RTNETLINK answers: File exists Tom Eastep, Shorewall creator, told me to inform you about the problem.