Re: [lkp] [rhashtable] f9f51b8070: INFO: suspicious RCU usage. ]

On Fri, Dec 18, 2015 at 09:39:22AM +0800, kernel test robot wrote: > FYI, we noticed the below changes on > > https://github.com/0day-ci/linux > Herbert-Xu/rhashtable-Fix-walker-list-corruption/20151216-164833 > commit f9f51b8070be3e829100614a7372b219723b864f ("rhashtable: Fix walker list >

Re: [PATCH 4/6] bpf: hash: convert per-hashtable lock into per-bucket bit spinlock

On Wed, Dec 16, 2015 at 02:58:08PM +0800, Ming Lei wrote: > On Wed, Dec 16, 2015 at 1:01 PM, Yang Shi wrote: > > > > > I recalled Steven confirmed raw_spin_lock has the lockdep benefit too in the > > patch review for changing to raw lock. > > > > Please check this thread out

Re: Random packet loss using IPsec with AES128-SHA1

On Thu, Dec 17, 2015 at 04:36:06PM +0100, Gabriele Beltrame wrote: > Hi Steffen, > > I don't think it's IPsec (I can see the outbound packet in tcpdump), not > alone at least but the XEN /AWS Ethernet driver (or multiple things > concurring to the issue) actually.i Well, in this case you should

rhashtable: Kill harmless RCU warning in rhashtable_walk_init

On Fri, Dec 18, 2015 at 01:34:16PM +0800, Herbert Xu wrote: > On Fri, Dec 18, 2015 at 09:39:22AM +0800, kernel test robot wrote: > > FYI, we noticed the below changes on > > > > https://github.com/0day-ci/linux > > Herbert-Xu/rhashtable-Fix-walker-list-corruption/20151216-164833 > > commit

[PATCH net-next 4/5] bpf, x86: detect/optimize loading 0 immediates

When sometimes structs or variables need to be initialized/'memset' to 0 in an eBPF C program, the x86 BPF JIT converts this to use immediates. We can however save a couple of bytes (f.e. even up to 7 bytes on a single emmission of BPF_LD | BPF_IMM | BPF_DW) in the image by detecting such case and

[PATCH net-next 2/5] bpf: move clearing of A/X into classic to eBPF migration prologue

Back in the days where eBPF (or back then "internal BPF" ;->) was not exposed to user space, and only the classic BPF programs internally translated into eBPF programs, we missed the fact that for classic BPF A and X needed to be cleared. It was fixed back then via 83d5b7ef99c9 ("net: filter:

[PATCH net-next 5/5] bpf, test: add couple of test cases

Add couple of test cases for interpreter but also JITs, f.e. to test that when imm32 moves are being done, upper 32bits of the regs are being zero extended. Without JIT: [...] [ 1114.129301] test_bpf: #43 MOV REG64 jited:0 128 PASS [ 1114.130626] test_bpf: #44 MOV REG32 jited:0 139 PASS

[PATCH net-next 3/5] bpf: fix misleading comment in bpf_convert_filter

Comment says "User BPF's register A is mapped to our BPF register 6", which is actually wrong as the mapping is on register 0. This can already be inferred from the code itself. So just remove it before someone makes assumptions based on that. Only code tells truth. ;) Signed-off-by: Daniel

[PATCH net-next 1/5] bpf: add bpf_skb_load_bytes helper

When hacking tc programs with eBPF, one of the issues that come up from time to time is to load addresses from headers. In eBPF as in classic BPF, we have BPF_LD | BPF_ABS | BPF_{B,H,W} instructions that extract a byte, half-word or word out of the skb data though helpers such as

[PATCH] netconsole: Initialize after all core networking drivers

With built-in netconsole and IXGBE, configuring netconsole via the kernel cmdline results in the following panic at boot: netpoll: netconsole: device eth0 not up yet, forcing it usb 2-1: new high-speed USB device number 2 using ehci-pci ixgbe :03:00.0: registered PHC device on

RE: [RFC 5/5] i40e/ethtool: support coalesce setting by queue

> From: Kan Liang > > This patch implements set_per_queue_coalesce for i40e driver. > For i40e driver, only rx and tx usecs has per queue value. Changing > these two parameters only impact the specific queue. For other interrupt > coalescing parameters, they are shared among

[PATCH net-next 0/5] Misc BPF updates

This series contains a couple of misc updates to the BPF code, besides others a new helper bpf_skb_load_bytes(), moving clearing of A/X to the classic converter, etc. Please see individual patches for details. Thanks! Daniel Borkmann (5): bpf: add bpf_skb_load_bytes helper bpf: move clearing

Re: [PATCH net-next 2/5] bpf: move clearing of A/X into classic to eBPF migration prologue

On 12/17/2015 2:51 PM, Daniel Borkmann wrote: Back in the days where eBPF (or back then "internal BPF" ;->) was not exposed to user space, and only the classic BPF programs internally translated into eBPF programs, we missed the fact that for classic BPF A and X needed to be cleared. It was

[PATCH net-next] tcp: diag: add support for request sockets to tcp_abort()

From: Eric Dumazet Adding support for SYN_RECV request sockets to tcp_abort() is quite easy after our tcp listener rewrite. Note that we also need to better handle listeners, or we might leak not yet accepted children, because of a missing inet_csk_listen_stop() call.

RE: [RFC 4/5] i40e/ethtool: support coalesce getting by queue

> From: Kan Liang > > This patch implements get_per_queue_coalesce for i40e driver. > For i40e driver, only rx and tx usecs has per queue value. So only these > two parameters are read from specific registers. For other interrupt > coalescing parameters, they are shared

Re: [PATCH] af_unix: Revert 'lock_interruptible' in stream receive code

Hannes Frederic Sowa writes: [...] > There is still a deadlock lingering around [...] > http://lists.openwall.net/netdev/2015/11/10/4 Interesting problem. Assuming the description (a while ago) A: socketpair() B: splice() from a pipe to

Re: use-after-free in sixpack_close

On Thu, 17 Dec 2015 16:05:32 -0500 (EST) David Miller wrote: > From: One Thousand Gnomes > Date: Thu, 17 Dec 2015 11:41:04 + > > >> This report is then followed by a dozen of other use-after-free reports. > >> > >> On commit

Re: [PATCH net-next 2/5] bpf: move clearing of A/X into classic to eBPF migration prologue

On Thu, Dec 17, 2015 at 2:51 PM, Daniel Borkmann wrote: > Back in the days where eBPF (or back then "internal BPF" ;->) was not > exposed to user space, and only the classic BPF programs internally > translated into eBPF programs, we missed the fact that for classic BPF > A

[PATCH] net/macb: add proper header file

header file to resolve it. Fixes: 5833e0526820 ("net/macb: add support for resetting PHY using GPIO") Cc: Gregory CLEMENT <gregory.clem...@free-electrons.com> Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- build log with next-20151217 is at: https://travis-c

Re: [PATCH 0/2] net: usb: cdc_ncm: Adding support for two new Dell devices

Dan Williams writes: > On Wed, 2015-12-16 at 10:39 +0100, Daniele Palmas wrote: >> This patch series add support in the cdc_ncm driver for two devices >> based on the same platform, that are different only for carrier >> customization. >> >> The devices do not have ARP

RE: [RFCv4 bluetooth-next 1/2] 6lowpan: iphc: add support for stateful compression

Hi Alex! > -Original Message- > From: Alexander Aring [mailto:alex.ar...@gmail.com] > Sent: Tuesday, December 15, 2015 12:09 > To: Duda, Lukasz > Cc: linux-w...@vger.kernel.org; linux-blueto...@vger.kernel.org; > netdev@vger.kernel.org; ker...@pengutronix.de; m...@sandelman.ca; >

[PATCH net-next V1 4/4] net/mlx5e: Add PTP Hardware Clock (PHC) support

From: Eran Ben Elisha Add a PHC support to the mlx5_en driver. Use reader/writer spinlocks to protect the timecounter since every packet received needs to call timecounter_cycle2time() when timestamping is enabled. This can become a performance bottleneck with RSS and

[PATCH net-next V1 2/4] net/mlx5_core: Add support for reading hardware timestamp

From: Eran Ben Elisha A preparation step which adds support for reading the hardware timestamp from the internal clock and from the CQE. In addition, advertize device_frequency_khz HCA capability. Signed-off-by: Eran Ben Elisha Signed-off-by: Saeed

[PATCH net-next V1 0/4] Introduce mlx5 ethernet timestamping

Hi Dave, This patch series introduces the support for ConnectX-4 timestamping and the PTP kernel interface. This version addresses all the comments received on v0 and breaks the original series to four patches. First patch fixes a bug in SKB data pointer in device xmit function. Second patch

[PATCH net-next V1 1/4] net/mlx5e: Restore the skb data pointer after xmit is finished

From: Eran Ben Elisha Restore the skb data pointer after coping the data to the HW, so the skb can be cloned with correct headers for future use (e.g timestamping). Fixes: e586b3b0baee ("net/mlx5: Ethernet Datapath files") Signed-off-by: Eran Ben Elisha

[PATCH net-next V1 3/4] net/mlx5e: Add HW timestamping (TS) support

From: Eran Ben Elisha Add support for enable/disable HW timestamping for incoming and/or outgoing packets. To enable/disable HW timestamping appropriate ioctl should be used. Currently HWTSTAMP_FILTER_ALL/NONE and HWTSAMP_TX_ON/OFF only are supported. Make all relevant

[PATCH net-next] net: qmi_wwan: ignore bogus CDC Union descriptors

The CDC descriptors found on these vendor specific functions should not be considered authoritative. They seem to be ignored by drivers for other systems, and the quality is therefore low. One device (1e0e:9001) has been reported to have such a bogus union descriptor on the QMI function, making

Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev ' command

Jesper, Sorry, it seems that I accidentally sent out an unfinished e-mail. >I don't think your patch should contain this cleanup of "b4". It seems that b3 is only used for the legacy overhead part and if I remove it, b3 is not going to be used. So I figured I remove b4 put b3 instead.

use-after-free in sixpack_close

Hello, The following program triggers use-after-free in sixpack_close: // autogenerated by syzkaller (http://github.com/google/syzkaller) #include #include #include #include #include #include #include int main() { int fd = open("/dev/ptmx", O_RDWR); int opt = 0x7;

Re: [PATCH][iproute2] tc/q_htb.c: Fix the MPU value output in 'tc -d class show dev ' command

16.12.2015, 18:16, "Jesper Dangaard Brouer" : >  I don't think your patch should contain this cleanup of "b4". >  Submit another patch with that cleanup change, please. > >>    if (show_details) { >>   - fprintf(f, "burst %s/%u mpu %s overhead %s ", >>   +

Re: use-after-free in sixpack_close

> This report is then followed by a dozen of other use-after-free reports. > > On commit edb42dc7bc0da0125ceacab810a553ce1f0cac8d (Dec 15). > > Thank you sixpack_close does unregister_netdev(sp->dev), which frees sp as sp is actually allocated via alloc_netdev() Then deletes two timers within

Re: [PATCH net-next V1 1/4] net/mlx5e: Restore the skb data pointer after xmit is finished

From: Saeed Mahameed Date: Thu, 17 Dec 2015 14:35:32 +0200 > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c > b/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c > index 1341b1d..0fcfe64 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tx.c > +++

Re: [PATCH v2] drivers: net: xgene: fix Tx flow control

From: Iyappan Subramanian Date: Wed, 16 Dec 2015 22:26:05 -0800 > Currently the Tx flow control is based on reading the hardware state, > which is not accurate since it may not reflect the descriptors that > are not yet reached the memory. > > To accurately control the Tx

Re: [PATCH] netconsole: Initialize after all core networking drivers

On Thursday 12/17 at 17:08 -0800, Eric Dumazet wrote: > On Thu, 2015-12-17 at 15:52 -0800, Calvin Owens wrote: > > With built-in netconsole and IXGBE, configuring netconsole via the kernel > > cmdline results in the following panic at boot: > > > > netpoll: netconsole: device eth0 not up yet,

[PATCH net-next] asix: silence log message from oversize packet

Since it is possible for an external system to send oversize packets at anytime, it is best for driver not to print a message and spam the log (potential external DoS). Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=109471 Signed-off-by: Stephen Hemminger ---

Re: rhashtable: Prevent spurious EBUSY errors on insertion

On Fri, Dec 18, 2015 at 12:07:08AM +0800, Xin Long wrote: > > I'm just wondering, why do not we handle the genuine double rehash > issue inside rhashtable? i mean it's just a temporary error that a > simple retry may fix it. Because a double rehash means that someone has cracked your hash

Re: [PATCH] netconsole: Initialize after all core networking drivers

On Thu, 2015-12-17 at 15:52 -0800, Calvin Owens wrote: > With built-in netconsole and IXGBE, configuring netconsole via the kernel > cmdline results in the following panic at boot: > > netpoll: netconsole: device eth0 not up yet, forcing it > usb 2-1: new high-speed USB device number 2

Re: [PATCH] netconsole: Initialize after all core networking drivers

On Thu, 17 Dec 2015 15:52:39 -0800 Calvin Owens wrote: > With built-in netconsole and IXGBE, configuring netconsole via the kernel > cmdline results in the following panic at boot: > > netpoll: netconsole: device eth0 not up yet, forcing it > usb 2-1: new high-speed

Re: [iproute PATCH] ip{,6}tunnel: have a shared stats parser/printer

On Fri, 11 Dec 2015 13:23:44 +0100 Phil Sutter wrote: > This has a slight side-effect of not aborting when /proc/net/dev is > malformed, but OTOH stats are not parsed for uninteresting interfaces. > > Signed-off-by: Phil Sutter > --- > ip/ip6tunnel.c | 21

Re: [iproute PATCH] route: Fix printing of locked entries

On Sat, 12 Dec 2015 14:09:48 +0100 Phil Sutter wrote: > Commit 0f7543322c5fd ("route: ignore RTAX_HOPLIMIT of value -1") > accidentally reordered fprintf statements. This patch restores the > original ordering. > > Fixes: 0f7543322c5fd ("route: ignore RTAX_HOPLIMIT of value -1") >

Re: [PATCH iproute2 v2 3/3] lwtunnel: implement support for ip6 encap

On Wed, 16 Dec 2015 13:22:28 +0100 Paolo Abeni wrote: > Currently ip6 encap support for lwtunnel is missing. > This patch implement it, mostly duplicating the ipv4 parts. > > Also be sure to insert a space after the encap type, when > showing lwtunnel, to avoid the tunnel

Re: [PATCH] netconsole: Initialize after all core networking drivers

On Thursday 12/17 at 17:10 -0800, Stephen Hemminger wrote: > On Thu, 17 Dec 2015 15:52:39 -0800 > Calvin Owens wrote: > > > With built-in netconsole and IXGBE, configuring netconsole via the kernel > > cmdline results in the following panic at boot: > > > > netpoll:

[PATCH] ipip: ioctl: Remove superfluous IP-TTL handling.

IP-TTL case is already handled in ip_tunnel_ioctl() API. Signed-off-by: Pravin B Shelar --- net/ipv4/ipip.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/ipv4/ipip.c b/net/ipv4/ipip.c index 1f06729..4044da6 100644 --- a/net/ipv4/ipip.c +++ b/net/ipv4/ipip.c @@

Re: [PATCH iproute2] ip, route: fix minor compile warning

On Mon, 14 Dec 2015 16:53:20 +0100 Daniel Borkmann wrote: > On 12/14/2015 04:51 PM, Phil Sutter wrote: > > On Mon, Dec 14, 2015 at 04:34:29PM +0100, Daniel Borkmann wrote: > >> Seems like gcc (4.8.3) doesn't catch this false positive, triggering > >> after 0f7543322c5f

Re: [PATCH iproute2] lwtunnel: fix argument parsing

On Tue, 15 Dec 2015 12:18:04 +0100 Paolo Abeni wrote: > Currently parse_encap_ip() does not update correctly argv/argc; > if multiple lwtunnel arguments are provided, the parsing fails after > the first one, i.e. > > ip route add 172.16.101.0/24 dev vxlan1 encap ip id 42 dst

Re: [PATCH iproute2 -next] bpf: minor fix in api and bpf_dump_error() usage

On Mon, 14 Dec 2015 16:57:32 +0100 Daniel Borkmann wrote: > Fix a whitespace in bpf_dump_error() usage, and also a missing closing > bracket in ntohl() macro for eBPF programs. > > Signed-off-by: Daniel Borkmann > --- Applied to net-next -- To

Re: [PATCH iproute2] iproute: print addrgenmode stable_secret and fallback otherwise

On Wed, 16 Dec 2015 10:52:36 +0100 Hannes Frederic Sowa wrote: Applied thanks -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH iproute2] iplink: support 'stable-privacy' IPv6 addrgenmode

On Wed, 16 Dec 2015 16:15:14 +0100 Bjørn Mork wrote: > Signed-off-by: Bjørn Mork Does not apply to current code base. Probably because of Hannes recent changes. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode

Hi, Jay Thanks for your reply. Yes. The NIC is a bit odd. We have to be compatible with it. I followed your advice to delay calling netif_carrier_on(). Changes: Delay calling netif_carrier_on(). Best Regards! Zhu Yanjun -- To unsubscribe from this list: send the line "unsubscribe netdev" in

[PATCH 1/1] bonding: delay up state without speed and duplex in 802.3ad mode

From: yzhu1 In 802.3ad mode, the speed and duplex is needed. But in some NICs, there is a time span between NIC up state and getting speed and duplex. As such, sometimes a slave in 802.3ad mode is in up state without speed and duplex. This will make bonding in 802.3ad mode

Re: [PATCH 1/1] bonding: delay up state without speed and duplex in 802.3ad mode

wrote: >From: yzhu1 > >In 802.3ad mode, the speed and duplex is needed. But in some NICs, >there is a time span between NIC up state and getting speed and duplex. >As such, sometimes a slave in 802.3ad mode is in up state without >speed and duplex.

<    1   2