Re: rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

> That said, if you figure out some change that produces significant > reductions in code or binary size on multiple architectures without > making things more complicated, less readable or making the code or > binary size larger, then by all means propose it. Are you looking also for "a proof"

Re: [PATCH (net-next.git) 01/18] stmmac: share reset function between dwmac100 and dwmac1000

On 1/5/2016 4:25 AM, David Miller wrote: From: Giuseppe Cavallaro Date: Mon, 4 Jan 2016 14:06:46 +0100 @@ -376,7 +376,8 @@ extern const struct stmmac_desc_ops ndesc_ops; /* Specific DMA helpers */ struct stmmac_dma_ops { /* DMA core initialization */ -

cobalt ring

Dear Sir or Madam We have some stock of items. if you are retailer that will be good for you. No MOQ demand. prompt shipment. If you are interested pls do feel free to contact us Best whishes TomN�Р骒r��yb�X�肚�v�^�)藓{.n�+�阀z�^�)��骅w*jg�报�茛j/�赇z罐���2���ㄨ��&�)摺�a囤��

[PATCH iproute2 2/2] tipc: add peer remove functionality

This enables a user to remove an offline peer from the kernel data structures. This could for example be useful when deliberately scaling in peer nodes in a cloud environment. Signed-off-by: Richard Alpe Reviewed-by: Jon Maloy Reviewed-by: Ying

[patch net-next] mlxsw: pci: Adjust value of CPU egress traffic class

From: Ido Schimmel During initialization, when creating the send descriptor queues (SDQs), we specify the CPU egress traffic class of each SDQ. The maximum number of classes of this type is different in the two ASICs supported by this PCI driver. New firmware versions check

Re: [PATCH v4 net-next 3/4] soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF

On 01/04/2016 11:41 PM, Craig Gallek wrote: From: Craig Gallek Expose socket options for setting a classic or extended BPF program for use when selecting sockets in an SO_REUSEPORT group. These options can be used on the first socket to belong to a group before bind or on

[PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace

[I stole this patch from Eric Biederman. He wrote:] > There is no defined mechanism to pass network namespace information > into /sbin/bridge-stp therefore don't even try to invoke it except > for bridge devices in the initial network namespace. > > It is possible for unprivileged users to cause

[PATCH net-next v1 1/2] tipc: move netlink policies to netlink.h

Make the c files less cluttered and enable netlink attributes to be shared between files. This will prove useful in a future patch where a node message will contain a nested network. Signed-off-by: Richard Alpe Acked-by: Jon Maloy ---

[PATCH net-next v1 2/2] tipc: add peer removal functionality

Add TIPC_NL_PEER_REMOVE netlink command. This command can remove an offline peer node from the internal data structures. This will be supported by the tipc user space tool in iproute2. Signed-off-by: Richard Alpe Reviewed-by: Jon Maloy

Re: [RFC PATCH net-next 3/3] macsec: introduce IEEE 802.1AE driver

On Mon, 2015-12-28 at 13:38 +0100, Sabrina Dubroca wrote: > +#define MACSEC_SCI_LEN 8 > + > +/* SecTAG length = macsec_eth_header without the optional SCI */ > +#define MACSEC_TAG_LEN 6 > + > +struct macsec_eth_header { > + struct ethhdr eth; > + /* SecTAG */ > + u8 tci_an; > +#if

Re: rsi: Delete unnecessary variable initialisations in rsi_send_mgmt_pkt()

Hi Markus, On Tue, Jan 5, 2016 at 7:29 PM, SF Markus Elfring wrote: >> That said, if you figure out some change that produces significant >> reductions in code or binary size on multiple architectures without >> making things more complicated, less readable or

Re: [PATCH V5 9/9] hvsock: introduce Hyper-V VM Sockets feature

Dexuan Cui writes: Just some minor nitpicks below -- I have to admit I didn't test the feature. [..skip..] > + > + if (sk->sk_err) { > + ret = -sk->sk_err; > + goto out_wait_error; > + } else { > + ret = 0; > + } > + >

[PATCH iproute2 1/2] tipc: fix help text spelling error in node.c

--- tipc/node.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tipc/node.c b/tipc/node.c index 163fb74..201fe1a 100644 --- a/tipc/node.c +++ b/tipc/node.c @@ -245,7 +245,7 @@ static int cmd_node_get(struct nlmsghdr *nlh, const struct cmd *cmd, void cmd_node_help(struct cmdl

Re: [PATCH net-next 1/5] sctp: add the rhashtable apis for sctp global transport hashtable

On Thu, Dec 31, 2015 at 1:41 AM, Marcelo Ricardo Leitner wrote: > On Wed, Dec 30, 2015 at 11:50:46PM +0800, Xin Long wrote: > ... >> +void sctp_hash_transport(struct sctp_transport *t) >> +{ >> + struct sctp_sockaddr_entry *addr; >> + struct sctp_hash_cmp_arg

Re: [PATCH 1/1] net/ipv6: add sysctl option accept_ra_min_hop_limit

Hi, Machida-san. Yuki Machida wrote: > Please apply the following patch to v4.1.x. > > By ommit 6fd99094de2b ("ipv6: Don't reduce hop limit for an interface") s/ommit/commit/ Futher comment below. : > Signed-off-by: Hangbin Liu > Acked-by: YOSHIFUJI Hideaki

Re: [PATCH] rt2x00pci: Disable memory-write-invalidate when the driver exits

On Tue, Jan 5, 2016 at 2:27 AM, Jia-Ju Bai wrote: > On 01/05/2016 12:50 AM, Helmut Schaa wrote: >> >> On Mon, Jan 4, 2016 at 8:55 AM, Jia-Ju Bai wrote: >>> >>> The driver calls pci_set_mwi to enable memory-write-invalidate when it >>> is initialized,

pull-request: wireless-drivers-next 2016-01-05

Hi Dave, here's a big pull request for 4.5, which I should have sent to you earlier but instead I was wasting my time with eating way too much chocolate and keeping my brains in low power mode :) Once again 'git request-pull' got diffstat wrong so I had to manually fix it, but at least based on

Re: [PATCH (net-next.git) 04/18] stmmac: remove modulo in stmmac_xmit()

Hi David On 1/5/2016 4:34 AM, David Miller wrote: From: Giuseppe Cavallaro Date: Mon, 4 Jan 2016 14:06:49 +0100 @@ -2056,7 +2068,10 @@ static netdev_tx_t stmmac_xmit(struct sk_buff *skb, struct net_device *dev) priv->hw->desc->set_tx_owner(first);

Re: [PATCH (net-next.git) 09/18] stmmac: optimize tx desc management

On 1/5/2016 4:39 AM, David Miller wrote: From: Giuseppe Cavallaro Date: Mon, 4 Jan 2016 14:06:54 +0100 @@ -334,12 +334,11 @@ struct stmmac_desc_ops { /* Invoked by the xmit function to prepare the tx descriptor */ void (*prepare_tx_desc) (struct

[PATCH 1/1 v2] include/uapi/linux/sockios.h: mark SIOCRTMSG unused

IOCTL SIOCRTMSG does nothing but return EINVAL. So comment it as unused. SIOCRTMSG is only used in: * net/ipv4/af_inet.c * include/uapi/linux/sockios.h inet_ioctl calls ip_rt_ioctl. ip_rt_ioctl only handles SIOCADDRT and SIOCDELRT and returns -EINVAL otherwise. Signed-off-by: Heinrich

Re: [PATCH (net-next.git) 02/18] stmmac: rework DMA bus setting and introduce new platform AXI structure

On 1/5/2016 4:29 AM, David Miller wrote: From: Giuseppe Cavallaro Date: Mon, 4 Jan 2016 14:06:47 +0100 @@ -81,7 +81,7 @@ static void stmmac_default_data(struct plat_stmmacenet_data *plat) plat->mdio_bus_data->phy_mask = 0; plat->dma_cfg->pbl = 32; -

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

On Tue, Jan 5, 2016 at 3:14 PM, Eric Dumazet wrote: > On Tue, 2016-01-05 at 12:07 +0100, Jacob Siverskog wrote: >> On Mon, Jan 4, 2016 at 4:25 PM, Eric Dumazet wrote: >> > On Mon, 2016-01-04 at 10:10 +0100, Jacob Siverskog wrote: >> >> On Wed, Dec

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

On Tue, 2016-01-05 at 15:34 +0100, Jacob Siverskog wrote: > On Tue, Jan 5, 2016 at 3:14 PM, Eric Dumazet wrote: > > > > You might build a kernel with KASAN support to get maybe more chances to > > trigger the bug. > > > > (

[PATCH] net: filter: make JITs zero A for SKF_AD_ALU_XOR_X

The SKF_AD_ALU_XOR_X ancillary is not like the other ancillary data instructions since it XORs A with X while all the others replace A with some loaded value. All the BPF JITs fail to clear A if this is used as the first instruction in a filter. This was found using american fuzzy lop. Add a

Re: [PATCH] net: filter: make JITs zero A for SKF_AD_ALU_XOR_X

On Tue, 2016-01-05 at 16:23 +0100, Rabin Vincent wrote: > The SKF_AD_ALU_XOR_X ancillary is not like the other ancillary data > instructions since it XORs A with X while all the others replace A with > some loaded value. All the BPF JITs fail to clear A if this is used as > the first instruction

Re: [PATCH] net: filter: make JITs zero A for SKF_AD_ALU_XOR_X

On 01/05/2016 04:23 PM, Rabin Vincent wrote: The SKF_AD_ALU_XOR_X ancillary is not like the other ancillary data instructions since it XORs A with X while all the others replace A with some loaded value. All the BPF JITs fail to clear A if this is used as the first instruction in a filter.

Re: [PATCH stable-3.2 stable-3.12] net: fix checksum check in skb_copy_and_csum_datagram_iovec()

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 01/05/2016, 05:40 PM, Ben Hutchings wrote: > On Tue, 2016-01-05 at 17:36 +0100, Jiri Slaby wrote: >> On 12/28/2015, 03:01 PM, Michal Kubecek wrote: >>> Recent fix "net: add length argument to >>> skb_copy_and_csum_datagram_iovec" added to some

RE: [PATCH V5 5/9] Drivers: hv: vmbus: add APIs to send/recv hvsock packets

> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Tuesday, January 5, 2016 20:39 > ... > > +/* > > + * vmbus_sendpacket_hvsock - Send the hvsock payload 'buf' of a length > > 'len' > > + */ > > +int vmbus_sendpacket_hvsock(struct vmbus_channel *channel, void *buf, > u32 len) > > ... >

Re: [PATCH net-next 1/2] Support outside netns for tunnels.

Le 04/01/2016 19:45, Saurabh Mohan a écrit : This patch enchances a tunnel interface, like gre, to have the tunnel encap/decap be in the context of a network namespace that is different from the namespace of the tunnel interface. From userspace this feature may be configured using the new

[PATCH] ARM: net: bpf: fix zero right shift

The LSR instruction cannot be used to perform a zero right shift since a 0 as the immediate value (imm5) in the LSR instruction encoding means that a shift of 32 is perfomed. See DecodeIMMShift() in the ARM ARM. Make the JIT skip generation of the LSR if a zero-shift is requested. This was

[PATCH] net: lan78xx: Fix to write to OTP(One Time Programmable) per magic number.

This patch fixes a bug writing to EEPROM in lan78xx_ethtool_set_eeprom() when asked to write to OTP. Signed-off-by: Woojung Huh --- drivers/net/usb/lan78xx.c | 55 ++- 1 file changed, 54 insertions(+), 1 deletion(-) diff

Re: [PATCH net-next] soreuseport: change consume_skb to kfree_skb in error case

On 01/05/2016 04:57 PM, Craig Gallek wrote: From: Craig Gallek Fixes: 538950a1b752 ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF") Suggested-by: Daniel Borkmann Signed-off-by: Craig Gallek Thanks, Craig. Acked-by: Daniel

Re: [PATCH stable-3.2 stable-3.12] net: fix checksum check in skb_copy_and_csum_datagram_iovec()

On Tue, 2016-01-05 at 17:36 +0100, Jiri Slaby wrote: > On 12/28/2015, 03:01 PM, Michal Kubecek wrote: > > Recent fix "net: add length argument to > > skb_copy_and_csum_datagram_iovec" added to some pre-3.19 stable > > branches, namely > > > >   stable-3.2.y: commit 127500d724f8 > >  

RE: [PATCH V5 7/9] Drivers: hv: vmbus: add a mechanism to pass hvsock events to the hvsock driver

> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > > diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c > > > > +/* hvsock related definitions */ > > +enum hvsock_event { > > + /* The host application is close()-ing the connection */ > > + HVSOCK_RESCIND_CHANNEL, > > +}; >

[PATCH] net: sched: fix missing free per cpu on qstats

When a qdisc is using per cpu stats (currently just the ingress qdisc) only the bstats are being freed. This also free's the qstats. Signed-off-by: John Fastabend --- net/sched/sch_generic.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH] arm64: net: bpf: don't BUG() on large shifts

Attempting to generate UBFM/SBFM instructions with shifts that can't be encoded in the immediate fields of the opcodes leads to a trigger of a BUG() in the instruction generation code. As the ARMv8 ARM says: "The shift amounts must be in the range 0 to one less than the register width of the

Re: [PATCH net-next] soreuseport: change consume_skb to kfree_skb in error case

On Tue, 2016-01-05 at 10:57 -0500, Craig Gallek wrote: > From: Craig Gallek > > Fixes: 538950a1b752 ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF") > Suggested-by: Daniel Borkmann > Signed-off-by: Craig Gallek > --- >

Re: [PATCH] net: filter: make JITs zero A for SKF_AD_ALU_XOR_X

On Tue, Jan 05, 2016 at 08:00:45AM -0800, Eric Dumazet wrote: > On Tue, 2016-01-05 at 16:23 +0100, Rabin Vincent wrote: > > The SKF_AD_ALU_XOR_X ancillary is not like the other ancillary data > > instructions since it XORs A with X while all the others replace A with > > some loaded value. All

Re: [PATCH stable-3.2 stable-3.12] net: fix checksum check in skb_copy_and_csum_datagram_iovec()

On 12/28/2015, 03:01 PM, Michal Kubecek wrote: > Recent fix "net: add length argument to > skb_copy_and_csum_datagram_iovec" added to some pre-3.19 stable > branches, namely > > stable-3.2.y: commit 127500d724f8 > stable-3.12.y: commit 3e1ac3aafbd0 Applied this fix to 3.12. Thanks! >

Re: linux-next: manual merge of the rdma tree with the net-next tree

On 1/5/2016 3:51 AM, Stephen Rothwell wrote: Hi Doug, Today's linux-next merge of the rdma tree got conflicts in: drivers/net/ethernet/mellanox/mlx5/core/vport.c include/linux/mlx5/mlx5_ifc.h include/linux/mlx5/vport.h between commits: e1d7d349c69d ("net/mlx5: Update access

Re: [PATCH] net: sched: fix missing free per cpu on qstats

On Tue, 2016-01-05 at 09:11 -0800, John Fastabend wrote: > When a qdisc is using per cpu stats (currently just the ingress > qdisc) only the bstats are being freed. This also free's the qstats. > > Signed-off-by: John Fastabend > --- Acked-by: Eric Dumazet

Re: [PATCH] net: filter: make JITs zero A for SKF_AD_ALU_XOR_X

On Tue, Jan 05, 2016 at 05:36:47PM +0100, Daniel Borkmann wrote: > On 01/05/2016 04:23 PM, Rabin Vincent wrote: > >The SKF_AD_ALU_XOR_X ancillary is not like the other ancillary data > >instructions since it XORs A with X while all the others replace A with > >some loaded value. All the BPF JITs

Re: [PATCH] net: filter: make JITs zero A for SKF_AD_ALU_XOR_X

On 01/05/2016 05:03 PM, Rabin Vincent wrote: On Tue, Jan 05, 2016 at 08:00:45AM -0800, Eric Dumazet wrote: On Tue, 2016-01-05 at 16:23 +0100, Rabin Vincent wrote: The SKF_AD_ALU_XOR_X ancillary is not like the other ancillary data instructions since it XORs A with X while all the others

Re: [PATCH v5 net-next 3/3] dt-bindings: net: macb: Add NP4 macb variant

Le 05/01/2016 14:39, Neil Armstrong a écrit : > Add NP4 macb SoC variant. > > Signed-off-by: Neil Armstrong Acked-by: Nicolas Ferre Neil, thanks for your understanding and reactivity concerning this patch series. Bye, > --- >

Re: [PATCH v5 net-next 2/3] net: macb: Add NP4 macb config using USRIO_DISABLED

Le 05/01/2016 14:39, Neil Armstrong a écrit : > Declare a new NP4 SoC variant having USRIO_DISABLED as capability bit. > > Signed-off-by: Neil Armstrong Acked-by: Nicolas Ferre > --- > drivers/net/ethernet/cadence/macb.c | 6 ++ > 1 file

Re: [RFC PATCH net-next 03/24] phy: Use phy_read() instead of mdiobus_read()

On Mon, Jan 04, 2016 at 12:07:43PM -0800, Florian Fainelli wrote: > On 04/01/16 09:36, Andrew Lunn wrote: > > Since we have a phydev, make use of it and the phy_read() function. > > This will help with later refactoring. > > > > Signed-off-by: Andrew Lunn > > --- > > [snip] > >

[PATCH v5 net-next 3/3] dt-bindings: net: macb: Add NP4 macb variant

Add NP4 macb SoC variant. Signed-off-by: Neil Armstrong --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt index

Re: [PATCH v4 net-next 3/4] soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF

On Tue, Jan 5, 2016 at 4:38 AM, Daniel Borkmann wrote: > On 01/04/2016 11:41 PM, Craig Gallek wrote: >> >> From: Craig Gallek >> >> Expose socket options for setting a classic or extended BPF program >> for use when selecting sockets in an SO_REUSEPORT

Re: [PATCH] net: Fix potential NULL pointer dereference in __skb_try_recv_datagram

On Tue, 2016-01-05 at 12:07 +0100, Jacob Siverskog wrote: > On Mon, Jan 4, 2016 at 4:25 PM, Eric Dumazet wrote: > > On Mon, 2016-01-04 at 10:10 +0100, Jacob Siverskog wrote: > >> On Wed, Dec 30, 2015 at 11:30 PM, Cong Wang > >> wrote: > >> > On

Re: [RFC v5 5/6] Add PTP_SYS_OFFSET_PRECISE for driver crosstimestamping

On Mon, Jan 04, 2016 at 04:45:22AM -0800, Christopher S. Hall wrote: > @@ -138,6 +142,7 @@ long ptp_ioctl(struct posix_clock *pc, unsigned int cmd, > unsigned long arg) > caps.n_per_out = ptp->info->n_per_out; > caps.pps = ptp->info->pps; > caps.n_pins =

[PATCH net-next] soreuseport: change consume_skb to kfree_skb in error case

From: Craig Gallek Fixes: 538950a1b752 ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF") Suggested-by: Daniel Borkmann Signed-off-by: Craig Gallek --- net/core/sock_reuseport.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v5 net-next 1/3] net: ethernet: cadence-macb: Add disabled usrio caps

Le 05/01/2016 14:39, Neil Armstrong a écrit : > On some platforms, the macb integration does not use the USRIO > register to configure the (R)MII port and clocks. > When the register is not implemented and the MACB error signal > is connected to the bus error, reading or writing to the USRIO >

[PATCH v5 net-next 1/3] net: ethernet: cadence-macb: Add disabled usrio caps

On some platforms, the macb integration does not use the USRIO register to configure the (R)MII port and clocks. When the register is not implemented and the MACB error signal is connected to the bus error, reading or writing to the USRIO register can trigger some Imprecise External Aborts on ARM

[PATCH v5 net-next 0/3] Add new capability and macb DT variant

The first patch introduces a new capability bit to disable usage of the USRIO register on platform not implementing it thus avoiding some external imprecise aborts on ARM based platforms. The two last patchs adds a new macb variant compatible name using the capability, the NP4 SoC uses this

[PATCH v5 net-next 2/3] net: macb: Add NP4 macb config using USRIO_DISABLED

Declare a new NP4 SoC variant having USRIO_DISABLED as capability bit. Signed-off-by: Neil Armstrong --- drivers/net/ethernet/cadence/macb.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/cadence/macb.c

RE: [PATCH V5 4/9] Drivers: hv: ring_buffer: enhance hv_ringbuffer_read() to support hvsock

> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Tuesday, January 5, 2016 20:31 > ... > > To get the payload of hvsock, we need raw=0 to skip the level-1 header > > (i.e., struct vmpacket_descriptor desc) and we also need to skip the > > level-2 header (i.e., struct

Re: [PATCH net-next] soreuseport: change consume_skb to kfree_skb in error case

On Tue, Jan 5, 2016 at 12:38 PM, Eric Dumazet wrote: > On Tue, 2016-01-05 at 10:57 -0500, Craig Gallek wrote: >> From: Craig Gallek >> >> Fixes: 538950a1b752 ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF") >> Suggested-by: Daniel Borkmann

Re: [PATCH next] net/core/dev: Warn on an impossibly short offload frame

Joe Perches writes: > On Sat, 2016-01-02 at 19:25 -0500, Aaron Conole wrote: >> When signaling that a GRO frame is ready to be processed, the network stack >> correctly checks length and aborts processing when a frame is less than 14 >> bytes. However, such a condition is really

Re: [PATCH] net: sched: fix missing free per cpu on qstats

From: Eric Dumazet Date: Tue, 05 Jan 2016 09:44:11 -0800 > David, please add the following tag to ease backports to stable kernels: > > Fixes: 22e0f8b9322cb ("net: sched: make bstats per cpu and estimator RCU > safe") Ok, will do, thanks! -- To unsubscribe from this

Re: [PATCH net-next 1/5] sctp: add the rhashtable apis for sctp global transport hashtable

On 12/30/2015 10:50 AM, Xin Long wrote: > tranport hashtbale will replace the association hashtable to do the > lookup for transport, and then get association by t->assoc, rhashtable > apis will be used because of it's resizable, scalable and using rcu. > > lport + rport + paddr will be the base

Re: [PATCH 0/2] ppp: add netlink support

From: Guillaume Nault Date: Tue, 5 Jan 2016 19:10:20 +0100 > On Wed, Dec 23, 2015 at 09:04:46PM +0100, Guillaume Nault wrote: >> This series adds netlink support for creating PPP devices. >> > Any feedback on this series? I can see that it has been marked > "Deferred" in

Re: [patch v2] qlcnic: fix a timeout loop

No. This patch is a suspend resume thing and your bug is something else. Honestly, this patch is a static checker fix and I doubt it has much real worl impact at all. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to

Re: [PATCH] net: sched: fix missing free per cpu on qstats

On 01/05/2016 06:11 PM, John Fastabend wrote: When a qdisc is using per cpu stats (currently just the ingress qdisc) only the bstats are being freed. This also free's the qstats. Signed-off-by: John Fastabend Acked-by: Daniel Borkmann -- To

[PATCH v2 net-next] net: Implement fast csum_partial for x86_64

Implement assembly routine for csum_partial for 64 bit x86. This primarily speeds up checksum calculation for smaller lengths such as those that are present when doing skb_postpull_rcsum when getting CHECKSUM_COMPLETE from device or after CHECKSUM_UNNECESSARY conversion. This implementation is

Re: [PATCH net-next V3 0/4] Introduce mlx5 ethernet timestamping

Thank you David and Richard. On Tue, Jan 5, 2016 at 9:12 PM, David Miller wrote: > From: Saeed Mahameed > Date: Tue, 29 Dec 2015 14:58:28 +0200 > >> This patch series introduces the support for ConnectX-4 timestamping >> and the PTP kernel interface. >

Re: [PATCH 0/2] ppp: add netlink support

On Tue, Jan 05, 2016 at 02:15:34PM -0500, David Miller wrote: > From: Guillaume Nault > Date: Tue, 5 Jan 2016 19:10:20 +0100 > > > On Wed, Dec 23, 2015 at 09:04:46PM +0100, Guillaume Nault wrote: > >> This series adds netlink support for creating PPP devices. > >> > > Any

Re: [PATCH net-next] soreuseport: change consume_skb to kfree_skb in error case

On Tue, 2016-01-05 at 12:47 -0500, Craig Gallek wrote: > On Tue, Jan 5, 2016 at 12:38 PM, Eric Dumazet wrote: > > > > BTW, why UDP calls reuseport_select_sock() with hdr_len == 0 sometimes ? > hdr_len only matters when you have an skb to work with. In both of > the call

Re: [PATCH (net-next.git) 01/18] stmmac: share reset function between dwmac100 and dwmac1000

From: Giuseppe CAVALLARO Date: Tue, 5 Jan 2016 10:03:28 +0100 > On 1/5/2016 4:25 AM, David Miller wrote: >> From: Giuseppe Cavallaro >> Date: Mon, 4 Jan 2016 14:06:46 +0100 >> >>> @@ -376,7 +376,8 @@ extern const struct stmmac_desc_ops ndesc_ops;

Re: [PATCH] arm64: net: bpf: don't BUG() on large shifts

On Tue, Jan 05, 2016 at 06:39:03PM +0100, Rabin Vincent wrote: > Attempting to generate UBFM/SBFM instructions with shifts that can't be > encoded in the immediate fields of the opcodes leads to a trigger of a > BUG() in the instruction generation code. As the ARMv8 ARM says: "The > shift amounts

Re: [PATCH net-next V3 0/4] Introduce mlx5 ethernet timestamping

From: Richard Cochran Date: Tue, 5 Jan 2016 13:51:18 +0100 > On Mon, Jan 04, 2016 at 04:47:03PM -0500, David Miller wrote: >> Richard, please review this series. > > It looks fine to me now, and I acked the timestamping/phc bits. Thank you. -- To unsubscribe from this

Re: [PATCH net-next] soreuseport: change consume_skb to kfree_skb in error case

On Tue, Jan 5, 2016 at 1:31 PM, Eric Dumazet wrote: > On Tue, 2016-01-05 at 12:47 -0500, Craig Gallek wrote: >> On Tue, Jan 5, 2016 at 12:38 PM, Eric Dumazet wrote: > >> > >> > BTW, why UDP calls reuseport_select_sock() with hdr_len == 0 sometimes

Re: [PATCH net-next V3 0/4] Introduce mlx5 ethernet timestamping

From: Saeed Mahameed Date: Tue, 29 Dec 2015 14:58:28 +0200 > This patch series introduces the support for ConnectX-4 timestamping > and the PTP kernel interface. Series applied, thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: [PATCH] ARM: net: bpf: fix zero right shift

On Tue, Jan 05, 2016 at 06:34:04PM +0100, Rabin Vincent wrote: > The LSR instruction cannot be used to perform a zero right shift since a > 0 as the immediate value (imm5) in the LSR instruction encoding means > that a shift of 32 is perfomed. See DecodeIMMShift() in the ARM ARM. > > Make the

Re: [PATCH 0/2] ppp: add netlink support

On Wed, Dec 23, 2015 at 09:04:46PM +0100, Guillaume Nault wrote: > This series adds netlink support for creating PPP devices. > Any feedback on this series? I can see that it has been marked "Deferred" in patchwork, so I'm unsure about what to do with this patch set now. Should I repost later

Re: [PATCH net-next 2/5] sctp: apply rhashtable api to send/recv path

On 12/30/2015 10:50 AM, Xin Long wrote: > apply lookup apis to two functions, for __sctp_endpoint_lookup_assoc > and __sctp_lookup_association, it's invoked in the protection of sock > lock, it will be safe, but sctp_lookup_association need to call > rcu_read_lock() and to detect the t->dead to

Re: [PATCH net-next] soreuseport: change consume_skb to kfree_skb in error case

On Tue, 2016-01-05 at 14:12 -0500, Craig Gallek wrote: > OK, I can buy that an skb should be piped through udp4|6_lib_lookup2, > but I don't think it's safe to remove the skb NULL check in > reuseport_select_sock. There's at least one path (udp_diag.c: > udp_dump_one) which does a lookup without

[PATCH net-next] soreuseport: pass skb to secondary UDP socket lookup

From: Craig Gallek This socket-lookup path did not pass along the skb in question in my original BPF-based socket selection patch. The skb in the udpN_lib_lookup2 path can be used for BPF-based socket selection just like it is in the 'traditional' udpN_lib_lookup path.

Re: [PATCH] net: sched: fix missing free per cpu on qstats

On Tue, Jan 5, 2016 at 9:44 AM, Eric Dumazet wrote: > On Tue, 2016-01-05 at 09:11 -0800, John Fastabend wrote: >> When a qdisc is using per cpu stats (currently just the ingress >> qdisc) only the bstats are being freed. This also free's the qstats. >> >> Signed-off-by:

Re: [PATCH net-next] soreuseport: pass skb to secondary UDP socket lookup

From: Craig Gallek Date: Tue, 5 Jan 2016 15:08:07 -0500 > From: Craig Gallek > > This socket-lookup path did not pass along the skb in question > in my original BPF-based socket selection patch. The skb in the > udpN_lib_lookup2 path can be used for

Re: [PATCH] net: sched: fix missing free per cpu on qstats

On Tue, 2016-01-05 at 18:49 -0800, Cong Wang wrote: > On Tue, Jan 5, 2016 at 9:44 AM, Eric Dumazet wrote: > > On Tue, 2016-01-05 at 09:11 -0800, John Fastabend wrote: > >> When a qdisc is using per cpu stats (currently just the ingress > >> qdisc) only the bstats are being

Re: [PATCH RFC] vhost: basic device IOTLB support

On 01/05/2016 11:18 AM, Yang Zhang wrote: > On 2016/1/4 14:22, Jason Wang wrote: >> >> >> On 01/04/2016 09:39 AM, Yang Zhang wrote: >>> On 2015/12/31 15:13, Jason Wang wrote: This patch tries to implement an device IOTLB for vhost. This could be used with for co-operation with

Re: [PATCH net-next 01/12] net/mlx5_core: Introduce flow steering autogrouped flow table

From: Saeed Mahameed Date: Tue, 5 Jan 2016 22:04:02 +0200 > - /* Add node to tree */ > - tree_init_node(>node, 1, del_flow_group); Why in the world would you take a properly formatted comment: > + /*Add node to tree*/ And proceed to molest it like this?

Re: [PATCH] 6pack: fix free memory scribbles

From: Alan Date: Tue, 05 Jan 2016 11:51:25 + > commit acf673a3187edf72068ee2f92f4dc47d66baed47 fixed a user triggerable free > memory scribble but in doing so replaced it with a different one that allows > the user to control the data and scribble even more. > >

Re: [PATCH] be2net: Delete an unnecessary check in two functions

On Fri, Jan 1, 2016 at 4:52 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 1 Jan 2016 00:11:57 +0100 > > Remove two checks for null pointers which would be handled by usual > error detection before. > >

Re: [PATCH] net: take care of bonding in build_skb_flow_key

在 2016年01月06日 15:35, zhuyj 写道: IMHO, "The path MTU is set to the active slave device, not the bonding master." Can we set PMTU to bonding master when path MTU is set to the active slave device? Actually the route is set on bonding master, not on any slave, the trying to set PMTU to the

[PATCH] rfcomm: fix information leak in rfcomm_sock_bind

if addr_len < sizeof(sa), sa.rc_bdaddr(4bytes) can be leaked by using rfcomm_sock_getname() Signed-off-by: Insu Yun --- net/bluetooth/rfcomm/sock.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/net/bluetooth/rfcomm/sock.c

Re: pull-request: wireless-drivers-next 2016-01-05

From: Kalle Valo Date: Tue, 05 Jan 2016 12:28:36 +0200 > here's a big pull request for 4.5, which I should have sent to you > earlier but instead I was wasting my time with eating way too much > chocolate and keeping my brains in low power mode :) > > Once again 'git

Re: [PATCH net-next] ethernet/atheros/alx: sanitize buffer sizing and padding

From: Jarod Wilson Date: Tue, 5 Jan 2016 18:12:34 -0500 > - if ((raw_mtu + 8) < ALX_TXQ1_JUMBO_TSO_TH) > - val = (raw_mtu + 8 + 7) >> 3; > + if ((raw_mtu) < ALX_TXQ1_JUMBO_TSO_TH) > + val = (raw_mtu + 7) >> 3; The parenthesis around 'raw_mtu'

Re: [PATCH] rfcomm: fix information leak in rfcomm_sock_bind

Hi Insu, > if addr_len < sizeof(sa), sa.rc_bdaddr(4bytes) can be leaked > by using rfcomm_sock_getname() > > Signed-off-by: Insu Yun > --- > net/bluetooth/rfcomm/sock.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git

Re: [PATCH 1/1] net/ipv6: add sysctl option accept_ra_min_hop_limit

Hi, Yoshifuji-san. Thanks for your kindly check. I will correct it in Patch v2. Best Regards, Yuki Machida On 2016年01月05日 19:17, YOSHIFUJI Hideaki wrote: > Hi, Machida-san. > > Yuki Machida wrote: >> Please apply the following patch to v4.1.x. >> >> By ommit 6fd99094de2b ("ipv6: Don't reduce

Re: [PATCH v2 net-next] net: Implement fast csum_partial for x86_64

On Wed, 2016-01-06 at 00:35 +0100, Hannes Frederic Sowa wrote: > > Tom, did you have a look if it makes sense to add a second carry > addition train with the adcx instruction, which does not signal carry > via the carry flag but with the overflow flag? This instruction should > not have any

RE: [PATCH V5 9/9] hvsock: introduce Hyper-V VM Sockets feature

> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Tuesday, January 5, 2016 17:52 > > Just some minor nitpicks below -- I have to admit I didn't test the feature. > > [..skip..] > > > + > > + if (sk->sk_err) { > > + ret = -sk->sk_err; > > + goto out_wait_error;

Re: [patch net-next] mlxsw: pci: Adjust value of CPU egress traffic class

From: Jiri Pirko Date: Tue, 5 Jan 2016 11:36:40 +0100 > From: Ido Schimmel > > During initialization, when creating the send descriptor queues (SDQs), > we specify the CPU egress traffic class of each SDQ. The maximum number > of classes of this type is

Re: [PATCH] ARM: net: bpf: fix zero right shift

From: Rabin Vincent Date: Tue, 5 Jan 2016 18:34:04 +0100 > The LSR instruction cannot be used to perform a zero right shift since a > 0 as the immediate value (imm5) in the LSR instruction encoding means > that a shift of 32 is perfomed. See DecodeIMMShift() in the ARM ARM. > >

Re: [PATCH net-next] net, sched: add clsact qdisc

On Tue, Jan 5, 2016 at 5:00 PM, Daniel Borkmann wrote: > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index c20b814..752c0d2 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -1739,7 +1739,9 @@ struct net_device { >

Re: [PATCH] net: take care of bonding in build_skb_flow_key

Hi Yanjun, Thanks for your review. Master MTU is same as that for slaves. Maybe fixing in bonding driver is a good idea, but I don't find a good place to do that. Let's go through the simplified follow: ... 1) Fragmentation. --This is is done is against the bonding master device(device MTU

Re: [PATCH v2 net-next] net: Implement fast csum_partial for x86_64

On Tue, 2016-01-05 at 17:10 -0800, H. Peter Anvin wrote: > Apparently "adcq.d8" will do The Right Thing for this. Nice trick ;) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] net: hns: avoid uninitialized variable warning:

From: Arnd Bergmann Date: Fri, 01 Jan 2016 23:27:57 +0100 > gcc fails to see that the use of the 'last_offset' variable > in hns_nic_reuse_page() is used correctly and issues a bogus > warning: > > drivers/net/ethernet/hisilicon/hns/hns_enet.c: In function >

Re: [Intel-wired-lan] [PATCH 2/2] ixgbe: restrict synchronization of link_up and speed

On 12/31/2015 12:37 AM, Tantilov, Emil S wrote: -Original Message- From: zhuyj [mailto:zyjzyj2...@gmail.com] Sent: Wednesday, December 30, 2015 12:20 AM To: Tantilov, Emil S; Kirsher, Jeffrey T; Brandeburg, Jesse; Nelson, Shannon; Wyborny, Carolyn; Skidmore, Donald C; Allan, Bruce W;

Re: [PATCH] net: take care of bonding in build_skb_flow_key

在 2016年01月06日 14:18, David Miller 写道: From: Wengang Wang Date: Wed, 6 Jan 2016 13:49:28 +0800 @@ -523,11 +523,20 @@ static void build_skb_flow_key(struct flowi4 *fl4, const struct sk_buff *skb, const struct sock *sk) {

  1   2   >