[PATCH 4/4] net: thunderx: Improvement for MBX interface debug messages

From: Radoslaw Biernacki Adding debug messages in case of NACK for a mailbox message, also did small cleanups. Signed-off-by: Radoslaw Biernacki Signed-off-by: Sunil Goutham --- drivers/net/ethernet/cavium/thunder/nic_main.c | 16

[PATCH 3/4] net: thunderx: add sysfs attribute for SQS/SVF assigments

From: Radoslaw Biernacki With this sysfs attribute (sriov_sqs_assignment) administrator will be able to read the current assigment of SQS/SVF for a given VF. This is useful to decide which VFs needs to be attached to UIO for a successful allocation of secondary Qsets

RE: [PATCHv2] wlcore: spi: add wl18xx support

> > > > It is also part of the generic spi.h (include/Linux/spi/spi.h), > > > > already part of " struct spi_device" So it seemed redundant adding > > > > another mechanism for implementing the same. > > > > Platform that interact with a wilink need to use it, and platforms > > > > that don't have

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

Hi, On 04/19/2016 04:56 PM, Andrew Goodbody wrote: > Adding a 2nd PHY to cpsw results in a NULL pointer dereference > as below. Fix by maintaining a reference to each PHY node in slave > struct instead of a single reference in the priv struct which was > overwritten by the 2nd PHY. David, Is it

Re: [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats

From: Nicolas Dichtel Date: Tue, 19 Apr 2016 09:45:32 +0200 > But we finally discover that some netlink API use the attribute '0'. I explicitly did not use attribute zero, and instead made a new IFLA_* attribute exactly to avoid compatability problems. Every netlink

Re: [PATCH net-next] net/hsr: Added support for HSR v1

From: Stephen Hemminger Date: Tue, 19 Apr 2016 08:21:00 -0700 > On Wed, 13 Apr 2016 13:52:22 +0200 > Peter Heise wrote: > >> diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h >> index 9427f17..bb3a90b 100644 >> ---

Re: Poorer networking performance in later kernels?

From: Oliver Hartkopp Date: Tue, 19 Apr 2016 17:58:03 +0200 > On 04/19/2016 04:54 PM, Butler, Peter wrote: > >> >> I think the issue is resolved. I had to recompile my 4.4.0 kernel >> with a few options pertaining to the Intel NIC which somehow (?) got >> left out or

Re: [RFC PATCH net-next 2/8] sfc: batch up RX delivery on EF10

On Tue, 2016-04-19 at 17:36 +0100, Edward Cree wrote: > > We have to really invent something better, like a real pipeline, instead > > of hacks like this, adding complexity everywhere. > I'm not sure what you mean by 'a real pipeline' in this context, could you > elaborate? > > > Have you tested

Re: [PATCH 5/5] drivers/net: support hdlc function for QE-UCC

Le 30/03/2016 10:50, Zhao Qiang a écrit : The driver add hdlc support for Freescale QUICC Engine. It support NMSI and TSA mode. When using TSA, how does the TSA gets configured ? Especially how do you describe which Timeslot is switched to HDLC channels ? Is it possible to route some Timeslots

Re: [RFC PATCH net-next 7/8] net: ipv4: listified version of ip_rcv

On Tue, 2016-04-19 at 08:46 -0700, Tom Herbert wrote: > Right, this is significant complexity for a fairly narrow use case. > One alternative might be to move early type demux like functionality > to the GRO layer. There's a lot of work done by GRO to parse and > identify packets of the same

Re: [RFC PATCH net-next 7/8] net: ipv4: listified version of ip_rcv

On 19/04/16 15:50, Eric Dumazet wrote: > The main problem in UDP stack today is having to lock the socket because > of the dumb forward allocation problem. I'm not quite sure what you're referring to here, care to educate me? > Are you really going to provide > a list of skbs up to _one_ UDP

Re: [PATCHv2] wlcore: spi: add wl18xx support

On Mon, Apr 18, 2016 at 05:55:51AM +, Reizer, Eyal wrote: > > I would suggest fixing this using a new API function from the SPI core, if > > we > > don't already have a generic way to do it. > Originally this is what I have done until I was pointed to the generic > cs-gpio mechanism > in

Re: [PATCHv2] wlcore: spi: add wl18xx support

On Tue, Apr 19, 2016 at 09:05:45AM +, Reizer, Eyal wrote: > Understood. As this special CS manipulation is unique to wspi (wilink spi) I > think the > best option is to move this gpio allocation into wlcore_spi as a new device > tree entry > used only by this driver. That sounds like it

Re: [RFC PATCH net-next 7/8] net: ipv4: listified version of ip_rcv

On 19/04/16 16:46, Tom Herbert wrote: > On Tue, Apr 19, 2016 at 7:50 AM, Eric Dumazet wrote: >> We have hard time to deal with latencies already, and maintaining some >> sanity in the stack(s) > Right, this is significant complexity for a fairly narrow use case. Why do you

[RFC PATCH net-next 3/8] net: core: unwrap skb list receive slightly further

Adds iterator skb_queue_for_each() to run over a list without modifying it. Signed-off-by: Edward Cree --- include/linux/skbuff.h | 16 include/trace/events/net.h | 7 +++ net/core/dev.c | 4 +++- 3 files changed, 26 insertions(+), 1

[RFC PATCH net-next 2/8] sfc: batch up RX delivery on EF10

Improves packet rate of 1-byte UDP receives by 10%. Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/ef10.c | 9 + drivers/net/ethernet/sfc/efx.c| 2 ++ drivers/net/ethernet/sfc/net_driver.h | 3 +++ drivers/net/ethernet/sfc/rx.c | 7

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

On Tue, 19 Apr 2016 17:41:07 +0300 Grygorii Strashko wrote: > Hi, > > On 04/19/2016 04:56 PM, Andrew Goodbody wrote: > > Adding a 2nd PHY to cpsw results in a NULL pointer dereference > > as below. Fix by maintaining a reference to each PHY node in slave > > struct

Re: [RFC PATCH net-next 2/8] sfc: batch up RX delivery on EF10

On 19/04/16 15:47, Eric Dumazet wrote: > On Tue, 2016-04-19 at 14:35 +0100, Edward Cree wrote: >> Improves packet rate of 1-byte UDP receives by 10%. > Sure, by adding yet another queue and extra latencies. > > If the switch delivered a high prio packet to your host right before a > train of 60

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

On Tue, 19 Apr 2016 18:44:41 +0300 Grygorii Strashko wrote: > On 04/19/2016 06:01 PM, David Rivshin (Allworx) wrote: > > On Tue, 19 Apr 2016 17:41:07 +0300 > > Grygorii Strashko wrote: > > > >> Hi, > >> > >> On 04/19/2016 04:56 PM, Andrew

Re: [PATCH net-next V3 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V)

Hi, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/K-Y-Srinivasan/ethernet-intel-Add-the-device-ID-s-presented-while-running-on-Hyper-V/20160419-221508 config: i386-randconfig-s0-201616 (attached as .config) reproduce: # save the attached

Re: [PATCH iproute2] ss: take care of unknown min_rtt

On Wed, 13 Apr 2016 15:18:38 -0700 Eric Dumazet wrote: > From: Eric Dumazet > > Kernel sets info->tcpi_min_rtt to ~0U when no RTT sample was ever > taken for the session, thus min_rtt is unknown. > > Signed-off-by: Eric Dumazet

Re: [patch iproute2 00/11] devlink: add support for shared buffer configuration and control

On Fri, 15 Apr 2016 09:51:42 +0200 Jiri Pirko wrote: > From: Jiri Pirko > > Jiri Pirko (11): > devlink: fix "devlink port" help message > list: add list_for_each_entry_reverse macro > list: add list_add_tail helper > devlink: introduce

Re: [PATCH net] tcp: Fix SOF_TIMESTAMPING_TX_ACK when handling dup acks

On Mon, Apr 18, 2016 at 6:39 PM, Martin KaFai Lau wrote: > Assuming SOF_TIMESTAMPING_TX_ACK is on. When dup acks are received, > it could incorrectly think that a skb has already > been acked and queue a SCM_TSTAMP_ACK cmsg to the > sk->sk_error_queue. > > In tcp_ack_tstamp(), it

[PATCH net-next V3 0/2] ethernet: intel: Support Hyper-V hosts

Make adjustments to the Intel 10G VF driver to support running on Hyper-V hosts. K. Y. Srinivasan (2): ethernet: intel: Add the device ID's presented while running on Hyper-V intel: ixgbevf: Support Windows hosts (Hyper-V) drivers/net/ethernet/intel/ixgbevf/defines.h |5 +

Re: [RFC PATCH net-next 2/8] sfc: batch up RX delivery on EF10

On Tue, 2016-04-19 at 14:35 +0100, Edward Cree wrote: > Improves packet rate of 1-byte UDP receives by 10%. Sure, by adding yet another queue and extra latencies. If the switch delivered a high prio packet to your host right before a train of 60 low prio packets, this is not to allow us to wait

Re: [PATCH] rtl8xxxu: hide unused tables

Arnd Bergmann writes: > The references to some arrays in the rtl8xxxu driver were moved inside > of an #ifdef, but the symbols remain outside, resulting in build warnings: > > rtl8xxxu/rtl8xxxu.c:1506:33: error: 'rtl8188ru_radioa_1t_highpa_table' > defined but not used >

Re: [PATCH iproute2] ip: neigh: Fix leftover attributes message during flush

On Thu, 14 Apr 2016 14:15:03 -0400 Jeff Harris wrote: > Use the same rtnl_dump_request_n call as the show. The rtnl_wilddump_request > assumes the type uses an ifinfomsg which is not the case for the neighbor > table. > > Signed-off-by: Jeff Harris

[RFC PATCH net-next 8/8] net: ipv4: listify ip_rcv_finish

Signed-off-by: Edward Cree --- net/ipv4/ip_input.c | 58 - 1 file changed, 53 insertions(+), 5 deletions(-) diff --git a/net/ipv4/ip_input.c b/net/ipv4/ip_input.c index e7d0d85..5bbc409 100644 --- a/net/ipv4/ip_input.c

[PATCH net-next V3 1/2] ethernet: intel: Add the device ID's presented while running on Hyper-V

Intel SR-IOV cards present different ID when running on Hyper-V. Add the device IDs presented while running on Hyper-V. Signed-off-by: K. Y. Srinivasan --- V2: No change from V1. V3: No change from V2. drivers/net/ethernet/intel/ixgbevf/defines.h |5

[PATCH net-next V3 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V)

On Hyper-V, the VF/PF communication is a via software mediated path as opposed to the hardware mailbox. Make the necessary adjustments to support Hyper-V. Signed-off-by: K. Y. Srinivasan V2: Addressed most of the comments from Alexander Duyck

Re: [PATCHv2] wlcore: spi: add wl18xx support

On Tuesday 19 April 2016 09:05:45 Reizer, Eyal wrote: > > > It is also part of the generic spi.h (include/Linux/spi/spi.h), > > > already part of " struct spi_device" So it seemed redundant adding > > > another mechanism for implementing the same. > > > Platform that interact with a wilink need to

[RFC PATCH net-next 0/8] Handle multiple received packets at each stage

Earlier discussions on this list[1] suggested that having multiple packets traverse the network stack together (rather than calling the stack for each packet singly) could improve performance through better cache locality. This patch series is an attempt to implement this by having drivers pass an

[PATCH 0/4] net: thunderx: Add multiqset support for DPDK

From: Sunil Goutham This patch series mainly adds support for userspace application like DPDK with a VNIC VF attached to request additional QSets for having morethan the default 8 queues. Jerin Jacob (1): net: thunderx: Introduce a mailbox message to reset VF counters

[RFC PATCH net-next 1/8] net: core: trivial netif_receive_skb_list() entry point

Just calls netif_receive_skb() in a loop. Signed-off-by: Edward Cree --- include/linux/netdevice.h | 1 + net/core/dev.c| 20 2 files changed, 21 insertions(+) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index

[PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs

Resend to add more people on Cc: as requested by Grygrii Strashko. This is a fix for a NULL pointer dereference from cpsw which is triggered by having two slave PHYs attached to a cpsw network device. The problem is due to only maintaining a single reference to a PHY node in the prive data which

[patch -next] geneve: testing the wrong variable in geneve6_build_skb()

We intended to test "err" and not "skb". Fixes: aed069df099c ('ip_tunnel_core: iptunnel_handle_offloads returns int and doesn't free skb') Signed-off-by: Dan Carpenter diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c index efbc7ce..512dbe0 100644 ---

Re: [RFC PATCH net-next 7/8] net: ipv4: listified version of ip_rcv

On Tue, 2016-04-19 at 14:37 +0100, Edward Cree wrote: > Also involved adding a way to run a netfilter hook over a list of packets. > Rather than attempting to make netfilter know about lists (which would be > horrendous) we just let it call the regular okfn (in this case > ip_rcv_finish()) for any

Re: [iproute PATCH 0/2] Minor ss filter fix and review

On Wed, 13 Apr 2016 22:07:03 +0200 Phil Sutter wrote: > While looking for a solution to the problem described in patch 2/2, I > discovered the overly complicated assignment in filter_states_set() which > is simplified in patch 1/2. > > Phil Sutter (2): > ss: Drop silly assignment

[PATCH 1/4] net: thunderx: Introduce a mailbox message to reset VF counters

From: Jerin Jacob Write access to VF statistics counter register is only allowed from PF. Added a new mailbox message to reset VF's Rx/Tx counters, this is used by userspace DPDK. Signed-off-by: Jerin Jacob Signed-off-by: Sunil

[PATCH 2/4] net: thunderx: Add multiqset support for dataplane apps

From: Radoslaw Biernacki This patch adds support to PF for allocating additional Qsets to dataplane apps such as DPDK. Till now PF, upon host bound interface's request it used to allocate Qsets from the free ones, but for dataplane apps support has been added for it to request

[RFC PATCH net-next 6/8] net: core: propagate SKB lists through packet_type lookup

This could maybe be made more efficient if we first split the list based on skb->protocol, and then did ptype lookup for each sublist. Unfortunately, there are things liks sch_handle_ingress and the rx_handlers that can produce different results per packet. Signed-off-by: Edward Cree

[RFC PATCH net-next 5/8] net: core: another layer of lists, around PF_MEMALLOC skb handling

First example of a layer splitting the list (rather than merely taking individual packets off it). Again, trying to factor the common parts wouldn't make this any nicer. Signed-off-by: Edward Cree --- net/core/dev.c | 36 ++-- 1 file

[RFC PATCH net-next 7/8] net: ipv4: listified version of ip_rcv

Also involved adding a way to run a netfilter hook over a list of packets. Rather than attempting to make netfilter know about lists (which would be horrendous) we just let it call the regular okfn (in this case ip_rcv_finish()) for any packets it steals, and have it give us back a list of packets

[RFC PATCH net-next 4/8] net: core: Another step of skb receive list processing

netif_receive_skb_list_internal() now processes a list and hands it on to the next function. The code duplication is unfortunate, but the common part between the list and non-list versions of the function takes a lock (rcu_read_lock()), so factoring it out would be a little ugly. Signed-off-by:

[PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

Adding a 2nd PHY to cpsw results in a NULL pointer dereference as below. Fix by maintaining a reference to each PHY node in slave struct instead of a single reference in the priv struct which was overwritten by the 2nd PHY. [ 17.870933] Unable to handle kernel NULL pointer dereference at

Re: [RFC PATCH v2 net-next 2/7] tcp: Merge tx_flags/tskey/txstamp_ack in tcp_collapse_retrans

On Tue, Apr 19, 2016 at 01:32:14AM -0400, Soheil Hassas Yeganeh wrote: > > + TCP_SKB_CB(skb)->txstamp_ack = > > + !!(shinfo->tx_flags & SKBTX_ACK_TSTAMP); > > Maybe we can skip a conditional jump here (because of !!), by simply > using the cached bit in

[PATCH net 0/5] macsec: a few fixes

Some small fixes for the macsec driver: - possible NULL pointer dereferences - netlink dumps fixes: RTNL locking, consistent dumps - a reference counting bug Sabrina Dubroca (5): macsec: add missing NULL check after kmalloc macsec: take rtnl lock before for_each_netdev macsec: don't put

[PATCH net 5/5] macsec: add consistency check to netlink dumps

Use genl_dump_check_consistent in dump_secy. Fixes: c09440f7dcb3 ("macsec: introduce IEEE 802.1AE driver") Suggested-by: Johannes Berg Signed-off-by: Sabrina Dubroca Acked-by: Hannes Frederic Sowa ---

[PATCH net 1/5] macsec: add missing NULL check after kmalloc

Fixes: c09440f7dcb3 ("macsec: introduce IEEE 802.1AE driver") Reported-by: Dan Carpenter Signed-off-by: Sabrina Dubroca Acked-by: Hannes Frederic Sowa --- drivers/net/macsec.c | 4 ++-- 1 file changed, 2 insertions(+),

[PATCH net 2/5] macsec: take rtnl lock before for_each_netdev

Fixes: c09440f7dcb3 ("macsec: introduce IEEE 802.1AE driver") Reported-by: Johannes Berg Signed-off-by: Sabrina Dubroca Acked-by: Hannes Frederic Sowa --- drivers/net/macsec.c | 7 ++- 1 file changed, 2

Re: [RFC PATCH v2 net-next 1/7] tcp: Carry txstamp_ack in tcp_fragment_tstamp

On Tue, Apr 19, 2016 at 1:39 PM, Martin KaFai Lau wrote: > On Tue, Apr 19, 2016 at 01:21:04AM -0400, Soheil Hassas Yeganeh wrote: >> Could you please submit the timestamping patches separately as non RFCs? >> Thanks! > Agree. I will re-spin. Great, thank you very much!

Re: [patch -next] geneve: testing the wrong variable in geneve6_build_skb()

On Tue, Apr 19, 2016 at 7:30 AM, Dan Carpenter wrote: > We intended to test "err" and not "skb". > > Fixes: aed069df099c ('ip_tunnel_core: iptunnel_handle_offloads returns int > and doesn't free skb') > Signed-off-by: Dan Carpenter > > diff

Re: [PATCHv2] wlcore: spi: add wl18xx support

On Tue, Apr 19, 2016 at 05:38:02PM +, Reizer, Eyal wrote: > Hi Mark, > > Hope you can see the attached picture that illustrates what need to sent for > sucesfull SPI init. I think what the picture shows is that you just need to send at least one byte at the end of the transfer *after*

[PATCH] drivers: net: cpsw: fix wrong regs access in cpsw_ndo_open

The cpsw_ndo_open() could try to access CPSW registers before calling pm_runtime_get_sync(). This will trigger L3 error: WARNING: CPU: 0 PID: 21 at drivers/bus/omap_l3_noc.c:147 l3_interrupt_handler+0x220/0x34c() 4400.ocp:L3 Custom Error: MASTER M2 (64-bit) TARGET L4_FAST (Idle): Data

Re: [RFC PATCH v2 net-next 2/7] tcp: Merge tx_flags/tskey/txstamp_ack in tcp_collapse_retrans

On Tue, Apr 19, 2016 at 10:35:52AM -0700, Eric Dumazet wrote: > On Tue, Apr 19, 2016 at 10:28 AM, Martin KaFai Lau wrote: > > > A bit off topic, I feel like the SKBTX_ACK_TSTAMP and txstamp_ack are sort > > of redundant but I have not look into the details yet, so not completely > >

RE: [Intel-wired-lan] i40e error handling LLDP messages from Arista switches

> -Original Message- > From: Jeremy Ashton [mailto:jeremy.ash...@shopify.com] > Sent: Tuesday, April 19, 2016 11:10 AM > To: Parikh, Neerav > Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: Re: [Intel-wired-lan] i40e error handling LLDP

Re: [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats

From: David Miller Date: Tue, 19 Apr 2016 01:03:16 -0400 (EDT) > From: Eric Dumazet > Date: Mon, 18 Apr 2016 21:32:04 -0700 > >> On Mon, 2016-04-18 at 23:41 -0400, David Miller wrote: >>> >>> + /* Add a zero length NOP attribute so that the

Re: [PATCHv2] wlcore: spi: add wl18xx support

On Tue, Apr 19, 2016 at 06:04:49PM +, Reizer, Eyal wrote: > Thanks! Glad the illustration helped. > I will try it out again as if i recall cotrectly, i did try that l, and it > didnt produce the correct waveform, but perhaps i didnt understand the usage > of .cs_change correctly. > Will

Re: [PATCH net 1/5] macsec: add missing NULL check after kmalloc

- Original Message - > From: "Sabrina Dubroca" > To: netdev@vger.kernel.org > Cc: "Hannes Frederic Sowa" , "Johannes Berg" > , "Dan Carpenter" > , "Sabrina Dubroca"

Re: [RFC PATCH net-next 7/8] net: ipv4: listified version of ip_rcv

On Tue, 2016-04-19 at 18:12 +0100, Edward Cree wrote: > I think if we pushed bundled RX all the way up to the TCP layer, it might > potentially also be faster than GRO, because it avoids the work of > coalescing superframes; plus going through the GRO callbacks for each > packet could end up

Re: [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats

From: Johannes Berg Date: Tue, 19 Apr 2016 12:09:03 +0200 > At netconf, we talked about how awkward it can be that one doesn't know > if an attribute was accepted by the kernel or simply ignored because > it's not supported (older kernel version). > > I considered

Re: [RFC PATCH v2 net-next 2/7] tcp: Merge tx_flags/tskey/txstamp_ack in tcp_collapse_retrans

On Tue, Apr 19, 2016 at 10:28 AM, Martin KaFai Lau wrote: > A bit off topic, I feel like the SKBTX_ACK_TSTAMP and txstamp_ack are sort > of redundant but I have not look into the details yet, so not completely > sure. It wwould be a separate cleanup patch if it is the case.

[PATCH net 3/5] macsec: don't put a NULL rxsa

The "deliver:" path of macsec_handle_frame can be called with rx_sa == NULL. Check rx_sa != NULL before calling macsec_rxsa_put(). Fixes: c09440f7dcb3 ("macsec: introduce IEEE 802.1AE driver") Signed-off-by: Sabrina Dubroca Acked-by: Hannes Frederic Sowa

[PATCH net 4/5] macsec: fix rx_sa refcounting with decrypt callback

The decrypt callback macsec_decrypt_done needs a reference on the rx_sa and releases it before returning, but macsec_handle_frame already put that reference after macsec_decrypt returned NULL. Change macsec_decrypt to return error codes, and use -EINPROGRESS as an indication that

Re: [RFC PATCH net-next 2/8] sfc: batch up RX delivery on EF10

On 19/04/16 18:20, Eric Dumazet wrote: > It seems all the discussions about fast kernel networking these days is > adding yet another queues, code duplication and complexity, batches, and > add latencies, on top of a single NIC RX queue. > > Apparently the multiqueue nature of a NIC is obsolete

Re: [RFC PATCH net-next 2/8] sfc: batch up RX delivery on EF10

On Tue, 2016-04-19 at 18:42 +0100, Edward Cree wrote: > Well, I don't know how to achieve that, but it sounds like you do, so why > not go ahead and show us ;) > If you submitted a patch series to make UDP twice as fast, I think people > would "really care" about an improvement of that magnitude.

[net-next PATCH 2/2] veth: Update features to include all tunnel GSO types

This patch adds support for the checksum enabled versions of UDP and GRE tunnels. With this change we should be able to send and receive GSO frames of these types over the veth pair without needing to segment the packets. Signed-off-by: Alexander Duyck ---

[net-next PATCH 1/2] netdev_features: Fold NETIF_F_ALL_TSO into NETIF_F_GSO_SOFTWARE

This patch folds NETIF_F_ALL_TSO into the bitmask for NETIF_F_GSO_SOFTWARE. The idea is to avoid duplication of defines since the only difference between the two was the GSO_UDP bit. Signed-off-by: Alexander Duyck --- include/linux/netdev_features.h |8 +++- 1 file

Re: [RFC PATCH v2 net-next 2/7] tcp: Merge tx_flags/tskey/txstamp_ack in tcp_collapse_retrans

On Tue, Apr 19, 2016 at 2:18 PM, Martin KaFai Lau wrote: > On Tue, Apr 19, 2016 at 10:35:52AM -0700, Eric Dumazet wrote: >> On Tue, Apr 19, 2016 at 10:28 AM, Martin KaFai Lau wrote: >> >> > A bit off topic, I feel like the SKBTX_ACK_TSTAMP and txstamp_ack are sort >>

Re: [RFC PATCH net-next 7/8] net: ipv4: listified version of ip_rcv

On Tue, Apr 19, 2016 at 10:12 AM, Edward Cree wrote: > On 19/04/16 16:46, Tom Herbert wrote: >> On Tue, Apr 19, 2016 at 7:50 AM, Eric Dumazet wrote: >>> We have hard time to deal with latencies already, and maintaining some >>> sanity in the stack(s)

Re: [PATCHv2] wlcore: spi: add wl18xx support

On Tue, Apr 19, 2016 at 05:21:01PM +, Reizer, Eyal wrote: > The main quirk here is that i need to send extra clocks after the spi init > command while the CS pin is "high" in order to put the wilink chip into SPI > mode. > So just sending an empty transfer wouldnt do the trick here. A

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

On 19/04/16 10:14, David Rivshin (Allworx) wrote: >> Ah Ok. There are no user of cpsw_platform_data outside of net/ethernet/ti/, >> so yes, looks like your patch 1 does exactly what's needed. > > Given that the v1 of Andrew's patch is already in Dave's net tree, and > would obviously have many

RE: [Intel-wired-lan] i40e error handling LLDP messages from Arista switches

Resending as the original email was sent in HTLM format and hence my reply went in that format as well; which got rejected by netdev mailer. > -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Parikh, Neerav > Sent: Tuesday,

Re: [RFC PATCH net-next 7/8] net: ipv4: listified version of ip_rcv

On Tue, 2016-04-19 at 17:50 +0100, Edward Cree wrote: > On 19/04/16 15:50, Eric Dumazet wrote: > > The main problem in UDP stack today is having to lock the socket because > > of the dumb forward allocation problem. > I'm not quite sure what you're referring to here, care to educate me? This was

Re: [PATCH] rtl8xxxu: hide unused tables

Kalle Valo writes: > Jes Sorensen writes: > >> Arnd Bergmann writes: >>> The references to some arrays in the rtl8xxxu driver were moved inside >>> of an #ifdef, but the symbols remain outside, resulting in build warnings: >>> >>>

[PATCH net-next V4 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V)

On Hyper-V, the VF/PF communication is a via software mediated path as opposed to the hardware mailbox. Make the necessary adjustments to support Hyper-V. Signed-off-by: K. Y. Srinivasan --- V2: Addressed most of the comments from Alexander Duyck

[PATCH net-next V4 0/2] ethernet: intel: Support Hyper-V hosts

Make adjustments to the Intel 10G VF driver to support running on Hyper-V hosts. K. Y. Srinivasan (2): ethernet: intel: Add the device ID's presented while running on Hyper-V intel: ixgbevf: Support Windows hosts (Hyper-V) drivers/net/ethernet/intel/ixgbevf/defines.h |5 +

[PATCH net-next V4 1/2] ethernet: intel: Add the device ID's presented while running on Hyper-V

Intel SR-IOV cards present different ID when running on Hyper-V. Add the device IDs presented while running on Hyper-V. Signed-off-by: K. Y. Srinivasan --- V4: No change from V1 drivers/net/ethernet/intel/ixgbevf/defines.h |5 + 1 files changed, 5

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

On 4/19/2016 2:22 PM, Christoph Hellwig wrote: > What I think we need is something like the patch below. In the long > ru nwe should also kill the mlx4_buf structure which now is pretty > pointless. Maybe; this could be the correct approach if we can guarantee that the architecture can allocate

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

On 04/19/2016 08:14 PM, David Rivshin (Allworx) wrote: On Tue, 19 Apr 2016 18:44:41 +0300 Grygorii Strashko wrote: On 04/19/2016 06:01 PM, David Rivshin (Allworx) wrote: On Tue, 19 Apr 2016 17:41:07 +0300 Grygorii Strashko wrote: Hi, On

Re: [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats

On Tue, 2016-04-19 at 14:31 -0400, David Miller wrote: > > Here is the final patch I'm about to push out, thanks a lot Eric. > > Roopa, please adjust your GETSTATS patch as needed (I think you need > to adjust the SELinux table entry as well) and we can integrate that > too. > >

Re: [PATCH net-next v5] rtnetlink: add new RTM_GETSTATS message to dump link stats

On Tue, 2016-04-19 at 14:31 -0400, David Miller wrote: > +#ifndef HAVE_EFFICIENT_UNALIGNED_ACCESS > + /* IF necessary, add a zero length NOP attribute so that the > + * nla_data() of the IFLA_STATS64 will be 64-bit aligned. > + * > + * The nlattr header is 4 bytes in size,

Re: [PATCH net-next V2 05/11] net/mlx5e: Support RX multi-packet WQE (Striding RQ)

On Tue, Apr 19, 2016 at 06:25:32PM +0200, Jesper Dangaard Brouer wrote: > On Mon, 18 Apr 2016 07:17:13 -0700 > Eric Dumazet wrote: > > > On Mon, 2016-04-18 at 16:05 +0300, Saeed Mahameed wrote: > > > On Mon, Apr 18, 2016 at 3:48 PM, Eric Dumazet

Re: [RFC PATCH v2 net-next 2/7] tcp: Merge tx_flags/tskey/txstamp_ack in tcp_collapse_retrans

On Tue, Apr 19, 2016 at 1:28 PM, Martin KaFai Lau wrote: > On Tue, Apr 19, 2016 at 01:32:14AM -0400, Soheil Hassas Yeganeh wrote: >> > + TCP_SKB_CB(skb)->txstamp_ack = >> > + !!(shinfo->tx_flags & SKBTX_ACK_TSTAMP); >> >> Maybe we can skip a

Re: [RFC PATCH v2 net-next 1/7] tcp: Carry txstamp_ack in tcp_fragment_tstamp

On Tue, Apr 19, 2016 at 01:21:04AM -0400, Soheil Hassas Yeganeh wrote: > Could you please submit the timestamping patches separately as non RFCs? > Thanks! Agree. I will re-spin.

Re: [Intel-wired-lan] i40e error handling LLDP messages from Arista switches

So, what commands exactly are you looking to have run? Would packet capture of the lldp traffic help? On Tue, Apr 19, 2016 at 1:53 PM, Parikh, Neerav wrote: > Resending as the original email was sent in HTLM format and hence my reply > went in that format > as well;

Re: [PATCH V2] net: ethernet: mellanox: correct page conversion

What I think we need is something like the patch below. In the long ru nwe should also kill the mlx4_buf structure which now is pretty pointless. --- >From a493881d2a6c90152d3daabb7b6b3afd1d254d78 Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Tue, 19 Apr 2016 14:12:14

Re: [PATCH net-next V2 05/11] net/mlx5e: Support RX multi-packet WQE (Striding RQ)

On Tue, Apr 19, 2016 at 7:25 PM, Jesper Dangaard Brouer wrote: > On Mon, 18 Apr 2016 07:17:13 -0700 > Eric Dumazet wrote: > >> Another idea would be to have a way to control max number of order-5 >> pages that a port would be using. >> >> Since driver

RE: Poorer networking performance in later kernels?

> I think the issue is resolved. I had to recompile my 4.4.0 kernel with a few > options pertaining to the Intel NIC which somehow (?) got left out or > otherwise clobbered when I ported my 3.4.2 .config to the 4.4.0 kernel source > tree. With those changes now in I see essentially identical

Re: Poorer networking performance in later kernels?

On 04/19/2016 04:54 PM, Butler, Peter wrote: I think the issue is resolved. I had to recompile my 4.4.0 kernel with a few options pertaining to the Intel NIC which somehow (?) got left out or otherwise clobbered when I ported my 3.4.2 .config to the 4.4.0 kernel source tree. With those

Re: [PATCH] ath9k: remove duplicate assignment of variable ah

Colin King writes: > From: Colin Ian King > > ah is written twice with the same value, remove one of the > redundant assignments to ah. > > Signed-off-by: Colin Ian King Applied, thanks. -- Kalle Valo

RE: Poorer networking performance in later kernels?

> -Original Message- > From: Rick Jones [mailto:rick.jon...@hpe.com] > Sent: April-15-16 6:37 PM > To: Butler, Peter ; netdev@vger.kernel.org > Subject: Re: Poorer networking performance in later kernels? > > On 04/15/2016 02:02 PM, Butler, Peter wrote: >> (Please

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

On 04/19/2016 06:01 PM, David Rivshin (Allworx) wrote: > On Tue, 19 Apr 2016 17:41:07 +0300 > Grygorii Strashko wrote: > >> Hi, >> >> On 04/19/2016 04:56 PM, Andrew Goodbody wrote: >>> Adding a 2nd PHY to cpsw results in a NULL pointer dereference >>> as below. Fix by

Re: [PATCH] rtl8xxxu: hide unused tables

Jes Sorensen writes: > Arnd Bergmann writes: >> The references to some arrays in the rtl8xxxu driver were moved inside >> of an #ifdef, but the symbols remain outside, resulting in build warnings: >> >> rtl8xxxu/rtl8xxxu.c:1506:33: error:

Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

From: Grygorii Strashko Date: Tue, 19 Apr 2016 17:41:07 +0300 > David, Is it possible to drop prev version of this patch from linux-next > - it breaks boot on many TI boards with -next. It doesn't work that way, I cannot "drop" patches. One has to send me a fix to the

Re: Poorer networking performance in later kernels?

On Tue, Apr 19, 2016 at 9:54 AM, Butler, Peter wrote: >> -Original Message- >> From: Rick Jones [mailto:rick.jon...@hpe.com] >> Sent: April-15-16 6:37 PM >> To: Butler, Peter ; netdev@vger.kernel.org >> Subject: Re: Poorer networking performance

Re: [PATCH net-next] net/hsr: Added support for HSR v1

On Wed, 13 Apr 2016 13:52:22 +0200 Peter Heise wrote: > diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h > index 9427f17..bb3a90b 100644 > --- a/include/uapi/linux/if_link.h > +++ b/include/uapi/linux/if_link.h > @@ -773,6 +773,7 @@ enum { >

Re: [RFC PATCH net-next 7/8] net: ipv4: listified version of ip_rcv

On Tue, Apr 19, 2016 at 7:50 AM, Eric Dumazet wrote: > On Tue, 2016-04-19 at 14:37 +0100, Edward Cree wrote: >> Also involved adding a way to run a netfilter hook over a list of packets. >> Rather than attempting to make netfilter know about lists (which would be >>

Re: [PATCH 2/2] net-ath9k_htc: Replace a variable initialisation by an assignment in ath9k_htc_set_channel()

Julian Calaby writes: > On Sat, Jan 2, 2016 at 5:25 AM, SF Markus Elfring > wrote: >> From: Markus Elfring >> Date: Fri, 1 Jan 2016 19:09:32 +0100 >> >> Replace an explicit initialisation for one local

Re: [PATCH net-next V2 05/11] net/mlx5e: Support RX multi-packet WQE (Striding RQ)

On Mon, 18 Apr 2016 07:17:13 -0700 Eric Dumazet wrote: > On Mon, 2016-04-18 at 16:05 +0300, Saeed Mahameed wrote: > > On Mon, Apr 18, 2016 at 3:48 PM, Eric Dumazet > > wrote: > > > On Sun, 2016-04-17 at 17:29 -0700, Eric Dumazet wrote: > > >

  1   2   3   >