Re: [PATCH net] sctp: fix a success return may hide an error

>> > This err returns back to sctp_sendmsg, there sctp will abort asoc. > > That's not right I think. sctp_sendmsg will only free the asoc if it was > created to send that specific chunk. And in this case, this change > should have no effect as it can't have sctp_outq_flush() touching > several

Re: [PATCH net] sctp: fix a success return may hide an error

On Wed, Aug 17, 2016 at 02:24:19AM +0800, Xin Long wrote: > >> > This err returns back to sctp_sendmsg, there sctp will abort asoc. > > > > That's not right I think. sctp_sendmsg will only free the asoc if it was > > created to send that specific chunk. And in this case, this change > > should

Re: [PATCH] net: macb: add phy-handle support for the macb

> Agree with you my intention is if there is a MDIO bus on the device-tree > The MAC driver should create PHY/MDIO devices using of_mdiobus_register(). What you suggest is better, and is similar to what other drivers use. In order to keep backwards compatibility with phy nodes in the MAC node,

Re: DSA + Marvell embedded switch question

On Mon, Aug 15, 2016 at 08:17:24PM -0400, John Fleming wrote: > Hi all, I have a embedded appliance I bought from a vendor and i'm > being told to file a RFE for this. > > The issue i have is the device has a embedded Marvell switch (88E1514 > ?). Hi John 1514 is probably a PHY, not a switch.

Re: kernel panic in qdisc_match_from_root starting openvswitch

On Tue, Aug 16, 2016 at 11:27 AM, David Ahern wrote: > Jiri: > > I am hitting a kernel panic with '/etc/init.d/openvswitch-switch restart' > Stack trace below. Reverting 59cc1f61f09c ("net: sched: convert qdisc linked > list to hashtable") clears the problem. > Jiri

Re: Microsemi VSC 8531/41 PHY Driver

On Fri, Aug 05, 2016 at 05:54:21PM +0530, Nagaraju Lakkaraju wrote: > Hello, > > I added all review comments and re-sending for review. You should also take a look at the output of scripts/checkpatch.pl: total: 9 errors, 82 warnings, 1 checks, 179 lines checked Andrew

Re: [PATCH RFC 0/1] xfrm: dst lookup doesn't account for fwmark

Shortly I will post an updated patch. Please ignore the 'onlink' on those routes. It is irrelevant. The particular use case is load balancing by using fwmark. Consider if we don't define any routes except load balancing based on fwmarks. The only requirement is that the traffic must exit the

Re: Fw: Linux tcp_xmit_retransmit_queue use after free on 4.8-rc1 / master]

On Tue, 2016-08-16 at 08:39 -0700, Eric Dumazet wrote: > On Tue, 2016-08-16 at 12:45 +0200, Greg KH wrote: > > For some reason Marco's emails can't make it to netdev, so I'm > > forwarding this on. Please cc: him on responses. > > Thanks for the report Greg and Marco. > > My first guess is this

Re: kernel panic in qdisc_match_from_root starting openvswitch

On Tue, 16 Aug 2016, Jiri Kosina wrote: > > I am hitting a kernel panic with '/etc/init.d/openvswitch-switch > > restart' Stack trace below. Reverting 59cc1f61f09c ("net: sched: convert > > qdisc linked list to hashtable") clears the problem. > > Thanks a lot for the report. Could you please

Re: [PATCH net] sctp: fix a success return may hide an error

On Tue, Aug 16, 2016 at 04:01:50PM +, David Laight wrote: > From: Xin Long > > Sent: 16 August 2016 12:34 > > > > >> Both sctp_outq_flush_rtx and sctp_packet_transmit can ONLY > > >> return one error (-ENOMEM), as sctp_outq_flush_rtx also calls > > >> sctp_packet_transmit. > > > > > > What is

kernel panic in qdisc_match_from_root starting openvswitch

Jiri: I am hitting a kernel panic with '/etc/init.d/openvswitch-switch restart' Stack trace below. Reverting 59cc1f61f09c ("net: sched: convert qdisc linked list to hashtable") clears the problem. [ 30.664503] BUG: unable to handle kernel NULL pointer dereference at 0418

Re: Microsemi VSC 8531/41 PHY Driver

On Fri, Aug 05, 2016 at 05:54:21PM +0530, Nagaraju Lakkaraju wrote: > Hello, > > I added all review comments and re-sending for review. > > >From a5017f5878a92d2acec86a6a29b1498c457cb73a Mon Sep 17 00:00:00 2001 > From: Nagaraju Lakkaraju > Date: Wed, 3 Aug 2016

Re: [PATCH RFC 1/1] xfrm: dst lookup doesn't account for fwmark

If route table includes routing based on fwmark, xfrm will not take it into account when routing ipsec traffic. We address this issue by adding fwmark information before calling route lookup. Also simplify lookup by passing the entire flow struct rather than tos, oif, and fwmark as individual

Re: kernel panic in qdisc_match_from_root starting openvswitch

On Tue, 16 Aug 2016, David Ahern wrote: > Jiri: > > I am hitting a kernel panic with '/etc/init.d/openvswitch-switch > restart' Stack trace below. Reverting 59cc1f61f09c ("net: sched: convert > qdisc linked list to hashtable") clears the problem. Thanks a lot for the report. Could you please

[PATCH net-next v3 0/2] Add enhancements to RX path

This patch set fix gives some enhancements about RX path handling. and thanks for Sergei Shtylyov helps reviewing during v2 to v3. v1 -> v2: Fix message typos and add coverletter v2 -> v3: Split from the previous series for submitting add enhancements as a series targeting 'net-next' and add

[PATCH net-next v3 2/2] net: ethernet: mediatek: enhance RX path by aggregating more SKBs into NAPI

The patch adds support for aggregating more SKBs feed into NAPI in order to get more benefits from generic receive offload (GRO) by peeking at the RX ring status and moving more packets right before returning from NAPI RX polling handler if NAPI budgets are still available. Signed-off-by: Sean

[PATCH net-next v3 1/2] net: ethernet: mediatek: enhance RX path by reducing the frequency of the memory barrier used

The patch makes moving wmb() to outside the loop that could help RX path handling more faster although that RX descriptors aren't freed for DMA to use as soon as possible, but based on my experiment and the result shows it still can reach about 943Mbpis without performance drop that is tested

Re: [PATCH] net: ip_finish_output_gso: If skb_gso_network_seglen exceeds MTU, allow segmentation for gre tunneled skbs

Hi, > Hi, > > On Fri, 12 Aug 2016 13:11:50 +0200, han...@stressinduktion.org wrote: >> I really would not like to see this expanded to gre and other protocols. >> All switches drop packets where the packets are exceeding the MTU, >> bridges and also openvswitch should behave the same. >> >>

[ANNOUNCE] Netdev 1.2 updates (16th August, 2016)

Hello folks, I hope all of you're fine. Here is an update for coming Netdev 1.2 Tokyo. * Summary 1) extended early-bird registration 2) paper submission deadline 3) slides submission deadline 4) newly accepted sessions So here we go. 1) extended early bird registration deadline Due to

[PATCH 09/16] batman-adv: add B.A.T.M.A.N. V bat_{orig, neigh}_dump implementations

From: Matthias Schiffer Dump the algo V originators and neighbours. Signed-off-by: Matthias Schiffer Signed-off-by: Andrew Lunn [s...@narfation.org: Fix includes, fix algo_ops integration] Signed-off-by: Sven

[PATCH 07/16] batman-adv: netlink: add originator and neighbor table queries

From: Matthias Schiffer Add BATADV_CMD_GET_ORIGINATORS and BATADV_CMD_GET_NEIGHBORS commands, using handlers bat_orig_dump and bat_neigh_dump in batadv_algo_ops. Will always return -EOPNOTSUPP for now, as no implementations exist yet. Signed-off-by: Matthias

[PATCH 01/16] batman-adv: Handle parent interfaces in a different netns

From: Andrew Lunn batman-adv tries to prevent the user from placing a batX soft interface into another batman mesh as a hard interface. It does this by walking up the devices list of parents and ensures they are all none batX interfaces. iflink can point to an interface in a

[PATCH 04/16] batman-adv: netlink: hardif query

From: Matthias Schiffer BATADV_CMD_GET_HARDIFS will return the list of hardifs (including index, name and MAC address) of all hardifs for a given softif. Signed-off-by: Matthias Schiffer Signed-off-by: Andrew Lunn

[PATCH 02/16] batman-adv: Suppress debugfs entries for netns's

From: Andrew Lunn Debugfs is not netns aware. It thus has problems when the same interface name exists in multiple network name spaces. Work around this by not creating entries for interfaces in name spaces other than the default name space. This means meshes in network

[PATCH 05/16] batman-adv: netlink: add translation table query

From: Matthias Schiffer This adds the commands BATADV_CMD_GET_TRANSTABLE_LOCAL and BATADV_CMD_GET_TRANSTABLE_GLOBAL, which correspond to the transtable_local and transtable_global debugfs files. The batadv_tt_client_flags enum is moved to the UAPI to expose it as

[PATCH 10/16] batman-adv: netlink: add gateway table queries

From: Sven Eckelmann Add BATADV_CMD_GET_GATEWAYS commands, using handlers bat_gw_dump in batadv_algo_ops. Will always return -EOPNOTSUPP for now, as no implementations exist yet. Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner

[PATCH 06/16] batman-adv: Provide TTVN in the mesh_info netlink msg

From: Sven Eckelmann The TTVN is the main information for the debugging of translation table problems. It is therefore necessary when comparing the global translation tables. Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich

Re: [PATCH v2] Bluetooth: Add LED triggers for HCI frames tx and rx

Hi Guodong, > Two LED triggers are added into hci_dev: tx_led and rx_led. Upon ACL/SCO > packets available in tx or rx, the LEDs will blink. > > For each hci registration, two triggers are added into LED subsystem: > [hdev->name]-tx and [hdev-name]-rx. > Refer to

Re: [PATCH net-next v3 0/2] Add enhancements to RX path

You have to wait for me to merge the 'net' tree into 'net-next' before you submit these changes. These patches won't apply cleanly otherwise. That will happen the next time I merge my tree to Linus which should be in the next day or two.

RE: [PATCH] net: macb: add phy-handle support for the macb

Hi David Miller, Thanks for the review... > > From: Kedareswara rao Appana > Date: Sat, 13 Aug 2016 15:31:49 +0530 > > > @@ -445,7 +445,13 @@ static int macb_mii_init(struct macb *bp) > > dev_set_drvdata(>dev->dev, bp->mii_bus); > > > > np =

RE: [RFC PATCH v5 3/3] net: phy: Add gmiitorgmii converter support

Hi Andrew, > > > Signed-off-by: Kedareswara rao Appana > > --- > > Thanks a lot Andrew for your inputs. > > Changes for v5: > > --> Fixed return values in the probe as suggested by punnaiah. > > --> Added a mask for the converter speed as suggested by punnaiah. > > +/*

[PATCH 08/16] batman-adv: add B.A.T.M.A.N. IV bat_{orig, neigh}_dump implementations

From: Matthias Schiffer Signed-off-by: Matthias Schiffer Signed-off-by: Andrew Lunn [sven.eckelm...@open-mesh.com: Fix function parameter alignments, add policy for attributes, fix includes, fix algo_ops

[PATCH 11/16] batman-adv: add B.A.T.M.A.N. IV bat_gw_dump implementations

From: Andrew Lunn Dump the list of gateways via the netlink socket. Signed-off-by: Andrew Lunn [sven.eckelm...@open-mesh.com: integrate in batadv_algo_ops] Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich

[PATCH 14/16] batman-adv: Provide bla group in the mesh_info netlink msg

From: Sven Eckelmann The bridge loop avoidange is the main information for the debugging of of bridge loop detection problems. It is therefore necessary when comparing the bla claim tables. Signed-off-by: Sven Eckelmann Signed-off-by: Simon Wunderlich

[PATCH 03/16] batman-adv: netlink: add routing_algo query

From: Matthias Schiffer BATADV_CMD_GET_ROUTING_ALGOS is used to get the list of supported routing algorithms. Signed-off-by: Matthias Schiffer Signed-off-by: Andrew Lunn [sven.eckelm...@open-mesh.com: Reduce the

[PATCH 00/16] pull request for net-next: batman-adv 2016-08-16

b5dcbad25219b82408e15e6d775a406be2116af1: batman-adv: Fix consistency of update route messages (2016-08-09 07:54:34 +0200) are available in the git repository at: git://git.open-mesh.org/linux-merge.git tags/batadv-next-for-davem-20160816 for you to fetch changes up

[PATCH 12/16] batman-adv: add B.A.T.M.A.N. V bat_gw_dump implementations

From: Sven Eckelmann Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner Signed-off-by: Simon Wunderlich --- net/batman-adv/bat_v.c | 125 + 1

[PATCH 13/16] batman-adv: add B.A.T.M.A.N. Dump BLA claims via netlink

From: Andrew Lunn Dump the list of bridge loop avoidance claims via the netlink socket. Signed-off-by: Andrew Lunn [sven.eckelm...@open-mesh.com: add policy for attributes, fix includes, fix soft_iface reference leak] Signed-off-by: Sven Eckelmann

[PATCH 15/16] batman-adv: add backbone table netlink support

Dump the list of bridge loop avoidance backbones via the netlink socket. Signed-off-by: Simon Wunderlich Signed-off-by: Sven Eckelmann Signed-off-by: Marek Lindner --- include/uapi/linux/batman_adv.h| 2 +

[PATCH 16/16] batman-adv: Indicate netlink socket can be used with netns.

From: Andrew Lunn Set the netnsof flag on the family structure, indicating it can be used with different network name spaces. Signed-off-by: Andrew Lunn Signed-off-by: Simon Wunderlich Signed-off-by: Sven Eckelmann

Re: [PATCH net v3 0/3] Fix warning and issue

From: Sean Wang Date: Tue, 16 Aug 2016 13:55:12 +0800 > This patch set fixes the following warning and issues > > v1 -> v2: Fix message typos and add coverletter > > v2 -> v3: Split from the previous series for submitting bug fixes > as a series targeting 'net' Series

[PATCH] net: atm: remove redundant null pointer check on dev->name

From: Colin Ian King dev->name is a char array of IFNAMSIZ elements, hence can never be null, so the null pointer check is redundant. Remove it. Signed-off-by: Colin Ian King --- net/atm/mpc.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v2] Bluetooth: Add LED triggers for HCI frames tx and rx

Hi, Marcel On 16 August 2016 at 14:03, Marcel Holtmann wrote: > Hi Guodong, > >> Two LED triggers are added into hci_dev: tx_led and rx_led. Upon ACL/SCO >> packets available in tx or rx, the LEDs will blink. >> >> For each hci registration, two triggers are added into LED

[PATCH] net: sched: fix handling of singleton qdiscs with qdisc_hash

From: Jiri Kosina qdisc_match_from_root() is now iterating over per-netdevice qdisc hashtable instead of going through a linked-list of qdiscs (independently on the actual underlying netdev), which used to be the case before the switch to hashtable for qdiscs. For singleton

[PATCH 1/1] ppp: Fix one deadlock issue of PPP when send frame

From: Gao Feng PPP channel holds one spinlock before send frame. But the skb may select the same PPP channel with wrong route policy. As a result, the skb reaches the same channel path. It tries to get the same spinlock which is held before. Bang, the deadlock comes out. Now

RE: [PATCH net] sctp: fix a success return may hide an error

From: Xin Long > Sent: 13 August 2016 08:48 > > > > This style of error handling is dangerous. The first error can be > > lost. > > > > For example, if sctp_outq_flush_rtx() earlier in this function returns > > an error, it will be lost if any invocation of the function > > sctp_packet_transmit()

Fw: Linux tcp_xmit_retransmit_queue use after free on 4.8-rc1 / master]

For some reason Marco's emails can't make it to netdev, so I'm forwarding this on. Please cc: him on responses. thanks, greg k-h - Forwarded message from Marco Grassi - Date: Mon, 15 Aug 2016 09:20:17 +0800 From: Marco Grassi To:

[PATCH v2 1/1] ppp: Fix one deadlock issue of PPP when send frame

From: Gao Feng PPP channel holds one spinlock before send frame. But the skb may select the same PPP channel with wrong route policy. As a result, the skb reaches the same channel path. It tries to get the same spinlock which is held before. Bang, the deadlock comes out. Now

Re: [PATCH net] sctp: fix a success return may hide an error

>> >> [1] >> Both sctp_outq_flush_rtx and sctp_packet_transmit can ONLY >> return one error (-ENOMEM), as sctp_outq_flush_rtx also calls >> sctp_packet_transmit. > > What is the effect of the error? > If it is 'just' equivalent to a lost ethernet packet (and the skb (etc) > is freed) then the

Re: [PATCH nf-next] netfilter: allow logging from non-init namespaces

On Mon, May 16, 2016 at 08:43:16AM +0200, Michal Kubecek wrote: > On Thu, May 12, 2016 at 11:57:26AM +0200, Pablo Neira Ayuso wrote: > > On Wed, Apr 27, 2016 at 02:48:02PM +0200, Michal Kubecek wrote: > > > Commit 69b34fb996b2 ("netfilter: xt_LOG: add net namespace support for > > > xt_LOG")

Re: [PATCH 1/1] ppp: Fix one deadlock issue of PPP when send frame

Hi Paul, The v1 patch does not handle the recursive lock case. It could cause unlock multiple times. So I send the v2 patch as one update. Best Regards Feng On Tue, Aug 16, 2016 at 7:05 PM, wrote: > From: Gao Feng > > PPP channel holds one spinlock before

Re: [PATCH net] bnx2x: don't reset chip on cleanup if PCI function is offline

On 08/10/2016 10:28 AM, Guilherme G. Piccoli wrote: On 08/10/2016 04:59 AM, Yuval Mintz wrote: Why would the published resume() from pci_error_handlers be called in this scenario? It isn't. That's why I specifically commented on commit message: "There are two cases though that another path

Re: [PATCH net] sctp: fix a success return may hide an error

On Tue, Aug 16, 2016 at 03:33:30PM -0300, Marcelo Ricardo Leitner wrote: > On Wed, Aug 17, 2016 at 02:24:19AM +0800, Xin Long wrote: > > >> > This err returns back to sctp_sendmsg, there sctp will abort asoc. > > > > > > That's not right I think. sctp_sendmsg will only free the asoc if it was > >

Re: kernel panic in qdisc_match_from_root starting openvswitch

On 8/16/16 1:51 PM, Jiri Kosina wrote: > On Tue, 16 Aug 2016, Jiri Kosina wrote: > >>> I am hitting a kernel panic with '/etc/init.d/openvswitch-switch >>> restart' Stack trace below. Reverting 59cc1f61f09c ("net: sched: convert >>> qdisc linked list to hashtable") clears the problem. >> >>

Re: [PATCH] [v7] net: emac: emac gigabit ethernet controller driver

Al Stone wrote: Does the ACPI portion of the driver*have* to know about the PHY? In general, the ACPI assumption on ARM [**] is that those have all been set up before we get to the kernel. So, does it need to be visible to the ACPI part of the driver at all? Yes, the driver supports both

[PATCH next-next 0/2] qdisc-hashtable fixes

The following two patches fix all the issues that have been reported against the conversion of qdisc linked list to hashtable (currently in net-next) so far. First patch adjusts handling of singleton qdiscs to the new semantics, and is rather straightforward. The second patch, which fixes

[PATCH 3/5] kobject: kset_create_and_add() - fetch ownership info from parent

This change implements get_ownership() for ksets created with kset_create_and_add() call by fetching ownership data from parent kobject. This is done mostly for benefit of "queues" attribute of net devices so that corresponding directory belongs to container's root instead of global root for

[PATCH 5/5] net-sysfs: make sure objects belong to contrainer's owner

When creating various objects in /sys/class/net/... make sure that they belong to container's owner instead of global root (if they belong to a container/namespace). Signed-off-by: Dmitry Torokhov --- net/core/net-sysfs.c | 44

[PATCH] net: thunderx: Fix OOPs with ethtool --register-dump

From: David Daney The ethtool_ops .get_regs function attempts to read the nonexistent register NIC_QSET_SQ_0_7_CNM_CHG, which produces a "bus error" type OOPs. Fix by not attempting to read, and removing the definition of, NIC_QSET_SQ_0_7_CNM_CHG. A zero is written into

[PATCH 2/2] net: sched: avoid duplicates in qdisc dump

From: Jiri Kosina tc_dump_qdisc() performs dumping of the per-device qdiscs in two phases; first, the "standard" dev->qdisc is being dumped. Second, if there is/are ingress queue(s), they are being dumped as well. After conversion of netdevice's qdisc linked-list into

[PATCH 2/5] sysfs, kobject: allow creating kobject belonging to arbitrary users

Normally kobjects and their sysfs representation belong to global root, however it is not necessarily the case for objects in separate namespaces. For example, objects in separate network namespace logically belong to the container's root and not global root. This change lays groundwork for

pls merge net to net-next

Since Vitaly's changes to hyperv drivers went into net it makes it harder to submit other changes for net-next since they will invariably cause conflicts.

Re: [PATCH 1/3] net: dt-bindings: Document the new Meson8b and GXBB DWMAC bindings

On Mon, Aug 15, 2016 at 06:40:58PM +0200, Martin Blumenstingl wrote: > This patch adds the documentation for the DWMAC ethernet controller > found in Amlogic Meson 8b (S805) and GXBB (S905) SoCs. > The main difference between the Meson6 glue is that different registers > (with different layout)

[PATCH iproute2 0/4] improve initialization of genl handle

This patchset fixes several issues for users of genetlink: - Duplicated code for initialization of a genl handle. All users of genl must open a socket and resolve the family, and use the same code to do that. Solution: add a library function. - genl family resolution fails when the

Re: [PATCH] net: sched: fix handling of singleton qdiscs with qdisc_hash

On Tue, 16 Aug 2016, Jiri Kosina wrote: > From: Jiri Kosina > > qdisc_match_from_root() is now iterating over per-netdevice qdisc > hashtable instead of going through a linked-list of qdiscs (independently > on the actual underlying netdev), which used to be the case before

[PULL] vhost: fixes for 4.8

The following changes since commit 3b2fbb3f06efe5bd2dfdce2a1db703e23c1a78af: virtio/s390: deprecate old transport (2016-08-09 13:42:41 +0300) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus for you to fetch changes up to

[PATCH iproute2 2/4] macsec: show usage even if the module is not available

Currently, the `ip macsec` command tries to initialize a genl context even when we just want to see the help for the command, which doesn't require to talk to the kernel at all. Delay genl initialization, which can fail if the module isn't loaded, until the point where we will actually need it.

[PATCH iproute2 4/4] ila: show usage even if the module is not available

Currently, the `ip ila` command tries to initialize a genl context even when we just want to see the help for the command, which doesn't require to talk to the kernel at all. Delay genl initialization, which can fail if the module isn't loaded, until the point where we will actually need it.

[PATCH iproute2 3/4] fou: show usage even if the module is not available

Currently, the `ip fou` command tries to initialize a genl context even when we just want to see the help for the command, which doesn't require to talk to the kernel at all. Delay genl initialization, which can fail if the module isn't loaded, until the point where we will actually need it.

[PATCH iproute2 1/4] libgenl: introduce genl_init_handle

All users of genl have the same code to open a genl socket and resolve the family for their specific protocol. Introduce a helper to intialize the handle, and use it in all the genl code. Signed-off-by: Sabrina Dubroca --- include/libgenl.h | 2 ++ ip/ipfou.c| 12

[PATCH] net: ipconfig: Fix more use after free

s still required. Move the call to ic_close_devs() to the very end of the function. Signed-off-by: Thierry Reding <tred...@nvidia.com> --- This applies on top of next-20160816. net/ipv4/ipconfig.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/net/ipv4/ipconfig.c

[lkp] [net/netpolicy] 19e7d15d66: EIP: [] netpolicy_unregister+0x23a/0x28a SS:ESP 0068:ceb19d94

FYI, we noticed the following commit: https://github.com/0day-ci/linux kan-liang-intel-com/net-introduce-NET-policy/20160805-034810 commit 19e7d15d66de8b17e3f2706b786fdc36932bbdbb ("net/netpolicy: limit the total record number") in testcase: boot on test machine: 2 threads qemu-system-i386

Re: Fw: Linux tcp_xmit_retransmit_queue use after free on 4.8-rc1 / master]

On Tue, 2016-08-16 at 13:19 -0700, Cong Wang wrote: > On Tue, Aug 16, 2016 at 11:39 AM, Eric Dumazet wrote: > > On Tue, 2016-08-16 at 08:39 -0700, Eric Dumazet wrote: > >> On Tue, 2016-08-16 at 12:45 +0200, Greg KH wrote: > >> > For some reason Marco's emails can't make it

Re: Fw: Linux tcp_xmit_retransmit_queue use after free on 4.8-rc1 / master]

On Tue, Aug 16, 2016 at 1:27 PM, Eric Dumazet wrote: > And tcp_add_write_queue_tail() looks like : > > > static inline void tcp_add_write_queue_tail(struct sock *sk, struct sk_buff > *skb) > { > __tcp_add_write_queue_tail(sk, skb); > > /* Queue it,

Re: [PATCH] [v7] net: emac: emac gigabit ethernet controller driver

On 08/16/2016 07:39 AM, Timur Tabi wrote: > Rob Herring wrote: > >>> In ACPI, the equivalent to a compatible string is the HID, which is QCOM8070 >>> for the EMAC. The problem is that it's very difficult, if not impossible, >>> to create new HIDs for different versions of the same device. >> >>

[PATCH 0/5] Make /sys/class/net per net namespace objects belong to container

There are objects in /sys hierarchy (/sys/class/net/) that logically belong to a namespace/container. Unfortunately all sysfs objects start their life belonging to global root, and while we could change ownership manually, keeping tracks of all objects that come and go is cumbersome. It would be

[PATCH 1/5] kernfs: allow creating kernfs objects with arbitrary uid/gid

This change allows creating kernfs files and directories with arbitrary uid/gid instead of always using GLOBAL_ROOT_UID/GID by extending kernfs_create_dir_ns() and kernfs_create_file_ns() with uid/gid arguments. The "simple" kernfs_create_file() and kernfs_create_dir() are left alone and always

[PATCH net] sctp: linearize early if it's not GSO

Because otherwise when crc computation is still needed it's way more expensive than on a linear buffer to the point that it affects performance. It's so expensive that netperf test gives a perf output as below: Overhead Shared ObjectSymbol 69,44% [kernel] [k]

[PATCH 4/5] driver core: set up ownership of class devices in sysfs

Plumb in get_ownership() callback for devices belonging to a class so that they can be created with uid/gid different from global root. This will allow network devices in a container to belong to container's root and not global root. Signed-off-by: Dmitry Torokhov ---

linux-next: manual merge of the net-next tree with the net tree

Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/dsa/mv88e6xxx/chip.c between commit: 601bbae0bc10 ("dsa: mv88e6xxx: hide unused functions") from the net tree and commit: 9c93829c014f ("net: dsa: mv88e6xxx: use the new PHY API") from the net-next

[net 2/6] e1000e: factor out systim sanitization

From: Jarod Wilson This is prepatory work for an expanding list of adapter families that have occasional ~10 hour clock jumps when being used for PTP. Factor out the sanitization function and convert to using a feature (bug) flag, per suggestion from Jesse Brandeburg.

[net 0/6][pull request] Intel Wired LAN Driver Updates 2016-08-16

This series contains fixes to e1000e, igb, ixgbe and i40e. Kshitiz Gupta provides a fix for igb to resolve the PHY delay compensation math in several functions. Jarod Wilson provides a fix for e1000e which had to broken up into 2 patches, first is prepares the driver for expanding the list of

Re: Fw: Linux tcp_xmit_retransmit_queue use after free on 4.8-rc1 / master]

On Tue, Aug 16, 2016 at 11:39 AM, Eric Dumazet wrote: > On Tue, 2016-08-16 at 08:39 -0700, Eric Dumazet wrote: >> On Tue, 2016-08-16 at 12:45 +0200, Greg KH wrote: >> > For some reason Marco's emails can't make it to netdev, so I'm >> > forwarding this on. Please cc: him

Re: Fw: Linux tcp_xmit_retransmit_queue use after free on 4.8-rc1 / master]

On Tue, 2016-08-16 at 13:27 -0700, Eric Dumazet wrote: > > Look at skb_entail() : It calls tcp_add_write_queue_tail() > > And tcp_add_write_queue_tail() looks like : > > > static inline void tcp_add_write_queue_tail(struct sock *sk, struct sk_buff > *skb) > { >

[net 6/6] i40e: check for and deal with non-contiguous TCs

From: Dave Ertman The i40e driver was causing a kernel panic when non-contiguous Traffic Classes, or Traffic Classes not starting with TC0, were configured on a link partner switch. i40e does not support non-contiguous TCs. To fix this, the patch changes the logic when

[net 5/6] ixgbe: Re-enable ability to toggle VLAN filtering

From: Alexander Duyck Back when I submitted the GSO code I messed up and dropped the support for disabling the VLAN tag filtering via the feature bit. This patch re-enables the use of the NETIF_F_HW_VLAN_CTAG_FILTER to enable/disable the VLAN filtering independent

[net 4/6] ixgbe: Force VLNCTRL.VFE to be set in all VMDq paths

From: Alexander Duyck When I was adding the code for enabling VLAN promiscuous mode with SR-IOV enabled I had inadvertently left the VLNCTRL.VFE bit unchanged as I has assumed there was code in another path that was setting it when we enabled SR-IOV. This wasn't the

[net 3/6] e1000e: fix PTP on e1000_pch_lpt variants

From: Jarod Wilson I've got reports that the Intel I-218V NIC in Intel NUC5i5RYH systems used as a PTP slave experiences random ~10 hour clock jumps, which are resolved if the same workaround for the 82574 and 82583 is employed, so set the appropriate flag2 in

[net 1/6] igb: fix adjusting PTP timestamps for Tx/Rx latency

From: Kshitiz Gupta Fix PHY delay compensation math in igb_ptp_tx_hwtstamp() and igb_ptp_rx_rgtstamp. Add PHY delay compensation in igb_ptp_rx_pktstamp(). In the IGB driver, there are two functions that retrieve timestamps received by the PHY - igb_ptp_rx_rgtstamp() and

[PATCH 1/2] net: sched: fix handling of singleton qdiscs with qdisc_hash

From: Jiri Kosina qdisc_match_from_root() is now iterating over per-netdevice qdisc hashtable instead of going through a linked-list of qdiscs (independently on the actual underlying netdev), which was the case before the switch to hashtable for qdiscs. For singleton qdiscs,

Re: [PATCH net] sctp: linearize early if it's not GSO

On 08/17/2016 12:35 AM, Marcelo Ricardo Leitner wrote: Because otherwise when crc computation is still needed it's way more expensive than on a linear buffer to the point that it affects performance. It's so expensive that netperf test gives a perf output as below: Overhead Shared Object

Re: [PATCH net] sctp: linearize early if it's not GSO

On Wed, Aug 17, 2016 at 12:59:17AM +0200, Daniel Borkmann wrote: > On 08/17/2016 12:35 AM, Marcelo Ricardo Leitner wrote: > > Because otherwise when crc computation is still needed it's way more > > expensive than on a linear buffer to the point that it affects > > performance. > > > > It's so

Re: [PATCH 2/5] net: add bind/listen ranges to net cgroup

On Mon, Aug 15, 2016 at 12:05:40PM -0700, Mahesh Bandewar wrote: > On Fri, Aug 12, 2016 at 9:29 PM, Alexei Starovoitov > wrote: > [...] > >> +static bool range_in_ranges(struct net_range *r, struct net_ranges *rs) > >> +{ > >> + int ri; > >> + > >> + for (ri

Re: DSA + Marvell embedded switch question

On Tue, Aug 16, 2016 at 2:17 PM, Andrew Lunn wrote: > On Mon, Aug 15, 2016 at 08:17:24PM -0400, John Fleming wrote: >> Hi all, I have a embedded appliance I bought from a vendor and i'm >> being told to file a RFE for this. >> >> The issue i have is the device has a embedded

Re: [PATCH v2] Bluetooth: Add LED triggers for HCI frames tx and rx

On 16 August 2016 at 20:33, Marcel Holtmann wrote: > > Hi Guodong, > > >>> Two LED triggers are added into hci_dev: tx_led and rx_led. Upon ACL/SCO > >>> packets available in tx or rx, the LEDs will blink. > >>> > >>> For each hci registration, two triggers are added into LED

Re: [PATCH iproute2] ip route: restore_handler should check tb[RTA_PREFSRC] for local networks

Hi, Stephen any update on this ?

[PATCH] mwifiex: fix missing break on IEEE80211_STYPE_ACTION case

From: Colin Ian King The IEEE80211_STYPE_ACTION case is missing a break in the switch statement, causing it to fall through to the default case that reports a debug message about an unknown frame subtype. Fix this by adding in the missing break statement.

Re: [PATCH v2] Bluetooth: Add LED triggers for HCI frames tx and rx

Hi Guodong, >>> Two LED triggers are added into hci_dev: tx_led and rx_led. Upon ACL/SCO >>> packets available in tx or rx, the LEDs will blink. >>> >>> For each hci registration, two triggers are added into LED subsystem: >>> [hdev->name]-tx and [hdev-name]-rx. >>> Refer to

Re: [PATCH] net: phy: Update copyright info

On Tue, Aug 16, 2016 at 11:58:29AM +0530, Kedareswara rao Appana wrote: > For implementing this driver most of the inputs is > provided by Andrew Lunn. > > Updating the driver with Andrew Copy right. > > Signed-off-by: Kedareswara rao Appana O.K, so this is a start in

[PATCH 2/2] ipv6: fixup RTF_* flags when restoring RTPROT_RA route from rtnetlink

Fix the flags for RA-derived routes that were saved via "ip -6 route save" and and subsequently restored via "ip -6 route restore", allowing the incoming router advertisements to update them, rather than complain about inability to do so. Upon the restore of RA-derived saved routes, set the

  1   2   >