[PATCH v4 6/6] samples: bpf: add userspace example for attaching eBPF programs to cgroups

2016-09-06 Thread Daniel Mack
Add a simple userpace program to demonstrate the new API to attach eBPF programs to cgroups. This is what it does: * Create arraymap in kernel with 4 byte keys and 8 byte values * Load eBPF program The eBPF program accesses the map passed in to store two pieces of information. The

[PATCH v4 0/6] Add eBPF hooks for cgroups

2016-09-06 Thread Daniel Mack
This is v4 of the patch set to allow eBPF programs for network filtering and accounting to be attached to cgroups, so that they apply to all sockets of all tasks placed in that cgroup. The logic also allows to be extendeded for other cgroup based eBPF logic. All the comments I got since v3 were

Re: [PATCH v5 nf] netfilter: seqadj: Drop the packet directly when fail to add seqadj extension to avoid dereference NULL pointer later

2016-09-06 Thread Gao Feng
inline On Tue, Sep 6, 2016 at 10:51 PM, Florian Westphal wrote: > f...@ikuai8.com wrote: >> From: Gao Feng >> >> When memory is exhausted, nfct_seqadj_ext_add may fail to add the seqadj >> extension. But the function nf_ct_seqadj_init doesn't

Re: [PATCH, net-next] perf, bpf: fix conditional call to bpf_overflow_handler

2016-09-06 Thread Alexei Starovoitov
On Tue, Sep 06, 2016 at 03:10:22PM +0200, Arnd Bergmann wrote: > The newly added bpf_overflow_handler function is only built of both > CONFIG_EVENT_TRACING and CONFIG_BPF_SYSCALL are enabled, but the caller > only checks the latter: > > kernel/events/core.c: In function 'perf_event_alloc': >

Re: [patch net-next RFC 1/2] fib: introduce fib notification infrastructure

2016-09-06 Thread David Ahern
On 9/6/16 6:01 AM, Jiri Pirko wrote: > From: Jiri Pirko > > This allows to pass information about added/deleted fib entries to > whoever is interested. This is done in a very similar way as devinet > notifies address additions/removals. > > Signed-off-by: Jiri Pirko

Re: [RFC Patch net-next 5/6] net_sched: use rcu in fast path

2016-09-06 Thread Eric Dumazet
On Thu, 2016-09-01 at 22:57 -0700, Cong Wang wrote: Missing changelog ? Here I have no idea what you want to fix, since John already took care all this infra. Adding extra rcu_dereference() and rcu_read_lock() while the critical RCU dereferences already happen in callers is not needed. >

Re: [PATCH] bonding: Prevent deletion of a bond, or the last slave from a bond, with active usage.

2016-09-06 Thread Jay Vosburgh
Kaur, Jasminder wrote: >From: "Kaur, Jasminder" > >If a bond is in use such as with IP address configured, removing it >can result in application disruptions. If bond is used for cluster >communication or network file system interfaces, removing

Re: [patch net-next RFC 1/2] fib: introduce fib notification infrastructure

2016-09-06 Thread David Ahern
On 9/6/16 6:01 AM, Jiri Pirko wrote: > From: Jiri Pirko > > This allows to pass information about added/deleted fib entries to > whoever is interested. This is done in a very similar way as devinet > notifies address additions/removals. > > Signed-off-by: Jiri Pirko

[PATCH v4 5/6] net: core: run cgroup eBPF egress programs

2016-09-06 Thread Daniel Mack
If the cgroup associated with the receiving socket has an eBPF programs installed, run them from __dev_queue_xmit(). eBPF programs used in this context are expected to either return 1 to let the packet pass, or != 1 to drop them. The programs have access to the full skb, including the MAC

[PATCH] ptp: ixp46x: remove NO_IRQ handling

2016-09-06 Thread Arnd Bergmann
gpio_to_irq does not return NO_IRQ but instead returns a negative error code on failure. Returning NO_IRQ from the function has no negative effects as we only compare the result to the expected interrupt number, but it's better to return a proper failure code for consistency, and we should remove

[PATCH v4 2/6] cgroup: add support for eBPF programs

2016-09-06 Thread Daniel Mack
This patch adds two sets of eBPF program pointers to struct cgroup. One for such that are directly pinned to a cgroup, and one for such that are effective for it. To illustrate the logic behind that, assume the following example cgroup hierarchy. A - B - C \ D - E If only B has a

[PATCH v4 3/6] bpf: add BPF_PROG_ATTACH and BPF_PROG_DETACH commands

2016-09-06 Thread Daniel Mack
Extend the bpf(2) syscall by two new commands, BPF_PROG_ATTACH and BPF_PROG_DETACH which allow attaching and detaching eBPF programs to a target. On the API level, the target could be anything that has an fd in userspace, hence the name of the field in union bpf_attr is called 'target_fd'. When

Re: [PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

2016-09-06 Thread Jamal Hadi Salim
On 16-09-06 09:37 AM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim This action is intended to be an upgrade from a usability perspective from pedit (as well as operational debugability). Compare this: Dave, I will have to send some new version of this action - so please

Re: [PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

2016-09-06 Thread Eric Dumazet
On Tue, 2016-09-06 at 09:37 -0400, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > + > +struct tcf_skbmod_params { > + struct rcu_head rcu; > + u64 flags; /*up to 64 types of operations; extend if needed */ > + u8 eth_dst[ETH_ALEN]; > + u16

Re: [PATCH] ptp: ixp46x: remove NO_IRQ handling

2016-09-06 Thread Richard Cochran
On Tue, Sep 06, 2016 at 04:28:30PM +0200, Arnd Bergmann wrote: > gpio_to_irq does not return NO_IRQ but instead returns a negative > error code on failure. Returning NO_IRQ from the function has no > negative effects as we only compare the result to the expected > interrupt number, but it's better

Re: [RFC PATCH 2/2] macb: Enable 1588 support in SAMA5D2 platform.

2016-09-06 Thread Richard Cochran
On Fri, Sep 02, 2016 at 02:53:37PM +0200, Andrei Pistirica wrote: > Hardware time stamp on the PTP Ethernet packets are received using the > SO_TIMESTAMPING API. Timers are obtained from the PTP event/peer > gem registers. > > Signed-off-by: Andrei Pistirica > ---

Re: [PATCH net-next V2 6/6] net/mlx5: Add handling for port module event

2016-09-06 Thread Joe Perches
On Tue, 2016-09-06 at 19:04 +0300, Saeed Mahameed wrote: > From: Huy Nguyen [] > +void mlx5_port_module_event(struct mlx5_core_dev *dev, struct mlx5_eqe *eqe) > +{ > > + struct mlx5_eqe_port_module *module_event_eqe; > > + u8 module_status; > > + u8 module_num; > > +

Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg

2016-09-06 Thread Grant Grundler
On Thu, Sep 1, 2016 at 10:02 AM, Eric Dumazet wrote: > On Thu, 2016-09-01 at 12:47 -0400, Robert Foss wrote: > >> I'm not quite sure how the first From line was added, it >> should not have been. >> Grant Grundler is most definitely the author. >> >> Would you like me to

[PATCH net-next V2 3/6] net/mlx5e: Read ETS settings directly from firmware

2016-09-06 Thread Saeed Mahameed
From: Huy Nguyen Issue description: Current implementation saves the ETS settings from user in a temporal soft copy and returns this settings when user queries the ETS settings. With the new DCBX firmware, the ETS settings can be changed by firmware when the DCBX is in

Re: [patch net-next v7 1/3] netdevice: Add offload statistics ndo

2016-09-06 Thread Jiri Pirko
Tue, Sep 06, 2016 at 05:08:25PM CEST, ro...@cumulusnetworks.com wrote: >On 9/5/16, 10:18 AM, Jiri Pirko wrote: >> From: Nogah Frankel >> >> Add a new ndo to return statistics for offloaded operation. >> Since there can be many different offloaded operation with many >> stats

[PATCH net-next V2 1/6] net/mlx5e: Add qos capability check

2016-09-06 Thread Saeed Mahameed
From: Huy Nguyen Make sure firmware supports qos before exposing the dcb api. Signed-off-by: Huy Nguyen Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PATCH net-next V2 2/6] net/mlx5e: Support DCBX CEE API

2016-09-06 Thread Saeed Mahameed
From: Huy Nguyen Add DCBX CEE API interface for ConnectX-4. Configurations are stored in a temporary structure and are applied to the card's firmware when the CEE's setall callback function is called. Note: priority group in CEE is equivalent to traffic class in ConnectX-4

[PATCH net-next V2 0/6] Mellanox 100G mlx5 DCBX CEE and firmware support

2016-09-06 Thread Saeed Mahameed
Hi Dave, This series from Huy provides mlx5 DCBX updates to support DCBX CEE API and DCBX firmware/host modes support. 1st patch ensures the dcbnl_rtnl_ops is published only when the qos capability bits is on. 2nd patch adds the support for CEE interfaces into mlx5 dcbnl_rtnl_ops. 3rd patch

[PATCH net-next V2 4/6] net/mlx5: Add DCBX firmware commands support

2016-09-06 Thread Saeed Mahameed
From: Huy Nguyen Add set/query commands for DCBX_PARAM register Signed-off-by: Huy Nguyen Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/port.c | 20 include/linux/mlx5/driver.h

[PATCH net-next V2 5/6] net/mlx5e: ConnectX-4 firmware support for DCBX

2016-09-06 Thread Saeed Mahameed
From: Huy Nguyen DBCX by default is controlled by firmware. In this mode, firmware is responsible for reading/sending the TLVs packets from/to the remote partner. When the driver is loaded, the driver can leave the DCBX in firmware controlled mode or switch the DCBX back to

[PATCH net-next V2 6/6] net/mlx5: Add handling for port module event

2016-09-06 Thread Saeed Mahameed
From: Huy Nguyen Add dmesg log for asynchronous port module event. Signed-off-by: Huy Nguyen Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/eq.c | 12 +++

Re: PROBLEM: TPROXY and DNAT broken (bisected to 079096f103fa)

2016-09-06 Thread Brandon Cazander
Sorry to resurrect this so much later—I just got back from holidays and this was still on my desk. Will anyone have another chance to look at this? It appears that the DIVERT rule is not working in our case, and I wonder if it is possible to fix the TPROXY target as well as the socket target

Re: [PATCH net-next 1/3] smsc95xx: Add maintainer

2016-09-06 Thread Steve Glendinning
On 2 September 2016 at 21:34, wrote: > From: Woojung Huh > > Add Microchip Linux Driver Support as maintainer > because this driver is maintaining by Microchip. > > Signed-off-by: Woojung Huh > --- Acked-by: Steve

Re: [patch net-next RFC 1/2] fib: introduce fib notification infrastructure

2016-09-06 Thread Jiri Pirko
Tue, Sep 06, 2016 at 05:11:11PM CEST, d...@cumulusnetworks.com wrote: >On 9/6/16 8:44 AM, Jiri Pirko wrote: >> Tue, Sep 06, 2016 at 04:32:12PM CEST, d...@cumulusnetworks.com wrote: >>> On 9/6/16 6:01 AM, Jiri Pirko wrote: From: Jiri Pirko This allows to pass

Re: [RFC PATCH 1/2] macb: Add 1588 support in Cadence GEM.

2016-09-06 Thread Richard Cochran
I have some issues with this patch... On Fri, Sep 02, 2016 at 02:53:36PM +0200, Andrei Pistirica wrote: > - Frequency adjustment is not directly supported by this IP. > addend is the initial value ns increment and similarly addendesub. > The ppb (parts per billion) provided is used as >

Re: [PATCH v3 5/6] net: core: run cgroup eBPF egress programs

2016-09-06 Thread Daniel Borkmann
On 09/05/2016 04:22 PM, Daniel Mack wrote: On 08/30/2016 12:03 AM, Daniel Borkmann wrote: On 08/26/2016 09:58 PM, Daniel Mack wrote: diff --git a/net/core/dev.c b/net/core/dev.c index a75df86..17484e6 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -141,6 +141,7 @@ #include

Re: [patch net-next RFC 1/2] fib: introduce fib notification infrastructure

2016-09-06 Thread Hannes Frederic Sowa
On Tue, Sep 6, 2016, at 17:49, Jiri Pirko wrote: > Tue, Sep 06, 2016 at 05:11:11PM CEST, d...@cumulusnetworks.com wrote: > >On 9/6/16 8:44 AM, Jiri Pirko wrote: > >> Tue, Sep 06, 2016 at 04:32:12PM CEST, d...@cumulusnetworks.com wrote: > >>> On 9/6/16 6:01 AM, Jiri Pirko wrote: > From: Jiri

Re: [PATCH v4 2/6] cgroup: add support for eBPF programs

2016-09-06 Thread Daniel Borkmann
On 09/06/2016 03:46 PM, Daniel Mack wrote: This patch adds two sets of eBPF program pointers to struct cgroup. One for such that are directly pinned to a cgroup, and one for such that are effective for it. To illustrate the logic behind that, assume the following example cgroup hierarchy. A

[PATCH net-next] sfc: check MTU against minimum threshold

2016-09-06 Thread Bert Kenward
Reported-by: Ma Yuying Suggested-by: Jarod Wilson Signed-off-by: Bert Kenward --- drivers/net/ethernet/sfc/efx.c| 12 +++- drivers/net/ethernet/sfc/net_driver.h | 3 +++ 2 files changed, 14 insertions(+), 1

[PATCH net-next] netlink: don't forget to release a rhashtable_iter structure

2016-09-06 Thread Andrei Vagin
This bug was detected by kmemleak: unreferenced object 0x8804269cc3c0 (size 64): comm "criu", pid 1042, jiffies 4294907360 (age 13.713s) hex dump (first 32 bytes): a0 32 cc 2c 04 88 ff ff 00 00 00 00 00 00 00 00 .2., 00 01 00 00 00 00 ad de 00 02 00 00 00 00 ad de

Re: [RFC PATCH kernel] PCI: Enable access to custom VPD for Chelsio devices (cxgb3)

2016-09-06 Thread Alexander Duyck
On Tue, Sep 6, 2016 at 8:48 AM, Bjorn Helgaas wrote: > Hi Alexey, > > On Thu, Aug 11, 2016 at 08:03:29PM +1000, Alexey Kardashevskiy wrote: >> There is at least one Chelsio 10Gb card which uses VPD area to store >> some custom blocks (example below). However pci_vpd_size()

Re: ipv6: release dst in ping_v6_sendmsg

2016-09-06 Thread Eric Dumazet
On Tue, 2016-09-06 at 10:36 -0700, Martin KaFai Lau wrote: > On Fri, Sep 02, 2016 at 02:39:50PM -0400, Dave Jones wrote: > > Neither the failure or success paths of ping_v6_sendmsg release > > the dst it acquires. This leads to a flood of warnings from > > "net/core/dst.c:288 dst_release" on

Re: ipv6: release dst in ping_v6_sendmsg

2016-09-06 Thread Dave Jones
On Tue, Sep 06, 2016 at 10:52:43AM -0700, Eric Dumazet wrote: > > > @@ -126,8 +126,10 @@ static int ping_v6_sendmsg(struct sock *sk, struct > > > msghdr *msg, size_t len) > > > rt = (struct rt6_info *) dst; > > > > > > np = inet6_sk(sk); > > > -if (!np) > > > -

Re: ipv6: release dst in ping_v6_sendmsg

2016-09-06 Thread Martin KaFai Lau
On Fri, Sep 02, 2016 at 02:39:50PM -0400, Dave Jones wrote: > Neither the failure or success paths of ping_v6_sendmsg release > the dst it acquires. This leads to a flood of warnings from > "net/core/dst.c:288 dst_release" on older kernels that > don't have

XPS configuration question (on tg3)

2016-09-06 Thread Michal Soltys
Hi, I've been testing different configurations and I didn't manage to get XPS to "behave" correctly - so I'm probably misunderstanding or forgetting something. The nic in question (under tg3 driver - BCM5720 and BCM5719 models) was configured to 3 tx and 4 rx queues. 3 irqs were shared (tx and

Re: [RFC PATCH kernel] PCI: Enable access to custom VPD for Chelsio devices (cxgb3)

2016-09-06 Thread Bjorn Helgaas
Hi Alexey, On Thu, Aug 11, 2016 at 08:03:29PM +1000, Alexey Kardashevskiy wrote: > There is at least one Chelsio 10Gb card which uses VPD area to store > some custom blocks (example below). However pci_vpd_size() returns > the length of the first block only assuming that there can be only > one

Re: [PATCH net-next V2 3/6] net/mlx5e: Read ETS settings directly from firmware

2016-09-06 Thread Or Gerlitz
On Tue, Sep 6, 2016 at 7:04 PM, Saeed Mahameed wrote: > From: Huy Nguyen > > Issue description: > Current implementation saves the ETS settings from user in > a temporal soft copy and returns this settings when user > queries the ETS settings. > > With the

Re: XPS configuration question (on tg3)

2016-09-06 Thread Alexander Duyck
On Tue, Sep 6, 2016 at 11:46 AM, Michal Soltys wrote: > Hi, > > I've been testing different configurations and I didn't manage to get XPS to > "behave" correctly - so I'm probably misunderstanding or forgetting > something. The nic in question (under tg3 driver - BCM5720 and

[PATCH v2] ptp: ixp46x: remove NO_IRQ handling

2016-09-06 Thread Arnd Bergmann
gpio_to_irq does not return NO_IRQ but instead returns a negative error code on failure. Returning NO_IRQ from the function has no negative effects as we only compare the result to the expected interrupt number, but it's better to return a proper failure code for consistency, and we should remove

Re: ipv6: release dst in ping_v6_sendmsg

2016-09-06 Thread David Miller
From: Dave Jones Date: Fri, 2 Sep 2016 14:39:50 -0400 > Neither the failure or success paths of ping_v6_sendmsg release > the dst it acquires. This leads to a flood of warnings from > "net/core/dst.c:288 dst_release" on older kernels that > don't have

Re: [PATCH net-next v2 0/3] net: dsa: mv88e6xxx: isolate Global2 support

2016-09-06 Thread David Miller
From: Vivien Didelot Date: Fri, 2 Sep 2016 14:45:31 -0400 > Registers of Marvell chips are organized in internal SMI devices. > > One of them at address 0x1C is called Global2. It provides an extended > set of registers, used for interrupt control, EEPROM

RE

2016-09-06 Thread Easy Loan
Are you need of Loan offer? We here to meet your need Contact us Jim Elssin --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

Re: [PATCH v3 5/5] net: asix: autoneg will set WRITE_MEDIUM reg

2016-09-06 Thread Robert Foss
On 2016-09-06 12:41 PM, Grant Grundler wrote: On Thu, Sep 1, 2016 at 10:02 AM, Eric Dumazet wrote: On Thu, 2016-09-01 at 12:47 -0400, Robert Foss wrote: I'm not quite sure how the first From line was added, it should not have been. Grant Grundler is most definitely

vlan aware bridge doesn't propagate mac changes to vlans on top of it

2016-09-06 Thread Michal Soltys
Consider following scenario: - create vlan aware bridge (say br0) - setup br0's vlans, e.g. bridge vlan add dev br0 vid 10 self This will add necessary fdb entries directing appropriate traffic to the bridge itself. - create appropriate vlan interfaces on top of it, for example: ip li add

[PATCH v4 4/4] wcn36xx: Implement print_reg indication

2016-09-06 Thread Bjorn Andersson
Some firmware versions sends a "print register indication", handle this by printing out the content. Cc: Nicolas Dechesne Signed-off-by: Bjorn Andersson --- Changes since v3: - Rebased separate patch onto this series

[PATCH v4 2/4] wcn36xx: Transition driver to SMD client

2016-09-06 Thread Bjorn Andersson
The wcn36xx wifi driver follows the life cycle of the WLAN_CTRL SMD channel, as such it should be a SMD client. This patch makes this transition, now that we have the necessary frameworks available. Signed-off-by: Bjorn Andersson --- Changes since v3: - Made

[PATCH v4 3/4] wcn36xx: Implement firmware assisted scan

2016-09-06 Thread Bjorn Andersson
Using the software based channel scan mechanism from mac80211 keeps us offline for 10-15 second, we should instead issue a start_scan/end_scan on each channel reducing this time. Signed-off-by: Bjorn Andersson --- Changes since v3: - None Changes since v2: - Match

[PATCH v4 1/4] soc: qcom: wcnss_ctrl: Stub wcnss_ctrl API

2016-09-06 Thread Bjorn Andersson
Stub the wcnss_ctrl API to allow compile testing wcnss function drivers. Cc: Marcel Holtmann Signed-off-by: Bjorn Andersson --- There are no other pending changes colliding with this, so if Andy is okay with this it could be merged through

Re: [PATCH net-next v5 0/2] net: ethernet: mediatek: add enhancements to RX path

2016-09-06 Thread David Miller
From: Date: Sat, 3 Sep 2016 17:59:25 +0800 > Changes since v1: > - fix message typos and add coverletter > > Changes since v2: > - split from the previous series for submitting add enhancements as > a series targeting 'net-next' and add indents before comments. > >

Re: [PATCH v2] net: smsc: remove build warning of duplicate definition

2016-09-06 Thread David Miller
From: Sudip Mukherjee Date: Sun, 4 Sep 2016 23:02:21 +0530 > The build of m32r was giving warning: > > In file included from drivers/net/ethernet/smsc/smc91x.c:92:0: > drivers/net/ethernet/smsc/smc91x.h:448:0: warning: "SMC_inb" redefined > #define SMC_inb(ioaddr,

Re: [PATCH net-next 0/9] rxrpc: Small fixes

2016-09-06 Thread David Miller
From: David Howells Date: Sun, 04 Sep 2016 22:02:24 +0100 > > Here's a set of small fix patches: > > (1) Fix some uninitialised variables. > > (2) Set the client call state before making it live by attaching it to the > conn struct. > > (3) Randomise the epoch

Re: [PATCH] tcp: cwnd does not increase in TCP YeAH

2016-09-06 Thread David Miller
From: Artem Germanov Date: Sun, 4 Sep 2016 21:03:27 -0700 > Commit 76174004a0f19785a328f40388e87e982bbf69b9 > (tcp: do not slow start when cwnd equals ssthresh ) > introduced regression in TCP YeAH. Using 100ms delay 1% loss virtual > ethernet link kernel 4.2 shows

Re: [PATCH v2] net: Don't delete routes in different VRFs

2016-09-06 Thread David Miller
From: Mark Tomlinson Date: Mon, 5 Sep 2016 10:20:20 +1200 > When deleting an IP address from an interface, there is a clean-up of > routes which refer to this local address. However, there was no check to > see that the VRF matched. This meant that deletion

Re: [PATCH net-next 0/3] qed*: Debug data collection

2016-09-06 Thread David Miller
From: Tomer Tayar Date: Mon, 5 Sep 2016 14:35:09 +0300 > This patch series adds the support of debug data collection in the qed driver, > and the means to extract it in the qede driver via the get_regs operation. ... > Please consider applying this to 'net-next'. There

[PATCH v5 1/6] net: dt-bindings: Document the new Meson8b and GXBB DWMAC bindings

2016-09-06 Thread Martin Blumenstingl
This patch adds the documentation for the DWMAC ethernet controller found in Amlogic Meson 8b (S805) and GXBB (S905) SoCs. The main difference between the Meson6 glue is that different registers (with different layout) are used. Signed-off-by: Martin Blumenstingl

[PATCH v5 4/6] net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC

2016-09-06 Thread Martin Blumenstingl
The Ethernet controller available in Meson8b and GXBB SoCs is a Synopsys DesignWare MAC IP core which is already supported by the stmmac driver. In addition to the standard stmmac driver some Meson8b / GXBB specific registers have to be configured for the PHY clocks. These SoC specific registers

[PATCH v5 3/6] stmmac: introduce get_stmmac_bsp_priv() helper

2016-09-06 Thread Martin Blumenstingl
From: Joachim Eastwood Create a helper to retrieve dwmac private data from a dev pointer. This is useful in PM callbacks and driver remove. Signed-off-by: Joachim Eastwood Tested-by: Martin Blumenstingl Acked-by:

[PATCH v5 0/6] meson: Meson8b and GXBB DWMAC glue driver

2016-09-06 Thread Martin Blumenstingl
This adds a DWMAC glue driver for the PRG_ETHERNET registers found in Meson8b and GXBB SoCs. Based on the "old" meson6b-dwmac glue driver the register layout is completely different. Thus I introduced a separate driver. Changes since v4: - DWMAC_MESON now depends on COMMON_CLK because the new

[PATCH v5 5/6] ARM64: dts: meson-gxbb: use the new GXBB DWMAC glue driver

2016-09-06 Thread Martin Blumenstingl
The Amlogic reference driver uses the "mc_val" devicetree property to configure the PRG_ETHERNET_ADDR0 register. Unfortunately it uses magic values for this configuration. According to the datasheet the PRG_ETHERNET_ADDR0 register is at address 0xc8834108. However, the reference driver uses

Re: [PATCH] vmxnet3: mark vmxnet3_rq_destroy_all_rxdataring() static

2016-09-06 Thread Arnd Bergmann
On Tuesday, September 6, 2016 4:11:59 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/net/vmxnet3/vmxnet3_drv.c:1643:1: warning: no previous prototype for > 'vmxnet3_rq_destroy_all_rxdataring' [-Wmissing-prototypes] > > In fact, this function is only used in

[PATCH] bonding: Prevent deletion of a bond, or the last slave from a bond, with active usage.

2016-09-06 Thread Kaur, Jasminder
From: "Kaur, Jasminder" If a bond is in use such as with IP address configured, removing it can result in application disruptions. If bond is used for cluster communication or network file system interfaces, removing it can cause system down time. An additional write

Re: [PATCH v4 4/5] net: stmmac: add a glue driver for the Amlogic Meson 8b / GXBB DWMAC

2016-09-06 Thread Arnd Bergmann
On Monday, September 5, 2016 9:07:03 PM CEST Martin Blumenstingl wrote: > On Mon, Sep 5, 2016 at 12:53 PM, Arnd Bergmann wrote: > > On Monday, September 5, 2016 9:37:29 AM CEST kbuild test robot wrote: > >> All error/warnings (new ones prefixed by >>): > >> > >> >>

Re: [PATCH iproute2] ip route: check ftell, fseek return value

2016-09-06 Thread Phil Sutter
On Tue, Sep 06, 2016 at 02:39:50PM +0800, Hangbin Liu wrote: > ftell() may return -1 in error case, which is not handled and therefore pass a > negative offset to fseek(). The return code of fseek() is also not checked. > > Reported-by: Phil Sutter > Signed-off-by: Hangbin Liu

Re: [PATCH v4 nf] netfilter: seqadj: Drop the packet directly when fail to add seqadj extension to avoid dereference NULL pointer later

2016-09-06 Thread Pablo Neira Ayuso
On Tue, Sep 06, 2016 at 09:57:23AM +0800, f...@ikuai8.com wrote: > From: Gao Feng > > When memory is exhausted, nfct_seqadj_ext_add may fail to add the seqadj > extension. But the function nf_ct_seqadj_init doesn't check if get valid > seqadj pointer by the nfct_seqadj. > > Now

Re: [PATCH net-next] netlink: don't forget to release a rhashtable_iter structure

2016-09-06 Thread David Miller
From: Andrei Vagin Date: Tue, 6 Sep 2016 11:23:39 -0700 > This bug was detected by kmemleak: > unreferenced object 0x8804269cc3c0 (size 64): > comm "criu", pid 1042, jiffies 4294907360 (age 13.713s) > hex dump (first 32 bytes): > a0 32 cc 2c 04 88 ff ff 00 00 00

Re: vlan aware bridge doesn't propagate mac changes to vlans on top of it

2016-09-06 Thread Toshiaki Makita
On 2016/09/07 6:59, Michal Soltys wrote: > Consider following scenario: > > - create vlan aware bridge (say br0) > - setup br0's vlans, e.g. > > bridge vlan add dev br0 vid 10 self > > This will add necessary fdb entries directing appropriate traffic to the > bridge itself. > > - create

Re: [PATCH 0/2] lan78xx: Remove trailing underscores from macros

2016-09-06 Thread Joe Perches
On Tue, 2016-09-06 at 23:19 +, woojung@microchip.com wrote: > > Joe Perches (2): > >   lan78xx: Remove locally defined trailing underscores from defines and uses > >   microchipphy.h and uses: Remove trailing underscores from defines and > > uses > > > >  drivers/net/phy/microchip.c |

[PATCH net-next 2/2] tcp: put a TLV list of TCP stats in error queue

2016-09-06 Thread Francis Y. Yan
To export useful TCP statistics along with timestamps, such as rwnd-limited time and min RTT, we enqueue a TLV list in error queue immediately when a timestamp is generated. Specifically, if user space requests SOF_TIMESTAMPING_TX_* timestamps and sets SOF_TIMESTAMPING_OPT_STATS, the kernel will

[PATCH net-next 1/2] tcp: measure rwnd-limited time

2016-09-06 Thread Francis Y. Yan
This patch measures the total time when TCP transmission is limited by receiver's advertised window (rwnd), and exports it in tcp_info as tcpi_rwnd_limited. The rwnd-limited time is defined as the period when the next segment to send by TCP cannot fit into rwnd. To measure it, we record the last

Re: [PATCH v4 1/4] soc: qcom: wcnss_ctrl: Stub wcnss_ctrl API

2016-09-06 Thread Andy Gross
On Tue, Sep 06, 2016 at 03:18:29PM -0700, Bjorn Andersson wrote: > Stub the wcnss_ctrl API to allow compile testing wcnss function drivers. > > Cc: Marcel Holtmann > Signed-off-by: Bjorn Andersson > --- > > There are no other pending changes

Re: [PATCH] net: hns: declare function as static

2016-09-06 Thread Kefeng Wang
On 2016/9/7 7:20, David Miller wrote: > From: Kefeng Wang > Date: Tue, 6 Sep 2016 19:53:11 +0800 > >> Declare function as static to kill warning about missing-prototypes. >> >> Cc: Yisen Zhuang >> Cc: Kejian Yan >>

RE: [PATCH 0/2] lan78xx: Remove trailing underscores from macros

2016-09-06 Thread Ronnie.Kunin
Microchip's internal convention is for register (offset) definitions to be capitalized (i.e.: MY_REGISTER). Our convention for bits (position) definitions within a register is to carry as a prefix the name of the register and suffix it with the bit name and adding a trailing underscore (i.e.

[PATCH net-next] MAINTAINERS: Update CPMAC email address

2016-09-06 Thread Florian Fainelli
Signed-off-by: Florian Fainelli --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9a1783547baf..5ec858e61ddb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3277,7 +3277,7 @@ S:Maintained F:

Re: [net:master 29/33] drivers/net/ethernet/cadence/macb.c:1385:2-8: preceding lock on line 1372

2016-09-06 Thread Julia Lawall
The lock acquired on line 1372 is still held when leaving the function at line 1385. Is this intentional? thanks, julia Le 07.09.2016 11:11, kbuild test robot a écrit : CC: kbuild-...@01.org CC: netdev@vger.kernel.org TO: Helmut Buchsbaum tree:

[PATCH net-next v2] netlink: don't forget to release a rhashtable_iter structure

2016-09-06 Thread Andrei Vagin
This bug was detected by kmemleak: unreferenced object 0x8804269cc3c0 (size 64): comm "criu", pid 1042, jiffies 4294907360 (age 13.713s) hex dump (first 32 bytes): a0 32 cc 2c 04 88 ff ff 00 00 00 00 00 00 00 00 .2., 00 01 00 00 00 00 ad de 00 02 00 00 00 00 ad de

Re: [PATCH v4 2/6] cgroup: add support for eBPF programs

2016-09-06 Thread Rami Rosen
Hi, + * __cgroup_bpf_update() - Update the pinned program of a cgroup, and + * propagate the change to descendants + * @cgrp: The cgroup which descendants to traverse Missing here is @parent + * @prog: A new program to pin + * @type: Type of pinning operation

Re: [PATCH net-next 2/2] tcp: put a TLV list of TCP stats in error queue

2016-09-06 Thread Soheil Hassas Yeganeh
On Tue, Sep 6, 2016 at 9:32 PM, Francis Y. Yan wrote: > > To export useful TCP statistics along with timestamps, such as > rwnd-limited time and min RTT, we enqueue a TLV list in error queue > immediately when a timestamp is generated. > > Specifically, if user space

Re: [PATCH v4 2/6] cgroup: add support for eBPF programs

2016-09-06 Thread kbuild test robot
Hi Daniel, [auto build test ERROR on net-next/master] [also build test ERROR on next-20160906] [cannot apply to linus/master linux/master v4.8-rc5] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] [Suggest to use git(>=2.9.0) format-patch --b

Re: [PATCH net-next 1/2] tcp: measure rwnd-limited time

2016-09-06 Thread Soheil Hassas Yeganeh
On Tue, Sep 6, 2016 at 9:32 PM, Francis Y. Yan wrote: > This patch measures the total time when TCP transmission is limited > by receiver's advertised window (rwnd), and exports it in tcp_info as > tcpi_rwnd_limited. > > The rwnd-limited time is defined as the period when

linux-next: manual merge of the net-next tree with the net tree

2016-09-06 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/ethernet/qlogic/qed/qed_dcbx.c between commit: 561ed23331df ("qed: fix kzalloc-simple.cocci warnings") from the net tree and commit: 2591c280c375 ("qed: Remove OOM messages") from the net-next tree.

Re: [PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

2016-09-06 Thread kbuild test robot
Hi Jamal, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Jamal-Hadi-Salim/net_sched-Introduce-skbmod-action/20160907-095338 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__

[PATCH net-next] net: diag: make udp_diag_destroy work for mapped addresses.

2016-09-06 Thread Lorenzo Colitti
udp_diag_destroy does look up the IPv4 UDP hashtable for mapped addresses, but it gets the IPv4 address to look up from the beginning of the IPv6 address instead of the end. Tested: https://android-review.googlesource.com/269874 Fixes: 5d77dca82839 ("net: diag: support SOCK_DESTROY for UDP

Re: [PATCH net-next v2] netlink: don't forget to release a rhashtable_iter structure

2016-09-06 Thread Herbert Xu
On Tue, Sep 06, 2016 at 09:31:17PM -0700, Andrei Vagin wrote: > This bug was detected by kmemleak: > unreferenced object 0x8804269cc3c0 (size 64): > comm "criu", pid 1042, jiffies 4294907360 (age 13.713s) > hex dump (first 32 bytes): > a0 32 cc 2c 04 88 ff ff 00 00 00 00 00 00 00 00

Re: [PATCH] ptp: ixp46x: remove NO_IRQ handling

2016-09-06 Thread Arnd Bergmann
On Tuesday, September 6, 2016 6:39:10 PM CEST Richard Cochran wrote: > On Tue, Sep 06, 2016 at 04:28:30PM +0200, Arnd Bergmann wrote: > > gpio_to_irq does not return NO_IRQ but instead returns a negative > > error code on failure. Returning NO_IRQ from the function has no > > negative effects as

Re: [PATCH 00/29] Netfilter updates for net-next

2016-09-06 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 5 Sep 2016 12:58:15 +0200 > Hi David, > > The following patchset contains Netfilter updates for your net-next > tree. Most relevant updates are the removal of per-conntrack timers to > use a workqueue/garbage collection approach instead

Re: [PATCH v4 net-next 1/1] net_sched: Introduce skbmod action

2016-09-06 Thread David Miller
From: Jamal Hadi Salim Date: Tue, 6 Sep 2016 09:54:28 -0400 > On 16-09-06 09:37 AM, Jamal Hadi Salim wrote: >> From: Jamal Hadi Salim >> >> This action is intended to be an upgrade from a usability perspective >> from pedit (as well as operational

[ethtool PATCH v1] ethtool: Document ethtool advertised speeds for 1G/10G

2016-09-06 Thread Vidya Sagar Ravipati
From: Vidya Sagar Ravipati Man page update to include updated advertised speeds for 1G/10G Signed-off-by: Vidya Sagar Ravipati --- ethtool.8.in | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ethtool.8.in b/ethtool.8.in index

Re: [PATCH net-next] sfc: check MTU against minimum threshold

2016-09-06 Thread David Miller
From: Bert Kenward Date: Tue, 6 Sep 2016 17:50:00 +0100 > Reported-by: Ma Yuying > Suggested-by: Jarod Wilson > Signed-off-by: Bert Kenward Applied.

Re: Minimum MTU Mess

2016-09-06 Thread David Miller
From: Jarod Wilson Date: Fri, 2 Sep 2016 13:07:42 -0400 > In any case, the number of "mtu < 68" and "#define FOO_MIN_MTU 68", or > variations thereof, under drivers/net/ is kind of crazy. Agreed, we can have a default and let the different cases provide overrides. Mostly what

Re: [PATCH v2] ptp: ixp46x: remove NO_IRQ handling

2016-09-06 Thread David Miller
From: Arnd Bergmann Date: Tue, 6 Sep 2016 21:20:36 +0200 > gpio_to_irq does not return NO_IRQ but instead returns a negative > error code on failure. Returning NO_IRQ from the function has no > negative effects as we only compare the result to the expected > interrupt number, but

[PATCH net-next] net: xfrm: Change u32 sysctl entries to use proc_douintvec

2016-09-06 Thread Subash Abhinov Kasiviswanathan
proc_dointvec limits the values to INT_MAX in u32 sysctl entries. proc_douintvec allows to write upto UINT_MAX. Signed-off-by: Subash Abhinov Kasiviswanathan --- net/xfrm/xfrm_sysctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: XPS configuration question (on tg3)

2016-09-06 Thread Eric Dumazet
On Tue, 2016-09-06 at 23:00 +0200, Michal Soltys wrote: > On 2016-09-06 22:21, Alexander Duyck wrote: > > On Tue, Sep 6, 2016 at 11:46 AM, Michal Soltys wrote: > >> Hi, > >> > >> I've been testing different configurations and I didn't manage to get XPS > >> to "behave" correctly

<    1   2