Re: [net-next 02/15] i40e: Enable VF specific ethtool statistics via VF Port representor netdevs

On 9/20/2016 9:26 PM, Or Gerlitz wrote: On Wed, Sep 21, 2016 at 6:43 AM, Jeff Kirsher wrote: From: Sridhar Samudrala Sample script that shows ethtool stats on VF representor netdev PF: enp5s0f0, VF0: enp5s2 VF_REP0: enp5s0f0-vf0

Re: [RFC] PCI: Allow sysfs control over totalvfs

Tue, Sep 20, 2016 at 10:27:24PM CEST, yuval.mi...@cavium.com wrote: >> >Some of the HW capable of SRIOV has resource limitations, where the >> >PF and VFs resources are drawn from a common pool. >> >In some cases, these limitations have to be considered early during >> >chip initialization and can

[PATCH net-next] tcp: implement TSQ for retransmits

From: Eric Dumazet We saw sch_fq drops caused by the per flow limit of 100 packets and TCP when dealing with large cwnd and bursts of retransmits. Even after increasing the limit to 1000, and even after commit 10d3be569243 ("tcp-tso: do not split TSO packets at retransmit

Re: [net-next 01/15] i40e: Introduce VF port representor/control netdevs

On 9/20/2016 9:22 PM, Or Gerlitz wrote: On Wed, Sep 21, 2016 at 6:43 AM, Jeff Kirsher wrote: From: Sridhar Samudrala This patch enables creation of a VF Port representor/Control netdev associated with each VF. These netdevs can be

Re: [patch net-next 0/9] mlxsw: Replace Hw related const with resource query results

From: Jiri Pirko Date: Tue, 20 Sep 2016 11:16:48 +0200 > Many of the ASIC's properties can be read from the HW with resources query. > This patchset adds new resources to the resource query and implement > using them, instead of the constants that we currently use. > Those

Re: [PATCH net v2] ipmr, ip6mr: return lastuse relative to now

From: Nikolay Aleksandrov Date: Tue, 20 Sep 2016 16:17:22 +0200 > When I introduced the lastuse member I made a subtle error because it was > returned as an absolute value but that is meaningless to user-space as it > doesn't allow to see how old exactly an entry is.

Re: [PATCH net 0/5] r8152: correct the flow of PHY

From: Hayes Wang Date: Tue, 20 Sep 2016 16:22:04 +0800 > First, to enable the PHY as early as possible. Some settings may fail if the > PHY is power down. > > Move the other PHY settings to hw_phy_cfg() to make sure the order is correct. > > Finally, disable ALDPS and

Re: [PATCHv2 net] cxgb4/cxgb4vf: Allocate more queues for 25G and 100G adapter

From: Hariprasad Shenai Date: Tue, 20 Sep 2016 12:00:52 +0530 > We were missing check for 25G and 100G while checking port speed, > which lead to less number of queues getting allocated for 25G & 100G > adapters and leading to low throughput. Adding the missing check for

Re: [PATCH net-next] mlxsw: spectrum: Make offloads stats functions static

From: Or Gerlitz Date: Tue, 20 Sep 2016 08:14:08 +0300 > The offloads stats functions are local to this file, make them static. > > Fixes: fc1bbb0f1831 ('mlxsw: spectrum: Implement offload stats ndo [..]') > Signed-off-by: Or Gerlitz Applied.

Re: [PATCH net-next 2/3] net: ethernet: mediatek: add support for GMAC0 connecting with external PHY through TRGMII

From: Date: Tue, 20 Sep 2016 15:59:19 +0800 > +/*TRGMII RXC control register*/ ... > +/*TRGMII RXC control register*/ ... > +/*TRGMII Interface mode register*/ Please put a space at the beginning and end of comment lines like this. Thanks.

Re: [PATCH v4 net-next 00/16] tcp: BBR congestion control algorithm

From: Neal Cardwell Date: Mon, 19 Sep 2016 23:39:07 -0400 > tcp: BBR congestion control algorithm Series applied, thanks Neal.

Re: [net-next PATCH v2 1/2] e1000: add initial XDP support

On 16-09-20 09:26 PM, zhuyj wrote: > +static int e1000_xdp_set(struct net_device *netdev, struct bpf_prog *prog) > +{ > + struct e1000_adapter *adapter = netdev_priv(netdev); > + struct bpf_prog *old_prog; > + > + old_prog = xchg(>prog, prog); > + if (old_prog) { > +

Re: [net-next PATCH v2 1/2] e1000: add initial XDP support

+static int e1000_xdp_set(struct net_device *netdev, struct bpf_prog *prog) +{ + struct e1000_adapter *adapter = netdev_priv(netdev); + struct bpf_prog *old_prog; + + old_prog = xchg(>prog, prog); + if (old_prog) { + synchronize_net(); +

Re: [net-next 02/15] i40e: Enable VF specific ethtool statistics via VF Port representor netdevs

On Wed, Sep 21, 2016 at 6:43 AM, Jeff Kirsher wrote: > From: Sridhar Samudrala > > Sample script that shows ethtool stats on VF representor netdev > PF: enp5s0f0, VF0: enp5s2 VF_REP0: enp5s0f0-vf0 > ># echo 2 >

Re: [net-next 01/15] i40e: Introduce VF port representor/control netdevs

On Wed, Sep 21, 2016 at 6:43 AM, Jeff Kirsher wrote: > From: Sridhar Samudrala > This patch enables creation of a VF Port representor/Control netdev > associated with each VF. These netdevs can be used to control and configure > VFs from

Re: [PATCH net-next] net: ethernet: mediatek: enhance with avoiding superfluous assignment inside mtk_get_ethtool_stats

From: Date: Tue, 20 Sep 2016 11:26:48 +0800 > From: Sean Wang > > data_src is unchanged inside the loop, so this patch moves > the assignment to outside the loop to avoid unnecessarily > assignment > > Signed-off-by: Sean Wang

Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU

From: Vivien Didelot Date: Mon, 19 Sep 2016 19:56:11 -0400 > An address can be loaded in the ATU with multiple ports, for instance > when adding multiple ports to a Multicast group with "bridge mdb". > > The current code doesn't allow that. Add an helper to

[net-next 15/15] i40evf: remove unnecessary error checking against i40e_shutdown_adminq

From: Lihong Yang The i40e_shutdown_adminq function never returns failure. There is no need to check the non-0 return value. Clean up the unnecessary error checking and warning against it. Change-ID: Ibb616f09cfb93bd1a872ebf3241a15fb8354b31b Signed-off-by: Lihong Yang

[net-next 14/15] i40e: Limit TX descriptor count in cases where frag size is greater than 16K

From: Alexander Duyck The i40e driver was incorrectly assuming that we would always be pulling no more than 1 descriptor from each fragment. It is in fact possible for us to end up with the case where 2 descriptors worth of data may be pulled when a frame is larger

[net-next 10/15] i40e: Add support for switchdev API for Switch ID

From: Amritha Nambiar This patch adds support for switchdev ops on the VF Port representors and the PF uplink, the only operation implemented is the port attribute API to get the port parent ID or the switch ID. The switch ID is used to identify the net_devices

[net-next 04/15] i40e: fix setting user defined RSS hash key

From: Alan Brady Previously, when using ethtool to change the RSS hash key, ethtool would report back saying the old key was still being used and no error was reported. It was unclear whether it was being reported incorrectly or being set incorrectly. Debugging revealed

[net-next 11/15] i40evf: Fix link state event handling

From: Sridhar Samudrala Currently disabling the link state from PF via ip link set enp5s0f0 vf 0 state disable doesn't disable the CARRIER on the VF. This patch updates the carrier and starts/stops the tx queues based on the link state notification from PF.

[net-next 03/15] i40e: Introduce devlink interface

From: Sridhar Samudrala Add initial devlink support to set/get the mode of SRIOV switch. By default the switch mode is set to 'switchdev' as VF Port representors are created by default. This patch allows the mode to be set to 'legacy' to disable creation of VF Port

[net-next 13/15] i40evf: remove unnecessary error checking against i40evf_up_complete

From: Bimmy Pujari Function i40evf_up_complete() always returns success. Changed this to a void type and removed the code that checks the return status and prints an error message. Change-ID: I8c400f174786b9c855f679e470f35af292fb50ad Signed-off-by: Bimmy Pujari

[net-next 06/15] i40e: return correct opcode to VF

From: Mitch Williams This conditional is backward, so the driver responds back to the VF with the wrong opcode. Do the old switcheroo to fix this. Change-ID: I384035b0fef8a3881c176de4b4672009b3400b25 Signed-off-by: Mitch Williams

[net-next 07/15] i40e: Fix to check for NULL

From: Carolyn Wyborny This patch fixes an issue in the virt channel code, where a return from i40e_find_vsi_from_id was not checked for NULL when applicable. Without this patch, there is a risk for panic and static analysis tools complain. This patch fixes the problem

[net-next 01/15] i40e: Introduce VF port representor/control netdevs

From: Sridhar Samudrala This patch enables creation of a VF Port representor/Control netdev associated with each VF. These netdevs can be used to control and configure VFs from PFs namespace. They enable exposing VF statistics, configuring link state, mtu, fdb/vlan

[net-next 09/15] i40e: avoid potential null pointer dereference when assigning len

From: Colin Ian King There is a sanitcy check for desc being null in the first line of function i40evf_debug_aq. However, before that, aq_desc is cast from desc, and aq_desc is being dereferenced on the assignment of len, so this could be a potential null pointer

[net-next 05/15] i40e: fix "dump port" command when NPAR enabled

From: Alan Brady When using the debugfs to issue the "dump port" command with NPAR enabled, the firmware reports back with invalid argument. The issue occurs because the pf->mac_seid was used to perform the query. This is fine when NPAR is disabled because the switch ID ==

[net-next 02/15] i40e: Enable VF specific ethtool statistics via VF Port representor netdevs

From: Sridhar Samudrala Sample script that shows ethtool stats on VF representor netdev PF: enp5s0f0, VF0: enp5s2 VF_REP0: enp5s0f0-vf0 # echo 2 > /sys/class/net/enp5s0f0/device/sriov_numvfs # ip link set enp5s2 up # ethtool -S enp5s0f0-vf0 NIC

[net-next 08/15] i40e: Fix for extra byte swap in tunnel setup

From: Carolyn Wyborny This patch fixes an issue where we were byte swapping the port parameter, then byte swapping it again in function execution. Obviously, that's unnecessary, so take it out of the function calls. Without this patch, the udp based tunnel

[net-next 12/15] i40e: Sync link state between VFs and VF Port representors(VFPR)

From: Sridhar Samudrala This patch enables - reflecting the link state of VFPR based on VF admin state & link state of VF based on admin state of VFPR. - bringing up/down the VFPR sends a notification to update VF link state. - bringing up/down the VF will cause

[net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2016-09-20

This series contains updates to i40e and i40evf only. Sridhar enables creation of a VF port Representor/Control netdev associated with each VF, which allows control and configuring VFs from Pfs namespace. Then enables the VF specific ethtool statistics via the VF port Representor. Adds initial

Re: [PATCH net-next 0/3] BPF direct packet access improvements

From: Daniel Borkmann Date: Tue, 20 Sep 2016 00:26:11 +0200 > This set adds write support to the currently available read support > for {cls,act}_bpf programs. First one is a fix for affected commit > sitting in net-next and prerequisite for the second one, last patch >

Re: [PATCH v5 net-next 1/1] net sched actions: fix GETing actions

From: Jamal Hadi Salim Date: Mon, 19 Sep 2016 19:02:51 -0400 > From: Jamal Hadi Salim > > With the batch changes that translated transient actions into > a temporary list lost in the translation was the fact that > tcf_action_destroy() will eventually

[PATCH net-next] MAINTAINERS: Update b44 maintainer.

Taking over as maintainer since Gary Zambrano is no longer working for Broadcom. Signed-off-by: Michael Chan --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ce80b36..7626f7836 100644 --- a/MAINTAINERS

Re: [PATCH net-next 5/7] rhashtable: abstract out function to get hash

On Tue, Sep 20, 2016 at 7:46 PM, Herbert Xu wrote: > On Tue, Sep 20, 2016 at 07:58:03PM +0200, Thomas Graf wrote: >> >> I understand this particular patch as an effort not to duplicate >> hash function selection such as jhash vs jhash2 based on key_len. > > If the

Re: [PATCH v4 net-next 16/16] tcp_bbr: add BBR congestion control

On Tue, Sep 20, 2016 at 2:50 PM, Neal Cardwell wrote: > On Tue, Sep 20, 2016 at 2:48 PM, Stephen Hemminger > wrote: >> >> On Mon, 19 Sep 2016 23:39:23 -0400 >> Neal Cardwell wrote: >> >> > +/* INET_DIAG_BBRINFO */ >> > + >>

Re: [PATCH] tcp: fix wrong checksum calculation on MTU probing

This patch is whitespace damaged by your email client. Please fix this, email the patch to yourself, and only resubmit this when you can successfully apply the patch you emailed to yourself. Thanks.

Re: [PATCH next] ipvlan: Fix dependency issue

From: Mahesh Bandewar Date: Mon, 19 Sep 2016 13:56:29 -0700 > From: Mahesh Bandewar > > kbuild-build-bot reported that if NETFILTER is not selected, the > build fails pointing to netfilter symbols. > > Fixes: 4fbae7d83c98 ("ipvlan: Introduce l3s mode")

Re: [PATCH net-next 2/2] openvswitch: avoid resetting flow key while installing new flow.

From: Pravin B Shelar Date: Mon, 19 Sep 2016 13:51:00 -0700 > since commit commit db74a3335e0f6 ("openvswitch: use percpu > flow stats") flow alloc resets flow-key. So there is no need > to reset the flow-key again if OVS is using newly allocated > flow-key. > > Signed-off-by:

Re: [PATCH net-next 1/2] openvswitch: Fix Frame-size larger than 1024 bytes warning.

From: Pravin B Shelar Date: Mon, 19 Sep 2016 13:50:59 -0700 > There is no need to declare separate key on stack, > we can just use sw_flow->key to store the key directly. > > This commit fixes following warning: > > net/openvswitch/datapath.c: In function ‘ovs_flow_cmd_new’: >

Re: pull request: bluetooth-next 2016-09-19

From: Johan Hedberg Date: Mon, 19 Sep 2016 22:37:42 +0300 > Here's the main bluetooth-next pull request for the 4.9 kernel. > > - Added new messages for monitor sockets for better mgmt tracing > - Added local name and appearance support in scan response > - Added new

Re: [PATCH] 6pack: fix buffer length mishandling

From: Alan Date: Mon, 19 Sep 2016 20:15:24 +0100 > Dmitry Vyukov wrote: >> different runs). Looking at code, the following looks suspicious -- we >> limit copy by 512 bytes, but use the original count which can be >> larger than 512: >> >> static void

Re: pull-request: can 2016-09-19

From: Marc Kleine-Budde Date: Mon, 19 Sep 2016 16:19:48 +0200 > this is a pull request of one patch for the upcoming linux-4.8 release. > > The patch by Fabio Estevam fixes the pm handling in the flexcan driver. Pulled, thanks.

Re: [iovisor-dev] XDP (eXpress Data Path) documentation

On Tue, Sep 20, 2016 at 11:08:44AM +0200, Jesper Dangaard Brouer via iovisor-dev wrote: > Hi all, > > As promised, I've started documenting the XDP eXpress Data Path): > > [1] > https://prototype-kernel.readthedocs.io/en/latest/networking/XDP/index.html > > IMHO the documentation have

Re: [PATCH net-next 5/7] rhashtable: abstract out function to get hash

On Tue, Sep 20, 2016 at 07:58:03PM +0200, Thomas Graf wrote: > > I understand this particular patch as an effort not to duplicate > hash function selection such as jhash vs jhash2 based on key_len. If the rhashtable params stay non-const as is then this is going to produce some monstrous code

[PATCH iproute2 3/3] ss: output TCP BBR diag information

Dump useful TCP BBR state information from a struct tcp_bbr_info that was grabbed using the inet_diag API. We tolerate info that is shorter or longer than expected, in case the kernel is older or newer than the ss binary. We simply print the minimum of what is expected from the kernel and what is

[PATCH iproute2 1/3] Update inet_diag.h header to pick up INET_DIAG_MARK

To ease the upcoming addition of BBR-related data to inet_diag.h, add the declaration of INET_DIAG_MARK. That way the BBR-related paches only contain BBR-related pieces. Signed-off-by: Neal Cardwell --- include/linux/inet_diag.h | 1 + 1 file changed, 1 insertion(+) diff

[PATCH iproute2 2/3] Update inet_diag.h to include INET_DIAG_BBRINFO and related structs

Update to include the the inet_diag.h changes in: "tcp_bbr: add BBR congestion control" Signed-off-by: Neal Cardwell --- include/linux/inet_diag.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/linux/inet_diag.h b/include/linux/inet_diag.h

Re: [PATCH net-next 6/7] net/faraday: Fix phy link irq on Aspeed G5 SoCs

On Wed, Sep 21, 2016 at 12:59 AM, Andrew Lunn wrote: > On Tue, Sep 20, 2016 at 10:13:14PM +1000, Benjamin Herrenschmidt wrote: >> On Tue, 2016-09-20 at 16:00 +0930, Joel Stanley wrote: >> > On Aspeed SoC with a direct PHY connection (non-NSCI), we receive >> > continual PHYSTS

[PATCH net] net: get rid of an signed integer overflow in ip_idents_reserve()

From: Eric Dumazet Jiri Pirko reported an UBSAN warning happening in ip_idents_reserve() [] UBSAN: Undefined behaviour in ./arch/x86/include/asm/atomic.h:156:11 [] signed integer overflow: [] -2117905507 + -695755206 cannot be represented in type 'int' Since we do not have

Re: [PATCHv3 net-next 1/2] net: dsa: mv88e6xxx: Add helper for accessing port registers

Hi Andrew, Andrew Lunn writes: > There is a device coming soon which places its port registers > somewhere different to all other Marvell switches supported so far. > Add helper functions for reading/writing port registers, making it > easier to handle this new device. > >

Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

On 9/20/16 4:59 PM, Tom Herbert wrote: I am looking at using this for ILA router. The problem I am hitting is that not all packets that we need to translate go through the XDP path. Some would go through the kernel path, some through XDP path but that would mean I need parallel lookup tables to

Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

On 9/20/16 3:00 PM, Tom Herbert wrote: +static inline int __xdp_hook_run(struct list_head *list_head, +struct xdp_buff *xdp) +{ + struct xdp_hook_ops *elem; + int ret = XDP_PASS; + + list_for_each_entry(elem, list_head, list) { +

Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

On Tue, Sep 20, 2016 at 4:43 PM, Thomas Graf wrote: > On 09/20/16 at 04:18pm, Tom Herbert wrote: >> This allows other use cases than BPF inserting code into the data >> path. This gives XDP potential more utility and more users so that we >> can motivate more driver

Re: [PATCH v4 net-next 16/16] tcp_bbr: add BBR congestion control

On Tue, Sep 20, 2016 at 4:42 PM, Neal Cardwell wrote: > > On Tue, Sep 20, 2016 at 7:39 PM, Stephen Hemminger > wrote: > > > >> NOTE: BBR *must* be used with the fq qdisc ("man tc-fq") with pacing > >> enabled, since pacing is integral to the BBR

Re: [PATCHv4 next 0/3] IPvlan introduce l3s mode

On Mon, 19 Sep 2016 01:25:53 -0400 (EDT) David Miller wrote: > From: Mahesh Bandewar > Date: Fri, 16 Sep 2016 12:59:01 -0700 > > > Same old problem with new approach especially from suggestions from > > earlier patch-series. > > > > First thing is

Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

On 09/20/16 at 04:18pm, Tom Herbert wrote: > This allows other use cases than BPF inserting code into the data > path. This gives XDP potential more utility and more users so that we > can motivate more driver implementations. For instance, I thinks it's > totally reasonable if the nftables guys

Re: [PATCH net-next] net: dsa: mv88e6xxx: handle multiple ports in ATU

On Mon, Sep 19, 2016 at 09:07:16PM -0400, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > > > On Mon, Sep 19, 2016 at 07:56:11PM -0400, Vivien Didelot wrote: > >> An address can be loaded in the ATU with multiple ports, for instance > >> when adding multiple ports

Re: [PATCH v4 net-next 16/16] tcp_bbr: add BBR congestion control

On Tue, Sep 20, 2016 at 7:39 PM, Stephen Hemminger wrote: > >> NOTE: BBR *must* be used with the fq qdisc ("man tc-fq") with pacing >> enabled, since pacing is integral to the BBR design and >> implementation. BBR without pacing would not function properly, and >> may

[PATCHv3 net-next 0/2] Preparation for mv88e6390

These two patches are a couple of preparation steps for supporting the the MV88E6390 family of chips. This is a new generation from Marvell, and will need more feature flags than are currently available in an unsigned long. Expand to an unsigned long long. The MV88E6390 also places its port

[PATCHv3 net-next 1/2] net: dsa: mv88e6xxx: Add helper for accessing port registers

There is a device coming soon which places its port registers somewhere different to all other Marvell switches supported so far. Add helper functions for reading/writing port registers, making it easier to handle this new device. Signed-off-by: Andrew Lunn --- v2: Call

[PATCHv3 net-next 2/2] net: dsa: mv88e6xxx: Convert flag bits to unsigned long long

We are soon going to run out of flag bits on 32bit systems. Convert to unsigned long long. Signed-off-by: Andrew Lunn Reviewed-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 62 +-- 1 file

Re: [PATCH v4 net-next 16/16] tcp_bbr: add BBR congestion control

> NOTE: BBR *must* be used with the fq qdisc ("man tc-fq") with pacing > enabled, since pacing is integral to the BBR design and > implementation. BBR without pacing would not function properly, and > may incur unnecessary high packet loss rates. Does it work with fq_codel?

[PATCH] ptp_clock: future-proofing drivers against PTP subsystem becoming optional

Drivers must be ready to accept NULL from ptp_clock_register() if the PTP clock subsystem is configured out. This patch documents that and ensures that all drivers cope well with a NULL return. Signed-off-by: Nicolas Pitre Reviewed-by: Eugenia Emantayev

Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

On 09/21/2016 01:09 AM, Thomas Graf wrote: On 09/20/16 at 03:49pm, Tom Herbert wrote: On Tue, Sep 20, 2016 at 3:44 PM, Thomas Graf wrote: On 09/20/16 at 03:00pm, Tom Herbert wrote: +static inline int __xdp_hook_run(struct list_head *list_head, +

Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

On Tue, Sep 20, 2016 at 4:09 PM, Thomas Graf wrote: > On 09/20/16 at 03:49pm, Tom Herbert wrote: >> On Tue, Sep 20, 2016 at 3:44 PM, Thomas Graf wrote: >> > On 09/20/16 at 03:00pm, Tom Herbert wrote: >> >> +static inline int __xdp_hook_run(struct list_head

Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

On 09/20/16 at 03:49pm, Tom Herbert wrote: > On Tue, Sep 20, 2016 at 3:44 PM, Thomas Graf wrote: > > On 09/20/16 at 03:00pm, Tom Herbert wrote: > >> +static inline int __xdp_hook_run(struct list_head *list_head, > >> + struct xdp_buff *xdp) > >> +{ > >>

Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

On Tue, Sep 20, 2016 at 3:44 PM, Thomas Graf wrote: > On 09/20/16 at 03:00pm, Tom Herbert wrote: >> +static inline int __xdp_hook_run(struct list_head *list_head, >> + struct xdp_buff *xdp) >> +{ >> + struct xdp_hook_ops *elem; >> + int ret =

Re: [PATCH v2 0/2] make POSIX timers optional

On Tue, 20 Sep 2016, Thomas Gleixner wrote: > I think the whole approach is wrong because it makes the PTP split at the > wrong level. > > Currently we have: > > DRIVER_X > tristate "Driver X" > select PTP > > In order to make POSIX_CLOCK configurable we should have >

Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

On 09/20/16 at 03:00pm, Tom Herbert wrote: > +static inline int __xdp_hook_run(struct list_head *list_head, > + struct xdp_buff *xdp) > +{ > + struct xdp_hook_ops *elem; > + int ret = XDP_PASS; > + > + list_for_each_entry(elem, list_head, list) { > +

Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

On Tue, Sep 20, 2016 at 3:37 PM, Eric Dumazet wrote: > On Tue, 2016-09-20 at 15:00 -0700, Tom Herbert wrote: > >> diff --git a/net/core/xdp.c b/net/core/xdp.c >> new file mode 100644 >> index 000..815ead8 >> --- /dev/null >> +++ b/net/core/xdp.c >> @@ -0,0 +1,211 @@ >>

Re: [PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

On Tue, 2016-09-20 at 15:00 -0700, Tom Herbert wrote: > diff --git a/net/core/xdp.c b/net/core/xdp.c > new file mode 100644 > index 000..815ead8 > --- /dev/null > +++ b/net/core/xdp.c > @@ -0,0 +1,211 @@ > +/* > + * Kernel Connection Multiplexor > + * > + * Copyright (c) 2016 Tom Herbert

Re: [RFC PATCH] xdp: separate struct xdp_prog as container for bpf_prog

On Tue, Sep 20, 2016 at 12:55 PM, Jesper Dangaard Brouer wrote: > Currently the XDP program is simply a bpf_prog pointer. While it > is good for simplicity, it is limiting extendability for upcoming > features. > Hi Jesper, Can you take a look (or try) the RFC patches I just

[PATCH RFC] brcmfmac: stop netif queue when waiting for packets transmission

From: Rafał Miłecki Sending a new key to the firmware should be done without any 802.1x packets pending. Currently brcmfmac has very trivial code waiting for that condition and it doesn't seem to be enough. We should stop netif from sending any extra packets in order to: 1)

[PATCH RFC 1/3] xdp: Infrastructure to generalize XDP

This patch creates an infrastructure for registering and running code at XDP hooks in drivers. This is based on the orignal XDP?BPF and borrows heavily from the techniques used by netfilter to make generic nfhooks. An XDP hook is defined by the xdp_hook_ops. This structure contains the ops of an

[PATCH RFC 2/3] mlx4: Change XDP/BPF to use generic XDP infrastructure

This patch changes the XDP-BPF implementation to use the generic XDP infrastructure. This includes corresponding changes to the Mellanox XDP code. Signed-off-by: Tom Herbert --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 64 --

[PATCH RFC 0/3] xdp: Generalize XDP

This patch set generalizes XDP by make the hooks in drivers to be generic in the same manner of nfhooks. This has a number of advantages: - Allows alternative users of the XDP hooks other than the original BPF - Allows a means to pipeline XDP programs together - Reduces the amount of

[PATCH RFC 3/3] netdevice: Remove obsolete xdp_netdev_command

Remove XDP_SETUP_PROG and XDP_QUERY_PROG as they should no longer be needed. Signed-off-by: Tom Herbert --- include/linux/netdevice.h | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h

Re: [RFC] PCI: Allow sysfs control over totalvfs

On Tue, Sep 20, 2016 at 8:49 AM, Yuval Mintz wrote: > [Sorry in advance if this was already discussed in the past] > > Some of the HW capable of SRIOV has resource limitations, where the > PF and VFs resources are drawn from a common pool. > In some cases, these

[PATCH next 0/2] Rename WORD_TRUNC/ROUND macros and use them

This patchset aims to rename these macros to a non-confusing name, as reported by David Laight and David Miller, and to update all remaining places to make use of it, which was 1 last remaining spot. v2: - fixed 2nd patch summary Details on the specific changelogs. Thanks! Marcelo Ricardo

[PATCH next v2 1/2] sctp: rename WORD_TRUNC/ROUND macros

To something more meaningful these days, specially because this is working on packet headers or lengths and which are not tied to any CPU arch but to the protocol itself. So, WORD_TRUNC becomes SCTP_TRUNC4 and WORD_ROUND becomes SCTP_ALIGN4. Reported-by: David Laight

[PATCH next v2 2/2] sctp: make use of SCTP_TRUNC4 macro

And avoid the usage of '&~3'. This is the last place still not using the macro. Also break the line to make it easier to read. Signed-off-by: Marcelo Ricardo Leitner --- When I checked it the other day I thought I had this patch applied by the moment but I hadn't. v2:

Re: [PATCH net-next 1/3] net: ethernet: mediatek: add extension of phy-mode for TRGMII

On 09/20/2016 12:59 AM, sean.w...@mediatek.com wrote: > From: Sean Wang > > adds PHY-mode "trgmii" as an extension for the operation > mode of the PHY interface, TRGMII can be compatible with > RGMII, so the extended mode doesn't really have effects on > the target MAC

Re: [PATCH next 2/2] sctp: make use of WORD_TRUNC macro

On Tue, Sep 20, 2016 at 05:24:20PM -0300, Marcelo Ricardo Leitner wrote: > + max_data = SCTP_TRUNC4(max_data); Will post a v2 to fix the subject.

[PATCH next 1/2] sctp: fix the handling of SACK Gap Ack blocks

sctp_acked() is using 32bit arithmetics on 16bits vars, via TSN_lte() macros, which is weird and confusing. Once the offset to ctsn is calculated, all wrapping is already handled and thus to verify the Gap Ack blocks we can just use pure less/big-or-equal than checks. Also, rename gap variable

[PATCH next 0/2] improvements to SSN and TSN handling

First patch fixes a potential issue made visible by the second one noticed by David Laight and is a preparation for the next one. The second patch changes how SSN, TSN and ASCONF serials are compared so they can use typecheck() and are more like time_before() macro. Marcelo Ricardo Leitner (2):

[PATCH next 2/2] sctp: improve how SSN, TSN and ASCONF serial are compared

Make it similar to time_before() macros: - easier to understand - make use of typecheck() to avoid working on unexpected variable types (made the issue on previous patch visible) - for _[lg]te versions, slighly faster, as the compiler used to generate a sequence of cmp/je/cmp/js instructions

Re: [PATCH v3] net: ip, diag -- Add diag interface for raw sockets

On Fri, Sep 16, 2016 at 11:07:22PM +0300, Cyrill Gorcunov wrote: > > It may well be a ss bug / problem. As I mentioned I am always seeing 255 > > for the protocol which > > It is rather not addressed in ss. I mean, look, when we send out a diag packet > the kernel look ups for a handler, which

Re: [PATCH v2 0/2] make POSIX timers optional

On Tue, 20 Sep 2016, Nicolas Pitre wrote: > On Tue, 20 Sep 2016, Richard Cochran wrote: > > > On Tue, Sep 20, 2016 at 10:25:56PM +0200, Richard Cochran wrote: > > > After this series, if I don't pay enough attention to dmesg, then I > > > have lost functionality that I had in step #1. That

Re: [PATCH net-next 7/8] net/mlx5e: XDP TX forwarding support

On Tue, 20 Sep 2016 09:45:28 -0700 Alexei Starovoitov wrote: > To your other question: > > Please explain why a eBPF program error (div by zero) must be a silent > > drop? > > because 'div by zero' is an abnormal situation that shouldn't be exploited. > Meaning

Re: [PATCH v2 0/2] make POSIX timers optional

On Tue, 20 Sep 2016, Richard Cochran wrote: > On Tue, Sep 20, 2016 at 10:25:56PM +0200, Richard Cochran wrote: > > After this series, if I don't pay enough attention to dmesg, then I > > have lost functionality that I had in step #1. That sucks, and it has > > nothing to do with the tinification

Re: [PATCH v2 0/2] make POSIX timers optional

On Tue, 20 Sep 2016, Richard Cochran wrote: > On Tue, Sep 20, 2016 at 03:56:38PM -0400, Nicolas Pitre wrote: > > - Add a warning for the case where PTP clock subsystem is modular and a > > driver providing a clock is built-in rather than silently ignoring it. > > Suggested by Jiri Benc. > >

Re: [PATCH net-next 7/8] net/mlx5e: XDP TX forwarding support

On Tue, 20 Sep 2016 20:59:39 +0200 Jesper Dangaard Brouer wrote: > On Tue, 20 Sep 2016 10:39:20 -0700 Eric Dumazet > wrote: > [...] > > > Many existing supervision infrastructures collect device snmp > > counters, and run as unprivileged programs.

Re: [PATCH v2 0/2] make POSIX timers optional

On Tue, Sep 20, 2016 at 10:25:56PM +0200, Richard Cochran wrote: > After this series, if I don't pay enough attention to dmesg, then I > have lost functionality that I had in step #1. That sucks, and it has > nothing to do with the tinification option at all. It will bite even > if I have no

[PATCH 2/2] net: ethernet: hisilicon: hns: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 105 -- 1 files changed, 58 insertions(+), 47 deletions(-)

[PATCH 1/2] net: ethernet: hisilicon: hns: use phydev from struct net_device

The private structure contain a pointer to phydev, but the structure net_device already contain such pointer. So we can remove the pointer phydev in the private structure, and update the driver to use the one contained in struct net_device. Signed-off-by: Philippe Reynes ---

Re: [RFC] PCI: Allow sysfs control over totalvfs

> >Some of the HW capable of SRIOV has resource limitations, where the > >PF and VFs resources are drawn from a common pool. > >In some cases, these limitations have to be considered early during > >chip initialization and can only be changed by tearing down the > >configuration and

Re: [PATCH v2 0/2] make POSIX timers optional

On Tue, Sep 20, 2016 at 03:56:38PM -0400, Nicolas Pitre wrote: > - Add a warning for the case where PTP clock subsystem is modular and a > driver providing a clock is built-in rather than silently ignoring it. > Suggested by Jiri Benc. So I am really not happy with this. Here is a common

  1   2   3   4   >