Re: [PATCHv2 net 3/3] sctp: hold transport instead of assoc when lookup assoc in rx path

2016-10-31 Thread Marcelo Ricardo Leitner
On Mon, Oct 31, 2016 at 08:32:33PM +0800, Xin Long wrote: > Prior to this patch, in rx path, before calling lock_sock, it needed to > hold assoc when got it by __sctp_lookup_association, in case other place > would free/put assoc. > > But in __sctp_lookup_association, it lookup and hold

Re: [PATCHv2 net 2/3] sctp: return back transport in __sctp_rcv_init_lookup

2016-10-31 Thread Marcelo Ricardo Leitner
On Mon, Oct 31, 2016 at 08:32:32PM +0800, Xin Long wrote: > Prior to this patch, it used a local variable to save the transport that is > looked up by __sctp_lookup_association(), and didn't return it back. But in > sctp_rcv, it is used to initialize chunk->transport. So when hitting this, > even

Re: [PATCHv2 net 1/3] sctp: hold transport instead of assoc in sctp_diag

2016-10-31 Thread Marcelo Ricardo Leitner
On Mon, Oct 31, 2016 at 08:32:31PM +0800, Xin Long wrote: > In sctp_transport_lookup_process(), Commit 1cceda784980 ("sctp: fix > the issue sctp_diag uses lock_sock in rcu_read_lock") moved cb() out > of rcu lock, but it put transport and hold assoc instead, and ignore > that cb() still uses

Re: [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup

2016-10-31 Thread marcelo . leitner
On Mon, Oct 31, 2016 at 03:53:48PM -0400, David Miller wrote: > From: Xin Long > Date: Mon, 31 Oct 2016 00:42:35 +0800 > > > Prior to this patch, it used a local variable to save the transport that is > > looked up by __sctp_lookup_association(), and didn't return it back.

[PATCH net] igb: re-assign hw address pointer on reset after PCI error

2016-10-31 Thread Guilherme G. Piccoli
Whenever the igb driver detects the result of a read operation returns a value composed only by F's (like 0x), it will detach the net_device, clear the hw_addr pointer and warn to the user that adapter's link is lost - those steps happen on igb_rd32(). In case a PCI error happens on Power

Re: [PATCH 1/1] xen-netfront: do not cast grant table reference to signed short

2016-10-31 Thread David Miller
From: Dongli Zhang Date: Mon, 31 Oct 2016 13:38:29 +0800 > While grant reference is of type uint32_t, xen-netfront erroneously casts > it to signed short in BUG_ON(). > > This would lead to the xen domU panic during boot-up or migration when it > is attached with lots

Re: [PATCHv2 net] sctp: return back transport in __sctp_rcv_init_lookup

2016-10-31 Thread David Miller
From: Xin Long Date: Mon, 31 Oct 2016 00:42:35 +0800 > Prior to this patch, it used a local variable to save the transport that is > looked up by __sctp_lookup_association(), and didn't return it back. But in > sctp_rcv, it is used to initialize chunk->transport. So when

Re: [PATCH net-next v2 0/7] qed*: Patch series

2016-10-31 Thread David Miller
From: Yuval Mintz Date: Mon, 31 Oct 2016 07:14:20 +0200 > This series does several things. The bigger changes: > > - Add new notification APIs [& Defaults] for various fields. > The series then utilizes some of those qed <-> qede APIs to bass WoL > support upon. > > -

Re: [net-next PATCH 0/7] stmmac: dwmac-sti refactor+cleanup

2016-10-31 Thread David Miller
From: Joachim Eastwood Date: Sun, 30 Oct 2016 21:05:00 +0100 > This patch set aims to remove the init/exit callbacks from the > dwmac-sti driver and instead use standard PM callbacks. Doing this > will also allow us to cleanup the driver. > > Eventually the init/exit

Re: pull-request: wireless-drivers-next 2016-10-30

2016-10-31 Thread David Miller
From: Kalle Valo Date: Sun, 30 Oct 2016 11:20:46 +0200 > few fixes for 4.9. I tagged this on the plane over a slow mosh > connection while travelling to Plumbers so I might have done something > wrong, please check more carefully than usually. For example I had to > redo

Re: [PATCH net] bgmac: stop clearing DMA receive control register right after it is set

2016-10-31 Thread Hauke Mehrtens
On 10/31/2016 06:32 PM, Andy Gospodarek wrote: > Current bgmac code initializes some DMA settings in the receive control > register for some hardware and then immediately clears those settings. > Not clearing those settings results in ~420Mbps *improvement* in > throughput; this system can now

Re: [patch net] mlxsw: spectrum: Fix incorrect reuse of MID entries

2016-10-31 Thread David Miller
From: Jiri Pirko Date: Sun, 30 Oct 2016 10:09:22 +0100 > From: Ido Schimmel > > In the device, a MID entry represents a group of local ports, which can > later be bound to a MDB entry. > > The lookup of an existing MID entry is currently done using the

Re: Let's do P4

2016-10-31 Thread John Fastabend
[...] >>> >> >> I think the issue with offloading a P4-AST will be how much work goes >> into mapping this onto any particular hardware instance. And how much >> of the P4 language feature set is exposed. >> >> For example I suspect MLX switch has a different pipeline than MLX NIC >> and even

Re: [PATCH 12/15] ptp: use permission-specific DEVICE_ATTR variants

2016-10-31 Thread David Miller
From: Julia Lawall Date: Sat, 29 Oct 2016 21:37:06 +0200 > Use DEVICE_ATTR_RO for read only attributes. This simplifies the > source code, improves readbility, and reduces the chance of > inconsistencies. > > The semantic patch that makes this change is as follows: >

Re: [PATCH net] qede: Fix statistics' strings for Tx/Rx queues

2016-10-31 Thread David Miller
From: Yuval Mintz Date: Sun, 30 Oct 2016 10:25:42 +0200 > When an interface is configured to use Tx/Rx-only queues, > the length of the statistics would be shortened to accomodate only the > statistics required per-each queue, and the values would be provided >

[PATCH -next] net: cris: make eth_v10.c explicitly non-modular

2016-10-31 Thread Paul Gortmaker
The Makefile/Kconfig currently controlling compilation of this code is: drivers/net/cris/Makefile:obj-$(CONFIG_ETRAX_ARCH_V10) += eth_v10.o arch/cris/Kconfig:config ETRAX_ARCH_V10 arch/cris/Kconfig: bool ...meaning that it currently is not being built as a module by anyone. Lets remove

Re: [PATCH 15/15] solos-pci: use permission-specific DEVICE_ATTR variants

2016-10-31 Thread David Miller
From: Julia Lawall Date: Sat, 29 Oct 2016 21:37:09 +0200 > Use DEVICE_ATTR_RW for read-write attributes. This simplifies the > source code, improves readbility, and reduces the chance of > inconsistencies. > > The semantic patch that makes this change is as follows: >

Re: [PATCH] unix: escape all null bytes in abstract unix domain socket

2016-10-31 Thread David Miller
From: Isaac Boukris Date: Sat, 29 Oct 2016 22:20:20 +0300 > Abstract unix domain socket may embed null characters, > these should be translated to '@' when printed out to > proc the same way the null prefix is currently being > translated. > > This helps for tools such as

Re: [PATCH net] net: mangle zero checksum in skb_checksum_help()

2016-10-31 Thread David Miller
From: Eric Dumazet Date: Sat, 29 Oct 2016 11:02:36 -0700 > From: Eric Dumazet > > Sending zero checksum is ok for TCP, but not for UDP. > > UDPv6 receiver should by default drop a frame with a 0 checksum, > and UDPv4 would not verify the checksum

Re: [PATCH net-next] bpf, inode: add support for symlinks and fix mtime/ctime

2016-10-31 Thread David Miller
From: Daniel Borkmann Date: Sat, 29 Oct 2016 02:30:46 +0200 > While commit bb35a6ef7da4 ("bpf, inode: allow for rename and link ops") > added support for hard links that can be used for prog and map nodes, > this work adds simple symlink support, which can be used f.e. for

Re: [PATCH net] net: clear sk_err_soft in sk_clone_lock()

2016-10-31 Thread David Miller
From: Eric Dumazet Date: Fri, 28 Oct 2016 13:40:24 -0700 > From: Eric Dumazet > > At accept() time, it is possible the parent has a non zero > sk_err_soft, leftover from a prior error. > > Make sure we do not leave this value in the child, as it >

Re: [PATCH net-next 5/5] ipv6: Compute multipath hash for forwarded ICMP errors from offending packet

2016-10-31 Thread Tom Herbert
On Sun, Oct 30, 2016 at 6:03 AM, Jakub Sitnicki wrote: > On Fri, Oct 28, 2016 at 02:25 PM GMT, Tom Herbert wrote: >> On Fri, Oct 28, 2016 at 1:32 AM, Jakub Sitnicki wrote: >>> On Thu, Oct 27, 2016 at 10:35 PM GMT, Tom Herbert wrote: On Mon, Oct 24, 2016 at

Re: XDP question - how much can BPF change in xdp_buff?

2016-10-31 Thread John Fastabend
On 16-10-31 11:57 AM, David Miller wrote: > From: "Mintz, Yuval" > Date: Mon, 31 Oct 2016 18:31:30 + > >> So I've [finally] started looking into implementing XDP >> for qede, and there's one thing I feel like I'm missing in >> regard to XDP_TX - what's the

Re: [PATCH net-next v3]ldmvsw: tx queue stuck in stopped state after LDC reset

2016-10-31 Thread David Miller
From: Aaron Young Date: Fri, 28 Oct 2016 14:26:19 -0400 > From: Aaron Young > > The following patch fixes an issue with the ldmvsw driver where > the network connection of a guest domain becomes non-functional after > the guest domain has panic'd

Re: [PATCH net] dctcp: avoid bogus doubling of cwnd after loss

2016-10-31 Thread David Miller
From: Florian Westphal Date: Fri, 28 Oct 2016 18:43:11 +0200 > If a congestion control module doesn't provide .undo_cwnd function, > tcp_undo_cwnd_reduction() will set cwnd to > >tp->snd_cwnd = max(tp->snd_cwnd, tp->snd_ssthresh << 1); > > ... which makes sense for reno (it

Re: [PATCH net-next 5/5] ipv6: Compute multipath hash for forwarded ICMP errors from offending packet

2016-10-31 Thread David Miller
From: Jakub Sitnicki Date: Sun, 30 Oct 2016 14:03:11 +0100 > 2) ensure the flow labels used in both directions are the same (either >reflected by one side, or fixed, e.g. not used and set to 0), so that >the 4-tuple we hash over when forwarding, label, next hdr>, is

Re: [PATCH net-next] net: set SK_MEM_QUANTUM to 4096

2016-10-31 Thread Eric Dumazet
On Mon, 2016-10-31 at 15:01 -0400, Neal Cardwell wrote: > On Mon, Oct 31, 2016 at 2:58 PM, Eric Dumazet wrote: > > > > From: Eric Dumazet > > > > Systems with large pages (64KB pages for example) do not always have > > huge quantity of memory. > > > >

Re: [RFC PATCH v2 2/5] net: phy: Add Meson GXL Internal PHY driver

2016-10-31 Thread Andrew Lunn
On Mon, Oct 31, 2016 at 05:56:24PM +0100, Neil Armstrong wrote: > Add driver for the Internal RMII PHY found in the Amlogic Meson GXL SoCs. > > This PHY seems to only implement some standard registers and need some > workarounds to provide autoneg values from vendor registers. > > Some magic

Re: [PATCH net-next] net: set SK_MEM_QUANTUM to 4096

2016-10-31 Thread Neal Cardwell
On Mon, Oct 31, 2016 at 2:58 PM, Eric Dumazet wrote: > > From: Eric Dumazet > > Systems with large pages (64KB pages for example) do not always have > huge quantity of memory. > > A big SK_MEM_QUANTUM value leads to fewer interactions with the >

Re: [net-next PATCH v2 0/4] Add support for XPS when using DCB

2016-10-31 Thread David Miller
From: Alexander Duyck Date: Fri, 28 Oct 2016 11:42:45 -0400 > This patch series enables proper isolation between traffic classes when > using XPS while DCB is enabled. Previously enabling XPS would cause the > traffic to be potentially pulled from one traffic class

Re: [RFC PATCH v2 1/5] net: mdio-mux-mmioreg: Add support for 16bit and 32bit register sizes

2016-10-31 Thread Andrew Lunn
On Mon, Oct 31, 2016 at 05:56:23PM +0100, Neil Armstrong wrote: > In order to support PHY switching on Amlogic GXL SoCs, add support for > 16bit and 32bit registers sizes. > > Signed-off-by: Neil Armstrong Nice. Reviewed-by: Andrew Lunn Andrew

[PATCH net-next] net: set SK_MEM_QUANTUM to 4096

2016-10-31 Thread Eric Dumazet
From: Eric Dumazet Systems with large pages (64KB pages for example) do not always have huge quantity of memory. A big SK_MEM_QUANTUM value leads to fewer interactions with the global counters (like tcp_memory_allocated) but might trigger memory pressure much faster, thus

Re: XDP question - how much can BPF change in xdp_buff?

2016-10-31 Thread David Miller
From: "Mintz, Yuval" Date: Mon, 31 Oct 2016 18:31:30 + > So I've [finally] started looking into implementing XDP > for qede, and there's one thing I feel like I'm missing in > regard to XDP_TX - what's the guarantee/requirement > that the bpf program isn't going to

Re: [PATCH] Revert "usb: dwc3: gadget: use allocated/queued reqs for LST bit"

2016-10-31 Thread David Miller
From: Ville Syrjälä Date: Fri, 28 Oct 2016 19:33:32 +0300 > On Fri, Oct 28, 2016 at 01:16:13PM +0300, Felipe Balbi wrote: >> Yeah, I'm guessing we're gonna need some help from networking folks. The >> only thing we did since v4.7 was actually respect

[PATCH net-next 1/3] tools lib bpf: Sync {tools,}/include/uapi/linux/bpf.h

2016-10-31 Thread Joe Stringer
The tools version of this header is out of date; update it to the latest version from the kernel headers. Signed-off-by: Joe Stringer --- tools/include/uapi/linux/bpf.h | 51 ++ 1 file changed, 51 insertions(+) diff --git

[PATCH net-next 0/3] tools lib bpf: Synchronize implementations

2016-10-31 Thread Joe Stringer
Update tools/lib/bpf to provide more functionality and improve interoperation with other tools that generate and use eBPF code. The kernel uapi headers are a bit newer than the version in the tools/ directory; synchronize those. samples/bpf/libbpf* has a bit more functionality than

[PATCH net-next 3/3] tools lib bpf: Sync bpf_map_def with tc

2016-10-31 Thread Joe Stringer
TC uses a slightly different map layout in its ELFs. Update libbpf to use the same definition so that ELFs may be built using libbpf and loaded using tc. Signed-off-by: Joe Stringer --- tools/lib/bpf/libbpf.h | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff

[PATCH net-next 2/3] tools lib bpf: Sync with samples/bpf/libbpf

2016-10-31 Thread Joe Stringer
Extend the tools/ version of libbpf to include all of the functionality provided in the samples/bpf version. Signed-off-by: Joe Stringer --- tools/lib/bpf/bpf.c| 139 +++-- tools/lib/bpf/bpf.h| 208

Re: net/dccp: warning in dccp_feat_clone_sp_val/__might_sleep

2016-10-31 Thread Eric Dumazet
On Mon, 2016-10-31 at 11:00 -0700, Cong Wang wrote: > On Sun, Oct 30, 2016 at 6:20 AM, Eric Dumazet wrote: > > On Sun, 2016-10-30 at 05:41 +0100, Andrey Konovalov wrote: > >> Sorry, the warning is still there. > >> > >> I'm not sure adding sched_annotate_sleep() does

[PATCH] rtl8xxxu: Fix for agressive power saving by rtl8723bu wireless IC

2016-10-31 Thread John Heenan
The rtl8723bu wireless IC shows evidence of a more agressive approach to power saving, powering down its RF side when there is no wireless interfacing but leaving USB interfacing intact. This makes the wireless IC more suitable for use in devices which need to keep their power use as low as

Re: Let's do P4

2016-10-31 Thread Hannes Frederic Sowa
On 31.10.2016 18:12, Jiri Pirko wrote: >> > >> >In the naive implementation only pipelines that map 1:1 will work. Maybe >> >this is what Alexei is noticing? > P4 is ment to program programable hw, not fixed pipeline. Is it realistic to assume that future hardware might be programmed with a

XDP question - how much can BPF change in xdp_buff?

2016-10-31 Thread Mintz, Yuval
So I've [finally] started looking into implementing XDP for qede, and there's one thing I feel like I'm missing in regard to XDP_TX - what's the guarantee/requirement that the bpf program isn't going to transmute some fields of the rx packet in a way that would prevent the forwarding? E.g., can a

Re: mv643xx_eth.c merge gone bad...

2016-10-31 Thread Andrew Lunn
On Mon, Oct 31, 2016 at 11:18:54AM -0700, Florian Fainelli wrote: > On 10/31/2016 07:34 AM, David Miller wrote: > > From: Andrew Lunn > > Date: Mon, 31 Oct 2016 14:35:38 +0100 > > > >> On Mon, Oct 31, 2016 at 09:12:06AM -0400, David Miller wrote: > >>> From: Andrew Lunn

Re: [PATCH net] ipv6: add mtu lock check in __ip6_rt_update_pmtu

2016-10-31 Thread David Miller
From: Xin Long Date: Fri, 28 Oct 2016 18:18:01 +0800 > Prior to this patch, ipv6 didn't do mtu lock check in ip6_update_pmtu. > It leaded to that mtu lock doesn't really work when receiving the pkt > of ICMPV6_PKT_TOOBIG. > > This patch is to add mtu lock check in

Re: [RFC PATCH 01/13] pinctrl: meson: Add GXL pinctrl definitions

2016-10-31 Thread Kevin Hilman
Neil Armstrong writes: > On 10/24/2016 03:03 AM, Linus Walleij wrote: >> On Fri, Oct 21, 2016 at 4:40 PM, Neil Armstrong >> wrote: >> >>> Add support for the Amlogic Meson GXL SoC, this is a partially complete >>> definition only based on the

Re: mv643xx_eth.c merge gone bad...

2016-10-31 Thread Florian Fainelli
On 10/31/2016 07:34 AM, David Miller wrote: > From: Andrew Lunn > Date: Mon, 31 Oct 2016 14:35:38 +0100 > >> On Mon, Oct 31, 2016 at 09:12:06AM -0400, David Miller wrote: >>> From: Andrew Lunn >>> Date: Mon, 31 Oct 2016 12:33:49 +0100 >>> The merge of commit

Re: [PATCH v2] ip6_tunnel: Clear IP6CB in ip6_tnl_xmit() after encapsulation

2016-10-31 Thread David Miller
From: Shmulik Ladkani Date: Fri, 28 Oct 2016 19:07:57 +0300 > On Fri, 28 Oct 2016 13:13:45 +0800 Eli Cooper wrote: >> Maybe we >> should clear IP6CB in ip6tunnel_xmit(), rather than in every tunnel's codes? > > This seems reasonable. > > A

Re: Why do we need tasklet in IFB?

2016-10-31 Thread David Miller
From: Michael Ma Date: Mon, 31 Oct 2016 11:02:28 -0700 > 2016-10-28 14:52 GMT-07:00 Michael Ma : >> 2016-10-28 14:48 GMT-07:00 Stephen Hemminger : >>> On Fri, 28 Oct 2016 14:45:07 -0700 >>> Michael Ma wrote:

Re: Why do we need tasklet in IFB?

2016-10-31 Thread Michael Ma
2016-10-31 11:02 GMT-07:00 Michael Ma : > 2016-10-28 14:52 GMT-07:00 Michael Ma : >> 2016-10-28 14:48 GMT-07:00 Stephen Hemminger : >>> On Fri, 28 Oct 2016 14:45:07 -0700 >>> Michael Ma wrote: >>>

Re: Why do we need tasklet in IFB?

2016-10-31 Thread Michael Ma
2016-10-28 14:52 GMT-07:00 Michael Ma : > 2016-10-28 14:48 GMT-07:00 Stephen Hemminger : >> On Fri, 28 Oct 2016 14:45:07 -0700 >> Michael Ma wrote: >> >>> 2016-10-28 14:38 GMT-07:00 Stephen Hemminger :

Re: net/dccp: warning in dccp_feat_clone_sp_val/__might_sleep

2016-10-31 Thread Cong Wang
On Sun, Oct 30, 2016 at 6:20 AM, Eric Dumazet wrote: > On Sun, 2016-10-30 at 05:41 +0100, Andrey Konovalov wrote: >> Sorry, the warning is still there. >> >> I'm not sure adding sched_annotate_sleep() does anything, since it's >> defined as (in case

Re: [PATCH] net: phy: at803x: the Atheros 8031 supports pause frames

2016-10-31 Thread Florian Fainelli
On 10/31/2016 10:23 AM, Timur Tabi wrote: > Florian Fainelli wrote: > >> May I suggest reading about standards a bit more, or just looking at >> other drivers, like tg3.c. > > I have been doing that for over six months now. There's only so much I > can glean from reading source code and

Re: [PATCH v2 net-next 1/5] bpf: Refactor cgroups code in prep for new type

2016-10-31 Thread Thomas Graf
On 10/31/16 at 06:16pm, Daniel Mack wrote: > On 10/31/2016 06:05 PM, David Ahern wrote: > > On 10/31/16 11:00 AM, Daniel Mack wrote: > >> Yeah, I'm confused too. I changed that name in my v7 from > >> BPF_PROG_TYPE_CGROUP_SOCK to BPF_PROG_TYPE_CGROUP_SKB on David's > >> (Ahern) request. Why is it

Re: [PATCH] net: phy: at803x: the Atheros 8031 supports pause frames

2016-10-31 Thread David Miller
From: Timur Tabi Date: Thu, 27 Oct 2016 17:05:01 -0500 > The Atheros 8031 PHY supports the 802.3 extension for symmetric and > asymmetric pause frames, so set that to the list of features supported > by the phy. > > Signed-off-by: Timur Tabi It

Re: [PATCH v2 net-next 0/5] Add bpf support to set sk_bound_dev_if

2016-10-31 Thread Thomas Graf
On 10/31/16 at 11:16am, David Ahern wrote: > On 10/31/16 11:01 AM, David Miller wrote: > > Also, any reason why you don't allow the cgroup bpf sk filter to return > > an error code so that the sock creation could be cancelled if the eBPF > > program desires that? It could be useful, I suppose. >

[PATCH net] bgmac: stop clearing DMA receive control register right after it is set

2016-10-31 Thread Andy Gospodarek
Current bgmac code initializes some DMA settings in the receive control register for some hardware and then immediately clears those settings. Not clearing those settings results in ~420Mbps *improvement* in throughput; this system can now receive frames at line-rate on Broadcom 5871x hardware

Re: [PATCH net-next 3/4] bpf: BPF for lightweight tunnel encapsulation

2016-10-31 Thread Thomas Graf
On 10/31/16 at 09:07am, Tom Herbert wrote: > I guess this leads to a more general question I have about the effects > of allowing userspace to insert code in the kernel that modifies > packets. If we allow BPF programs to arbitrarily modify packets in > LWT, how do we ensure that there are no

Re: [PATCH/RFC] ravb: Support 1Gbps on R-Car H3 ES1.1+ and R-Car M3-W

2016-10-31 Thread David Miller
From: Geert Uytterhoeven Date: Mon, 31 Oct 2016 18:13:38 +0100 > The limitation to 10/100Mbit speeds on R-Car Gen3 is valid for R-Car H3 > ES1.0 only. Check for the exact SoC model to allow 1Gbps on newer > revisions of R-Car H3, and on R-Car M3-W. > > Signed-off-by:

Re: [PATCH] net: phy: at803x: the Atheros 8031 supports pause frames

2016-10-31 Thread Timur Tabi
Florian Fainelli wrote: May I suggest reading about standards a bit more, or just looking at other drivers, like tg3.c. I have been doing that for over six months now. There's only so much I can glean from reading source code and standards documents. The inner workings of our NIC are a

Re: [PATCH v2 net-next 0/5] Add bpf support to set sk_bound_dev_if

2016-10-31 Thread David Ahern
On 10/31/16 11:01 AM, David Miller wrote: > From: David Ahern > Date: Wed, 26 Oct 2016 17:58:37 -0700 > >> The recently added VRF support in Linux leverages the bind-to-device >> API for programs to specify an L3 domain for a socket. While >> SO_BINDTODEVICE has been

Re: [PATCH v2 net-next 1/5] bpf: Refactor cgroups code in prep for new type

2016-10-31 Thread Daniel Mack
On 10/31/2016 06:05 PM, David Ahern wrote: > On 10/31/16 11:00 AM, Daniel Mack wrote: >> On 10/31/2016 05:58 PM, David Miller wrote: >>> From: David Ahern Date: Wed, 26 Oct >>> 2016 17:58:38 -0700 >>> diff --git a/include/uapi/linux/bpf.h

[PATCH/RFC] ravb: Support 1Gbps on R-Car H3 ES1.1+ and R-Car M3-W

2016-10-31 Thread Geert Uytterhoeven
The limitation to 10/100Mbit speeds on R-Car Gen3 is valid for R-Car H3 ES1.0 only. Check for the exact SoC model to allow 1Gbps on newer revisions of R-Car H3, and on R-Car M3-W. Signed-off-by: Geert Uytterhoeven --- Tested on: - r8a7795/salvator-x with R-Car H3 ES1.0

Re: [PATCH net] ipv6: Don't use ufo handling on later transformed packets

2016-10-31 Thread David Miller
From: Jakub Sitnicki Date: Wed, 26 Oct 2016 11:21:14 +0200 > Similar to commit c146066ab802 ("ipv4: Don't use ufo handling on later > transformed packets"), don't perform UFO on packets that will be IPsec > transformed. To detect it we rely on the fact that headerlen in >

Re: Let's do P4

2016-10-31 Thread Jiri Pirko
Mon, Oct 31, 2016 at 05:53:38PM CET, john.fastab...@gmail.com wrote: >On 16-10-31 02:39 AM, Jiri Pirko wrote: >> Sun, Oct 30, 2016 at 11:39:05PM CET, alexei.starovoi...@gmail.com wrote: >>> On Sun, Oct 30, 2016 at 05:38:36PM +0100, Jiri Pirko wrote: Sun, Oct 30, 2016 at 11:26:49AM CET,

Re: [PATCH 00/12] xen: add common function for reading optional value

2016-10-31 Thread David Miller
From: Juergen Gross Date: Mon, 31 Oct 2016 17:48:18 +0100 > There are multiple instances of code reading an optional unsigned > parameter from Xenstore via xenbus_scanf(). Instead of repeating the > same code over and over add a service function doing the job and > replace the

Re: [PATCH v2 net-next 1/5] bpf: Refactor cgroups code in prep for new type

2016-10-31 Thread David Ahern
On 10/31/16 11:00 AM, Daniel Mack wrote: > On 10/31/2016 05:58 PM, David Miller wrote: >> From: David Ahern >> Date: Wed, 26 Oct 2016 17:58:38 -0700 >> >>> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h >>> index 6b62ee9a2f78..73da296c2125 100644 >>>

Re: [PATCH v2 net-next 0/5] Add bpf support to set sk_bound_dev_if

2016-10-31 Thread David Miller
From: David Ahern Date: Wed, 26 Oct 2016 17:58:37 -0700 > The recently added VRF support in Linux leverages the bind-to-device > API for programs to specify an L3 domain for a socket. While > SO_BINDTODEVICE has been around for ages, not every ipv4/ipv6 capable >

[RFC PATCH v2 0/5] ARM64: Add Internal PHY support for Meson GXL

2016-10-31 Thread Neil Armstrong
The Amlogic Meson GXL SoCs have an internal RMII PHY that is muxed with the external RGMII pins. In order to support switching between the two PHYs links, extended registers size for mdio-mux-mmioreg must be added. Finally, the internal PHY is added in the GXL dtsi and support for each board is

Re: [PATCH v2 net-next 1/5] bpf: Refactor cgroups code in prep for new type

2016-10-31 Thread Daniel Mack
On 10/31/2016 05:58 PM, David Miller wrote: > From: David Ahern > Date: Wed, 26 Oct 2016 17:58:38 -0700 > >> diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h >> index 6b62ee9a2f78..73da296c2125 100644 >> --- a/include/uapi/linux/bpf.h >> +++

[RFC PATCH v2 4/5] ARM64: dts: meson-gxl-p23x: Enable ethernet

2016-10-31 Thread Neil Armstrong
Enable Ethernet on the p23x board, pinctrl attribute is only added for the p230 board since the p231 only uses the Internal PHY. Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-gxl-s905d-p230.dts | 16

[RFC PATCH v2 1/5] net: mdio-mux-mmioreg: Add support for 16bit and 32bit register sizes

2016-10-31 Thread Neil Armstrong
In order to support PHY switching on Amlogic GXL SoCs, add support for 16bit and 32bit registers sizes. Signed-off-by: Neil Armstrong --- .../devicetree/bindings/net/mdio-mux-mmioreg.txt | 4 +- drivers/net/phy/mdio-mux-mmioreg.c | 60

[RFC PATCH v2 3/5] ARM64: dts: meson-gxl: Add ethernet nodes with internal PHY

2016-10-31 Thread Neil Armstrong
Add Ethernet node with Internal PHY selection for the Amlogic GXL SoCs Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 45 ++ 1 file changed, 45 insertions(+) diff --git

[RFC PATCH v2 5/5] ARM64: dts: meson-gxl-s905x: Enable internal ethernet PHY

2016-10-31 Thread Neil Armstrong
Signed-off-by: Neil Armstrong --- arch/arm64/boot/dts/amlogic/meson-gxl-s905x.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x.dtsi index 07f0e0b..08237ee 100644

Re: [PATCH v2 net-next 1/5] bpf: Refactor cgroups code in prep for new type

2016-10-31 Thread David Miller
From: David Ahern Date: Wed, 26 Oct 2016 17:58:38 -0700 > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h > index 6b62ee9a2f78..73da296c2125 100644 > --- a/include/uapi/linux/bpf.h > +++ b/include/uapi/linux/bpf.h > @@ -98,7 +98,7 @@ enum bpf_prog_type

[RFC PATCH v2 2/5] net: phy: Add Meson GXL Internal PHY driver

2016-10-31 Thread Neil Armstrong
Add driver for the Internal RMII PHY found in the Amlogic Meson GXL SoCs. This PHY seems to only implement some standard registers and need some workarounds to provide autoneg values from vendor registers. Some magic values are currently used to configure the PHY, and this a temporary setup

Re: Let's do P4

2016-10-31 Thread John Fastabend
On 16-10-31 02:39 AM, Jiri Pirko wrote: > Sun, Oct 30, 2016 at 11:39:05PM CET, alexei.starovoi...@gmail.com wrote: >> On Sun, Oct 30, 2016 at 05:38:36PM +0100, Jiri Pirko wrote: >>> Sun, Oct 30, 2016 at 11:26:49AM CET, tg...@suug.ch wrote: On 10/30/16 at 08:44am, Jiri Pirko wrote: > Sat,

[PATCH 07/12] xen: make use of xenbus_read_unsigned() in xen-netfront

2016-10-31 Thread Juergen Gross
Use xenbus_read_unsigned() instead of xenbus_scanf() when possible. This requires to change the type of some reads from int to unsigned, but these cases have been wrong before: negative values are not allowed for the modified cases. Cc: netdev@vger.kernel.org Signed-off-by: Juergen Gross

[PATCH net-next] sctp: clean up sctp_packet_transmit

2016-10-31 Thread Xin Long
After adding sctp gso, sctp_packet_transmit is a quite big function now. This patch is to extract the codes for packing packet to sctp_packet_pack from sctp_packet_transmit, and add some comments, simplify the err path by freeing auth chunk when freeing packet chunk_list in out path and freeing

[PATCH 00/12] xen: add common function for reading optional value

2016-10-31 Thread Juergen Gross
There are multiple instances of code reading an optional unsigned parameter from Xenstore via xenbus_scanf(). Instead of repeating the same code over and over add a service function doing the job and replace the call of xenbus_scanf() with the call of the new function where appropriate. Juergen

[PATCH 06/12] xen: make use of xenbus_read_unsigned() in xen-netback

2016-10-31 Thread Juergen Gross
Use xenbus_read_unsigned() instead of xenbus_scanf() when possible. This requires to change the type of some reads from int to unsigned, but these cases have been wrong before: negative values are not allowed for the modified cases. Cc: wei.l...@citrix.com Cc: paul.durr...@citrix.com Cc:

Re: [PATCH v7 5/6] net: ipv4, ipv6: run cgroup eBPF egress programs

2016-10-31 Thread David Miller
From: Daniel Mack Date: Tue, 25 Oct 2016 12:14:13 +0200 > @@ -312,6 +314,13 @@ int ip_mc_output(struct net *net, struct sock *sk, > struct sk_buff *skb) > skb->dev = dev; > skb->protocol = htons(ETH_P_IP); > > + ret = cgroup_bpf_run_filter(sk_to_full_sk(sk),

Re: Ethernet not working on a different SoC with same eth HW

2016-10-31 Thread Mason
On 31/10/2016 16:53, Andrew Lunn wrote: >> I'll add a log for the request_irq call. > > And take a look at /proc/interrupts You're right, there does seem to be something wrong with the interrupts. # cat /proc/interrupts CPU0 20: 26285 GIC-0 29 Edge twd IPI0:

Re: [PATCH net-next 3/4] bpf: BPF for lightweight tunnel encapsulation

2016-10-31 Thread Tom Herbert
On Mon, Oct 31, 2016 at 8:06 AM, Thomas Graf wrote: > On 10/31/16 at 07:17am, Tom Herbert wrote: >> On Mon, Oct 31, 2016 at 5:59 AM, Thomas Graf wrote: >> > Noticed while implementing this: How does ILA ensure that dst_output() >> > is not invoked in a circular

Re: Ethernet not working on a different SoC with same eth HW

2016-10-31 Thread Andrew Lunn
> I'll add a log for the request_irq call. And take a look at /proc/interrupts Andrew

[no subject]

2016-10-31 Thread Debra_Farmer/SSB/HIDOE
I am Mrs. Gu Kailai and i intend to make a DONATION. Contact my personal E-mail Via: mrsgukai...@post.cz for more details:

Re: Ethernet not working on a different SoC with same eth HW

2016-10-31 Thread Mason
On 31/10/2016 16:37, Andrew Lunn wrote: >> The regnum=5,4,1,1,a,9 logs keep repeating, endlessly. >> Is that expected? > > Yes, that is expected, if you are not using interrupts. The phylib > state machine polls the state of the PHY once per second to see if > there has been a link up/down.

Re: Ethernet not working on a different SoC with same eth HW

2016-10-31 Thread Andrew Lunn
On Mon, Oct 31, 2016 at 04:29:25PM +0100, Mason wrote: > Hello everyone, > > I'm using these net drivers: > > drivers/net/ethernet/aurora/nb8800.c > drivers/net/phy/at803x.c > > With a smp8758 board, they work great. > I've been trying to use them on a different board: > > same eth PHY

Re: Ethernet not working on a different SoC with same eth HW

2016-10-31 Thread Andrew Lunn
> The regnum=5,4,1,1,a,9 logs keep repeating, endlessly. > Is that expected? Yes, that is expected, if you are not using interrupts. The phylib state machine polls the state of the PHY once per second to see if there has been a link up/down. Andrew

Ethernet not working on a different SoC with same eth HW

2016-10-31 Thread Mason
Hello everyone, I'm using these net drivers: drivers/net/ethernet/aurora/nb8800.c drivers/net/phy/at803x.c With a smp8758 board, they work great. I've been trying to use them on a different board: same eth PHY (Atheros AR8035) same eth MAC (Aurora SSN8800) different SoC (same base

Re: [net-next PATCH RFC 04/26] arch/arm: Add option to skip sync on DMA map and unmap

2016-10-31 Thread Alexander Duyck
On Mon, Oct 31, 2016 at 3:20 AM, Russell King - ARM Linux wrote: > On Mon, Oct 24, 2016 at 08:04:47AM -0400, Alexander Duyck wrote: >> The use of DMA_ATTR_SKIP_CPU_SYNC was not consistent across all of the DMA >> APIs in the arch/arm folder. This change is meant to correct

Re: nfs NULL-dereferencing in net-next

2016-10-31 Thread Jakub Kicinski
On Thu, 27 Oct 2016 06:50:22 +, Yotam Gigi wrote: > >-Original Message- > >From: Anna Schumaker [mailto:anna.schuma...@netapp.com] > >Sent: Wednesday, October 26, 2016 9:17 PM > >To: Jakub Kicinski > >Cc: Yotam Gigi ; Andy Adamson

Re: [PATCH net-next] udp: do fwd memory scheduling on dequeue

2016-10-31 Thread Eric Dumazet
On Mon, 2016-10-31 at 16:02 +0100, Paolo Abeni wrote: > > No problem at all with incremental patches ;-) > > In our experiment, touching udp_memory_allocated is only a part of the > the source of contention, with the biggest source of contention being > the sk_rmem_alloc update - which happens

[PATCH] ath9k_htc: fix minor mistakes in dev_err messages

2016-10-31 Thread Colin King
From: Colin Ian King Add missing space in a dev_err message and join wrapped text so it does not span multiple lines. Fix spelling mistake on "unknown". Signed-off-by: Colin Ian King --- drivers/net/wireless/ath/ath9k/htc_hst.c | 6 +++---

Re: [PATCH net-next 3/4] bpf: BPF for lightweight tunnel encapsulation

2016-10-31 Thread Thomas Graf
On 10/31/16 at 07:17am, Tom Herbert wrote: > On Mon, Oct 31, 2016 at 5:59 AM, Thomas Graf wrote: > > Noticed while implementing this: How does ILA ensure that dst_output() > > is not invoked in a circular manner? > > > > dstA->output() -> dstB->otuput() -> dstA->output() -> ... >

Re: [PATCH (net.git)] net: phy: at803x: disable by default the hibernation feature

2016-10-31 Thread David Miller
From: Giuseppe Cavallaro Date: Tue, 25 Oct 2016 10:31:22 +0200 > These PHY chips, by default, enable the hibernation feature > so, if the cable is unplugged the device enters in hibernation > mode after some time. This can generate problems on some cases. > It has been

Re: [PATCH net-next] udp: do fwd memory scheduling on dequeue

2016-10-31 Thread Paolo Abeni
On Sat, 2016-10-29 at 05:43 -0700, Eric Dumazet wrote: > On Sat, 2016-10-29 at 10:17 +0200, Paolo Abeni wrote: > > > Thank you for working on this. > > > > I just gave a very quick look (the WE has started, children are > > screaming ;-), overall the implementation seems quite similar to our >

[PATCH net-next] genetlink: fix error return code in genl_register_family()

2016-10-31 Thread Wei Yongjun
From: Wei Yongjun Fix to return error code -ENOMEM from the idr_alloc() error handling case instead of 0, as done elsewhere in this function. Fixes: 2ae0f17df1cd ("genetlink: use idr to track families") Signed-off-by: Wei Yongjun ---

Re: [PATCH net-next] net: add an ioctl to get a socket network namespace

2016-10-31 Thread David Miller
From: Andrei Vagin Date: Mon, 24 Oct 2016 18:29:13 -0700 > From: Andrey Vagin > > Each socket operates in a network namespace where it has been created, > so if we want to dump and restore a socket, we have to know its network > namespace. > > We have a

Re: [PATCH net-next v2 1/1] driver: tun: Use new macro SOCK_IOC_TYPE instead of literal number 0x89

2016-10-31 Thread David Miller
From: f...@ikuai8.com Date: Thu, 27 Oct 2016 09:05:22 +0800 > From: Gao Feng > > The current codes use _IOC_TYPE(cmd) == 0x89 to check if the cmd is one > socket ioctl command like SIOCGIFHWADDR. But the literal number 0x89 may > confuse readers. So create one macro

Re: mv643xx_eth.c merge gone bad...

2016-10-31 Thread David Miller
From: Andrew Lunn Date: Mon, 31 Oct 2016 14:35:38 +0100 > On Mon, Oct 31, 2016 at 09:12:06AM -0400, David Miller wrote: >> From: Andrew Lunn >> Date: Mon, 31 Oct 2016 12:33:49 +0100 >> >> > The merge of commit 27058af401e49d88a905df000dd26f443fcfa8ce for >> >

<    1   2   3   >