Re: Initial thoughts on TXDP

On Thu, 1 Dec 2016 11:51:42 -0800 Tom Herbert wrote: > On Wed, Nov 30, 2016 at 6:44 PM, Florian Westphal wrote: > > Tom Herbert wrote: [...] > >> - Call into TCP/IP stack with page data directly from driver-- no > >> skbuff

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

Hi! > >Well, if you have a workload that sends and receive packets, it tends > >to work ok, as you do tx_clean() in stmmac_poll(). My workload is not > >like that -- it is "sending packets at 3MB/sec, receiving none". So > >the stmmac_tx_timer() is rescheduled and rescheduled and rescheduled, >

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

On 12/2/2016 1:32 PM, Pavel Machek wrote: Hi! Well, if you have a workload that sends and receive packets, it tends to work ok, as you do tx_clean() in stmmac_poll(). My workload is not like that -- it is "sending packets at 3MB/sec, receiving none". So the stmmac_tx_timer() is rescheduled and

[PATCH 1/6] net: stmmac: return error if no DMA configuration is found

From: Niklas Cassel All drivers except pci glue layer calls stmmac_probe_config_dt. stmmac_probe_config_dt does a kzalloc dma_cfg. pci glue layer does kzalloc dma_cfg explicitly, so all current drivers does a kzalloc dma_cfg. Return an error if no DMA configuration is

[PATCH 5/6] net: stmmac: add support for independent DMA pbl for tx/rx

From: Niklas Cassel GMAC and newer supports independent programmable burst lengths for DMA tx/rx. Add new optional devicetree properties representing this. To be backwards compatible, snps,pbl will still be valid, but snps,txpbl/snps,rxpbl will override the value in

[PATCH 6/6] net: smmac: allow configuring lower pbl values

From: Niklas Cassel The driver currently always sets the PBLx8/PBLx4 bit, which means that the pbl values configured via the pbl/txpbl/rxpbl DT properties are always multiplied by 8/4 in the hardware. In order to allow the DT to configure lower pbl values, while at the

[PATCH 2/6] net: stmmac: simplify the common DMA init API

From: Niklas Cassel Use struct stmmac_dma_cfg *dma_cfg as an argument rather than using all the struct members as individual arguments. Signed-off-by: Niklas Cassel --- drivers/net/ethernet/stmicro/stmmac/common.h| 4 ++--

[PATCH 4/6] net: stmmac: dwmac1000: fix define DMA_BUS_MODE_RPBL_MASK

From: Niklas Cassel DMA_BUS_MODE_RPBL_MASK is really 6 bits, just like DMA_BUS_MODE_PBL_MASK. Signed-off-by: Niklas Cassel --- drivers/net/ethernet/stmicro/stmmac/dwmac1000.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [flamebait] xdp, well meaning but pointless

On 02.12.2016 11:24, Jesper Dangaard Brouer wrote: > On Thu, 1 Dec 2016 13:51:32 -0800 > Tom Herbert wrote: > The technical plenary at last IETF on Seoul a couple of weeks ago was exclusively focussed on DDOS in light of the recent attack against Dyn. There

Re: Initial thoughts on TXDP

On Thu, 1 Dec 2016 23:47:44 +0100 Hannes Frederic Sowa wrote: > Side note: > > On 01.12.2016 20:51, Tom Herbert wrote: > >> > E.g. "mini-skb": Even if we assume that this provides a speedup > >> > (where does that come from? should make no difference if a 32 or > >>

Re: arp_filter and IPv6 ND

On 02.12.2016 13:51, Saku Ytti wrote: > net.ipv4.conf.all.arp_filter appears not to have IPv6 counter part. > Or am I missing something? That is Linux does answer to ND queries for > unrelated interfaces by default, and I can't seem to find way to turn > that off. May I ask why you want to turn

Re: [PATCH] stmmac: reduce code duplication getting basic descriptors

Hi Pavel, On 11/28/2016 01:17 PM, Pavel Machek wrote: Remove code duplication getting basic descriptors. I agree with your patch, it will make code easier to understand. After fix kbuild issue you can add my Acked-by; Regards Alex Signed-off-by: Pavel Machek diff --git

net/can: warning in raw_setsockopt/__alloc_pages_slowpath

Hi! I've got the following error report while running the syzkaller fuzzer. A reproducer is attached. On commit d8e435f3ab6fea2ea324dce72b51dd7761747523 (Nov 26). [ cut here ] WARNING: CPU: 0 PID: 4009 at mm/page_alloc.c:3511 __alloc_pages_slowpath+0x3d4/0x1bf0 Modules

Re: [PATCH net v2] igb: re-assign hw address pointer on reset after PCI error

On 11/10/2016 04:46 PM, Guilherme G. Piccoli wrote: > Whenever the igb driver detects the result of a read operation returns > a value composed only by F's (like 0x), it will detach the > net_device, clear the hw_addr pointer and warn to the user that adapter's > link is lost - those steps

[PATCH 3/6] net: stmmac: stmmac_platform: fix parsing of DT binding

From: Niklas Cassel commit 64c3b252e9fc ("net: stmmac: fixed the pbl setting with DT") changed the parsing of the DT binding. Before 64c3b252e9fc, snps,fixed-burst and snps,mixed-burst were parsed regardless if the property snps,pbl existed or not. After the commit,

[PATCH iproute2 V5 3/3] tc/act_tunnel: Introduce ip tunnel action

This action could be used before redirecting packets to a shared tunnel device, or when redirecting packets arriving from a such a device. The 'unset' action is optional. It is used to explicitly unset the metadata created by the tunnel device during decap. If not used, the metadata will be

[PATCH iproute2 V5 2/3] tc/cls_flower: Classify packet in ip tunnels

Introduce classifying by metadata extracted by the tunnel device. Outer header fields - source/dest ip and tunnel id, are extracted from the metadata when classifying. For example, the following will add a filter on the ingress Qdisc of shared vxlan device named 'vxlan0'. To forward packets with

[PATCH iproute2 V5 0/3] tc: Support for ip tunnel metadata set/unset/classify

Hi, This short series adds support for matching and setting metadata for ip tunnel shared device using the TC system, introduced in kernel 4.9 [1]. Applied and tested on top of commit b6c7fc61faab ("ss: print new tcp_info fields: busy, rwnd-limited, sndbuf-limited times") Example usage: $ tc

[PATCH iproute2 V5 1/3] libnetlink: Introduce rta_getattr_be*()

Add the utility functions rta_getattr_be16() and rta_getattr_be32(), and change existing code to use it. Signed-off-by: Amir Vadai --- bridge/fdb.c | 4 ++-- include/libnetlink.h | 9 + ip/iplink_geneve.c | 2 +- ip/iplink_vxlan.c| 2 +- tc/f_flower.c

Re: [PATCH net v3] tipc: check minimum bearer MTU

On 12/02/2016 04:33 PM, Michal Kubecek wrote: Qian Zhang (张谦) reported a potential socket buffer overflow in tipc_msg_build() which is also known as CVE-2016-8632: due to insufficient checks, a buffer overflow can occur if MTU is too short for even tipc headers. As anyone can set device MTU in a

Re: [PATCH 5/7] Documentation: DT: net: cpsw: allow to specify descriptors pool size

On Thu, Dec 01, 2016 at 05:34:30PM -0600, Grygorii Strashko wrote: > Add optional property "descs_pool_size" to specify buffer descriptor's > pool size. The "descs_pool_size" should define total number of CPDMA > CPPI descriptors to be used for both ingress/egress packets > processing. If not

[PATCH iproute2/net-next] ss: initialise variables outside of for loop

Initialise for loops outside of for loops. GCC flags this as being out of spec unless C99 or C11 mode is used. With this change the entire tree appears to compile cleanly with -Wall. $ gcc --version gcc (Debian 4.9.2-10) 4.9.2 ... $ make ... ss.c: In function ‘unix_show_sock’: ss.c:3128:4:

arp_filter and IPv6 ND

Hey, net.ipv4.conf.all.arp_filter appears not to have IPv6 counter part. Or am I missing something? That is Linux does answer to ND queries for unrelated interfaces by default, and I can't seem to find way to turn that off. Is it proper maintainership to accept changes to single protocol,

Re: [PATCH net] fib_trie: Avoid expensive update of suffix length when not required

On 01/12/16 18:29, Alexander Duyck wrote: On Wed, Nov 30, 2016 at 4:27 PM, Robert Shearman wrote: On 29/11/16 23:14, Alexander Duyck wrote: On Tue, Nov 29, 2016 at 9:46 AM, Robert Shearman Fixes: 5405afd1a306 ("fib_trie: Add tracking value for

Re: [PATCH 2/7] net: ethernet: ti: cpdma: fix desc re-queuing

On Thu, Dec 01, 2016 at 05:34:27PM -0600, Grygorii Strashko wrote: > The currently processing cpdma descriptor with EOQ flag set may > contain two values in Next Descriptor Pointer field: > - valid pointer: means CPDMA missed addition of new desc in queue; It shouldn't happen in normal

Re: net/can: warning in raw_setsockopt/__alloc_pages_slowpath

On 12/02/2016 01:43 PM, Andrey Konovalov wrote: > Hi! > > I've got the following error report while running the syzkaller fuzzer. > > A reproducer is attached. > > On commit d8e435f3ab6fea2ea324dce72b51dd7761747523 (Nov 26). > > [ cut here ] > WARNING: CPU: 0 PID: 4009

Aw: Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

Hi, > > There's nothing that protect stmmac_poll() from running concurently > with stmmac_dma_interrupt(), right? > could it be that there is also another issue concerned locking?: The tx completion handler takes the xmit_lock in case that the netif_queue is stopped. This is AFAICS

[PATCH net-next 4/4] bpf: xdp: Add XDP example for head adjustment

The XDP prog checks if the incoming packet matches any VIP:PORT combination in the BPF hashmap. If it is, it will encapsulate the packet with a IPv4/v6 header as instructed by the value of the BPF hashmap and then XDP_TX it out. The VIP:PORT -> IP-Encap-Info can be specified by the cmd args of

Re: bpf bounded loops. Was: [flamebait] xdp

On Fri, Dec 02, 2016 at 11:42:15AM -0800, John Fastabend wrote: > >> As far as pattern search for DNS packets... > >> it was requested by Cloudflare guys back in March: > >> https://github.com/iovisor/bcc/issues/471 > >> and it is useful for several tracing use cases as well. > >> Unfortunately no

Re: [PATCH net-next] liquidio: 'imply' ptp instead of 'select'

Hi Arnd, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Arnd-Bergmann/liquidio-imply-ptp-instead-of-select/20161203-084019 config: x86_64-allmodconfig compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: make ARCH=x86_64 allmodconfig

Re: [PATCH] net: wireless: realtek: constify rate_control_ops structures

On Sat, Dec 3, 2016 at 2:09 AM, Larry Finger wrote: > On 12/02/2016 03:50 AM, Bhumika Goyal wrote: >> >> The structures rate_control_ops are only passed as an argument to the >> functions ieee80211_rate_control_{register/unregister}. This argument is >> of type const,

Re: [PATCH 2/3] uapi: export tc_skbmod.h

Hi Stephen, [auto build test ERROR on linus/master] [also build test ERROR on v4.9-rc7] [cannot apply to next-20161202] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Stephen-Hemminger/UAPI

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

Hello On 11/24/2016 10:25 PM, Pavel Machek wrote: Hi! I'm debugging strange delays during transmit in stmmac driver. They seem to be present in 4.4 kernel (and older kernels, too). Workload is burst of udp packets being sent, pause, burst of udp packets, ... ... 4.9-rc6 still has the

Re: [patch net-next v3 11/12] mlxsw: spectrum_router: Request a dump of FIB tables during init

On Fri, Dec 02, 2016 at 12:27:25AM +0100, Hannes Frederic Sowa wrote: > I really like that. Would you mind adding this? Yes. I'll send another version to Jiri today after testing and hopefully we can submit today / tomorrow. I think Linus is still undecided about -rc8 and I would like to get this

[PATCH v2] netfilter: avoid warn and OOM killer on vmalloc call

Andrey Konovalov reported that this vmalloc call is based on an userspace request and that it's spewing traces, which may flood the logs and cause DoS if abused. Florian Westphal also mentioned that this call should not trigger OOM killer. This patch brings the vmalloc call in sync to kmalloc

[PATCH net v2] tcp: warn on bogus MSS and try to amend it

There have been some reports lately about TCP connection stalls caused by NIC drivers that aren't setting gso_size on aggregated packets on rx path. This causes TCP to assume that the MSS is actually the size of the aggregated packet, which is invalid. Although the proper fix is to be done at

Re: [PATCH 1/2] net: stmmac: avoid Camelcase naming

Hello Corentin patches look ok, I just wonder if you tested it in case of the stmmac is connected to a transceiver. Let me consider it a critical part of the driver to properly work. Regards Peppe On 12/1/2016 4:19 PM, Corentin Labbe wrote: This patch simply rename regValue to value, like it

Re: pull request (net-next): ipsec-next 2016-12-01

On Thu, Dec 01, 2016 at 11:45:16AM -0500, David Miller wrote: > From: Steffen Klassert > Date: Thu, 1 Dec 2016 12:48:04 +0100 > > > git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next.git > > master > > > > for you to fetch changes up to

Re: [RFC PATCH net-next v2] ipv6: implement consistent hashing for equal-cost multipath routing

On 11/30/2016 05:04 AM, Tom Herbert wrote: > This is a lot of code to make ECMP work better. Can you be more > specific as to what the "issues" are? Assuming this is just the > transient packet reorder that happens in one link flap I am wondering > if this complexity is justified. Unconsistent

[PATCH] net: wireless: realtek: constify rate_control_ops structures

The structures rate_control_ops are only passed as an argument to the functions ieee80211_rate_control_{register/unregister}. This argument is of type const, so rate_control_ops having this property can also be declared as const. Done using Coccinelle: @r1 disable optional_qualifier @ identifier

[PATCH net v3] tipc: check minimum bearer MTU

Qian Zhang (张谦) reported a potential socket buffer overflow in tipc_msg_build() which is also known as CVE-2016-8632: due to insufficient checks, a buffer overflow can occur if MTU is too short for even tipc headers. As anyone can set device MTU in a user/net namespace, this issue can be abused by

Re: stmmac: turn coalescing / NAPI off in stmmac

On 12/1/2016 11:48 PM, Pavel Machek wrote: @@ -2771,12 +2771,8 @@ static netdev_features_t stmmac_fix_features(struct net_device *dev, features &= ~NETIF_F_CSUM_MASK; /* Disable tso if asked by ethtool */ - if ((priv->plat->tso_en) && (priv->dma_cap.tsoen)) { -

Re: [PATCH 1/2] net: stmmac: avoid Camelcase naming

On Fri, Dec 02, 2016 at 09:44:48AM +0100, Giuseppe CAVALLARO wrote: > Hello Corentin > > patches look ok, I just wonder if you tested it in case of > the stmmac is connected to a transceiver. Let me consider it > a critical part of the driver to properly work. > > Regards > Peppe > I tested it

Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers

Hi Florian sorry for my delay. On 11/24/2016 7:23 PM, Florian Fainelli wrote: +Peppe, Le 24/11/2016 à 07:38, Andrew Lunn a écrit : As for enabling advertising and correct working of cpsw do you mean it would be better to disable EEE in any PHY on cpsw initialization as long as cpsw doesn't

Re: [PATCH 4/6] net: ethernet: ti: cpts: add ptp pps support

On Wed, Nov 30, 2016 at 11:17:38PM +0100, Richard Cochran wrote: > On Wed, Nov 30, 2016 at 02:43:57PM -0600, Grygorii Strashko wrote: > > Sry, but this is questionable - code for pps comes from TI internal > > branches (SDK releases) where it survived for a pretty long time. Actually, there is a

Re: [flamebait] xdp, well meaning but pointless

On Thu, 1 Dec 2016 13:51:32 -0800 Tom Herbert wrote: > >> The technical plenary at last IETF on Seoul a couple of weeks ago was > >> exclusively focussed on DDOS in light of the recent attack against > >> Dyn. There were speakers form Cloudflare and Dyn. The Cloudflare > >>

[iproute PATCH v2 10/18] ss: Make user_ent_hash_build_init local to user_ent_hash_build()

By having it statically defined, there is no need for it to be global. Signed-off-by: Phil Sutter --- misc/ss.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index 97fcfd4a85548..44386c82c7578 100644 --- a/misc/ss.c +++ b/misc/ss.c @@

[iproute PATCH v2 16/18] ss: Make sstate_name local to sock_state_print()

Signed-off-by: Phil Sutter --- misc/ss.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index e82c416b5fa72..8439f473d7f7b 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -655,21 +655,6 @@ static unsigned long long

[PATCH net-next 1/2] samples, bpf: Refactor test_current_task_under_cgroup - separate out helpers

This patch modifies test_current_task_under_cgroup_user. The test has several helpers around creating a temporary environment for cgroup testing, and moving the current task around cgroups. This set of helpers can then be used in other tests. Signed-off-by: Sargun Dhillon ---

[PATCH net-next 2/2] samples, bpf: Add automated test for cgroup filter attachments

This patch adds the sample program test_cgrp2_attach2. This program is similar to test_cgrp2_attach, but it performs automated testing of the cgroupv2 BPF attached filters. It runs the following checks: * Simple filter attachment * Application of filters to child cgroups * Overriding filters on

[iproute PATCH v2 00/18] ss: Minor code review

This is a series of misc changes to ss code which happened as fall-out when working on a unified output formatter (still unfinished). Changes since v1: - Rebased onto current upstream, resolved conflicts in patch 4 generated by previously added SCTP socket support. Phil Sutter (18): ss: Mark

[iproute PATCH v2 14/18] ss: Get rid of single-fielded struct snmpstat

A struct with only a single field does not make much sense. Besides that, it was used by print_summary() only. Signed-off-by: Phil Sutter --- misc/ss.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index

[PATCH net-next 0/2] samples, bpf: Refactor; Add automated tests for cgroups

These two patches are around refactoring out some old, reusable code from the existing test_current_task_under_cgroup_user test, and adding a new, automated test. There is some generic cgroupsv2 setup & cleanup code, given that most environment still don't have it setup by default. With this

[iproute PATCH v2 17/18] ss: Make sstate_namel local to scan_state()

Signed-off-by: Phil Sutter --- misc/ss.c | 29 ++--- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index 8439f473d7f7b..c72aba7e65ad3 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -666,21 +666,6 @@ static const char

Re: stmmac: turn coalescing / NAPI off in stmmac

Hi! > >Anyway... since you asked. I belive I have way to disable NAPI / tx > >coalescing in the driver. Unfortunately, locking is missing on the rx > >path, and needs to be extended to _irqsave variant on tx path. > > I have just replied to a previous thread about that... Yeah, please reply to

[iproute PATCH v2 05/18] ss: introduce proc_ctx_print()

This consolidates identical code in three places. While the function name is not quite perfect as there is different proc_ctx printing code in netlink_show_one() as well, I sadly didn't find a more suitable one. Signed-off-by: Phil Sutter --- misc/ss.c | 49

Re: [PATCH 1/4] bindings: net: stmmac: correct note about TSO

On 11/23/2016 3:24 PM, Niklas Cassel wrote: From: Niklas Cassel snps,tso was previously placed under AXI BUS Mode parameters, suggesting that the property should be in the stmmac-axi-config node. TSO (TCP Segmentation Offloading) has nothing to do with AXI BUS Mode

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

Hi Pavel On 12/2/2016 9:45 AM, Pavel Machek wrote: Hi! 1 HZ, which is the lowest granularity of non-highres timers in the kernel, is variable as well as already too large of a delay for effective TX coalescing. I seriously think that the TX coalescing support should be ripped out or disabled

[PATCH/RFC net-next 0/2] net/sched: cls_flower: Support matching on ICMP

Hi, this series add supports for matching on ICMP type and code to cls_flower. This is modeled on existing support for matching on L4 ports. The updates to the dissector are intended to allow for code and storage re-use. Simon Horman (2): flow dissector: ICMP support net/sched: cls_flower:

Re: [PATCH] stmmac: simplify flag assignment

+ Alex On 11/30/2016 12:44 PM, Pavel Machek wrote: Simplify flag assignment. Signed-off-by: Pavel Machek diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index ed20668..0b706a7 100644 ---

Re: [PATCH net 0/7] net: stmmac: fix probe error handling and phydev leaks

On 11/30/2016 3:29 PM, Johan Hovold wrote: This series fixes a number of issues with the stmmac-driver probe error handling, which for example left clocks enabled after probe failures. The final patch fixes a failure to deregister and free any fixed-link PHYs that were registered during probe

Re: [PATCH v3 net-next 3/3] openvswitch: Fix skb->protocol for vlan frames.

On Thu, 1 Dec 2016 12:31:09 -0800, Pravin Shelar wrote: > On Wed, Nov 30, 2016 at 6:30 AM, Jiri Benc wrote: > > I'm not opposed to changing this but I'm afraid it needs much deeper > > review. Because with this in place, no core kernel functions that > > depend on skb->protocol

Re: [PATCH v3 net-next 3/3] openvswitch: Fix skb->protocol for vlan frames.

On Fri, 2 Dec 2016 10:42:02 +0100, Jiri Benc wrote: > On Thu, 1 Dec 2016 12:31:09 -0800, Pravin Shelar wrote: > It's not set exactly by the caller, because that's what this patch is > removing. It is set by whoever handed over the packet to openvswitch. > The point is we don't know *what* it is

Re: [PATCH 1/2] net: stmmac: avoid Camelcase naming

On 12/2/2016 9:58 AM, Corentin Labbe wrote: On Fri, Dec 02, 2016 at 09:44:48AM +0100, Giuseppe CAVALLARO wrote: Hello Corentin patches look ok, I just wonder if you tested it in case of the stmmac is connected to a transceiver. Let me consider it a critical part of the driver to properly work.

RE: [PATCH] net:phy fix driver reference count error when attach and detach phy device

From: Mao Wenan > Sent: 30 November 2016 10:23 > The nic in my board use the phy dev from marvell, and the system will > load the marvell phy driver automatically, but when I remove the phy > drivers, the system immediately panic: > Call trace: > [ 2582.834493] [] phy_state_machine+0x3c/0x438 [ >

Re: [patch] net: renesas: ravb: unintialized return value

On Thu, Dec 01, 2016 at 11:57:44PM +0300, Dan Carpenter wrote: > We want to set the other "err" variable here so that we can return it > later. My version of GCC misses this issue but I caught it with a > static checker. > Fixes: 9f70eb339f52 ("net: ethernet: renesas: ravb: fix fixed-link phydev

Re: [PATCH iproute2 net-next 2/4] tc: flower: document SCTP ip_proto

On Thu, Dec 01, 2016 at 10:50:10AM -0800, Stephen Hemminger wrote: > On Tue, 29 Nov 2016 16:51:31 +0100 > Simon Horman wrote: > > > Add SCTP ip_proto to help text and man page. > > > > Signed-off-by: Simon Horman > > Sorry doesn't apply

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

Hi! > >>1 HZ, which is the lowest granularity of non-highres timers in the > >>kernel, is variable as well as already too large of a delay for > >>effective TX coalescing. > >> > >>I seriously think that the TX coalescing support should be ripped out > >>or disabled entirely until it is

[[PATCH iproute2/net-next v2] 2/4] tc: flower: document SCTP ip_proto

Add SCTP ip_proto to help text and man page. Signed-off-by: Simon Horman --- man/man8/tc-flower.8 | 14 +++--- tc/f_flower.c| 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/man/man8/tc-flower.8 b/man/man8/tc-flower.8 index

[[PATCH iproute2/net-next v2] 3/4] tc: flower: correct name of ip_proto parameter to flower_parse_port()

This corrects a typo. Fixes: a1fb0d484237 ("tc: flower: Support matching on SCTP ports") Signed-off-by: Simon Horman --- tc/f_flower.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tc/f_flower.c b/tc/f_flower.c index

[[PATCH iproute2/net-next v2] 4/4] tc: flower: make use of flower_port_attr_type() safe and silent

Make use of flower_port_attr_type() safe: * flower_port_attr_type() may return a valid index into tb[] or -1. Only access tb[] in the case of the former. * Do not access null entries in tb[] Also make usage silent - it is valid for ip_proto to be invalid, for example if it is not specified as

[[PATCH iproute2/net-next v2] 0/4] tc: flower: SCTP and other port fixes

Hi Stephen, this short series: * Makes some improvements to the documentation of flower; A follow-up to recent work by Paul Blakey and myself. * Corrects some errors introduced when SCTP port matching support was recently added. Changes since v2: * Rebase Simon Horman (4): tc: flower:

[[PATCH iproute2/net-next v2] 1/4] tc: flower: remove references to eth_type in manpage

Remove references to eth_type and ether_type (spelling error) in the tc flower manpage. Also correct formatting of boldface text with whitespace. Cc: Paul Blakey Signed-off-by: Simon Horman --- man/man8/tc-flower.8 | 23 +++

Re: [PATCH v3 net-next 2/3] openvswitch: Use is_skb_forwardable() for length check.

On Thu, 1 Dec 2016 11:50:00 -0800, Pravin Shelar wrote: > This is not changing any behavior compared to current OVS vlan checks. > Single vlan header is not considered for MTU check. It is changing it. Consider the case when there's an interface with MTU 1500 forwarding to an interface with MTU

Re: [PATCH net] tcp: warn on bogus MSS and try to amend it

On Thu, Dec 01, 2016 at 03:29:49PM -0500, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Wed, 30 Nov 2016 11:14:32 -0200 > > > There have been some reports lately about TCP connection stalls caused > > by NIC drivers that aren't setting gso_size on

[iproute PATCH v2 04/18] ss: Use sockstat->type in all socket types

Unix sockets used that field already to hold info about the socket type. By replicating this approach in all other socket types, we can get rid of protocol parameter in inet_stats_print() and have sock_state_print() figure things out by itself. Signed-off-by: Phil Sutter ---

[iproute PATCH v2 07/18] ss: Eliminate unix_use_proc()

This function is used only at a single place anymore, so replace the call to it by it's content, which makes that specific part of unix_show() consistent with e.g. tcp_show(). Signed-off-by: Phil Sutter --- misc/ss.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-)

[iproute PATCH v2 12/18] ss: Make slabstat_ids local to get_slabstat()

Signed-off-by: Phil Sutter --- misc/ss.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index 3662f5f4861c7..c498478421190 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -601,21 +601,19 @@ struct slabstat { static struct

[iproute PATCH v2 15/18] ss: Make unix_state_map local to unix_show()

Also make it const, since there won't be any write access happening. Signed-off-by: Phil Sutter --- misc/ss.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index c7818eadf9e75..e82c416b5fa72 100644 --- a/misc/ss.c +++ b/misc/ss.c @@

[iproute PATCH v2 08/18] ss: Turn generic_proc_open() wrappers into macros

Signed-off-by: Phil Sutter --- misc/ss.c | 89 ++- 1 file changed, 19 insertions(+), 70 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index ad38eb97b0055..71040a82ca6b1 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -327,76

[iproute PATCH v2 06/18] ss: Drop list traversal from unix_stats_print()

Although this complicates the dedicated procfs-based code path in unix_show() a bit, it's the only sane way to get rid of unix_show_sock() output diverging from other socket types in that it prints all socket details in a new line. As a side effect, it allows to eliminate all procfs specific code

[iproute PATCH v2 01/18] ss: Mark fall through in arg parsing switch()

As there is a certain chance of overlooking this, better add a comment to draw readers' attention. Signed-off-by: Phil Sutter --- misc/ss.c | 1 + 1 file changed, 1 insertion(+) diff --git a/misc/ss.c b/misc/ss.c index 07dcd8c209c04..469721fd9aee3 100644 --- a/misc/ss.c +++

Re: [PATCH net-next 2/3] net/act_pedit: Support using offset relative to the conventional network headers

On Thu, Dec 01, 2016 at 02:41:14PM -0500, David Miller wrote: > From: Amir Vadai > Date: Wed, 30 Nov 2016 11:09:27 +0200 > > > @@ -119,18 +119,45 @@ static bool offset_valid(struct sk_buff *skb, int > > offset) > > return true; > > } > > > > +static int

[iproute PATCH v2 02/18] ss: Drop empty lines in UDP output

When dumping UDP sockets and show_tcpinfo (-i) is active but not show_mem (-m), print_tcpinfo() does not output anything leading to an empty line being printed after every socket. Fix this by skipping the call to print_tcpinfo() and the previous newline printing in that case. Signed-off-by: Phil

[iproute PATCH v2 18/18] ss: unix_show: No need to initialize members of calloc'ed structs

Signed-off-by: Phil Sutter --- misc/ss.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index c72aba7e65ad3..f23aa6be33174 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -3066,8 +3066,6 @@ static int unix_show(struct filter *f) if (!(u =

[iproute PATCH v2 13/18] ss: Get rid of useless goto in handle_follow_request()

Signed-off-by: Phil Sutter --- misc/ss.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index c498478421190..ec71c21ce6a4a 100644 --- a/misc/ss.c +++ b/misc/ss.c @@ -3632,7 +3632,7 @@ static int generic_show_sock(const struct

[iproute PATCH v2 11/18] ss: Make some variables function-local

addrp_width and screen_width are used in main() only, so no need to have them globally available. Signed-off-by: Phil Sutter --- misc/ss.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index 44386c82c7578..3662f5f4861c7 100644 ---

[iproute PATCH v2 09/18] ss: Make tmr_name local to tcp_timer_print()

It's used only there, so no need to have it globally defined. Signed-off-by: Phil Sutter --- misc/ss.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/misc/ss.c b/misc/ss.c index 71040a82ca6b1..97fcfd4a85548 100644 --- a/misc/ss.c +++

[iproute PATCH v2 03/18] ss: Add missing tab when printing UNIX details

When dumping UNIX sockets and show_details is active but not show_mem (ss -xne), the socket details are printed without being prefixed by tab. Fix this by printing the tab character when either one of '-e' or '-m' has been specified. Signed-off-by: Phil Sutter --- misc/ss.c | 4

[PATCH 2/2] can: peak: Add support for PCAN-USB X6 USB interface

From: Stephane Grosjean This adds support for PEAK-System PCAN-USB X6 USB to CAN interface. The CAN FD adapter PCAN-USB X6 allows the connection of up to 6 CAN FD or CAN networks to a computer via USB. The interface is installed in an aluminum profile casing and is

[PATCH 1/2] can: peak: Fix bittiming fields size in bits

From: Stephane Grosjean This fixes the bitimings fields ranges supported by all the CAN-FD USB interfaces of the PEAK-System CAN-FD adapters. Very first development versions of the IP core API defined smaller TSGEx and SJW fields for both nominal and data bittimings

pull-request: can 2016-12-02

Hello David, this is a pull request for net/master. THere are two patches by Stephane Grosjean, who adds support for the new PCAN-USB X6 USB interface to the pcan_usb driver. regards, Marc --- The following changes since commit aa196eed3d80d4b003b04a270712b978a012a939: macvtap: handle ubuf

Re: [RFC PATCH net-next v2] ipv6: implement consistent hashing for equal-cost multipath routing

On 12/01/2016 06:55 PM, Roopa Prabhu wrote: > I think Its best for it to be a global setting, and thats why sysctl > seems like the best way (unless there are other ways to set this > globally via rtnetlink). If it helps, most hw switch vendors > supporting this feature also provide a globally

Re: stmmac ethernet in kernel 4.9-rc6: coalescing related pauses.

+ Lino On 12/2/2016 9:24 AM, Giuseppe CAVALLARO wrote: Hello On 11/24/2016 10:25 PM, Pavel Machek wrote: Hi! I'm debugging strange delays during transmit in stmmac driver. They seem to be present in 4.4 kernel (and older kernels, too). Workload is burst of udp packets being sent, pause,

[PATCH/RFC net-next 1/2] flow dissector: ICMP support

Allow dissection of ICMP(V6) type and code. This re-uses transport layer port dissection code as although ICMP is not a transport protocol and their type and code are not ports this allows sharing of both code and storage. Signed-off-by: Simon Horman ---

[PATCH/RFC net-next 2/2] net/sched: cls_flower: Support matching on ICMP type and code

Support matching on ICMP type and code. Example usage: tc qdisc add dev eth0 ingress tc filter add dev eth0 protocol ip parent : flower \ indev eth0 ip_proto icmp type 8 code 0 action drop tc filter add dev eth0 protocol ipv6 parent : flower \ indev eth0 ip_proto icmpv6

[PATCH/RFC iproute2/net-next 2/3] tc: flower: introduce enum flower_endpoint

Introduce enum flower_endpoint and use it instead of a bool as the type for paramatising source and destination. This is intended to improve read-ability and provide some type checking of endpoint parameters. Signed-off-by: Simon Horman --- tc/f_flower.c | 22

[PATCH/RFC iproute2/net-next 3/3] tc: flower: support matching on ICMP type and code

Support matching on ICMP type and code. Example usage: tc qdisc add dev eth0 ingress tc filter add dev eth0 protocol ip parent : flower \ indev eth0 ip_proto icmp type 8 code 0 action drop tc filter add dev eth0 protocol ipv6 parent : flower \ indev eth0 ip_proto icmpv6

[PATCH/RFC iproute2/net-next 0/3] tc: flower: Support matching on ICMP

Add support for matching on ICMP type and code to flower. This is modeled on existing support for matching on L4 ports. The second patch provided a minor cleanup which is in keeping with they style used in the last patch. This is marked as an RFC to match the same designation given to the

[PATCH/RFC iproute2/net-next 1/3] tc: flower: update headers for TCA_FLOWER_KEY_ICMP*

These are proposed changes for net-next. Signed-off-by: Simon Horman --- include/linux/pkt_cls.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/linux/pkt_cls.h b/include/linux/pkt_cls.h index a3d8a4f17d8e..fa435ea8ad21 100644 ---

  1   2   3   4   >