[PATCH] ipv6: addrconf: Avoid addrconf_disable_change() using RCU read-side lock

2017-01-19 Thread Kefeng Wang
Just like commit 4acd4945cd1e ("ipv6: addrconf: Avoid calling netdevice notifiers with RCU read-side lock"), it is unnecessary to make addrconf_disable_change() use RCU iteration over the netdev list, since it already holds the RTNL lock, or we may meet Illegal context switch in RCU read-side

RE: [PATCH] net: fec: Fixed panic problem with non-tso

2017-01-19 Thread Andy Duan
From: Eric Dumazet Sent: Wednesday, January 18, 2017 12:36 PM >To: Ashizuka, Yuusuke >Cc: Andy Duan ; netdev@vger.kernel.org; Pravin B >Shelar >Subject: Re: [PATCH] net: fec: Fixed panic problem with

Re: linux-next: build warning after merge of the net tree

2017-01-19 Thread Tariq Toukan
Hi Stephen, On 19/01/2017 12:56 AM, Stephen Rothwell wrote: Hi all, After merging the net tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c: In function 'mlx5e_set_channels':

Re: [PATCH] ip/xfrm: Fix deleteall when having many policies installed

2017-01-19 Thread Alexander Heinlein
From 192cf19b3a97871a508ad57ba5893d1719877f13 Mon Sep 17 00:00:00 2001 From: Alexander Heinlein Date: Mon, 16 Jan 2017 14:48:25 +0100 Subject: [PATCH] ip/xfrm: Fix deleteall when having many policies installed Fix "Policy buffer overflow" when trying to use

Re: [PATCH net-next 0/9] mlx4 misc improvements

2017-01-19 Thread Tariq Toukan
On 17/01/2017 9:49 PM, David Miller wrote: From: Tariq Toukan Date: Mon, 16 Jan 2017 19:29:56 +0200 This patchset contains several improvements and cleanups from the team to the mlx4 Eth and core drivers. Series generated against net-next commit: dbeaa8c2a4ba stmmac:

Re: Potential issues (security and otherwise) with the current cgroup-bpf API

2017-01-19 Thread Michal Hocko
On Wed 18-01-17 14:18:50, Tejun Heo wrote: > Hello, Michal. > > On Tue, Jan 17, 2017 at 02:58:30PM +0100, Michal Hocko wrote: > > This would require using hierarchical cgroup iterators to iterate over > > It does behave hierarchically. > > > tasks. As per Andy's testing this doesn't seem to be

RE: [Xen-devel] xennet_start_xmit assumptions

2017-01-19 Thread Paul Durrant
> -Original Message- > From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] > Sent: 18 January 2017 19:25 > To: Sowmini Varadhan ; Wei Liu > ; Paul Durrant > Cc: netdev@vger.kernel.org;

Re: [PATCH v3] net/irda: fix lockdep annotation

2017-01-19 Thread Dmitry Vyukov
On Tue, Jan 17, 2017 at 9:19 PM, David Miller wrote: > From: Dmitry Vyukov > Date: Mon, 16 Jan 2017 22:10:52 +0100 > >> The current annotation uses a global variable as recursion counter. >> The variable is not atomic nor protected with a mutex, but

Re: [Xen-devel] xennet_start_xmit assumptions

2017-01-19 Thread Sowmini Varadhan
On (01/19/17 11:31), Paul Durrant wrote: > Sowmini, > > Yeah, it would be useful to verify any change fixes the particular > issue you're seeing so please share the program. For the non-empty > non-linear case I'd hope that catching this and doing a pull of some > sensible amount of header (which

Re: [PATCH 2/2] at803x: double check SGMII side autoneg

2017-01-19 Thread Zefir Kurtisi
On 01/18/2017 04:02 PM, Timur Tabi wrote: > On 01/18/2017 07:53 AM, Zefir Kurtisi wrote: >> No, not necessarily. The SGMII link default configuration is set such that >> you do >> not have to bother at all. > > Does the SGMII link need to make the speed and duplex of the external link? > >

Re: [PATCH net-next v4] bridge: multicast to unicast

2017-01-19 Thread Nikolay Aleksandrov
On 19/01/17 03:45, Linus Lüssing wrote: > From: Felix Fietkau > > Implements an optional, per bridge port flag and feature to deliver > multicast packets to any host on the according port via unicast > individually. This is done by copying the packet per host and > changing the

Re: [PATCH net-next] net/sched: cls_flower: reduce fl_change stack size

2017-01-19 Thread Jiri Pirko
Thu, Jan 19, 2017 at 10:45:31AM CET, a...@arndb.de wrote: >The new ARP support has pushed the stack size over the edge on ARM, >as there are two large objects on the stack in this function (mask >and tb) and both have now grown a bit more: > >net/sched/cls_flower.c: In function 'fl_change':

RE: [PATCH net-next] macb: Common code to enable ptp support for SAMA5Dx platforms.

2017-01-19 Thread Andrei.Pistirica
> Subject: Re: [PATCH net-next] macb: Common code to enable ptp support > for SAMA5Dx platforms. > > Le 18/01/2017 à 09:57, Andrei Pistirica a écrit : > > This patch does the following: > > - add GEM-PTP interface > > - registers and bitfields for TSU are named according to SAMA5Dx data > > sheet

Re: [net, 3/6] net: korina: increase tx/rx ring sizes

2017-01-19 Thread Roman Yeryomin
On 17 January 2017 at 21:20, Eric Dumazet wrote: > On Tue, 2017-01-17 at 20:27 +0200, Roman Yeryomin wrote: >> On 17 January 2017 at 19:58, David Miller wrote: >> > From: Roman Yeryomin >> > Date: Tue, 17 Jan 2017 19:32:36

RE: [Xen-devel] xennet_start_xmit assumptions

2017-01-19 Thread Paul Durrant
> -Original Message- > From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com] > Sent: 19 January 2017 11:14 > To: Paul Durrant > Cc: Konrad Rzeszutek Wilk ; Wei Liu > ; netdev@vger.kernel.org; xen- >

[PATCH] net/mlx5e: Remove unused variable

2017-01-19 Thread Arnd Bergmann
A cleanup removed the only user of this variable mlx5/core/en_ethtool.c: In function 'mlx5e_set_channels': mlx5/core/en_ethtool.c:546:6: error: unused variable 'ncv' [-Werror=unused-variable] Let's remove the declaration as well. Fixes: 639e9e94160e ("net/mlx5e: Remove unnecessary checks when

[PATCH net-next] net/sched: cls_flower: reduce fl_change stack size

2017-01-19 Thread Arnd Bergmann
The new ARP support has pushed the stack size over the edge on ARM, as there are two large objects on the stack in this function (mask and tb) and both have now grown a bit more: net/sched/cls_flower.c: In function 'fl_change': net/sched/cls_flower.c:928:1: error: the frame size of 1072 bytes is

Re: [PATCH] net/mlx5e: Remove unused variable

2017-01-19 Thread Tariq Toukan
Hi Arnd, On 19/01/2017 11:33 AM, Arnd Bergmann wrote: A cleanup removed the only user of this variable mlx5/core/en_ethtool.c: In function 'mlx5e_set_channels': mlx5/core/en_ethtool.c:546:6: error: unused variable 'ncv' [-Werror=unused-variable] Let's remove the declaration as well. Fixes:

Re: [PATCH v6 13/13] net: ethernet: aquantia: Integrate AQtion 2.5/5 GB NIC driver

2017-01-19 Thread kbuild test robot
-aquantia-Make-and-configuration-files/20170119-19 coccinelle warnings: (new ones prefixed by >>) >> drivers/net/ethernet/aquantia/atlantic/aq_ring.c:24:20-41: WARNING: casting >> value returned by memory allocation function to (struct aq_ring_buff_s *) is >> useless. Pl

[PATCH] net: ethernet: aquantia: fix alloc_cast.cocci warnings

2017-01-19 Thread kbuild test robot
drivers/net/ethernet/aquantia/atlantic/aq_ring.c:24:20-41: WARNING: casting value returned by memory allocation function to (struct aq_ring_buff_s *) is useless. Remove casting the values returned by memory allocation functions like kmalloc, kzalloc, kmem_cache_alloc, kmem_cache_zalloc etc.

[PATCH] rtlwifi: rtl8192x: Enabling and disabling hardware interrupts after enabling local irq flags

2017-01-19 Thread Bharat Kumar Gogada
-Realtek 8192CE chipset maintains local irq flags after enabling/disabling hardware interrupts. -Hardware interrupts are enabled before enabling the local irq flags(these flags are being checked in interrupt handler), leading to race condition on some RP, where the irq line between bridge and

[PATCH] net: atm: Fix build error when !CONFIG_PROC_FS

2017-01-19 Thread Augusto Mecking Caringi
When CONFIG_ATM_CLIP is set and CONFIG_PROC_FS is not set, the building was failing whith the error: net/atm/clip.c: In function ‘atm_clip_exit’: net/atm/clip.c:933:27: error: ‘atm_proc_root’ undeclared (first use in this function) remove_proc_entry("arp", atm_proc_root);

Re: [PATCH v3] net/irda: fix lockdep annotation

2017-01-19 Thread Dmitry Vyukov
On Thu, Jan 19, 2017 at 11:05 AM, Dmitry Vyukov wrote: > On Tue, Jan 17, 2017 at 9:19 PM, David Miller wrote: >> From: Dmitry Vyukov >> Date: Mon, 16 Jan 2017 22:10:52 +0100 >> >>> The current annotation uses a global variable as

Re: [Xen-devel] xennet_start_xmit assumptions

2017-01-19 Thread Sowmini Varadhan
On (01/19/17 09:36), Paul Durrant wrote: > > Hi Sowmini, > > Sounds like a straightforward bug to me... netfront should be able > to handle an empty skb and clearly, if it's relying on skb_headlen() > being non-zero, that's not the case. > > Paul I see. Seems like there are 2 things broken

[PATCH iproute2 net-next] tc: flower: Refactor matching flags to be more user friendly

2017-01-19 Thread Paul Blakey
Instead of "magic numbers" we can now specify each flag by name. Prefix of "no_" (e.g no_frag) unsets the flag, otherwise it wil be set. Example: # add a flower filter that will drop fragmented packets tc filter add dev ens4f0 protocol ip parent : \ flower \

Re: [PATCH iproute2 net-next] tc: flower: support matching flags

2017-01-19 Thread Paul Blakey
On 18/01/2017 14:41, Jiri Benc wrote: On Wed, 4 Jan 2017 12:55:59 +0100, Jiri Benc wrote: On Wed, 4 Jan 2017 13:51:13 +0200, Paul Blakey wrote: It mimics the kernel packing of flags, I have no problem either way (flags, or ip_flags/tcp_flags pairs), what do you think jiri? What Simon says

Re: [PATCH iproute2 net-next] tc: flower: Refactor matching flags to be more user friendly

2017-01-19 Thread Paul Blakey
On 19/01/2017 13:32, Paul Blakey wrote: Instead of "magic numbers" we can now specify each flag by name. Prefix of "no_" (e.g no_frag) unsets the flag, otherwise it wil be set. Example: # add a flower filter that will drop fragmented packets tc filter add dev ens4f0 protocol ip

RE: [PATCH 2/3] qed: avoid possible stack overflow in qed_ll2_acquire_connection

2017-01-19 Thread Mintz, Yuval
> 968,23 +968,19 @@ static int qed_ll2_start_ooo(struct qed_dev *cdev, { > struct qed_hwfn *hwfn = QED_LEADING_HWFN(cdev); > u8 *handle = >pf_params.iscsi_pf_params.ll2_ooo_queue_id; > - struct qed_ll2_info *ll2_info; > + struct qed_ll2_conn ll2_info; A bit confusing to

[PATCH iproute2 net-next V2] tc: flower: Refactor matching flags to be more user friendly

2017-01-19 Thread Paul Blakey
Instead of "magic numbers" we can now specify each flag by name. Prefix of "no_" (e.g no_frag) unsets the flag, otherwise it wil be set. Example: # add a flower filter that will drop fragmented packets tc filter add dev ens4f0 protocol ip parent : \ flower \

[PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM

2017-01-19 Thread Andrei Pistirica
This patch does the following: - MACB/GEM-PTP interface - registers and bitfields for TSU - capability flags to enable PTP per platform basis Signed-off-by: Andrei Pistirica --- Patch history: Version 1: This is just the common code for MACB/GEM-PTP support. Code

RE: [PATCH v2 net-next] net:add one common config ARCH_WANT_RELAX_ORDER to support relax ordering.

2017-01-19 Thread David Laight
From: Alexander Duyck > Sent: 18 January 2017 17:25 > On Wed, Jan 18, 2017 at 8:22 AM, David Laight wrote: > > From: David Miller > >> Sent: 17 January 2017 19:16 > >> > Relax ordering(RO) is one feature of 82599 NIC, to enable this feature > >> > can > >> > enhance the

[PATCH v2 net-next] phy: increase size of bus_id and MII_BUS_ID_SIZE

2017-01-19 Thread Volodymyr Bendiuga
Some bus names are pretty long and do not fit into 20 chars, therefore bus_id size is increased together with MII_BUS_ID_SIZE to host larger names. Signed-off-by: Volodymyr Bendiuga Signed-off-by: Magnus Öberg --- include/linux/phy.h | 4

[PATCH iproute2 0/2] two small fixes in flower option parser error flow

2017-01-19 Thread Roi Dayan
Hi, the first adds a missing return check and the second removes an incorrect error msg. Thanks, Roi Roi Dayan (2): tc: flower: Add missing err check when parsing flower options tc: flower: Fix incorrect error msg about eth type tc/f_flower.c | 11 +-- 1 files changed, 5

[PATCH iproute2 2/2] tc: flower: Fix incorrect error msg about eth type

2017-01-19 Thread Roi Dayan
addattr16 may return an error about the nl msg size but not about incorrect eth type. Fixes: 488b41d020fb ("tc: flower no need to specify the ethertype") Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- tc/f_flower.c |7 ++- 1 files changed,

[PATCH iproute2 1/2] tc: flower: Add missing err check when parsing flower options

2017-01-19 Thread Roi Dayan
addattr32 may return an error. Fixes: cfcabf18d84a ("tc: flower: Add skip_{hw|sw} support") Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey --- tc/f_flower.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tc/f_flower.c

Re: [PATCH] net: ethtool: avoid allocation failure for dump_regs

2017-01-19 Thread David Arcari
On 01/18/2017 11:45 AM, David Miller wrote: > From: David Arcari > Date: Wed, 18 Jan 2017 08:34:05 -0500 > >> If the user executes 'ethtool -d' for an interface and the associated >> get_regs_len() function returns 0, the user will see a call trace from >> the vmalloc() call

Re: libertas: fix improper return value

2017-01-19 Thread Kalle Valo
Pan Bian wrote: > Function lbs_cmd_802_11_sleep_params() always return 0, even if the call > to lbs_cmd_with_response() fails. In this case, the parameter @sp will > keep uninitialized. Because the return value is 0, its caller (say > lbs_sleepparams_read()) will not detect

[PATCH] tcp: initialize max window for a new fastopen socket

2017-01-19 Thread Alexey Kodanev
Found that if we run LTP netstress test with large MSS (65K), the first attempt from server to send data comparable to this MSS on fastopen connection will be delayed by the probe timer. Here is an example: < S seq 0:0 win 43690 options [mss 65495 wscale 7 tfo cookie] length 32 > S.

Re: [net, 3/6] net: korina: increase tx/rx ring sizes

2017-01-19 Thread Eric Dumazet
On Thu, 2017-01-19 at 12:55 +0200, Roman Yeryomin wrote: > On 17 January 2017 at 21:20, Eric Dumazet wrote: > > Note that at 100M, 64 rx descriptors have a 8 ms max latency. > > > > Switching to 256 also multiply by 4 the latency -> 32 ms latency. > > > > Presumably

Re: [PATCH] net: fec: Fixed panic problem with non-tso

2017-01-19 Thread Eric Dumazet
On Thu, 2017-01-19 at 08:18 +, Andy Duan wrote: > I will double check your fix. Thanks. > > And, if driver is to support highmem, then we should add tso highmem > support in net/core/tso.c, do you think it is necessary ? Adding TSO highmem support would mean changing net/core/tso.c ABI

[PATCH iproute2 net-next V3] tc: flower: Refactor matching flags to be more user friendly

2017-01-19 Thread Paul Blakey
Instead of "magic numbers" we can now specify each flag by name. Prefix of "no" (e.g nofrag) unsets the flag, otherwise it wil be set. Example: # add a flower filter that will drop fragmented packets tc filter add dev ens4f0 protocol ip parent : \ flower \

Re: [PATCH net-next V4] tc: flower: Refactor matching flags to be more user friendly

2017-01-19 Thread Jiri Benc
On Thu, 19 Jan 2017 16:17:48 +0200, Paul Blakey wrote: > + while (token) { > + if (!strncmp(token, "no", 2)) { > + no = true; > + token = strchr(token, '_') + 1; This seems to still assume that "no" is followed by an underscore. What about a

Re: [PATCH iproute2 net-next V3] tc: flower: Refactor matching flags to be more user friendly

2017-01-19 Thread Paul Blakey
On 19/01/2017 16:14, Paul Blakey wrote: Instead of "magic numbers" we can now specify each flag by name. Prefix of "no" (e.g nofrag) unsets the flag, otherwise it wil be set. Example: # add a flower filter that will drop fragmented packets tc filter add dev ens4f0 protocol ip parent

RE: [PATCH net] gianfar: Do not reuse pages from emergency reserve

2017-01-19 Thread Claudiu Manoil
>-Original Message- >From: Eric Dumazet [mailto:eric.duma...@gmail.com] >Sent: Thursday, January 19, 2017 5:45 AM >To: David Miller >Cc: netdev ; Claudiu Manoil > >Subject: [PATCH net] gianfar: Do not reuse pages

Re: [PATCH] tcp: initialize max window for a new fastopen socket

2017-01-19 Thread Eric Dumazet
On Thu, 2017-01-19 at 16:36 +0300, Alexey Kodanev wrote: > Found that if we run LTP netstress test with large MSS (65K), > the first attempt from server to send data comparable to this > MSS on fastopen connection will be delayed by the probe timer. > > This also contradicts with the fact that

Re: [PATCH iproute2 net-next V2] tc: flower: Refactor matching flags to be more user friendly

2017-01-19 Thread Paul Blakey
On 19/01/2017 16:04, Jiri Benc wrote: On Thu, 19 Jan 2017 14:17:57 +0200, Paul Blakey wrote: Instead of "magic numbers" we can now specify each flag by name. Prefix of "no_" (e.g no_frag) unsets the flag, otherwise it wil be set. Other parts of the tc tool use the "no" prefix (without the

[PATCH net-next V4] tc: flower: Refactor matching flags to be more user friendly

2017-01-19 Thread Paul Blakey
Instead of "magic numbers" we can now specify each flag by name. Prefix of "no" (e.g nofrag) unsets the flag, otherwise it wil be set. Example: # add a flower filter that will drop fragmented packets tc filter add dev ens4f0 protocol ip parent : \ flower \

Re: [PATCH iproute2 net-next V5] tc: flower: Refactor matching flags to be more user friendly

2017-01-19 Thread Jiri Benc
On Thu, 19 Jan 2017 16:27:53 +0200, Paul Blakey wrote: > Instead of "magic numbers" we can now specify each flag > by name. Prefix of "no" (e.g nofrag) unsets the flag, > otherwise it wil be set. > > Example: > # add a flower filter that will drop fragmented packets > tc filter add dev

[PATCH iproute2 net-next V5] tc: flower: Refactor matching flags to be more user friendly

2017-01-19 Thread Paul Blakey
Instead of "magic numbers" we can now specify each flag by name. Prefix of "no" (e.g nofrag) unsets the flag, otherwise it wil be set. Example: # add a flower filter that will drop fragmented packets tc filter add dev ens4f0 protocol ip parent : \ flower \

Re: [PATCH] rtlwifi: rtl8192x: Enabling and disabling hardware interrupts after enabling local irq flags

2017-01-19 Thread Lino Sanfilippo
Hi, altek/rtlwifi/rtl8192ce/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c > index a47be73..143766c4 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c > @@ -1306,9 +1306,9 @@ void

Re: [PATCH net-next v3 06/10] net: dsa: Migrate to device_find_class()

2017-01-19 Thread Greg KH
On Mon, Jan 16, 2017 at 12:01:02PM -0800, Florian Fainelli wrote: > On 01/15/2017 11:16 AM, Andrew Lunn wrote: > >>> What exactly is the relationship between these devices (a ascii-art tree > >>> or sysfs tree output might be nice) so I can try to understand what is > >>> going on here. > > > >

Re: [PATCH net-next v3 06/10] net: dsa: Migrate to device_find_class()

2017-01-19 Thread Andrew Lunn
> > > struct dsa_platform_data { > > > /* > > > * Reference to a Linux network interface that connects > > > * to the root switch chip of the tree. > > > */ > > > struct device *netdev; > > This I think is the oddest thing, why do you need to have the

Re: [PATCH iproute2 net-next V2] tc: flower: Refactor matching flags to be more user friendly

2017-01-19 Thread Jiri Benc
On Thu, 19 Jan 2017 14:17:57 +0200, Paul Blakey wrote: > Instead of "magic numbers" we can now specify each flag > by name. Prefix of "no_" (e.g no_frag) unsets the flag, > otherwise it wil be set. Other parts of the tc tool use the "no" prefix (without the underscore), such as "nofrag" in u32

Re: [PATCH iproute2 net-next V5] tc: flower: Refactor matching flags to be more user friendly

2017-01-19 Thread Or Gerlitz
On 1/19/2017 4:27 PM, Paul Blakey wrote: Hi, added a framework to add new flags more easily, such as the upcoming tcp_flags (see kernel cls_flower), and other ip_flags. FWIW, just wanted to make a note that I have the patches for tcp_flags under the works, so if someone needs them urgently

Re: [PATCH net-next V4] tc: flower: Refactor matching flags to be more user friendly

2017-01-19 Thread Paul Blakey
On 19/01/2017 16:22, Jiri Benc wrote: On Thu, 19 Jan 2017 16:17:48 +0200, Paul Blakey wrote: + while (token) { + if (!strncmp(token, "no", 2)) { + no = true; + token = strchr(token, '_') + 1; This seems to still assume that

[PATCH net-next] net: caif: Remove unused stats member from struct chnl_net

2017-01-19 Thread Tobias Klauser
The stats member of struct chnl_net is used nowhere in the code, so it might as well be removed. Signed-off-by: Tobias Klauser --- net/caif/chnl_net.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/caif/chnl_net.c b/net/caif/chnl_net.c index

Re: Initializing MAC address at run-time

2017-01-19 Thread Mason
Hello Uwe, On 18/01/2017 19:54, Uwe Kleine-König wrote: > On Wed, Jan 18, 2017 at 03:03:57PM +0100, Mason wrote: > >> When my system boots up, eth0 is given a seemingly random MAC address. >> >> [0.950734] nb8800 26000.ethernet eth0: MAC address ba:de:d6:38:b8:38 >> [0.957334] nb8800

Re: [PATCH] net: ethtool: avoid allocation failure for dump_regs

2017-01-19 Thread John W. Linville
On Thu, Jan 19, 2017 at 07:35:22AM -0500, David Arcari wrote: > On 01/18/2017 11:45 AM, David Miller wrote: > > From: David Arcari > > Date: Wed, 18 Jan 2017 08:34:05 -0500 > > > >> If the user executes 'ethtool -d' for an interface and the associated > >> get_regs_len()

RE: [PATCH iproute2 v4 3/4] ifstat: Add 64 bits based stats to extended statistics

2017-01-19 Thread Nogah Frankel
> -Original Message- > From: Nogah Frankel > Sent: Sunday, January 15, 2017 3:55 PM > To: 'Stephen Hemminger' > Cc: netdev@vger.kernel.org; roszenr...@gmail.com; ro...@cumulusnetworks.com; > Jiri > Pirko ; Ido Schimmel ;

Re: [PATCH] net: atm: Fix build error when !CONFIG_PROC_FS

2017-01-19 Thread David Miller
From: Augusto Mecking Caringi Date: Thu, 19 Jan 2017 11:00:12 + > When CONFIG_ATM_CLIP is set and CONFIG_PROC_FS is not set, the building > was failing whith the error: > > net/atm/clip.c: In function ‘atm_clip_exit’: > net/atm/clip.c:933:27: error: ‘atm_proc_root’

Re: [PATCH v6 00/13] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver

2017-01-19 Thread David Miller
From: Alexander Loktionov Date: Wed, 18 Jan 2017 17:07:51 -0800 > From: David VomLehn > > This series introduces the AQtion NIC driver for the aQuantia > AQC107/AQC108 network devices. > > This series introduces the AQtion NIC driver for

[PATCH v2 1/5] net: ethernet: ti: cpsw: remove dual check from common res usage function

2017-01-19 Thread Ivan Khoronzhuk
Common res usage is possible only in case an interface is running. In case of not dual emac here can be only one interface, so while ndo_open and switch mode, only one interface can be opened, thus if open is called no any interface is running ... and no common res are used. So remove check on

[PATCH v2 3/5] net: ethernet: ti: cpsw: don't duplicate ndev_running

2017-01-19 Thread Ivan Khoronzhuk
No need to create additional vars to identify if interface is running. So simplify code by removing redundant var and checking usage counter instead. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 31 +-- 1 file

[PATCH v2 4/5] net: ethernet: ti: cpsw: don't duplicate common res in rx handler

2017-01-19 Thread Ivan Khoronzhuk
No need to duplicate the same function in rx handler to get info if any interface is running. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/cpsw.c | 40 1 file changed, 16 insertions(+), 24 deletions(-) diff

[PATCH v2 2/5] net: ethernet: ti: cpsw: don't disable interrupts in ndo_open

2017-01-19 Thread Ivan Khoronzhuk
No need to disable interrupts if no open devices, they are disabled anyway. Even no need to disable interrupts if some ndev is opened, In this case shared resources are not touched, only parameters of ndev shell, so no reason to disable them also. Removed lines have proved it. So, no need in

[PATCH iproute2] ip route: error out on multiple via without nexthop keyword

2017-01-19 Thread David Ahern
To specify multiple nexthops in a route the user is expected to use the "nexthop" keyword which ip route uses to create the RTA_MULTIPATH. However, ip route always accepts multiple 'via' keywords where only the last one is used in the route leading to confusion. For example, ip accepts this

[PATCH v2 0/5] net: ethernet: ti: cpsw: correct common res usage

2017-01-19 Thread Ivan Khoronzhuk
This series is intended to remove unneeded redundancies connected with common resource usage function. Since v1: - changed name to cpsw_get_usage_count() - added comments to open/closw for cpsw_get_usage_count() - added patch: net: ethernet: ti: cpsw: clarify ethtool ops changing num of descs

[PATCHv3 net-next 0/4] sctp: add sender-side procedures for stream reconf asoc reset and add streams

2017-01-19 Thread Xin Long
Patch 2/4 is to implement sender-side procedures for the SSN/TSN Reset Request Parameter described in rfc6525 section 5.1.4, patch 1/4 is ahead of it to define a function to make the request chunk for it. Patch 4/4 is to implement sender-side procedures for the Add Incoming and Outgoing Streams

Re: [PATCHv3 net-next 4/4] sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter

2017-01-19 Thread Marcelo Ricardo Leitner
On Fri, Jan 20, 2017 at 01:19:14AM +0800, Xin Long wrote: > This patch is to implement Sender-Side Procedures for the Add > Outgoing and Incoming Streams Request Parameter described in > rfc6525 section 5.1.5-5.1.6. > > It is also to add sockopt SCTP_ADD_STREAMS in rfc6525 section > 6.3.4 for

Re: [PATCHv3 net-next 2/4] sctp: implement sender-side procedures for SSN/TSN Reset Request Parameter

2017-01-19 Thread Marcelo Ricardo Leitner
On Fri, Jan 20, 2017 at 01:19:12AM +0800, Xin Long wrote: > This patch is to implement Sender-Side Procedures for the SSN/TSN > Reset Request Parameter descibed in rfc6525 section 5.1.4. > > It is also to add sockopt SCTP_RESET_ASSOC in rfc6525 section 6.3.3 > for users. > > Signed-off-by: Xin

Re: [PATCH v5 0/2] Add support for the ethernet switch on the ESPRESSObin

2017-01-19 Thread Vivien Didelot
Hi Gregory, Gregory CLEMENT writes: > I created a new family for this switch and filled the ops structure by > selecting which seems the more appropriate functions. We don't create families, this information comes from the Marvell DSDT. If you don't know

Re: [PATCH v5 0/2] Add support for the ethernet switch on the ESPRESSObin

2017-01-19 Thread Andrew Lunn
> While comparing the datasheet and the ops functions used, some > question came to me. They should not prevent applying this series, > but their answer would help me to have a better understanding of the > dsa subsystem. > > - Are the temperature related operation still useful with dsa2 ? No.

Re: [PATCH v5 1/2] net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports

2017-01-19 Thread Vivien Didelot
Hi Gregory, Gregory CLEMENT writes: > From: Romain Perier > > Some Marvell ethernet switches have internal ethernet transceivers with > hardcoded phy addresses. These addresses can be greater than the number > of ports or

Re: [PATCHv3 net-next 4/4] sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter

2017-01-19 Thread Marcelo Ricardo Leitner
On Fri, Jan 20, 2017 at 01:19:14AM +0800, Xin Long wrote: > This patch is to implement Sender-Side Procedures for the Add > Outgoing and Incoming Streams Request Parameter described in > rfc6525 section 5.1.5-5.1.6. > > It is also to add sockopt SCTP_ADD_STREAMS in rfc6525 section > 6.3.4 for

[PATCH v3 net-next 2/2] net/ipv6: support more tunnel interfaces for EUI64 link-local generation

2017-01-19 Thread Felix Jia
Signed-off-by: Felix Jia --- net/ipv6/addrconf.c | 5 + net/ipv6/ip6_gre.c | 3 +++ net/ipv6/ip6_vti.c | 4 3 files changed, 12 insertions(+) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index e35259dd17ba..4c47656b9f09 100644 ---

[PATCH v3 net-next 1/2] net/ipv6: allow sysctl to change link-local address generation mode

2017-01-19 Thread Felix Jia
The address generation mode for IPv6 link-local can only be configured by netlink messages. This patch adds the ability to change the address generation mode via sysctl. v1 -> v2 Removed the rtnl lock and switch to use RCU lock to iterate through the netdev list. v2 -> v3 Removed the addrgenmode

[PATCH iproute2] f_flower: don't set TCA_FLOWER_KEY_ETH_TYPE for "protocol all"

2017-01-19 Thread Benjamin LaHaise
When using the tc filter flower, rules marked with "protocol all" do not actually match all packets. This is due to a bug in f_flower.c that passes in ETH_P_ALL in the TCA_FLOWER_KEY_ETH_TYPE attribute when adding a rule. Fix this by omitting TCA_FLOWER_KEY_ETH_TYPE if the protocol is set to

Re: [RFC] RESEND - rdmatool - tool for RDMA users

2017-01-19 Thread Bart Van Assche
On Thu, 2017-01-19 at 11:03 -0700, Jason Gunthorpe wrote: > sysfs is unpopular because the 'one value per file' dogma is laregly > unsuitable for complex mulit-value atomic changes which are common in > netdev. You can force it to work, but it is pretty horrible.. > > It is also very expensive if

Re: [PATCH v7 11/13] net: ethernet: aquantia: Ethtool support

2017-01-19 Thread Florian Fainelli
On 01/19/2017 01:33 PM, Alexander Loktionov wrote: > From: David VomLehn > > Add the driver interfaces required for support by the ethtool utility. > > Signed-off-by: Alexander Loktionov > Signed-off-by: Dmitrii Tarakanov

Re: [PATCH v5 0/2] Add support for the ethernet switch on the ESPRESSObin

2017-01-19 Thread Vivien Didelot
Hi Gregory, Vivien Didelot writes: > The temperature is accessed via ethtool -e|-E. Oops, that was a silly mistake, no need to explain! ;-) Vivien

[net-next 14/15] net/mlx5: Move cached hca caps to designated caps struct

2017-01-19 Thread Saeed Mahameed
From: Gal Pressman The caps structure consists of hca caps and port/management caps, all under one roof. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 2 +-

[net-next 09/15] net/mlx5: Query and cache PCAM, MCAM registers on initialization

2017-01-19 Thread Saeed Mahameed
From: Gal Pressman On load_one, we now cache our capabilities registers internally, similar to QUERY_HCA_CAP. Capabilities can later be queried using macros introduced in this patch. Signed-off-by: Gal Pressman Signed-off-by: Saeed Mahameed

Re: [PATCH v7 10/13] net: ethernet: aquantia: Hardware interface and utility functions

2017-01-19 Thread Florian Fainelli
On 01/19/2017 01:33 PM, Alexander Loktionov wrote: > From: David VomLehn > > Add functions to interface with the hardware and some utility functions. > > Signed-off-by: Alexander Loktionov > Signed-off-by: Dmitrii Tarakanov

Re: [PATCH v7 00/13] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver

2017-01-19 Thread David VomLehn
On 01/19/2017 02:41 PM, Florian Fainelli wrote: On 01/19/2017 01:33 PM, Alexander Loktionov wrote: From: David VomLehn This series introduces the AQtion NIC driver for the aQuantia AQC107/AQC108 network devices. v5: o Removed extra newline at the end of the files. v6: o

Re: [PATCH v7 00/13] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver

2017-01-19 Thread Florian Fainelli
On 01/19/2017 02:45 PM, David VomLehn wrote: > On 01/19/2017 02:41 PM, Florian Fainelli wrote: >> On 01/19/2017 01:33 PM, Alexander Loktionov wrote: >>> From: David VomLehn >>> >>> This series introduces the AQtion NIC driver for the aQuantia >>> AQC107/AQC108 network devices.

[PATCH v5 0/2] Add support for the ethernet switch on the ESPRESSObin

2017-01-19 Thread Gregory CLEMENT
Hi, This set of patches adds support for the Marvell Ethernet switch 88E6341 which is found on the ESPRESSObin. With this series the network is usable on this board. >From now on, I am taking care of this series. As Andrew Lunn pointed this switch is not fully compatible with the 6352. However

[PATCH v5 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341

2017-01-19 Thread Gregory CLEMENT
The Marvell 88E6341 device is single-chip, 6-port Ethernet switch with four integrated 10/100/1000Mbps Ethernet transceivers and one high speed SerDes interfaces. It is partially compatible with switches of family 88E6352 and switches of family 88E6390. This commit adds an initial support for

[PATCH v5 1/2] net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports

2017-01-19 Thread Gregory CLEMENT
From: Romain Perier Some Marvell ethernet switches have internal ethernet transceivers with hardcoded phy addresses. These addresses can be greater than the number of ports or its value might be different than the associated port number. This is for example the

Re: [RFC] RESEND - rdmatool - tool for RDMA users

2017-01-19 Thread Jason Gunthorpe
On Thu, Jan 19, 2017 at 10:06:12PM +, Bart Van Assche wrote: > On Thu, 2017-01-19 at 11:03 -0700, Jason Gunthorpe wrote: > > sysfs is unpopular because the 'one value per file' dogma is laregly > > unsuitable for complex mulit-value atomic changes which are common in > > netdev. You can force

Re: linux-next: build failure after merge of the rcu tree

2017-01-19 Thread Paul McKenney
On Wed, Jan 18, 2017 at 7:34 PM, Stephen Rothwell wrote: > Hi Paul, > > After merging the rcu tree, today's linux-next build (x86_64 allmodconfig) > failed like this: > > net/smc/af_smc.c:102:16: error: 'SLAB_DESTROY_BY_RCU' undeclared here (not in > a function) >

Re: [PATCHv3 net-next 4/4] sctp: implement sender-side procedures for Add Incoming/Outgoing Streams Request Parameter

2017-01-19 Thread Marcelo Ricardo Leitner
On Thu, Jan 19, 2017 at 03:17:18PM -0500, Neil Horman wrote: > On Fri, Jan 20, 2017 at 01:19:14AM +0800, Xin Long wrote: > > This patch is to implement Sender-Side Procedures for the Add > > Outgoing and Incoming Streams Request Parameter described in > > rfc6525 section 5.1.5-5.1.6. > > > > It

Re: [PATCH v5 2/2] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341

2017-01-19 Thread Vivien Didelot
Gregory CLEMENT writes: > +static bool mv88e6xxx_6341_family(struct mv88e6xxx_chip *chip) > +{ > + return chip->info->family == MV88E6XXX_FAMILY_6341; > +} I don't want to see these erronous family checks anymore, but I cannot blame you for adding it

Re: [PATCH] virtio: don't set VIRTIO_NET_HDR_F_DATA_VALID on xmit

2017-01-19 Thread Michael S. Tsirkin
On Thu, Jan 19, 2017 at 11:06:59AM +0800, Jason Wang wrote: > > > On 2017年01月18日 23:18, Michael S. Tsirkin wrote: > > On Wed, Jan 18, 2017 at 11:54:21AM +0800, Jason Wang wrote: > > > On 2017年01月18日 02:27, Michael S. Tsirkin wrote: > > > > On Tue, Jan 17, 2017 at 06:13:51PM +, Rolf

Re: [Xen-devel] xennet_start_xmit assumptions

2017-01-19 Thread Sowmini Varadhan
On (01/19/17 13:47), Sowmini Varadhan wrote: > > Specifically I'm talking about the dev_validate_header() check. > > That is supposed to protect us from these kinds of situations. > > ah, but I run my pf_packet application as root, so I have > capable(CAP_SYS_RAWIO), so I slip through the

Re: [PATCH] rtlwifi: rtl8192x: Enabling and disabling hardware interrupts after enabling local irq flags

2017-01-19 Thread Lino Sanfilippo
Hi, On 19.01.2017 19:08, Larry Finger wrote: On 01/19/2017 08:35 AM, Lino Sanfilippo wrote: Hi, altek/rtlwifi/rtl8192ce/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c index a47be73..143766c4 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c +++

[net-next 05/15] net/mlx5: Add support to s-tag in mlx5 firmware interface

2017-01-19 Thread Saeed Mahameed
From: Mohamad Haj Yahia Add svlan_tag and rename vlan_tag to cvlan_tag in flow table entry match param. Signed-off-by: Mohamad Haj Yahia Signed-off-by: Saeed Mahameed Signed-off-by: Leon Romanovsky ---

Re: [PATCH v7 00/13] net: ethernet: aquantia: Add AQtion 2.5/5 GB NIC driver

2017-01-19 Thread Florian Fainelli
On 01/19/2017 01:33 PM, Alexander Loktionov wrote: > From: David VomLehn > > This series introduces the AQtion NIC driver for the aQuantia > AQC107/AQC108 network devices. > v5: o Removed extra newline at the end of the files. > v6: o Removed unnecessary cast from void*. >

[net-next 08/15] net/mlx5: Implement PCAM, MCAM access register commands

2017-01-19 Thread Saeed Mahameed
From: Gal Pressman Introduced registers will expose capabilities of new registers and features related to port/management. Driver will query MCAM and PCAM in order to avoid failing on old firmwares with lack of support. Signed-off-by: Gal Pressman

[net-next 02/15] net/mlx5: Fix version printout in case of health issue

2017-01-19 Thread Saeed Mahameed
From: Eli Cohen Firmware representation of the firmware version on the health buffer has changed for newer device. The representation in the initialization segment does not and will not change. In addition, we print the health buffer firmware version as a raw hex number.

[net-next 01/15] net/mlx5: Remove information print after attempt to load mlx5_ib module

2017-01-19 Thread Saeed Mahameed
From: Leon Romanovsky Infiniband part of mlx5 driver can be compiled as a module or as a part of bzImage (compiled in). In the second case, the call to request_module will return an error -ENOENT. It will cause to a misleading print "failed request module on mlx5_ib". This

  1   2   3   >