Re: [net-next sample action optimization 3/3] openvswitch: Optimize sample action for the clone use cases

2017-03-13 Thread Pravin Shelar
On Mon, Mar 13, 2017 at 1:14 PM, Andy Zhou wrote: > Thanks for the review. Please see comments inline. > > On Mon, Mar 13, 2017 at 12:08 AM, Pravin Shelar wrote: >> On Fri, Mar 10, 2017 at 4:51 PM, Andy Zhou wrote: >>> With the introduction of open

Re: [PATCH net] tun: fix premature POLLOUT notification on tun devices

2017-03-13 Thread David Miller
From: Hannes Frederic Sowa Date: Mon, 13 Mar 2017 00:00:26 +0100 > aszlig observed failing ssh tunnels (-w) during initialization since > commit cc9da6cc4f56e0 ("ipv6: addrconf: use stable address generator for > ARPHRD_NONE"). We already had reports that the

Re: [PATCH net] dccp: fix memory leak during tear-down of unsuccessful connection request

2017-03-13 Thread David Miller
From: Hannes Frederic Sowa Date: Mon, 13 Mar 2017 00:01:30 +0100 > This patch fixes a memory leak, which happens if the connection request > is not fulfilled between parsing the DCCP options and handling the SYN > (because e.g. the backlog is full), because we forgot

Re: [PATCH net-next] mlx4: Better use of order-0 pages in RX path

2017-03-13 Thread Alexei Starovoitov
On Mon, Mar 13, 2017 at 06:02:11PM -0700, Eric Dumazet wrote: > On Mon, 2017-03-13 at 16:40 -0700, Alexei Starovoitov wrote: > > > that's not how it works. It's a job of submitter to prove > > that additional code doesn't cause regressions especially > > when there are legitimate concerns. > >

Re: [PATCH net, v2] dccp/tcp: fix routing redirect race

2017-03-13 Thread David Miller
From: Jon Maxwell Date: Fri, 10 Mar 2017 16:40:33 +1100 > As Eric Dumazet pointed out this also needs to be fixed in IPv6. > v2: Contains the IPv6 tcp/Ipv6 dccp patches as well. > > We have seen a few incidents lately where a dst_enty has been freed > with a dangling TCP

Re: [PATCH] ucc/hdlc: fix two little issue

2017-03-13 Thread David Miller
From: Zhao Qiang Date: Tue, 14 Mar 2017 09:38:33 +0800 > 1. modify bd_status from u32 to u16 in function hdlc_rx_done, > because bd_status register is 16bits > 2. write bd_length register before writing bd_status register > > Signed-off-by: Zhao Qiang

Re: [PATCH net-next 00/12] net: bcmgenet: add support for GENETv5

2017-03-13 Thread David Miller
From: Doug Berger Date: Mon, 13 Mar 2017 17:41:30 -0700 > This collection of patches contains changes related to adding > support for the BCM7260, BCM7268, and BCM7271 devices that > contain a new version of the GENET MAC IP block (v5) and a new > fast ethernet (10/100BASE-T)

Re: [4.10+] sctp lockdep trace

2017-03-13 Thread Xin Long
On Tue, Mar 14, 2017 at 4:11 AM, Marcelo Ricardo Leitner wrote: > On Mon, Mar 13, 2017 at 05:10:45PM -0300, Marcelo Ricardo Leitner wrote: >> On Fri, Feb 24, 2017 at 05:21:10PM -0500, Dave Jones wrote: >> > [ 244.251557] === >> > [

Re: bond procfs hw addr prints

2017-03-13 Thread Jarod Wilson
On 2017-03-13 10:06 PM, Jarod Wilson wrote: On 2017-03-13 8:28 PM, Jay Vosburgh wrote: Jarod Wilson wrote: I've got a bug report for someone using a Intel OPA devices in a bond, and it appears these devices have a hardware address length of 20, opposed to the typical 6 on

openvswitch conntrack and nat problem in first packet reply with RST

2017-03-13 Thread wenxu
Hi all, There is a simple test for conntrack and nat in openvswitch. I want to do stateful firewall with conntrack then do nat netns1 port1 with ip 10.0.0.7 netns2 port2 with ip 1.1.1.7 netns1 10.0.0.7 src -nat to 2.2.1.7 access netns2 1.1.1.7 1. # ovs-ofctl add-flow br0 'ip,in_port=1

Re: [PATCH net-next 02/12] net: phy: bcm7xxx: add support for 28nm EPHY

2017-03-13 Thread Andrew Lunn
On Mon, Mar 13, 2017 at 07:06:25PM -0700, Doug Berger wrote: > On 03/13/2017 06:06 PM, Andrew Lunn wrote: > > On Mon, Mar 13, 2017 at 05:41:32PM -0700, Doug Berger wrote: > >> +static int bcm7xxx_28nm_ephy_01_afe_config_init(struct phy_device *phydev) > >> +{ > >> + int ret; > >> + > >> + /* set

Re: [PATCH] usbnet: smsc95xx: Reduce logging noise

2017-03-13 Thread Guenter Roeck
On 03/13/2017 03:32 PM, David Miller wrote: From: Guenter Roeck Date: Fri, 10 Mar 2017 17:45:21 -0800 An insert/remove stress test generated the following log message sequence. ... Use netdev_dbg() instead of netdev_warn() for the repeating messages to reduce logging

RE: [Intel-wired-lan] [PATCH] net: intel: ixgb: use new api ethtool_{get|set}_link_ksettings

2017-03-13 Thread Brown, Aaron F
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Philippe Reynes > Sent: Sunday, February 5, 2017 3:11 PM > To: Kirsher, Jeffrey T ; da...@davemloft.net > Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux- >

Re: [PATCH net-next 02/12] net: phy: bcm7xxx: add support for 28nm EPHY

2017-03-13 Thread Doug Berger
On 03/13/2017 06:06 PM, Andrew Lunn wrote: > On Mon, Mar 13, 2017 at 05:41:32PM -0700, Doug Berger wrote: >> +static int bcm7xxx_28nm_ephy_01_afe_config_init(struct phy_device *phydev) >> +{ >> +int ret; >> + >> +/* set shadow mode 2 */ >> +ret = phy_set_clr_bits(phydev,

Re: bond procfs hw addr prints

2017-03-13 Thread Jarod Wilson
On 2017-03-13 8:28 PM, Jay Vosburgh wrote: Jarod Wilson wrote: I've got a bug report for someone using a Intel OPA devices in a bond, and it appears these devices have a hardware address length of 20, opposed to the typical 6 on ethernet. When they dump

[PATCH] ucc/hdlc: fix two little issue

2017-03-13 Thread Zhao Qiang
1. modify bd_status from u32 to u16 in function hdlc_rx_done, because bd_status register is 16bits 2. write bd_length register before writing bd_status register Signed-off-by: Zhao Qiang --- drivers/net/wan/fsl_ucc_hdlc.c | 4 ++-- 1 file changed, 2 insertions(+), 2

RE: [Intel-wired-lan] [PATCH] net: intel: igbvf: use new api ethtool_{get|set}_link_ksettings

2017-03-13 Thread Brown, Aaron F
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Philippe Reynes > Sent: Sunday, February 5, 2017 2:55 PM > To: Kirsher, Jeffrey T ; da...@davemloft.net > Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux- >

RE: [Intel-wired-lan] [PATCH] net: intel: igb: use new api ethtool_{get|set}_link_ksettings

2017-03-13 Thread Brown, Aaron F
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@lists.osuosl.org] On > Behalf Of Philippe Reynes > Sent: Sunday, February 5, 2017 9:56 AM > To: Kirsher, Jeffrey T ; da...@davemloft.net > Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux- >

Re: [PATCH] net: ethernet: aquantia: set net_device mtu when mtu is changed

2017-03-13 Thread Pavel Belous
On 03/14/2017 02:07 AM, David Arcari wrote: When the aquantia device mtu is changed the net_device structure is not updated. As a result the ip command does not properly reflect the mtu change. Commit 5513e16421cb incorrectly assumed that __dev_set_mtu() was making the assignment ndev->mtu =

Re: [RFC PATCH] sock: add SO_RCVQUEUE_SIZE getsockopt

2017-03-13 Thread Eric Dumazet
On Mon, 2017-03-13 at 18:34 -0500, Josh Hunt wrote: > In this particular case they really do want to know total # of bytes in > the receive queue, not the data bytes they can consume from an > application pov. The kernel currently only exposes this value through > netlink or /proc/net/udp from

Re: [PATCH net-next 02/12] net: phy: bcm7xxx: add support for 28nm EPHY

2017-03-13 Thread Andrew Lunn
On Mon, Mar 13, 2017 at 05:41:32PM -0700, Doug Berger wrote: > +static int bcm7xxx_28nm_ephy_01_afe_config_init(struct phy_device *phydev) > +{ > + int ret; > + > + /* set shadow mode 2 */ > + ret = phy_set_clr_bits(phydev, MII_BCM7XXX_TEST, > +

Re: [PATCH net-next] mlx4: Better use of order-0 pages in RX path

2017-03-13 Thread Eric Dumazet
On Mon, 2017-03-13 at 16:40 -0700, Alexei Starovoitov wrote: > that's not how it works. It's a job of submitter to prove > that additional code doesn't cause regressions especially > when there are legitimate concerns. This test was moved out of the mlx4_en_prepare_rx_desc() section into the

Re: [PATCH net-next 12/12] net: bcmgenet: add support for the GENETv5 hardware

2017-03-13 Thread Florian Fainelli
On 03/13/2017 05:41 PM, Doug Berger wrote: > This commit adds support for the GENETv5 implementation. > > The GENETv5 reports a major version of 6 instead of 5 so compensate > for this when verifying the configuration of the driver. Also the > EPHY revision is now contained in the MDIO registers

Re: [PATCH net-next 11/12] dt-bindings: net: update bcmgenet binding for GENETv5

2017-03-13 Thread Florian Fainelli
On 03/13/2017 05:41 PM, Doug Berger wrote: > The device tree documentation must be updated to reflect the new compatible > strings "brcm,genet-v5" and "brcm,genet-mdio-v5" used by the GENETv5 driver. > > Signed-off-by: Doug Berger Reviewed-by: Florian Fainelli

Re: [PATCH net-next 10/12] dt-bindings: net: document bcmgenet WoL interrupt

2017-03-13 Thread Florian Fainelli
On 03/13/2017 05:41 PM, Doug Berger wrote: > A third interrupt cell can be provided to optionally specify > the interrupt used for handling Wake on LAN events. > > Typically the wake up handling uses a separate interrupt > controller, so the interrupts-extended property is used to > accommodate

Re: [PATCH net-next 09/12] net: bcmgenet: return EOPNOTSUPP for unknown ioctl commands

2017-03-13 Thread Florian Fainelli
On 03/13/2017 05:41 PM, Doug Berger wrote: > This commit changes the ioctl handling behavior to return the > EOPNOTSUPP error code instead of the EINVAL error code when an > unknown ioctl command value is detected. > > It also removes some redundant parsing of the ioctl command value > and allows

Re: [PATCH net-next 08/12] net: bcmgenet: correct return value of __bcmgenet_tx_reclaim

2017-03-13 Thread Florian Fainelli
On 03/13/2017 05:41 PM, Doug Berger wrote: > The reclaim function should return the number of buffer descriptors > reclaimed, not just the number corresponding to skb packets. > > Also, remove the unnecessary computation when updating the consumer > index. > > While this is not a functional

Re: [PATCH net-next 07/12] net: bcmgenet: clear status to reduce spurious interrupts

2017-03-13 Thread Florian Fainelli
On 03/13/2017 05:41 PM, Doug Berger wrote: > Since the DMA interrupt status is latched and the DMA servicing can be > polled, it is a good idea to clear the latched status of a DMA interrupt > before performing the service that would be invoked by the interrupt. > > This prevents old status from

Re: [PATCH net-next 06/12] net: bcmgenet: remove handling of wol interrupts from isr0

2017-03-13 Thread Florian Fainelli
On 03/13/2017 05:41 PM, Doug Berger wrote: > The bcmgenet_wol_isr() handler performs the necessary processing for > waking from a GENET event. There is no necessary functionality behind > servicing the UMAC_IRQ_MPD_R event in the handling of isr0. Therefore > the code that unmasks and masks this

Re: [PATCH net-next 05/12] net: bcmgenet: manage dma interrupts in napi code

2017-03-13 Thread Florian Fainelli
On 03/13/2017 05:41 PM, Doug Berger wrote: > This commit moves DMA interrupt enabling out of init_umac() and adds > the masking of these interrupts to the napi enable and disable code. > > Signed-off-by: Doug Berger Reviewed-by: Florian Fainelli --

Re: [PATCH net-next 04/12] net: bcmgenet: remove meaningless lines

2017-03-13 Thread Florian Fainelli
On 03/13/2017 05:41 PM, Doug Berger wrote: > An assortment of non-functional lines are removed to reduce confusion > and some typos in comments are corrected. > > Signed-off-by: Doug Berger Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 03/12] net: bcmgenet: simplify circular pointer arithmetic

2017-03-13 Thread Florian Fainelli
On 03/13/2017 05:41 PM, Doug Berger wrote: > A 2's complement subtraction will always do a borrow, so masking > off the sign bits is the same as conditionally adding (mask+1). > > Signed-off-by: Doug Berger Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 02/12] net: phy: bcm7xxx: add support for 28nm EPHY

2017-03-13 Thread Florian Fainelli
On 03/13/2017 05:41 PM, Doug Berger wrote: > This commit adds support for the internal fast ethernet 10/100 PHY > found in the BCM7260, BCM7268, and BCM7271 devices. > > Signed-off-by: Doug Berger Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH net-next 01/12] net: phy: bcm-phylib: replace obsolete EEE macro references

2017-03-13 Thread Florian Fainelli
On 03/13/2017 05:41 PM, Doug Berger wrote: > The macros MDIO_AN_EEE_ADV_100TX and MDIO_AN_EEE_ADV_1000T are now > considered obsolete and are replaced in the kernel with the generic > macros MDIO_EEE_100TX and MDIO_EEE_1000T respectively. > > Signed-off-by: Doug Berger

[PATCH net-next 02/12] net: phy: bcm7xxx: add support for 28nm EPHY

2017-03-13 Thread Doug Berger
This commit adds support for the internal fast ethernet 10/100 PHY found in the BCM7260, BCM7268, and BCM7271 devices. Signed-off-by: Doug Berger --- drivers/net/phy/bcm7xxx.c | 215 +- include/linux/brcmphy.h | 3 + 2 files

[PATCH net-next 00/12] net: bcmgenet: add support for GENETv5

2017-03-13 Thread Doug Berger
This collection of patches contains changes related to adding support for the BCM7260, BCM7268, and BCM7271 devices that contain a new version of the GENET MAC IP block (v5) and a new fast ethernet (10/100BASE-T) internal PHY. These patches were originally developed on top of the bug fixes of the

[PATCH net-next 03/12] net: bcmgenet: simplify circular pointer arithmetic

2017-03-13 Thread Doug Berger
A 2's complement subtraction will always do a borrow, so masking off the sign bits is the same as conditionally adding (mask+1). Signed-off-by: Doug Berger --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 19 +-- 1 file changed, 5 insertions(+), 14

[PATCH net-next 01/12] net: phy: bcm-phylib: replace obsolete EEE macro references

2017-03-13 Thread Doug Berger
The macros MDIO_AN_EEE_ADV_100TX and MDIO_AN_EEE_ADV_1000T are now considered obsolete and are replaced in the kernel with the generic macros MDIO_EEE_100TX and MDIO_EEE_1000T respectively. Signed-off-by: Doug Berger --- drivers/net/phy/bcm-phy-lib.c | 6 +++--- 1 file

[PATCH net-next 06/12] net: bcmgenet: remove handling of wol interrupts from isr0

2017-03-13 Thread Doug Berger
The bcmgenet_wol_isr() handler performs the necessary processing for waking from a GENET event. There is no necessary functionality behind servicing the UMAC_IRQ_MPD_R event in the handling of isr0. Therefore the code that unmasks and masks this interrupt and that gets invoked in response to it

[PATCH net-next 04/12] net: bcmgenet: remove meaningless lines

2017-03-13 Thread Doug Berger
An assortment of non-functional lines are removed to reduce confusion and some typos in comments are corrected. Signed-off-by: Doug Berger --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git

[PATCH net-next 11/12] dt-bindings: net: update bcmgenet binding for GENETv5

2017-03-13 Thread Doug Berger
The device tree documentation must be updated to reflect the new compatible strings "brcm,genet-v5" and "brcm,genet-mdio-v5" used by the GENETv5 driver. Signed-off-by: Doug Berger --- Documentation/devicetree/bindings/net/brcm,bcmgenet.txt| 10 +-

[PATCH net-next 05/12] net: bcmgenet: manage dma interrupts in napi code

2017-03-13 Thread Doug Berger
This commit moves DMA interrupt enabling out of init_umac() and adds the masking of these interrupts to the napi enable and disable code. Signed-off-by: Doug Berger --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 39 +++--- 1 file changed, 22

[PATCH net-next 10/12] dt-bindings: net: document bcmgenet WoL interrupt

2017-03-13 Thread Doug Berger
A third interrupt cell can be provided to optionally specify the interrupt used for handling Wake on LAN events. Typically the wake up handling uses a separate interrupt controller, so the interrupts-extended property is used to accommodate this. Signed-off-by: Doug Berger

[PATCH net-next 07/12] net: bcmgenet: clear status to reduce spurious interrupts

2017-03-13 Thread Doug Berger
Since the DMA interrupt status is latched and the DMA servicing can be polled, it is a good idea to clear the latched status of a DMA interrupt before performing the service that would be invoked by the interrupt. This prevents old status from causing spurious interrupts when the interrupt is

[PATCH net-next 12/12] net: bcmgenet: add support for the GENETv5 hardware

2017-03-13 Thread Doug Berger
This commit adds support for the GENETv5 implementation. The GENETv5 reports a major version of 6 instead of 5 so compensate for this when verifying the configuration of the driver. Also the EPHY revision is now contained in the MDIO registers of the PHY so the EPHY revision of 0 in

[PATCH net-next 09/12] net: bcmgenet: return EOPNOTSUPP for unknown ioctl commands

2017-03-13 Thread Doug Berger
This commit changes the ioctl handling behavior to return the EOPNOTSUPP error code instead of the EINVAL error code when an unknown ioctl command value is detected. It also removes some redundant parsing of the ioctl command value and allows the SIOCSHWTSTAMP value to be handled. Signed-off-by:

[PATCH net-next 08/12] net: bcmgenet: correct return value of __bcmgenet_tx_reclaim

2017-03-13 Thread Doug Berger
The reclaim function should return the number of buffer descriptors reclaimed, not just the number corresponding to skb packets. Also, remove the unnecessary computation when updating the consumer index. While this is not a functional problem it could degrade performance of napi in a fragmented

Re: bond procfs hw addr prints

2017-03-13 Thread Jay Vosburgh
Jarod Wilson wrote: >I've got a bug report for someone using a Intel OPA devices in a bond, and >it appears these devices have a hardware address length of 20, opposed to >the typical 6 on ethernet. When they dump /proc/net/bonding/bondX, it only >prints the first 6 of the

Re: [PATCH 09/11] net: stmmac: dma channel init prepared for multiple queues

2017-03-13 Thread David Miller
From: Joao Pinto Date: Mon, 13 Mar 2017 16:12:40 + > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index e60e077..44db2e3 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++

Re: [RFC PATCH] sock: add SO_RCVQUEUE_SIZE getsockopt

2017-03-13 Thread David Miller
From: Josh Hunt Date: Mon, 13 Mar 2017 18:34:41 -0500 > In this particular case they really do want to know total # of bytes > in the receive queue, not the data bytes they can consume from an > application pov. The kernel currently only exposes this value through > netlink or

Re: [PATCH v2 net-next] qed*: Utilize Firmware 8.15.3.0

2017-03-13 Thread David Miller
From: Christoph Hellwig Date: Mon, 13 Mar 2017 16:19:47 -0700 > On Mon, Mar 13, 2017 at 03:33:47PM -0700, David Miller wrote: >> Applied, thanks. > > So everyone who doesn't have the very latests linux-firmware will now > have a non-working card after upgrading the kernel?

Re: [PATCH 3/7] ath9k: Add support for reading the EEPROM data using the nvmem API

2017-03-13 Thread Christian Lamparter
On Monday, March 13, 2017 10:05:11 PM CET Alban wrote: > Currently SoC platforms use a firmware request to get the EEPROM data. > This is mostly a hack and rely on using a user-helper scripts which is > deprecated. A nicer alternative is to use the nvmem API which was > designed for this kind of

Re: [PATCH net-next] mlx4: Better use of order-0 pages in RX path

2017-03-13 Thread Alexei Starovoitov
On Mon, Mar 13, 2017 at 04:44:19PM -0700, Eric Dumazet wrote: > On Mon, Mar 13, 2017 at 4:40 PM, Alexei Starovoitov > wrote: > > On Mon, Mar 13, 2017 at 04:28:04PM -0700, Eric Dumazet wrote: > >> On Mon, Mar 13, 2017 at 4:21 PM, Alexei Starovoitov > >>

[PATCH] net: mpls: Fix nexthop alive tracking on down events

2017-03-13 Thread David Ahern
Alive tracking of nexthops can account for a link twice if the carrier goes down followed by an admin down of the same link rendering multipath routes useless. This is similar to 79099aab38c8 for UNREGISTER events and DOWN events. Fix by tracking number of alive nexthops in mpls_ifdown similar to

bond procfs hw addr prints

2017-03-13 Thread Jarod Wilson
I've got a bug report for someone using a Intel OPA devices in a bond, and it appears these devices have a hardware address length of 20, opposed to the typical 6 on ethernet. When they dump /proc/net/bonding/bondX, it only prints the first 6 of the address, per %pM and mac_address_string(),

Re: [PATCH net-next] mlx4: Better use of order-0 pages in RX path

2017-03-13 Thread Eric Dumazet
On Mon, Mar 13, 2017 at 4:40 PM, Alexei Starovoitov wrote: > On Mon, Mar 13, 2017 at 04:28:04PM -0700, Eric Dumazet wrote: >> On Mon, Mar 13, 2017 at 4:21 PM, Alexei Starovoitov >> wrote: >> > >> > is it once in the beginning only? If

Re: [PATCH net-next] mlx4: Better use of order-0 pages in RX path

2017-03-13 Thread Alexei Starovoitov
On Mon, Mar 13, 2017 at 04:28:04PM -0700, Eric Dumazet wrote: > On Mon, Mar 13, 2017 at 4:21 PM, Alexei Starovoitov > wrote: > > > > is it once in the beginning only? If so then why that > > 'if (!ring->page_cache.index)' check is done for every packet? > > > >

Re: [net-next sample action optimization 3/3] openvswitch: Optimize sample action for the clone use cases

2017-03-13 Thread Andy Zhou
>>> - skb = skb_clone(skb, GFP_ATOMIC); >>> - if (!skb) >>> - /* Skip the sample action when out of memory. */ >>> - return 0; >>> + if (key) { >>> + err = do_execute_actions(dp, skb, key, actions, rem); >>> + } else if

Re: [RFC PATCH] sock: add SO_RCVQUEUE_SIZE getsockopt

2017-03-13 Thread Josh Hunt
On 03/13/2017 02:39 PM, David Miller wrote: From: Josh Hunt Date: Mon, 13 Mar 2017 12:38:39 -0500 On 03/13/2017 11:12 AM, Eric Dumazet wrote: On Mon, Mar 13, 2017 at 8:59 AM, Josh Hunt wrote: Allows application to read the amount of data sitting in the

Re: [PATCH net-next] mlx4: Better use of order-0 pages in RX path

2017-03-13 Thread Eric Dumazet
On Mon, Mar 13, 2017 at 4:21 PM, Alexei Starovoitov wrote: > > is it once in the beginning only? If so then why that > 'if (!ring->page_cache.index)' check is done for every packet? You did not really read the patch, otherwise you would not ask these questions.

Re: [PATCH net-next] mlx4: Better use of order-0 pages in RX path

2017-03-13 Thread Alexei Starovoitov
On Mon, Mar 13, 2017 at 02:09:23PM -0700, Eric Dumazet wrote: > On Mon, Mar 13, 2017 at 1:23 PM, Alexei Starovoitov > wrote: > > On Mon, Mar 13, 2017 at 11:58:05AM -0700, Eric Dumazet wrote: > >> On Mon, Mar 13, 2017 at 11:31 AM, Alexei Starovoitov > >>

Re: [PATCH v2 net-next] qed*: Utilize Firmware 8.15.3.0

2017-03-13 Thread Christoph Hellwig
On Mon, Mar 13, 2017 at 03:33:47PM -0700, David Miller wrote: > Applied, thanks. So everyone who doesn't have the very latests linux-firmware will now have a non-working card after upgrading the kernel?

Re: [PATCH net-next 4/4] net-next: dsa: add dsa support for Mediatek MT7530 switch

2017-03-13 Thread Andrew Lunn
> +static int > +mt7530_setup(struct dsa_switch *ds) > +{ > + struct mt7530_priv *priv = ds->priv; > + int ret, i, phy_mode; > + u8 cpup_mask = 0; > + u32 id, val; > + struct regmap *regmap; > + > + /* Make sure that cpu port specfied on the dt is appropriate */ > + if

[PATCH] net: ethernet: aquantia: set net_device mtu when mtu is changed

2017-03-13 Thread David Arcari
When the aquantia device mtu is changed the net_device structure is not updated. As a result the ip command does not properly reflect the mtu change. Commit 5513e16421cb incorrectly assumed that __dev_set_mtu() was making the assignment ndev->mtu = new_mtu; This is not true in the case where

Re: [PATCH net] vxlan: fix ovs support

2017-03-13 Thread David Miller
From: Nicolas Dichtel Date: Mon, 13 Mar 2017 16:24:03 +0100 > The required changes in the function vxlan_dev_create() were missing > in commit 8bcdc4f3a20b. > The vxlan device is not registered anymore after this patch and the error > path causes an stack dump: >

Re: [PATCH] net: use net->count to check whether a netns is alive or not

2017-03-13 Thread David Miller
From: Andrei Vagin Date: Sun, 12 Mar 2017 21:36:18 -0700 > The previous idea was to check whether a net namespace is in > net_exit_list or not. It doesn't work, because net->exit_list is used in > __register_pernet_operations and __unregister_pernet_operations where > all

Re: [PATCH] net: ethernet: aquantia: set net_device mtu when mtu is changed

2017-03-13 Thread David Arcari
On 03/13/2017 03:56 PM, David Miller wrote: > From: David Arcari > Date: Mon, 13 Mar 2017 11:50:50 -0400 > >> On 03/13/2017 02:09 AM, David Miller wrote: >>> From: David Arcari >>> Date: Wed, 8 Mar 2017 16:33:21 -0500 >>> When the aquantia device

Re: [PATCH net-next] net: dsa: mv88e6xxx: debug ATU Age Time

2017-03-13 Thread Andrew Lunn
On Mon, Mar 13, 2017 at 03:42:36PM -0700, Florian Fainelli wrote: > On 03/13/2017 03:39 PM, Andrew Lunn wrote: > > On Mon, Mar 13, 2017 at 03:20:43PM -0400, Vivien Didelot wrote: > >> The ATU ageing time value programmed in the switch is rounded up to the > >> nearest multiple of its coefficient

Re: [PATCH net-next] net: dsa: mv88e6xxx: set out of range ageing time

2017-03-13 Thread Andrew Lunn
On Mon, Mar 13, 2017 at 03:19:32PM -0400, Vivien Didelot wrote: > The minimum and maximum value of the ATU Age Time varies depending on > the switch model. The current code returns -ERANGE for out-of-range > values, and makes switchdev commit phase fail with this stacktrace: Hi Vivien I took a

Re: [PATCH net-next] net: dsa: mv88e6xxx: debug ATU Age Time

2017-03-13 Thread Florian Fainelli
On 03/13/2017 03:39 PM, Andrew Lunn wrote: > On Mon, Mar 13, 2017 at 03:20:43PM -0400, Vivien Didelot wrote: >> The ATU ageing time value programmed in the switch is rounded up to the >> nearest multiple of its coefficient (variable depending on the model.) >> >> Add a debug message to inform the

Re: [PATCH v7 0/6] Bluetooth: 6LoWPAN: Fix lladdr length

2017-03-13 Thread David Miller
From: Luiz Augusto von Dentz Date: Sun, 12 Mar 2017 10:19:32 +0200 > From: Luiz Augusto von Dentz > > These patches fixes lladdr length to be 6 bytes long and not 8 which cause > neighbor advertisement to be sent with wrong lladdr including FF:FE

Re: [PATCH net-next] net: dsa: mv88e6xxx: debug ATU Age Time

2017-03-13 Thread Andrew Lunn
On Mon, Mar 13, 2017 at 03:20:43PM -0400, Vivien Didelot wrote: > The ATU ageing time value programmed in the switch is rounded up to the > nearest multiple of its coefficient (variable depending on the model.) > > Add a debug message to inform the user about the exact programmed value. > > On

Re: [PATCH] mpls: Do not decrement alive counter for unregister events

2017-03-13 Thread David Ahern
On 3/13/17 3:11 PM, David Ahern wrote: > On 3/13/17 5:10 AM, Robert Shearman wrote: >> Doesn't this leave the problem that if the device's link goes down and >> then the device gets deleted the alive count will be decremented twice >> for the same path? > yes. and it exposes another bug in

Re: [Patch net-next] atm: remove an unnecessary loop

2017-03-13 Thread David Miller
From: Chas Williams <3ch...@gmail.com> Date: Sat, 11 Mar 2017 19:41:36 -0500 > From: Francois Romieu > > Andrey reported this kernel warning: > > WARNING: CPU: 0 PID: 4114 at kernel/sched/core.c:7737 > __might_sleep+0x149/0x1a0 > do not call blocking ops when

Re: [PATCH v2 net-next] qed*: Utilize Firmware 8.15.3.0

2017-03-13 Thread David Miller
From: Yuval Mintz Date: Sat, 11 Mar 2017 18:39:18 +0200 > This patch advances the qed* drivers into using the newer firmware - > This solves several firmware bugs, mostly related [but not limited to] > various init/deinit issues in various offloaded protocols. > > It

Re: [PATCH] usbnet: smsc95xx: Reduce logging noise

2017-03-13 Thread David Miller
From: Guenter Roeck Date: Fri, 10 Mar 2017 17:45:21 -0800 > An insert/remove stress test generated the following log message sequence. ... > Use netdev_dbg() instead of netdev_warn() for the repeating messages > to reduce logging noise. > > Signed-off-by: Guenter Roeck

Re: [PATCH net-next v3 0/2] mpls: allow TTL propagation to/from IP packets to be configured

2017-03-13 Thread David Miller
From: Robert Shearman Date: Fri, 10 Mar 2017 20:43:23 + > It is sometimes desirable to present an MPLS transport network as a > single hop to traffic transiting it because it prevents confusion when > diagnosing failures. An example of where confusion can be generated

Re: [PATCH] net: usb: asix88179_178a: use new api ethtool_{get|set}_link_ksettings

2017-03-13 Thread David Miller
From: Philippe Reynes Date: Sun, 12 Mar 2017 18:02:36 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] net: usb: catc: use new api ethtool_{get|set}_link_ksettings

2017-03-13 Thread David Miller
From: Philippe Reynes Date: Sun, 12 Mar 2017 22:08:26 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] net: usb: r8152: use new api ethtool_{get|set}_link_ksettings

2017-03-13 Thread David Miller
From: Philippe Reynes Date: Sun, 12 Mar 2017 22:41:58 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH] net: net_netdev: use new api ethtool_{get|set}_link_ksettings

2017-03-13 Thread David Miller
From: Philippe Reynes Date: Thu, 9 Mar 2017 23:10:13 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > >

Re: [PATCH v2] net: tun: use new api ethtool_{get|set}_link_ksettings

2017-03-13 Thread David Miller
From: Philippe Reynes Date: Sat, 11 Mar 2017 22:03:50 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > Signed-off-by: Philippe Reynes > --- > Changelog: > v2: > - Finaly, I've found

Re: [PATCH net-next 1/1 v2] net: rmnet_data: Initial implementation

2017-03-13 Thread kbuild test robot
Hi Subash, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Subash-Abhinov-Kasiviswanathan/net-rmnet_data-Initial-implementation/20170313-174754 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF

Re: [PATCH 5/7] ath9k: of: Use the clk API to get the reference clock rate

2017-03-13 Thread Rafał Miłecki
On 03/13/2017 10:05 PM, Alban wrote: @@ -573,6 +575,12 @@ static int ath9k_of_init(struct ath_softc *sc) ath_dbg(common, CONFIG, "parsing configuration from OF node\n"); + clk = clk_get(sc->dev, "ref"); + if (!IS_ERR(clk)) { + ah->is_clk_25mhz =

Re: [PATCH 3/7] ath9k: Add support for reading the EEPROM data using the nvmem API

2017-03-13 Thread Rafał Miłecki
On 03/13/2017 10:05 PM, Alban wrote: @@ -654,6 +656,25 @@ static int ath9k_init_softc(u16 devid, struct ath_softc *sc, if (ret) return ret; + /* If the EEPROM hasn't been retrieved via firmware request +* use the nvmem API insted. +*/ + if

Re: [PATCH net-next RFC v1 00/27] afnetns: new namespace type for separation on protocol level

2017-03-13 Thread Eric W. Biederman
Michael Kerrisk writes: > On Mon, Mar 13, 2017 at 12:44 AM, Hannes Frederic Sowa > wrote: >> Hi, >> >> On Sun, 2017-03-12 at 16:26 -0700, David Miller wrote: >>> From: Hannes Frederic Sowa >>> Date: Mon, 13 Mar

Re: [PATCH v2] net: ethernet: aquantia: set net_device mtu when mtu is changed

2017-03-13 Thread David Miller
From: David Arcari Date: Mon, 13 Mar 2017 16:30:52 -0400 > Please drop v2 of this patch. We would like to have v1 applied. Resubmit v1 again if you want me to do this.

Re: [PATCH net-next 1/1 v2] net: rmnet_data: Initial implementation

2017-03-13 Thread Subash Abhinov Kasiviswanathan
On 2017-03-13 02:54, Jiri Pirko wrote: Mon, Mar 13, 2017 at 08:43:09AM CET, subas...@codeaurora.org wrote: RmNet Data driver provides a transport agnostic MAP (multiplexing and Why "data"? Why not just "rmnet"?? Btw, what is "RmNet". Google does not give me much. Is it some priprietady

Re: [PATCH 1/1] r8152: fix NULL pointer dereference in r8152_poll

2017-03-13 Thread Petr Vorel
> > > Unfortunately this doesn't work. Code in r8152.c doesn't use > > > local_bh_enable()/local_bh_disable(). I tried to lock it with > > > spin_lock_bh()/spin_unlock_bh() and with mutex_lock()/mutex_unlock() > > > but neither work. > > The local_bh_disable() / local_bh_enable() definitely is

Re: [PATCH net] vxlan: fix ovs support

2017-03-13 Thread Roopa Prabhu
On 3/13/17, 8:24 AM, Nicolas Dichtel wrote: > The required changes in the function vxlan_dev_create() were missing > in commit 8bcdc4f3a20b. > The vxlan device is not registered anymore after this patch and the error > path causes an stack dump: > WARNING: CPU: 3 PID: 1498 at net/core/dev.c:6713

[PATCH 7/7] ath9k: hw: Reset the device with the external reset before init

2017-03-13 Thread Alban
On the SoC platform the board code often manually reset the device before registering it. To allow the same to happen on DT platforms let the driver call the reset before init. Signed-off-by: Alban --- drivers/net/wireless/ath/ath9k/hw.c | 7 +++ 1 file changed, 7

Re: [PATCH] mpls: Do not decrement alive counter for unregister events

2017-03-13 Thread David Ahern
On 3/13/17 5:10 AM, Robert Shearman wrote: > Doesn't this leave the problem that if the device's link goes down and > then the device gets deleted the alive count will be decremented twice > for the same path? yes. and it exposes another bug in multipath selection. > > Perhaps it would be

Re: [PATCH net-next] mlx4: Better use of order-0 pages in RX path

2017-03-13 Thread Eric Dumazet
On Mon, Mar 13, 2017 at 1:23 PM, Alexei Starovoitov wrote: > On Mon, Mar 13, 2017 at 11:58:05AM -0700, Eric Dumazet wrote: >> On Mon, Mar 13, 2017 at 11:31 AM, Alexei Starovoitov >> wrote: >> > On Mon, Mar 13, 2017 at 10:50:28AM -0700,

[PATCH 3/7] ath9k: Add support for reading the EEPROM data using the nvmem API

2017-03-13 Thread Alban
Currently SoC platforms use a firmware request to get the EEPROM data. This is mostly a hack and rely on using a user-helper scripts which is deprecated. A nicer alternative is to use the nvmem API which was designed for this kind of task. Furthermore we let CONFIG_ATH9K_AHB select CONFIG_NVMEM

[PATCH 5/7] ath9k: of: Use the clk API to get the reference clock rate

2017-03-13 Thread Alban
If a clock named "ref" exists use it to get the reference clock rate. Signed-off-by: Alban --- drivers/net/wireless/ath/ath9k/init.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c index

[PATCH 6/7] ath9k: Allow using the reset API for the external reset

2017-03-13 Thread Alban
From: Alban Bedel Allow using the reset API instead of a platform specific callback to reset the device. Signed-off-by: Alban Bedel --- drivers/net/wireless/ath/ath9k/hw.c | 26 +- drivers/net/wireless/ath/ath9k/hw.h | 1 +

[PATCH 4/7] ath9k: Add support for reading the MAC address with nvmem

2017-03-13 Thread Alban
On embedded platforms the MAC address is often stored in flash, use nvmem to read it if the platform data or DT didn't specify one. Signed-off-by: Alban --- drivers/net/wireless/ath/ath9k/init.c | 33 + 1 file changed, 33 insertions(+) diff --git

[PATCH 2/7] ath9k: ahb: Add OF support

2017-03-13 Thread Alban
Allow registering ath9k AHB devices defined in DT. This just add the compatible strings to allow matching the driver and setting the proper device ID. Signed-off-by: Alban --- drivers/net/wireless/ath/ath9k/ahb.c | 47 +--- 1 file changed, 43

[PATCH 1/7] Documentation: dt: net: Update the ath9k binding for SoC devices

2017-03-13 Thread Alban
The current binding only cover PCI devices so extend it for SoC devices. Most SoC platforms use an MTD partition for the calibration data instead of an EEPROM. The qca,no-eeprom property was added to allow loading the EEPROM content using firmware loading. This new binding replace this hack with

Re: [RESEND PATCH -net] cpsw/netcp: cpts depends on posix_timers

2017-03-13 Thread Nicolas Pitre
On Mon, 13 Mar 2017, Nicolas Pitre wrote: > So unless I'm mistaken I don't see any problem using "depends on > PTP_1588_CLOCK" here. Furthermore that wouldn't be a first. See for example PTP_1588_CLOCK_GIANFAR, PTP_1588_CLOCK_IXP46X, DP83640_PHY, etc. Nicolas

  1   2   3   4   >