Re: [PATCH 1/1] ethtool : added get_phy_stats,get_strings,get_sset_count

Hello, On 03/27/2017 03:12 AM, Thomas Scariah wrote: > From: "Scariah, Thomas" > > Added functions to support ethtool to print the phy statistics and error > information along with other ethtool statistics. This will help ethtool > information to know the error is

Re: [PATCH net-next 1/4] net: mpls: Convert number of nexthops to u8

On 3/26/17 9:11 PM, Eric W. Biederman wrote: > I don't like this. Byte writes don't exist on all architectures. > > So while I think always writing to rtn_nhn_alive under the > rtn_lock ensures that we don't have wrong values written > it is quite subtle. And I don't know how this will interact

RE: [PATCH] net: netfilter: Remove multiple assignment.

From: Pablo Neira Ayuso > Sent: 27 March 2017 13:08 > On Sat, Mar 25, 2017 at 06:19:47PM +0530, Arushi Singhal wrote: > > This patch removes multiple assignments. > > Done using coccinelle. > > @@ > > identifier i1,i2; > > constant c; > > @@ > > - i1=i2=c; > > + i1=c; > > + i2=c; > > You have to

Re: [PATCH RFC v2 3/3] net: phy: allow EEE with SGMII interface modes

On 03/27/2017 02:59 AM, Russell King wrote: > As EEE is able to work in SGMII mode as well, add it to the list of > permissable EEE modes that phy_init_eee() will accept. This is > necessary so that EEE can work with an 88E1512 connected in SGMII mode. As you mention in your cover letter, we

Re: [PATCH net-next v3 3/3] net: phy: Allow splitting MDIO bus/device support from PHYs

On Thu, Mar 23, 2017 at 6:01 PM, Florian Fainelli wrote: > Introduce a new configuration symbol: MDIO_DEVICE which allows building > the MDIO devices and bus code, without pulling in the entire Ethernet > PHY library and devices code. > > PHYLIB nows select MDIO_DEVICE and

RE: [PATCH 5/5] PCI: remove pci_enable_msix

From: 'Christoph Hellwig' > Sent: 27 March 2017 15:52 > On Mon, Mar 27, 2017 at 02:06:45PM +, David Laight wrote: > > Apart from all the 'out of tree' drivers that will need > > fixing and a conditional compile added. > > That has never been a reason for stopping linux kernel changes. I'm

Re: Page allocator order-0 optimizations merged

On Mon, 27 Mar 2017 07:15:18 -0700 Matthew Wilcox wrote: > On Mon, Mar 27, 2017 at 02:39:47PM +0200, Jesper Dangaard Brouer wrote: > > > > +static __always_inline int in_irq_or_nmi(void) > > +{ > > + return in_irq() || in_nmi(); > > +// XXX: hoping compiler will optimize

Re: [PATCH 1/5] net: thunderx: switch to pci_alloc_irq_vectors

On Mon, Mar 27, 2017 at 1:59 PM, Christoph Hellwig wrote: > Remove the deprecated pci_enable_msix API in favour of it's successor. > > Signed-off-by: Christoph Hellwig > --- > drivers/net/ethernet/cavium/thunder/nic_main.c | 75 > ++ > 1 file

Re: Extending socket timestamping API for NTP

> On Mar 27, 2017, at 07:29, Richard Cochran wrote: > > At the end of the day, the correction in the igb driver is useless and > even harmful. Why? Because if the app cares about this level of > accuracy, it is going to have to implement special logic anyhow, and >

RE: [net-next 05/11] i40e: fix for queue timing delays

> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Saturday, March 25, 2017 8:01 PM > To: Kirsher, Jeffrey T > Cc: Wyborny, Carolyn ; > netdev@vger.kernel.org; nhor...@redhat.com; sassm...@redhat.com; >

Re: [PATCH 5/5] PCI: remove pci_enable_msix

On Mon, Mar 27, 2017 at 02:06:45PM +, David Laight wrote: > Apart from all the 'out of tree' drivers that will need > fixing and a conditional compile added. That has never been a reason for stopping linux kernel changes. Never mind that your out of tree drivers should probably never have

Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

From: Corentin Labbe Date: Mon, 27 Mar 2017 19:00:58 +0200 > On Mon, Mar 27, 2017 at 04:26:48PM +0100, Joao Pinto wrote: >> Hi David, >> >> Às 7:26 AM de 3/25/2017, Corentin Labbe escreveu: >> > On Fri, Mar 24, 2017 at 05:16:45PM +, Joao Pinto wrote: >> >> For

[PATCH net-next 1/2] flow_dissector: add mpls support

Add support for parsing MPLS flows to the flow dissector in preparation for adding MPLS match support to cls_flower. Signed-off-by: Benjamin LaHaise Signed-off-by: Benjamin LaHaise Reviewed-by: Simon Horman

Re: [PATCH ethtool] ethtool: Support for configurable RSS hash function

On Sat, Mar 25, 2017 at 02:50:47PM -0700, Jakub Kicinski wrote: > On Wed, 8 Mar 2017 16:03:51 +0200, Gal Pressman wrote: > > This ethtool patch adds support to set and get the current RSS hash > > function for the device through the new hfunc mask field in the > > ethtool_rxfh struct. Kernel

[PATCH next 4/5] bonding: correctly update link status during mii-commit phase

From: Mahesh Bandewar bond_miimon_commit() marks the link UP after attempting to get the speed and duplex settings for the link. There is a possibility that bond_update_speed_duplex() could fail. This is another place where it could result into an inconsistent bonding link

Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

On Mon, Mar 27, 2017 at 06:44:22PM +0100, Joao Pinto wrote: > Às 6:28 PM de 3/27/2017, David Miller escreveu: > > From: Corentin Labbe > > Date: Mon, 27 Mar 2017 19:00:58 +0200 > > > >> On Mon, Mar 27, 2017 at 04:26:48PM +0100, Joao Pinto wrote: > >>> Hi David, > >>> >

in_irq_or_nmi()

On Mon, Mar 27, 2017 at 05:15:00PM +0200, Jesper Dangaard Brouer wrote: > And I also verified it worked: > > 0.63 │ mov__preempt_count,%eax >│ free_hot_cold_page(): > 1.25 │ test $0x1f,%eax >│ ↓ jne1e4 > > And this simplification also made

Re: [PATCH RFC v2 3/3] net: phy: allow EEE with SGMII interface modes

On Mon, Mar 27, 2017 at 09:47:31AM -0700, Florian Fainelli wrote: > On 03/27/2017 02:59 AM, Russell King wrote: > > As EEE is able to work in SGMII mode as well, add it to the list of > > permissable EEE modes that phy_init_eee() will accept. This is > > necessary so that EEE can work with an

[PATCH] net: ipconfig: fix ic_close_devs() use-after-free

Our chosen ic_dev may be anywhere in our list of ic_devs, and we may free it before attempting to close others. When we compare d->dev and ic_dev->dev, we're potentially dereferencing memory returned to the allocator. This causes KASAN to scream for each subsequent ic_dev we check. As there's a

Re: [PATCH RFC v2 3/3] net: phy: allow EEE with SGMII interface modes

On 03/27/2017 10:00 AM, Russell King - ARM Linux wrote: > On Mon, Mar 27, 2017 at 09:47:31AM -0700, Florian Fainelli wrote: >> On 03/27/2017 02:59 AM, Russell King wrote: >>> As EEE is able to work in SGMII mode as well, add it to the list of >>> permissable EEE modes that phy_init_eee() will

[RFC PATCH iproute2 net-next] tc flower: support for matching MPLS

[RFC until kernel code is accepted/rejected] This patch adds support to the iproute2 tc filter command for matching MPLS labels in the flower classifier. The ability to match the Time To Live, Bottom Of Stack, Traffic Control and Label fields are added as options to the flower filter.

Re: Extending socket timestamping API for NTP

On Mon, Mar 27, 2017 at 09:25:03AM -0700, Denny Page wrote: > I agree that the values in the igb driver are incorrect. They were > middle of the range values from the old tables. At least for 100Mb, > Intel seems to know that the original table was incorrect. I’ve done > extensive measurements of

Re: [PATCH 1/1] ethtool : added get_phy_stats,get_strings,get_sset_count

> > static int cpsw_get_sset_count(struct net_device *ndev, int sset) > > { > > + struct cpsw_priv *priv = netdev_priv(ndev); > > + int slave_no = cpsw_slave_index(priv); > > + int count; > > + > > switch (sset) { > > case ETH_SS_STATS: > > - return CPSW_STATS_LEN; > > +

Re: [PATCH 1/1] ethtool : added get_phy_stats,get_strings,get_sset_count

On Mon, Mar 27, 2017 at 09:44:37AM -0700, Florian Fainelli wrote: > Hello, > > On 03/27/2017 03:12 AM, Thomas Scariah wrote: > > From: "Scariah, Thomas" > > > > Added functions to support ethtool to print the phy statistics and error > > information along with other

Re: [PATCH RFC v2 1/3] net: phy: avoid setting unsupported EEE advertisments

On 03/27/2017 02:58 AM, Russell King wrote: > We currently allow userspace to set any EEE advertisments it desires, > whether or not the PHY supports them. For example: > > # ethtool --set-eee eth1 advertise 0x > # ethtool --show-eee eth1 > EEE Settings for eth1: > EEE status:

[PATCH next 2/5] bonding: improve link-status update in mii-monitoring

From: Mahesh Bandewar The primary issue is that mii-inspect phase updates link-state and expects changes to be committed during the mii-commit phase. After the inspect phase if it fails to acquire rtnl-mutex, the commit phase (bond_mii_commit) doesn't get to run. This

[PATCH next 1/5] bonding: split bond_set_slave_link_state into two parts

From: Mahesh Bandewar Split the function into two (a) propose (b) commit phase without changing the semantics for the original API. Signed-off-by: Mahesh Bandewar --- include/net/bonding.h | 22 +- 1 file changed, 17 insertions(+), 5

[PATCH next 3/5] bonding: make speed, duplex setting consistent with link state

From: Mahesh Bandewar bond_update_speed_duplex() retrieves speed and duplex settings. There is a possibility of failure in retrieving these values but caller has to assume it's always successful. This leads to having inconsistent slave link settings. If these (speed, duplex)

[PATCH next 0/5] link-status fixes for mii-monitoring

From: Mahesh Bandewar The mii monitoring is divided into two phases - inspect and commit. The inspect phase technically should not make any changes to the state and defer it to the commit phase. However detected link state inconsistencies on several machines and discovered

Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

Às 6:00 PM de 3/27/2017, Corentin Labbe escreveu: > On Mon, Mar 27, 2017 at 04:26:48PM +0100, Joao Pinto wrote: >> Hi David, >> >> Às 7:26 AM de 3/25/2017, Corentin Labbe escreveu: >>> On Fri, Mar 24, 2017 at 05:16:45PM +, Joao Pinto wrote: For cores that have more than 1 TX queue

[PATCH net] MAINTAINERS: Add Andrew Lunn as co-maintainer of PHYLIB

Andrew has been contributing a lot to PHYLIB over the past months and his feedback on patches is more than welcome. Signed-off-by: Florian Fainelli --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH RFC net-next 1/3] net: mdio: add definition for MDIO_STAT1_CLOCK_STOP_CAPABLE

Add the definition for the Clause 45 IEEE PCS Status 1 Register (3.1) reporting whether a PHY supports stopping its clock or not during LPI (EEE). Signed-off-by: Florian Fainelli --- include/uapi/linux/mdio.h | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH RFC net-next 0/3] net: phy: Read if PHY can stop its clock

This patch series update PHYLIB to read whether the PHY is actually capable of stopping its clocks during EEE low power modes. One problem (not the only one) with phy_init_eee() is that it takes a clk_stop_enable argument that the caller has no idea how to determine. This patch series makes the

[PATCH RFC net-next 2/3] net: phy: read whether PHY supports stopping clock during LPI

In order to use phy_init_eee() correctly, in particular the clk_stop argument, we need to know whether the Ethernet PHY supports stopping its clock. Right now, we would have to call phy_init_eee(phydev, 1), see if that tails, and call again with phy_init_eee(phydev, 0) to enable EEE this is not

[PATCH RFC net-next 3/3] net: phy: stop the PHY clock during LPI only if supported

Now that we detect whether a PHY supports stopping its clock during LPI, deny a call to phy_init_eee() with clk_stop_enable being set and the PHY not supporting that. Signed-off-by: Florian Fainelli --- drivers/net/phy/phy.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

On Mon, Mar 27, 2017 at 04:26:48PM +0100, Joao Pinto wrote: > Hi David, > > Às 7:26 AM de 3/25/2017, Corentin Labbe escreveu: > > On Fri, Mar 24, 2017 at 05:16:45PM +, Joao Pinto wrote: > >> For cores that have more than 1 TX queue configured, the kernel would > >> crash, > >> since only one

Re: [PATCH 5/5] PCI: remove pci_enable_msix

On Mon, Mar 27, 2017 at 09:59:35AM -0700, David Daney wrote: > On 03/27/2017 01:29 AM, Christoph Hellwig wrote: >> Unused now that all callers switched to pci_alloc_irq_vectors. >> > > And you are aware that the ThunderX GPIO driver that I am attempting to > merge uses this interface. > > If this

Re: [PATCH 5/5] PCI: remove pci_enable_msix

On Mon, Mar 27, 2017 at 03:03:30PM +, David Laight wrote: > Indeed, but pci_enable_msix_range() only appeared in 3.14. > We have to support a wide range of kernels. > I think we've finally managed to get most of our customers off 2.6.18. That's your problem, not that of upstream kernel

Re: [PATCH 1/5] net: thunderx: switch to pci_alloc_irq_vectors

On Mon, Mar 27, 2017 at 09:33:32PM +0530, Sunil Kovvuri wrote: > How urgent is this ? I would like to get this into 4.12 to stop people from adding new users of pci_enable_msix. > Can we comeup with a proper patch to fix this in couple of weeks, instead of > going with these untested patches ?

Re: [PATCH 5/5] PCI: remove pci_enable_msix

On 03/27/2017 10:11 AM, Christoph Hellwig wrote: On Mon, Mar 27, 2017 at 09:59:35AM -0700, David Daney wrote: On 03/27/2017 01:29 AM, Christoph Hellwig wrote: Unused now that all callers switched to pci_alloc_irq_vectors. And you are aware that the ThunderX GPIO driver that I am attempting

Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

Às 6:28 PM de 3/27/2017, David Miller escreveu: > From: Corentin Labbe > Date: Mon, 27 Mar 2017 19:00:58 +0200 > >> On Mon, Mar 27, 2017 at 04:26:48PM +0100, Joao Pinto wrote: >>> Hi David, >>> >>> Às 7:26 AM de 3/25/2017, Corentin Labbe escreveu: On Fri, Mar 24,

[PATCH net-next 2/2] cls_flower: add support for matching MPLS labels

Add support to tc flower to match based on fields in MPLS labels (TTL, Bottom of Stack, TC field, Label). Signed-off-by: Benjamin LaHaise Signed-off-by: Benjamin LaHaise Reviewed-by: Simon Horman Reviewed-by: Jakub

Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

On Mon, Mar 27, 2017 at 06:06:05PM +0100, Joao Pinto wrote: > Às 6:00 PM de 3/27/2017, Corentin Labbe escreveu: > > On Mon, Mar 27, 2017 at 04:26:48PM +0100, Joao Pinto wrote: > >> Hi David, > >> > >> Às 7:26 AM de 3/25/2017, Corentin Labbe escreveu: > >>> On Fri, Mar 24, 2017 at 05:16:45PM +,

Re: [PATCH 5/5] PCI: remove pci_enable_msix

On 03/27/2017 01:29 AM, Christoph Hellwig wrote: Unused now that all callers switched to pci_alloc_irq_vectors. And you are aware that the ThunderX GPIO driver that I am attempting to merge uses this interface. If this patch gets merged, should I ask to revert it when the GPIO driver goes

Re: [PATCH RFC v2 2/3] net: phy: restart phy autonegotiation after EEE advertisment change

On 03/27/2017 02:58 AM, Russell King wrote: > When the EEE advertisment is changed, we should restart autonegotiation > to update the link partner with the new EEE settings. Add this trigger > but only if the advertisment has changed. > > Signed-off-by: Russell King

[PATCH next 5/5] bonding: avoid printing while holding a spinlock

From: Mahesh Bandewar Signed-off-by: Mahesh Bandewar --- drivers/net/bonding/bond_3ad.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.c index

Re: Extending socket timestamping API for NTP

> On Mar 27, 2017, at 11:28, Richard Cochran wrote: > > On Mon, Mar 27, 2017 at 09:25:03AM -0700, Denny Page wrote: > >> I agree that the values in the igb driver are incorrect. They were >> middle of the range values from the old tables. At least for 100Mb, >> Intel

Re: Extending socket timestamping API for NTP

[Resend in plain text for vger] > On Mar 27, 2017, at 11:28, Richard Cochran wrote: > > On Mon, Mar 27, 2017 at 09:25:03AM -0700, Denny Page wrote: > >> I agree that the values in the igb driver are incorrect. They were >> middle of the range values from the old

Re: Extending socket timestamping API for NTP

[Resend in plain text for vger] > On Mar 27, 2017, at 11:28, Richard Cochran wrote: > > I didn't do anything super methodical, and I didn't keep notes, but I > had a phyter (whose delays were published by TI and independently > confirmed in a ISPCS paper by Christian

Re: [PATCH RFC v2 3/3] net: phy: allow EEE with SGMII interface modes

On 03/27/2017 12:47 PM, Russell King - ARM Linux wrote: > On Mon, Mar 27, 2017 at 11:03:12AM -0700, Florian Fainelli wrote: >> On 03/27/2017 10:00 AM, Russell King - ARM Linux wrote: >>> On Mon, Mar 27, 2017 at 09:47:31AM -0700, Florian Fainelli wrote: On 03/27/2017 02:59 AM, Russell King

Re: [PATCH RFC v2 3/3] net: phy: allow EEE with SGMII interface modes

On Mon, Mar 27, 2017 at 11:03:12AM -0700, Florian Fainelli wrote: > On 03/27/2017 10:00 AM, Russell King - ARM Linux wrote: > > On Mon, Mar 27, 2017 at 09:47:31AM -0700, Florian Fainelli wrote: > >> On 03/27/2017 02:59 AM, Russell King wrote: > >>> As EEE is able to work in SGMII mode as well, add

Re: [PATCH RFC v4 10/10] tty: serdev: add functions to retrieve common UART settings

On Mon, Mar 27, 2017 at 8:37 AM, Stefan Wahren wrote: > Currently serdev core doesn't provide functions to retrieve common > UART settings like data bits, stop bits or parity. This patch adds > the interface to the core and the necessary implementation for >

Re: [PATCH net] MAINTAINERS: Add Andrew Lunn as co-maintainer of PHYLIB

On Mon, Mar 27, 2017 at 10:48:11AM -0700, Florian Fainelli wrote: > Andrew has been contributing a lot to PHYLIB over the past months and > his feedback on patches is more than welcome. > > Signed-off-by: Florian Fainelli Thanks Florian Acked-by: Andrew Lunn

Re: [PATCH RFC v2 3/3] net: phy: allow EEE with SGMII interface modes

Here's the revised patch as requested. Thanks. 8<=== From: Russell King Subject: [PATCH] net: phy: allow EEE with any interface mode EEE is able to work in any PHY interface mode, there is nothing which fundamentally restricts it to only a few modes. For example,

Re: [PATCH RFC v4 07/10] dt-bindings: net: add binding for QCA7000 UART

On Mon, Mar 27, 2017 at 8:37 AM, Stefan Wahren wrote: > This is the serdev binding for the QCA7000 UART driver (Ethernet over UART). > > Signed-off-by: Stefan Wahren > --- > > According to this binding are still some questions: > > Where should be

Re: [PATCH] cfg80211: Fix array-bounds warning in fragment copy

El Mon, Mar 27, 2017 at 12:47:59PM +0200 Johannes Berg ha dit: > On Fri, 2017-03-24 at 18:06 -0700, Matthias Kaehlcke wrote: > > __ieee80211_amsdu_copy_frag intentionally initializes a pointer to > > array[-1] to increment it later to valid values. clang rightfully > > generates an array-bounds

[PATCH v2] cfg80211: Fix array-bounds warning in fragment copy

__ieee80211_amsdu_copy_frag intentionally initializes a pointer to array[-1] to increment it later to valid values. clang rightfully generates an array-bounds warning on the initialization statement. Initialize the pointer to array[0] and change the algorithm from increment before to increment

Re: [PATCH RFC v4 09/10] tty: serdev-ttyport: return actual baudrate from ttyport_set_baudrate

On Mon, Mar 27, 2017 at 8:37 AM, Stefan Wahren wrote: > Instead of returning the requested baudrate, we better return the > actual one because it isn't always the same. > > Signed-off-by: Stefan Wahren > --- > drivers/tty/serdev/serdev-ttyport.c |

Re: [PATCH RFC net-next 2/3] net: phy: read whether PHY supports stopping clock during LPI

On Mon, Mar 27, 2017 at 11:47:20AM -0700, Florian Fainelli wrote: > In order to use phy_init_eee() correctly, in particular the clk_stop > argument, we need to know whether the Ethernet PHY supports stopping its > clock. > > Right now, we would have to call phy_init_eee(phydev, 1), see if that >

Re: [PATCHv2 net-next 2/7] sctp: implement receiver-side procedures for the SSN/TSN Reset Request Parameter

On Mon, Mar 27, 2017 at 10:16 PM, Marcelo Ricardo Leitner wrote: > On Mon, Mar 27, 2017 at 12:48:31PM +0800, Xin Long wrote: >> On Sat, Mar 25, 2017 at 7:52 AM, Marcelo Ricardo Leitner >> wrote: >> > On Tue, Mar 21, 2017 at 01:44:32PM +0800,

[PATCH 4/5] net/ena: switch to pci_alloc_irq_vectors

Remove the deprecated pci_enable_msix API in favour of it's successor. Signed-off-by: Christoph Hellwig --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 55 ++-- drivers/net/ethernet/amazon/ena/ena_netdev.h | 2 - 2 files changed, 12 insertions(+), 45

Re: [PATCH 1/5] rds: tcp: release the created connection

On (03/27/17 16:05), Yanjun Zhu wrote: > Sorry. I just made simple test. It seems that it worked well. Would you like > to show me some test about this patch? > Your patch is a non-trivial bug. Dont do this. Please read the comments above the "goto rst_nsk" in that function. Also note the

[PATCH net-next] ipv6: sr: select DST_CACHE by default

When CONFIG_IPV6_SEG6_LWTUNNEL is selected, automatically select DST_CACHE. This allows to remove multiple ifdefs. Signed-off-by: David Lebrun --- net/ipv6/Kconfig | 1 + net/ipv6/seg6_iptunnel.c | 18 -- 2 files changed, 1 insertion(+), 18

[PATCH RFC v2] net: phy: improve phylib correctness for non-autoneg settings

phylib has some undesirable behaviour when forcing a link mode through ethtool. phylib uses this code: idx = phy_find_valid(phy_find_setting(phydev->speed, phydev->duplex), features); to find an index in the settings table. phy_find_setting() starts at index 0,

[PATCH 1/1] ethtool : added get_phy_stats,get_strings,get_sset_count

From: "Scariah, Thomas" Added functions to support ethtool to print the phy statistics and error information along with other ethtool statistics. This will help ethtool information to know the error is from physical layer or MAC layer. This is an enahancement for

Re: Extending socket timestamping API for NTP

On Fri, Mar 24, 2017 at 10:17:51AM -0700, Denny Page wrote: > > On Mar 24, 2017, at 02:45, Miroslav Lichvar wrote: > > How common is to have link speed changing in normal operation on LAN? > > In my case, it’s currently every few minutes because I’m doing hw timestamp >

Re: [PATCH V8 1/3] irq: Add flags to request_percpu_irq function

On Thu, Mar 23, 2017 at 06:42:01PM +0100, Daniel Lezcano wrote: > diff --git a/drivers/clocksource/timer-nps.c b/drivers/clocksource/timer-nps.c > index da1f798..dbdb622 100644 > --- a/drivers/clocksource/timer-nps.c > +++ b/drivers/clocksource/timer-nps.c > @@ -256,7 +256,7 @@ static int __init

Re: Page allocator order-0 optimizations merged

On Mon, 27 Mar 2017 03:32:47 -0400 (EDT) Pankaj Gupta wrote: > Hello, > > It looks like a race with softirq and normal process context. > > Just thinking if we really want allocations from 'softirqs' to be > done using per cpu list? Yes, softirq need fast page allocs. The

remove pci_enable_msix()

Hi all, this series removes the remaining callers of the pci_enable_msix() function and then the function itself. All remaining users in in network drivers, so if Bjorn is fine with it I'd like to handle it entirely through the netdev tree.

[PATCH 5/5] PCI: remove pci_enable_msix

Unused now that all callers switched to pci_alloc_irq_vectors. Signed-off-by: Christoph Hellwig --- drivers/pci/msi.c | 21 - include/linux/pci.h | 4 2 files changed, 25 deletions(-) diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index

[PATCH 1/5] net: thunderx: switch to pci_alloc_irq_vectors

Remove the deprecated pci_enable_msix API in favour of it's successor. Signed-off-by: Christoph Hellwig --- drivers/net/ethernet/cavium/thunder/nic_main.c | 75 ++ 1 file changed, 15 insertions(+), 60 deletions(-) diff --git

Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

Às 7:26 AM de 3/25/2017, Corentin Labbe escreveu: > On Fri, Mar 24, 2017 at 05:16:45PM +, Joao Pinto wrote: >> For cores that have more than 1 TX queue configured, the kernel would crash, >> since only one TX queue is permitted by default. >> >> Signed-off-by: Joao Pinto

Re: [4.9.13] brcmf use-after-free on resume

+ Johannes On 6-3-2017 11:48, Arend Van Spriel wrote: > + linux-wireless > > On 6-3-2017 8:04, Daniel J Blueman wrote: >> When resuming from suspend with a BCM43602 on Ubuntu 16.04 with >> 4.9.13, we see use after free [1]. >> >> We see the struct cfg80211_ops is accessed in the resume path,

RE: [PATCH] igb: add module param to set max-rss-queues.

From: gree...@candelatech.com > Sent: 24 March 2017 20:59 > From: Ben Greear > > In systems where you may have a very large number of network > adapters, certain drivers may consume an unfair amount of > IRQ resources. So, allow a module param that will limit the >

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

Às 10:28 AM de 3/27/2017, Alexandre Torgue escreveu: > Hi Joao > > On 03/24/2017 06:09 PM, Joao Pinto wrote: >> >> Hello David, >> >> Às 5:05 PM de 3/24/2017, David Miller escreveu: >>> From: Andrew Lunn >>> Date: Fri, 24 Mar 2017 12:17:36 +0100 >>> > Yes it would be

[PATCH RFC v2 1/3] net: phy: avoid setting unsupported EEE advertisments

We currently allow userspace to set any EEE advertisments it desires, whether or not the PHY supports them. For example: # ethtool --set-eee eth1 advertise 0x # ethtool --show-eee eth1 EEE Settings for eth1: EEE status: disabled Tx LPI: disabled Supported EEE

Re: [PATCH net-next 0/2] net: mpls: multipath route cleanups

On 24/03/17 22:21, David Ahern wrote: When a device associated with a nexthop is deleted, the nexthop in the route is effectively removed, so remove it from the route dump. Further, when all nexhops have been deleted the route is effectively done, so remove the route. David Ahern (2): mpls:

Re: Page allocator order-0 optimizations merged

Hello, It looks like a race with softirq and normal process context. Just thinking if we really want allocations from 'softirqs' to be done using per cpu list? Or we can have some check in 'free_hot_cold_page' for softirqs to check if we are on a path of returning from hard interrupt don't

[PATCH 3/5] net: alx: switch to pci_alloc_irq_vectors

Remove the deprecated pci_enable_msix API in favour of it's successor, and make sure to handle errors during IRQ setup properly. Signed-off-by: Christoph Hellwig --- drivers/net/ethernet/atheros/alx/alx.h | 6 -- drivers/net/ethernet/atheros/alx/main.c | 128

[PATCH 2/5] net: thunderxvf: switch to pci_alloc_irq_vectors

Remove the deprecated pci_enable_msix API in favour of it's successor. Signed-off-by: Christoph Hellwig --- drivers/net/ethernet/cavium/thunder/nic.h| 2 - drivers/net/ethernet/cavium/thunder/nicvf_main.c | 70 2 files changed, 24 insertions(+), 48

Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

On Mon, Mar 27, 2017 at 10:04:57AM +0100, Joao Pinto wrote: > Às 7:26 AM de 3/25/2017, Corentin Labbe escreveu: > > On Fri, Mar 24, 2017 at 05:16:45PM +, Joao Pinto wrote: > >> For cores that have more than 1 TX queue configured, the kernel would > >> crash, > >> since only one TX queue is

Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

Às 10:09 AM de 3/27/2017, Corentin Labbe escreveu: > On Mon, Mar 27, 2017 at 10:04:57AM +0100, Joao Pinto wrote: >> Às 7:26 AM de 3/25/2017, Corentin Labbe escreveu: >>> On Fri, Mar 24, 2017 at 05:16:45PM +, Joao Pinto wrote: For cores that have more than 1 TX queue configured, the kernel

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

Hi Joao On 03/24/2017 06:09 PM, Joao Pinto wrote: Hello David, Às 5:05 PM de 3/24/2017, David Miller escreveu: From: Andrew Lunn Date: Fri, 24 Mar 2017 12:17:36 +0100 Yes it would be fantastic to have a set of boards, but I rarely see this in any maintainer :). Being a

[PATCH RFC v2 0/3] phylib EEE updates

Florian, This series of patches depends on the previous set of changes, and is therefore net-next material. While testing the EEE code, I discovered a number of issues: 1. It is possible to enable advertisment of EEE modes which are not supported by the hardware. We omit to check the

[PATCH RFC v2 2/3] net: phy: restart phy autonegotiation after EEE advertisment change

When the EEE advertisment is changed, we should restart autonegotiation to update the link partner with the new EEE settings. Add this trigger but only if the advertisment has changed. Signed-off-by: Russell King --- drivers/net/phy/phy.c | 21 +++--

[PATCH RFC v2 3/3] net: phy: allow EEE with SGMII interface modes

As EEE is able to work in SGMII mode as well, add it to the list of permissable EEE modes that phy_init_eee() will accept. This is necessary so that EEE can work with an 88E1512 connected in SGMII mode. Signed-off-by: Russell King --- drivers/net/phy/phy.c | 1 + 1

Re: [4.9.13] brcmf use-after-free on resume

On 27-3-2017 11:24, Arend Van Spriel wrote: > + Johannes > > On 6-3-2017 11:48, Arend Van Spriel wrote: >> + linux-wireless >> >> On 6-3-2017 8:04, Daniel J Blueman wrote: >>> When resuming from suspend with a BCM43602 on Ubuntu 16.04 with >>> 4.9.13, we see use after free [1]. >>> >>> We see the

[PATCH net-next] net: ibmvnic: Remove unused net_stats member from struct ibmvnic_adapter

The ibmvnic driver keeps its statistics in net_device->stats, so the net_stats member in struct ibmvnic_adapter is unused. Remove it. Signed-off-by: Tobias Klauser --- drivers/net/ethernet/ibm/ibmvnic.h | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH 1/5] rds: tcp: release the created connection

On 2017/3/27 15:37, Sowmini Varadhan wrote: On (03/27/17 03:06), Zhu Yanjun wrote: Date: Mon, 27 Mar 2017 03:06:26 -0400 From: Zhu Yanjun To: yanjun@oracle.com, santosh.shilim...@oracle.com, netdev@vger.kernel.org, linux-r...@vger.kernel.org,

[PATCH net-next] net: bfin_mac: Remove unused stats member from struct bfin_mac_local

The bfin_mac driver keeps its statistics in net_device->stats, so the stats member in struct bfin_mac_local is unused. Remove it, as well as the accompanying comment. Cc: adi-buildroot-de...@lists.sourceforge.net Signed-off-by: Tobias Klauser ---

[PATCH net-next] net: ibmveth: Remove unused stats member from struct ibmveth_adapter

The ibmveth driver keeps its statistics in net_device->stats, so the stats member in struct ibmveth_adapter is unused. Remove it. Signed-off-by: Tobias Klauser --- drivers/net/ethernet/ibm/ibmveth.h | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH 3/5] rds: remove unnecessary returned value check

In the function rds_stats_init, the returned value is always zero. As such, it is not necessary to check it. And change the return type to void. Signed-off-by: Zhu Yanjun --- net/rds/af_rds.c | 5 + net/rds/rds.h| 2 +- net/rds/stats.c | 3 +-- 3 files changed, 3

[PATCH 5/5] rds: ib: add the static type to the functions

The functions rds_ib_flush_mr_pool and rds_ib_reuse_mr are called in the local file. As such, the static type is added to limit them in the local file. And the function rds_ib_flush_mr_pool always returns zero. As such, change the return type to void. Signed-off-by: Zhu Yanjun

[PATCH 2/5] rds: rdma: fix memory leak error

In the function __rds_rdma_map, the allocated memory and other resources should be freed when some error occurs. Signed-off-by: Zhu Yanjun --- net/rds/rdma.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/net/rds/rdma.c b/net/rds/rdma.c index f06fac4..ad9b6bd

[PATCH 0/5] rds: trivial patches

Hi, all The 5 patches are trivial patches. Thanks a lot. Zhu Yanjun (5): rds: tcp: release the created connection rds: rdma: fix memory leak error rds: remove unnecessary returned value check rds: remove the unused variable rds: ib: add the static type to the functions

[PATCH 1/5] rds: tcp: release the created connection

When some error occurs, the created connection should be destroyed. Signed-off-by: Zhu Yanjun --- net/rds/tcp_listen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/rds/tcp_listen.c b/net/rds/tcp_listen.c index 5076788..58aa5bc 100644 --- a/net/rds/tcp_listen.c

[PATCH 4/5] rds: remove the unused variable

In the function rds_ib_recv_path, the variable ret is not used. Signed-off-by: Zhu Yanjun --- net/rds/ib_recv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/rds/ib_recv.c b/net/rds/ib_recv.c index e10624a..be8d2f2 100644 ---

ath: firmware panic! exccause: 0x0000000d

I find that every time all of the cpu cores are being used, when compiling the kernel source for example, I end up losing my wireless adapter. It seems to be an old issue: https://bbs.archlinux.org/viewtopic.php?id=182173 ARM ODroid XU4 $ uname -a Linux server

Re: [PATCH 1/5] rds: tcp: release the created connection

On (03/27/17 03:06), Zhu Yanjun wrote: > Date: Mon, 27 Mar 2017 03:06:26 -0400 > From: Zhu Yanjun > To: yanjun@oracle.com, santosh.shilim...@oracle.com, > netdev@vger.kernel.org, linux-r...@vger.kernel.org, > rds-de...@oss.oracle.com, junxiao...@oracle.com,

Re: [PATCH] xfrm: use "unsigned int" in __xfrm6_pref_hash()

On Fri, Mar 24, 2017 at 01:53:09AM +0300, Alexey Dobriyan wrote: > x86_64 is zero-extending arch so "unsigned int" is preferred over "int" > for address calculations. > > Space savings: > > add/remove: 0/0 grow/shrink: 0/3 up/down: 0/-58 (-58) > function

  1   2   3   >