Re: [PATCH v4 net-next 04/10] net/ncsi: Ethtool operation to get NCSI topology

On Wed, May 03, 2017 at 10:21:11PM -0700, Stephen Hemminger wrote: >On Wed, 3 May 2017 14:44:35 +1000 >Gavin Shan wrote: > >> +void ncsi_ethtool_register_dev(struct net_device *dev) >> +{ >> +struct ethtool_ops *ops; >> + >> +ops = (struct ethtool_ops

Re: [PATCH v4 net-next 04/10] net/ncsi: Ethtool operation to get NCSI topology

On Wed, May 03, 2017 at 10:19:44PM -0700, Stephen Hemminger wrote: >On Wed, 3 May 2017 14:44:35 +1000 >Gavin Shan wrote: > >> +static int ethtool_get_ncsi_channels(struct net_device *dev, >> + void __user *useraddr) > >Please don't use

Re: new warning at net/wireless/util.c:1236

Hi, > Things still work, but when it starts warning, it generates a *lot* > of noise (I got 36 of these within about ten minutes). Yeah, that's kinda dumb - I just sent a patch to make that just warn once and actually report the configuration. > I have no idea what triggered it, because when I

[PATCH] cfg80211: make RATE_INFO_BW_20 the default

From: Johannes Berg Due to the way I did the RX bitrate conversions in mac80211 with spatch, going setting flags to setting the value, many drivers now don't set the bandwidth value for 20 MHz, since with the flags it wasn't necessary to (there was no 20 MHz flag, only

RE: [PATCH net-next 9/9] ipvlan: introduce individual MAC addresses

> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of Dan Williams > Sent: Tuesday, May 2, 2017 5:09 PM > To: Chiappero, Marco ; netdev@vger.kernel.org > Cc: David S . Miller ; Kirsher,

Re: iproute2 build error due to sr-ipv6 lwtunnel

On 05/04/2017 11:28 AM, David Lebrun wrote: On 05/04/2017 11:13 AM, Daniel Borkmann wrote: Hi David, I'm getting the following build error from e8493916a8ed ("iproute: add support for SR-IPv6 lwtunnel encapsulation"). Reverting your commit makes iproute2 build again for me. Please take a look.

Re: [PATCH v4 net-next 08/10] net/ncsi: Support NCSI packet generation

On Wed, May 03, 2017 at 02:52:54PM +0200, Andrew Lunn wrote: >On Wed, May 03, 2017 at 02:44:39PM +1000, Gavin Shan wrote: >> This introduces /sys/kernel/debug/ncsi/eth0/pkt. The debugfs entry >> can accept parameters to produce NCSI command packet. The received >> NCSI response packet is dumped on

Re: [PATCH net 2/3] qed: Fix overriding of supported autoneg value.

On Wed, May 03, 2017 at 11:52:08PM -0700, Sudarsana Reddy Kalluru wrote: > Driver currently uses advertised-autoneg value to populate the > supported-autoneg field. When advertised field is updated, user gets > the same value for supported field. Supported-autoneg value need to be > populated from

RE: sock_create_kern() and (lack of) get_net()

From: Cong Wang > Sent: 03 May 2017 17:33 > On Wed, May 3, 2017 at 4:39 AM, David Laight wrote: > > I suspect that many of the sockets created with 'kern=1' are not 'special' > > and should hold a reference to the namespace. > > They are special if they are created in

[PATCH v1] ACPI: Switch to use generic UUID API

acpi_evaluate_dsm() and friends take a pointer to a raw buffer of 16 bytes. Instead we convert them to use uuid_le type. At the same time we convert current users. acpi_str_to_uuid() becomes useless after the conversion and it's safe to get rid of it. The conversion fixes a potential bug in

iproute2 build error due to sr-ipv6 lwtunnel

Hi David, I'm getting the following build error from e8493916a8ed ("iproute: add support for SR-IPv6 lwtunnel encapsulation"). Reverting your commit makes iproute2 build again for me. Please take a look. [...] CC iplink_vrf.o CC iproute_lwtunnel.o In file included from

RE: [PATCH v4 net-next 04/10] net/ncsi: Ethtool operation to get NCSI topology

From: Gavin Shan > Sent: 04 May 2017 07:16 > On Wed, May 03, 2017 at 10:19:44PM -0700, Stephen Hemminger wrote: > >On Wed, 3 May 2017 14:44:35 +1000 > >Gavin Shan wrote: ... > >> +{ > >> + struct ethtool_ncsi_channels *enc; > >> + short nr_channels; > >Should be

Re: [PATCH v1] ACPI: Switch to use generic UUID API

On Thu, 04 May 2017, Andy Shevchenko wrote: > diff --git a/drivers/gpu/drm/i915/intel_acpi.c > b/drivers/gpu/drm/i915/intel_acpi.c > index eb638a1e69d2..72bfe6ceadf8 100644 > --- a/drivers/gpu/drm/i915/intel_acpi.c > +++ b/drivers/gpu/drm/i915/intel_acpi.c > @@

RE: [PATCH net 2/3] qed: Fix overriding of supported autoneg value.

-Original Message- From: Leon Romanovsky [mailto:l...@kernel.org] Sent: 04 May 2017 12:51 To: Kalluru, Sudarsana Cc: da...@davemloft.net; netdev@vger.kernel.org; Mintz, Yuval Subject: Re: [PATCH net 2/3] qed: Fix overriding of

Re: xfrm4_state_afinfo size increase (was: Re: xfrm: Add a xfrm type offload.)

On Thu, May 04, 2017 at 10:08:07AM +0200, Geert Uytterhoeven wrote: > > @@ -314,12 +316,14 @@ void km_state_expired(struct xfrm_state *x, int hard, > > u32 portid); > > int __xfrm_state_delete(struct xfrm_state *x); > > > > struct xfrm_state_afinfo { > > - unsigned intfamily;

Re: iproute2 build error due to sr-ipv6 lwtunnel

On 05/04/2017 11:13 AM, Daniel Borkmann wrote: > Hi David, > > I'm getting the following build error from e8493916a8ed ("iproute: > add support for SR-IPv6 lwtunnel encapsulation"). Reverting your > commit makes iproute2 build again for me. Please take a look. Hi Daniel, This is because

Re: new warning at net/wireless/util.c:1236

On Thu, 2017-05-04 at 07:35 +0300, Kalle Valo wrote: > Linus Torvalds writes: > > > So my Dell XPS 13 seems to have grown a new warning as of the > > networking merge yesterday. > > > > Things still work, but when it starts warning, it generates a *lot* of > >

Re: net/smc and the RDMA core

On Thu, May 04, 2017 at 11:43:50AM +0300, Sagi Grimberg wrote: > I would also suggest that you stop exposing the DMA MR for remote > access (at least by default) and use a proper reg_mr operations with a > limited lifetime on a properly sized buffer. Yes, exposing the default DMA MR is a _major_

[PATCH net 2/3] qed: Fix overriding of supported autoneg value.

Driver currently uses advertised-autoneg value to populate the supported-autoneg field. When advertised field is updated, user gets the same value for supported field. Supported-autoneg value need to be populated from the link capabilities value returned by the MFW. Signed-off-by: Sudarsana Reddy

[PATCH net 0/3] qed*: Bug fix series.

From: Sudarsana Reddy Kalluru The series contains minor bug fixes for qed/qede drivers. Please consider applying it to 'net' branch. Sudarsana Reddy Kalluru (3): qed*: Fix possible overflow for status block id field. qed: Fix overriding of supported autoneg

[PATCH net 3/3] qede: Fix possible misconfiguration of advertised autoneg value.

Fail the configuration of advertised speed-autoneg value if the config update is not supported. Signed-off-by: Sudarsana Reddy Kalluru --- drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH net 1/3] qed*: Fix possible overflow for status block id field.

Value for status block id could be more than 256 in 100G mode, need to update its data type from u8 to u16. Signed-off-by: Sudarsana Reddy Kalluru --- drivers/net/ethernet/qlogic/qed/qed_dev.c | 8 drivers/net/ethernet/qlogic/qed/qed_dev_api.h | 4

xfrm4_state_afinfo size increase (was: Re: xfrm: Add a xfrm type offload.)

Hi Steffen, On Wed, May 3, 2017 at 3:05 AM, Linux Kernel Mailing List wrote: > Web: > https://git.kernel.org/torvalds/c/9d389d7f84bbb3a294eb05f7dfe2076e291fc150 > Commit: 9d389d7f84bbb3a294eb05f7dfe2076e291fc150 > Parent:

Re: net/smc and the RDMA core

if you can point out specific issues, we will be happy to work with you to get them addressed! Hello Ursula, My list of issues that I would like to see addressed can be found below. Doug, Christoph and others may have additional inputs. The issues that have not yet been mentioned in other

Re: [RFC] iproute: Add support for extended ack to rtnl_talk

On 05/04/2017 01:56 AM, Stephen Hemminger wrote: Add support for extended ack error reporting via libmnl. This is a better alternative to use existing library and not copy/paste code from the kernel. Also make arguments const where possible. Add a new function rtnl_talk_extack that takes a

Re: [PATCH v1] ACPI: Switch to use generic UUID API

On Thu, May 04, 2017 at 12:21:51PM +0300, Andy Shevchenko wrote: > acpi_evaluate_dsm() and friends take a pointer to a raw buffer of 16 > bytes. Instead we convert them to use uuid_le type. At the same time we > convert current users. > > acpi_str_to_uuid() becomes useless after the conversion

Re: net/dccp: dccp_create_openreq_child freed held lock

On Thu, May 4, 2017 at 3:53 PM, David Miller wrote: > From: Andrey Konovalov > Date: Thu, 4 May 2017 15:36:37 +0200 > >> On Wed, Mar 1, 2017 at 4:40 PM, Arnaldo Carvalho de Melo >> wrote: >>> Em Wed, Mar 01, 2017 at 12:35:10PM -0300,

[PATCH] xen-netfront: avoid crashing on resume after a failure in talk_to_netback()

Unavoidable crashes in netfront_resume() and netback_changed() after a previous fail in talk_to_netback() (e.g. when we fail to read MAC from xenstore) were discovered. The failure path in talk_to_netback() does unregister/free for netdev but we don't reset drvdata and we try accessing it again

Re: [PATCH v2 net] xfrm: fix stack access out of bounds with CONFIG_XFRM_SUB_POLICY

On Wed, May 03, 2017 at 04:43:19PM +0200, Sabrina Dubroca wrote: > When CONFIG_XFRM_SUB_POLICY=y, xfrm_dst stores a copy of the flowi for > that dst. Unfortunately, the code that allocates and fills this copy > doesn't care about what type of flowi (flowi, flowi4, flowi6) gets > passed. In

Re: [PATCH 1/2] wcn36xx: Pass used skb to ieee80211_tx_status()

Bjorn Andersson writes: > On Thu 27 Apr 01:22 PDT 2017, Johannes Berg wrote: > >> >> > @@ -371,7 +371,7 @@ static void reap_tx_dxes(struct wcn36xx *wcn, >> > struct wcn36xx_dxe_ch *ch) >> >   info = IEEE80211_SKB_CB(ctl->skb); >> >  

Re: [PATCH net] ah: use crypto_memneq to check the ICV

On Wed, May 03, 2017 at 04:57:57PM +0200, Sabrina Dubroca wrote: > Signed-off-by: Sabrina Dubroca > --- > net/ipv4/ah4.c | 5 +++-- > net/ipv6/ah6.c | 5 +++-- > 2 files changed, 6 insertions(+), 4 deletions(-) Is this a fix for something? If so, please describe what it

[[NET-NEXT]] Added dump function to recognise rpl extension header option(63)

Signed-off-by: Andreas Bardoutsos --- I have added a dump function(always return true) to recognise RPL extension header(RFC6553) Otherwise packet was dropped by kernel resulting in impossible communication in RPL DAG's between linux running border routers and

Re: net/smc and the RDMA core

On Thu, May 04, 2017 at 03:08:39PM +0200, Ursula Braun wrote: > > > On 05/04/2017 10:48 AM, h...@lst.de wrote: > > On Thu, May 04, 2017 at 11:43:50AM +0300, Sagi Grimberg wrote: > >> I would also suggest that you stop exposing the DMA MR for remote > >> access (at least by default) and use a

[PATCH iproute] tc: Reflect HW offload status

Currently there is no way of querying whether a filter is offloaded to HW or not when using "both" policy (where none of skip_sw or skip_hw flags are set by user-space). Add two new flags, "in hw" and "not in hw" such that user space can determine if a filter is actually offloaded to hw or not.

Re: x86: warning: kernel stack regs has bad 'bp' value

On Wed, May 3, 2017 at 5:50 PM, Andrey Konovalov wrote: > On Wed, May 3, 2017 at 3:30 PM, Josh Poimboeuf wrote: >> On Wed, May 03, 2017 at 02:48:28PM +0200, Andrey Konovalov wrote: >>> Hi, >>> >>> I've got the following error report while fuzzing the

Re: [[NET-NEXT]] Added dump function to recognise rpl extension header option(63)

Stefan Schmidt wrote: > ipv6: ext_header: add function to handle RPL option 0x63 But its not handled, is it? The kernel tosses it because the RPL option/RFC says so ('nodes that do not understand this option on a received packet MUST discard the packet.').

Re: [[NET-NEXT]] Added dump function to recognise rpl extension header option(63)

Hello. On Thu, 2017-05-04 at 14:33, Florian Westphal wrote: > Stefan Schmidt wrote: > > ipv6: ext_header: add function to handle RPL option 0x63 > > But its not handled, is it? Its not handled in the kernel. The RPL daemon would run in userspace in this case. >From my

Re: net/smc and the RDMA core

On 05/04/2017 10:48 AM, h...@lst.de wrote: > On Thu, May 04, 2017 at 11:43:50AM +0300, Sagi Grimberg wrote: >> I would also suggest that you stop exposing the DMA MR for remote >> access (at least by default) and use a proper reg_mr operations with a >> limited lifetime on a properly sized

Re: [PATCH net 2/3] qed: Fix overriding of supported autoneg value.

From: "Kalluru, Sudarsana" Date: Thu, 4 May 2017 08:02:52 + > Dave, please let us know if re-spin is required for this. If not required, > will plan to clean it up in the next series. Please fix this now. Thanks.

Re: [[NET-NEXT]] Added dump function to recognise rpl extension header option(63)

From: Andreas Bardoutsos Date: Thu, 04 May 2017 14:06:32 +0200 > Signed-off-by: Andreas Bardoutsos First of all, the net-next tree is closed. You will need to resubmit this when the net-next tree opens back up. Second of all, your

Re: net: possible deadlock in skb_queue_tail

On Fri, Feb 24, 2017 at 3:56 AM, Florian Westphal wrote: > Andrey Konovalov wrote: > > [ CC Paolo ] > >> I've got the following error report while fuzzing the kernel with syzkaller. >> >> On commit c470abd4fde40ea6a0846a2beab642a578c0b8cd (4.10). >> >>

Re: [[NET-NEXT]] Added dump function to recognise rpl extension header option(63)

Stefan Schmidt wrote: > > The kernel tosses it because the RPL option/RFC says so > > ('nodes that do not understand this option on a received > > packet MUST discard the packet.'). > > What we might need is a way to let the kernel know we have a RPL running with >

Re: net/dccp: dccp_create_openreq_child freed held lock

On Wed, Mar 1, 2017 at 4:40 PM, Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 01, 2017 at 12:35:10PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Wed, Mar 01, 2017 at 10:38:54AM +0100, Dmitry Vyukov escreveu: >> > Hello, >> > >> > I've got the following report while running

Re: [PATCH net] ah: use crypto_memneq to check the ICV

2017-05-04, 12:41:24 +0200, Steffen Klassert wrote: > On Wed, May 03, 2017 at 04:57:57PM +0200, Sabrina Dubroca wrote: > > Signed-off-by: Sabrina Dubroca > > --- > > net/ipv4/ah4.c | 5 +++-- > > net/ipv6/ah6.c | 5 +++-- > > 2 files changed, 6 insertions(+), 4 deletions(-)

SSE instructions for fast packet copy?

Hi, I am thinking about the possibility of using SSE in kernel for speeding up the kernel memcpy particularly for copy to userspace emeory, and maybe even using the string instructions (like if we supported regex in something like eBPF). AFAIK we don't use SSE in kernel because of xmm register

Re: Bug in skb_gro_receive - possible bad page state problems?

On Fri, 2017-05-05 at 08:57 +0530, Anand H. Krishnan wrote: > Hello, > > Is skb_gro_receive doing the right thing for cloned packets? > > When we are merging fragments, we do not seem to be taking a reference > to the underlying page. To me, it looks like it should work fine for > non-cloned >

Re: [RFC iproute2 0/8] RDMA tool

On 05/04/2017 02:45 PM, Leon Romanovsky wrote: On Thu, May 04, 2017 at 06:30:27PM +, Bart Van Assche wrote: On Thu, 2017-05-04 at 21:25 +0300, Leon Romanovsky wrote: On Thu, May 04, 2017 at 06:10:54PM +, Bart Van Assche wrote: On Thu, 2017-05-04 at 21:02 +0300, Leon Romanovsky wrote:

Re: [Patch net v2] ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf

On 5/4/17 11:36 AM, Cong Wang wrote: > For each netns (except init_net), we initialize its null entry > in 3 places: > > 1) The template itself, as we use kmemdup() > 2) Code around dst_init_metrics() in ip6_route_net_init() > 3) ip6_route_dev_notify(), which is supposed to initialize it after >

[PATCH 3/6] cxgb4vf: Adjust five checks for null pointers

From: Markus Elfring Date: Thu, 4 May 2017 21:20:25 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus

Re: [PATCH] aquantia: Fix "ethtool -S" crash when adapter down.

On 05/04/2017 04:10 PM, Pavel Belous wrote: > From: Pavel Belous > > This patch fixes the crash that happens when driver tries to collect > statistics > from already released "aq_vec" object. > If adapter is in "down" state we still allow user to see statistics from

[PATCH net] tcp: randomize timestamps on syncookies

From: Eric Dumazet Whole point of randomization was to hide server uptime, but an attacker can simply start a syn flood and TCP generates 'old style' timestamps, directly revealing server jiffies value. Also, TSval sent by the server to a particular remote address vary

Re: [PATCH net-next 9/9] ipvlan: introduce individual MAC addresses

On Thu, May 4, 2017 at 2:37 AM, Chiappero, Marco wrote: >> -Original Message- >> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] >> On Behalf Of Dan Williams >> Sent: Tuesday, May 2, 2017 5:09 PM >> To: Chiappero, Marco

[PATCH iproute2] vxlan: Add support for modifying vxlan device attributes

Ability to change vxlan device attributes was added to kernel through commit 8bcdc4f3a20b ("vxlan: add changelink support"), however one cannot do the same through ip(8) command. Changing the allowed vxlan device attributes using 'ip link set dev type vxlan ' currently fails with 'operation not

[Patch net] ipv4: restore rt->fi for reference counting

IPv4 dst could use fi->fib_metrics to store metrics but fib_info itself is refcnt'ed, so without taking a refcnt fi and fi->fib_metrics could be freed while dst metrics still points to it. This triggers use-after-free as reported by Andrey twice. This patch reverts commit 2860583fe840 ("ipv4:

Re: [PATCH net-next 9/9] ipvlan: introduce individual MAC addresses

On Thu, May 4, 2017 at 9:43 AM, Jiri Benc wrote: > On Thu, 4 May 2017 09:37:00 +, Chiappero, Marco wrote: >> This looks conceptually wrong. Yes, ipvlan works at L3 (which is an >> implementation detail anyway), but slaves are Ethernet interfaces and >> should behave as much

Re: FEC on i.MX 7 transmit queue timeout

On 2017-05-03 20:08, Andy Duan wrote: > From: Stefan Agner Sent: Thursday, May 04, 2017 9:22 AM >>To: Andy Duan >>Cc: fugang.d...@freescale.com; feste...@gmail.com; >>netdev@vger.kernel.org; netdev-ow...@vger.kernel.org >>Subject: Re: FEC on i.MX 7 transmit

Re: [net-ipv4] question about arguments position

On Thu, 2017-05-04 at 14:15 -0500, Gustavo A. R. Silva wrote: > Quoting Joe Perches : > > > On Thu, 2017-05-04 at 14:00 -0500, Gustavo A. R. Silva wrote: > > > Regarding the code comments, what about the following patch: > > > > [] > > > diff --git a/net/ipv4/inet_diag.c

Re: [net-ipv4] question about arguments position

Hi Joe, Quoting Joe Perches : On Thu, 2017-05-04 at 12:46 -0400, David Miller wrote: From: "Gustavo A. R. Silva" Date: Thu, 04 May 2017 11:07:54 -0500 > While looking into Coverity ID 1357474 I ran into the following piece > of code at

Re: [PATCH] iproute2: hide devices starting with period by default

On 5/4/17 1:10 PM, Florian Fainelli wrote: > On 05/04/2017 09:37 AM, David Ahern wrote: >> On 5/4/17 9:15 AM, Nicolas Dichtel wrote: >>> Le 24/02/2017 à 16:52, David Ahern a écrit : On 2/23/17 8:12 PM, David Miller wrote: > This really need to be a fundamental facility, so that it

[PATCH] aquantia: Fix "ethtool -S" crash when adapter down.

From: Pavel Belous This patch fixes the crash that happens when driver tries to collect statistics from already released "aq_vec" object. If adapter is in "down" state we still allow user to see statistics from HW. V2: fixed braces around "aq_vec_free". Fixes:

Re: [RFC] iproute: Add support for extended ack to rtnl_talk

Hi, On Thu, May 04, 2017 at 09:43:56AM -0700, Stephen Hemminger wrote: > On Thu, 04 May 2017 10:41:03 -0400 (EDT) > David Miller wrote: > > > From: David Ahern > > Date: Thu, 4 May 2017 08:27:35 -0600 > > > > > On 5/4/17 3:36 AM, Daniel Borkmann wrote:

Re: [PATCH 1/2] PCI: Add new PCIe Fabric End Node flag, PCI_DEV_FLAGS_NO_RELAXED_ORDERING

| From: Alexander Duyck | Sent: Wednesday, May 3, 2017 9:02 AM | ... | It sounds like we are more or less in agreement. My only concern is | really what we default this to. On x86 I would say we could probably | default this to disabled for existing platforms since my

Re: [PATCH] iproute2: hide devices starting with period by default

On 05/04/2017 09:37 AM, David Ahern wrote: > On 5/4/17 9:15 AM, Nicolas Dichtel wrote: >> Le 24/02/2017 à 16:52, David Ahern a écrit : >>> On 2/23/17 8:12 PM, David Miller wrote: This really need to be a fundamental facility, so that it transparently works for NetworkManager, router

Re: [net-ipv4] question about arguments position

Quoting Joe Perches : On Thu, 2017-05-04 at 14:00 -0500, Gustavo A. R. Silva wrote: Regarding the code comments, what about the following patch: [] diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c [] @@ -389,6 +389,12 @@ static int sk_diag_fill(struct sock *sk,

Re: [PATCH RESEND 4.4-only] netlink: Allow direct reclaim for fallback allocation

On Wed, May 03, 2017 at 09:44:19AM +0100, Ross Lagerwall wrote: > The backport of d35c99ff77ec ("netlink: do not enter direct reclaim from > netlink_dump()") to the 4.4 branch (first in 4.4.32) mistakenly removed > direct claim from the initial large allocation _and_ the fallback > allocation

Patch "netlink: Allow direct reclaim for fallback allocation" has been added to the 4.4-stable tree

This is a note to let you know that I've just added the patch titled netlink: Allow direct reclaim for fallback allocation to the 4.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

[PATCH 2/6] cxgb4vf: Combine substrings for 24 messages

From: Markus Elfring Date: Thu, 4 May 2017 21:00:20 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: quoted string split across lines Thus fix the affected source code places. Signed-off-by: Markus Elfring

[PATCH 1/6] cxgb4vf: Use seq_putc() in mboxlog_show()

From: Markus Elfring Date: Thu, 4 May 2017 20:02:04 +0200 A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 6/6] cxgb4: Combine substrings for two messages

From: Markus Elfring Date: Thu, 4 May 2017 22:16:57 +0200 The script "checkpatch.pl" pointed information out like the following. WARNING: quoted string split across lines Thus fix two source code places. Signed-off-by: Markus Elfring

[PATCH 4/6] cxgb4: Replace seven seq_puts() calls by seq_putc()

From: Markus Elfring Date: Thu, 4 May 2017 21:40:54 +0200 Seven single characters (line breaks) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 0/6] cxgb4: Fine-tuning for some function implementations

From: Markus Elfring Date: Thu, 4 May 2017 22:23:45 +0200 A few update suggestions were taken into account from static source code analysis. Markus Elfring (6): Use seq_putc() in mboxlog_show() Combine substrings for 24 messages Adjust five checks for null

Re: [PATCH] aquantia: Fix "ethtool -S" crash when adapter down.

On Thu, 2017-05-04 at 23:10 +0300, Pavel Belous wrote: > diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c > b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c [] > @@ -959,8 +959,10 @@ void aq_nic_free_hot_resources(struct aq_nic_s *self) > goto err_exit; > > for

[PATCH] net: ipv4: add code comment for clarification

Add code comment to make it clear that the position of the arguments req->id.idiag_dport and req->id.idiag_sport is a locked in behavior and it should not be changed. Addresses-Coverity-ID: 1357474 Cc: David Miller Cc: Joe Perches Signed-off-by: Gustavo A.

[PATCH 5/6] cxgb4: Use seq_puts() in cim_qcfg_show()

From: Markus Elfring Date: Thu, 4 May 2017 21:52:32 +0200 A string which did not contain a data format specification should be put into a sequence. Thus use the corresponding function "seq_puts". This issue was detected by using the Coccinelle software.

Re: [RFC iproute2 0/8] RDMA tool

On Thu, May 04, 2017 at 03:26:13PM -0400, Dennis Dalessandro wrote: > On 05/04/2017 02:45 PM, Leon Romanovsky wrote: > > On Thu, May 04, 2017 at 06:30:27PM +, Bart Van Assche wrote: > > > On Thu, 2017-05-04 at 21:25 +0300, Leon Romanovsky wrote: > > > > On Thu, May 04, 2017 at 06:10:54PM

Re: [net-ipv4] question about arguments position

Quoting Joe Perches : [] > > +/* > > + * Ignore the position of the arguments req->id.idiag_dport and > > + * req->id.idiag_sport in both calls to inet_lookup() and inet6_lookup() > > + * functions, once this is a locked in behavior exposed to user space. > > + * Changing

Re: [RFC iproute2 0/8] RDMA tool

On Thu, 2017-05-04 at 15:26 -0400, Dennis Dalessandro wrote: > On 05/04/2017 02:45 PM, Leon Romanovsky wrote: > > > > On Thu, May 04, 2017 at 06:30:27PM +, Bart Van Assche wrote: > > > > > > On Thu, 2017-05-04 at 21:25 +0300, Leon Romanovsky wrote: > > > > > > > > On Thu, May 04, 2017 at

Re: [RFC] iproute: Add support for extended ack to rtnl_talk

On Thu, 04 May 2017 10:41:03 -0400 (EDT) David Miller wrote: > From: David Ahern > Date: Thu, 4 May 2017 08:27:35 -0600 > > > On 5/4/17 3:36 AM, Daniel Borkmann wrote: > >> What is the clear benefit/rationale of outsourcing this to > >> libmnl? I

Re: [net-ipv4] question about arguments position

From: "Gustavo A. R. Silva" Date: Thu, 04 May 2017 11:07:54 -0500 > While looking into Coverity ID 1357474 I ran into the following piece > of code at net/ipv4/inet_diag.c:392: Because it's been this way since at least 2005, it doesn't matter if the order is correct or

Re: [RFC] iproute: Add support for extended ack to rtnl_talk

On Thu, 4 May 2017 17:37:38 +0300 Leon Romanovsky wrote: > On Thu, May 04, 2017 at 11:36:36AM +0200, Daniel Borkmann wrote: > > On 05/04/2017 01:56 AM, Stephen Hemminger wrote: > > > Add support for extended ack error reporting via libmnl. This > > > is a better alternative to

Re: [PATCH] aquantia: Fix "ethtool -S" crash when adapter down.

Hi Pavel, On 04.05.2017 18:33, Pavel Belous wrote: > From: Pavel Belous > > This patch fixes the crash that happens when driver tries to collect > statistics > from already released "aq_vec" object. > > Fixes: 97bde5c4f909 ("net: ethernet: aquantia: Support for

Fw: [Bug 195217] siocsifflags - irda doesn't work (MCS7780)

Apparently IRDA is broken by VMAP_STACK Begin forwarded message: Date: Thu, 04 May 2017 12:16:15 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 195217] siocsifflags - irda doesn't work (MCS7780) https://bugzilla.kernel.org/show_bug.cgi?id=195217

Re: [PATCH] aquantia: Fix "ethtool -S" crash when adapter down.

From: Lino Sanfilippo Date: Thu, 4 May 2017 18:48:12 +0200 > Hi Pavel, > > On 04.05.2017 18:33, Pavel Belous wrote: >> From: Pavel Belous >> >> This patch fixes the crash that happens when driver tries to collect >> statistics >> from already

Re: struct ip vs struct iphdr

On (05/04/17 19:42), Oleg wrote: > > Hi, all. > > It seems struct ip and struct iphdr are similar: struct ip, despite of > it name, doesn't contain anything but ip header. > > So, my noob question, what is the difference between them? > > Thanks. BSD vs linux? struct ip is a BSD-ism,

Re: [PATCH] aquantia: Fix "ethtool -S" crash when adapter down.

On 04.05.2017 20:00, David Arcari wrote: Hi Pavel, On 05/04/2017 12:33 PM, Pavel Belous wrote: From: Pavel Belous This patch fixes the crash that happens when driver tries to collect statistics from already released "aq_vec" object. Fixes: 97bde5c4f909 ("net:

Re: struct ip vs struct iphdr

On 5/4/17 9:42 AM, Oleg wrote: Hi, all. It seems struct ip and struct iphdr are similar: struct ip, despite of it name, doesn't contain anything but ip header. So, my noob question, what is the difference between them? Also, see this:

Re: [PATCH] aquantia: Fix "ethtool -S" crash when adapter down.

On 04.05.2017 19:51, David Miller wrote: From: Lino Sanfilippo Date: Thu, 4 May 2017 18:48:12 +0200 Hi Pavel, On 04.05.2017 18:33, Pavel Belous wrote: From: Pavel Belous This patch fixes the crash that happens when driver tries to

Re: [Patch net] ipv6: initialize route null entry in addrconf_init()

On 5/4/17 10:51 AM, David Miller wrote: > From: Andrey Konovalov > Date: Thu, 4 May 2017 14:28:37 +0200 > >> On Thu, May 4, 2017 at 7:07 AM, Cong Wang wrote: >>> Andrey reported a crash on init_net.ipv6.ip6_null_entry->rt6i_idev >>> since it is

[net-ipv4] question about arguments position

Hello everybody, While looking into Coverity ID 1357474 I ran into the following piece of code at net/ipv4/inet_diag.c:392: struct sock *inet_diag_find_one_icsk(struct net *net, struct inet_hashinfo *hashinfo, const

[PATCH] aquantia: Fix "ethtool -S" crash when adapter down.

From: Pavel Belous This patch fixes the crash that happens when driver tries to collect statistics from already released "aq_vec" object. Fixes: 97bde5c4f909 ("net: ethernet: aquantia: Support for NIC-specific code") Signed-off-by: Pavel Belous

Re: [PATCH net v2 0/3] qed*: Bug fix series.

From: Sudarsana Reddy Kalluru Date: Thu, 4 May 2017 08:15:02 -0700 > From: Sudarsana Reddy Kalluru > > The series contains minor bug fixes for qed/qede drivers. > > Please consider applying it to 'net' branch. Series applied,

Re: [PATCH] iproute2: hide devices starting with period by default

On 5/4/17 9:15 AM, Nicolas Dichtel wrote: > Le 24/02/2017 à 16:52, David Ahern a écrit : >> On 2/23/17 8:12 PM, David Miller wrote: >>> This really need to be a fundamental facility, so that it transparently >>> works for NetworkManager, router daemons, everything. Not just iproute2 >>> and "ls".

Re: [RFC] iproute: Add support for extended ack to rtnl_talk

On Thu, 04 May 2017 11:36:36 +0200 Daniel Borkmann wrote: > On 05/04/2017 01:56 AM, Stephen Hemminger wrote: > > Add support for extended ack error reporting via libmnl. This > > is a better alternative to use existing library and not copy/paste > > code from the kernel.

Re: [PATCH net-next 9/9] ipvlan: introduce individual MAC addresses

On Thu, 4 May 2017 09:37:00 +, Chiappero, Marco wrote: > This looks conceptually wrong. Yes, ipvlan works at L3 (which is an > implementation detail anyway), but slaves are Ethernet interfaces and > should behave as much as possible as such regardless, with an > individual MAC address

struct ip vs struct iphdr

Hi, all. It seems struct ip and struct iphdr are similar: struct ip, despite of it name, doesn't contain anything but ip header. So, my noob question, what is the difference between them? Thanks. -- Олег Неманов (Oleg Nemanov)

Re: [Patch net] ipv6: initialize route null entry in addrconf_init()

From: Andrey Konovalov Date: Thu, 4 May 2017 14:28:37 +0200 > On Thu, May 4, 2017 at 7:07 AM, Cong Wang wrote: >> Andrey reported a crash on init_net.ipv6.ip6_null_entry->rt6i_idev >> since it is always NULL. >> >> This is clearly wrong, we have

Re: [PATCH] aquantia: Fix "ethtool -S" crash when adapter down.

Hi Pavel, On 05/04/2017 12:33 PM, Pavel Belous wrote: > From: Pavel Belous > > This patch fixes the crash that happens when driver tries to collect > statistics > from already released "aq_vec" object. > > Fixes: 97bde5c4f909 ("net: ethernet: aquantia: Support for

Why do we need MSG_SENDPAGE_NOTLAST?

I don't understand the need for MSG_SENDPAGE_NOTLAST and I'm hoping someone can enlighten me. According to commit 35f9c09 ('tcp: tcp_sendpages() should call tcp_push() once'): "We need to call tcp_flush() at the end of the last page processed in tcp_sendpages(), or else transmits can be

Re: [PATCH v1] ACPI: Switch to use generic UUID API

On Thu, May 4, 2017 at 4:21 AM, Andy Shevchenko wrote: > acpi_evaluate_dsm() and friends take a pointer to a raw buffer of 16 > bytes. Instead we convert them to use uuid_le type. At the same time we > convert current users. > > acpi_str_to_uuid() becomes

Re: [RFC] iproute: Add support for extended ack to rtnl_talk

On 5/4/17 3:36 AM, Daniel Borkmann wrote: > What is the clear benefit/rationale of outsourcing this to > libmnl? I always was the impression we should strive for as little > dependencies as possible? +1

  1   2   >