Re: [net,v2] ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf

2017-06-20 Thread Cong Wang
On Mon, Jun 19, 2017 at 11:37 PM, jeffy wrote: > Hi Cong Wang, > > > On 06/20/2017 12:54 PM, Cong Wang wrote: >> >> Interesting, I didn't notice this corner-case, because normally >> we would hit the one in rollback_registered_many(). Probably >> we need to add a check

[Patch net] ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER

2017-06-20 Thread Cong Wang
In commit 242d3a49a2a1 ("ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf") I assumed NETDEV_REGISTER and NETDEV_UNREGISTER are paired, unfortunately, as reported by jeffy, netdev_wait_allrefs() could rebroadcast NETDEV_UNREGISTER event until all refs are gone. We have to add an

Re: Repeatable inet6_dump_fib crash in stock 4.12.0-rc4+

2017-06-20 Thread Michal Kubecek
On Tue, Jun 20, 2017 at 07:12:27AM -0700, Ben Greear wrote: > On 06/14/2017 03:25 PM, David Ahern wrote: > >On 6/14/17 4:23 PM, Ben Greear wrote: > >>On 06/13/2017 07:27 PM, David Ahern wrote: > >> > >>>Let's try a targeted debug patch. See attached > >> > >>I had to change it to pr_err so it

Re: [RFC 2/2] net-next: mt7530: add nh and proto offsets to the ops struct

2017-06-20 Thread Andrew Lunn
> #include "../dsa/dsa_priv.h" > > I was not sure if this is ok or if we would need to move the struct > definition to include/net/dsa.h in that case Hi John Please move the structure. Andrew

[PATCH v2] net/phy: micrel: configure intterupts after autoneg workaround

2017-06-20 Thread Zach Brown
The commit ("net/phy: micrel: Add workaround for bad autoneg") fixes an autoneg failure case by resetting the hardware. This turns off intterupts. Things will work themselves out if the phy polls, as it will figure out it's state during a poll. However if the phy uses only intterupts, the phy will

Re: [PATCH 0/2] fix loadable module for DPAA Ethernet

2017-06-20 Thread David Miller
From: Madalin Bucur Date: Mon, 19 Jun 2017 18:04:15 +0300 > The DPAA Ethernet makes use of a symbol that is not exported. > Address the issue by propagating the dma_ops rather than calling > arch_setup_dma_ops(). Series applied, thanks.

[Patch net] igmp: add a missing spin_lock_init()

2017-06-20 Thread Cong Wang
Andrey reported a lockdep warning on non-initialized spinlock: INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. CPU: 1 PID: 4099 Comm: a.out Not tainted 4.12.0-rc6+ #9 Hardware name: QEMU Standard PC

Re: [PATCH net-next] net: phy: lxt: Export link partner advertising

2017-06-20 Thread David Miller
From: Thomas Bogendoerfer Date: Mon, 19 Jun 2017 16:00:22 +0200 > From: Thomas Bogendoerfer > > Provide link partner advertising information. > Removed testing for gigabit modes, which is useless for a fast ethernet phy. > > Signed-off-by:

Re: [PATCH 0/4] net-next: mediatek: various performance improvements

2017-06-20 Thread David Miller
From: John Crispin Date: Mon, 19 Jun 2017 15:37:02 +0200 > During development we mainly ran testing using iperf doing 1500 byte > tcp frames. It was pointed out recently, that the driver does not perform > very well when using 512 byte udp frames. The biggest problem was that >

Re: [RFC 1/2] net-next: fix DSA flow_disection

2017-06-20 Thread John Crispin
On 20/06/17 19:30, Florian Fainelli wrote: On 06/20/2017 07:01 AM, Andrew Lunn wrote: On Tue, Jun 20, 2017 at 10:06:54AM +0200, John Crispin wrote: RPS and probably other kernel features are currently broken on some if not all DSA devices. The root cause of this that skb_hash will call the

Re: [RFC 1/2] net-next: fix DSA flow_disection

2017-06-20 Thread John Crispin
On 20/06/17 16:01, Andrew Lunn wrote: On Tue, Jun 20, 2017 at 10:06:54AM +0200, John Crispin wrote: RPS and probably other kernel features are currently broken on some if not all DSA devices. The root cause of this that skb_hash will call the flow_disector. Hi John What is the call path

Re: [PATCH net-next v3 0/6] vxlan: cleanup and IPv6 link-local support

2017-06-20 Thread David Miller
From: Matthias Schiffer Date: Mon, 19 Jun 2017 10:03:54 +0200 > Running VXLANs over IPv6 link-local addresses allows to use them as a > drop-in replacement for VLANs, avoiding to allocate additional outer IP > addresses to run the VXLAN over. > > Since v1, I have

Re: [PATCH net-next] ibmvnic: Return from ibmvnic_resume if not in VNIC_OPEN state

2017-06-20 Thread Nathan Fontenot
On 06/19/2017 11:27 AM, John Allen wrote: > If the ibmvnic driver is not in the VNIC_OPEN state, return from > ibmvnic_resume callback. If we are not in the VNIC_OPEN state, interrupts > may not be initialized and directly calling the interrupt handler will > cause a crash. > > Signed-off-by:

Re: [PATCH] netxen: Fix a sleep-in-atomic bug in netxen_nic_pci_mem_access_direct

2017-06-20 Thread David Miller
From: Jia-Ju Bai Date: Mon, 19 Jun 2017 10:48:53 +0800 > The driver may sleep under a spin lock, and the function call path is: > netxen_nic_pci_mem_access_direct (acquire the lock by spin_lock) > ioremap --> may sleep > > To fix it, the lock is released before

[PATCH net-next] ibmvnic: Correct return code checking for ibmvnic_init during probe

2017-06-20 Thread Nathan Fontenot
Fixes: 6a2fb0e99f9c (ibmvnic: driver initialization for kdump/kexec) The update to ibmvnic_init to allow an EAGAIN return code broke the calling of ibmvnic_init from ibmvnic_probe. The code now will return from this point in the probe routine if anything other than EAGAIN is returned. The check

Re: [PATCH net-next 0/3] more skb_put_[data:zero] related work

2017-06-20 Thread David Miller
From: yuan linyu Date: Sun, 18 Jun 2017 22:41:54 +0800 > yuan linyu (3): > net: introduce __skb_put_[zero, data, u8] > net: replace more place to skb_put_[data:zero] > net: manual clean code which call skb_put_[data:zero] Series applied, thanks.

Re: [RFC 1/2] net-next: fix DSA flow_disection

2017-06-20 Thread Florian Fainelli
On 06/20/2017 07:01 AM, Andrew Lunn wrote: > On Tue, Jun 20, 2017 at 10:06:54AM +0200, John Crispin wrote: >> RPS and probably other kernel features are currently broken on some if not >> all DSA devices. The root cause of this that skb_hash will call the >> flow_disector. > > Hi John > > What

Re: [RFC 2/2] net-next: mt7530: add nh and proto offsets to the ops struct

2017-06-20 Thread John Crispin
On 20/06/17 15:54, Andrew Lunn wrote: On Tue, Jun 20, 2017 at 10:06:55AM +0200, John Crispin wrote: The MT7530 inserts the 4 magic header in between the 802.3 address and protocol field. The patch defines these header such that the flow_disector can properly parse the packet and thus allows

[PATCH v2] net/mlx5e: Use device ID defines

2017-06-20 Thread Myron Stowe
Use Mellanox device ID definitions in the driver's mlx5 ID table so tools such as 'grep' and 'cscope' can be used to help find correlated material (such as INTx Masking quirks: d76d2fe05fd PCI: Convert Mellanox broken INTx quirks to be for listed devices only). No functional change intended.

Re: [PATCH net-next v2 00/10] net: dsa: Global 2 cosmetics

2017-06-20 Thread David Miller
From: Vivien Didelot Date: Mon, 19 Jun 2017 10:55:35 -0400 > Similarly to what has been done for the Port and Global 1 registers, > this patch series prefixes and documents the macros of Global 2. > > It brings no functional changes except for 1/10 which

Re: [PATCH 0/4] net-next: stmmac: dwmac-sun8i: add support for V3s

2017-06-20 Thread David Miller
From: Icenowy Zheng Date: Sat, 17 Jun 2017 22:07:33 +0800 > Allwinner V3s features an EMAC like the on in H3, but without external MII > interfaces, so being not able really to use RMII/RGMII. > > And it has a different default value of syscon (0x38000 instead of 0x58000 > on

Re: net/ipv4: trying to register non-static key in ip_mc_clear_src

2017-06-20 Thread Cong Wang
On Tue, Jun 20, 2017 at 8:14 AM, Andrey Konovalov wrote: > Hi, > > I've got the following error report while fuzzing the kernel with syzkaller. > > On commit 9705596d08ac87c18aee32cc97f2783b7d14624e (4.12-rc6+). > > A reproducer and .config are attached. > > INFO: trying to

Re: [PATCH net-next 0/1] Introduction of the tc tests

2017-06-20 Thread David Miller
From: Lucas Bates Date: Fri, 16 Jun 2017 17:22:34 -0400 > Apologies for sending this as one big patch. I've been sitting on this a > little > too long, but it's ready and I wanted to get it out. > > There are a limited number of tests to start - I plan to add more on a

Re: [PATCH net-next 06/12] nfp: add stats and xmit helpers for representors

2017-06-20 Thread kbuild test robot
Hi Simon, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Simon-Horman/nfp-add-flower-app-with-representors/20170620-233831 config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce

Re: [PATCH] net: introduce SO_PEERGROUPS getsockopt

2017-06-20 Thread David Miller
This doesn't apply cleanly to net-next, please respin.

Re: [PATCH 2/2] net/core: remove explicit do_softirq() from busy_poll_stop()

2017-06-20 Thread David Miller
From: Sebastian Andrzej Siewior Date: Fri, 16 Jun 2017 19:24:00 +0200 > Since commit 217f69743681 ("net: busy-poll: allow preemption in > sk_busy_loop()") there is an explicit do_softirq() invocation after > local_bh_enable() has been invoked. > I don't understand why we

Re: [PATCH 1/2] net/core: use local_bh_disable() in netif_rx_ni()

2017-06-20 Thread David Miller
From: Sebastian Andrzej Siewior Date: Fri, 16 Jun 2017 19:23:59 +0200 > In 2004 [0] netif_rx_ni() gained a preempt_disable() section around > netif_rx() and its do_softirq() + testing for it. The do_softirq() part > is required because netif_rx() raises the softirq but

Re: [PATCH v2] arm: eBPF JIT compiler

2017-06-20 Thread Daniel Borkmann
On 06/20/2017 03:34 AM, Shubham Bansal wrote: Hi Daniel, Sorry, had a travel over the weekend, so didn't read it in time. What is the issue with imitating in JIT what the interpreter is doing as a starting point? That should be generic enough to handle any case. Why not proceeding this way

Re: dev: Reclaim network device indexes

2017-06-20 Thread David Miller
From: Serhey Popovych Date: Fri, 16 Jun 2017 19:39:34 +0300 > While making dev_new_index() return zero on overrun prevents > from infinite loop, there is no way to recovery mechanisms > since namespace ifindex only increases and never reused > from released network

Re: fib_rules: Resolve goto rules target on delete

2017-06-20 Thread David Miller
From: Serhey Popovych Date: Fri, 16 Jun 2017 15:44:47 +0300 > We should avoid marking goto rules unresolved when their > target is actually reachable after rule deletion. > > Consolder following sample scenario: > > # ip -4 ru sh > 0: from all lookup local >

Re: [PATCH] veth: Be more robust on network device creation when no attributes

2017-06-20 Thread David Miller
From: Serhey Popovych Date: Fri, 16 Jun 2017 18:05:00 +0300 > There are number of problems with configuration peer > network device in absence of IFLA_VETH_PEER attributes > where attributes for main network device shared with > peer. > > First it is not feasible to

Re: [PATCH v4 net-next 0/7] qed*: RDMA and infrastructure for iWARP

2017-06-20 Thread David Miller
From: Yuval Mintz Date: Tue, 20 Jun 2017 15:59:59 +0300 > Please consider applying this series to `net-next'. Series applied, thanks.

Re: [PATCH net-next 00/12] nfp: add flower app with representors

2017-06-20 Thread Or Gerlitz
On Tue, Jun 20, 2017 at 8:51 AM, Simon Horman wrote: > this series adds a flower app to the NFP driver. > It initialises four types of netdevs: > > * PF netdev - lower-device for communication of packets to device > * PF representor netdev > * VF representor netdevs >

Re: [PATCH net-next] sctp: handle errors when updating asoc

2017-06-20 Thread Marcelo Ricardo Leitner
On Tue, Jun 20, 2017 at 04:05:11PM +0800, Xin Long wrote: > It's a bad thing not to handle errors when updating asoc. The memory > allocation failure in any of the functions called in sctp_assoc_update() > would cause sctp to work unexpectedly. > > This patch is to fix it by aborting the asoc and

Re: [PATCH net-next] sctp: uncork the old asoc before changing to the new one

2017-06-20 Thread Marcelo Ricardo Leitner
On Tue, Jun 20, 2017 at 04:01:55PM +0800, Xin Long wrote: > local_cork is used to decide if it should uncork asoc outq after processing > some cmds, and it is set when replying or sending msgs. local_cork should > always have the same value with current asoc q->cork in some way. > > The thing is

Re: [PATCH net-next 0/1] Introduction of the tc tests

2017-06-20 Thread David Miller
From: Cong Wang Date: Mon, 19 Jun 2017 21:13:31 -0700 > I thought tools/testing/selftests/ is mainly for those tests close to > kernel ABI and API. What is the criteria for these tests? If any test > can fit in, we somehow would merge the whole LTP... > > I definitely

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Benjamin Gaignard
2017-06-20 15:48 GMT+02:00 Alexandre Belloni : > On 20/06/2017 at 15:44:58 +0200, Pavel Machek wrote: >> On Tue 2017-06-20 13:37:22, Steve Twiss wrote: >> > Hi Pavel, >> > >> > On 20 June 2017 14:26, Pavel Machek wrote: >> > >> > > Subject: Re: [PATCH 00/51]

Re: [PATCH net-next] net: phy: lxt: Export link partner advertising

2017-06-20 Thread Andrew Lunn
On Mon, Jun 19, 2017 at 04:00:22PM +0200, Thomas Bogendoerfer wrote: > From: Thomas Bogendoerfer > > Provide link partner advertising information. > Removed testing for gigabit modes, which is useless for a fast ethernet phy. > > Signed-off-by: Thomas Bogendoerfer

[net-next 02/10] net/mlx5e: Prevent PFC call for non ethernet ports

2017-06-20 Thread Saeed Mahameed
From: Feras Daoud Port flow control supported only for ethernet ports, therefore, prevent any call if the port type differs from MLX5_CAP_PORT_TYPE_ETH. Signed-off-by: Feras Daoud Signed-off-by: Saeed Mahameed ---

[net-next 06/10] net/mlx5e: Use hard_mtu as part of the mlx5e_priv struct

2017-06-20 Thread Saeed Mahameed
From: Erez Shitrit The mtu extra space that kept for the HW is specific for each link type, and it is different in mlx5e and mlx5i modules. Now it is kept in the priv structures, set by the mlx5e/mlx5i driver accordingly. Signed-off-by: Erez Shitrit

[net-next 09/10] net/mlx5e: IPoIB, Add PTP support to IPoIB device driver

2017-06-20 Thread Saeed Mahameed
From: Feras Daoud Enable PTP for IPoIB rdma_netdev and add the ability to get the time stamping parameters using ethtool. Signed-off-by: Feras Daoud Signed-off-by: Eitan Rabin Signed-off-by: Saeed Mahameed

[net-next 03/10] net/mlx5e: IPoIB, Add ethtool support

2017-06-20 Thread Saeed Mahameed
From: Erez Shitrit Add support for the following: "ethtool -S" (statistics). "ethtool -i" (driver info). "ethtool -g/G" (rings parameters). "ethtool -l/L" (channels parameters). "ethtool -c/C" (coalesce options). Signed-off-by: Erez

[pull request][net-next 00/10] Mellanox, mlx5 IPoIB updates 2017-06-20

2017-06-20 Thread Saeed Mahameed
Hi Dave, This series mainly from Erez and Feras includes some updates and ethtool/ndos extension to the mlx5 IPoIB netdevice. for more detalis please see tag log below. Please pull and let me know if there's any problem. Thanks, Saeed. --- The following changes since commit

[net-next 01/10] net/mlx5e: IPoIB, Move to a separate directory

2017-06-20 Thread Saeed Mahameed
IPoIB netdevice driver was only introduced in previous kernel release and it is growing in terms of features and LOC, move it to a separate directory. Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/Makefile| 2 +-

[net-next 07/10] net/mlx5e: IPoIB, Handle change_mtu

2017-06-20 Thread Saeed Mahameed
From: Erez Shitrit Add the ndo that supports change mtu for IPoIB. The callback called from the ipoib ULP driver, that gives the ability to change the SW and HW resources accordingly in the lower driver. Signed-off-by: Erez Shitrit Signed-off-by: Saeed

[net-next 10/10] net/mlx5e: IPoIB, Add ioctl support to IPoIB device driver

2017-06-20 Thread Saeed Mahameed
From: Feras Daoud Add ioctl support to IPoIB device driver. For now, this ioctl will support timestamp get and set. Signed-off-by: Feras Daoud Signed-off-by: Eitan Rabin Signed-off-by: Saeed Mahameed ---

[net-next 05/10] net/mlx5e: IPoIB, Change parameters default values

2017-06-20 Thread Saeed Mahameed
From: Erez Shitrit Add function that sets the default values for ipoib, setting/clearing abilities that IPoIB doesn't support, like RQ size in this case. Signed-off-by: Erez Shitrit Signed-off-by: Saeed Mahameed ---

[net-next 04/10] net/mlx5e: Add new profile function update_carrier

2017-06-20 Thread Saeed Mahameed
From: Erez Shitrit Updating the carrier involves specific HW setting, each profile should use its own function for that. Both IPoIB and VF representor don't need carrier update function, since VF representor has only a logical link to VF and IPoIB manages its own link via

[net-next 08/10] net/mlx5e: IPoIB, Get more TX statistics

2017-06-20 Thread Saeed Mahameed
From: Erez Shitrit Add misses counters (bytes, packet, gso, xmit_more) in TX flow for ipoib traffic. Fixes: 58545449b7b ("net/mlx5e: IPoIB, Xmit flow") Signed-off-by: Erez Shitrit Signed-off-by: Saeed Mahameed ---

Re: Repeatable inet6_dump_fib crash in stock 4.12.0-rc4+

2017-06-20 Thread Ben Greear
On 06/14/2017 03:25 PM, David Ahern wrote: On 6/14/17 4:23 PM, Ben Greear wrote: On 06/13/2017 07:27 PM, David Ahern wrote: Let's try a targeted debug patch. See attached I had to change it to pr_err so it would go to our serial console since the system locked hard on crash, and that

Re: [RFC 1/2] net-next: fix DSA flow_disection

2017-06-20 Thread Andrew Lunn
On Tue, Jun 20, 2017 at 10:06:54AM +0200, John Crispin wrote: > RPS and probably other kernel features are currently broken on some if not > all DSA devices. The root cause of this that skb_hash will call the > flow_disector. Hi John What is the call path when the flow_disector is called? I'm

[PATCH net-next 4/4] s390/qeth: use diag26c to get MAC address on L2

2017-06-20 Thread Julian Wiedmann
When a s390 guest runs on a z/VM host that's part of a SSI cluster, it can be migrated to a different host. In this case, the MAC address it originally obtained on the old host may be re-assigned to a new guest. This would result in address conflicts between the two guests. When running as z/VM

[PATCH net-next 2/4] s390/qeth: fix packing buffer statistics

2017-06-20 Thread Julian Wiedmann
There's two spots in qeth_send_packet() where we don't accurately account for transmitted packing buffers in qeth's performance statistics: 1) when flushing the current buffer due to insufficient size, and the next buffer is not EMPTY, we need to account for that flushed buffer. 2) when

[PATCH net-next 3/4] s390/diag: add diag26c support

2017-06-20 Thread Julian Wiedmann
Implement support for the hypervisor diagnose 0x26c ('Access Certain System Information'). It passes a request buffer and a subfunction code, and receives a response buffer and a return code. Also add the scaffolding for the 'MAC Services' subfunction. It may be used by network devices to obtain

[PATCH net-next 1/4] s390/qeth: add ipa return codes for bridgeport

2017-06-20 Thread Julian Wiedmann
From: Kittipon Meesompop add ipa return codes for Bridgeport (HiperSockets and OSA) according to system level design. Signed-off-by: Kittipon Meesompop Reviewed-by: Julian Wiedmann Reviewed-by: Ursula Braun

[PATCH net-next 0/4] s390/net updates, part 2 (v2)

2017-06-20 Thread Julian Wiedmann
Hi Dave, thanks for the feedback. Here's an updated patchset that honours the reverse christmas tree and drops the __packed attribute. Please apply. Thanks, Julian Julian Wiedmann (3): s390/qeth: fix packing buffer statistics s390/diag: add diag26c support s390/qeth: use diag26c to get

Re: [RFC 2/2] net-next: mt7530: add nh and proto offsets to the ops struct

2017-06-20 Thread Andrew Lunn
On Tue, Jun 20, 2017 at 10:06:55AM +0200, John Crispin wrote: > The MT7530 inserts the 4 magic header in between the 802.3 address and > protocol field. The patch defines these header such that the flow_disector > can properly parse the packet and thus allows hashing to function properly. This is

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 15:44:58 +0200, Pavel Machek wrote: > On Tue 2017-06-20 13:37:22, Steve Twiss wrote: > > Hi Pavel, > > > > On 20 June 2017 14:26, Pavel Machek wrote: > > > > > Subject: Re: [PATCH 00/51] rtc: stop using rtc deprecated functions > > > > > > On Tue 2017-06-20 14:24:00, Alexandre

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Pavel Machek
On Tue 2017-06-20 13:37:22, Steve Twiss wrote: > Hi Pavel, > > On 20 June 2017 14:26, Pavel Machek wrote: > > > Subject: Re: [PATCH 00/51] rtc: stop using rtc deprecated functions > > > > On Tue 2017-06-20 14:24:00, Alexandre Belloni wrote: > > > On 20/06/2017 at 14:10:11 +0200, Pavel Machek

pull-request: wireless-drivers 2017-06-20

2017-06-20 Thread Kalle Valo
Hi Dave, here's a pull request to net tree, few important fixes still I would like to have in 4.12. Please let me know if there are any problems. Kalle The following changes since commit dc89481bb4c9af0700423e21c8371379d3d943b1: Merge tag 'iwlwifi-for-kalle-2017-06-05' of

RE: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Steve Twiss
Hi Pavel, On 20 June 2017 14:26, Pavel Machek wrote: > Subject: Re: [PATCH 00/51] rtc: stop using rtc deprecated functions > > On Tue 2017-06-20 14:24:00, Alexandre Belloni wrote: > > On 20/06/2017 at 14:10:11 +0200, Pavel Machek wrote: > > > On Tue 2017-06-20 12:03:48, Alexandre Belloni wrote:

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-20 Thread Andrew Lunn
> >> The question really is, why is not this properly integrated into the PHY > >> driver and PHYLIB such that the only thing the Ethernet MAC driver has > >> to call is a function of the PHY driver putting it in self-test? > > > > This whole driver pokes various PHY registers, rather than use >

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-20 Thread Andrew Lunn
On Tue, Jun 20, 2017 at 11:05:54AM +0800, l00371289 wrote: > hi, Florian > > On 2017/6/20 5:00, Florian Fainelli wrote: > > On 06/16/2017 02:24 AM, Lin Yun Sheng wrote: > >> This patch fixes the phy loopback self_test failed issue. when > >> Marvell Phy Module is loaded, it will powerdown fiber

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Pavel Machek
On Tue 2017-06-20 14:24:00, Alexandre Belloni wrote: > On 20/06/2017 at 14:10:11 +0200, Pavel Machek wrote: > > On Tue 2017-06-20 12:03:48, Alexandre Belloni wrote: > > > On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: > > > > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because

Re: [PATCH net-next] sctp: handle errors when updating asoc

2017-06-20 Thread Neil Horman
On Tue, Jun 20, 2017 at 04:05:11PM +0800, Xin Long wrote: > It's a bad thing not to handle errors when updating asoc. The memory > allocation failure in any of the functions called in sctp_assoc_update() > would cause sctp to work unexpectedly. > > This patch is to fix it by aborting the asoc and

Re: clean up and modularize arch dma_mapping interface

2017-06-20 Thread Christoph Hellwig
On Tue, Jun 20, 2017 at 11:19:02AM +0200, Daniel Vetter wrote: > Ack for the 2 drm patches, but I can also pick them up through drm-misc if > you prefer that (but then it'll be 4.14). Nah, I'll plan to set up a dma-mapping tree so that we'll have common place for dma-mapping work.

Re: new dma-mapping tree, was Re: clean up and modularize arch dma_mapping interface V2

2017-06-20 Thread Christoph Hellwig
On Tue, Jun 20, 2017 at 11:04:00PM +1000, Stephen Rothwell wrote: > git://git.linaro.org/people/mszyprowski/linux-dma-mapping.git#dma-mapping-next > > Contacts: Marek Szyprowski and Kyungmin Park (cc'd) > > I have called your tree dma-mapping-hch for now. The other tree has > not been updated

Re: new dma-mapping tree, was Re: clean up and modularize arch dma_mapping interface V2

2017-06-20 Thread Robin Murphy
Hi Christoph, On 20/06/17 13:41, Christoph Hellwig wrote: > On Fri, Jun 16, 2017 at 08:10:15PM +0200, Christoph Hellwig wrote: >> I plan to create a new dma-mapping tree to collect all this work. >> Any volunteers for co-maintainers, especially from the iommu gang? > > Ok, I've created the new

Re: new dma-mapping tree, was Re: clean up and modularize arch dma_mapping interface V2

2017-06-20 Thread Christoph Hellwig
On Tue, Jun 20, 2017 at 02:14:36PM +0100, Robin Murphy wrote: > Hi Christoph, > > On 20/06/17 13:41, Christoph Hellwig wrote: > > On Fri, Jun 16, 2017 at 08:10:15PM +0200, Christoph Hellwig wrote: > >> I plan to create a new dma-mapping tree to collect all this work. > >> Any volunteers for

Re: new dma-mapping tree, was Re: clean up and modularize arch dma_mapping interface V2

2017-06-20 Thread Stephen Rothwell
Hi Christoph, On Tue, 20 Jun 2017 14:41:40 +0200 Christoph Hellwig wrote: > > On Fri, Jun 16, 2017 at 08:10:15PM +0200, Christoph Hellwig wrote: > > I plan to create a new dma-mapping tree to collect all this work. > > Any volunteers for co-maintainers, especially from the iommu

[PATCH v4 net-next 7/7] qed: SPQ async callback registration

2017-06-20 Thread Yuval Mintz
From: Michal Kalderon Whenever firmware indicates that there's an async indication it needs to handle, there's a switch-case where the right functionality is called based on function's personality and information. Before iWARP is added [as yet another client], switch

[PATCH v4 net-next 6/7] qed: Wait for resources before FUNC_CLOSE

2017-06-20 Thread Yuval Mintz
From: Michal Kalderon Driver needs to wait for all resources to return from FW before it can send the FUNC_CLOSE ramrod. Signed-off-by: Michal Kalderon Signed-off-by: Yuval Mintz ---

[PATCH v4 net-next 3/7] qed: Disable RoCE dpm when DCBx change occurs

2017-06-20 Thread Yuval Mintz
If DCBx update occurs while QPs are open, stop sending edpms until all QPs are closed. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 8 +++ drivers/net/ethernet/qlogic/qed/qed_roce.c | 36 ++

[PATCH v4 net-next 2/7] qed: RoCE EDPM to honor PFC

2017-06-20 Thread Yuval Mintz
Configure device according to DCBx results so that EDPMs made by RoCE would honor flow-control. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 16 drivers/net/ethernet/qlogic/qed/qed_reg_addr.h | 6 ++ 2 files

[PATCH v4 net-next 4/7] qed*: qede_roce.[ch] -> qede_rdma.[ch]

2017-06-20 Thread Yuval Mintz
From: Michal Kalderon Once we have iWARP support, the qede portion of the qedr<->qede would serve all the RDMA protocols - so rename the file to be appropriate to its function. While we're at it, we're also moving a couple of inclusions to it into .h files and adding

[PATCH v4 net-next 5/7] qed*: Set rdma generic functions prefix

2017-06-20 Thread Yuval Mintz
From: Michal Kalderon Rename the functions common to both iWARP and RoCE to have a prefix of _rdma_ instead of _roce_. Signed-off-by: Michal Kalderon Signed-off-by: Yuval Mintz ---

[PATCH v4 net-next 1/7] qed: Chain support for external PBL

2017-06-20 Thread Yuval Mintz
iWARP would require the chains to allocate/free their PBL memory independently, so add the infrastructure to provide it externally. Signed-off-by: Yuval Mintz --- drivers/infiniband/hw/qedr/main.c | 2 +- drivers/infiniband/hw/qedr/verbs.c| 6

[PATCH v4 net-next 0/7] qed*: RDMA and infrastructure for iWARP

2017-06-20 Thread Yuval Mintz
This series focuses on RDMA in general with emphasis on required changes toward adding iWARP support. The vast majority of the changes introduced are in qed/qede, with a couple of small changes to qedr [mentioned below]. The infrastructure changes: - Patch #1 adds the ability to pass PBL memory

RE: remove dma_alloc_noncoherent

2017-06-20 Thread David Laight
From: Christoph Hellwig > Sent: 16 June 2017 08:17 > > For many years we've had the dma_alloc_attrs API that is more flexible > than dma_alloc_noncoherent. This series moves the remaining users over > to the attrs API. And most of the callers probably only want to specify 'noncoherent'. Grepping

new dma-mapping tree, was Re: clean up and modularize arch dma_mapping interface V2

2017-06-20 Thread Christoph Hellwig
On Fri, Jun 16, 2017 at 08:10:15PM +0200, Christoph Hellwig wrote: > I plan to create a new dma-mapping tree to collect all this work. > Any volunteers for co-maintainers, especially from the iommu gang? Ok, I've created the new tree: git://git.infradead.org/users/hch/dma-mapping.git for-next

RE: [net-next 11/15] net/mlx5e: Reduce number of heap allocated buffers for update stats

2017-06-20 Thread David Laight
From: Saeed Mahameed > Sent: 15 June 2017 22:43 > Allocating buffers on the heap every 200ms is something we should avoid, > let's use buffers located on the stack instead. ... > + u32 in[MLX5_ST_SZ_DW(ppcnt_reg)] = {0}; How big is that? Allocating large on-stack buffers is even worse. One

[PATCH net] net: stmmac: free an skb first when there are no longer any descriptors using it

2017-06-20 Thread Niklas Cassel
When having the skb pointer in the first descriptor, stmmac_tx_clean can get called at a moment where the IP has only cleared the own bit of the first descriptor, thus freeing the skb, even though there can be several descriptors whose buffers point into the same skb. By simply moving the skb

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 14:10:11 +0200, Pavel Machek wrote: > On Tue 2017-06-20 12:03:48, Alexandre Belloni wrote: > > On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: > > > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they > > > rely on 32bits variables and that will make rtc

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Pavel Machek
On Tue 2017-06-20 12:03:48, Alexandre Belloni wrote: > On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: > > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they > > rely on 32bits variables and that will make rtc break in y2038/2016. > > Please don't, because this hide the

[PATCH net] sfc: remove duplicate up_write on VF filter_sem

2017-06-20 Thread Edward Cree
Somehow two copies of the line 'up_write(>efx->filter_sem);' got into efx_ef10_sriov_set_vf_vlan(). This would put the mutex in a bad state and cause all subsequent down attempts to hang. Fixes: 671b53eec2ed ("sfc: Ensure down_write(_sem) and up_write() are matched before calling

[PATCH] rtnetlink: add IFLA_GROUP to ifla_policy

2017-06-20 Thread Serhey Popovych
Network interface groups support added while ago, however there is no IFLA_GROUP attribute description in policy and netlink message size calculations until now. Add IFLA_GROUP attribute to the policy. Fixes: cbda10fa97d7 ("net_device: add support for network device groups") Signed-off-by:

Re: [PATCH] dt-bindings: net: sms911x: Add missing optional VDD regulators

2017-06-20 Thread Linus Walleij
On Mon, Jun 19, 2017 at 6:05 PM, Krzysztof Kozlowski wrote: > The lan911x family of devices require supplying from 3.3 V power > supplies (connected to VDD_IO, VDD_A and VREG_3.3 pins). The existing > driver however obtains only VDD_IO and VDD_A regulators in an optional > way

Re: [PATCH net-next 0/1] Introduction of the tc tests

2017-06-20 Thread Jamal Hadi Salim
On 17-06-20 01:40 AM, Stephen Hemminger wrote: The "Occum's razor" for deciding where tests belong should be does the test need to change to respond to kernel change? Don't want to have iproute2 tests that have if (kernel_version > ...) The suite is intended to include both forward and

Re: [PATCH 03/11] au1100fb: remove a bogus dma_free_nonconsistent call

2017-06-20 Thread Bartlomiej Zolnierkiewicz
On Tuesday, June 20, 2017 11:10:45 AM Christoph Hellwig wrote: > On Mon, Jun 19, 2017 at 01:15:04PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On Friday, June 16, 2017 09:17:08 AM Christoph Hellwig wrote: > > > au1100fb is using managed dma allocations, so it doesn't need to > > > explicitly free

Re: [PATCH net-next 09/10] net/mlx4_en: Replace TXBB_SIZE multiplications with shift operations

2017-06-20 Thread Tariq Toukan
On 20/06/2017 11:45 AM, David Laight wrote: From: Tariq Toukan Sent: 15 June 2017 12:36 Define LOG_TXBB_SIZE, log of TXBB_SIZE, and use it with a shift operation instead of a multiplication with TXBB_SIZE. Operations are equivalent as TXBB_SIZE is a power of two. Performance tests: Tested on

Re: [PATCH] loopback: Force LOOPBACK_IFINDEX for registration

2017-06-20 Thread Serhey Popovych
> From: Serhey Popovych > Date: Fri, 16 Jun 2017 15:10:03 +0300 > >> Now with commit 9c7dafb (net: Allow to create links with >> given ifindex) support registration of network devices >> with specific ifindex is added. >> >> We can force loopback network device index

ipv6: Do not leak throw route references

2017-06-20 Thread Serhey Popovych
While commit 73ba57bfae4a ("ipv6: fix backtracking for throw routes") does good job on error propagation to the fib_rules_lookup() in fib rules core framework that also corrects throw routes handling, it does not solve route reference leakage problem happened when we return -EAGAIN to the

Re: [PATCH] net: introduce SO_PEERGROUPS getsockopt

2017-06-20 Thread Tom Gundersen
On Fri, Jun 16, 2017 at 10:31 PM, David Herrmann wrote: > This adds the new getsockopt(2) option SO_PEERGROUPS on SOL_SOCKET to > retrieve the auxiliary groups of the remote peer. It is designed to > naturally extend SO_PEERCRED. That is, the underlying data is from the >

Re: [RFC 1/2] net-next: fix DSA flow_disection

2017-06-20 Thread Sergei Shtylyov
Hello! On 6/20/2017 11:06 AM, John Crispin wrote: RPS and probably other kernel features are currently broken on some if not all DSA devices. The root cause of this that skb_hash will call the "Is" missing between "this" and "that"? flow_disector. At this point the skb still contains the

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 12:03:48 +0200, Alexandre Belloni wrote: > On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: > > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they > > rely on 32bits variables and that will make rtc break in y2038/2016. > > Please don't, because this hide

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 11:35:08 +0200, Benjamin Gaignard wrote: > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they > rely on 32bits variables and that will make rtc break in y2038/2016. Please don't, because this hide the fact that the hardware will not handle dates in y2038 anyway and

[PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Benjamin Gaignard
rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they rely on 32bits variables and that will make rtc break in y2038/2016. The goal of this series of patches is ti stop using those two functions and use instead to safer 64bits ones. It also remove change .set_mmss to set_mmss64

[PATCH 03/51] net: broadcom: stop using rtc deprecated functions

2017-06-20 Thread Benjamin Gaignard
rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they rely on 32bits variables and that will make rtc break in y2038/2016. Stop using those two functions to safer 64bits ones. Signed-off-by: Benjamin Gaignard CC: Michael Chan

Re: TCP Vegas per-socket alpha, beta, gamma parameters

2017-06-20 Thread Lars Erik Storbukås
On Mon, Jun 19, 2017 at 3:30 PM, Lawrence Brakmo wrote: > Hi Lars, > > You would need to modify the source code to support per connection alpha, > beta and gamma parameters. Although you can modify the parameters at runtime, > they would apply to all connections using Vegas, both

Re: [PATCH net-next v2 4/4] ip6mr: add netlink notifications on mrt6msg cache reports

2017-06-20 Thread Nikolay Aleksandrov
On 19/06/17 23:44, Julien Gomes wrote: > Add Netlink notifications on cache reports in ip6mr, in addition to the > existing mrt6msg sent to mroute6_sk. > Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV6_MROUTE_R. > > MSGTYPE, MIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the >

<    1   2   3   >