pull-request: wireless-drivers 2017-06-20

2017-06-20 Thread Kalle Valo
Hi Dave, here's a pull request to net tree, few important fixes still I would like to have in 4.12. Please let me know if there are any problems. Kalle The following changes since commit dc89481bb4c9af0700423e21c8371379d3d943b1: Merge tag 'iwlwifi-for-kalle-2017-06-05' of

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 15:44:58 +0200, Pavel Machek wrote: > On Tue 2017-06-20 13:37:22, Steve Twiss wrote: > > Hi Pavel, > > > > On 20 June 2017 14:26, Pavel Machek wrote: > > > > > Subject: Re: [PATCH 00/51] rtc: stop using rtc deprecated functions > > > > > > On Tue 2017-06-20 14:24:00, Alexandre

[PATCH net-next 3/4] s390/diag: add diag26c support

2017-06-20 Thread Julian Wiedmann
Implement support for the hypervisor diagnose 0x26c ('Access Certain System Information'). It passes a request buffer and a subfunction code, and receives a response buffer and a return code. Also add the scaffolding for the 'MAC Services' subfunction. It may be used by network devices to obtain

[PATCH net-next 1/4] s390/qeth: add ipa return codes for bridgeport

2017-06-20 Thread Julian Wiedmann
From: Kittipon Meesompop add ipa return codes for Bridgeport (HiperSockets and OSA) according to system level design. Signed-off-by: Kittipon Meesompop Reviewed-by: Julian Wiedmann Reviewed-by: Ursula Braun

[PATCH net-next 0/4] s390/net updates, part 2 (v2)

2017-06-20 Thread Julian Wiedmann
Hi Dave, thanks for the feedback. Here's an updated patchset that honours the reverse christmas tree and drops the __packed attribute. Please apply. Thanks, Julian Julian Wiedmann (3): s390/qeth: fix packing buffer statistics s390/diag: add diag26c support s390/qeth: use diag26c to get

Re: Repeatable inet6_dump_fib crash in stock 4.12.0-rc4+

2017-06-20 Thread Ben Greear
On 06/14/2017 03:25 PM, David Ahern wrote: On 6/14/17 4:23 PM, Ben Greear wrote: On 06/13/2017 07:27 PM, David Ahern wrote: Let's try a targeted debug patch. See attached I had to change it to pr_err so it would go to our serial console since the system locked hard on crash, and that

[PATCH v4 net-next 4/7] qed*: qede_roce.[ch] -> qede_rdma.[ch]

2017-06-20 Thread Yuval Mintz
From: Michal Kalderon Once we have iWARP support, the qede portion of the qedr<->qede would serve all the RDMA protocols - so rename the file to be appropriate to its function. While we're at it, we're also moving a couple of inclusions to it into .h files and adding

[PATCH v4 net-next 5/7] qed*: Set rdma generic functions prefix

2017-06-20 Thread Yuval Mintz
From: Michal Kalderon Rename the functions common to both iWARP and RoCE to have a prefix of _rdma_ instead of _roce_. Signed-off-by: Michal Kalderon Signed-off-by: Yuval Mintz ---

[PATCH v4 net-next 3/7] qed: Disable RoCE dpm when DCBx change occurs

2017-06-20 Thread Yuval Mintz
If DCBx update occurs while QPs are open, stop sending edpms until all QPs are closed. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 8 +++ drivers/net/ethernet/qlogic/qed/qed_roce.c | 36 ++

[PATCH v4 net-next 7/7] qed: SPQ async callback registration

2017-06-20 Thread Yuval Mintz
From: Michal Kalderon Whenever firmware indicates that there's an async indication it needs to handle, there's a switch-case where the right functionality is called based on function's personality and information. Before iWARP is added [as yet another client], switch

[PATCH v4 net-next 6/7] qed: Wait for resources before FUNC_CLOSE

2017-06-20 Thread Yuval Mintz
From: Michal Kalderon Driver needs to wait for all resources to return from FW before it can send the FUNC_CLOSE ramrod. Signed-off-by: Michal Kalderon Signed-off-by: Yuval Mintz ---

[PATCH v4 net-next 2/7] qed: RoCE EDPM to honor PFC

2017-06-20 Thread Yuval Mintz
Configure device according to DCBx results so that EDPMs made by RoCE would honor flow-control. Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 16 drivers/net/ethernet/qlogic/qed/qed_reg_addr.h | 6 ++ 2 files

Re: new dma-mapping tree, was Re: clean up and modularize arch dma_mapping interface V2

2017-06-20 Thread Christoph Hellwig
On Tue, Jun 20, 2017 at 11:04:00PM +1000, Stephen Rothwell wrote: > git://git.linaro.org/people/mszyprowski/linux-dma-mapping.git#dma-mapping-next > > Contacts: Marek Szyprowski and Kyungmin Park (cc'd) > > I have called your tree dma-mapping-hch for now. The other tree has > not been updated

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-20 Thread Andrew Lunn
On Tue, Jun 20, 2017 at 11:05:54AM +0800, l00371289 wrote: > hi, Florian > > On 2017/6/20 5:00, Florian Fainelli wrote: > > On 06/16/2017 02:24 AM, Lin Yun Sheng wrote: > >> This patch fixes the phy loopback self_test failed issue. when > >> Marvell Phy Module is loaded, it will powerdown fiber

[net-next 04/10] net/mlx5e: Add new profile function update_carrier

2017-06-20 Thread Saeed Mahameed
From: Erez Shitrit Updating the carrier involves specific HW setting, each profile should use its own function for that. Both IPoIB and VF representor don't need carrier update function, since VF representor has only a logical link to VF and IPoIB manages its own link via

[net-next 08/10] net/mlx5e: IPoIB, Get more TX statistics

2017-06-20 Thread Saeed Mahameed
From: Erez Shitrit Add misses counters (bytes, packet, gso, xmit_more) in TX flow for ipoib traffic. Fixes: 58545449b7b ("net/mlx5e: IPoIB, Xmit flow") Signed-off-by: Erez Shitrit Signed-off-by: Saeed Mahameed ---

[net-next 10/10] net/mlx5e: IPoIB, Add ioctl support to IPoIB device driver

2017-06-20 Thread Saeed Mahameed
From: Feras Daoud Add ioctl support to IPoIB device driver. For now, this ioctl will support timestamp get and set. Signed-off-by: Feras Daoud Signed-off-by: Eitan Rabin Signed-off-by: Saeed Mahameed ---

[net-next 05/10] net/mlx5e: IPoIB, Change parameters default values

2017-06-20 Thread Saeed Mahameed
From: Erez Shitrit Add function that sets the default values for ipoib, setting/clearing abilities that IPoIB doesn't support, like RQ size in this case. Signed-off-by: Erez Shitrit Signed-off-by: Saeed Mahameed ---

Re: [PATCH net-next] sctp: handle errors when updating asoc

2017-06-20 Thread Neil Horman
On Tue, Jun 20, 2017 at 04:05:11PM +0800, Xin Long wrote: > It's a bad thing not to handle errors when updating asoc. The memory > allocation failure in any of the functions called in sctp_assoc_update() > would cause sctp to work unexpectedly. > > This patch is to fix it by aborting the asoc and

Re: [PATCH NET] net/hns:bugfix of ethtool -t phy self_test

2017-06-20 Thread Andrew Lunn
> >> The question really is, why is not this properly integrated into the PHY > >> driver and PHYLIB such that the only thing the Ethernet MAC driver has > >> to call is a function of the PHY driver putting it in self-test? > > > > This whole driver pokes various PHY registers, rather than use >

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Pavel Machek
On Tue 2017-06-20 13:37:22, Steve Twiss wrote: > Hi Pavel, > > On 20 June 2017 14:26, Pavel Machek wrote: > > > Subject: Re: [PATCH 00/51] rtc: stop using rtc deprecated functions > > > > On Tue 2017-06-20 14:24:00, Alexandre Belloni wrote: > > > On 20/06/2017 at 14:10:11 +0200, Pavel Machek

Re: [PATCH net-next] ibmvnic: Return from ibmvnic_resume if not in VNIC_OPEN state

2017-06-20 Thread David Miller
From: John Allen Date: Mon, 19 Jun 2017 11:27:53 -0500 > If the ibmvnic driver is not in the VNIC_OPEN state, return from > ibmvnic_resume callback. If we are not in the VNIC_OPEN state, interrupts > may not be initialized and directly calling the interrupt handler

Re: [PATCH net-next 0/4] s390/net updates, part 2 (v2)

2017-06-20 Thread David Miller
From: Julian Wiedmann Date: Tue, 20 Jun 2017 16:00:30 +0200 > thanks for the feedback. Here's an updated patchset that honours > the reverse christmas tree and drops the __packed attribute. Please apply. Series applied.

Re: [Patch net] igmp: add a missing spin_lock_init()

2017-06-20 Thread David Miller
From: Cong Wang Date: Tue, 20 Jun 2017 10:46:27 -0700 > Andrey reported a lockdep warning on non-initialized > spinlock: > > INFO: trying to register non-static key. > the code is fine but needs lockdep annotation. > turning off the locking correctness validator. >

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Alexandre Belloni
On 20/06/2017 at 22:15:36 +0100, Russell King - ARM Linux wrote: > On Tue, Jun 20, 2017 at 05:07:46PM +0200, Benjamin Gaignard wrote: > > 2017-06-20 15:48 GMT+02:00 Alexandre Belloni > > : > > >> Yes, that's argument against changing rtc _drivers_ for hardware

Re: [PATCH net-next 00/12] nfp: add flower app with representors

2017-06-20 Thread Simon Horman
On Tue, Jun 20, 2017 at 07:13:43PM +0300, Or Gerlitz wrote: > On Tue, Jun 20, 2017 at 8:51 AM, Simon Horman > wrote: > > this series adds a flower app to the NFP driver. > > It initialises four types of netdevs: > > > > * PF netdev - lower-device for communication of

Re: [PATCH net-next] net: stmmac: enable TSO for IPv6

2017-06-20 Thread David Miller
From: Niklas Cassel Date: Mon, 19 Jun 2017 18:36:44 +0200 > There is nothing in the IP that prevents us from enabling TSO for IPv6. > > Before patch: > ftp fe80::2aa:bbff:fecc:1336%eth0 > ftp> get /dev/zero > 882512708 bytes received in 00:14 (56.11 MiB/s) > > After

Re: [PATCH] rtnetlink: add IFLA_GROUP to ifla_policy

2017-06-20 Thread David Miller
From: Serhey Popovych Date: Tue, 20 Jun 2017 14:35:23 +0300 > Network interface groups support added while ago, however > there is no IFLA_GROUP attribute description in policy > and netlink message size calculations until now. > > Add IFLA_GROUP attribute to the

[PATCH] [PATCH v2 net-next] bonding: Convert multiple netdev_info messages to netdev_dbg

2017-06-20 Thread Michael J Dilmore
The bond_options.c file contains several netdev_info messages that clutter kernel output. This patch changes all netdev_info messages to netdev_dbg and adds a netdev debug for the packets per slave parameter. Suggested-by: Joe Perches Signed-off-by: Michael J Dilmore

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Pavel Machek
Hi! > >> > This is it. > >> > https://patchwork.kernel.org/patch/6219401/ > >> > >> Thanks. > >> > >> Yes, that's argument against changing rtc _drivers_ for hardware that > >> can not do better than 32bit. For generic code (such as 44/51 sysfs, > >> 51/51 suspend test), the change still makes

[Patch net] ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER

2017-06-20 Thread Cong Wang
In commit 242d3a49a2a1 ("ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf") I assumed NETDEV_REGISTER and NETDEV_UNREGISTER are paired, unfortunately, as reported by jeffy, netdev_wait_allrefs() could rebroadcast NETDEV_UNREGISTER event until all refs are gone. We have to add an

Re: [oss-drivers] Re: [PATCH net-next 00/12] nfp: add flower app with representors

2017-06-20 Thread Jakub Kicinski
On Tue, 20 Jun 2017 19:13:43 +0300, Or Gerlitz wrote: > > Control queues are used to send and receive control messages which are > > used to communicate configuration information with the firmware. These > > are in separate vNIC to the queues belonging to the PF netdev. The control > > queues are

Re: [PATCH net] net: stmmac: free an skb first when there are no longer any descriptors using it

2017-06-20 Thread David Miller
From: Niklas Cassel Date: Tue, 20 Jun 2017 14:32:41 +0200 > When having the skb pointer in the first descriptor, stmmac_tx_clean > can get called at a moment where the IP has only cleared the own bit > of the first descriptor, thus freeing the skb, even though there can >

Re: [pull request][net-next 00/10] Mellanox, mlx5 IPoIB updates 2017-06-20

2017-06-20 Thread David Miller
From: Saeed Mahameed Date: Tue, 20 Jun 2017 17:13:04 +0300 > This series mainly from Erez and Feras includes some updates and > ethtool/ndos extension to the mlx5 IPoIB netdevice. > > for more detalis please see tag log below. > > Please pull and let me know if there's any

Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data

2017-06-20 Thread Felix Manlunas
From: Derek Chickles Date: Tue, 20 Jun 2017 13:15:34 -0700 > > From: David Miller [mailto:da...@davemloft.net] > > Sent: Tuesday, June 20, 2017 12:22 PM > > > > From: Denys Vlasenko > > Date: Mon, 19 Jun 2017 21:50:52 +0200 > > > > > Only

Re: [PATCH net-next] sctp: uncork the old asoc before changing to the new one

2017-06-20 Thread Neil Horman
On Tue, Jun 20, 2017 at 04:01:55PM +0800, Xin Long wrote: > local_cork is used to decide if it should uncork asoc outq after processing > some cmds, and it is set when replying or sending msgs. local_cork should > always have the same value with current asoc q->cork in some way. > > The thing is

Re: [PATCH] net: phy: smsc: fix buffer overflow in memcpy

2017-06-20 Thread Andrew Lunn
On Tue, Jun 20, 2017 at 10:40:46PM +0200, Arnd Bergmann wrote: > The memcpy annotation triggers for a fixed-length buffer copy: > > In file included from /git/arm-soc/arch/arm64/include/asm/processor.h:30:0, > from /git/arm-soc/arch/arm64/include/asm/spinlock.h:21, >

Re: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data

2017-06-20 Thread David Miller
From: Denys Vlasenko Date: Mon, 19 Jun 2017 21:50:52 +0200 > Only compile-tested - I don't have the hardware. > > From code inspection, octeon_pci_write_core_mem() appears to be safe wrt > unaligned source. In any case, u8 fbuf[] was not guaranteed to be aligned > anyway. >

Re: [PATCH net-next v2 0/4] ipmr/ip6mr: add Netlink notifications on cache reports

2017-06-20 Thread David Miller
From: Julien Gomes Date: Mon, 19 Jun 2017 13:44:13 -0700 > Currently, all ipmr/ip6mr cache reports are sent through the > mroute/mroute6 socket only. > This forces the use of a single socket for mroute programming, cache > reports and, regarding ipmr, IGMP messages without

Re: [PATCH net] sfc: remove duplicate up_write on VF filter_sem

2017-06-20 Thread David Miller
From: Edward Cree Date: Tue, 20 Jun 2017 13:08:51 +0100 > Somehow two copies of the line 'up_write(>efx->filter_sem);' got into > efx_ef10_sriov_set_vf_vlan(). This would put the mutex in a bad state and > cause all subsequent down attempts to hang. > > Fixes:

[PATCH net-next v3 0/4] ipmr/ip6mr: add Netlink notifications on cache reports

2017-06-20 Thread Julien Gomes
Currently, all ipmr/ip6mr cache reports are sent through the mroute/mroute6 socket only. This forces the use of a single socket for mroute programming, cache reports and, regarding ipmr, IGMP messages without Router Alert option reception. The present patches are aiming to send Netlink

[PATCH] net: intel: e1000e: add check on e1e_wphy() return value

2017-06-20 Thread Gustavo A. R. Silva
Check return value from call to e1e_wphy(). This value is being checked during previous calls to function e1e_wphy() and it seems a check was missing here. Addresses-Coverity-ID: 1226905 Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/intel/e1000e/ich8lan.c

[PATCH net-next v2 05/12] nfp: general representor implementation

2017-06-20 Thread Simon Horman
Provide infrastructure to create and destroy representors of a given type. Parts based on work by Bert van Leeuwen, Benjamin LaHaise, and Jakub Kicinski. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski ---

[PATCH net-next v2 04/12] nfp: map mac_stats and vf_cfg BARs

2017-06-20 Thread Simon Horman
If present map mac_stats and vf_cfg BARs. These will be used by representor netdevs to read statistics for phys port and vf representors. Also provide defines describing the layout of the mac_stats area. Similar defines are already present for the cf_cfg area. Based in part on work by Jakub

[PATCH net-next v2 03/12] nfp: move physical port init into a helper

2017-06-20 Thread Simon Horman
From: Jakub Kicinski Move MAC/PHY port init into a helper to make it easier to reuse it in the representor code. Signed-off-by: Jakub Kicinski Signed-off-by: Simon Horman ---

[PATCH net-next v2 02/12] nfp: devlink add support for getting eswitch mode

2017-06-20 Thread Simon Horman
From: Jakub Kicinski Add app callback for reporting eswitch mode. Non-SRIOV apps should not implement this callback, nfp_app code will then respond with -EOPNOTSUPP. Signed-off-by: Jakub Kicinski Signed-off-by: Simon Horman

[PATCH net-next v2 09/12] nfp: add support for tx/rx with metadata portid

2017-06-20 Thread Simon Horman
Allow tx/rx with metadata port id. This will be used for tx/rx of representor netdevs acting as upper-devices while a pf netdev acts as a lower-device. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski ---

[PATCH net-next v2 07/12] nfp: app callbacks for SRIOV

2017-06-20 Thread Simon Horman
Add app-callbacks for app-specific initialisation of SRIOV. Disabling SRIOV is brought forward in nfp_pci_remove() so that nfp_app_sriov_disable is called while the app still exists. This is intended to be used to implement representor netdevs for virtual ports. Signed-off-by: Simon Horman

[PATCH net-next v2 00/12] nfp: add flower app with representors

2017-06-20 Thread Simon Horman
Hi, this series adds a flower app to the NFP driver. It initialises four types of netdevs: * PF netdev - lower-device for communication of packets to device * PF representor netdev * VF representor netdevs * Phys port representor netdevs The PF netdev acts as a lower-device which sends and

[PATCH net-next v2 08/12] nfp: provide nfp_port to of nfp_net_get_mac_addr()

2017-06-20 Thread Simon Horman
Provide port rather than vNIC as parameter of nfp_net_get_mac_addr. This is to allow this function to be used by representor netdevs where a vNIC may have more than one physical port none of which are associated with the vNIC. Signed-off-by: Simon Horman Reviewed-by:

[PATCH net-next v2 10/12] nfp: add support for control messages for flower app

2017-06-20 Thread Simon Horman
In preparation for adding a new flower app - targeted at offloading the flower classifier - provide support for control message that it will use to communicate with the NFP. Based in part on work by Bert van Leeuwen. Signed-off-by: Simon Horman Reviewed-by: Jakub

[PATCH net-next v2 12/12] nfp: add VF and PF representors to flower app

2017-06-20 Thread Simon Horman
Initialise VF and PF representors in flower app. Based in part on work by Benjamin LaHaise, Bert van Leeuwen and Jakub Kicinski. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski ---

[PATCH net-next v2 11/12] nfp: add flower app

2017-06-20 Thread Simon Horman
Add app for flower offload. At this point the PF netdev and phys port representor netdevs are initialised. Follow-up work will add support for VF and PF representors and beyond that offloading the flower classifier. Based in part on work by Benjamin LaHaise and Bert van Leeuwen. Signed-off-by:

[PATCH net-next v2 06/12] nfp: add stats and xmit helpers for representors

2017-06-20 Thread Simon Horman
Provide helpers for stats and xmit on representor netdevs. Parts based on work by Bert van Leeuwen, Benjamin LaHaise and Jakub Kicinski. Signed-off-by: Simon Horman Reviewed-by: Jakub Kicinski ---

[PATCH net-next v2 01/12] net: store port/representator id in metadata_dst

2017-06-20 Thread Simon Horman
From: Jakub Kicinski Switches and modern SR-IOV enabled NICs may multiplex traffic from Port representators and control messages over single set of hardware queues. Control messages and muxed traffic may need ordered delivery. Those requirements make it hard to

Re: [RFC 1/2] net-next: fix DSA flow_disection

2017-06-20 Thread Andrew Lunn
> On Tue, Jun 20, 2017 at 07:37:35PM +0200, John Crispin wrote: > > > On 20/06/17 16:01, Andrew Lunn wrote: > >On Tue, Jun 20, 2017 at 10:06:54AM +0200, John Crispin wrote: > >>RPS and probably other kernel features are currently broken on some if not > >>all DSA devices. The root cause of this

Re: [PATCH] dt-bindings: net: sms911x: Add missing optional VDD regulators

2017-06-20 Thread David Miller
From: Krzysztof Kozlowski Date: Mon, 19 Jun 2017 18:05:41 +0200 > The lan911x family of devices require supplying from 3.3 V power > supplies (connected to VDD_IO, VDD_A and VREG_3.3 pins). The existing > driver however obtains only VDD_IO and VDD_A regulators in an optional >

Re: [PATCH net-next v2] enic: Fix format truncation warning

2017-06-20 Thread David Miller
From: Govindarajulu Varadarajan Date: Mon, 19 Jun 2017 16:28:44 -0700 > With -Wformat-truncation, gcc throws the following warning. > > Fix this by increasing the size of devname to accommodate 15 character > netdev interface name and description. > > Remove length format

Re: ipv6: Do not leak throw route references

2017-06-20 Thread David Miller
From: Serhey Popovych Date: Tue, 20 Jun 2017 13:29:25 +0300 > While commit 73ba57bfae4a ("ipv6: fix backtracking for throw routes") > does good job on error propagation to the fib_rules_lookup() > in fib rules core framework that also corrects throw routes > handling,

Re: pull-request: wireless-drivers 2017-06-20

2017-06-20 Thread David Miller
From: Kalle Valo Date: Tue, 20 Jun 2017 16:39:59 +0300 > here's a pull request to net tree, few important fixes still I would > like to have in 4.12. Please let me know if there are any problems. Pulled, thanks Kalle.

[GIT] Networking

2017-06-20 Thread David Miller
1) Fix refcounting wrt. timers which hold onto inet6 address objects, from Xin Long. 2) Fix an ancient bug in wireless wext ioctls, from Johannes Berg. 3) Firmware handling fixes in brcm80211 driver, from Arend Van Spriel. 4) Several mlx5 driver fixes (firmware readiness, timestamp cap

[PATCH] net: phy: smsc: fix buffer overflow in memcpy

2017-06-20 Thread Arnd Bergmann
The memcpy annotation triggers for a fixed-length buffer copy: In file included from /git/arm-soc/arch/arm64/include/asm/processor.h:30:0, from /git/arm-soc/arch/arm64/include/asm/spinlock.h:21, from /git/arm-soc/include/linux/spinlock.h:87, from

Re: [PATCH v1 1/2] dt-binding: ptp: add bindings document for dte based ptp clock

2017-06-20 Thread Scott Branden
Hi Rob, On 17-06-18 07:04 AM, Rob Herring wrote: On Mon, Jun 12, 2017 at 01:26:00PM -0700, Arun Parameswaran wrote: Add device tree binding documentation for the Broadcom DTE PTP clock driver. Signed-off-by: Arun Parameswaran ---

Re: [PATCH net-next 06/12] nfp: add stats and xmit helpers for representors

2017-06-20 Thread Simon Horman
On Wed, Jun 21, 2017 at 01:15:05AM +0800, kbuild test robot wrote: > Hi Simon, > > [auto build test ERROR on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Simon-Horman/nfp-add-flower-app-with-representors/20170620-233831 > config: arm-allmodconfig

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Russell King - ARM Linux
On Tue, Jun 20, 2017 at 05:07:46PM +0200, Benjamin Gaignard wrote: > 2017-06-20 15:48 GMT+02:00 Alexandre Belloni > : > >> Yes, that's argument against changing rtc _drivers_ for hardware that > >> can not do better than 32bit. For generic code (such as 44/51

Re: [PATCH net-next v3 07/15] bpf: Add setsockopt helper function to bpf

2017-06-20 Thread Craig Gallek
On Mon, Jun 19, 2017 at 11:00 PM, Lawrence Brakmo wrote: > Added support for calling a subset of socket setsockopts from > BPF_PROG_TYPE_SOCK_OPS programs. The code was duplicated rather > than making the changes to call the socket setsockopt function because > the changes required

Re: [PATCH net-next v3 3/4] ipmr: add netlink notifications on igmpmsg cache reports

2017-06-20 Thread Nikolay Aleksandrov
On 20/06/17 23:54, Julien Gomes wrote: > Add Netlink notifications on cache reports in ipmr, in addition to the > existing igmpmsg sent to mroute_sk. > Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV4_MROUTE_R. > > MSGTYPE, VIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the > same

Re: [net,v2] ipv6: reorder ip6_route_dev_notifier after ipv6_dev_notf

2017-06-20 Thread Cong Wang
On Mon, Jun 19, 2017 at 11:37 PM, jeffy wrote: > Hi Cong Wang, > > > On 06/20/2017 12:54 PM, Cong Wang wrote: >> >> Interesting, I didn't notice this corner-case, because normally >> we would hit the one in rollback_registered_many(). Probably >> we need to add a check

[PATCH net-next v3 1/4] rtnetlink: add NEWCACHEREPORT message type

2017-06-20 Thread Julien Gomes
New NEWCACHEREPORT message type to be used for cache reports sent via Netlink, effectively allowing splitting cache report reception from mroute programming. Suggested-by: Ryan Halbrook Signed-off-by: Julien Gomes Reviewed-by: Nikolay Aleksandrov

Re: [PATCH net-next v3 4/4] ip6mr: add netlink notifications on mrt6msg cache reports

2017-06-20 Thread Nikolay Aleksandrov
On 20/06/17 23:54, Julien Gomes wrote: > Add Netlink notifications on cache reports in ip6mr, in addition to the > existing mrt6msg sent to mroute6_sk. > Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV6_MROUTE_R. > > MSGTYPE, MIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the >

Re: [PATCH net] dccp: call inet_add_protocol after register_pernet_subsys in dccp_v4_init

2017-06-20 Thread David Miller
From: Xin Long Date: Tue, 20 Jun 2017 15:42:38 +0800 > Now dccp_ipv4 works as a kernel module. During loading this module, if > one dccp packet is being recieved after inet_add_protocol but before > register_pernet_subsys in which v4_ctl_sk is initialized, a null pointer >

Re: [PATCH net-next] sctp: uncork the old asoc before changing to the new one

2017-06-20 Thread David Miller
From: Xin Long Date: Tue, 20 Jun 2017 16:01:55 +0800 > local_cork is used to decide if it should uncork asoc outq after processing > some cmds, and it is set when replying or sending msgs. local_cork should > always have the same value with current asoc q->cork in some way.

Re: [PATCH net-next] sctp: handle errors when updating asoc

2017-06-20 Thread David Miller
From: Xin Long Date: Tue, 20 Jun 2017 16:05:11 +0800 > It's a bad thing not to handle errors when updating asoc. The memory > allocation failure in any of the functions called in sctp_assoc_update() > would cause sctp to work unexpectedly. > > This patch is to fix it by

Re: [PATCH] cfg80211: Fix a memory leak in error handling path in 'brcmf_cfg80211_attach'

2017-06-20 Thread Arend van Spriel
On 20-06-17 08:22, Christophe JAILLET wrote: > If 'wiphy_new()' fails, we leak 'ops'. Add a new label in the error > handling path to free it in such a case. Thanks. Please add the following tags: Cc: sta...@vger.kernel.org > Fixes: 5c22fb85102a7 ("brcmfmac: add wowl gtk rekeying offload

[net-next PATCH] tcp: md5: hide unused variable

2017-06-20 Thread Arnd Bergmann
Changing from a memcpy to per-member comparison left the size variable unused: net/ipv4/tcp_ipv4.c: In function 'tcp_md5_do_lookup': net/ipv4/tcp_ipv4.c:910:15: error: unused variable 'size' [-Werror=unused-variable] This does not show up when CONFIG_IPV6 is enabled, but the variable can be

Re: [PATCH v2] net/phy: micrel: configure intterupts after autoneg workaround

2017-06-20 Thread Florian Fainelli
On 06/20/2017 10:48 AM, Zach Brown wrote: > The commit ("net/phy: micrel: Add workaround for bad autoneg") fixes an > autoneg failure case by resetting the hardware. This turns off > intterupts. Things will work themselves out if the phy polls, as it will > figure out it's state during a poll.

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Thomas Gleixner
On Tue, 20 Jun 2017, Alexandre Belloni wrote: > On 20/06/2017 at 22:15:36 +0100, Russell King - ARM Linux wrote: > > On Tue, Jun 20, 2017 at 05:07:46PM +0200, Benjamin Gaignard wrote: > > > 2017-06-20 15:48 GMT+02:00 Alexandre Belloni > > > : > > > >> Yes,

Re: [PATCH net] dccp: call inet_add_protocol after register_pernet_subsys in dccp_v6_init

2017-06-20 Thread David Miller
From: Xin Long Date: Tue, 20 Jun 2017 15:44:44 +0800 > Patch "call inet_add_protocol after register_pernet_subsys in dccp_v4_init" > fixed a null pointer dereference issue for dccp_ipv4 module. > > The same fix is needed for dccp_ipv6 module. > > Signed-off-by: Xin Long

RE: [PATCH] liquidio: stop using huge static buffer, save 4096k in .data

2017-06-20 Thread Chickles, Derek
> From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, June 20, 2017 12:22 PM > > From: Denys Vlasenko > Date: Mon, 19 Jun 2017 21:50:52 +0200 > > > Only compile-tested - I don't have the hardware. > > > > From code inspection, octeon_pci_write_core_mem()

[PATCH net-next v3 3/4] ipmr: add netlink notifications on igmpmsg cache reports

2017-06-20 Thread Julien Gomes
Add Netlink notifications on cache reports in ipmr, in addition to the existing igmpmsg sent to mroute_sk. Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV4_MROUTE_R. MSGTYPE, VIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the same data as their equivalent fields in the igmpmsg

[PATCH net-next v3 4/4] ip6mr: add netlink notifications on mrt6msg cache reports

2017-06-20 Thread Julien Gomes
Add Netlink notifications on cache reports in ip6mr, in addition to the existing mrt6msg sent to mroute6_sk. Send RTM_NEWCACHEREPORT notifications to RTNLGRP_IPV6_MROUTE_R. MSGTYPE, MIF_ID, SRC_ADDR and DST_ADDR Netlink attributes contain the same data as their equivalent fields in the mrt6msg

[PATCH net-next v3 2/4] rtnetlink: add restricted rtnl groups for ipv4 and ipv6 mroute

2017-06-20 Thread Julien Gomes
Add RTNLGRP_{IPV4,IPV6}_MROUTE_R as two new restricted groups for the NETLINK_ROUTE family. Binding to these groups specifically requires CAP_NET_ADMIN to allow multicast of sensitive messages (e.g. mroute cache reports). Suggested-by: Nikolay Aleksandrov

Re: [PATCH v2] net/phy: micrel: configure intterupts after autoneg workaround

2017-06-20 Thread Andrew Lunn
On Tue, Jun 20, 2017 at 12:48:11PM -0500, Zach Brown wrote: > The commit ("net/phy: micrel: Add workaround for bad autoneg") fixes an > autoneg failure case by resetting the hardware. This turns off > intterupts. Things will work themselves out if the phy polls, as it will > figure out it's state

Re: Repeatable inet6_dump_fib crash in stock 4.12.0-rc4+

2017-06-20 Thread Ben Greear
On 06/20/2017 11:05 AM, Michal Kubecek wrote: On Tue, Jun 20, 2017 at 07:12:27AM -0700, Ben Greear wrote: On 06/14/2017 03:25 PM, David Ahern wrote: On 6/14/17 4:23 PM, Ben Greear wrote: On 06/13/2017 07:27 PM, David Ahern wrote: Let's try a targeted debug patch. See attached I had to

Re: [PATCH net-next 0/1] Introduction of the tc tests

2017-06-20 Thread David Miller
From: Cong Wang Date: Mon, 19 Jun 2017 21:13:31 -0700 > I thought tools/testing/selftests/ is mainly for those tests close to > kernel ABI and API. What is the criteria for these tests? If any test > can fit in, we somehow would merge the whole LTP... > > I definitely

Re: [PATCH 00/51] rtc: stop using rtc deprecated functions

2017-06-20 Thread Benjamin Gaignard
2017-06-20 15:48 GMT+02:00 Alexandre Belloni : > On 20/06/2017 at 15:44:58 +0200, Pavel Machek wrote: >> On Tue 2017-06-20 13:37:22, Steve Twiss wrote: >> > Hi Pavel, >> > >> > On 20 June 2017 14:26, Pavel Machek wrote: >> > >> > > Subject: Re: [PATCH 00/51]

Re: [PATCH net-next] sctp: uncork the old asoc before changing to the new one

2017-06-20 Thread Marcelo Ricardo Leitner
On Tue, Jun 20, 2017 at 04:01:55PM +0800, Xin Long wrote: > local_cork is used to decide if it should uncork asoc outq after processing > some cmds, and it is set when replying or sending msgs. local_cork should > always have the same value with current asoc q->cork in some way. > > The thing is

Re: [PATCH net-next 00/12] nfp: add flower app with representors

2017-06-20 Thread Or Gerlitz
On Tue, Jun 20, 2017 at 8:51 AM, Simon Horman wrote: > this series adds a flower app to the NFP driver. > It initialises four types of netdevs: > > * PF netdev - lower-device for communication of packets to device > * PF representor netdev > * VF representor netdevs >

Re: [PATCH v4 net-next 0/7] qed*: RDMA and infrastructure for iWARP

2017-06-20 Thread David Miller
From: Yuval Mintz Date: Tue, 20 Jun 2017 15:59:59 +0300 > Please consider applying this series to `net-next'. Series applied, thanks.

Re: fib_rules: Resolve goto rules target on delete

2017-06-20 Thread David Miller
From: Serhey Popovych Date: Fri, 16 Jun 2017 15:44:47 +0300 > We should avoid marking goto rules unresolved when their > target is actually reachable after rule deletion. > > Consolder following sample scenario: > > # ip -4 ru sh > 0: from all lookup local >

Re: [PATCH] veth: Be more robust on network device creation when no attributes

2017-06-20 Thread David Miller
From: Serhey Popovych Date: Fri, 16 Jun 2017 18:05:00 +0300 > There are number of problems with configuration peer > network device in absence of IFLA_VETH_PEER attributes > where attributes for main network device shared with > peer. > > First it is not feasible to

Re: dev: Reclaim network device indexes

2017-06-20 Thread David Miller
From: Serhey Popovych Date: Fri, 16 Jun 2017 19:39:34 +0300 > While making dev_new_index() return zero on overrun prevents > from infinite loop, there is no way to recovery mechanisms > since namespace ifindex only increases and never reused > from released network

Re: [PATCH net-next] sctp: handle errors when updating asoc

2017-06-20 Thread Marcelo Ricardo Leitner
On Tue, Jun 20, 2017 at 04:05:11PM +0800, Xin Long wrote: > It's a bad thing not to handle errors when updating asoc. The memory > allocation failure in any of the functions called in sctp_assoc_update() > would cause sctp to work unexpectedly. > > This patch is to fix it by aborting the asoc and

Re: [RFC 1/2] net-next: fix DSA flow_disection

2017-06-20 Thread Florian Fainelli
On 06/20/2017 07:01 AM, Andrew Lunn wrote: > On Tue, Jun 20, 2017 at 10:06:54AM +0200, John Crispin wrote: >> RPS and probably other kernel features are currently broken on some if not >> all DSA devices. The root cause of this that skb_hash will call the >> flow_disector. > > Hi John > > What

Re: [PATCH net-next 0/3] more skb_put_[data:zero] related work

2017-06-20 Thread David Miller
From: yuan linyu Date: Sun, 18 Jun 2017 22:41:54 +0800 > yuan linyu (3): > net: introduce __skb_put_[zero, data, u8] > net: replace more place to skb_put_[data:zero] > net: manual clean code which call skb_put_[data:zero] Series applied, thanks.

[PATCH net-next] ibmvnic: Correct return code checking for ibmvnic_init during probe

2017-06-20 Thread Nathan Fontenot
Fixes: 6a2fb0e99f9c (ibmvnic: driver initialization for kdump/kexec) The update to ibmvnic_init to allow an EAGAIN return code broke the calling of ibmvnic_init from ibmvnic_probe. The code now will return from this point in the probe routine if anything other than EAGAIN is returned. The check

Re: [PATCH] netxen: Fix a sleep-in-atomic bug in netxen_nic_pci_mem_access_direct

2017-06-20 Thread David Miller
From: Jia-Ju Bai Date: Mon, 19 Jun 2017 10:48:53 +0800 > The driver may sleep under a spin lock, and the function call path is: > netxen_nic_pci_mem_access_direct (acquire the lock by spin_lock) > ioremap --> may sleep > > To fix it, the lock is released before

Re: [PATCH net-next] ibmvnic: Return from ibmvnic_resume if not in VNIC_OPEN state

2017-06-20 Thread Nathan Fontenot
On 06/19/2017 11:27 AM, John Allen wrote: > If the ibmvnic driver is not in the VNIC_OPEN state, return from > ibmvnic_resume callback. If we are not in the VNIC_OPEN state, interrupts > may not be initialized and directly calling the interrupt handler will > cause a crash. > > Signed-off-by:

Re: [RFC 1/2] net-next: fix DSA flow_disection

2017-06-20 Thread John Crispin
On 20/06/17 16:01, Andrew Lunn wrote: On Tue, Jun 20, 2017 at 10:06:54AM +0200, John Crispin wrote: RPS and probably other kernel features are currently broken on some if not all DSA devices. The root cause of this that skb_hash will call the flow_disector. Hi John What is the call path

Re: [PATCH net-next v3 0/6] vxlan: cleanup and IPv6 link-local support

2017-06-20 Thread David Miller
From: Matthias Schiffer Date: Mon, 19 Jun 2017 10:03:54 +0200 > Running VXLANs over IPv6 link-local addresses allows to use them as a > drop-in replacement for VLANs, avoiding to allocate additional outer IP > addresses to run the VXLAN over. > > Since v1, I have

<    1   2   3   >