Re: [PATCH net] virtio-net: fix leaking of ctx array

2017-07-07 Thread Michael S. Tsirkin
On Fri, Jul 07, 2017 at 07:56:09PM +0800, Jason Wang wrote: > Fixes: commit d45b897b11ea ("virtio_net: allow specifying context for rx") > Signed-off-by: Jason Wang Acked-by: Michael S. Tsirkin Needed for stable as well. Thanks Jason. > --- >

[RFC PATCH 06/12] ixgbe: add initial support for xdp redirect

2017-07-07 Thread John Fastabend
There are optimizations we can add after the basic feature is enabled. But, for now keep the patch simple. Signed-off-by: John Fastabend Acked-by: Daniel Borkmann --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 41 -

[RFC PATCH 04/12] xdp: sample program for new bpf_redirect helper

2017-07-07 Thread John Fastabend
This implements a sample program for testing bpf_redirect. It reports the number of packets redirected per second and as input takes the ifindex of the device to run the xdp program on and the ifindex of the interface to redirect packets to. Signed-off-by: John Fastabend

[RFC PATCH 07/12] xdp: add trace event for xdp redirect

2017-07-07 Thread John Fastabend
This adds a trace event for xdp redirect which may help when debugging XDP programs that use redirect bpf commands. Signed-off-by: John Fastabend Acked-by: Daniel Borkmann --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c |2 +-

[RFC PATCH 05/12] net: implement XDP_REDIRECT for xdp generic

2017-07-07 Thread John Fastabend
Add support for redirect to xdp generic creating a fall back for devices that do not yet have support and allowing test infrastructure using veth pairs to be built. Signed-off-by: John Fastabend Tested-by: Andy Gospodarek Acked-by: Daniel Borkmann

[PATCH v3 4/9] completion: Replace spin_unlock_wait() with lock/unlock pair

2017-07-07 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore replaces the spin_unlock_wait() call in completion_done() with spin_lock() followed immediately by spin_unlock(). This should

[PATCH v3 5/9] exit: Replace spin_unlock_wait() with lock/unlock pair

2017-07-07 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore replaces the spin_unlock_wait() call in do_exit() with spin_lock() followed immediately by spin_unlock(). This should be safe

[PATCH net] mpls: fix uninitialized in_label var warning in mpls_getroute

2017-07-07 Thread Roopa Prabhu
From: Roopa Prabhu Fix the below warning generated by static checker: net/mpls/af_mpls.c:2111 mpls_getroute() error: uninitialized symbol 'in_label'." Fixes: 397fc9e5cefe ("mpls: route get support") Reported-by: Dan Carpenter

[PATCH iproute2] ip: change flag names to an array

2017-07-07 Thread Stephen Hemminger
For the most of the address flags, use a table of bit values rather than open coding every value. This allows for easier inevitable expansion of flags. This also fixes the missing stable-privacy flag. Signed-off-by: Stephen Hemminger --- ip/ipaddress.c | 152

Re: [PATCH v2] net: axienet: add support for standard phy-mode binding

2017-07-07 Thread Florian Fainelli
On 07/06/2017 11:50 PM, Alvaro Gamez Machado wrote: > Keep supporting proprietary "xlnx,phy-type" attribute and add support for > MII connectivity to the PHY. > > Signed-off-by: Alvaro Gamez Machado > --- > > Changes since v1: > > * Renamed phy_type to phy_mode.

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-07 Thread Manfred Spraul
Hi Ingo, On 07/07/2017 10:31 AM, Ingo Molnar wrote: There's another, probably just as significant advantage: queued_spin_unlock_wait() is 'read-only', while spin_lock()+spin_unlock() dirties the lock cache line. On any bigger system this should make a very measurable difference - if

[PATCH v3 1/9] net/netfilter/nf_conntrack_core: Fix net_conntrack_lock()

2017-07-07 Thread Paul E. McKenney
From: Manfred Spraul As we want to remove spin_unlock_wait() and replace it with explicit spin_lock()/spin_unlock() calls, we can use this to simplify the locking. In addition: - Reading nf_conntrack_locks_all needs ACQUIRE memory ordering. - The new code avoids the

[PATCH v3 9/9] arch: Remove spin_unlock_wait() arch-specific definitions

2017-07-07 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes the underlying arch-specific arch_spin_unlock_wait() for all architectures providing them. Signed-off-by: Paul E.

[PATCH v3 8/9] locking: Remove spin_unlock_wait() generic definitions

2017-07-07 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore removes spin_unlock_wait() and related definitions from core code. Signed-off-by: Paul E. McKenney

[PATCH v3 6/9] ipc: Replace spin_unlock_wait() with lock/unlock pair

2017-07-07 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore replaces the spin_unlock_wait() call in exit_sem() with spin_lock() followed immediately by spin_unlock(). This should be safe

God dag,

2017-07-07 Thread Corporate Lenders
God dag,    Jeg er Thomas Walter, finansiell agent for dette selskapet kjent som Corporate Lenders. Vi låne penger til enkeltpersoner og selskaper som trenger økonomisk hjelp. Har du dårlig kreditt eller har du behov for penger til å betale regningene dine? Vi bruker dette mediet til å

[RFC PATCH 03/12] xdp: add bpf_redirect helper function

2017-07-07 Thread John Fastabend
This adds support for a bpf_redirect helper function to the XDP infrastructure. For now this only supports redirecting to the egress path of a port. In order to support drivers handling a xdp_buff natively this patches uses a new ndo operation ndo_xdp_xmit() that takes pushes a xdp_buff to the

[RFC PATCH 02/12] net: xdp: support xdp generic on virtual devices

2017-07-07 Thread John Fastabend
XDP generic allows users to test XDP programs and/or run them with degraded performance on devices that do not yet support XDP. For testing I typically test eBPF programs using a set of veth devices. This allows testing topologies that would otherwise be difficult to setup especially in the early

[RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-07 Thread John Fastabend
This series adds two new XDP helper routines bpf_redirect() and bpf_redirect_map(). The first variant bpf_redirect() is meant to be used the same way it is currently being used by the cls_bpf classifier. An xdp packet will be redirected immediately when this is called. The other variant

[RFC PATCH 01/12] ixgbe: NULL xdp_tx rings on resource cleanup

2017-07-07 Thread John Fastabend
tx_rings and rx_rings are cleaned up on close paths in ixgbe driver however, xdp_rings are not. Set the xdp_rings to NULL here so that we can use the pointer to indicate if the XDP rings are initialized. Signed-off-by: John Fastabend Acked-by: Daniel Borkmann

Re: [iovisor-dev] [PATCH v3 net-next 02/12] bpf/verifier: rework value tracking

2017-07-07 Thread Nadav Amit
Edward Cree wrote: > On 06/07/17 22:21, Nadav Amit wrote: >> I find it a bit surprising that such huge changes that can affect security >> and robustness are performed in one patch. > In the first version of the series, this was two patches, with "feed >

Re: [Patch net] wl1251: add a missing spin_lock_init()

2017-07-07 Thread Pavel Machek
Hi! > This fixes the following kernel warning: > > [ 5668.771453] BUG: spinlock bad magic on CPU#0, kworker/u2:3/9745 ... > [ 5668.777343] [] (ieee80211_subif_start_xmit) from > [] (dev_hard_start_xmit+0x80/0x118) > ... > > by adding the missing spin_lock_init(). > > Reported-by: Pavel

[PATCH v3 3/9] sched: Replace spin_unlock_wait() with lock/unlock pair

2017-07-07 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore replaces the spin_unlock_wait() call in do_task_dead() with spin_lock() followed immediately by spin_unlock(). This should be

[PATCH v3 7/9] drivers/ata: Replace spin_unlock_wait() with lock/unlock pair

2017-07-07 Thread Paul E. McKenney
There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore eliminates the spin_unlock_wait() call and associated else-clause and hoists the then-clause's lock and unlock out of the "if"

[PATCH v3 2/9] task_work: Replace spin_unlock_wait() with lock/unlock pair

2017-07-07 Thread Paul E. McKenney
From: Oleg Nesterov There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This commit therefore replaces the spin_unlock_wait() call in task_work_run() with a spin_lock_irq() and a

Re: [PATCH net] virtio-net: fix leaking of ctx array

2017-07-07 Thread David Miller
From: Jason Wang Date: Fri, 7 Jul 2017 19:56:09 +0800 > Fixes: commit d45b897b11ea ("virtio_net: allow specifying context for rx") > Signed-off-by: Jason Wang Applied and queued up for -stable, thanks Jason.

[RFC PATCH 09/12] bpf: add bpf_redirect_map helper routine

2017-07-07 Thread John Fastabend
BPF programs can use the devmap with a bpf_redirect_map() helper routine to forward packets to netdevice in map. Signed-off-by: John Fastabend Acked-by: Daniel Borkmann --- include/linux/bpf.h |3 +++ include/uapi/linux/bpf.h |8

[RFC PATCH 08/12] bpf: add devmap, a map for storing net device references

2017-07-07 Thread John Fastabend
Device map (devmap) is a BPF map, primarily useful for networking applications, that uses a key to lookup a reference to a netdevice. The map provides a clean way for BPF programs to build virtual port to physical port maps. Additionally, it provides a scoping function for the redirect action

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-07 Thread John Fastabend
On 07/07/2017 10:34 AM, John Fastabend wrote: > This series adds two new XDP helper routines bpf_redirect() and > bpf_redirect_map(). The first variant bpf_redirect() is meant > to be used the same way it is currently being used by the cls_bpf > classifier. An xdp packet will be redirected

[RFC PATCH 10/12] xdp: Add batching support to redirect map

2017-07-07 Thread John Fastabend
For performance reasons we want to avoid updating the tail pointer in the driver tx ring as much as possible. To accomplish this we add batching support to the redirect path in XDP. This adds another ndo op "xdp_flush" that is used to inform the driver that it should bump the tail pointer on the

[RFC PATCH 11/12] net: add notifier hooks for devmap bpf map

2017-07-07 Thread John Fastabend
The BPF map devmap holds a refcnt on the net_device structure when it is in the map. We need to do this to ensure on driver unload we don't lose a dev reference. However, its not very convenient to have to manually unload the map when destroying a net device so add notifier handlers to do the

[RFC PATCH 12/12] xdp: bpf redirect with map sample program

2017-07-07 Thread John Fastabend
Signed-off-by: John Fastabend Tested-by: Andy Gospodarek Acked-by: Daniel Borkmann --- samples/bpf/Makefile|4 + samples/bpf/bpf_helpers.h |2 + samples/bpf/xdp_redirect_map_kern.c | 83

[Patch] mqueue: fix the retry logic for netlink_attachskb()

2017-07-07 Thread Cong Wang
The retry logic for netlink_attachskb() inside sys_mq_notify() is suspicious and vulnerable: 1) The sock refcnt is already released when retry is needed 2) The fd is controllable by user-space because we already release the file refcnt so we when retry and the fd has been closed during this

[PATCH v3 0/9] Remove spin_unlock_wait()

2017-07-07 Thread Paul E. McKenney
Hello! There is no agreed-upon definition of spin_unlock_wait()'s semantics, and it appears that all callers could do just as well with a lock/unlock pair. This series therefore removes spin_unlock_wait() and changes its users to instead use a lock/unlock pair. The commits are as follows, in

[PATCH V2] brcmfmac: fix possible buffer overflow in brcmf_cfg80211_mgmt_tx()

2017-07-07 Thread Arend van Spriel
The lower level nl80211 code in cfg80211 ensures that "len" is between 25 and NL80211_ATTR_FRAME (2304). We subtract DOT11_MGMT_HDR_LEN (24) from "len" so thats's max of 2280. However, the action_frame->data[] buffer is only BRCMF_FIL_ACTION_FRAME_SIZE (1800) bytes long so this memcpy() can

[PATCH] net: ethernet: mediatek: remove useless code in mtk_probe()

2017-07-07 Thread Gustavo A. R. Silva
Remove useless local variables _match_, _soc_ and the code related. Notice that const struct of_device_id of_mtk_match[] = { { .compatible = "mediatek,mt2701-eth" }, {}, }; So match->data is NULL. Suggested-by: Andrew Lunn Signed-off-by: Gustavo A. R. Silva

Re: [PATCH] net: ethernet: mediatek: add NULL check on of_match_device() return value

2017-07-07 Thread Gustavo A. R. Silva
Hi Andrew, Quoting Andrew Lunn : On Fri, Jul 07, 2017 at 02:11:35AM -0500, Gustavo A. R. Silva wrote: Check return value from call to of_match_device() in order to prevent a NULL pointer dereference. In case of NULL print error message and return -ENODEV Signed-off-by:

Re: net: Fix inconsistent teardown and release of private netdev state.

2017-07-07 Thread Cong Wang
On Thu, Jul 6, 2017 at 7:24 AM, Jason A. Donenfeld wrote: > list_add(>list, _of_things); > > ret = register_netdevice(); // if ret is < 0, then destruct above is > automatically called > > // RACE WITH LIST_ADD/LIST_DEL!! It's impossible to call list_add

Re: [Patch] mqueue: fix the retry logic for netlink_attachskb()

2017-07-07 Thread Linus Torvalds
On Fri, Jul 7, 2017 at 11:32 AM, Cong Wang wrote: > The retry logic for netlink_attachskb() inside sys_mq_notify() > is suspicious and vulnerable: > > 1) The sock refcnt is already released when retry is needed > 2) The fd is controllable by user-space because we already

Re: [CRIU] BUG: Dentry ffff9f795a08fe60{i=af565f, n=lo} still in use (1) [unmount of proc proc]

2017-07-07 Thread Andrei Vagin
On Thu, Jul 06, 2017 at 08:41:00AM -0500, Eric W. Biederman wrote: > Andrei Vagin writes: > > > I did a few experiments and found that the bug is reproduced for 6-12 > > hours on the our test server. Then I reverted two patches and the server > > is working normally for more

Re: [PATCH v6 0/3] Add new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

2017-07-07 Thread Casey Leedom
Hey Ding, Bjorn, Alexander, et.al., Sorry for the insane delay in getting to this and thanks especially to Ding for picking up the ball on this feature. I got side=-tracked into a multi-week rewrite of our Firmware/Host Driver Port Capabilities code, then to the recent Ethernet Plug-Fest at

Re: [PATCH v6 0/3] Add new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

2017-07-07 Thread Casey Leedom
By the way, it ~seems~ like the patch set confuses the idea of the PCIe Capability Device Control[Relaxed Ordering Enable] with the device's ability to handle incoming TLPs with the Relaxed Ordering Attribute set. These are completely different things. The PCIe Capability Device

Re: [iovisor-dev] [PATCH v3 net-next 02/12] bpf/verifier: rework value tracking

2017-07-07 Thread Nadav Amit
Nadav Amit wrote: > Edward Cree wrote: > >> On 06/07/17 22:21, Nadav Amit wrote: >>> I find it a bit surprising that such huge changes that can affect security >>> and robustness are performed in one patch. >> In the first version of the series, this

Re: [PATCH v6 0/3] Add new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

2017-07-07 Thread Alexander Duyck
On Fri, Jul 7, 2017 at 5:30 PM, Casey Leedom wrote: > By the way, it ~seems~ like the patch set confuses the idea of the PCIe > Capability Device Control[Relaxed Ordering Enable] with the device's ability > to handle incoming TLPs with the Relaxed Ordering Attribute set.

meson-gxbb-p200 4.12.0 network TCP transfer stalls

2017-07-07 Thread Marc Duponcheel
Hi all Similar to 'crow' ARM GLX Khadas VIM Pro - Ethernet detected as only 10Mbps and stalled after some traffic I also have the situation where copying large file over LAN stalls. 3.14.29 performance is good 4.12.0 performance not output of 'mii-tool -vvv eth0' differs (e.g. flow-control)

[PATCH iproute2 net-next] iproute: extend route get for mpls routes

2017-07-07 Thread Roopa Prabhu
From: Roopa Prabhu This patch extends route get to support mpls specific route attributes like RTA_NEWDST. Input: RTA_DST - input label RTA_NEWDST - labels in packet for multipath selection By default the getroute handler returns matched nexthop label, via and oif

Re: [PATCH v6 0/3] Add new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

2017-07-07 Thread Casey Leedom
Okay, thanks for the note Alexander. I'll have to look more closely at the patch on Monday and try it out on one of the targeted systems to verify the semantics you describe. However, that said, there is no way to tell a priori where a device will send TLPs. To simply assume that all TLPs

[PATCH] cisco: enic: Fic an error handling path in 'vnic_dev_init_devcmd2()'

2017-07-07 Thread Christophe JAILLET
if 'ioread32()' returns 0xFFF, we have to go through the error handling path as done everywhere else in this function. Move the 'err_free_wq' label to better match its name and its location and add a new label 'err_disable_wq'. Update the code accordingly. Fixes: 373fb0873d43 ("enic: add

Re: [PATCH v6 0/3] Add new PCI_DEV_FLAGS_NO_RELAXED_ORDERING flag

2017-07-07 Thread Alexander Duyck
On Fri, Jul 7, 2017 at 7:04 PM, Casey Leedom wrote: > Okay, thanks for the note Alexander. I'll have to look more closely at > the patch on Monday and try it out on one of the targeted systems to verify > the semantics you describe. > > However, that said, there is no way

Re: [PATCH V2] brcmfmac: fix possible buffer overflow in brcmf_cfg80211_mgmt_tx()

2017-07-07 Thread Linus Torvalds
On Fri, Jul 7, 2017 at 1:09 PM, Arend van Spriel wrote: > Now I signed off on the patch although formally I suppose Linus should > sign it off. You can certainly consider it Signed-off-by: Linus Torvalds but I really don't need

[PATCH iproute2 net-next] bridge: this patch adds json support for bridge mdb show

2017-07-07 Thread Roopa Prabhu
From: Nikhil Gajendrakumar This patch adds json output to bridge mdb show Normal Output: $ bridge -d -s mdb show dev br0 port swp3 grp 239.0.0.1 temp vid 128 172.26 dev br0 port swp3 grp 239.0.0.1 temp vid 64 172.26 dev br0 port swp2 grp 239.0.0.2 temp vid 1024

[PATCH] mac80211: Fix null pointer dereference with iTXQ support

2017-07-07 Thread Chunho Lee
This change adds null pointer check before dereferencing pointer dev on netif_tx_start_all_queues() when an interface is added. With iTXQ support, netif_tx_start_all_queues() is always called while an interface is added. however, the netdev queues are not associated and dev is null when the

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-07 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Thu, Jul 06, 2017 at 09:20:24AM -0700, Paul E. McKenney wrote: > > On Thu, Jul 06, 2017 at 06:05:55PM +0200, Peter Zijlstra wrote: > > > On Thu, Jul 06, 2017 at 02:12:24PM +, David Laight wrote: > > > > From: Paul E. McKenney > > > > [ . .

[PATCH v2 RFC 02/13] macb: Remove bogus reference to NETIF_F_UFO.

2017-07-07 Thread David Miller
This driver doesn't actually support UFO explicitly yet it advertises this in netdev->features. Signed-off-by: David S. Miller --- drivers/net/ethernet/cadence/macb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 RFC 07/13] virtio_net: Remove references to NETIF_F_UFO.

2017-07-07 Thread David Miller
It is going away. Signed-off-by: David S. Miller --- drivers/net/virtio_net.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 2e69bcd..eb33e2e 100644 --- a/drivers/net/virtio_net.c +++

[PATCH v2 RFC 08/13] net: Remove references to NETIF_F_UFO in netdev_fix_features().

2017-07-07 Thread David Miller
It is going away. Signed-off-by: David S. Miller --- net/core/dev.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 7098fba..8495ded 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -7234,24 +7234,6 @@ static

[PATCH v2 RFC 0/13] Remove UDP Fragmentation Offload support

2017-07-07 Thread David Miller
This is an RFC patch series, based upon some discussions with various developers, that removes UFO offloading. Very few devices support this operation, it's usefullness is quesitonable at best, and it adds a non-trivial amount of complexity to our data paths. v2: Delete more code thanks to

[PATCH v2 RFC 03/13] ipvlan: Stop advertising NETIF_F_UFO support.

2017-07-07 Thread David Miller
It is going away. Signed-off-by: David S. Miller --- drivers/net/ipvlan/ipvlan_main.c | 2 +- drivers/net/ipvlan/ipvtap.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c index

[PATCH v2 RFC 05/13] tun/tap: Remove references to NETIF_F_UFO.

2017-07-07 Thread David Miller
It is going away. Signed-off-by: David S. Miller --- drivers/net/tap.c | 7 ++- drivers/net/tun.c | 7 +-- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/net/tap.c b/drivers/net/tap.c index 9af3239..d4579a3 100644 --- a/drivers/net/tap.c

[PATCH v2 RFC 11/13] net: Remove all references to SKB_GSO_UDP.

2017-07-07 Thread David Miller
Such packets are no longer possible. Signed-off-by: David S. Miller --- include/linux/virtio_net.h | 5 - net/core/filter.c | 8 net/ipv4/af_inet.c | 12 ++-- net/ipv4/gre_offload.c | 14 +- net/ipv4/udp_offload.c

[PATCH v2 RFC 13/13] net: Kill NETIF_F_UFO and SKB_GSO_UDP.

2017-07-07 Thread David Miller
No longer used. Signed-off-by: David S. Miller --- include/linux/netdev_features.h | 4 +--- include/linux/netdevice.h | 1 - include/linux/skbuff.h | 31 +++ 3 files changed, 16 insertions(+), 20 deletions(-) diff --git

[PATCH v2 RFC 09/13] net: Remove references to NETIF_F_UFO from ethtool.

2017-07-07 Thread David Miller
It is going away. Signed-off-by: David S. Miller --- net/core/ethtool.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/net/core/ethtool.c b/net/core/ethtool.c index 674b6c9..78408ab 100644 --- a/net/core/ethtool.c +++ b/net/core/ethtool.c @@ -76,7 +76,6 @@

[PATCH v2 RFC 12/13] inet: Remove software UFO fragmenting code.

2017-07-07 Thread David Miller
Rename udp{4,6}_ufo_fragment() to udp{4,6}_tunnel_segment() and only handle tunnel segmentation. Signed-off-by: David S. Miller --- net/ipv4/udp_offload.c | 58 ++-- net/ipv6/udp_offload.c | 100 ++--- 2

Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-07 Thread Richard Leitner
On 07/07/2017 09:03 AM, Andy Duan wrote: From: Richard Leitner Sent: Friday, July 07, 2017 1:51 PM Since it is common issue so long as using the PHY, can you move it into smsc phy driver like in .smsc_phy_reset() function ? And get the reset pin from phy dts

Re: [PATCH net] nfp: flower: add missing clean up call to avoid memory leaks

2017-07-07 Thread David Miller
From: Jakub Kicinski Date: Thu, 6 Jul 2017 17:29:05 -0700 > nfp_flower_metadata_cleanup() is defined but never invoked, > not calling it will cause us to leak mask and statistics > queue memory on the host. > > Fixes: 43f84b72c50d ("nfp: add metadata to each flow

Re: [Intel-wired-lan] [PATCH 1/2] i40e/i40evf: rename vf_offload_flags to vf_cap_flags in struct virtchnl_vf_resource

2017-07-07 Thread Greg Rose
On Thu, Jul 6, 2017 at 4:26 PM, Wyborny, Carolyn wrote: >> -Original Message- >> From: Greg Rose [mailto:gvrose8...@gmail.com] >> Sent: Thursday, July 06, 2017 7:25 AM >> To: Wyborny, Carolyn >> Cc: Stefan Assmann

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-07 Thread Peter Zijlstra
On Fri, Jul 07, 2017 at 10:31:28AM +0200, Ingo Molnar wrote: > Here's a quick list of all the use cases: > > net/netfilter/nf_conntrack_core.c: > >- This is I believe the 'original', historic spin_unlock_wait() usecase > that > still exists in the kernel. spin_unlock_wait() is only

Re: [PATCH 2/2 net-next] net: stmmac: Improve documentation on AVB parameters

2017-07-07 Thread Joao Pinto
Hi Peppe, Às 8:09 AM de 7/7/2017, Giuseppe CAVALLARO escreveu: > Hi Joao > > On 7/5/2017 12:34 PM, Joao Pinto wrote: >> Hi Peppe, >> >> Às 8:10 AM de 6/9/2017, Giuseppe CAVALLARO escreveu: >>> Hi Joao >>> >>> On 6/8/2017 8:02 PM, Joao Pinto wrote: This patch fixes the description of the DT

[PATCH v2 RFC 01/13] s2io: Remove UFO support.

2017-07-07 Thread David Miller
Signed-off-by: David S. Miller --- drivers/net/ethernet/neterion/s2io.c | 45 1 file changed, 45 deletions(-) diff --git a/drivers/net/ethernet/neterion/s2io.c b/drivers/net/ethernet/neterion/s2io.c index fd2ec36..462eda9 100644 ---

[PATCH v2 RFC 06/13] dummy: Remove references to NETIF_F_UFO.

2017-07-07 Thread David Miller
It is going away. Signed-off-by: David S. Miller --- drivers/net/dummy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dummy.c b/drivers/net/dummy.c index d0c165d..d0a1f9c 100644 --- a/drivers/net/dummy.c +++ b/drivers/net/dummy.c @@

[PATCH v2 RFC 04/13] macvlan/macvtap: Remove NETIF_F_UFO advertisement.

2017-07-07 Thread David Miller
It is going away. Signed-off-by: David S. Miller --- drivers/net/macvlan.c | 2 +- drivers/net/macvtap.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 0f581ee..ca35c6b 100644 ---

[PATCH v2 RFC 10/13] inet: Stop generating UFO packets.

2017-07-07 Thread David Miller
Signed-off-by: David S. Miller --- net/ipv4/ip_output.c | 76 --- net/ipv6/ip6_output.c | 76 --- 2 files changed, 152 deletions(-) diff --git a/net/ipv4/ip_output.c

Re: [PATCH RFC 11/12] net: Remove all references to SKB_GSO_UDP.

2017-07-07 Thread David Miller
From: Willem de Bruijn Date: Thu, 6 Jul 2017 13:57:20 -0400 > On Thu, Jul 6, 2017 at 10:43 AM, David Miller wrote: >> From: Willem de Bruijn >> Date: Wed, 5 Jul 2017 12:27:11 -0400 >> > ---

Re: ath10k: ret used but uninitialized

2017-07-07 Thread Kalle Valo
Erik Stromdahl writes: >> With gcc 4.1.2: >> >> drivers/net/wireless/ath/ath10k/sdio.c: In function >> ‘ath10k_sdio_mbox_rxmsg_pending_handler’: >> drivers/net/wireless/ath/ath10k/sdio.c:676: warning: ‘ret’ may be used >> uninitialized in this function >> >>> + >>> +

Re: [PATCH] arcnet: com20020-pci: Fix an error handling path in 'com20020pci_probe()'

2017-07-07 Thread David Miller
From: Christophe JAILLET Date: Fri, 7 Jul 2017 06:56:16 +0200 > If this memory allocation fails, we should go through the error handling > path as done everywhere else in this function before returning. > > Signed-off-by: Christophe JAILLET

Re: [PATCH v3 net-next 00/12] bpf: rewrite value tracking in verifier

2017-07-07 Thread Daniel Borkmann
On 07/06/2017 08:27 PM, Edward Cree wrote: On 04/07/17 23:28, Daniel Borkmann wrote: Have you tried with cilium's BPF code? The kernel selftests are quite small, so not really pushing processed insns too far. I can send you a BPF obj file if that's easier for testing. Results from the next

pull-request: mac80211 2017-07-07

2017-07-07 Thread Johannes Berg
Hi Dave, Just got a set of fixes in from Jouni/QCA, all netlink validation fixes. I assume they ran some kind of checker, but I don't know what kind :) Please pull and let me know if there's any problem. Thanks, johannes The following changes since commit

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-07 Thread Ingo Molnar
* Ingo Molnar wrote: > > * Peter Zijlstra wrote: > > > > It might even be that this is the defined semantics of spin_unlock_wait(). > > > > As is, spin_unlock_wait() is somewhat ill defined. IIRC it grew from an > > optimization by Oleg and

Salutation from London

2017-07-07 Thread Robert Kim
Good Day, Please Whoever this email meets, i need your co-operation and to introduce myself I am Robert Kim and i work with an intermediary bank. i discovered from my bank data assessment as the bank auditor general that a deceased customer left in one of his accounts GBP15,000,000.00 and no

[PATCH net] doc: SKB_GSO_[IPIP|SIT] have been replaced

2017-07-07 Thread Nicolas Dichtel
Those enum values don't exist anymore. Fixes: 7e13318daa4a ("net: define gso types for IPx over IPv4 and IPv6") CC: Tom Herbert Signed-off-by: Nicolas Dichtel --- Documentation/networking/segmentation-offloads.txt | 2 +- 1 file changed, 1

Re: [PATCH v3 net-next 00/12] bpf: rewrite value tracking in verifier

2017-07-07 Thread Edward Cree
On 07/07/17 10:14, Daniel Borkmann wrote: > But this means the bpf_lxc_* cases increase quite significantly, > arguably one of them is pretty close already, but the other one not > so much, meaning while 142k would shoot over the 128k target quite a > bit, the 95k is quite close to the point that

Re: [PATCH v2 RFC 0/13] Remove UDP Fragmentation Offload support

2017-07-07 Thread Michal Kubecek
On Fri, Jul 07, 2017 at 10:43:26AM +0100, David Miller wrote: > > This is an RFC patch series, based upon some discussions with > various developers, that removes UFO offloading. > > Very few devices support this operation, it's usefullness is > quesitonable at best, and it adds a non-trivial

[PATCH iproute2] tc: fix typo in manpage

2017-07-07 Thread Matteo Croce
Fix a typo in the 'tc' manpage and reword some sentences. Signed-off-by: Matteo Croce --- man/man8/tc-csum.8 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/man/man8/tc-csum.8 b/man/man8/tc-csum.8 index 718301d..409ab71 100644 --- a/man/man8/tc-csum.8

Probable Spam: Ativação de Zimbra

2017-07-07 Thread ZIMBRA-ADMIN
A ativação da conta precisa ser feita, você nunca ativou sua conta para que você possa perder o acesso à sua conta de e-mail se não for ativada. Siga as instruções abaixo para ativar sua conta agora. Siga aqui para ativar: http://free.allforms.mailjol.net/u/03756f3e.php Administrador de Zimbra

Re: [PATCH v3 net-next 00/12] bpf: rewrite value tracking in verifier

2017-07-07 Thread Daniel Borkmann
On 07/07/2017 02:50 PM, Edward Cree wrote: On 07/07/17 10:14, Daniel Borkmann wrote: But this means the bpf_lxc_* cases increase quite significantly, arguably one of them is pretty close already, but the other one not so much, meaning while 142k would shoot over the 128k target quite a bit, the

RE: [PATCH v2 RFC 0/13] Remove UDP Fragmentation Offload support

2017-07-07 Thread David Laight
From: Michal Kubecek > Sent: 07 July 2017 13:46 > On Fri, Jul 07, 2017 at 10:43:26AM +0100, David Miller wrote: > > > > This is an RFC patch series, based upon some discussions with > > various developers, that removes UFO offloading. > > > > Very few devices support this operation, it's

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-07 Thread Paul E. McKenney
On Fri, Jul 07, 2017 at 10:31:28AM +0200, Ingo Molnar wrote: [ . . . ] > In fact I'd argue that any future high performance spin_unlock_wait() user is > probably better off open coding the unlock-wait poll loop (and possibly > thinking > hard about eliminating it altogether). If such patterns

Re: [PATCH] net: ethernet: mediatek: add NULL check on of_match_device() return value

2017-07-07 Thread Matthias Brugger
On 07/07/2017 09:11 AM, Gustavo A. R. Silva wrote: Check return value from call to of_match_device() in order to prevent a NULL pointer dereference. In case of NULL print error message and return -ENODEV Signed-off-by: Gustavo A. R. Silva --- Reviewed-by: Matthias

Re: [PATCH] net: ethernet: mediatek: add NULL check on of_match_device() return value

2017-07-07 Thread Andrew Lunn
On Fri, Jul 07, 2017 at 02:11:35AM -0500, Gustavo A. R. Silva wrote: > Check return value from call to of_match_device() > in order to prevent a NULL pointer dereference. > > In case of NULL print error message and return -ENODEV > > Signed-off-by: Gustavo A. R. Silva >

Re: pull-request: mac80211 2017-07-07

2017-07-07 Thread David Miller
From: Johannes Berg Date: Fri, 7 Jul 2017 11:29:01 +0200 > Just got a set of fixes in from Jouni/QCA, all netlink validation > fixes. I assume they ran some kind of checker, but I don't know > what kind :) > > Please pull and let me know if there's any problem.

[PATCH net] virtio-net: fix leaking of ctx array

2017-07-07 Thread Jason Wang
Fixes: commit d45b897b11ea ("virtio_net: allow specifying context for rx") Signed-off-by: Jason Wang --- drivers/net/virtio_net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 2e69bcd..99a26a9 100644 ---

Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-07 Thread Richard Leitner
Hi Andy, thanks for the clarifications! On 07/07/2017 01:08 PM, Andy Duan wrote: 3. Who should then trigger the "hard reset" of the PHY? phy_init_hw? The FEC? The point is that the LAN8710 is currently not always working correctly, therefore this small change was proposed. Should we really

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-07 Thread Peter Zijlstra
On Fri, Jul 07, 2017 at 12:33:49PM +0200, Ingo Molnar wrote: > [1997/04] v2.1.36: > > the spin_unlock_wait() primitive gets introduced as part of release() Whee, that goes _way_ further back than I thought it did :-) > [2017/07] v4.12: > > wait_task_inactive() is still alive

Re: [PATCH net] ip[6]: don't register inet[6]dev when dev is down

2017-07-07 Thread Nicolas Dichtel
Le 06/07/2017 à 20:16, Cong Wang a écrit : > On Thu, Jul 6, 2017 at 5:08 AM, Nicolas Dichtel > wrote: >> Le 06/07/2017 à 00:43, Cong Wang a écrit : >>> On Wed, Jul 5, 2017 at 8:57 AM, Nicolas Dichtel >>> wrote: When a device changes from

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-07 Thread Ingo Molnar
* Peter Zijlstra wrote: > You missed the one in do_exit(), which I thought was the original one. Indeed, it's raw_spin_unlock_wait() which my git grep pattern missed. But it's not the original spin_unlock_wait(): the pi_lock and priority inheritance is a newfangled

RE: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-07 Thread Andy Duan
From: Richard Leitner Sent: Friday, July 07, 2017 5:53 PM >To: Andy Duan ; robh...@kernel.org; >mark.rutl...@arm.com >Cc: netdev@vger.kernel.org; devicet...@vger.kernel.org; linux- >ker...@vger.kernel.org; d...@g0hl1n.net; Andrew Lunn

Re: [iovisor-dev] [PATCH v3 net-next 02/12] bpf/verifier: rework value tracking

2017-07-07 Thread Edward Cree
On 06/07/17 22:21, Nadav Amit wrote: > I find it a bit surprising that such huge changes that can affect security > and robustness are performed in one patch. In the first version of the series, this was two patches, with "feed pointer-to-unknown-scalar casts into scalar ALU path" split out from

Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-07 Thread Andrew Lunn
> Ok. I'm fine with moving the phy-reset-gpios binding into the PHY. > But one question still remains: Who should then trigger the "hard > reset" of the PHY? Hi Richard I think i see a few whys to do this, but first i need to check something. Is the clock which is causing a problem this one:

Re: [PATCH v2] net: axienet: add support for standard phy-mode binding

2017-07-07 Thread Andrew Lunn
On Fri, Jul 07, 2017 at 08:50:15AM +0200, Alvaro Gamez Machado wrote: > Keep supporting proprietary "xlnx,phy-type" attribute and add support for > MII connectivity to the PHY. > > Signed-off-by: Alvaro Gamez Machado > --- > > Changes since v1: > > * Renamed

[PATCH] brcmfmac: added LED triggers for transmit/receive

2017-07-07 Thread Russell Joyce
Add three basic LED triggers to brcmfmac, based on those in mac80211: one for transmit, one for receive, and one for combined transmit/receive. Signed-off-by: Russell Joyce --- drivers/net/wireless/broadcom/brcm80211/Kconfig| 12 +++

  1   2   >