Re: [PATCH v5 net-next] net: systemport: Support 64bit statistics

2017-07-30 Thread Florian Fainelli
On July 30, 2017 5:01:15 PM PDT, "Jianming.qiao" wrote: >When using Broadcom Systemport device in 32bit Platform, ifconfig can >only report up to 4G tx,rx status, which will be wrapped to 0 when the >number of incoming or outgoing packets exceeds 4G, only taking >around 2

Re: [PATCH net] ipv6: set fc_protocol with 0 when rtm_protocol is RTPROT_REDIRECT

2017-07-30 Thread Xin Long
On Mon, Jul 31, 2017 at 2:35 PM, David Ahern wrote: > On 7/30/17 6:51 AM, Xin Long wrote: >> diff --git a/net/ipv6/route.c b/net/ipv6/route.c >> index 4d30c96..187580f 100644 >> --- a/net/ipv6/route.c >> +++ b/net/ipv6/route.c >> @@ -2912,9 +2912,11 @@ static int

Re: [PATCH net] ipv6: set fc_protocol with 0 when rtm_protocol is RTPROT_REDIRECT

2017-07-30 Thread David Ahern
On 7/30/17 6:51 AM, Xin Long wrote: > diff --git a/net/ipv6/route.c b/net/ipv6/route.c > index 4d30c96..187580f 100644 > --- a/net/ipv6/route.c > +++ b/net/ipv6/route.c > @@ -2912,9 +2912,11 @@ static int rtm_to_fib6_config(struct sk_buff *skb, > struct nlmsghdr *nlh, > cfg->fc_dst_len =

Re: [PATCH net-next v12 0/4] net sched actions: improve dump performance

2017-07-30 Thread David Miller
Series applied, thanks.

Re: [PATCH net-next] net: fec: Allow reception of frames bigger than 1522 bytes

2017-07-30 Thread Andrew Lunn
On Sun, Jul 30, 2017 at 07:26:29PM -0700, David Miller wrote: > From: Andrew Lunn > Date: Sun, 30 Jul 2017 19:36:05 +0200 > > > The FEC Receive Control Register has a 14 bit field indicating the > > longest frame that my be received. It is being set to 1522. Frames > > longer

Re: [PATCH net-next v12 1/4] net netlink: Add new type NLA_BITFIELD32

2017-07-30 Thread David Ahern
On 7/30/17 1:59 PM, Jamal Hadi Salim wrote: > On D. Ahern: I dont think we are disagreeing anymore on the need to > generalize the check. He is saying it should be a helper and I already > had the validation data; either works. I dont see the gapping need > to remove the validation data. I never

Re: [PATCH net-next] net: fec: Allow reception of frames bigger than 1522 bytes

2017-07-30 Thread David Miller
From: Andrew Lunn Date: Sun, 30 Jul 2017 19:36:05 +0200 > The FEC Receive Control Register has a 14 bit field indicating the > longest frame that my be received. It is being set to 1522. Frames > longer than this are discarded, but counted as being in error. > > When using DSA,

Re: [PATCH v2 net-next 0/4] net: dsa: lan9303: Fix MDIO issues.

2017-07-30 Thread David Miller
From: Egil Hjelmeland Date: Sun, 30 Jul 2017 19:58:52 +0200 > This series fix the MDIO interface for the lan9303 DSA driver. > Bugs found after testing on actual HW. > > This series is extracted from the first patch of my first large > series. Significant changes from

RE: [PATCH net-next] net: fec: Issue error for missing but expected PHY

2017-07-30 Thread Andy Duan
From: Andrew Lunn Sent: Monday, July 31, 2017 4:11 AM >If the PHY is missing but expected, e.g. because of a typ0 in the dt file, it >is not >possible to open the interface. ip link returns: > >RTNETLINK answers: No such device > >It is not very obvious what the problem is. Add a

RE: [PATCH net-next] net: fec: Allow reception of frames bigger than 1522 bytes

2017-07-30 Thread Andy Duan
From: Andrew Lunn Sent: Monday, July 31, 2017 1:36 AM >The FEC Receive Control Register has a 14 bit field indicating the longest >frame >that my be received. It is being set to 1522. Frames longer than this are My -> may >discarded, but counted as being in error. > >When using

[PATCH] drivers/net/wan/z85230.c: Use designated initializers

2017-07-30 Thread Kees Cook
In preparation for the randstruct gcc plugin performing randomization of structures that are entirely function pointers, use designated initializers so the compiler doesn't get angry. Reported-by: kbuild test robot Signed-off-by: Kees Cook --- This

[PATCH v5 net-next] net: systemport: Support 64bit statistics

2017-07-30 Thread Jianming.qiao
When using Broadcom Systemport device in 32bit Platform, ifconfig can only report up to 4G tx,rx status, which will be wrapped to 0 when the number of incoming or outgoing packets exceeds 4G, only taking around 2 hours in busy network environment (such as streaming). Therefore, it makes hard for

I am Mrs Kivi Kangas, citizen of Finland and 68 years old.

2017-07-30 Thread Office File
Dear Beloved One. I am writing this mail with tears and sorrow seeking your assistance due to my medical situation here in London. I am Mrs Kivi Kangas, citizen of Finland and 68 years old. I was an Orphan, adopted by my late father, Engr. Grain Kangas, Chairman/CEO of Grainkangas Oil and Gas

Re: Performance regression with virtio_net

2017-07-30 Thread Euan Kemp
I've also observed this performance regression. The minimal fix for me is removing the two > if (unlikely(len > (unsigned long)ctx)) checks added in 680557c. After digging a little more, the reason that check can fail appears to be that add_recvbuf_mergeable sometimes includes a hole at the end,

[PATCH] hyperv: netvsc: Neaten netvsc_send_pkt by using a temporary

2017-07-30 Thread Joe Perches
Repeated dereference of nvmsg.msg.v1_msg.send_rndis_pkt can be shortened by using a temporary. Do so. No change in object code. Signed-off-by: Joe Perches --- drivers/net/hyperv/netvsc.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff

Re: Kernel TLS in 4.13-rc1

2017-07-30 Thread David Oberhollenzer
On 07/24/2017 11:10 PM, Dave Watson wrote: > On 07/23/17 09:39 PM, David Oberhollenzer wrote: >> After fixing the benchmark/test tool that the patch description >> linked to (https://github.com/Mellanox/tls-af_ktls_tool) to make >> sure that the server and client actually *agree* on AES-128-GCM,

[PATCH net-next 5/7] net: phy: marvell: Refactor m88e1121 RGMII delay configuration

2017-07-30 Thread Andrew Lunn
Turns out that MII_M1116R_CONTROL_REG_MAC is the same as MII_88E1121_PHY_MSCR_REG. Refactor the code to set the RGMII delays into a shared helper. Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 62 +-- 1 file changed, 33

[PATCH net-next 7/7] net: phy: marvell: Refactor setting downshift into a helper

2017-07-30 Thread Andrew Lunn
The 1116r has code to set downshift. Refactor this into a helper, so in future other marvell PHYs can use it. Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 24 +++- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git

[PATCH net-next 6/7] net: phy: marvell: Use the set_polarity helper

2017-07-30 Thread Andrew Lunn
Some of the init functions unilaterally enable set auto cross over without using the helper. Make use of the helper, and respect the phydev MDI configuration. Clean up the #define used while setting polarity, and the other functions of the bits in the register. Signed-off-by: Andrew Lunn

[PATCH net-next 4/7] net: phy: marvell: Consolidate setting the phy-mode

2017-07-30 Thread Andrew Lunn
The same code is repeated a few times. Refactor into a helped. Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 88 +-- 1 file changed, 40 insertions(+), 48 deletions(-) diff --git a/drivers/net/phy/marvell.c

[PATCH net-next 0/7] More Marvell PHY refactoring and cleanup

2017-07-30 Thread Andrew Lunn
Consolidate more duplicated code into helpers, make use of core helpers, move code into a helper for later adding functionality to add marvell PHYs, etc. Andrew Lunn (7): net: phy: marvell: tabification net: phy: marvell: Use core genphy_soft_reset() net: phy: marvell: consolidate RGMII

[PATCH net-next 2/7] net: phy: marvell: Use core genphy_soft_reset()

2017-07-30 Thread Andrew Lunn
Rather than using an open coded equivalent, use the core genphy_soft_reset() function. Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 47 --- 1 file changed, 12 insertions(+), 35 deletions(-) diff --git

[PATCH net-next 3/7] net: phy: marvell: consolidate RGMII delay code

2017-07-30 Thread Andrew Lunn
The same code is repeated for different PHY versions. Put it into a help and call when needed. Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 54 +++ 1 file changed, 22 insertions(+), 32 deletions(-) diff --git

[PATCH net-next 1/7] net: phy: marvell: tabification

2017-07-30 Thread Andrew Lunn
Convert spaces to tabs where appropriate, and fix up some otherwise odd indentation. Signed-off-by: Andrew Lunn --- drivers/net/phy/marvell.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/net/phy/marvell.c

Re: [PATCH V2 net-next 0/2] liquidio: Add support for managing liquidio adapter

2017-07-30 Thread Simon Horman
On Fri, Jul 28, 2017 at 11:17:07PM -0700, Felix Manlunas wrote: > From: Veerasenareddy Burru > > The LiquidIO adapter has processor cores that can run Linux. This patch > set adds support to create a virtual Ethernet interface on host to > communicate with

Re: [PATCH v2] ravb: add wake-on-lan support via magic packet

2017-07-30 Thread Niklas Söderlund
Hi Andrew, On 2017-07-30 22:07:31 +0200, Andrew Lunn wrote: > On Sun, Jul 30, 2017 at 09:51:54PM +0200, Niklas Söderlund wrote: > > Hi Andrew, > > > > On 2017-07-30 19:07:38 +0200, Andrew Lunn wrote: > > > Hi Niklas > > > > > > > @@ -2041,6 +2073,11 @@ static int ravb_probe(struct

Re: [patch net-next 09/20] net: sched: convert actions array into rcu list

2017-07-30 Thread Jamal Hadi Salim
On 17-07-28 10:40 AM, Jiri Pirko wrote: From: Jiri Pirko Currently the actions are stored in array with array size. To traverse this array in fastpath, tcf_tree_lock is taken to protect it. Convert the array into a singly linked list, similar to the filter chains style and

[PATCH net-next] net: fec: Issue error for missing but expected PHY

2017-07-30 Thread Andrew Lunn
If the PHY is missing but expected, e.g. because of a typ0 in the dt file, it is not possible to open the interface. ip link returns: RTNETLINK answers: No such device It is not very obvious what the problem is. Add a netdev_err() in this case to make it easier to debug the issue. [

Re: [PATCH v2] ravb: add wake-on-lan support via magic packet

2017-07-30 Thread Andrew Lunn
On Sun, Jul 30, 2017 at 09:51:54PM +0200, Niklas Söderlund wrote: > Hi Andrew, > > On 2017-07-30 19:07:38 +0200, Andrew Lunn wrote: > > Hi Niklas > > > > > @@ -2041,6 +2073,11 @@ static int ravb_probe(struct platform_device *pdev) > > > > > > priv->chip_id = chip_id; > > > > > > + /* Get

[PATCH 1/1 v2] netfilter: constify nf_conntrack_l3/4proto parameters

2017-07-30 Thread Julia Lawall
When a nf_conntrack_l3/4proto parameter is not on the left hand side of an assignment, its address is not taken, and it is not passed to a function that may modify its fields, then it can be declared as const. This change is useful from a documentation point of view, and can possibly facilitate

[PATCH 0/1 v2] constify nf_conntrack_l3/4proto parameters

2017-07-30 Thread Julia Lawall
When a nf_conntrack_l3/4proto parameter is not on the left hand side of an assignment, its address is not taken, and it is not passed to a function that may modify its fields, then it can be declared as const. This change is useful from a documentation point of view, and can possibly facilitate

Re: [PATCH net-next v12 1/4] net netlink: Add new type NLA_BITFIELD32

2017-07-30 Thread Jamal Hadi Salim
Jiri, This is getting exhausting, seriously. I posted the code you are commenting one two days ago so i dont have to repost. On D. Ahern: I dont think we are disagreeing anymore on the need to generalize the check. He is saying it should be a helper and I already had the validation data; either

Re: [PATCH v2] ravb: add wake-on-lan support via magic packet

2017-07-30 Thread Niklas Söderlund
Hi Andrew, On 2017-07-30 19:07:38 +0200, Andrew Lunn wrote: > Hi Niklas > > > @@ -2041,6 +2073,11 @@ static int ravb_probe(struct platform_device *pdev) > > > > priv->chip_id = chip_id; > > > > + /* Get clock, if not found that's OK but Wake-On-Lan is unavailable */ > > + priv->clk =

Re: [patch net-next 04/20] net: sched: use tcf_exts_has_actions in tcf_exts_exec

2017-07-30 Thread Jamal Hadi Salim
I am probably missing something. All those changes to just replace "if (exts->nr_actions)" with "if (tcf_exts_has_actions(exts))" ? cheers, jamal On 17-07-28 10:40 AM, Jiri Pirko wrote: From: Jiri Pirko Use the tcf_exts_has_actions helper instead or directly testing

Re: [patch net-next 03/20] net: sched: change names of action number helpers to be aligned with the rest

2017-07-30 Thread Jamal Hadi Salim
On 17-07-28 10:40 AM, Jiri Pirko wrote: From: Jiri Pirko The rest of the helpers are named tcf_exts_*, so change the name of the action number helpers to be aligned. While at it, change to inline functions. Signed-off-by: Jiri Pirko Looks reasonable.

Re: [PATCH net-next v12 4/4] net sched actions: add time filter for action dumping

2017-07-30 Thread Jiri Pirko
Sun, Jul 30, 2017 at 07:24:52PM CEST, j...@mojatatu.com wrote: >From: Jamal Hadi Salim > >This patch adds support for filtering based on time since last used. >When we are dumping a large number of actions it is useful to >have the option of filtering based on when the action

Re: [PATCH net-next v12 3/4] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-07-30 Thread Jiri Pirko
Sun, Jul 30, 2017 at 07:24:51PM CEST, j...@mojatatu.com wrote: >From: Jamal Hadi Salim > >When you dump hundreds of thousands of actions, getting only 32 per >dump batch even when the socket buffer and memory allocations allow >is inefficient. > >With this change, the user will

Re: [patch net-next 01/20] net: sched: sch_atm: use Qdisc_class_common structure

2017-07-30 Thread Jamal Hadi Salim
On 17-07-28 10:40 AM, Jiri Pirko wrote: From: Jiri Pirko Even if it is only for classid now, use this common struct a be aligned with the rest of the classful qdiscs. Signed-off-by: Jiri Pirko Looks good to me. Acked-by: Jamal Hadi Salim

Re: [PATCH net-next v12 2/4] net sched actions: Use proper root attribute table for actions

2017-07-30 Thread Jiri Pirko
Sun, Jul 30, 2017 at 07:24:50PM CEST, j...@mojatatu.com wrote: >From: Jamal Hadi Salim > >Bug fix for an issue which has been around for about a decade. >We got away with it because the enumeration was larger than needed. > >Fixes: 7ba699c604ab ("[NET_SCHED]: Convert actions

Re: [PATCH net-next v12 1/4] net netlink: Add new type NLA_BITFIELD32

2017-07-30 Thread Jiri Pirko
Sun, Jul 30, 2017 at 07:24:49PM CEST, j...@mojatatu.com wrote: >From: Jamal Hadi Salim > >Generic bitflags attribute content sent to the kernel by user. >With this netlink attr type the user can either set or unset a >flag in the kernel. > >The value is a bitmap that defines

Fw: [Bug 196533] New: kernel stack infoleaks

2017-07-30 Thread Stephen Hemminger
Begin forwarded message: Date: Sun, 30 Jul 2017 05:13:08 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 196533] New: kernel stack infoleaks https://bugzilla.kernel.org/show_bug.cgi?id=196533 Bug ID: 196533 Summary: kernel

[PATCH v2 net-next 4/4] net: dsa: lan9303: MDIO access phy registers directly

2017-07-30 Thread Egil Hjelmeland
Indirect access (PMI) to phy register only work in I2C mode. In MDIO mode phy registers must be accessed directly. Introduced struct lan9303_phy_ops to handle the two modes. Signed-off-by: Egil Hjelmeland Reviewed-by: Andrew Lunn Reviewed-by: Vivien

[PATCH v2 net-next 3/4] net: dsa: lan9303: Renamed indirect phy access functions

2017-07-30 Thread Egil Hjelmeland
Preparing for the following fix of MDIO phy access: Renamed functions that access PHY 1 and 2 indirectly through PMI registers. lan9303_port_phy_reg_wait_for_completion() to lan9303_indirect_phy_wait_for_completion() lan9303_port_phy_reg_read() to lan9303_indirect_phy_read()

[PATCH v2 net-next 0/4] net: dsa: lan9303: Fix MDIO issues.

2017-07-30 Thread Egil Hjelmeland
This series fix the MDIO interface for the lan9303 DSA driver. Bugs found after testing on actual HW. This series is extracted from the first patch of my first large series. Significant changes from that version are: - use mdiobus_write_nested, mdiobus_read_nested. - EXPORT

[PATCH v2 net-next 1/4] net: dsa: lan9303: Fix lan9303_detect_phy_setup() for MDIO

2017-07-30 Thread Egil Hjelmeland
Handle that MDIO read with no response return 0x. Signed-off-by: Egil Hjelmeland Reviewed-by: Andrew Lunn Reviewed-by: Vivien Didelot Reviewed-by: Florian Fainelli ---

[PATCH v2 net-next 2/4] net: dsa: lan9303: Multiply by 4 to get MDIO register

2017-07-30 Thread Egil Hjelmeland
lan9303_mdio_write()/_read() must multiply register number by 4 to get offset. Added some commments to the register definitions. Signed-off-by: Egil Hjelmeland Reviewed-by: Andrew Lunn Reviewed-by: Vivien Didelot

[PATCH net-next] net: fec: Allow reception of frames bigger than 1522 bytes

2017-07-30 Thread Andrew Lunn
The FEC Receive Control Register has a 14 bit field indicating the longest frame that my be received. It is being set to 1522. Frames longer than this are discarded, but counted as being in error. When using DSA, frames from the switch has an additional header, either 4 or 8 bytes if a Marvell

[PATCH net-next v12 4/4] net sched actions: add time filter for action dumping

2017-07-30 Thread Jamal Hadi Salim
From: Jamal Hadi Salim This patch adds support for filtering based on time since last used. When we are dumping a large number of actions it is useful to have the option of filtering based on when the action was last used to reduce the amount of data crossing to user space.

[PATCH net-next v12 1/4] net netlink: Add new type NLA_BITFIELD32

2017-07-30 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Generic bitflags attribute content sent to the kernel by user. With this netlink attr type the user can either set or unset a flag in the kernel. The value is a bitmap that defines the bit values being set The selector is a bitmask that defines which

[PATCH net-next v12 2/4] net sched actions: Use proper root attribute table for actions

2017-07-30 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Bug fix for an issue which has been around for about a decade. We got away with it because the enumeration was larger than needed. Fixes: 7ba699c604ab ("[NET_SCHED]: Convert actions from rtnetlink to new netlink API") Suggested-by: Jiri Pirko

[PATCH net-next v12 3/4] net sched actions: dump more than TCA_ACT_MAX_PRIO actions per batch

2017-07-30 Thread Jamal Hadi Salim
From: Jamal Hadi Salim When you dump hundreds of thousands of actions, getting only 32 per dump batch even when the socket buffer and memory allocations allow is inefficient. With this change, the user will get as many as possibly fitting within the given constraints

[PATCH net-next v12 0/4] net sched actions: improve dump performance

2017-07-30 Thread Jamal Hadi Salim
From: Jamal Hadi Salim Changes since v11: -- 1) Jiri - renames: nla_value to value and nla_selector to selector 2) Jiri - rename: validate_nla_bitfield_32 to validate_nla_bitfield_32 3) Jiri - rename: NLA_BITFIELD_32 to NLA_BITFIELD32 4) Jiri - remove

Re: [PATCH v2] ravb: add wake-on-lan support via magic packet

2017-07-30 Thread Andrew Lunn
Hi Niklas > @@ -2041,6 +2073,11 @@ static int ravb_probe(struct platform_device *pdev) > > priv->chip_id = chip_id; > > + /* Get clock, if not found that's OK but Wake-On-Lan is unavailable */ > + priv->clk = devm_clk_get(>dev, NULL); > + if (IS_ERR(priv->clk)) > +

[RFC PATCH net-next 5/5] ipv6: sr: implement several seg6local actions

2017-07-30 Thread David Lebrun
This patch implements the following seg6local actions. - SEG6_LOCAL_ACTION_END: regular SRH processing. The DA of the packet is updated to the next segment and forwarded accordingly. - SEG6_LOCAL_ACTION_END_X: same as above, except that the packet is forwarded to the specified IPv6 next-hop.

[RFC PATCH net-next 2/5] ipv6: sr: export SRH insertion functions

2017-07-30 Thread David Lebrun
This patch exports the seg6_do_srh_encap() and seg6_do_srh_inline() functions. It also removes the CONFIG_IPV6_SEG6_INLINE knob that enabled the compilation of seg6_do_srh_inline(). This function is now built-in. Signed-off-by: David Lebrun --- include/net/seg6.h

[RFC PATCH net-next 4/5] ipv6: sr: add rtnetlink functions for seg6local action parameters

2017-07-30 Thread David Lebrun
This patch adds the necessary functions to parse, fill, and compare seg6local rtnetlink attributes, for all defined action parameters. - The SRH parameter defines an SRH to be inserted or encapsulated. - The TABLE parameter defines the table to use for the route lookup of the next segment or

[RFC PATCH net-next 3/5] ipv6: sr: define core operations for seg6local lightweight tunnel

2017-07-30 Thread David Lebrun
This patch implements a new type of lightweight tunnel named seg6local. A seg6local lwt is defined by a type of action and a set of parameters. The action represents the operation to perform on the packets matching the lwt's route, and is not necessarily an encapsulation. The set of parameters are

[RFC PATCH net-next 0/5] ipv6: sr: add support for advanced local segment processing

2017-07-30 Thread David Lebrun
The current implementation of IPv6 SR supports SRH insertion/encapsulation and basic segment endpoint behavior (i.e., processing of an SRH contained in a packet whose active segment (IPv6 DA) is routed to the local node). This behavior simply consists of updating the DA to the next segment and

[RFC PATCH net-next 1/5] ipv6: sr: allow SRH insertion with arbitrary segments_left value

2017-07-30 Thread David Lebrun
The seg6_validate_srh() function only allows SRHs whose active segment is the first segment of the path. However, an application may insert an SRH whose active segment is not the first one. Such an application might be for example an SR-aware Virtual Network Function. This patch enables to insert

[PATCH v2] ravb: add wake-on-lan support via magic packet

2017-07-30 Thread Niklas Söderlund
WoL is enabled in the suspend callback by setting MagicPacket detection and disabling all interrupts expect MagicPacket. In the resume path the driver needs to reset the hardware to rearm the WoL logic, this prevents the driver from simply restoring the registers and to take advantage of that ravb

Re: [net-next PATCH 11/12] net: add notifier hooks for devmap bpf map

2017-07-30 Thread Levin, Alexander (Sasha Levin)
On Mon, Jul 17, 2017 at 09:30:02AM -0700, John Fastabend wrote: >@@ -341,9 +368,11 @@ static int dev_map_update_elem(struct bpf_map *map, void >*key, void *value, >* Remembering the driver side flush operation will happen before the >* net device is removed. >*/ >+

[PATCH net] ipv6: set fc_protocol with 0 when rtm_protocol is RTPROT_REDIRECT

2017-07-30 Thread Xin Long
After commit c2ed1880fd61 ("net: ipv6: check route protocol when deleting routes"), ipv6 route checks rt protocol when trying to remove a rt entry. It introduced a side effect when flushing caches with iproute, in which all route caches get dumped from kernel then removed one by one by sending

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store

2017-07-30 Thread Michael Büsch
On Fri, 02 Jun 2017 09:18:14 +0800 Jia-Ju Bai wrote: > On 06/02/2017 12:11 AM, Jonathan Corbet wrote: > > On Thu, 01 Jun 2017 09:05:07 +0800 > > Jia-Ju Bai wrote: > > > >> I admit my patches are not well tested, and they may not well fix the bugs. >

Re: [PATCH V2 net-next 20/21] net-next/hinic: Add ethtool and stats

2017-07-30 Thread Aviad Krawczyk
Hi, I saw that netif_err is more common in code, is it preferred on netdev_err? What is the preferred style, netif_ or netdev_? Best Regards, Aviad On 7/27/2017 1:33 AM, Andrew Lunn wrote: > On Wed, Jul 19, 2017 at 03:36:28PM +0300, Aviad Krawczyk wrote: >> Hi Joe, >> >> I tried to be

Re: [PATCH V5 net-next 2/8] net: hns3: Add support of the HNAE3 framework

2017-07-30 Thread Leon Romanovsky
On Fri, Jul 28, 2017 at 11:26:46PM +0100, Salil Mehta wrote: > This patch adds the support of the HNAE3 (Hisilicon Network > Acceleration Engine 3) framework support to the HNS3 driver. > > Framework facilitates clients like ENET(HNS3 Ethernet Driver), RoCE > and user-space Ethernet drivers (like

[PATCH] netfilter: ipvs: Fix space before '[' error.

2017-07-30 Thread Arvind Yadav
Fix checkpatch.pl error: ERROR: space prohibited before open square bracket '['. Signed-off-by: Arvind Yadav --- net/netfilter/ipvs/ip_vs_proto_tcp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_proto_tcp.c

Re: [PATCH net] bpf: fix bpf_prog_get_info_by_fd to dump correct xlated_prog_len

2017-07-30 Thread David Miller
From: Daniel Borkmann Date: Fri, 28 Jul 2017 17:05:25 +0200 > bpf_prog_size(prog->len) is not the correct length we want to dump > back to user space. The code in bpf_prog_get_info_by_fd() uses this > to copy prog->insnsi to user space, but bpf_prog_size(prog->len) also >

Re: [PATCH net] mcs7780: Silence uninitialized variable warning

2017-07-30 Thread David Miller
From: Dan Carpenter Date: Fri, 28 Jul 2017 17:45:11 +0300 > - __u16 rval; > + __u16 rval = -1; Fixing a bogus warning by assigning a signed constant to an unsigned variable doesn't really make me all that happy. I don't think I'll apply this, sorry.

Re: [PATCH net] tcp: avoid bogus gcc-7 array-bounds warning

2017-07-30 Thread David Miller
From: Arnd Bergmann Date: Fri, 28 Jul 2017 16:41:37 +0200 > When using CONFIG_UBSAN_SANITIZE_ALL, the TCP code produces a > false-positive warning: > > net/ipv4/tcp_output.c: In function 'tcp_connect': > net/ipv4/tcp_output.c:2207:40: error: array subscript is below array bounds

Re: [PATCH net] Revert "vhost: cache used event for better performance"

2017-07-30 Thread K. Den
On Wed, 2017-07-26 at 19:08 +0300, Michael S. Tsirkin wrote: > On Wed, Jul 26, 2017 at 09:37:15PM +0800, Jason Wang wrote: > > > > > > On 2017年07月26日 21:18, Jason Wang wrote: > > > > > > > > > On 2017年07月26日 20:57, Michael S. Tsirkin wrote: > > > > On Wed, Jul 26, 2017 at 04:03:17PM +0800,

Re: [PATCH net-next v2 0/3] ethtool: support for forward error correction mode setting on a link

2017-07-30 Thread David Miller
From: Roopa Prabhu Date: Thu, 27 Jul 2017 16:47:25 -0700 > From: Roopa Prabhu > > Forward Error Correction (FEC) modes i.e Base-R > and Reed-Solomon modes are introduced in 25G/40G/100G standards > for providing good BER at high speeds.