Re: [RFC] iproute: Add support for extended ack to rtnl_talk

On Thu, Aug 03, 2017 at 02:26:58PM -0600, David Ahern wrote: > On 5/18/17 10:24 PM, David Ahern wrote: > > On 5/18/17 3:02 AM, Daniel Borkmann wrote: > >> So effectively this means libmnl has to be used for new stuff, noone > >> has time to do the work to convert the existing tooling over (which >

Realtek r8169 driver VLAN TAG stripping / offloading

Hi Yes, someone posted the same problem a couple of years ago: https://www.spinics.net/lists/netdev/msg152505.html But as far as I have read the thread, nobody figured out the problem. I have run in the same strange problem, where I suspect either a driver of firmware bug, after upgrading a

[patch net 0/2] mlxsw: Couple of fixes

From: Jiri Pirko Ido says: The first patch prevents us from warning about valid situations that can happen due to the fact that some operations in switchdev are deferred. Second patch fixes a long standing problem in which we didn't correctly free resources upon module

[patch net 1/2] mlxsw: spectrum_switchdev: Don't warn about valid situations

From: Ido Schimmel Some operations in the bridge driver such as MDB deletion are preformed in an atomic context and thus deferred to a process context by the switchdev infrastructure. Therefore, by the time the operation is performed by the underlying device driver it's

[patch net 2/2] mlxsw: spectrum_switchdev: Release multicast groups during fini

From: Ido Schimmel Each multicast group (MID) stores a bitmap of ports to which a packet should be forwarded to in case an MDB entry associated with the MID is hit. Since the initial introduction of IGMP snooping in commit 3a49b4fde2a1 ("mlxsw: Adding layer 2 multicast

[patch net-next v2 15/20] net: sched: cls_bpf: no need to call tcf_exts_change for newly allocated struct

From: Jiri Pirko As the prog struct was allocated right before cls_bpf_set_parms call, no need to use tcf_exts_change to do atomic change, and we can just fill-up the unused exts struct directly by tcf_exts_validate. Signed-off-by: Jiri Pirko ---

[patch net-next v2 09/20] net: sched: cls_bpf: rename cls_bpf_modify_existing function

From: Jiri Pirko The name cls_bpf_modify_existing is highly misleading, as it indeed does not modify anything existing. It does not modify at all. Signed-off-by: Jiri Pirko Acked-by: Daniel Borkmann --- net/sched/cls_bpf.c | 10

[patch net-next v2 07/20] net: sched: remove check for number of actions in tcf_exts_exec

From: Jiri Pirko Leave it to tcf_action_exec to return TC_ACT_OK in case there is no action present. Signed-off-by: Jiri Pirko --- include/net/pkt_cls.h | 4 +--- net/sched/act_api.c | 3 ++- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git

[patch net-next v2 13/20] net: sched: cls_matchall: no need to call tcf_exts_change for newly allocated struct

From: Jiri Pirko As the head struct was allocated right before mall_set_parms call, no need to use tcf_exts_change to do atomic change, and we can just fill-up the unused exts struct directly by tcf_exts_validate. Signed-off-by: Jiri Pirko ---

[patch net-next v2 14/20] net: sched: cls_basic: no need to call tcf_exts_change for newly allocated struct

From: Jiri Pirko As the f struct was allocated right before basic_set_parms call, no need to use tcf_exts_change to do atomic change, and we can just fill-up the unused exts struct directly by tcf_exts_validate. Signed-off-by: Jiri Pirko ---

[patch net-next v2 10/20] net: sched: cls_fw: rename fw_change_attrs function

From: Jiri Pirko Since the function name is misleading since it is not changing anything, name it similarly to other cls. Signed-off-by: Jiri Pirko --- net/sched/cls_fw.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git

[patch net-next v2 18/20] net: sched: cls_route: no need to call tcf_exts_change for newly allocated struct

From: Jiri Pirko As the f struct was allocated right before route4_set_parms call, no need to use tcf_exts_change to do atomic change, and we can just fill-up the unused exts struct directly by tcf_exts_validate. Signed-off-by: Jiri Pirko ---

[patch net-next v2 19/20] net: sched: cls_u32: no need to call tcf_exts_change for newly allocated struct

From: Jiri Pirko As the n struct was allocated right before u32_set_parms call, no need to use tcf_exts_change to do atomic change, and we can just fill-up the unused exts struct directly by tcf_exts_validate. Signed-off-by: Jiri Pirko ---

[patch net-next v2 17/20] net: sched: cls_flow: no need to call tcf_exts_change for newly allocated struct

From: Jiri Pirko As the fnew struct just was allocated, so no need to use tcf_exts_change to do atomic change, and we can just fill-up the unused exts struct directly by tcf_exts_validate. Signed-off-by: Jiri Pirko --- net/sched/cls_flow.c | 41

[patch net-next v2 20/20] net: sched: avoid atomic swap in tcf_exts_change

From: Jiri Pirko tcf_exts_change is always called on newly created exts, which are not used on fastpath. Therefore, simple struct copy is enough. Signed-off-by: Jiri Pirko --- include/net/pkt_cls.h | 3 +-- net/sched/cls_api.c | 10 ++

[patch net-next v2 12/20] net: sched: cls_fw: no need to call tcf_exts_change for newly allocated struct

From: Jiri Pirko As the f struct was allocated right before fw_set_parms call, no need to use tcf_exts_change to do atomic change, and we can just fill-up the unused exts struct directly by tcf_exts_validate. Signed-off-by: Jiri Pirko ---

[patch net-next v2 16/20] net: sched: cls_cgroup: no need to call tcf_exts_change for newly allocated struct

From: Jiri Pirko As the new struct just was allocated, so no need to use tcf_exts_change to do atomic change, and we can just fill-up the unused exts struct directly by tcf_exts_validate. Signed-off-by: Jiri Pirko --- net/sched/cls_cgroup.c | 14

[patch net-next v2 02/20] net: sched: remove unneeded tcf_em_tree_change

From: Jiri Pirko Since tcf_em_tree_validate could be always called on a newly created filter, there is no need for this change function. Signed-off-by: Jiri Pirko --- include/net/pkt_cls.h | 21 - net/sched/cls_basic.c | 4 +---

[patch net-next v2 11/20] net: sched: cls_flower: no need to call tcf_exts_change for newly allocated struct

From: Jiri Pirko As the f struct was allocated right before fl_set_parms call, no need to use tcf_exts_change to do atomic change, and we can just fill-up the unused exts struct directly by tcf_exts_validate. Signed-off-by: Jiri Pirko ---

[patch net-next v2 08/20] net: sched: use tcf_exts_has_actions instead of exts->nr_actions

From: Jiri Pirko For check in tcf_exts_dump use tcf_exts_has_actions helper instead of exts->nr_actions for checking if there are any actions present. Signed-off-by: Jiri Pirko --- net/sched/cls_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[patch net-next v2 03/20] net: sched: change names of action number helpers to be aligned with the rest

From: Jiri Pirko The rest of the helpers are named tcf_exts_*, so change the name of the action number helpers to be aligned. While at it, change to inline functions. Signed-off-by: Jiri Pirko Acked-by: Jamal Hadi Salim ---

[patch net-next v2 06/20] net: sched: fix return value of tcf_exts_exec

From: Jiri Pirko Return the defined TC_ACT_OK instead of 0. Signed-off-by: Jiri Pirko --- include/net/pkt_cls.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h index 817badf..61ce521

Re: [PATCH] MIPS: Add missing file for eBPF JIT.

On 08/04/2017 02:10 AM, David Daney wrote: Inexplicably, commit f381bf6d82f0 ("MIPS: Add support for eBPF JIT.") lost a file somewhere on its path to Linus' tree. Add back the missing ebpf_jit.c so that we can build with CONFIG_BPF_JIT selected. This version of ebpf_jit.c is identical to the

[PATCH] net: Reduce skb_warn_bad_offload() noise.

This patch will revert the b2504a5dbe "net: reduce skb_warn_bad_offload() noise". The ovs will call the __skb_gso_segment() with tx false. When segmenting UDP with UFO, the __skb_gso_segment raises a warning as below [1], because the ip_summed is CHECKSUM_NONE. While the net-next has removed the

Re: [net-next PATCH] net: comment fixes against BPF devmap helper calls

On 08/04/2017 06:58 AM, John Fastabend wrote: Update BPF comments to accurately reflect XDP usage. Fixes: 97f91a7cf04ff ("bpf: add bpf_redirect_map helper routine") Reported-by: Alexei Starovoitov Signed-off-by: John Fastabend ---

[PATCH net-next 2/5] ipv6: sr: export SRH insertion functions

This patch exports the seg6_do_srh_encap() and seg6_do_srh_inline() functions. It also removes the CONFIG_IPV6_SEG6_INLINE knob that enabled the compilation of seg6_do_srh_inline(). This function is now built-in. Signed-off-by: David Lebrun --- include/net/seg6.h

[PATCH net-next 3/5] ipv6: sr: define core operations for seg6local lightweight tunnel

This patch implements a new type of lightweight tunnel named seg6local. A seg6local lwt is defined by a type of action and a set of parameters. The action represents the operation to perform on the packets matching the lwt's route, and is not necessarily an encapsulation. The set of parameters are

[PATCH net-next 0/5] ipv6: sr: add support for advanced local segment processing

The current implementation of IPv6 SR supports SRH insertion/encapsulation and basic segment endpoint behavior (i.e., processing of an SRH contained in a packet whose active segment (IPv6 DA) is routed to the local node). This behavior simply consists of updating the DA to the next segment and

[PATCH net-next 1/5] ipv6: sr: allow SRH insertion with arbitrary segments_left value

The seg6_validate_srh() function only allows SRHs whose active segment is the first segment of the path. However, an application may insert an SRH whose active segment is not the first one. Such an application might be for example an SR-aware Virtual Network Function. This patch enables to insert

[PATCH net-next 4/5] ipv6: sr: add rtnetlink functions for seg6local action parameters

This patch adds the necessary functions to parse, fill, and compare seg6local rtnetlink attributes, for all defined action parameters. - The SRH parameter defines an SRH to be inserted or encapsulated. - The TABLE parameter defines the table to use for the route lookup of the next segment or

[PATCH net-next 5/5] ipv6: sr: implement several seg6local actions

This patch implements the following seg6local actions. - SEG6_LOCAL_ACTION_END: regular SRH processing. The DA of the packet is updated to the next segment and forwarded accordingly. - SEG6_LOCAL_ACTION_END_X: same as above, except that the packet is forwarded to the specified IPv6 next-hop.

RE: [PATCH] PCI: Update ACS quirk for more Intel 10G NICs

From: Bjorn Helgaas > Sent: 03 August 2017 22:49 > On Thu, Jul 20, 2017 at 02:41:01PM -0700, Roland Dreier wrote: > > From: Roland Dreier > > > > Add one more variant of the 82599 plus the device IDs for X540 and X550 > > variants. Intel has confirmed that none of these

Re: [PATCH] net: Reduce skb_warn_bad_offload() noise.

On Fri, 2017-08-04 at 06:11 -0700, Tonghao Zhang wrote: > This patch will revert the b2504a5dbe "net: reduce > skb_warn_bad_offload() noise". The ovs will call the > __skb_gso_segment() with tx false. When segmenting UDP with UFO, > the __skb_gso_segment raises a warning as below [1], because the

Re: [PATCH net 1/2] bpf, s390: fix jit branch offset related to ldimm64

Am Fri, 4 Aug 2017 14:20:54 +0200 schrieb Daniel Borkmann : > While testing some other work that required JIT modifications, I > run into test_bpf causing a hang when JIT enabled on s390. The > problematic test case was the one from ddc665a4bb4b (bpf, arm64: > fix jit

RE: [PATCH] net: phy: marvell: logical vs bitwise OR typo

From: Dan Carpenter > Sent: 04 August 2017 09:17 > This was supposed to be a bitwise OR but there is a || vs | typo. > > Fixes: 864dc729d528 ("net: phy: marvell: Refactor m88e1121 RGMII delay > configuration") > Signed-off-by: Dan Carpenter > > diff --git

[PATCH 6/6] samples: Introduce Qualcomm QRTR sample client

Introduce a sample driver that register for server notifications and spawn clients for each available test service (service 15). The spawned clients implements the interface for encoding "ping" and "data" requests and decode the responses from the remote. Signed-off-by: Bjorn Andersson

Re: [net-next PATCH v2] net: comment fixes against BPF devmap helper calls

On 08/04/2017 05:24 PM, John Fastabend wrote: Update BPF comments to accurately reflect XDP usage. Fixes: 97f91a7cf04ff ("bpf: add bpf_redirect_map helper routine") Reported-by: Alexei Starovoitov Signed-off-by: John Fastabend Acked-by: Daniel

Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

On Fri, Aug 4, 2017 at 3:12 AM, maowenan wrote: > > > --- a/net/ipv4/tcp_output.c > > > +++ b/net/ipv4/tcp_output.c > > > @@ -2380,21 +2380,12 @@ bool tcp_schedule_loss_probe(struct sock *sk) > > > u32 rtt = usecs_to_jiffies(tp->srtt_us >> 3); > > > u32 timeout,

Re: [PATCH] iproute2/misc: do not mix CFLAGS with LDFLAGS

On Fri, 4 Aug 2017 11:54:02 +0200 Marcus Meissner wrote: > during linking, do not use CFLAGS. This avoid clashes when doing PIE builds. > --- > misc/Makefile | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/misc/Makefile

Re: [PATCH iproute2] netns: make /var/run/netns bind-mount recursive

Stephen Hemminger writes: > On Tue, 1 Aug 2017 17:46:09 +0200 > Casey Callendrello wrote: > >> When ip netns {add|delete} is first run, it bind-mounts /var/run/netns >> on top of itself, then marks it as shared. However, if there are

[PATCH 0/6] In-kernel QMI handling

This series starts by moving the common definitions of the QMUX protocol to the uapi header, as they are shared with clients - both in kernel and userspace. This series then introduces in-kernel helper functions for aiding the handling of QMI encoded messages in the kernel. QMI encoding is a

[PATCH 4/6] soc: qcom: Introduce QMI encoder/decoder

Add the helper library for encoding and decoding QMI encoded messages. The implementation is taken from lib/qmi_encdec.c of the Qualcomm kernel (msm-3.18). Modifications has been made to the public API, source buffers has been made const and the debug-logging part was omitted, for now.

[PATCH 1/6] net: qrtr: Invoke sk_error_report() after setting sk_err

Rather than manually waking up any context sleeping on the sock to signal an error we should call sk_error_report(). This has the added benefit that in-kernel consumers can override this notificatino with its own callback. Signed-off-by: Bjorn Andersson ---

[net-next PATCH v2] net: comment fixes against BPF devmap helper calls

Update BPF comments to accurately reflect XDP usage. Fixes: 97f91a7cf04ff ("bpf: add bpf_redirect_map helper routine") Reported-by: Alexei Starovoitov Signed-off-by: John Fastabend --- include/uapi/linux/bpf.h | 16 +++- 1 file changed,

Re: [PATCH] PCI: Update ACS quirk for more Intel 10G NICs

On Fri, 4 Aug 2017 13:28:32 + David Laight wrote: > From: Bjorn Helgaas > > Sent: 03 August 2017 22:49 > > On Thu, Jul 20, 2017 at 02:41:01PM -0700, Roland Dreier wrote: > > > From: Roland Dreier > > > > > > Add one more variant of the

Re: [PATCH 1/2] net: mvneta: remove bogus use of

Hi Rob, On jeu., juil. 20 2017, Rob Herring wrote: > On Thu, Jul 20, 2017 at 10:06 AM, Gregory CLEMENT > wrote: >> Hi Rob, >> >> On jeu., juil. 20 2017, Rob Herring wrote: >> >> (Adding Marcin in CC who wrote this part

Re: [PATCH net-next] net: dsa: User per-cpu 64-bit statistics

On 08/03/2017 10:36 PM, Eric Dumazet wrote: > On Thu, 2017-08-03 at 21:33 -0700, Florian Fainelli wrote: >> During testing with a background iperf pushing 1Gbit/sec worth of >> traffic and having both ifconfig and ethtool collect statistics, we >> could see quite frequent deadlocks. Convert the

Re: XFRM pcpu cache issue

Ilan Tayari wrote: > I debugged a little the regression I told you about the other day... > > Steps and Symptoms: > 1. Set up a host-to-host IPSec tunnel (or transport, doesn't matter) > 2. Ping over IPSec, or do something to populate the pcpu cache > 3. Join a MC group, then

Re: [PATCH net 1/2] bpf, s390: fix jit branch offset related to ldimm64

On 08/04/2017 03:44 PM, Michael Holzheu wrote: Am Fri, 4 Aug 2017 14:20:54 +0200 schrieb Daniel Borkmann : [...] What about "Cc: sta...@vger.kernel.org"? Handled by Dave, see also: Documentation/networking/netdev-FAQ.txt +117 Cheers, Daniel

[PATCH 2/6] net: qrtr: Move constants to header file

The constants are used by both the name server and clients, so make their value explicit and move them to the uapi header. Signed-off-by: Bjorn Andersson --- include/uapi/linux/qrtr.h | 3 +++ net/qrtr/qrtr.c | 2 -- 2 files changed, 3 insertions(+), 2

Re: [PATCH 0/6] In-kernel QMI handling

On Fri, 2017-08-04 at 07:59 -0700, Bjorn Andersson wrote: > This series starts by moving the common definitions of the QMUX > protocol to the > uapi header, as they are shared with clients - both in kernel and > userspace. > > This series then introduces in-kernel helper functions for aiding the

[PATCH net-next V2] net ipv6: convert fib6_table rwlock to a percpu lock

From: Shaohua Li In a syn flooding test, the fib6_table rwlock is a significant bottleneck. While converting the rwlock to rcu sounds straighforward, but is very challenging if it's possible. A percpu spinlock (lglock has been removed from kernel, so I added a simple implementation

[PATCH 5/6] soc: qcom: Introduce QMI helpers

Drivers that needs to communicate with a remote QMI service all has to perform the operations of discovering the service, encoding and decoding the messages and operate the socket. This introduces an abstraction for these common operations, reducing most of the duplication in such cases.

[PATCH 3/6] net: qrtr: Add control packet definition to uapi

The QMUX protocol specification defines structure of the special control packet messages being sent between handlers of the control port. Add these to the uapi header, as this structure and the associated types are shared between the kernel and all userspace handlers of control messages.

Re: [PATCH 1/2] net: mvneta: remove bogus use of

Hi Gregory, >From my side: +1 to your modification. Thanks, Marcin 2017-08-04 17:26 GMT+02:00 Gregory CLEMENT : > Hi Rob, > > On jeu., juil. 20 2017, Rob Herring wrote: > >> On Thu, Jul 20, 2017 at 10:06 AM, Gregory CLEMENT >>

Re: [RFC] iproute: Add support for extended ack to rtnl_talk

On Fri, 4 Aug 2017 13:31:48 +0200 Simon Horman wrote: > On Thu, Aug 03, 2017 at 02:26:58PM -0600, David Ahern wrote: > > On 5/18/17 10:24 PM, David Ahern wrote: > > > On 5/18/17 3:02 AM, Daniel Borkmann wrote: > > >> So effectively this means libmnl has to be used

Re: [PATCH net 3/3] tcp: fix xmit timer to only be reset if data ACKed/SACKed

On Fri, Aug 4, 2017 at 3:33 AM, maowenan wrote: > [Mao Wenan]Follow previous mail, in lower version such as 3.10, I found > there are many timer type, e.g:ICSK_TIME_EARLY_RETRANS, RTO,PTO > are used. I'm not sure there exist some unknown problem if we don't check >

Re: [PATCH net-next v2 00/13] Change DSA's FDB API and perform switchdev cleanup

Hi Arkadi, Jiri, Jiri Pirko writes: >>It seems impossible currently to move the self to be the default, and >>this introduces regression which you don't approve, so it seems few >>options left: >> >>a) Leave two ways to add fdb, through the bridge (by using the master >>

Re: [PATCH] samples/bpf: Fix cross compiler error with bpf sample

On 08/04/2017 07:46 AM, Joel Fernandes wrote: When cross-compiling the bpf sample map_perf_test for aarch64, I find that __NR_getpgrp is undefined. This causes build errors. Fix it by allowing the deprecated syscall in the sample. Signed-off-by: Joel Fernandes ---

<    1   2