Re: [PATCH v3 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

On Thu, Nov 09, 2017 at 11:29:08AM -0800, David Daney wrote: > From: Carlos Munoz > > Add bindings for Common Ethernet Interface (BGX) block. > > Signed-off-by: Carlos Munoz > Signed-off-by: Steven J. Hill > Signed-off-by: David

[PATCH] qed: fix unnecessary call to memset cocci warnings

Use kzalloc rather than kmalloc followed by memset with 0 drivers/net/ethernet/qlogic/qed/qed_dcbx.c:1280:13-20: WARNING: kzalloc should be used for dcbx_info, instead of kmalloc/memset Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci Originally was fixed in: 'commit 561ed23331df

Re: [PATCH] net: bridge: add max_fdb_count

On Wed, 15 Nov 2017 11:27:07 -0800 Sarah Newman wrote: > Current memory and CPU usage for managing bridge fdb entries is unbounded. > Add a parameter max_fdb_count, controlled from sysfs, which places an upper > limit on the number of entries. Defaults to 1024. > > When

Re: [PATCH iproute2/net-next v2]tc: B.W limits can now be specified in %.

On Wed, 15 Nov 2017 07:06:21 +0530 Nishanth Devarajan wrote: > int parse_percent_rate(char *rate, const char *str, char *dev) You aren't modifyin dev so it should be const char * > +{ > + long max_rate_bits; > + int ret, saved_errno; > + double perc, rate_bits; >

[PATCH] net: bridge: add max_fdb_count

Current memory and CPU usage for managing bridge fdb entries is unbounded. Add a parameter max_fdb_count, controlled from sysfs, which places an upper limit on the number of entries. Defaults to 1024. When max_fdb_count is met or exceeded, whether traffic is sent out a given port should depend on

[PATCH][v4] uprobes/x86: emulate push insns for uprobe on x86

Uprobe is a tracing mechanism for userspace programs. Typical uprobe will incur overhead of two traps. First trap is caused by replaced trap insn, and the second trap is to execute the original displaced insn in user space. To reduce the overhead, kernel provides hooks for architectures to

Re: [RFC] [PATCH] netns: Fix race in virtual interface bringup

Adding CC netdev Can someone comment on the expected behavior of this test case? Here's the isolated test: ip netns del tst_net_ns0 ip netns del tst_net_ns1 ip netns add tst_net_ns0 ip netns add tst_net_ns1 ip netns exec tst_net_ns0 ip link add veth0 type veth peer name

Re: [GIT] Networking

On Wed, Nov 15, 2017 at 3:33 AM, David Miller wrote: > > Highlights: Lowlights: 1) it duplicated a commit from the hrtimer tree, which had been cleaned up and rewritten, but then merging the second copy of the commit re-introduced the bad code that had been cleaned up.

Re: [PATCH] net: recvmsg: Unconditionally zero struct sockaddr_storage

Kees Cook writes: > On Wed, Nov 1, 2017 at 5:48 AM, Eric W. Biederman > wrote: >> Eric Dumazet writes: >> >>> On Tue, 2017-10-31 at 09:14 -0700, Kees Cook wrote: Some protocols do not correctly wipe the contents of the

[RFC PATCH net-next 1/2] ethtool: Add support for configuring PFC stall prevention in ethtool

From: Inbar Karmy In the event where the device unexpectedly becomes unresponsive for a long period of time, flow control mechanism may propagate pause frames which will cause congestion spreading to the entire network. To prevent this scenario, when the device is stalled

[RFC PATCH net-next 0/2] Configuring PFC stall prevention via ethtool

From: Inbar Karmy This RFC adds support for configuring PFC stall prevention through ethtool. In the event where the device unexpectedly becomes unresponsive for a long period of time, flow control mechanism may propagate pause frames which will cause congestion spreading

[RFC PATCH net-next 2/2] net/mlx5e: PFC stall prevention support

From: Inbar Karmy Implement set/get functions to configure PFC stall prevention mode by ethtool. On default the stall prevention timeout is configured to 8 sec. Auto mode will set the stall prevention timeout to be 100 msec. Signed-off-by: Inbar Karmy

Re: [PATCH net-next v2 0/2] retire IPX and NCPFS

On Wed, 15 Nov 2017 09:58:33 +0900 (KST) David Miller wrote: > From: Stephen Hemminger > Date: Tue, 14 Nov 2017 08:37:13 -0800 > > > These are both old decrepit protocols that need to be sent > > to pasture. > > These need to go to gregkh and

Re: [RFC PATCH 06/17] net: sched: explicit locking in gso_cpu fallback

On Wed, Nov 15, 2017 at 10:11 AM, John Fastabend wrote: > On 11/14/2017 04:41 PM, Willem de Bruijn wrote: >>> /* use instead of qdisc->dequeue() for all qdiscs queried with ->peek() */ >>> static inline struct sk_buff *qdisc_dequeue_peeked(struct Qdisc *sch) >>> { >>>

Re: [PATCH V4 net 0/2] ipv6: fix flowlabel issue for reset packet

On Tue, Nov 14, 2017 at 01:59:03PM -0800, Shaohua Li wrote: > On Tue, Nov 14, 2017 at 11:13:10AM -0800, Tom Herbert wrote: > > On Tue, Nov 14, 2017 at 10:24 AM, Shaohua Li wrote: > > > On Wed, Nov 08, 2017 at 09:44:51AM -0800, Tom Herbert wrote: > > >> On Fri, Aug 18, 2017 at

Re: [PATCH v3 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

On 11/15/2017 11:18 AM, Rob Herring wrote: On Thu, Nov 09, 2017 at 11:29:08AM -0800, David Daney wrote: From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill

Re: [PATCH] net: bridge: add max_fdb_count

On 11/15/2017 11:27 AM, Sarah Newman wrote: > Current memory and CPU usage for managing bridge fdb entries is unbounded. > Add a parameter max_fdb_count, controlled from sysfs, which places an upper > limit on the number of entries. Defaults to 1024. > > When max_fdb_count is met or exceeded,

Re: SRIOV switchdev mode BoF minutes

On Tue, Nov 14, 2017 at 8:02 PM, Jakub Kicinski wrote: > On Tue, 14 Nov 2017 19:04:36 -0800, Alexander Duyck wrote: >> On Tue, Nov 14, 2017 at 3:36 PM, Jakub Kicinski >> wrote: >> > On Tue, 14 Nov 2017 15:05:08 -0800, Alexander Duyck

[net-next 1/1] tipc: enforce valid ratio between skb truesize and contents

The socket level flow control is based on the assumption that incoming buffers meet the condition (skb->truesize / roundup(skb->len) <= 4), where the latter value is rounded off upwards to the nearest 1k number. This does empirically hold true for the device drivers we know, but we cannot trust

Re: [PATCH RfC 1/2] net: phy: core: remove now uneeded disabling of interrupts

On 11/12/2017 01:08 PM, Heiner Kallweit wrote: > After commits c974bdbc3e "net: phy: Use threaded IRQ, to allow IRQ from > sleeping devices" and 664fcf123a30 "net: phy: Threaded interrupts allow > some simplification" all relevant code pieces run in process context > anyway and I don't think we

[PATCH 2/2] net: phy: remove generic settings for callbacks config_aneg and read_status from drivers

Remove generic settings for callbacks config_aneg and read_status from drivers. Signed-off-by: Heiner Kallweit --- drivers/net/phy/amd.c| 2 -- drivers/net/phy/at803x.c | 6 -- drivers/net/phy/bcm-cygnus.c | 2 -- drivers/net/phy/bcm63xx.c| 4

Re: [PATCH 1/2] net: phy: core: use genphy version of callbacks read_status and config_aneg per default

On 11/15/2017 01:42 PM, Heiner Kallweit wrote: > read_status and config_aneg are the only mandatory callbacks and most > of the time the generic implementation is used by drivers. > So make the core fall back to the generic version if a driver doesn't > implement the respective callback. > > Also

Re: [PATCH v3 2/4] net: nb8800: Simplify nb8800_pause_config()

On Wed, Nov 15, 2017 at 04:19:56PM +0100, Marc Gonzalez wrote: > On 15/11/2017 16:03, Andrew Lunn wrote: > > > On Wed, Nov 15, 2017 at 03:33:47PM +0100, Marc Gonzalez wrote: > > > >> On 15/11/2017 15:17, Andrew Lunn wrote: > >> > >> In our local branch, I have completely disabled flow control

Re: [RFC PATCH 01/14] packet: introduce AF_PACKET V4 userspace API

> > Actually, we started out with that approach, where the packet_mmap > call mapped Tx/Rx descriptor rings and the packet buffer region. We > later moved to this (register umem) approach, because it's more > flexible for user space, not having to use a AF_PACKET specific > allocator (i.e.

Re: [PATCH RfC 1/2] net: phy: core: remove now uneeded disabling of interrupts

Am 15.11.2017 um 23:04 schrieb Florian Fainelli: > On 11/12/2017 01:08 PM, Heiner Kallweit wrote: >> After commits c974bdbc3e "net: phy: Use threaded IRQ, to allow IRQ from >> sleeping devices" and 664fcf123a30 "net: phy: Threaded interrupts allow >> some simplification" all relevant code pieces

Re: [RFC PATCH 01/14] packet: introduce AF_PACKET V4 userspace API

On Tue, Oct 31, 2017 at 5:41 AM, Björn Töpel wrote: > From: Björn Töpel > > +/* > + * struct tpacket_memreg_req is used in conjunction with PACKET_MEMREG > + * to register user memory which should be used to store the packet > + * data. > + * > + *

Re: linux-next: build warning after merge of the netfilter-next tree

Hi Pablo, On Thu, 9 Nov 2017 00:40:14 +0100 Pablo Neira Ayuso wrote: > > On Wed, Nov 08, 2017 at 07:00:52PM +1100, Stephen Rothwell wrote: > > > > On Tue, 7 Nov 2017 11:02:48 +1100 Stephen Rothwell > > wrote: > > > > > > After merging the

Re: [patch net-next v2 00/10] net: sched: allow qdiscs to share filter block instances

On Sun, Nov 12, 2017 at 7:55 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Currently the filters added to qdiscs are independent. So for example if you > have 2 netdevices and you create ingress qdisc on both and you want to add > identical filter rules both,

Re: [PATCH] net: bridge: add max_fdb_count

Den 15. nov. 2017 20:27, skrev Sarah Newman: Current memory and CPU usage for managing bridge fdb entries is unbounded. Add a parameter max_fdb_count, controlled from sysfs, which places an upper limit on the number of entries. Defaults to 1024. When max_fdb_count is met or exceeded, whether

Re: [GIT] Networking

On 11/15/2017 09:19 PM, Linus Torvalds wrote: > On Wed, Nov 15, 2017 at 3:33 AM, David Miller wrote: >> >> Highlights: > > Lowlights: > > 1) it duplicated a commit from the hrtimer tree, which had been > cleaned up and rewritten, but then merging the second copy of the >

[PATCH 1/2] net: phy: core: use genphy version of callbacks read_status and config_aneg per default

read_status and config_aneg are the only mandatory callbacks and most of the time the generic implementation is used by drivers. So make the core fall back to the generic version if a driver doesn't implement the respective callback. Also currently the core doesn't seem to verify that drivers

Re: [PATCH 2/2] net: phy: remove generic settings for callbacks config_aneg and read_status from drivers

On 11/15/2017 01:45 PM, Heiner Kallweit wrote: > Remove generic settings for callbacks config_aneg and read_status > from drivers. > > Signed-off-by: Heiner Kallweit Nice diffstat: Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH 4.4 27/56] cdc_ncm: Set NTB format again after altsetting switch for Huawei devices

Ben Hutchings writes: > On Tue, 2017-07-11 at 17:21 +0200, Enrico Mioso wrote: >> From: Enrico Mioso >> >> commit 2b02c20ce0c28974b44e69a2e2f5ddc6a470ad6f upstream. > [...] >> --- a/drivers/net/usb/cdc_ncm.c >> +++ b/drivers/net/usb/cdc_ncm.c

Re: [PATCH iproute2/net-next v2]tc: B.W limits can now be specified in %.

On Wed, 15 Nov 2017 07:06:21 +0530, Nishanth Devarajan wrote: > This patch adapts the tc command line interface to allow bandwidth limits > to be specified as a percentage of the interface's capacity. > > For this purpose, we've modified and moved int read_prop() from > ip/iptuntap.c to

Re: [patch net-next RFC v2 03/11] devlink: Add support for reload

On Tue, 14 Nov 2017 17:18:44 +0100, Jiri Pirko wrote: > +static int devlink_nl_cmd_reload(struct sk_buff *skb, struct genl_info *info) > +{ > + struct devlink *devlink = info->user_ptr[0]; > + int err; > + > + if (!devlink->ops->reload) > + return -EOPNOTSUPP; > + > +

Re: [PATCH] net: recvmsg: Unconditionally zero struct sockaddr_storage

On Wed, Nov 1, 2017 at 7:23 PM, Kees Cook wrote: > On Wed, Nov 1, 2017 at 5:48 AM, Eric W. Biederman > wrote: >> Eric Dumazet writes: >> >>> On Tue, 2017-10-31 at 09:14 -0700, Kees Cook wrote: Some protocols do not

[PATCH net,stable] net: cdc_ncm: GetNtbFormat endian fix

The GetNtbFormat and SetNtbFormat requests operate on 16 bit little endian values. We get away with ignoring this most of the time, because we only care about USB_CDC_NCM_NTB16_FORMAT which is 0x. This fails for USB_CDC_NCM_NTB32_FORMAT. Fix comparison between LE value from device and

Re: [patch net-next RFC v2 02/11] devlink: Add support for resource abstraction

On Tue, 14 Nov 2017 17:18:43 +0100, Jiri Pirko wrote: > From: Arkadi Sharshevsky > > Add support for hardware resource abstraction over devlink. Each resource > is identified via id, furthermore it contains information regarding its > size and its related sub resources.

[PATCHv2 net] sctp: do not free asoc when it is already dead in sctp_sendmsg

Now in sctp_sendmsg sctp_wait_for_sndbuf could schedule out without holding sock sk. It means the current asoc can be freed elsewhere, like when receiving an abort packet. If the asoc is just created in sctp_sendmsg and sctp_wait_for_sndbuf returns err, the asoc will be freed again due to

[PATCHv2 net] sctp: check stream reset info len before making reconf chunk

Now when resetting stream, if both in and out flags are set, the info len can reach: sizeof(struct sctp_strreset_outreq) + SCTP_MAX_STREAM(65535) + sizeof(struct sctp_strreset_inreq) + SCTP_MAX_STREAM(65535) even without duplicated stream no, this value is far greater than the chunk's max

Re: [PATCH net-next v2 0/2] retire IPX and NCPFS

On Wed, Nov 15, 2017 at 09:58:33AM +0900, David Miller wrote: > From: Stephen Hemminger > Date: Tue, 14 Nov 2017 08:37:13 -0800 > > > These are both old decrepit protocols that need to be sent > > to pasture. > > These need to go to gregkh and his staging/ tree, not

Re: tipc_udp_send_msg oops in 4.4 when setting link tolerance

On 14.11.2017 13:35, Jon Maloy wrote: Found it, the missing patch is this one (9b3009604b8e does not help): commit d01332f1acacc0cb43a61f4244dd2b846d4cd585 Author: Richard Alpe Date: Mon Feb 1 08:19:56 2016 +0100 tipc: fix link attribute propagation bug It

Re: [PATCH net] hv_netvsc: preserve hw_features on mtu/channels/ringparam changes

Haiyang Zhang writes: >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: Tuesday, November 14, 2017 11:58 AM >> To: Stephen Hemminger >> Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; >>

Re: [patch net-next RFC v2 03/11] devlink: Add support for reload

Wed, Nov 15, 2017 at 09:03:59AM CET, jakub.kicin...@netronome.com wrote: >On Tue, 14 Nov 2017 17:18:44 +0100, Jiri Pirko wrote: >> +static int devlink_nl_cmd_reload(struct sk_buff *skb, struct genl_info >> *info) >> +{ >> +struct devlink *devlink = info->user_ptr[0]; >> +int err; >> + >>

[PATCHv2 net] sctp: use the right sk after waking up from wait_buf sleep

Commit dfcb9f4f99f1 ("sctp: deny peeloff operation on asocs with threads sleeping on it") fixed the race between peeloff and wait sndbuf by checking waitqueue_active(>wait) in sctp_do_peeloff(). But it actually doesn't work, as even if waitqueue_active returns false the waiting sndbuf thread may

[PATCH 2/2] r8169: reinstate internal ASPM and clock request settings

Commit ("r8169: enable internal ASPM and clock request settings") caused a regression on RTL8168evl/8111evl [1], so it got reverted. Instead of reverting the whole commit, let's reinstate ASPM for all models other than RTL8168evl/8111evl. [1] https://lkml.org/lkml/2013/1/5/36 Cc: Francois

[PATCH 1/2] r8169: reinstate ALDPS for power saving

Commit ("r8169: enable ALDPS for power saving") caused a regression on RTL8168evl/8111evl [1], so it got reverted. Instead of reverting the whole commit, let's reinstate ALDPS for all models other than RTL8168evl/8111evl. [1] https://lkml.org/lkml/2013/1/5/36 Cc: Francois Romieu

Re: [PATCH] vhost/scsi: Use safe iteration in vhost_scsi_complete_cmd_work()

On Thu, Nov 09, 2017 at 09:17:29AM +0900, Byungchul Park wrote: > I am sorry for having made a mistake on it. Hello Nicholas, Please consider this patch urgently. I'm sorry for having changed the original behavior with the previous patch. The safe version of llist API should be used to keep the

Re: [RFC PATCH net-next 0/2] Configuring PFC stall prevention via ethtool

On Wed, Nov 15, 2017 at 09:00:09PM +0200, Eran Ben Elisha wrote: > From: Inbar Karmy > > This RFC adds support for configuring PFC stall prevention through ethtool. > > In the event where the device unexpectedly becomes unresponsive for a long > period of time, flow control

Re: [PATCH net] genetlink: fix genlmsg_nlhdr()

From: Michal Kubecek Date: Wed, 15 Nov 2017 13:09:32 +0100 (CET) > According to the description, first argument of genlmsg_nlhdr() points to > what genlmsg_put() returns, i.e. beginning of user header. Therefore we > should only subtract size of genetlink header and netlink

Re: [PATCH net v2] hv_netvsc: preserve hw_features on mtu/channels/ringparam changes

From: Vitaly Kuznetsov Date: Wed, 15 Nov 2017 15:12:55 +0100 > rndis_filter_device_add() is called both from netvsc_probe() when we > initially create the device and from set channels/mtu/ringparam > routines where we basically remove the device and add it back. > >

Re: [PATCH net-next] netfilter: add ifdef around ctnetlink_proto_size

From: Pablo Neira Ayuso Date: Wed, 15 Nov 2017 18:28:21 +0100 > From: Arnd Bergmann > > This function is no longer marked 'inline', so we now get a warning > when it is unused: > > net/netfilter/nf_conntrack_netlink.c:536:15: error: 'ctnetlink_proto_size'

Re: [PATCH] qed: use kzalloc instead of kmalloc and memset

From: Colin King Date: Wed, 15 Nov 2017 14:03:20 + > From: Colin Ian King > > Replace kmalloc followed by a memset with kzalloc > > Signed-off-by: Colin Ian King Applied.

Re: [net-next v2] ipv6: sr: update the struct ipv6_sr_hdr

From: Ahmed Abdelsalam Date: Wed, 15 Nov 2017 15:34:23 +0100 > The IPv6 Segment Routing Header (SRH) format has been updated (revision 6 > of the SRH ietf draft). The update includes the following SRH fields: > > (1) The "First Segment" field changed to be "Last Entry"

Re: [PATCHv2 net] sctp: do not free asoc when it is already dead in sctp_sendmsg

From: Xin Long Date: Wed, 15 Nov 2017 16:55:54 +0800 > Now in sctp_sendmsg sctp_wait_for_sndbuf could schedule out without > holding sock sk. It means the current asoc can be freed elsewhere, > like when receiving an abort packet. > > If the asoc is just created in

Re: [PATCHv2 net] sctp: check stream reset info len before making reconf chunk

From: Xin Long Date: Wed, 15 Nov 2017 17:00:11 +0800 > Now when resetting stream, if both in and out flags are set, the info > len can reach: > sizeof(struct sctp_strreset_outreq) + SCTP_MAX_STREAM(65535) + > sizeof(struct sctp_strreset_inreq) + SCTP_MAX_STREAM(65535)

Re: [PATCHv2 net] sctp: use the right sk after waking up from wait_buf sleep

From: Xin Long Date: Wed, 15 Nov 2017 16:57:26 +0800 > Commit dfcb9f4f99f1 ("sctp: deny peeloff operation on asocs with threads > sleeping on it") fixed the race between peeloff and wait sndbuf by > checking waitqueue_active(>wait) in sctp_do_peeloff(). > > But it actually

Re: [net-next 1/1] tipc: enforce valid ratio between skb truesize and contents

From: Jon Maloy Date: Wed, 15 Nov 2017 21:23:56 +0100 > The socket level flow control is based on the assumption that incoming > buffers meet the condition (skb->truesize / roundup(skb->len) <= 4), > where the latter value is rounded off upwards to the nearest 1k number.

Re: [PATCH] ibmveth: Kernel crash LSO offload flag toggle

On Wed, 2017-11-15 at 10:45 -0600, Bryant G. Ly wrote: > This patch just closes the window, bad things can still happen. I wanted to > leave it > up to the people who actively develop in ibmveth to close the window, since > introducing > a lock can be expensive in tx. You don't need to

Re: [PATCH] vhost/scsi: Use safe iteration in vhost_scsi_complete_cmd_work()

On Thu, Nov 16, 2017 at 08:52:39AM +0900, Byungchul Park wrote: > On Thu, Nov 09, 2017 at 09:17:29AM +0900, Byungchul Park wrote: > > I am sorry for having made a mistake on it. > > Hello Nicholas, > > Please consider this patch urgently. I'm sorry for having changed the > original behavior with

Re: [GIT] Networking

From: Daniel Borkmann Date: Wed, 15 Nov 2017 23:15:20 +0100 > On 11/15/2017 09:19 PM, Linus Torvalds wrote: >> On Wed, Nov 15, 2017 at 3:33 AM, David Miller wrote: >>> >>> Highlights: >> >> Lowlights: >> >> 1) it duplicated a commit from the hrtimer

[PATCH] fealnx: Fix building error on MIPS

This patch try to fix the building error on MIPS. The reason is MIPS has already defined the LONG macro, which conflicts with the LONG enum in drivers/net/ethernet/fealnx.c. Cc: sta...@vger.kernel.org Signed-off-by: Huacai Chen --- drivers/net/ethernet/fealnx.c | 6 +++--- 1

Re: [RFC PATCH 00/14] Introducing AF_PACKET V4 support

On Wed, Nov 15, 2017 at 9:55 PM, Alexei Starovoitov wrote: > On 11/14/17 4:20 AM, Willem de Bruijn wrote: >> >> >> * Limit the scope of the first patchset to Rx only, and introduce Tx >> in a separate patchset. > > > > all sounds good to me except

Re: Request for -stable inclusion: time stamping fix for nfp

From: Guillaume Nault Date: Wed, 15 Nov 2017 17:20:46 +0100 > Can you please queue commit 46f1c52e66db > ("nfp: TX time stamp packets before HW doorbell is rung") for -stable? > We got hit but this bug in the late summer. We run this fix internally > since a couple of

Re: [PATCH 1/2] r8169: reinstate ALDPS for power saving

David Miller : [...] > The amount of coverage this change is going to get is very small as > well, meaning an even greater chance of regressions. Yes. > Therefore the only acceptable way to handle this is to have > a white-list, specific chips that have been explicitly

[PATCH net-next] driver: ipvlan: Add new func ipvlan_is_valid_dev instead of duplicated codes

From: Gao Feng There are multiple duplicated condition checks in the current codes, so I add the new func ipvlan_is_valid_dev instead of the duplicated codes to check if the netdev is real ipvlan dev. Signed-off-by: Gao Feng ---

Re: [PATCH] qed: fix unnecessary call to memset cocci warnings

From: Vasyl Gomonovych Date: Wed, 15 Nov 2017 20:58:15 +0100 > @@ -1277,11 +1277,10 @@ static struct qed_dcbx_get *qed_dcbnl_get_dcbx(struct > qed_hwfn *hwfn, > { > struct qed_dcbx_get *dcbx_info; > > - dcbx_info = kmalloc(sizeof(*dcbx_info), GFP_ATOMIC); > +

Re: [RFC PATCH 01/14] packet: introduce AF_PACKET V4 userspace API

From: chet l Date: Wed, 15 Nov 2017 14:34:32 -0800 > I have not reviewed the entire patchset but I think if we could add a > version_hdr and then unionize the fields, it might be easier to add > SVM support without having to spin v5. I could be wrong though. Please, NO

Re: [RFC PATCH net-next 0/2] Configuring PFC stall prevention via ethtool

> What do other vendors support? Time? Number of pause frames sent? So i checked a few Marvell Switches. You can also specify a time. It is a little bit more complex than that, since the units of time depend on the link speed. But converting a time in ms to what the register wants is possible.

Re: [RFC PATCH 00/14] Introducing AF_PACKET V4 support

On 11/14/17 4:20 AM, Willem de Bruijn wrote: * Limit the scope of the first patchset to Rx only, and introduce Tx in a separate patchset. all sounds good to me except above bit. I don't remember people suggesting to split it this way. What's the value of it without tx? We definitely

Re: [PATCH] net: bridge: add max_fdb_count

On 2017/11/16 11:25, Andrew Lunn wrote: >> Also what do the vendors using bridge for L2 offload to switch think? > > The Marvell L2 switches which DSA supports have 8K FDB/MDB entries. So > maybe 1024 is a bit low? How about U32_MAX by default since it is currently not restricted. (assuming the

NETDEV WATCHDOG: eth0 (dwc-eth-dwmac): transmit queue 1 timed out

Hi, I am trying to enable multi-queue in Tegra186 EQOS (which has support for 4 channels). Observed below netdev watchdog warning. Its easily reproable with iperf test. In normal ping scenario this is not observed. I did not observe any issue if we disable TSO. Looks like issue in

Re: [PATCH] net: ethernet: ti: cpsw: fix min eth packet size

From: Grygorii Strashko Date: Wed, 15 Nov 2017 09:46:35 -0600 > Now CPSW driver configures min eth packet size to 60 octets (ETH_ZLEN) > which works in most of cases, but when port VLAN is configured on some > switch port, it also can be configured to force all egress

Re: [PATCH] net: bridge: add max_fdb_count

On 15/11/17 21:27, Sarah Newman wrote: > Current memory and CPU usage for managing bridge fdb entries is unbounded. > Add a parameter max_fdb_count, controlled from sysfs, which places an upper > limit on the number of entries. Defaults to 1024. > > When max_fdb_count is met or exceeded, whether

[PATCH 11/12] isdn: hisax: Fix pnp_irq's error checking for setup_sedlbauer_isapnp

The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/sedlbauer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/sedlbauer.c

Re: [PATCH] net: bridge: add max_fdb_count

On 11/15/2017 08:05 PM, Toshiaki Makita wrote: > On 2017/11/16 11:25, Andrew Lunn wrote: >>> Also what do the vendors using bridge for L2 offload to switch think? >> >> The Marvell L2 switches which DSA supports have 8K FDB/MDB entries. So >> maybe 1024 is a bit low? > > How about U32_MAX by

Re: [PATCH] rtnetlink: fix missing size for IFLA_IF_NETNSID

On Mon, 6 Nov 2017 16:16:20 +0100 Jiri Benc wrote: > On Mon, 6 Nov 2017 15:04:54 +, Colin King wrote: > > The size for IFLA_IF_NETNSID is missing from the size calculation > > because the proceeding semicolon was not removed. Fix this by removing > > the semicolon. > >

Re: [PATCH v3] wcn36xx: Set default BTLE coexistence config

On Mon 13 Nov 23:23 PST 2017, Ramon Fried wrote: > From: Eyal Ilsar > > If the value for the firmware configuration parameters > BTC_STATIC_LEN_LE_BT and BTC_STATIC_LEN_LE_WLAN are not set the duty > cycle between BT and WLAN is such that if BT (including BLE) is active >

Re: [PATCH] mac80211: mwl8k: Expand non-DFS 5G channels

Weixiao Zhang writes: > Signed-off-by: Weixiao Zhang No empty commit logs, please. And use v2, v3 to clearly mark what's the version of the patch: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing

[PATCH 05/12] isdn: hisax: Fix pnp_irq's error checking for setup_hfcsx

The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/hfc_sx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/hfc_sx.c

[PATCH 09/12] isdn: hisax: Fix pnp_irq's error checking for setup_ix1micro

The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/ix1_micro.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/ix1_micro.c

[PATCH 04/12] isdn: hisax: Fix pnp_irq's error checking for setup_elsa_isapnp

The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/elsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/elsa.c

Re: [PATCH 1/2] r8169: reinstate ALDPS for power saving

> On 15 Nov 2017, at 6:53 PM, David Miller wrote: > > From: Kai-Heng Feng > Date: Wed, 15 Nov 2017 04:00:18 -0500 > >> Commit ("r8169: enable ALDPS for power saving") caused a regression on >> RTL8168evl/8111evl [1], so it got reverted. >>

[PATCH 07/12] isdn: hisax: Handle return value of pnp_irq and pnp_port_start

pnp_irq() and pnp_port_start() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/hisax_fcpcipnp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/isdn/hisax/hisax_fcpcipnp.c

[PATCH 12/12] isdn: hisax: Fix pnp_irq's error checking for setup_teles3

The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/teles3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/teles3.c

Re: [PATCH] net: bridge: add max_fdb_count

On 2017/11/16 13:54, Sarah Newman wrote: > On 11/15/2017 08:05 PM, Toshiaki Makita wrote: >> On 2017/11/16 11:25, Andrew Lunn wrote: Also what do the vendors using bridge for L2 offload to switch think? >>> >>> The Marvell L2 switches which DSA supports have 8K FDB/MDB entries. So >>> maybe

Re: [PATCH] net: bridge: add max_fdb_count

On Wed, Nov 15, 2017 at 10:13 PM, Toshiaki Makita wrote: > On 2017/11/16 13:54, Sarah Newman wrote: >> On 11/15/2017 08:05 PM, Toshiaki Makita wrote: >>> On 2017/11/16 11:25, Andrew Lunn wrote: > Also what do the vendors using bridge for L2 offload to switch

Re: [RFC PATCH 00/14] Introducing AF_PACKET V4 support

2017-11-16 4:35 GMT+01:00 Willem de Bruijn : > On Wed, Nov 15, 2017 at 9:55 PM, Alexei Starovoitov wrote: >> On 11/14/17 4:20 AM, Willem de Bruijn wrote: >>> >>> >>> * Limit the scope of the first patchset to Rx only, and introduce Tx

Re: [PATCH v2 2/2] chcr: Add support for Inline IPSec

On Thu, Nov 16, 2017 at 01:19:52PM +0800, kbuild test robot wrote: > Hi Atul, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on cryptodev/master] > [also build test ERROR on next-20171115] > [cannot apply to v4.14] > [if your patch is

[PATCH net] net/sctp: Always set scope_id in sctp_inet6_skb_msgname

Alexandar Potapenko while testing the kernel with KMSAN and syzkaller discovered that in some configurations sctp would leak 4 bytes of kernel stack. Working with his reproducer I discovered that those 4 bytes that are leaked is the scope id of an ipv6 address returned by recvmsg. With a little

[PATCH 02/12] isdn: hisax: Fix pnp_irq's error checking for avm_pnp_setup

The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/avm_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/avm_pci.c

[PATCH 00/12] isdn: hisax: Fix pnp_irq's error checking

The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Arvind Yadav (12): [PATCH 01/12] isdn: hisax: Fix pnp_irq's error checking for setup_asuscom [PATCH 02/12] isdn: hisax: Fix pnp_irq's error checking for avm_pnp_setup [PATCH 03/12] isdn:

[PATCH 06/12] isdn: hisax: Fix pnp_irq's error checking for setup_hfcs

The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/hfcscard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/hfcscard.c

[PATCH 01/12] isdn: hisax: Fix pnp_irq's error checking for setup_asuscom

The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/asuscom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/asuscom.c

[PATCH 03/12] isdn: hisax: Fix pnp_irq's error checking for setup_diva_isapnp

The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/diva.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/diva.c

[PATCH 10/12] isdn: hisax: Fix pnp_irq's error checking for setup_niccy

The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/niccy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/niccy.c

[PATCH 08/12] isdn: hisax: Fix pnp_irq's error checking for setup_isurf

The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/isurf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/isurf.c

Re: [PATCH v2 2/2] chcr: Add support for Inline IPSec

Hi Atul, Thank you for the patch! Yet something to improve: [auto build test ERROR on cryptodev/master] [also build test ERROR on next-20171115] [cannot apply to v4.14] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [PATCH] vhost/scsi: Use safe iteration in vhost_scsi_complete_cmd_work()

On 11/16/2017 10:30 AM, Michael S. Tsirkin wrote: On Thu, Nov 16, 2017 at 08:52:39AM +0900, Byungchul Park wrote: On Thu, Nov 09, 2017 at 09:17:29AM +0900, Byungchul Park wrote: I am sorry for having made a mistake on it. Hello Nicholas, Please consider this patch urgently. I'm sorry for

Re: [PATCH] net: bridge: add max_fdb_count

> Also what do the vendors using bridge for L2 offload to switch think? The Marvell L2 switches which DSA supports have 8K FDB/MDB entries. So maybe 1024 is a bit low? How big is an FDB entry? Even an OpenWRT/LEDE class devices with 512MB RAM can probably support 1MB of RAM for FDB entries. >

  1   2   >