Re: [PATCH net v2 00/10] bpf: offload: check netdev pointer in the drivers and namespace trouble

Tue, Nov 21, 2017 at 01:25:56AM CET, dan...@iogearbox.net wrote: >On 11/21/2017 12:21 AM, Jakub Kicinski wrote: >> Hi! >> >> This series addresses some late comments and moves checking if program >> has been loaded for the correct device to the drivers. There are also >> some problems with net

Re: [PATCH v2 25/35] nds32: Build infrastructure

2017-11-27 22:21 GMT+08:00 Arnd Bergmann : > On Mon, Nov 27, 2017 at 1:28 PM, Greentime Hu wrote: > >> diff --git a/arch/nds32/Kconfig.cpu b/arch/nds32/Kconfig.cpu >> new file mode 100644 >> index 000..6b4013f >> --- /dev/null >> +++ b/arch/nds32/Kconfig.cpu

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote: > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote: > > The driver expect "allwinner,leds-active-low" to be in PHY node, but > > the binding doc expect it to be in MAC node. > > > > Since all board DT use it also in MAC

Re: [PATCH v2 25/35] nds32: Build infrastructure

On Wed, Nov 29, 2017 at 9:39 AM, Greentime Hu wrote: > 2017-11-27 22:21 GMT+08:00 Arnd Bergmann : >> On Mon, Nov 27, 2017 at 1:28 PM, Greentime Hu wrote: >>> diff --git a/arch/nds32/Kconfig.cpu b/arch/nds32/Kconfig.cpu >>> +config

Re: [PATCH iproute2] tc: police: fix control action parsing

On 11/28/2017 02:02 PM, Jiri Pirko wrote: > Mon, Nov 27, 2017 at 09:32:59PM CET, step...@networkplumber.org wrote: >> On Mon, 27 Nov 2017 19:00:14 +0100 >> Michal Privoznik wrote: >> >>> parse_action_control helper does advancing of the arg inside. So don't >>> do it outside.

Re: [PATCH v2 25/35] nds32: Build infrastructure

2017-11-29 17:25 GMT+08:00 Arnd Bergmann : > On Wed, Nov 29, 2017 at 10:10 AM, Geert Uytterhoeven > wrote: >> Hi Arnd, >> >> On Wed, Nov 29, 2017 at 9:58 AM, Arnd Bergmann wrote: >>> On Wed, Nov 29, 2017 at 9:39 AM, Greentime Hu

Re: [iproute2 -net-next] build broken ...

On 11/29/2017 03:17 AM, Stephen Hemminger wrote: [...] > Sorry, net-next branch had out of date headers. Now fixed. Yeah, master worked fine. Thanks for the fix!

Re: [PATCH] trace/xdp: fix compile warning: ‘struct bpf_map’ declared inside parameter list

On Wed, 29 Nov 2017 16:35:01 +0800 Xie XiuQi wrote: > We meet this compile warning, which caused by missing bpf.h in xdp.h. > > In file included from ./include/trace/events/xdp.h:10:0, > from ./include/linux/bpf_trace.h:6, > from

Re: fec driver and two micrel phys

On 29/11/17, Oliver Graute wrote: > On 28/11/17, Andrew Lunn wrote: > > On Tue, Nov 28, 2017 at 04:28:15PM +0100, Oliver Graute wrote: > > > Hello list, > > > > > > I try to get two Micrel KSZ8041 Phys working with the fec driver from > > > Kernel 4.14. But it looks that something with the

[PATCH] net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bit

On 64-bit (e.g. powerpc64/allmodconfig): drivers/net/ethernet/xilinx/ll_temac_main.c: In function 'temac_start_xmit_done': drivers/net/ethernet/xilinx/ll_temac_main.c:633:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

Re: [PATCH] trace/xdp: fix compile warning: ‘struct bpf_map’ declared inside parameter list

On 11/29/2017 10:15 AM, Jesper Dangaard Brouer wrote: > On Wed, 29 Nov 2017 16:35:01 +0800 > Xie XiuQi wrote: > >> We meet this compile warning, which caused by missing bpf.h in xdp.h. >> >> In file included from ./include/trace/events/xdp.h:10:0, >> from

Re: [PATCH v2 25/35] nds32: Build infrastructure

Hi Arnd, On Wed, Nov 29, 2017 at 9:58 AM, Arnd Bergmann wrote: > On Wed, Nov 29, 2017 at 9:39 AM, Greentime Hu wrote: >> 2017-11-27 22:21 GMT+08:00 Arnd Bergmann : >>> On Mon, Nov 27, 2017 at 1:28 PM, Greentime Hu wrote:

Re: [PATCH v2 25/35] nds32: Build infrastructure

On Wed, Nov 29, 2017 at 10:10 AM, Geert Uytterhoeven wrote: > Hi Arnd, > > On Wed, Nov 29, 2017 at 9:58 AM, Arnd Bergmann wrote: >> On Wed, Nov 29, 2017 at 9:39 AM, Greentime Hu wrote: >>> 2017-11-27 22:21 GMT+08:00 Arnd Bergmann

[PATCH net v2] tipc: call tipc_rcv() only if bearer is up in tipc_udp_recv()

Remove the second tipc_rcv() call in tipc_udp_recv(). We have just checked that the bearer is not up, and calling tipc_rcv() with a bearer that is not up leads to a TIPC div-by-zero crash in tipc_node_calculate_timer(). The crash is rare in practice, but can happen like this: We're enabling a

Re: [PATCH net v2 00/10] bpf: offload: check netdev pointer in the drivers and namespace trouble

Wed, Nov 29, 2017 at 09:18:29AM CET, j...@resnulli.us wrote: >Tue, Nov 21, 2017 at 01:25:56AM CET, dan...@iogearbox.net wrote: >>On 11/21/2017 12:21 AM, Jakub Kicinski wrote: >>> Hi! >>> >>> This series addresses some late comments and moves checking if program >>> has been loaded for the correct

RE: [PATCH V11 4/5] vsprintf: add printk specifier %px

From: Linus Torvalds > Sent: 29 November 2017 02:29 > > On Tue, Nov 28, 2017 at 6:05 PM, Tobin C. Harding wrote: > > > >Let's add specifier %px as a > > clear, opt-in, way to print a pointer and maintain some level of > > isolation from all the other hex integer output within

[BUG] kernel stack corruption during/after Netlabel error

I'm seeing a kernel stack corruption bug (detected via gcc) when running the SELinux testsuite on a 4.15-rc1 kernel, in the 2nd inet_socket test: https://github.com/SELinuxProject/selinux-testsuite/blob/master/tests/inet_socket/test # Verify that unauthorized client cannot communicate with

[PATCH] ethernet: dwmac-stm32: Fix copyright

Uniformize STMicroelectronics copyrights header Signed-off-by: Benjamin Gaignard CC: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v2 19/35] nds32: L2 cache support

Hi, Arnd: 2017-11-27 22:33 GMT+08:00 Arnd Bergmann : > On Mon, Nov 27, 2017 at 1:28 PM, Greentime Hu wrote: >> + >> +#define L2C_R_REG(offset) __raw_readl(atl2c_base + offset) >> +#define L2C_W_REG(offset, value)__raw_writel(value,

Re: [PATCH V11 2/5] vsprintf: refactor %pK code out of pointer()

On Wed, 29 Nov 2017 15:27:46 +1100 "Tobin C. Harding" wrote: > On Tue, Nov 28, 2017 at 09:39:57PM -0500, Steven Rostedt wrote: > > On Wed, 29 Nov 2017 13:05:02 +1100 > > "Tobin C. Harding" wrote: > > > > > + /* > > > + * kptr_restrict==1 cannot

Re: [Patch net] xfrm: check id proto in validate_tmpl()

On Mon, Nov 27, 2017 at 11:15:16AM -0800, Cong Wang wrote: > syzbot reported a kernel warning in xfrm_state_fini(), which > indicates that we have entries left in the list > net->xfrm.state_all whose proto is zero. And > xfrm_id_proto_match() doesn't consider them as a match with > IPSEC_PROTO_ANY

[PATCH] [RFC v4] packet: experimental support for 64-bit timestamps

As I noticed in my previous patch to remove the 'timespec' usage in the packet socket, the timestamps in the packet socket are slightly inefficient as they convert a nanosecond value into seconds/nanoseconds or seconds/microseconds. This adds two new socket options for the timestamp to resolve

Re: [PATCH v2 25/35] nds32: Build infrastructure

2017-11-29 19:57 GMT+08:00 Arnd Bergmann : > On Wed, Nov 29, 2017 at 12:39 PM, Greentime Hu wrote: >> 2017-11-29 17:25 GMT+08:00 Arnd Bergmann : >>> On Wed, Nov 29, 2017 at 10:10 AM, Geert Uytterhoeven >>> wrote: Hi

[RFC PATCH] net_sched: bulk free tcf_block

Currently deleting qdisc with a large number of children and filters can take a lot of time: tc qdisc add dev lo root htb for I in `seq 1 1000`; do tc class add dev lo parent 1: classid 1:$I htb rate 100kbit tc qdisc add dev lo parent 1:$I handle $((I + 1)): htb for J in

Re: [PATCH] trace/xdp: fix compile warning: ‘struct bpf_map’ declared inside parameter list

On Wed, 29 Nov 2017 13:49:01 + David Laight wrote: > From: Xie XiuQi > > Sent: 29 November 2017 08:35 > > > > We meet this compile warning, which caused by missing bpf.h in xdp.h. > > > > In file included from ./include/trace/events/xdp.h:10:0, > >

Re: [PATCH net-next] vmxnet3: increase default rx ring sizes

From: Shrikrishna Khare Date: Tue, 28 Nov 2017 13:12:04 -0800 > We often notice rx packet drops due to small default rx ring sizes and > solve the problem by increasing the ring sizes. This patch increases the > default rx ring sizes thereby reducing the probability of rx

[PATCH net,stable v2] vhost: fix skb leak in handle_rx()

From: Wei Xu Matthew found a roughly 40% tcp throughput regression with commit c67df11f(vhost_net: try batch dequing from skb array) as discussed in the following thread: https://www.mail-archive.com/netdev@vger.kernel.org/msg187936.html Eventually we figured out that it was a

Re: [PATCH] net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bit

On 29.11.2017 11:01, Geert Uytterhoeven wrote: > On 64-bit (e.g. powerpc64/allmodconfig): > > drivers/net/ethernet/xilinx/ll_temac_main.c: In function > 'temac_start_xmit_done': > drivers/net/ethernet/xilinx/ll_temac_main.c:633:22: warning: cast to > pointer from integer of different

Re: [BUG] kernel stack corruption during/after Netlabel error

On Wed, Nov 29, 2017 at 2:26 AM, James Morris wrote: > I'm seeing a kernel stack corruption bug (detected via gcc) when running > the SELinux testsuite on a 4.15-rc1 kernel, in the 2nd inet_socket test: > >

[PATCH] net: via: via-rhine: use %p to format void * address instead of %x

From: Colin Ian King Don't use %x and casting to print out an address, instead use %p and remove the casting. Cleans up smatch warnings: drivers/net/ethernet/via/via-rhine.c:998 rhine_init_one_common() warn: argument 4 to %lx specifier is cast from pointer

Re: [PATCH v4 0/8] Cavium OCTEON-III network driver.

The net-next tree is closed, please resubmit this when the net-next tree opens again. Thank you.

Re: [PATCH net] myri10ge: Update MAINTAINERS

From: Hyong-Youb Kim Date: Wed, 29 Nov 2017 00:03:50 -0500 > Change the maintainer to Chris Lee who has access to Myricom hardware > and can test/review. Update the website URL. > > Signed-off-by: Hyong-Youb Kim Applied, thank you.

Re: [PATCH v2 25/35] nds32: Build infrastructure

On Wed, Nov 29, 2017 at 12:39 PM, Greentime Hu wrote: > 2017-11-29 17:25 GMT+08:00 Arnd Bergmann : >> On Wed, Nov 29, 2017 at 10:10 AM, Geert Uytterhoeven >> wrote: >>> Hi Arnd, >>> >>> On Wed, Nov 29, 2017 at 9:58 AM, Arnd Bergmann

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

On Wed, Nov 29, 2017 at 04:00:01PM +0530, Souptick Joarder wrote: Hi Souptick Please trim the code when giving reviews. We don't want to have to page through 8K lines of code it find a few comments mixed in. Just keep the beginning of the function you are commented on to make the context clear.

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

From: Alan Cox Date: Wed, 29 Nov 2017 13:46:12 + > I really don't care what the module loading rules end up with and > whether we add CAP_SYS_YET_ANOTHER_MEANINGLESS_FLAG but what is > actually needed is to properly incorporate it into securiy ruiles > for

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

On Wed, Nov 29, 2017 at 10:02:40AM +0100, Corentin Labbe wrote: > On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote: > > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote: > > > The driver expect "allwinner,leds-active-low" to be in PHY node, but > > > the binding doc expect

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

On Wed, Nov 29, 2017 at 4:00 PM, Souptick Joarder wrote: > On Wed, Nov 29, 2017 at 6:25 AM, David Daney wrote: >> From: Carlos Munoz >> >> The Cavium OCTEON cn78xx and cn73xx SoCs have network packet I/O >> hardware that is

Re: [PATCH] ethernet: dwmac-stm32: Fix copyright

From: Benjamin Gaignard Date: Wed, 29 Nov 2017 15:20:00 +0100 > Uniformize STMicroelectronics copyrights header > > Signed-off-by: Benjamin Gaignard Applied.

Re: [PATCH v2 27/35] irqchip: Andestech Internal Vector Interrupt Controller driver

Hi, Marc: 2017-11-28 17:37 GMT+08:00 Marc Zyngier : > On 27/11/17 12:28, Greentime Hu wrote: >> +static void ativic32_ack_irq(struct irq_data *data) >> +{ >> + __nds32__mtsr_dsb(1 << data->hwirq, NDS32_SR_INT_PEND2); > > Consider writing (1 << data->hwirq) as

[PATCH net 3/3] rxrpc: Fix variable overwrite

From: Gustavo A. R. Silva Values assigned to both variable resend_at and ack_at are overwritten before they can be used. The correct fix here is to add 'now' to the previously computed value in resend_at and ack_at. Addresses-Coverity-ID: 1462262 Addresses-Coverity-ID:

[PATCH v3 36/36] net/mvpp2: Replace tasklet with softirq hrtimer

From: Thomas Gleixner The tx_done_tasklet tasklet is used in invoke the hrtimer (mvpp2_hr_timer_cb) in softirq context. This can be also achieved without the tasklet but with HRTIMER_MODE_SOFT as hrtimer mode. Signed-off-by: Thomas Gleixner

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

On Wed, Nov 29, 2017 at 04:37:12PM +0100, Andrew Lunn wrote: > On Wed, Nov 29, 2017 at 10:02:40AM +0100, Corentin Labbe wrote: > > On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote: > > > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote: > > > > The driver expect

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

From: Theodore Ts'o Date: Wed, 29 Nov 2017 10:54:06 -0500 > On Wed, Nov 29, 2017 at 09:50:14AM -0500, David Miller wrote: >> From: Alan Cox >> Date: Wed, 29 Nov 2017 13:46:12 + >> >> > I really don't care what the module loading rules end up with

Re: [PATCH] net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bit

From: Geert Uytterhoeven Date: Wed, 29 Nov 2017 11:01:09 +0100 > On 64-bit (e.g. powerpc64/allmodconfig): > > drivers/net/ethernet/xilinx/ll_temac_main.c: In function > 'temac_start_xmit_done': > drivers/net/ethernet/xilinx/ll_temac_main.c:633:22: warning: cast

Re: [PATCH net,stable v2] vhost: fix skb leak in handle_rx()

On 2017年11月29日 22:23, w...@redhat.com wrote: From: Wei Xu Matthew found a roughly 40% tcp throughput regression with commit c67df11f(vhost_net: try batch dequing from skb array) as discussed in the following thread:

[PATCH net-next 0/3] rxrpc: Fixes

/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-fixes Tagged thusly: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-fixes-20171129 David --- David Howells (2): rxrpc: Clean up whitespace rxrpc: Fix ACK generation from the connection event processor

[PATCH net 2/3] rxrpc: Fix ACK generation from the connection event processor

Repeat terminal ACKs and now terminal ACKs are now generated from the connection event processor rather from call handling as this allows us to discard client call structures as soon as possible and free up the channel for a follow on call. However, in ACKs so generated, the additional

[PATCH net 1/3] rxrpc: Clean up whitespace

Clean up some whitespace from rxrpc. Signed-off-by: David Howells --- net/rxrpc/call_event.c |2 +- net/rxrpc/conn_object.c |2 +- net/rxrpc/input.c |4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/rxrpc/call_event.c

[PATCH] Documentation: net: dsa: Cut set_addr() documentation

This is not supported anymore, devices needing a MAC address just assign one at random, it's just a driver pecularity. Signed-off-by: Linus Walleij --- Documentation/networking/dsa/dsa.txt | 5 - 1 file changed, 5 deletions(-) diff --git

[GIT] Networking

There is a small overlapping conflict to net/rxrpc/call_object.c, it should be easy to resolve. In your tree there was a setup_timer() --> timer_setup() conversion, and in my tree there are new lines adding a lockdep_set_class() call right beforehand. 1) The forcedeth conversion from pci_*()

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

Hi ChenYu > It worked at one point. During some previous iteration, they lit up as > they were supposed to. For a released version of the kernel? Or during development work? If they did work, but broken, it would be good to know which commit broke it. We can then add a fixes: tag to the patch

Re: [PATCH 3/4] RFC: net: dsa: Add bindings for Realtek SMI DSAs

> I have the phy-handle in the ethernet controller. This RTL8366RB > thing is just one big PHY as far as I know. Hi Linus We don't model switches as PHYs. They are their own device type. And the internal or external PHYs are just normal PHYs in the linux model. Meaning their interrupt

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

On Wed, Nov 29, 2017 at 09:50:14AM -0500, David Miller wrote: > From: Alan Cox > Date: Wed, 29 Nov 2017 13:46:12 + > > > I really don't care what the module loading rules end up with and > > whether we add CAP_SYS_YET_ANOTHER_MEANINGLESS_FLAG but what is > >

Re: [PATCH] ethernet: dwmac-stm32: Fix copyright

On 11/29/2017 03:20 PM, Benjamin Gaignard wrote: Uniformize STMicroelectronics copyrights header Signed-off-by: Benjamin Gaignard CC: Alexandre Torgue --- drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 4 ++-- 1 file changed, 2

Re: [PATCH net,stable v2] vhost: fix skb leak in handle_rx()

On Wed, Nov 29, 2017 at 09:23:24AM -0500, w...@redhat.com wrote: > From: Wei Xu > > Matthew found a roughly 40% tcp throughput regression with commit > c67df11f(vhost_net: try batch dequing from skb array) as discussed > in the following thread: >

[PATCH v3 32/36] xfrm: Replace hrtimer tasklet with softirq hrtimer

From: Thomas Gleixner Switch the timer to HRTIMER_MODE_SOFT, which executed the timer callback in softirq context and remove the hrtimer_tasklet. Signed-off-by: Thomas Gleixner Signed-off-by: Anna-Maria Gleixner Cc: Steffen

Re: [PATCH net-next 0/3] rxrpc: Fixes

ther than ignoring it. > > The patches can be found here also: > > > http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-fixes > > Tagged thusly: > > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git >

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

On Wed, Nov 29, 2017 at 11:37 PM, Andrew Lunn wrote: > On Wed, Nov 29, 2017 at 10:02:40AM +0100, Corentin Labbe wrote: >> On Tue, Nov 28, 2017 at 06:38:26PM +0100, Andrew Lunn wrote: >> > On Tue, Nov 28, 2017 at 05:48:22PM +0100, Corentin Labbe wrote: >> > > The driver expect

Re: [PATCH] Documentation: net: dsa: Cut set_addr() documentation

On Wed, Nov 29, 2017 at 04:34:38PM +0100, Linus Walleij wrote: > This is not supported anymore, devices needing a MAC address > just assign one at random, it's just a driver pecularity. > > Signed-off-by: Linus Walleij Hi Linus It is normal to put the tree, net-next

Re: [PATCH] net: stmmac: dwmac-sun8i: fix allwinner,leds-active-low handling

On Wed, Nov 29, 2017 at 11:46 PM, Andrew Lunn wrote: > Hi ChenYu > >> It worked at one point. During some previous iteration, they lit up as >> they were supposed to. > > For a released version of the kernel? Or during development work? If > they did work, but broken, it would be

Re: [PATCH] net: via: via-rhine: use %p to format void * address instead of %x

From: Colin King Date: Wed, 29 Nov 2017 14:11:49 + > From: Colin Ian King > > Don't use %x and casting to print out an address, instead use %p > and remove the casting. Cleans up smatch warnings: > >

Re: [PATCHv2 2/2] userns: control capabilities of some user namespaces

Quoting Mahesh Bandewar (महेश बंडेवार) (mahe...@google.com): > On Tue, Nov 28, 2017 at 3:04 PM, Serge E. Hallyn wrote: > > Quoting Mahesh Bandewar (महेश बंडेवार) (mahe...@google.com): > > ... > >> >> diff --git a/security/commoncap.c b/security/commoncap.c > >> >> index

Re: [PATCH net v2 00/10] bpf: offload: check netdev pointer in the drivers and namespace trouble

On 11/29/2017 09:52 AM, Jiri Pirko wrote: > Wed, Nov 29, 2017 at 09:18:29AM CET, j...@resnulli.us wrote: >> Tue, Nov 21, 2017 at 01:25:56AM CET, dan...@iogearbox.net wrote: >>> On 11/21/2017 12:21 AM, Jakub Kicinski wrote: Hi! This series addresses some late comments and moves

Re: [PATCH net-next 0/3] rxrpc: Fixes

David Miller wrote: > This email says "net-next", yet your patches say "net". Sorry about that - it should be 'net'. I copied an old cover note. All the patches have a macro substitution, but the cover note does not. Do you want me to repost? David

[iproute PATCH] man: tc-csum.8: Fix inconsistency in example description

Commit 6bbe5e6290db5 ("man: tc-csum.8: Fix example") changed both source and destination IP addresses in example code but missed to update the example's description accordingly. Fixes: 6bbe5e6290db5 ("man: tc-csum.8: Fix example") Signed-off-by: Phil Sutter --- man/man8/tc-csum.8 |

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

On Wed, Nov 29, 2017 at 10:58:16AM -0500, David Miller wrote: > That's not what we're talking about. > > We're talking about making sure that loading "ppp.ko" really gets > ppp.ko rather than some_other_module.ko renamed to ppp.ko via some > other mechanism. Right, and the best solution to this

[PATCH ipsec] xfrm: fix XFRMA_OUTPUT_MARK policy entry

This seems to be an obvious typo, NLA_U32 is type of the attribute, not its (minimal) length. Fixes: 077fbac405bf ("net: xfrm: support setting an output mark.") Signed-off-by: Michal Kubecek --- net/xfrm/xfrm_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [BUG] kernel stack corruption during/after Netlabel error

On Wed, 2017-11-29 at 21:26 +1100, James Morris wrote: > I'm seeing a kernel stack corruption bug (detected via gcc) when > running  > the SELinux testsuite on a 4.15-rc1 kernel, in the 2nd inet_socket > test: > > https://github.com/SELinuxProject/selinux-testsuite/blob/master/tests >

[BUG] net/sched: use after free

Hi Running the following script twice gave me a KASAN splat on net tree, (this is on commit f6454f80e8a965fca203dab28723f68ec78db608 ) ETH=eth0 tc qdisc del dev $ETH ingress 2>/dev/null tc qdisc add dev $ETH ingress tc filter add dev eth0 parent : \    matchall action sample

Re: [PATCH 4/4] selinux: Add SCTP support

Hi Richard, Thank you for the patch! Yet something to improve: [auto build test ERROR on security/next] [cannot apply to net-next/master net/master v4.15-rc1 next-20171129] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Fw: [Bug 198025] New: : hw csum failure

Looks like a virtio bug Begin forwarded message: Date: Wed, 29 Nov 2017 08:16:45 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 198025] New: : hw csum failure https://bugzilla.kernel.org/show_bug.cgi?id=198025 Bug ID: 198025

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

On Wed, Nov 29, 2017 at 09:37:15PM +0530, Souptick Joarder wrote: > >> +static int bgx_port_sgmii_set_link_speed(struct bgx_port_priv *priv, > >> struct port_status status) > >> +{ > >> + u64 data; > >> + u64 prtx; > >> + u64 miscx; > >> + int timeout; > >>

[PATCH v3] net: sched: crash on blocks with goto chain action

tcf_block_put_ext has assumed that all filters (and thus their goto actions) are destroyed in RCU callback and so can not race with our list iteration. However, that is not true during netns cleanup (see tcf_exts_get_net comment). The assumption was broken by the patch series

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

On 11/29/2017 08:07 AM, Souptick Joarder wrote: On Wed, Nov 29, 2017 at 4:00 PM, Souptick Joarder wrote: On Wed, Nov 29, 2017 at 6:25 AM, David Daney wrote: From: Carlos Munoz The Cavium OCTEON cn78xx and cn73xx SoCs have

Re: [BUG] kernel stack corruption during/after Netlabel error

On Wed, Nov 29, 2017 at 12:34 PM, Eric Dumazet wrote: > On Wed, Nov 29, 2017 at 9:31 AM, Stephen Smalley wrote: >> On Wed, 2017-11-29 at 21:26 +1100, James Morris wrote: >>> I'm seeing a kernel stack corruption bug (detected via gcc) when >>> running >>>

Re: [PATCH 11/17] cls_bpf: Convert to use idr_alloc_u32

On Tue, Nov 28, 2017 at 05:08:40PM -0800, Jakub Kicinski wrote: > On Tue, 28 Nov 2017 13:33:06 -0800, Matthew Wilcox wrote: > > + ret = idr_alloc_u32(>handle_idr, prog, , > > + INT_MAX, GFP_KERNEL); > > + } else if (!oldprog) { > > +

Re: [PATCH 11/17] cls_bpf: Convert to use idr_alloc_u32

From: Matthew Wilcox Date: Wed, 29 Nov 2017 08:29:16 -0800 > On Tue, Nov 28, 2017 at 05:08:40PM -0800, Jakub Kicinski wrote: >> On Tue, 28 Nov 2017 13:33:06 -0800, Matthew Wilcox wrote: >> > + ret = idr_alloc_u32(>handle_idr, prog, , >> > +

Re: [PATCH] [RFC v3] packet: experimental support for 64-bit timestamps

> Thanks for the review! Any suggestions for how to do the testing? If you have > existing test cases, could you give my next version a test run to see if there > are any regressions and if the timestamps work as expected? > > I see that there are test cases in tools/testing/selftests/net/, but

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

Quoting Theodore Ts'o (ty...@mit.edu): > Half the problem here is that with containers, people are changing the > security model, because they want to let untrusted users have "root", > without really having "root". Part of the fundamental problem is that > there are some well-meaning, but

Re: fec driver and two micrel phys

> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-January/314706.html > > { > phy-mode = "rmii"; > phy-handle = <>; > pinctrl-names = "default"; > pinctrl-0 = <_pins_a>; > phy-reset-gpios = < 13 0>; > phy-reset-duration = <100>; > status =

Re: [RFC PATCH] net_sched: bulk free tcf_block

On Wed, Nov 29, 2017 at 6:25 AM, Paolo Abeni wrote: > Currently deleting qdisc with a large number of children and filters > can take a lot of time: > > tc qdisc add dev lo root htb > for I in `seq 1 1000`; do > tc class add dev lo parent 1: classid 1:$I htb rate

Re: [PATCH v7 1/5] add infrastructure for tagging functions as error injectable

On 11/28/2017 09:02 PM, Josef Bacik wrote: > On Tue, Nov 28, 2017 at 11:58:41AM -0700, Jonathan Corbet wrote: >> On Wed, 22 Nov 2017 16:23:30 -0500 >> Josef Bacik wrote: >>> From: Josef Bacik >>> >>> Using BPF we can override kprob'ed functions and return

Re: [PATCH 3/4] RFC: net: dsa: Add bindings for Realtek SMI DSAs

On Mon, Nov 6, 2017 at 12:48 AM, Andrew Lunn wrote: >> This interrupt construction is similar to how we handle >> interrupt controllers inside PCI bridges etc. > > Hi Linus > > Your interrupt handling is going in the right direction, but needs > further work. The PHY interrupt is

Re: [PATCH] [RFC v3] packet: experimental support for 64-bit timestamps

On Tue, Nov 28, 2017 at 11:28 PM, Willem de Bruijn wrote: > On Tue, Nov 28, 2017 at 3:32 PM, Arnd Bergmann wrote: >> As I noticed in my previous patch to remove the 'timespec' usage in >> the packet socket, the timestamps in the packet socket are

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

On Tue, 28 Nov 2017 13:39:58 -0800 Kees Cook wrote: > On Tue, Nov 28, 2017 at 1:16 PM, Luis R. Rodriguez wrote: > > And *all* auto-loading uses aliases? What's the difference between > > auto-loading > > and direct-loading? > > The difference is the

Re: [BUG] kernel stack corruption during/after Netlabel error

On Wed, Nov 29, 2017 at 9:31 AM, Stephen Smalley wrote: > On Wed, 2017-11-29 at 21:26 +1100, James Morris wrote: >> I'm seeing a kernel stack corruption bug (detected via gcc) when >> running >> the SELinux testsuite on a 4.15-rc1 kernel, in the 2nd inet_socket >> test: >> >>

Re: [PATCH V11 4/5] vsprintf: add printk specifier %px

On Wed, Nov 29, 2017 at 2:07 AM, David Laight wrote: > From: Linus Torvalds >> Sent: 29 November 2017 02:29 >> >> On Tue, Nov 28, 2017 at 6:05 PM, Tobin C. Harding wrote: >> > >> >Let's add specifier %px as a >> > clear, opt-in, way to print a pointer

RE: [PATCH V11 4/5] vsprintf: add printk specifier %px

> -Original Message- > From: keesc...@google.com [mailto:keesc...@google.com] On Behalf Of Kees > Cook > Sent: Wednesday, November 29, 2017 2:28 PM > To: David Laight > Cc: Linus Torvalds ; Tobin C. Harding > ;

Re: [PATCH V11 4/5] vsprintf: add printk specifier %px

On Wed, Nov 29, 2017 at 2:28 PM, Kees Cook wrote: > > In the future, maybe we could have a knob: unhashed, hashed (default), > or zeroed. I haven't actually seen a case for that yet. Let's see if there are actually any debug issues at all, and how big they are before

RE: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect

The attached p21 patch doesn't change anything. But another one from the mail-text is good void phylink_disconnect_phy(struct phylink *pl) + pl->phy_state.link = false; There still (not for my MRVL-PP2) problem: It is expected that on ifconfig-down the

Re: [PATCH 3/4] RFC: net: dsa: Add bindings for Realtek SMI DSAs

Hi Linus > Just that the PHYs are on the MDIO bus inside the switch, of > course. I think the problem might be, you are using the DSA provided MDIO bus. The Marvell switches has a similar setup in terms of interrupts. The PHY interrupts appear within the switch. So i implemented an interrupt

Re: Sending 802.1Q packets using AF_PACKET socket on filtered bridge forwards with wrong MAC addresses

I narrowed the search to a memmove() called from skb_reorder_vlan_header() in net/core/skbuff.c. > memmove(skb->data - ETH_HLEN, skb->data - skb->mac_len - VLAN_HLEN, >2 * ETH_ALEN); Calling skb_reset_mac_len() after skb_reset_mac_header() before calling br_allowed_ingress() in

Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.

On Wed, Nov 29, 2017 at 10:11:38PM +0300, Dan Carpenter wrote: > On Wed, Nov 29, 2017 at 09:37:15PM +0530, Souptick Joarder wrote: > > >> +static int bgx_port_sgmii_set_link_speed(struct bgx_port_priv *priv, > > >> struct port_status status) > > >> +{ > > >> + u64 data; > > >> +

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

On Wed, Nov 29, 2017 at 7:58 AM, David Miller wrote: > > We're talking about making sure that loading "ppp.ko" really gets > ppp.ko rather than some_other_module.ko renamed to ppp.ko via some > other mechanism. > > Both modules have legitimate signatures so the kernel will

Re: [PATCH 1/2] net: phy: core: use genphy version of callbacks read_status and config_aneg per default

From: Heiner Kallweit Date: Wed, 29 Nov 2017 21:47:16 +0100 > Am 15.11.2017 um 22:56 schrieb Florian Fainelli: >> On 11/15/2017 01:42 PM, Heiner Kallweit wrote: >>> read_status and config_aneg are the only mandatory callbacks and most >>> of the time the generic

Re: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect

On Wed, Nov 29, 2017 at 09:06:56PM +, Yan Markman wrote: > The attached p21 patch doesn't change anything. > But another one from the mail-text is good > void phylink_disconnect_phy(struct phylink *pl) > + pl->phy_state.link = false; > > There still (not for my

Re: [PATCH 3/4] RFC: net: dsa: Add bindings for Realtek SMI DSAs

On Wed, Nov 29, 2017 at 4:56 PM, Andrew Lunn wrote: >> I have the phy-handle in the ethernet controller. This RTL8366RB >> thing is just one big PHY as far as I know. > > We don't model switches as PHYs. They are their own device type. And > the internal or external PHYs are just

Re: [PATCH 3/4] RFC: net: dsa: Add bindings for Realtek SMI DSAs

On 11/29/2017 01:28 PM, Linus Walleij wrote: > On Wed, Nov 29, 2017 at 4:56 PM, Andrew Lunn wrote: >>> I have the phy-handle in the ethernet controller. This RTL8366RB >>> thing is just one big PHY as far as I know. >> >> We don't model switches as PHYs. They are their own device

Re: [PATCH v5 next 1/5] modules:capabilities: add request_module_cap()

On Wed, Nov 29, 2017 at 11:28:52AM -0600, Serge E. Hallyn wrote: > > Just to be clear, module loading requires - and must always continue to > require - CAP_SYS_MODULE against the initial user namespace. Containers > in user namespaces do not have that. > > I don't believe anyone has ever

Re: KASAN: use-after-free Read in sock_release

On Wed, Nov 29, 2017 at 11:37:04AM -0800, Cong Wang wrote: > > Allocated by task 31066: > > save_stack+0x43/0xd0 mm/kasan/kasan.c:447 > > set_track mm/kasan/kasan.c:459 [inline] > > kasan_kmalloc+0xad/0xe0 mm/kasan/kasan.c:551 > > kmem_cache_alloc_trace+0x136/0x750 mm/slab.c:3613 > > kmalloc

  1   2   >