Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Jiri Pirko
Wed, Feb 21, 2018 at 05:49:49PM CET, alexander.du...@gmail.com wrote: >On Wed, Feb 21, 2018 at 8:11 AM, Jiri Pirko wrote: >> Wed, Feb 21, 2018 at 04:56:48PM CET, alexander.du...@gmail.com wrote: >>>On Wed, Feb 21, 2018 at 1:51 AM, Jiri Pirko wrote: Tue,

Re: [PATCH net-next] cxgb4: append firmware dump to vmcore in kernel panic

2018-02-21 Thread Rahul Lakkireddy
On Tuesday, February 02/20/18, 2018 at 17:04:20 -0800, Jakub Kicinski wrote: > On Tue, 20 Feb 2018 16:51:03 -0800, Florian Fainelli wrote: > > On 02/20/2018 04:43 PM, Jakub Kicinski wrote: > > > On Mon, 19 Feb 2018 18:04:17 +0530, Rahul Lakkireddy wrote: > > >> Our requirement is to analyze the

Re: [PATCH net] tcp_bbr: better deal with suboptimal GSO

2018-02-21 Thread Paolo Abeni
On Wed, 2018-02-21 at 07:09 -0800, Eric Dumazet wrote: > On Wed, Feb 21, 2018 at 7:01 AM, Paolo Abeni wrote: > > > > Very minor nit, why don't: > > > > return max_t(u32, bytes / mss_now, min_tso_segs); > > > > and drop the 'segs' local variable? > > Simply to ease

[PATCH] selftests/bpf: tcpbpf_kern: use in6_* macros from glibc

2018-02-21 Thread Anders Roxell
Both glibc and the kernel have in6_* macros definitions. Build fails because it picks up wrong in6_* macro from the kernel header and not the header from glibc. Fixes build error below: clang -I. -I./include/uapi -I../../../include/uapi -Wno-compare-distinct-pointer-types \ -O2

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Alexander Duyck
On Wed, Feb 21, 2018 at 8:11 AM, Jiri Pirko wrote: > Wed, Feb 21, 2018 at 04:56:48PM CET, alexander.du...@gmail.com wrote: >>On Wed, Feb 21, 2018 at 1:51 AM, Jiri Pirko wrote: >>> Tue, Feb 20, 2018 at 11:33:56PM CET, kubak...@wp.pl wrote: On Tue, 20 Feb

Re: [PATCH net] tcp: restrict F-RTO to work-around broken middle-boxes

2018-02-21 Thread Neal Cardwell
On Wed, Feb 21, 2018 at 7:38 AM, Teodor Milkov wrote: > Here they are: > > > http://vps3.avodz.org/tmp/frto-4.14.11-linux.pcap.xz - 3.3 MB/s > > http://vps3.avodz.org/tmp/frto-4.14.11-windows.pcap.xz - connection > completely froze and eventually timed out > >

[4.15-stable 1/1] uapi/if_ether.h: move __UAPI_DEF_ETHHDR libc define

2018-02-21 Thread Mark Asselstine
Please promote commit da360299b6734135a5f66d7db458dcc7801c826a [uapi/ if_ether.h: move __UAPI_DEF_ETHHDR libc define] to linux-4.15.y stable. Without this fix users of the uapi headers will run into the issue as described in the commit log. Specifically we have seen this with building ebtables.

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Jiri Pirko
Wed, Feb 21, 2018 at 04:56:48PM CET, alexander.du...@gmail.com wrote: >On Wed, Feb 21, 2018 at 1:51 AM, Jiri Pirko wrote: >> Tue, Feb 20, 2018 at 11:33:56PM CET, kubak...@wp.pl wrote: >>>On Tue, 20 Feb 2018 21:14:10 +0100, Jiri Pirko wrote: Yeah, I can see it now :( I guess

Re: [PATCH iproute2-next 1/4] ip: Use the `struct fib_rule_hdr` for rules

2018-02-21 Thread David Ahern
On 2/20/18 6:53 PM, Donald Sharp wrote: > @@ -159,7 +159,13 @@ static bool filter_nlmsg(struct nlmsghdr *n, struct > rtattr **tb, int host_len) > return false; > } > > - table = rtm_get_table(r, tb); > + > + /* struct fib_rule_hdr and struct rtmsg > + *

Re: [PATCH iproute2-next v2] ip: link_gre6.c: Support IP6_TNL_F_ALLOW_LOCAL_REMOTE flag

2018-02-21 Thread Petr Machata
Serhey Popovych writes: > Petr Machata wrote: >> For IP-in-IP tunnels, one can specify the [no]allow-localremote command >> when configuring a device. Under the hood, this flips the >> IP6_TNL_F_ALLOW_LOCAL_REMOTE flag on the netdevice. However, ip6gretap >> and

Re: [PATCH v7 02/37] asm-generic/io.h: move ioremap_nocache/ioremap_uc/ioremap_wc/ioremap_wt out of ifndef CONFIG_MMU

2018-02-21 Thread Greentime Hu
2018-02-16 18:47 GMT+08:00 kbuild test robot : > Hi Greentime, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [also build test ERROR on v4.16-rc1 next-20180216] > [if your patch is applied to the wrong git tree, please drop us a

Re: [PATCH RFC 0/4] net: add bpfilter

2018-02-21 Thread Florian Westphal
Pablo Neira Ayuso wrote: > On Tue, Feb 20, 2018 at 05:52:54PM -0800, Alexei Starovoitov wrote: > > On Tue, Feb 20, 2018 at 11:44:31AM +0100, Pablo Neira Ayuso wrote: > > > > > > Don't get me wrong, no software is safe from security issues, but if you > > > don't abstract

Re: [PATCH v7 03/37] sparc: io: To use the define of ioremap_[nocache|wc|wb] in asm-generic/io.h

2018-02-21 Thread Arnd Bergmann
On Wed, Feb 21, 2018 at 9:05 AM, Greentime Hu wrote: > 2018-02-14 22:43 GMT+08:00 Arnd Bergmann : >> On Tue, Feb 13, 2018 at 10:09 AM, Greentime Hu wrote: >>> A commit for the nds32 architecture bootstrap("asm-generic/io.h: move >>>

[PATCH net-next 4/5] net/smc: remove unused fields from smc structures

2018-02-21 Thread Ursula Braun
From: Karsten Graul The daddr field holds the destination IPv4 address. The field was set but never used and can be removed. The addr field was a left-over from an earlier version of non-blocking connects and can be removed. The result of the call to kernel_getpeername

[PATCH net-next 3/5] net/smc: move netinfo function to file smc_clc.c

2018-02-21 Thread Ursula Braun
From: Karsten Graul The function smc_netinfo_by_tcpsk() belongs to CLC handling. Move it to smc_clc.c and rename to smc_clc_netinfo_by_tcpsk. Signed-off-by: Karsten Graul Signed-off-by: Ursula Braun ---

[PATCH net-next 1/5] net/smc: cleanup smc_llc.h and smc_clc.h headers

2018-02-21 Thread Ursula Braun
From: Stefan Raspl Remove structures used internal only from headers. And remove an extra function parameter. Signed-off-by: Stefan Raspl Signed-off-by: Ursula Braun --- net/smc/af_smc.c | 8

[PATCH net-next 2/5] net/smc: fix structure size

2018-02-21 Thread Ursula Braun
From: Karsten Graul The struct smc_cdc_msg must be defined as packed, so the size is 44 bytes. And change the structure size check, so sizeof is checked. Signed-off-by: Karsten Graul Signed-off-by: Ursula Braun

[PATCH net-next 0/5] net/smc: fixes 2018-02-21

2018-02-21 Thread Ursula Braun
Dave, here are some smc-patches for net-next. Besides cleanups, the link id field of the LLC confirm link reply is changed to comply with RFC7609. Thanks, Ursula Karsten Graul (4): smc: fix structure size smc: move netinfo function to file smc_clc.c smc: remove unused fields from smc

[PATCH net-next 5/5] net/smc: use server link_id in confirm link reply

2018-02-21 Thread Ursula Braun
From: Karsten Graul The CONFIRM LINK reply message must contain the link_id sent by the server. And set the link_id explicitly when initializing the link. Signed-off-by: Karsten Graul Signed-off-by: Ursula Braun

Re: [PATCH RFC 3/3] netfilter: nf_tables: add BPF-based jit infrastructure

2018-02-21 Thread Pablo Neira Ayuso
Hi Alexei, On Tue, Feb 20, 2018 at 06:01:39PM -0800, Alexei Starovoitov wrote: > On Tue, Feb 20, 2018 at 11:53:55AM +0100, Pablo Neira Ayuso wrote: > > > > I'll explore how to generate eBPF code in the next patchset version. > > from the user space please... OK, let's do that, from user space

Re: [PATCH RFC 0/4] net: add bpfilter

2018-02-21 Thread Pablo Neira Ayuso
On Tue, Feb 20, 2018 at 05:52:54PM -0800, Alexei Starovoitov wrote: > On Tue, Feb 20, 2018 at 11:44:31AM +0100, Pablo Neira Ayuso wrote: > > > > Don't get me wrong, no software is safe from security issues, but if you > > don't abstract your resources in the right way, you have more chance to

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-21 Thread Denys Fedoryshchenko
It seems even rebuilding seemingly stable version triggering crashes too (but different ones) Maybe it is coincidence, and bug reproducer appeared in network same time i decided to upgrade kernel, as it happened with xt_MSS(and that bug existed for years). Deleted quoting, i added more debug

[PATCH iproute2-next v3] ip: link_gre6.c: Support IP6_TNL_F_ALLOW_LOCAL_REMOTE flag

2018-02-21 Thread Petr Machata
For IP-in-IP tunnels, one can specify the [no]allow-localremote command when configuring a device. Under the hood, this flips the IP6_TNL_F_ALLOW_LOCAL_REMOTE flag on the netdevice. However, ip6gretap and ip6erspan devices, where the flag is also relevant, are not IP-in-IP tunnels, and thus

Re: [PATCH v7 02/37] asm-generic/io.h: move ioremap_nocache/ioremap_uc/ioremap_wc/ioremap_wt out of ifndef CONFIG_MMU

2018-02-21 Thread Greentime Hu
2018-02-21 19:37 GMT+08:00 Arnd Bergmann : > On Wed, Feb 21, 2018 at 12:21 PM, Greentime Hu wrote: >> 2018-02-16 18:47 GMT+08:00 kbuild test robot : > >> >> From: Greentime Hu >> Date: Wed, 21 Feb 2018 14:21:23 +0800 >>

Re: [PATCH net] tcp: restrict F-RTO to work-around broken middle-boxes

2018-02-21 Thread Teodor Milkov
On 19.02.2018 20:05, Neal Cardwell wrote: On Mon, Feb 19, 2018 at 11:17 AM, Teodor Milkov wrote: On 19.02.2018 15:38, Neal Cardwell wrote: On Sun, Feb 18, 2018 at 4:02 PM, Teodor Milkov wrote: Hello, I've numerous reports from Windows users that after kernel

Re: [PATCH iproute2-next 4/4] ip: Add ability to flush a rule based upon protocol

2018-02-21 Thread David Ahern
On 2/20/18 6:53 PM, Donald Sharp wrote: > Add code to allow the `ip rule flush protocol XXX` > command to be accepted and properly handled. > > Additionally modify the documentation to be correct > with these changes. > > Signed-off-by: Donald Sharp > --- >

Re: [4.15-stable 1/1] uapi/if_ether.h: move __UAPI_DEF_ETHHDR libc define

2018-02-21 Thread Mark Asselstine
On Wednesday, February 21, 2018 11:25:30 AM EST David Miller wrote: > From: Mark Asselstine > Date: Wed, 21 Feb 2018 10:13:18 -0500 > > > Please promote commit da360299b6734135a5f66d7db458dcc7801c826a [uapi/ > > if_ether.h: move __UAPI_DEF_ETHHDR libc define] to

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Alexander Duyck
On Wed, Feb 21, 2018 at 8:58 AM, Jiri Pirko wrote: > Wed, Feb 21, 2018 at 05:49:49PM CET, alexander.du...@gmail.com wrote: >>On Wed, Feb 21, 2018 at 8:11 AM, Jiri Pirko wrote: >>> Wed, Feb 21, 2018 at 04:56:48PM CET, alexander.du...@gmail.com wrote: On

Re: [PATCH RFC net-next 5/7] net/ipv6: Add support for path selection using hash of 5-tuple

2018-02-21 Thread David Ahern
On 2/21/18 9:22 AM, Ido Schimmel wrote: >> +u32 rt6_multipath_hash(const struct net *net, const struct flowi6 *fl6, >> + const struct sk_buff *skb) >> { >> struct flow_keys hash_keys; >> u32 mhash; >> >> -memset(_keys, 0, sizeof(hash_keys)); >> -

Re: [4.15-stable 1/1] uapi/if_ether.h: move __UAPI_DEF_ETHHDR libc define

2018-02-21 Thread David Miller
From: Mark Asselstine Date: Wed, 21 Feb 2018 12:23:51 -0500 > On Wednesday, February 21, 2018 11:25:30 AM EST David Miller wrote: >> From: Mark Asselstine >> Date: Wed, 21 Feb 2018 10:13:18 -0500 >> >> > Please promote commit

Re: [PATCH net-next] r8169: remove not needed PHY soft reset in rtl8168e_2_hw_phy_config

2018-02-21 Thread David Miller
From: Heiner Kallweit Date: Wed, 21 Feb 2018 07:29:24 +0100 > Am 21.02.2018 um 05:27 schrieb David Miller: >> From: Heiner Kallweit >> Date: Tue, 20 Feb 2018 07:30:16 +0100 >> >>> rtl8169_init_phy() resets the PHY anyway after applying the

Re: ss issue on arm not showing UDP listening ports

2018-02-21 Thread jesse_cooper
ss utility, iproute2-ss161212 Quoting Stefano Brivio : Hi, On Wed, 21 Feb 2018 11:30:16 -0500 jesse_coo...@codeholics.com wrote: Hi, I currently had the follow issues with ss where it was not displaying the UDP listening ports.This was on: Linux 4.9.59-v7+ #1047 SMP

[PATCH net-next 5/7] net/ipv6: Add support for path selection using hash of 5-tuple

2018-02-21 Thread David Ahern
Some operators prefer IPv6 path selection to use a standard 5-tuple hash rather than just an L3 hash with the flow the label. To that end add support to IPv6 for multipath hash policy similar to bf4e0a3db97eb ("net: ipv4: add support for ECMP hash policy choice"). The default is still L3 which

[PATCH net-next 6/7] mlxsw: spectrum_router: Add support for ipv6 hash policy update

2018-02-21 Thread David Ahern
Similar to 28678f07f127d ("mlxsw: spectrum_router: Update multipath hash parameters upon netevents") for IPv4, make sure the kernel and asic are using the same hash algorithm for path selection. Signed-off-by: David Ahern ---

Re: [PATCH iproute2-next] tc: implement color output

2018-02-21 Thread David Ahern
On 2/20/18 5:39 PM, Stephen Hemminger wrote: > Implement the -color option; in this case -co is ambiguous > since it was already used for -conf. > For now this just means putting device name in color. > > Signed-off-by: Stephen Hemminger > --- > man/man8/tc.8 | 9

Re: ss issue on arm not showing UDP listening ports

2018-02-21 Thread Stefano Brivio
Hi, On Wed, 21 Feb 2018 11:30:16 -0500 jesse_coo...@codeholics.com wrote: > Hi, > > I currently had the follow issues with ss where it was not displaying > the UDP listening ports.This was on: > > Linux 4.9.59-v7+ #1047 SMP Sun Oct 29 12:19:23 GMT 2017 armv7l GNU/Linux > > ss -ul > State

Re: [patch net-next] mlxsw: spectrum_switchdev: Allow port enslavement to a VLAN-unaware bridge

2018-02-21 Thread David Ahern
On 2/20/18 12:45 AM, Jiri Pirko wrote: > From: Ido Schimmel > > Up until now we only allowed VLAN devices to be put in a VLAN-unaware > bridge, but some users need the ability to enslave physical ports as > well. > > This is achieved by mapping the port and VID 1 to the

[PATCH net-next 3/7] net/ipv6: Make rt6_multipath_hash similar to fib_multipath_hash

2018-02-21 Thread David Ahern
Make rt6_multipath_hash more of a direct parallel to fib_multipath_hash and reduce stack and overhead in the process: get_hash_from_flowi6 is just a wrapper around __get_hash_from_flowi6 with another stack allocation for flow_keys. Move setting the addresses, protocol and label into

[PATCH net-next 7/7] net: Remove unused get_hash_from_flow functions

2018-02-21 Thread David Ahern
__get_hash_from_flowi6 is still used for flowlabels, but the IPv4 variant and the wrappers to both are not used. Remove them. Signed-off-by: David Ahern --- include/net/flow.h| 15 --- net/core/flow_dissector.c | 16 2 files changed, 31

[for-next 4/7] net/mlx5: CQ hold/put API

2018-02-21 Thread Saeed Mahameed
Now as the CQ table is per EQ, add an API to hold/put CQ to be used from eq.c in downstream patch. Signed-off-by: Saeed Mahameed Reviewed-by: Gal Pressman --- drivers/net/ethernet/mellanox/mlx5/core/cq.c | 42 +---

[for-next 3/7] net/mlx5: EQ add/del CQ API

2018-02-21 Thread Saeed Mahameed
Add API to add/del CQ to/from EQs CQ table to be used in cq.c upon CQ creation/destruction, as CQ table is now private to eq.c. Signed-off-by: Saeed Mahameed Reviewed-by: Gal Pressman --- drivers/net/ethernet/mellanox/mlx5/core/cq.c | 60

[PATCH net] net: ipv4: Set addr_type in hash_keys for forwarded case

2018-02-21 Thread David Ahern
The result of the skb flow dissect is copied from keys to hash_keys to ensure only the intended data is hashed. The original L4 hash patch overlooked setting the addr_type for this case; add it. Fixes: bf4e0a3db97eb ("net: ipv4: add support for ECMP hash policy choice") Reported-by: Ido Schimmel

Re: [PATCH net] net: ipv4: Set addr_type in hash_keys for forwarded case

2018-02-21 Thread Ido Schimmel
On Wed, Feb 21, 2018 at 11:00:54AM -0800, David Ahern wrote: > The result of the skb flow dissect is copied from keys to hash_keys to > ensure only the intended data is hashed. The original L4 hash patch > overlooked setting the addr_type for this case; add it. > > Fixes: bf4e0a3db97eb ("net:

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-21 Thread Cong Wang
On Thu, Feb 15, 2018 at 11:31 AM, Guillaume Nault wrote: > On Thu, Feb 15, 2018 at 06:01:16PM +0200, Denys Fedoryshchenko wrote: >> On 2018-02-15 17:55, Guillaume Nault wrote: >> > On Thu, Feb 15, 2018 at 12:19:52PM +0200, Denys Fedoryshchenko wrote: >> > > Here we go: >> >

Re: [PATCH V3 net-next 0/5] ibmvnic: Make driver resources dynamic

2018-02-21 Thread David Miller
From: Nathan Fontenot Date: Mon, 19 Feb 2018 13:29:55 -0600 > The ibmvnic driver needs to be able to handle the number of tx/rx > sub-crqs changing during a reset of the driver. To do this several > changes need to be made. First the num_active_[tx|rx]_pools > counters

Re: [PATCH net-next] tcp: remove the hardcode in the definition of TCPF Macro

2018-02-21 Thread David Miller
From: Yafang Shao Date: Tue, 20 Feb 2018 21:28:31 +0800 > TCPF_ macro depends on the definition of TCP_ macro. > So it is better to define them with TCP_ marco. > > Signed-off-by: Yafang Shao Applied, thank you.

Re: ixgbe tuning reset when XDP is setup

2018-02-21 Thread Peter Manev
>> >> Hi, >> >> We were wondering if there is any follow up/potential solution for that? >> If there is something we could help out testing with regards to that >> - please let us know. >> >> Thank you >> >> -- >> Regards, >> Peter Manev > > We don't have a solution available for this yet.

Re: [pull request][net 00/11] Mellanox, mlx5 fixes 2018-02-20

2018-02-21 Thread David Miller
From: Saeed Mahameed Date: Tue, 20 Feb 2018 17:18:12 -0800 > The following pull request includes some fixes for the mlx5 core and > netdevice driver. > > Please pull and let me know if there's any issue. > > -stable 4.10.y: > ('net/mlx5e: Fix loopback self test when GRO is

[for-next 7/7] IB/mlx5: Implement fragmented completion queue (CQ)

2018-02-21 Thread Saeed Mahameed
From: Yonatan Cohen The current implementation of create CQ requires contiguous memory, such requirement is problematic once the memory is fragmented or the system is low in memory, it causes for failures in dma_zalloc_coherent(). This patch implements new scheme of

[PATCH v2 net-next 1/2] lan743x: Add main source files for new lan743x driver

2018-02-21 Thread Bryan Whitehead
Add main source files for new lan743x driver. Signed-off-by: Bryan Whitehead --- drivers/net/ethernet/microchip/Kconfig| 10 + drivers/net/ethernet/microchip/Makefile |3 + drivers/net/ethernet/microchip/lan743x_main.c | 2757

Re: [PATCH net] net: ipv4: Set addr_type in hash_keys for forwarded case

2018-02-21 Thread Nikolay Aleksandrov
On 21/02/18 21:00, David Ahern wrote: > The result of the skb flow dissect is copied from keys to hash_keys to > ensure only the intended data is hashed. The original L4 hash patch > overlooked setting the addr_type for this case; add it. > > Fixes: bf4e0a3db97eb ("net: ipv4: add support for ECMP

Re: [PATCH net-next 0/6] tcp: remove non GSO code

2018-02-21 Thread David Miller
From: Eric Dumazet Date: Mon, 19 Feb 2018 11:56:46 -0800 > Switching TCP to GSO mode, relying on core networking layers > to perform eventual adaptation for dumb devices was overdue. > > 1) Most TCP developments are done with TSO in mind. > 2) Less high-resolution timers

Re: [patch net-next] mlxsw: spectrum_switchdev: Allow port enslavement to a VLAN-unaware bridge

2018-02-21 Thread David Ahern
On 2/21/18 12:25 PM, Ido Schimmel wrote: >> >> and can talk to the hosts: >> # ping6 ff02::2%br0 > > Can you try ff02::1 ? same result. > >> PING ff02::2%br0(ff02::2) 56 data bytes >> 64 bytes from fe80::7efe:90ff:fee8:3a79: icmp_seq=1 ttl=64 time=0.073 ms >> 64 bytes from fe80::202:ff:fe00:2:

[PATCH net-next 0/7] net/ipv6: Add support for path selection using hash of 5-tuple

2018-02-21 Thread David Ahern
Hardware supports multipath selection using the standard L4 5-tuple instead of just L3 and the flow label. In addition, some network operators prefer IPv6 path selection to use the 5-tuple. To that end, add support to IPv6 for multipath hash policy similar to bf4e0a3db97eb ("net: ipv4: add support

Re: [patch net-next] mlxsw: spectrum_switchdev: Allow port enslavement to a VLAN-unaware bridge

2018-02-21 Thread Ido Schimmel
On Wed, Feb 21, 2018 at 11:16:35AM -0700, David Ahern wrote: > On 2/20/18 12:45 AM, Jiri Pirko wrote: > > From: Ido Schimmel > > > > Up until now we only allowed VLAN devices to be put in a VLAN-unaware > > bridge, but some users need the ability to enslave physical ports as

[PATCH net-next 1/7] net/ipv4: Pass net to fib_multipath_hash instead of fib_info

2018-02-21 Thread David Ahern
fib_multipath_hash only needs net struct to check a sysctl. Make it clear by passing net instead of fib_info. In the need this allows alignment between the ipv4 and ipv6 versions. Signed-off-by: David Ahern --- include/net/ip_fib.h | 2 +- net/ipv4/fib_semantics.c | 2 +-

Re: [PATCH net-next] tcp: remove the hardcode in the definition of TCPF Macro

2018-02-21 Thread Eric Dumazet
On Tue, 2018-02-20 at 21:28 +0800, Yafang Shao wrote: > TCPF_ macro depends on the definition of TCP_ macro. > So it is better to define them with TCP_ marco. > > Signed-off-by: Yafang Shao > --- Seems reasonable, thanks ! Reviewed-by: Eric Dumazet

[PATCH ethtool] ethtool: Add SFF 8636 date code parsing support

2018-02-21 Thread Saeed Mahameed
Parse date codes according to SFF 8636 and print them to output. ethtool -m ethX [...] Date code : 160220 Signed-off-by: Saeed Mahameed Reviewed-by: Gal Pressman --- qsfp.c | 2 ++ qsfp.h | 2 ++ 2 files changed, 4 insertions(+) diff

[PATCH net-next 2/7] net: Align ip_multipath_l3_keys and ip6_multipath_l3_keys

2018-02-21 Thread David Ahern
Symmetry is good and allows easy comparison that ipv4 and ipv6 are doing the same thing. To that end, change ip_multipath_l3_keys to set addresses at the end after the icmp compares, and move the initialization of ipv6 flow keys to rt6_multipath_hash. Signed-off-by: David Ahern

Re: [PATCH net 2/4] net/8390: Fix msg_enable patch snafu

2018-02-21 Thread David Miller
Ok I applied this series, thanks!

Re: [net PATCH 0/4] virtio_net: several bugs in XDP code for driver virtio_net

2018-02-21 Thread David Miller
From: Jesper Dangaard Brouer Date: Tue, 20 Feb 2018 14:31:59 +0100 > The virtio_net driver actually violates the original memory model of > XDP causing hard to debug crashes. Per request of John Fastabend, > instead of removing the XDP feature I'm fixing as much as possible.

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-21 Thread Denys Fedoryshchenko
On 2018-02-21 20:55, Guillaume Nault wrote: On Wed, Feb 21, 2018 at 12:26:51PM +0200, Denys Fedoryshchenko wrote: It seems even rebuilding seemingly stable version triggering crashes too (but different ones) Different ones? The trace following your message looks very similar to your first

Re: [PATCH net-next 6/7] mlxsw: spectrum_router: Add support for ipv6 hash policy update

2018-02-21 Thread Ido Schimmel
On Wed, Feb 21, 2018 at 10:49:53AM -0800, David Ahern wrote: > Similar to 28678f07f127d ("mlxsw: spectrum_router: Update multipath hash > parameters upon netevents") for IPv4, make sure the kernel and asic are > using the same hash algorithm for path selection. > > Signed-off-by: David Ahern

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Jiri Pirko
Wed, Feb 21, 2018 at 06:56:35PM CET, alexander.du...@gmail.com wrote: >On Wed, Feb 21, 2018 at 8:58 AM, Jiri Pirko wrote: >> Wed, Feb 21, 2018 at 05:49:49PM CET, alexander.du...@gmail.com wrote: >>>On Wed, Feb 21, 2018 at 8:11 AM, Jiri Pirko wrote: Wed,

[PATCH v2 net-next 0/2] lan743x: Add new lan743x driver

2018-02-21 Thread Bryan Whitehead
Add new lan743x driver. The lan743x from Microchip Technologies Inc, is a PCIe to Gigabit Ethernet Controller. Bryan Whitehead (2): lan743x: Add main source files for new lan743x driver lan743x: Update MAINTAINERS to include lan743x driver MAINTAINERS |

Re: ss issue on arm not showing UDP listening ports

2018-02-21 Thread Stefano Brivio
On Wed, 21 Feb 2018 12:37:31 -0500 jesse_coo...@codeholics.com wrote: > ss utility, iproute2-ss161212 Works for me on iproute2-ss161212 and 4.9.0 kernel on armv7l. Unless somebody on the list has other ideas, I guess you should either try more recent versions, debug it (strace should show a pair

Re: [PATCH net-next] RDS: deliver zerocopy completion notification with data as an optimization

2018-02-21 Thread Santosh Shilimkar
On 2/21/2018 12:19 PM, Sowmini Varadhan wrote: This commit is an optimization that builds on top of commit 01883eda72bd ("rds: support for zcopy completion notification") for PF_RDS sockets. Cookies associated with zerocopy completion are passed up on the POLLIN channel, piggybacked with data

[for-next 2/7] net/mlx5: Add missing likely/unlikely hints to cq events

2018-02-21 Thread Saeed Mahameed
If a hardware event is targeting a CQ, that CQ should exist. Add unlikely to error handling flows. Signed-off-by: Saeed Mahameed Reviewed-by: Gal Pressman --- drivers/net/ethernet/mellanox/mlx5/core/cq.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[pull request][for-next 0/7] Mellanox, mlx5 shared code updates 2018-02-21

2018-02-21 Thread Saeed Mahameed
Hi Dave & Doug, This series includes shared code updates for mlx5 core driver for both netdev and rdma subsystems. This series should be pulled to both trees so we can continue netdev and rdma specific submissions separately. For more information please see tag log below. P.S. We expect two

[for-next 5/7] net/mlx5: Move CQ completion and event forwarding logic to eq.c

2018-02-21 Thread Saeed Mahameed
Since CQ tree is now per EQ, CQ completion and event forwarding became specific implementation of EQ logic, this patch moves that logic to eq.c and makes those functions static. Signed-off-by: Saeed Mahameed Reviewed-by: Gal Pressman ---

[for-next 1/7] net/mlx5: CQ Database per EQ

2018-02-21 Thread Saeed Mahameed
Before this patch the driver had one CQ database protected via one spinlock, this spinlock is meant to synchronize between CQ adding/removing and CQ IRQ interrupt handling. On a system with large number of CPUs and on a work load that requires lots of interrupts, this global spinlock becomes a

Re: [PATCH net-next] ipv6: allow userspace to add IFA_F_OPTIMISTIC addresses

2018-02-21 Thread David Miller
From: Sabrina Dubroca Date: Tue, 20 Feb 2018 19:17:17 +0100 > 2018-02-20, 10:25:41 -0700, David Ahern wrote: >> On 2/20/18 9:43 AM, Sabrina Dubroca wrote: >> > According to RFC 4429 (section 3.1), adding new IPv6 addresses as >> > optimistic addresses is acceptable, as long

Re: pull-request: bpf 2018-02-20

2018-02-21 Thread David Miller
From: Daniel Borkmann Date: Tue, 20 Feb 2018 22:08:32 +0100 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: ... > Please consider pulling these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git

[PATCH net-next] RDS: deliver zerocopy completion notification with data as an optimization

2018-02-21 Thread Sowmini Varadhan
This commit is an optimization that builds on top of commit 01883eda72bd ("rds: support for zcopy completion notification") for PF_RDS sockets. Cookies associated with zerocopy completion are passed up on the POLLIN channel, piggybacked with data whereever possible. Such cookies are passed up as

Re: [patch net-next] mlxsw: spectrum_switchdev: Allow port enslavement to a VLAN-unaware bridge

2018-02-21 Thread David Ahern
On 2/21/18 1:24 PM, Ido Schimmel wrote: >>> Does it matter if you try IPv4 ping or if vlan_filtering is set 1? >>> Unfortunately, I can't reproduce on my switch. >> >> Bring up the hosts and then reboot the switch. At that point I get no >> host to host communication. As soon as I flap the port on

Re: [PATCH net] amd-xgbe: Restore PCI interrupt enablement setting on resume

2018-02-21 Thread David Miller
From: Tom Lendacky Date: Tue, 20 Feb 2018 15:22:05 -0600 > After resuming from suspend, the PCI device support must re-enable the > interrupt setting so that interrupts are actually delivered. > > Signed-off-by: Tom Lendacky > --- > > Please

Re: [patch net-next] mlxsw: spectrum_switchdev: Allow port enslavement to a VLAN-unaware bridge

2018-02-21 Thread Ido Schimmel
On Wed, Feb 21, 2018 at 12:41:39PM -0700, David Ahern wrote: > On 2/21/18 12:25 PM, Ido Schimmel wrote: > >> > >> and can talk to the hosts: > >> # ping6 ff02::2%br0 > > > > Can you try ff02::1 ? > > same result. > > > > >> PING ff02::2%br0(ff02::2) 56 data bytes > >> 64 bytes from

Re: [PATCH net-next ] ibmvnic: Correct goto target for tx irq initialization failure

2018-02-21 Thread David Miller
From: Nathan Fontenot Date: Tue, 20 Feb 2018 11:04:18 -0600 > When a failure occurs during initialization of the tx sub crq > irqs, we should branch to the cleanup of the tx irqs. The current > code branches to the rx irq cleanup and attempts to cleanup the > rx irqs

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-21 Thread Guillaume Nault
On Wed, Feb 21, 2018 at 12:26:51PM +0200, Denys Fedoryshchenko wrote: > It seems even rebuilding seemingly stable version triggering crashes too > (but different ones) Different ones? The trace following your message looks very similar to your first KASAN report. Or are you refering to the lockup

Re: ppp/pppoe, still panic 4.15.3 in ppp_push

2018-02-21 Thread Guillaume Nault
On Sun, Feb 18, 2018 at 12:01:02PM +0200, Denys Fedoryshchenko wrote: > On 2018-02-16 20:48, Guillaume Nault wrote: > > On Fri, Feb 16, 2018 at 01:13:18PM +0200, Denys Fedoryshchenko wrote: > > > As far as i can see there is only KASAN triggered again(and server > > > rebooted > > > shortly after

Re: [PATCH net-next,v3] net: sched: add em_ipt ematch for calling xtables matches

2018-02-21 Thread David Miller
From: Eyal Birger Date: Thu, 15 Feb 2018 19:42:43 +0200 > The commit a new tc ematch for using netfilter xtable matches. > > This allows early classification as well as mirroning/redirecting traffic > based on logic implemented in netfilter extensions. > > Current

[for-next 6/7] net/mlx5: Remove redundant EQ API exports

2018-02-21 Thread Saeed Mahameed
EQ structure and API is private to mlx5_core driver only, external drivers should not have access or the means to manipulate EQ objects. Remove redundant exports and move API functions out of the linux/mlx5 include directory into the driver's mlx5_core.h private include file. Signed-off-by:

Re: Qualcomm rmnet driver and qmi_wwan

2018-02-21 Thread Subash Abhinov Kasiviswanathan
On 2018-02-21 04:38, Daniele Palmas wrote: Hello, in rmnet kernel documentation I read: "This driver can be used to register onto any physical network device in IP mode. Physical transports include USB, HSIC, PCIe and IP accelerator." Does this mean that it can be used in association with

Re: [PATCH V7 2/4] sctp: Add ip option support

2018-02-21 Thread Paul Moore
On February 21, 2018 9:33:51 AM Marcelo Ricardo Leitner wrote: > On Tue, Feb 20, 2018 at 07:15:27PM +, Richard Haines wrote: >> Add ip option support to allow LSM security modules to utilise CIPSO/IPv4 >> and CALIPSO/IPv6 services. >> >> Signed-off-by: Richard

Re: [RFC PATCH v3 0/3] Enable virtio_net to act as a backup for a passthru device

2018-02-21 Thread Alexander Duyck
On Wed, Feb 21, 2018 at 11:38 AM, Jiri Pirko wrote: > Wed, Feb 21, 2018 at 06:56:35PM CET, alexander.du...@gmail.com wrote: >>On Wed, Feb 21, 2018 at 8:58 AM, Jiri Pirko wrote: >>> Wed, Feb 21, 2018 at 05:49:49PM CET, alexander.du...@gmail.com wrote: On

Possible iputils infrastructure/hosting issue on skbuff.net

2018-02-21 Thread Graph Worlok
http://www.skbuff.net/iputils/ has a list of source tarball releases. All of these releases reference http://www.skbuff.net/iputils/iputils-current.tar.bz2 as the location to obtain the source. This URL 404's, meaning that most linux systems in existence refer to a unavailable URL for the source

[PATCH] selftests/bpf: update gitignore with test_libbpf_open

2018-02-21 Thread Anders Roxell
bpf builds a test program for loading BPF ELF files. Add the executable to the .gitignore list. Signed-off-by: Anders Roxell --- tools/testing/selftests/bpf/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/bpf/.gitignore

Re: [PATCH 00/19] Netfilter fixes for net

2018-02-21 Thread David Miller
From: Pablo Neira Ayuso Date: Tue, 20 Feb 2018 17:38:47 +0100 > The following patchset contains large batch with Netfilter fixes for > your net tree, mostly due to syzbot report fixups and pr_err() > ratelimiting, more specifically, they are: ... > You can pull these

Re: [PATCH] selftests/bpf: update gitignore with test_libbpf_open

2018-02-21 Thread Daniel Díaz
On 02/21/2018 03:30 PM, Anders Roxell wrote: > bpf builds a test program for loading BPF ELF files. Add the executable > to the .gitignore list. > > Signed-off-by: Anders Roxell Tested-by: Daniel Díaz > --- >

Re: [PATCH] selftests/bpf: tcpbpf_kern: use in6_* macros from glibc

2018-02-21 Thread Daniel Díaz
On 02/21/2018 10:51 AM, Anders Roxell wrote: > Both glibc and the kernel have in6_* macros definitions. Build fails > because it picks up wrong in6_* macro from the kernel header and not the > header from glibc. > > Fixes build error below: > clang -I. -I./include/uapi -I../../../include/uapi >

syzcaller patch postings...

2018-02-21 Thread David Miller
I have to mention this now before it gets out of control. I would like to ask that syzkaller stop posting the patch it is testing when it posts to netdev. This creates a lot of confusion and I have to manually change the status in patchwork of every patch syzcaller posts in this way. I would

Re: [PATCH] rds: send: mark expected switch fall-through in rds_rm_size

2018-02-21 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 19 Feb 2018 12:10:20 -0600 > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1465362 ("Missing break in switch") > Signed-off-by: Gustavo A.

<    1   2