[PATCH PATCH net v2 0/4] hv_netvsc: fix multicast flags and sync

2018-03-07 Thread Stephen Hemminger
This set of patches deals with the handling of multicast flags and addresses in transparent VF mode. The recent set of patches (in linux-net) had a couple of bugs. Stephen Hemminger (4): hv_netvsc: fix filter flags hv_netvsc: avoid repeated updates of packet filter hv_netvsc: fix locking

[PATCH PATCH net v2 2/4] hv_netvsc: avoid repeated updates of packet filter

2018-03-07 Thread Stephen Hemminger
The netvsc driver can get repeated calls to netvsc_rx_mode during network setup; each of these calls ends up scheduling the lower layers to update tha packet filter. This update requires an request/response to the host. So avoid doing this if we already know that the correct packet filter value is

[PATCH PATCH net v2 1/4] hv_netvsc: fix filter flags

2018-03-07 Thread Stephen Hemminger
The recent change to nto always enable all multicast and broadcast was broken; meant to set filter, not change flags. Fixes: 009f766ca238 ("hv_netvsc: filter multicast/broadcast") Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/rndis_filter.c | 4 ++-- 1 file

[PATCH PATCH net v2 4/4] hv_netvsc: fix locking during VF setup

2018-03-07 Thread Stephen Hemminger
The dev_uc/mc_sync calls need to have the device address list locked. This was spotted by running with lockdep enabled. Fixes: bee9d41b37ea ("hv_netvsc: propagate rx filters to VF") Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 4 1 file

Re: [RFC v3 net-next 02/18] net: Clear skb->tstamp only on the forwarding path

2018-03-07 Thread Jesus Sanchez-Palencia
On 03/07/2018 08:59 AM, Willem de Bruijn wrote: > On Tue, Mar 6, 2018 at 8:12 PM, Jesus Sanchez-Palencia > wrote: >> This is done in preparation for the upcoming time based transmission >> patchset. Now that skb->tstamp will be used to hold packet's txtime, >>

[PATCH] net: phy: Move interrupt check from phy_check to phy_interrupt

2018-03-07 Thread Brad Mouring
If multiple phys share the same interrupt (e.g. a multi-phy chip), the first device registered is the only one checked as phy_interrupt will always return IRQ_HANDLED if the first phydev is not halted. Move the interrupt check into phy_interrupt and, if it was not this phydev, return IRQ_NONE to

[RESEND PATCH 1/3 net-next] ibmvnic: Clean up device close

2018-03-07 Thread Thomas Falcon
Remove some dead code now that RX pools are being cleaned. This was included to wait until any pending RX queue interrupts are processed, but NAPI polling should be disabled by this point. Another minor change is to use the net device parameter for any print functions instead of accessing it from

[RESEND PATCH 3/3 net-next] ibmvnic: Do not disable device during failover or partition migration

2018-03-07 Thread Thomas Falcon
During a device failover or partition migration reset, it is not necessary to disable the backing adapter since it should not be running yet and its Command-Response Queue is closed. Sending device commands during this time could result in an error or timeout disrupting the reset process. In these

[RESEND PATCH 0/3 net-next] ibmvnic: Clean up net close and fix reset bug

2018-03-07 Thread Thomas Falcon
This patch set cleans up and reorganizes the driver's net_device close function and leverages that to fix up a bug that can occur during some device resets. Some reset cases require the backing adapter to be disabled before continuing, but other cases, such as during a device failover or

Re: [RFC v3 net-next 08/18] net: SO_TXTIME: Add clockid and drop_if_late params

2018-03-07 Thread Eric Dumazet
On Wed, 2018-03-07 at 13:52 -0800, Jesus Sanchez-Palencia wrote: > Hi, ... > I should have mentioned on the commit msg, but the tc_drop_if_late is > actually > filling a 1 bit hole that was already there. > > > > > > Do we really need 32 bits for a clockid_t ? > > There is a 2 bytes hole just

Re: [PATCH net-next 0/2] RDS: zerocopy code enhancements

2018-03-07 Thread David Miller
From: Sowmini Varadhan Date: Tue, 6 Mar 2018 07:22:32 -0800 > A couple of enhancements to the rds zerocop code > - patch 1 refactors rds_message_copy_from_user to pull the zcopy logic > into its own function > - patch 2 drops the usage sk_buff to track

[PATCHv2 net-next] openvswitch: fix vport packet length check.

2018-03-07 Thread William Tu
When sending a packet to a tunnel device, the dev's hard_header_len could be larger than the skb->len in function packet_length(). In the case of ip6gretap/erspan, hard_header_len = LL_MAX_HEADER + t_hlen, which is around 180, and an ARP packet sent to this tunnel has skb->len = 42. This causes

[pull request][for-next 00/11] Mellanox, mlx5 IPSec updates 2018-02-28-2 (Part 2)

2018-03-07 Thread Saeed Mahameed
Hi Dave and Doug, This series includes shared code updates (IPSec part2) for mlx5 core driver for both netdev and rdma subsystems. This series should be pulled to both trees so we can continue netdev and rdma specific submissions separately. Mainly it includes two fixes for previous pull

[for-next 01/11] net/mlx5: Use MLX5_IPSEC_DEV macro for ipsec caps

2018-03-07 Thread Saeed Mahameed
Fix build break of mlx5_accel_ipsec_device_caps is not defined when MLX5_ACCEL is not selected, use MLX5_IPSEC_DEV instead which handles such case. Signed-off-by: Saeed Mahameed Reported-by: Doug Ledford ---

[for-next 04/11] net/mlx5: IPSec, Add command V2 support

2018-03-07 Thread Saeed Mahameed
From: Aviad Yehezkel This patch adds V2 command support. New fpga devices support extended features (udp encap, esn etc...), this features require new hardware sadb format therefore we have a new version of commands to manipulate it. Signed-off-by: Yossef Efraim

Re: [PATCH] net: remove VLA usage

2018-03-07 Thread David Miller
From: Laszlo Toth Date: Thu, 8 Mar 2018 01:19:53 +0100 > Separated snmp_seq_show_tcp_udp() to tcp and udp variants, > so the usage of max_t() for the array size can be emitted. > > Signed-off-by: Laszlo Toth But it's a max on a constant value, computed at

[for-next 03/11] net/mlx5e: IPSec, Add support for ESP trailer removal by hardware

2018-03-07 Thread Saeed Mahameed
From: Yossi Kuperman Current hardware decrypts and authenticates incoming ESP packets. Subsequently, the software extracts the nexthdr field, truncates the trailer and adjusts csum accordingly. With this patch and a capable device, the trailer is being removed by the

[for-next 05/11] net/mlx5: Export ipsec capabilities

2018-03-07 Thread Saeed Mahameed
From: Aviad Yehezkel We will need that for ipsec verbs. Signed-off-by: Aviad Yehezkel Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/accel/ipsec.c | 3 +-

[for-next 09/11] net/mlx5e: Added common function for to_ipsec_sa_entry

2018-03-07 Thread Saeed Mahameed
From: Aviad Yehezkel New function for getting driver internal sa entry from xfrm state. All checks are done in one function. Signed-off-by: Aviad Yehezkel Signed-off-by: Saeed Mahameed ---

[for-next 06/11] net/mlx5: Added required metadata capability for ipsec

2018-03-07 Thread Saeed Mahameed
From: Aviad Yehezkel Currently our device requires additional metadata in packet to perform ipsec crypto offload. Signed-off-by: Aviad Yehezkel Signed-off-by: Saeed Mahameed ---

Re: [RFC v3 net-next 08/18] net: SO_TXTIME: Add clockid and drop_if_late params

2018-03-07 Thread Jesus Sanchez-Palencia
Hi, On 03/06/2018 06:53 PM, Eric Dumazet wrote: > On Tue, 2018-03-06 at 17:12 -0800, Jesus Sanchez-Palencia wrote: >> Extend SO_TXTIME APIs with new per-packet parameters: a clockid_t and >> a drop_if_late flag. With this commit the API becomes: >> >> > > * diff --git a/include/linux/skbuff.h

RE: [Intel-wired-lan] [next-queue PATCH v3 6/8] igb: Add MAC address support for ethtool nftuple filters

2018-03-07 Thread Brown, Aaron F
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > Behalf Of Vinicius Costa Gomes > Sent: Tuesday, March 6, 2018 5:30 PM > To: intel-wired-...@lists.osuosl.org > Cc: netdev@vger.kernel.org; Sanchez-Palencia, Jesus palen...@intel.com> > Subject: [Intel-wired-lan] [next-queue

Re: linux-next: manual merge of the selinux tree with the net-next tree

2018-03-07 Thread Paul Moore
On Wed, Mar 7, 2018 at 3:26 PM, David Miller wrote: > From: Paul Moore > Date: Wed, 7 Mar 2018 15:20:33 -0500 > >>> So you would only have to wait until my tree went in before >>> sending your pull request. >> >> So you would want me to rebase

[PATCH 1/3] ibmvnic: Clean up device close

2018-03-07 Thread Thomas Falcon
Remove some dead code now that RX pools are being cleaned. This was included to wait until any pending RX queue interrupts are processed, but NAPI polling should be disabled by this point. Another minor change is to use the net device parameter for any print functions instead of accessing it from

[PATCH 2/3] ibmvnic: Reorganize device close

2018-03-07 Thread Thomas Falcon
Introduce a function to halt network operations and clean up any unused or outstanding socket buffers. Then, during device close, disable backing adapter before halting all queues and performing cleanup. This ensures all backing device operations will be stopped before the driver cleans up shared

[PATCH 3/3] ibmvnic: Do not disable device during failover or partition migration

2018-03-07 Thread Thomas Falcon
During a device failover or partition migration reset, it is not necessary to disable the backing adapter since it should not be running yet and its Command-Response Queue is closed. Sending device commands during this time could result in an error or timeout disrupting the reset process. In these

[PATCH 0/3] ibmvnic: Clean up net close and fix reset bug

2018-03-07 Thread Thomas Falcon
This patch set cleans up and reorganizes the driver's net_device close function and leverages that to fix up a bug that can occur during some device resets. Some reset cases require the backing adapter to be disabled before continuing, but other cases, such as during a device failover or

Re: [PATCH net 4/5] tcp: prevent bogus undos when SACK is not enabled

2018-03-07 Thread Yuchung Cheng
On Wed, Mar 7, 2018 at 12:19 PM, Neal Cardwell wrote: > > On Wed, Mar 7, 2018 at 7:59 AM, Ilpo Järvinen > wrote: > > A bogus undo may/will trigger when the loss recovery state is > > kept until snd_una is above high_seq. If tcp_any_retrans_done >

pull-request: bpf 2018-03-08

2018-03-07 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Fix various BPF helpers which adjust the skb and its GSO information with regards to SCTP GSO. The latter is a special case where gso_size is of value GSO_BY_FRAGS, so mangling that

,Your urgent confirmation

2018-03-07 Thread James Williams
Attn: Beneficiary, We have contacted the Federal Ministry of Finance on your Behalf and they have brought a solution to your problem by coordinating your payment in total (10,000,000.00) Ten Million Dollars in an atm card which you can use to withdraw money from any ATM MACHINE CENTER anywhere in

Re: linux-next: manual merge of the selinux tree with the net-next tree

2018-03-07 Thread Stephen Rothwell
Hi all, On Mon, 5 Mar 2018 12:40:54 +1100 Stephen Rothwell wrote: > > Today's linux-next merge of the selinux tree got a conflict in: > > net/sctp/socket.c > > between several refactoring commits from the net-next tree and commit: > > 2277c7cd75e3 ("sctp: Add LSM

[PATCH net-next 17/23] {topost} net: hns3: refactor the coalesce related struct

2018-03-07 Thread Peng Li
From: Yunsheng Lin This patch refoctors the coalesce related struct by introducing the hns3_enet_coalesce struct, in order to fix the coalesce configuation lost problem when changing the channel number. Signed-off-by: Yunsheng Lin Signed-off-by:

[PATCH net-next 23/23] {topost} net: hns3: add support for VF driver inner interface hclgevf_ops.get_tqps_and_rss_info

2018-03-07 Thread Peng Li
This patch adds support for VF driver inner interface hclgevf_ops.get_tqps_and_rss_info. This interface will be used in the initialization process. Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 10 ++ 1 file changed, 10

[PATCH net-next 15/23] {topost} net: hns3: refactor the get/put_vector function

2018-03-07 Thread Peng Li
From: Yunsheng Lin There is a get_vector function, which allocate the vectors for a client, but there is not a put_vector to free the vector. This patch introduces the put_vector function in order to fix the coalesce configuration lost problem during reset process.

[PATCH net-next 20/23] {topost} net: hns3: fix for buffer overflow smatch warning

2018-03-07 Thread Peng Li
From: Yunsheng Lin This patch fixes the buffer overflow warning by refactoring hclgevf_bind_ring_to_vector and hclge_get_ring_chain_from_mbx. Fixes: e2cb1dec9779 ("net: hns3: Add HNS3 VF HCL(Hardware Compatibility Layer) Support") Fixes: dde1a86e93ca ("net: hns3: Add

[PATCH net-next 18/23] {topost} net: hns3: fix for coal configuation lost when setting the channel

2018-03-07 Thread Peng Li
From: Yunsheng Lin This patch fixes the coalesce configuation lost problem when setting the channel number by restoring all vectors's coalesce configuation to vector 0's, because all vectors belonging to the same netdev have the same coalesce configuation for now.

Please add "NFC: llcp: Limit size of SDP URI" for stable

2018-03-07 Thread Kees Cook
Hi, I don't see fe9c842695e2 ("NFC: llcp: Limit size of SDP URI") queued up for stable. Can this one be added please? This is a buffer overflow fix. Thanks! -Kees -- Kees Cook Pixel Security

[PATCH net-next 19/23] {topost} net: hns3: fix for loopback failure when vlan filter is enable

2018-03-07 Thread Peng Li
From: Yunsheng Lin When vlan ctag filter is enabled, the loopback selftest fails because loopback selftest does not support vlan. This patch fixes it by disabling the vlan ctag filter when runnig loopback selftest. Signed-off-by: Yunsheng Lin

[PATCH net-next 10/23] {topost} net: hns3: refactor the hclge_get/set_rss function

2018-03-07 Thread Peng Li
From: Yunsheng Lin This patch refactors the hclge_get/set_rss function in order to fix the rss configuration loss problem during reset process. Signed-off-by: Yunsheng Lin Signed-off-by: Peng Li ---

[PATCH net-next 09/23] {topost} net: hns3: add support for querying pfc puase packets statistic

2018-03-07 Thread Peng Li
This patch add support for querying pfc puase packets statistic in hclge_ieee_getpfc, which is used to tell user how many pfc puase packets have been sent and received by this mac port. Signed-off-by: Yunsheng Lin Signed-off-by: Peng Li ---

[PATCH net-next 03/23] {topost} net: hns3: set the cmdq out_vld bit to 0 after used

2018-03-07 Thread Peng Li
Driver check the out_vld bit when get a new cmdq BD, if the bit is 1, the BD is valid. driver Should set the bit 0 after used and hw will set the bit 1 if get a valid BD. Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c | 1 +

[PATCH 2/3] net: Remove accidental VLAs from proc buffers

2018-03-07 Thread Kees Cook
In the quest to remove all stack VLAs from the kernel[1], this refactors the stack array size calculation to avoid using max(), which makes the compiler think the size isn't fixed. [1] https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Kees Cook --- net/ipv4/proc.c | 10

[PATCH 3/3] btrfs: tree-checker: Avoid accidental stack VLA

2018-03-07 Thread Kees Cook
In the quest to remove all stack VLAs from the kernel[1], this refactors the stack array size calculation to avoid using max(), which makes the compiler think the size isn't fixed. [1] https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Kees Cook ---

[PATCH 0/3] Remove accidental VLA usage

2018-03-07 Thread Kees Cook
This series adds SIMPLE_MAX() to be used in places where a stack array is actually fixed, but the compiler still warns about VLA usage due to confusion caused by the safety checks in the max() macro. I'm sending these via -mm since that's where I've introduced SIMPLE_MAX(), and they should all

[PATCH AUTOSEL for 4.9 032/190] time: Change posix clocks ops interfaces to use timespec64

2018-03-07 Thread Sasha Levin
From: Deepa Dinamani [ Upstream commit d340266e19ddb70dbd608f9deedcfb35fdb9d419 ] struct timespec is not y2038 safe on 32 bit machines. The posix clocks apis use struct timespec directly and through struct itimerspec. Replace the posix clock interfaces to use struct

[net-next:master 178/193] drivers/net/ipvlan/ipvlan.h:183:32: sparse: incompatible types in comparison expression (different address spaces)

2018-03-07 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: a366e300ae9fc466d333e6d8f2bc5d58ed248041 commit: 1ec54cb44e6731c3cb251bcf9251d65a4b4f6306 [178/193] net: unpollute priv_flags space reproduce: # apt-get install sparse git checkout

[PATCH net-next 07/23] {topost} net: hns3: unify the pause params setup function

2018-03-07 Thread Peng Li
From: Fuyun Liang Since the firmware cmd to setup mac pause params is the same as the firmware cmd to pfc pause params, this patch unifies the pause params setup function. Signed-off-by: Fuyun Liang Signed-off-by: Peng Li

[PATCH net-next 13/23] {topost} net: hns3: fix for pause configuration lost during reset

2018-03-07 Thread Peng Li
From: Yunsheng Lin Pause configuration will be set to default value by hclge_tm_schd_init during reset, which causes the RSS configuration loss problem. This patch fixes it by calling hclge_tm_init_hw during reset process , which will set the pause configuration to

[PATCH net-next 02/23] {topost} net: hns3: add existence check when remove old uc mac address

2018-03-07 Thread Peng Li
From: Fuyun Liang When driver is in initial state, the mac_vlan table table is empty. So the delete operation for mac address must fail. Existence check is needed here. Otherwise, the error message will make user confused. Fixes: 46a3df9f9718 ("net: hns3: Add HNS3

[PATCH net-next 11/23] {topost} net: hns3: refactor the hclge_get/set_rss_tuple function

2018-03-07 Thread Peng Li
From: Yunsheng Lin This patch refactors the hclge_get/set_rss_tuple function in order to fix the rss configuration loss problem during reset process. Signed-off-by: Yunsheng Lin Signed-off-by: Peng Li ---

[PATCH net-next 08/23] {topost} net: hns3: fix rx path skb->truesize reporting bug

2018-03-07 Thread Peng Li
Original skb->truesize reports the received packet size, not the actual buffer size NIC driver allocated(1 Page). The linux net protocol will misjudge the true size of rx queue. Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 10 -- 1

[PATCH net-next 00/23] net: hns3: HNS3 bug fixes & code improvements

2018-03-07 Thread Peng Li
This patch-set introduces various HNS3 bug fixes, optimizations and code improvements. Fuyun Liang (4): {topost} net: hns3: add existence check when remove old uc mac address {topost} net: hns3: fix for netdev not running problem after calling net_stop and net_open {topost} net: hns3:

[PATCH net-next 14/23] {topost} net: hns3: fix for use-after-free when setting ring parameter

2018-03-07 Thread Peng Li
From: Yunsheng Lin In hns3_set_ringparam, hns3_uninit_all_ring frees the memory pointed by priv->ring_data[i].ring, and hns3_change_all_ring_bd_num use that pointer without mallocing, which will cause a use-after-free problem. The patch fixes it by not freeing the memory

Re: [PATCH net-next 00/23] net: hns3: HNS3 bug fixes & code improvements

2018-03-07 Thread David Miller
Sorry, this is way too large of a patch series. Please keep your series to about a dozen or so changes. Anything longer puts an unreasonable burdon upon patch reviewers, and such a large series will often make it so that nearly all reviewers are discouraged from taking a look at all. Thank

[PATCH net-next 05/23] {topost} net: hns3: fix for netdev not running problem after calling net_stop and net_open

2018-03-07 Thread Peng Li
From: Fuyun Liang The link status update function is called by timer every second. But net_stop and net_open may be called with very short intervals. The link status update function can not detect the link state has changed. It causes the netdev not running problem. This

Re: [PATCHv2 net-next] openvswitch: fix vport packet length check.

2018-03-07 Thread Pravin Shelar
On Wed, Mar 7, 2018 at 3:38 PM, William Tu wrote: > When sending a packet to a tunnel device, the dev's hard_header_len > could be larger than the skb->len in function packet_length(). > In the case of ip6gretap/erspan, hard_header_len = LL_MAX_HEADER + t_hlen, > which is

[PATCH iproute2 net-next v4] iprule: support for ip_proto, sport and dport match options

2018-03-07 Thread Roopa Prabhu
From: Roopa Prabhu add support to match on ip_proto, sport and dport ranges. For ip_proto, this patch currently enumerates, tcp, udp and sctp. This list can be extended in the future. example: $ip rule add sport 666-777 dport 999 ip_proto tcp table 100 $ip rule show

[PATCH net-next] liquidio: fix ndo_change_mtu to always return correct status to the caller

2018-03-07 Thread Felix Manlunas
From: Veerasenareddy Burru In a scenario where the command queued to firmware get dropped or times out, MTU change from host will not propagate to firmware. So, it is required for host driver to wait for response from firmware or timeout and then return correct

Re: [PATCH bpf-next 0/2] bpf: add support for bpf program to read perf event sample address

2018-03-07 Thread Daniel Borkmann
On 03/06/2018 07:55 PM, Teng Qin wrote: > These patches add support that allows bpf programs attached to perf events to > read the address values recorded with the perf events. These values are > requested by specifying sample_type with PERF_SAMPLE_ADDR when calling > perf_event_open(). > > The

[PATCH AUTOSEL for 4.4 016/101] time: Change posix clocks ops interfaces to use timespec64

2018-03-07 Thread Sasha Levin
From: Deepa Dinamani [ Upstream commit d340266e19ddb70dbd608f9deedcfb35fdb9d419 ] struct timespec is not y2038 safe on 32 bit machines. The posix clocks apis use struct timespec directly and through struct itimerspec. Replace the posix clock interfaces to use struct

Re: pull-request: bpf 2018-03-08

2018-03-07 Thread Daniel Borkmann
On 03/08/2018 02:31 AM, David Miller wrote: > From: Daniel Borkmann > Date: Thu, 8 Mar 2018 02:17:16 +0100 > >> The following pull-request contains BPF updates for your *net* tree. >> >> The main changes are: >> >> 1) Fix various BPF helpers which adjust the skb and its

[PATCH net-next 04/23] {topost} net: hns3: fix endian issue when PF get mbx message flag

2018-03-07 Thread Peng Li
This patch fixes the endian issue when PF get mbx message flag. Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH net-next 16/23] {topost} net: hns3: fix for coalesce configuration lost during reset

2018-03-07 Thread Peng Li
From: Yunsheng Lin Coalesce configuration will be set to default value by hns3_nic_init_vector_data during reset, which causes the coalesce configuration loss problem. This patch fixes it by setting the default value in hns3_nic_alloc_vector_data, which will not be

[PATCH net-next 22/23] {topost} net: hns3: set the max ring num when alloc netdev

2018-03-07 Thread Peng Li
HNS3 driver should alloc netdev with max support ring num, as driver support change netdev count by ethtool -L. Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 27 - 1 file changed, 13 insertions(+), 14 deletions(-)

[PATCH net-next 21/23] {topost} net: hns3: fix the queue id for tqp enable&

2018-03-07 Thread Peng Li
Command HCLGE_OPC_CFG_COM_TQP_QUEUE should use queue id in the function, but command HCLGE_OPC_RESET_TQP_QUEUE should use global queue id. This patch fixes the queue id about queue enable/disable/reset. Signed-off-by: Peng Li ---

[PATCH net-next 06/23] {topost} net: hns3: fix for ipv6 address loss problem after setting channels

2018-03-07 Thread Peng Li
From: Fuyun Liang The function of dev_close and dev_open is just likes ifconfig down and ifconfig up. The ipv6 address will be lost after dev_close and dev_open are called. This patch uses hns3_nic_net_stop to replace dev_close and uses hns3_nic_net_open to replace

[PATCH net-next 01/23] {topost} net: hns3: VF should get the real rss_size instead of rss_size_max

2018-03-07 Thread Peng Li
VF driver should get the real rss_size which is assigned by host PF, not rss_size_max. Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net-next 12/23] {topost} net: hns3: fix for RSS configuration loss problem during reset

2018-03-07 Thread Peng Li
From: Yunsheng Lin RSS configuration will be set to default value by hclge_rss_init_hw during reset, which causes the RSS configuration loss problem. This patch fixes it by setting the default value in hclge_rss_init_cfg function, which will not be called in the reset

[PATCH v2 1/3] vsprintf: Remove accidental VLA usage

2018-03-07 Thread Kees Cook
In the quest to remove all stack VLAs from the kernel[1], this introduces a new "simple max" macro, and changes the "sym" array size calculation to use it. The value is actually a fixed size, but since the max() macro uses some extensive tricks for safety, it ends up looking like a variable size

[PATCH net-next] liquidio: Resolved mbox read issue while reading more than one 64bit data

2018-03-07 Thread Felix Manlunas
From: Intiyaz Basha Corrected length check when data received in the mbox is more than one 64 bit data value Signed-off-by: Intiyaz Basha Signed-off-by: Felix Manlunas ---

[PATCH net-next] liquidio: avoid doing useless work

2018-03-07 Thread Felix Manlunas
From: Prasad Kanneganti Avoid doing useless work by making sure that the response_list is not empty before scheduling work to process it. Signed-off-by: Prasad Kanneganti Signed-off-by: Felix Manlunas ---

Re: [bpf-next V1 PATCH 09/15] mlx5: register a memory model when XDP is enabled

2018-03-07 Thread Jesper Dangaard Brouer
On Wed, 7 Mar 2018 13:50:19 +0200 Tariq Toukan wrote: > On 06/03/2018 11:48 PM, Jesper Dangaard Brouer wrote: > > Now all the users of ndo_xdp_xmit have been converted to use > > xdp_return_frame. > > This enable a different memory model, thus activating another code path >

Re: [PATCH] net: xfrm: use preempt-safe this_cpu_read() in ipcomp_alloc_tfms()

2018-03-07 Thread Herbert Xu
On Wed, Mar 07, 2018 at 11:24:16AM -0800, Greg Hackmann wrote: > f7c83bcbfaf5 ("net: xfrm: use __this_cpu_read per-cpu helper") added a > __this_cpu_read() call inside ipcomp_alloc_tfms(). Since this call was > introduced, the rules around per-cpu accessors have been tightened and >

Re: [PATCH V3 net] qed: Free RoCE ILT Memory on rmmod qedr

2018-03-07 Thread David Miller
From: Michal Kalderon Date: Mon, 5 Mar 2018 23:50:46 +0200 > Rdma requires ILT Memory to be allocated for it's QPs. > Each ILT entry points to a page used by several Rdma QPs. > To avoid allocating all the memory in advance, the rdma > implementation dynamically

Re: [PATCH] tipc: bcast: use true and false for boolean values

2018-03-07 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 5 Mar 2018 15:56:14 -0600 > Assign true or false to boolean variables instead of an integer value. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Applied.

Re: [PATCH net-next] dt-bindings: net: dsa: marvell: describe compatibility string

2018-03-07 Thread David Miller
From: Brandon Streiff Date: Mon, 5 Mar 2018 16:05:22 -0600 > There are two compatibility strings for mv88e6xxx, but it isn't clear > from the documentation why only those two exist when the mv88e6xxx driver > supports more than the 6085 and 6190. Briefly describe how the

Re: [PATCH] ipv6: ndisc: use true and false for boolean values

2018-03-07 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 5 Mar 2018 16:11:54 -0600 > Assign true or false to boolean variables instead of an integer value. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Applied,

Re: [PATCH net-next 2/4] net: stmmac: use correct barrier between coherent memory and MMIO

2018-03-07 Thread Niklas Cassel
On Wed, Mar 07, 2018 at 10:32:26AM -0500, David Miller wrote: > From: Niklas Cassel > Date: Sat, 3 Mar 2018 00:28:53 +0100 > > > However, the last write we do is "DMA start transmission", > > this is a register in the IP, i.e. it is a write to the cache > > incoherent

Re: [RFC PATCH linux-next] net: mvpp2: mvpp2_check_hw_buf_num() can be static

2018-03-07 Thread David Miller
From: kbuild test robot Date: Tue, 6 Mar 2018 13:05:06 +0800 > Fixes: effbf5f58d64 ("net: mvpp2: update the BM buffer free/destroy logic") > Signed-off-by: Fengguang Wu Applied.

Re: [PATCH v3.18] net: fec: introduce fec_ptp_stop and use in probe fail path

2018-03-07 Thread Greg Kroah-Hartman
On Tue, Mar 06, 2018 at 03:23:23PM -0800, Guenter Roeck wrote: > From: Lucas Stach > > [ upstream commit 32cba57ba74be58589aeb4cb6496183e46a5e3e5 ] > > This function frees resources and cancels delayed work item that > have been initialized in fec_ptp_init(). > > Use

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

2018-03-07 Thread David Miller
From: Alexei Starovoitov Date: Mon, 5 Mar 2018 17:34:57 -0800 > As the first step in development of bpfilter project [1] the > request_module() code is extended to allow user mode helpers to be > invoked. Looks like there is a little bit of feedback requiring changes, please

Re: [PATCH] net: qcom/emac: Use proper free methods during TX

2018-03-07 Thread David Miller
From: Hemanth Puranik Date: Tue, 6 Mar 2018 08:18:06 +0530 > This patch fixes the warning messages/call traces seen if DMA debug is > enabled, In case of fragmented skb's memory was allocated using > dma_map_page but freed using dma_unmap_single. This patch modifies

Re: [PATCH] cxgb3: remove VLA

2018-03-07 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 5 Mar 2018 23:39:34 -0600 > In preparation to enabling -Wvla, remove VLA and replace it > with dynamic memory allocation. > > Signed-off-by: Gustavo A. R. Silva All of these lengths are limited by the

Re: [PATCH net-next] selftests/net: fix in_netns.sh script

2018-03-07 Thread David Miller
From: Prashant Bhole Date: Tue, 6 Mar 2018 17:31:32 +0900 > execute the subprocess in netns using 'ip netns exec' > > Fixes: cc30c93fa020 ("selftests/net: ignore background traffic in > psock_fanout") > Signed-off-by: Prashant Bhole

Re: linux-next: manual merge of the selinux tree with the net-next tree

2018-03-07 Thread Paul Moore
On Wed, Mar 7, 2018 at 11:41 AM, David Miller wrote: > From: Paul Moore > Date: Wed, 7 Mar 2018 11:34:31 -0500 >> On Mon, Mar 5, 2018 at 2:03 AM, Xin Long wrote: >>> On Mon, Mar 5, 2018 at 9:40 AM, Stephen Rothwell

Re: [PATCH v3 net-next 2/5] net/ipv6: Address checks need to consider the L3 domain

2018-03-07 Thread David Ahern
On 3/7/18 4:53 AM, Kirill Tkhai wrote: >> diff --git a/include/net/addrconf.h b/include/net/addrconf.h >> index c4185a7b0e90..132e5b95167a 100644 >> --- a/include/net/addrconf.h >> +++ b/include/net/addrconf.h >> @@ -69,8 +69,8 @@ int addrconf_set_dstaddr(struct net *net, void __user >> *arg); >>

Re: [PATCH v2 net-next 0/2] net: phy: remove phy_error from phy_disable_interrupts

2018-03-07 Thread David Miller
From: Heiner Kallweit Date: Mon, 5 Mar 2018 22:29:43 +0100 > All callers of phy_disable_interrupts() call phy_error() in the error > case. Therefore we don't need to do this within the function too. > This change also allows us to use phy_disable_interrupts() in code >

Re: [RFC v3 net-next 08/18] net: SO_TXTIME: Add clockid and drop_if_late params

2018-03-07 Thread Richard Cochran
On Wed, Mar 07, 2018 at 12:01:19PM -0500, Willem de Bruijn wrote: > The same choices are probably made for all packets on a given > socket. Unless skb->sk gets scrubbed in some transmit paths, > then these be set as sockopt instead of cmsg. The discussion on v2 ended with this per-message idea,

Re: [RFC v3 net-next 08/18] net: SO_TXTIME: Add clockid and drop_if_late params

2018-03-07 Thread Richard Cochran
On Wed, Mar 07, 2018 at 09:35:24AM -0800, Richard Cochran wrote: > The discussion on v2 ended with this per-message idea, in preference > to the per-socket idea, IIRC. (But my own opinion is that per-socket is good enough...) Thanks, Richard

Re: [PATCH net-next] net: unpollute priv_flags space

2018-03-07 Thread David Miller
From: Paolo Abeni Date: Tue, 6 Mar 2018 10:56:31 +0100 > the ipvlan device driver defines and uses 2 bits inside the priv_flags > net_device field. Such bits and the related helper are used only > inside the ipvlan device driver, and the core networking does not > need to be

Re: [PATCH net-next] net: phy: mdio-mux: slience probe defer error

2018-03-07 Thread David Miller
From: Jerome Brunet Date: Tue, 6 Mar 2018 12:10:45 +0100 > If we fail to register the mdio bus due to probe defer, we should not > print an error message. Just be silent in this case. > > Signed-off-by: Jerome Brunet Applied, thanks Jerome.

Re: [PATCH net-next 2/4] net: stmmac: use correct barrier between coherent memory and MMIO

2018-03-07 Thread David Miller
From: Niklas Cassel Date: Wed, 7 Mar 2018 18:21:57 +0100 > Considering this, you can drop/revert: > 95eb930a40a0 ("net: stmmac: use correct barrier between coherent memory and > MMIO") > or perhaps you want me to send a revert? You must submit explicit patches to do a

[PATCH net-next] sock: Fix SO_ZEROCOPY switch case

2018-03-07 Thread Jesus Sanchez-Palencia
Fix the SO_ZEROCOPY switch case on sock_setsockopt() avoiding the ret values to be overwritten by the one set on the default case. Fixes: 28190752c7092 ("sock: permit SO_ZEROCOPY on PF_RDS socket") Signed-off-by: Jesus Sanchez-Palencia Acked-by: Willem de Bruijn

Re: linux-next: manual merge of the selinux tree with the net-next tree

2018-03-07 Thread David Miller
From: Paul Moore Date: Wed, 7 Mar 2018 12:27:52 -0500 > I'm not sure we could have cleanly separated the core network stack > changes from the rest of the SELinux/SCTP enablement, regardless it's > a bit late at this point. The only other thought would have been to > simply

Re: [RFC v3 net-next 08/18] net: SO_TXTIME: Add clockid and drop_if_late params

2018-03-07 Thread Eric Dumazet
On Wed, Mar 7, 2018 at 9:37 AM, Richard Cochran wrote: > On Wed, Mar 07, 2018 at 09:35:24AM -0800, Richard Cochran wrote: >> The discussion on v2 ended with this per-message idea, in preference >> to the per-socket idea, IIRC. > > (But my own opinion is that per-socket

Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available

2018-03-07 Thread Alexander Duyck
On Tue, Mar 6, 2018 at 6:38 PM, Michael S. Tsirkin wrote: > On Tue, Mar 06, 2018 at 03:27:46PM -0800, Alexander Duyck wrote: >> > I definitelly vote for a separate common shared code for both netvsc and >> > virtio_net - even if you use 2 and 3 netdev model, you could share the

Re: [PATCH net-next] net/mlx4_en: try to use high order pages for RX rings

2018-03-07 Thread Tariq Toukan
On 06/03/2018 9:12 PM, Eric Dumazet wrote: From: Eric Dumazet RX rings can fit most of the time in a contiguous piece of memory, so lets use kvzalloc_node/kvfree instead of vzalloc_node/vfree Note that kvzalloc_node() automatically falls back to another node, there is no

Re: [PATCH RESEND net-next] net: Do synchronize_rcu() in ip6mr_sk_done() only if this is needed

2018-03-07 Thread Kirill Tkhai
On 06.03.2018 19:50, Eric Dumazet wrote: > On Tue, 2018-03-06 at 19:24 +0300, Kirill Tkhai wrote: >> After unshare test kworker hangs for ages: >> >> $ while :; do unshare -n true; done & >> >> $ perf report >> -   88,82% 0,00%  kworker/u16:0  [kernel.vmlinux]  [k] >> cleanup_net

[PATCH net-next 1/2] net: kalmia: clean up bind error path

2018-03-07 Thread Johan Hovold
Drop bogus call to usb_driver_release_interface() from an error path in the usbnet bind() callback, which is called during interface probe. At this point the interface is not bound and usb_driver_release_interface() returns early. Also remove the bogus call to clear the interface data, which is

Re: [PATCH v9 crypto 01/12] tls: tls_device struct to register TLS drivers

2018-03-07 Thread Sabrina Dubroca
Hello Atul, One quick note before you start replying: please fix your email client, as you've been told before. Quoting has to add a quoting marker (the '>' character) at the beginning of the line, otherwise it's impossible to separate your reply from the email you're quoting. 2018-03-06,

<    1   2   3   4   >