Re: [Intel-wired-lan] [PATCH 12/15] ice: Add stats and ethtool support

On Tue, 13 Mar 2018 12:17:10 -0700 Eric Dumazet wrote: > > Yes, this is a recurring mistake > > See commit > bf909456f6a89654cb65c01fe83a4f9b133bf978 Revert "net: hns3: Add packet > statistics of netdev" Thanks for the pointer, that was a useful thread to review. I

Re: [PATCH v2 iproute2-next 0/6] cm_id, cq, mr, and pd resource tracking

On Tue, Mar 13, 2018 at 01:45:12PM -0700, David Ahern wrote: > On 3/13/18 1:32 AM, Leon Romanovsky wrote: > > On Mon, Mar 12, 2018 at 10:53:03AM -0700, David Ahern wrote: > >> On 3/12/18 8:16 AM, Steve Wise wrote: > >>> Hey all, > >>> > >>> The kernel side of this series has been merged for

Re: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

On Mon, 12 Mar 2018 21:28:57 -0700 Kees Cook wrote: > On Mon, Mar 12, 2018 at 4:57 PM, Linus Torvalds > wrote: > > On Mon, Mar 12, 2018 at 3:55 PM, Andrew Morton > > wrote: > >> > >> Replacing the

Re: [RESEND] rsi: Remove stack VLA usage

On Tue, Mar 13, 2018 at 10:17 PM, tcharding wrote: > On Mon, Mar 12, 2018 at 09:46:06AM +, Kalle Valo wrote: >> tcharding wrote: I'm pretty much sure it depends on the original email headers, like above ^^^ — no name. Perhaps git config on your side should be

[PATCH] pktgen: use dynamic allocation for debug print buffer

After the removal of the VLA, we get a harmless warning about a large stack frame: net/core/pktgen.c: In function 'pktgen_if_write': net/core/pktgen.c:1710:1: error: the frame size of 1076 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] The function was previously shown to be safe

Re: [PATCH v2 iproute2-next 0/6] cm_id, cq, mr, and pd resource tracking

On Tue, 2018-03-13 at 13:45 -0700, David Ahern wrote: > On 3/13/18 1:32 AM, Leon Romanovsky wrote: > > On Mon, Mar 12, 2018 at 10:53:03AM -0700, David Ahern wrote: > > > On 3/12/18 8:16 AM, Steve Wise wrote: > > > > Hey all, > > > > > > > > The kernel side of this series has been merged for

Re: [PATCH 12/15] ice: Add stats and ethtool support

From: "Venkataramanan, Anirudh" Date: Tue, 13 Mar 2018 19:05:19 + > Thanks for the feedback. I am not sure I understand what's being asked > here. Do you mean to say that standard netdev stats should not be > printed when we do ethtool -S or something else?

[PATCH v2 net 1/1] net sched actions: return explicit error when tunnel_key mode is not specified

If set/unset mode of the tunnel_key action is not provided, ->init() still returns 0, and the caller proceeds with bogus 'struct tc_action *' object, this results in crash: % tc actions add action tunnel_key src_ip 1.1.1.1 dst_ip 2.2.2.1 id 7 index 1 [ 35.805515] general protection fault:

Re: linux-next: build warning after merge of the net-next tree

On 03/13/2018 10:33 AM, David Miller wrote: From: "Gustavo A. R. Silva" Date: Tue, 13 Mar 2018 06:46:24 -0500 Hi Stephen, On 03/13/2018 01:11 AM, Stephen Rothwell wrote: Hi all, After merging the net-next tree, today's linux-next build (sparc defconfig) produced

Re: [PATCH v2 iproute2-next 0/6] cm_id, cq, mr, and pd resource tracking

On 3/13/18 1:32 AM, Leon Romanovsky wrote: > On Mon, Mar 12, 2018 at 10:53:03AM -0700, David Ahern wrote: >> On 3/12/18 8:16 AM, Steve Wise wrote: >>> Hey all, >>> >>> The kernel side of this series has been merged for rdma-next [1]. Let me >>> know if this iproute2 series can be merged, of if it

Re: [PATCH 12/15] ice: Add stats and ethtool support

On Sat, 2018-03-10 at 08:42 -0800, Stephen Hemminger wrote: > On Fri, 9 Mar 2018 09:21:33 -0800 > Anirudh Venkataramanan wrote: > > > + /* VSI stats */ > > + struct rtnl_link_stats64 net_stats; > > + struct rtnl_link_stats64 net_stats_prev; > > + struct

[PATCH net-next 1/2] selftests/txtimestamp: Add more configurable parameters

Add a way to configure if poll() should wait forever for an event, the number of packets that should be sent for each and if there should be any delay between packets. Signed-off-by: Vinicius Costa Gomes --- .../selftests/networking/timestamping/txtimestamp.c | 21

[PATCH net-next 0/2] skbuff: Fix applications not being woken for errors

Hi, Changes from the RFC: - tweaked commit messages; Original cover letter: This is actually a "bug report"-RFC instead of the more usual "new feature"-RFC. We are developing an application that uses TX hardware timestamping to make some measurements, and during development Randy Witt

[PATCH net-next 2/2] skbuff: Fix not waking applications when errors are enqueued

When errors are enqueued to the error queue via sock_queue_err_skb() function, it is possible that the waiting application is not notified. Calling 'sk->sk_data_ready()' would not notify applications that selected only POLLERR events in poll() (for example). Reported-by: Randy E. Witt

[PATCH iproute2] treat "default" and "all"/"any" parameters differenty

Debian maintainer found that basic command: # ip route flush all No longer worked as expected which breaks user scripts and expectations. It no longer flushed all IPv4 routes. Recently behaviour of "default" prefix parameter was corrected. But at the same time behaviour of "all"/"any"

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

Hi, I just realized that you need patch for v4.15.0, which is easier to do. I'll send it as separate message now. I will make patch for the master branch, but later. On 13.03.2018 13:02, Luca Boccassi wrote: On Tue, 2018-03-13 at 12:05 +0100, Alexander Zubkov wrote: Hello again, The fun

Re: [RESEND] rsi: Remove stack VLA usage

On Mon, Mar 12, 2018 at 09:46:06AM +, Kalle Valo wrote: > tcharding wrote: > > > The kernel would like to have all stack VLA usage removed[1]. rsi uses > > a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size > > is defined using a magic number. We can

Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"

On Tue, 2018-03-13 at 21:12 +0100, Alexander Zubkov wrote: > Hi, > > I just realized that you need patch for v4.15.0, which is easier to > do. > I'll send it as separate message now. I will make patch for the > master  > branch, but later. Thanks but don't worry about 4.15 - Stephen's revert

Re: [RESEND PATCH] rsi: Remove stack VLA usage

On Sun, Mar 11, 2018 at 09:06:10PM -0500, Larry Finger wrote: > On 03/11/2018 08:43 PM, Tobin C. Harding wrote: > >The kernel would like to have all stack VLA usage removed[1]. rsi uses > >a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size > >is defined using a magic number.

Re: [PATCH] net: dsa: drop some VLAs in switch.c

On 03/13/2018 12:58 PM, Vivien Didelot wrote: > Hi Salvatore, > > Salvatore Mesoraca writes: > >> dsa_switch's num_ports is currently fixed to DSA_MAX_PORTS. So we avoid >> 2 VLAs[1] by using DSA_MAX_PORTS instead of ds->num_ports. >> >> [1]

Re: [PATCH] net: dsa: drop some VLAs in switch.c

Hi Salvatore, Salvatore Mesoraca writes: > dsa_switch's num_ports is currently fixed to DSA_MAX_PORTS. So we avoid > 2 VLAs[1] by using DSA_MAX_PORTS instead of ds->num_ports. > > [1] https://lkml.org/lkml/2018/3/7/621 > > Signed-off-by: Salvatore Mesoraca

[PATCH net 2/2] vmxnet3: use correct flag to indicate LRO feature

'Commit 45dac1d6ea04 ("vmxnet3: Changes for vmxnet3 adapter version 2 (fwd)")' introduced a flag "lro" in structure vmxnet3_adapter which is used to indicate whether LRO is enabled or not. However, the patch did not set the flag and hence it was never exercised. So, when LRO is enabled, it

[PATCH net 1/2] vmxnet3: avoid xmit reset due to a race in vmxnet3

The field txNumDeferred is used by the driver to keep track of the number of packets it has pushed to the emulation. The driver increments it on pushing the packet to the emulation and the emulation resets it to 0 at the end of the transmit. There is a possibility of a race either when (a) ESX is

Re: [pull request][for-next 00/11] Mellanox, mlx5 IPSec updates 2018-02-28-2 (Part 2)

On Mon, 2018-03-12 at 21:43 -0400, Doug Ledford wrote: > On Mon, 2018-03-12 at 21:43 +, Saeed Mahameed wrote: > > On Thu, 2018-03-08 at 14:14 -0500, Doug Ledford wrote: > > > On 3/8/2018 1:04 PM, David Miller wrote: > > > > From: Saeed Mahameed > > > > Date: Wed, 7 Mar

[PATCH] net: dsa: drop some VLAs in switch.c

dsa_switch's num_ports is currently fixed to DSA_MAX_PORTS. So we avoid 2 VLAs[1] by using DSA_MAX_PORTS instead of ds->num_ports. [1] https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Salvatore Mesoraca --- net/dsa/switch.c | 4 ++-- 1 file changed, 2 insertions(+), 2

RE: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

> On Tue, Feb 27, 2018 at 08:07:05AM -0800, Steve Wise wrote: > > Sample output: > > > > # rdma resource > > 2: cxgb4_0: pd 5 cq 2 qp 2 cm_id 3 mr 7 > > 3: mlx4_0: pd 7 cq 3 qp 3 cm_id 3 mr 7 > > > > # rdma resource show cm_id > > link cxgb4_0/- lqpn 0 qp-type RC state LISTEN ps TCP pid 30485 comm

Copy of: 注册送28，精彩娱乐，从这开始。

This is a copy of the following message you sent to via Mechron FZE This is an enquiry email via http://www.mechronfze.ae/ from: 狄郁扈 AG真人： www.3330823.com/? 创新玩法·尊贵体验！让您尽情畅玩，赢钱倍加有趣。 办理会员送28元，首存赠送388元，存款享1%(起）优惠。天天至尊返水1.2%无上限。 晋升VIP尽享奢华·专属待遇·惊喜不断！24小时存提款，3分钟火速到账。

Re: [PATCH] hv_netvsc: Make sure out channel is fully opened on send

On Tue, 13 Mar 2018 20:06:50 +0100 Mohammed Gamal wrote: > Dring high network traffic changes to network interface parameters > such as number of channels or MTU can cause a kernel panic with a NULL > pointer dereference. This is due to netvsc_device_remove() being > called

[PATCH net-next] enic: drop IP proto check for vxlan tunnel delete

Commit d11790941dd3 ("enic: Add vxlan offload support for IPv6 pkts") added vxlan offload support for IPv6 pkts. Required change in enic_udp_tunnel_del was not made. This creates a bug where once user adds IPv6 tunnel, hw offload for that cannot be deleted. This patch removes check for IP proto

[PATCH net-next] doc: remove out of date links and info from packet mmap

The packet_mmap documentation had links to no longer existing web sites; replace with other site which has similar example. Support for packet mmap has been in mainline versions of libpcap for several years. Signed-off-by: Stephen Hemminger ---

Re: [PATCH 12/15] ice: Add stats and ethtool support

On 03/13/2018 12:05 PM, Venkataramanan, Anirudh wrote: On Fri, 2018-03-09 at 15:14 -0800, Jakub Kicinski wrote: On Fri, 9 Mar 2018 09:21:33 -0800, Anirudh Venkataramanan wrote: +static const struct ice_stats ice_net_stats[] = { + ICE_NETDEV_STAT(rx_packets), +

[PATCH] hv_netvsc: Make sure out channel is fully opened on send

Dring high network traffic changes to network interface parameters such as number of channels or MTU can cause a kernel panic with a NULL pointer dereference. This is due to netvsc_device_remove() being called and deallocating the channel ring buffers, which can then be accessed by

Re: [PATCH v2 iproute2-next 6/6] rdma: Add PD resource tracking information

On Tue, Feb 27, 2018 at 08:07:23AM -0800, Steve Wise wrote: > Sample output: > > Without CAP_NET_ADMIN capability: > > link mlx4_0/- users 0 pid 0 comm [ib_srpt] > link mlx4_0/- users 0 pid 0 comm [ib_srp] > link mlx4_0/- users 1 pid 0 comm [ib_core] > link cxgb4_0/- users 0 pid 0 comm [ib_srp] >

Re: [PATCH 12/15] ice: Add stats and ethtool support

On Fri, 2018-03-09 at 15:14 -0800, Jakub Kicinski wrote: > On Fri, 9 Mar 2018 09:21:33 -0800, Anirudh Venkataramanan wrote: > > +static const struct ice_stats ice_net_stats[] = { > > + ICE_NETDEV_STAT(rx_packets), > > + ICE_NETDEV_STAT(tx_packets), > > + ICE_NETDEV_STAT(rx_bytes), > > +

Re: [PATCH v2 iproute2-next 5/6] rdma: Add MR resource tracking information

On Tue, Feb 27, 2018 at 08:07:17AM -0800, Steve Wise wrote: > Sample output: > > Without CAP_NET_ADMIN: > > $ rdma resource show mr mrlen 65536 > link mlx4_0/- mrlen 65536 pid 0 comm [nvme_rdma] > link cxgb4_0/- mrlen 65536 pid 0 comm [nvme_rdma] > > With CAP_NET_ADMIN: > > # rdma resource show mr

Re: [PATCH v2 iproute2-next 4/6] rdma: Add CQ resource tracking information

On Tue, Feb 27, 2018 at 08:07:11AM -0800, Steve Wise wrote: > Sample output: > > # rdma resource show cq > link cxgb4_0/- cqe 46 users 2 pid 30503 comm rping > link cxgb4_0/- cqe 46 users 2 pid 30498 comm rping > link mlx4_0/- cqe 63 users 2 pid 30494 comm rping > link mlx4_0/- cqe 63 users 2 pid

[PATCH v2 net] kcm: lock lower socket in kcm_attach

Need to lock lower socket in order to provide mutual exclusion with kcm_unattach. v2: Add Reported-by for syzbot Fixes: ab7ac4eb9832e32a09f4e804 ("kcm: Kernel Connection Multiplexor module") Reported-by: syzbot+ea75c0ffcd353d32515f064aaebefc5279e61...@syzkaller.appspotmail.com Signed-off-by:

Re: [bug, bisected] pfifo_fast causes packet reordering

On Tue, Mar 13, 2018 at 11:24 AM, Jakob Unterwurzacher wrote: > During stress-testing our "ucan" USB/CAN adapter SocketCAN driver on Linux > v4.16-rc4-383-ged58d66f60b3 we observed that a small fraction of packets are > delivered out-of-order. > > We

[bug, bisected] pfifo_fast causes packet reordering

During stress-testing our "ucan" USB/CAN adapter SocketCAN driver on Linux v4.16-rc4-383-ged58d66f60b3 we observed that a small fraction of packets are delivered out-of-order. We have tracked the problem down to the driver interface level, and it seems that the driver's

Re: [PATCH net-next] net: fix sysctl_fb_tunnels_only_for_init_net link error

From: Arnd Bergmann Date: Tue, 13 Mar 2018 12:44:53 +0100 > The new variable is only available when CONFIG_SYSCTL is enabled, > otherwise we get a link error: > > net/ipv4/ip_tunnel.o: In function `ip_tunnel_init_net': > ip_tunnel.c:(.text+0x278b): undefined reference to >

Re: [PATCH v2 iproute2-next 2/6] rdma: initialize the rd struct

On Tue, Feb 27, 2018 at 08:07:00AM -0800, Steve Wise wrote: > Initialize the rd struct so port_idx is 0 unless set otherwise. > Otherwise, strict_port queries end up passing an uninitialized PORT > nlattr. > > Signed-off-by: Steve Wise > --- > rdma/rdma.c | 2 +- > 1

Re: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information

On Tue, Feb 27, 2018 at 08:07:05AM -0800, Steve Wise wrote: > Sample output: > > # rdma resource > 2: cxgb4_0: pd 5 cq 2 qp 2 cm_id 3 mr 7 > 3: mlx4_0: pd 7 cq 3 qp 3 cm_id 3 mr 7 > > # rdma resource show cm_id > link cxgb4_0/- lqpn 0 qp-type RC state LISTEN ps TCP pid 30485 comm rping > src-addr

Re: [RFC PATCH v0 2/2] skbuff: Notify errors with sk_error_report()

On 03/13/2018 10:20 AM, Vinicius Costa Gomes wrote: Hi Cool. Will send a non-RFC version then. Would the changes to txtimestamp selftest be helpful? Yes, since it could have spotted the bug earlier. Thanks.

Re: [RFC PATCH v0 2/2] skbuff: Notify errors with sk_error_report()

Hi Eric Dumazet writes: > On 03/12/2018 04:10 PM, Vinicius Costa Gomes wrote: >> When errors are enqueued to the error queue via sock_queue_err_skb() >> function, it is possible that the correct application is not notified. > > Your patch makes sense, thanks. Cool. Will

[PATCH v4 net-next 0/6] net/ipv6: Address checks need to consider the L3 domain

IPv6 prohibits a local address from being used as a gateway for a route. However, it is ok for the gateway to be a local address in a different L3 domain (e.g., VRF). This allows, for example, veth pairs to connect VRFs. ip6_route_info_create calls ipv6_chk_addr_and_flags for gateway addresses to

[PATCH v4 net-next 1/6] net/ipv6: Refactor gateway validation on route add

Move gateway validation code from ip6_route_info_create into ip6_validate_gw. Code move plus adjustments to handle the potential reset of dev and idev and to make checkpatch happy. Signed-off-by: David Ahern --- net/ipv6/route.c | 120

[PATCH v4 net-next 2/6] net/ipv6: Change address check to always take a device argument

ipv6_chk_addr_and_flags determines if an address is a local address and optionally if it is an address on a specific device. For example, it is called by ip6_route_info_create to determine if a given gateway address is a local address. The address check currently does not consider L3 domains and

[PATCH v4 net-next 3/6] net/ipv6: Add l3mdev check to ipv6_chk_addr_and_flags

Lookup the L3 master device for the passed in device. Only consider addresses on netdev's with the same master device. If the device is not enslaved or is NULL, then the l3mdev is NULL which means only devices not enslaved (ie, in the default domain) are considered. Signed-off-by: David Ahern

[PATCH v4 net-next 4/6] selftests: fib_tests: Use an alias for ip command

Replace 'ip -netns testns' with the alias IP. Shortens the line lengths and makes running the commands manually a bit easier. Signed-off-by: David Ahern --- tools/testing/selftests/net/fib_tests.sh | 169 --- 1 file changed, 85 insertions(+), 84

[PATCH v4 net-next 5/6] selftests: fib_tests: Allow user to run a specific test

Allow a user to run just a specific fib test by setting the TEST environment variable. Signed-off-by: David Ahern --- tools/testing/selftests/net/fib_tests.sh | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git

[PATCH v4 net-next 6/6] selftests: fib_tests: Add IPv6 nexthop spec tests

Add series of tests for valid and invalid nexthop specs for IPv6. $ TEST=fib_nexthop_test ./fib_tests.sh ... IPv6 nexthop tests TEST: Directly connected nexthop, unicast address [ OK ] TEST: Directly connected nexthop, unicast address with device [ OK ] TEST: Gateway is

Re: [PATCH net-next] cxgb4: Add HMA support

From: Arjun Vynipadath Date: Tue, 13 Mar 2018 16:24:45 +0530 > HMA(Host Memory Access) maps a part of host memory for T6-SO memfree cards. > > This commit does the following: > - Query FW to check if we have HMA support. If yes, the params will > return HMA size configured

Re: [RESEND] rsi: Remove stack VLA usage

"Tobin C. Harding" wrote: > The kernel would like to have all stack VLA usage removed[1]. rsi uses > a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size > is defined using a magic number. We can use a pre-processor defined > constant and declare the array to

Re: net/wireless: fix spaces and grammar copy/paste in vendor Kconfig help text

Randy Dunlap wrote: > From: Randy Dunlap > > Lots of the wireless driver vendor Kconfig symol help text says > "questions about cards." (2 spaces between "about" and "cards") > > Besides dropping one of those spaces, it also needs some other word

Re: [PATCH net-next] net: Add comment about pernet_operations methods and synchronization

From: Kirill Tkhai Date: Tue, 13 Mar 2018 13:55:55 +0300 > Make locking scheme be visible for users, and provide > a comment what for we are need exit_batch() methods, > and when it should be used. > > Signed-off-by: Kirill Tkhai Applied.

Re: linux-next: build warning after merge of the net-next tree

From: "Gustavo A. R. Silva" Date: Tue, 13 Mar 2018 06:46:24 -0500 > Hi Stephen, > > On 03/13/2018 01:11 AM, Stephen Rothwell wrote: >> Hi all, >> After merging the net-next tree, today's linux-next build (sparc >> defconfig) produced this warning: >> net/core/pktgen.c:

Re: [PATCH 00/30] Netfilter/IPVS updates for net-next

From: Florian Westphal Date: Tue, 13 Mar 2018 14:41:39 +0100 > David Miller wrote: >> From: Felix Fietkau >> Date: Mon, 12 Mar 2018 20:30:01 +0100 >> >> > It's not dead and useless. In its current state, it has a software fast >> > path that

Re: [pci PATCH v5 3/4] ena: Migrate over to unmanaged SR-IOV support

On 03/13/2018 11:04 AM, David Woodhouse wrote: On Tue, 2018-03-13 at 07:51 -0700, Alexander Duyck wrote: Actually the suggestion I had from Don Dutile was that we should be looking at creating a pci-stub like driver specifically for those type of devices, but without the ability to arbitrarily

Re: [PATCH] netfilter: cttimeout: remove VLA usage

On Tue, 2018-03-13 at 15:59 +0100, Pablo Neira Ayuso wrote: > On Mon, Mar 12, 2018 at 04:58:38PM -0700, Joe Perches wrote: > > On Mon, 2018-03-12 at 18:14 -0500, Gustavo A. R. Silva wrote: > > > In preparation to enabling -Wvla, remove VLA and replace it > > > with dynamic memory allocation. > > >

Re: [PATCH] net: dev_forward_skb(): Scrub packet's per-netns info only when crossing netns

On Tue, Mar 13, 2018 at 05:07:22PM +0200, Liran Alon wrote: > Before this commit, dev_forward_skb() always cleared packet's > per-network-namespace info. Even if the packet doesn't cross > network namespaces. > > The comment above dev_forward_skb() describes that this is done > because the

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

On Tue, Mar 13, 2018 at 5:51 PM, Or Gerlitz wrote: Sorry ppl, I added MLNX alias (asap_direct_...@mellanox.com) which is not open to outer posts, please remove it from your replies, otherwise it will bump you back.. Or. > On Wed, Mar 7, 2018 at 12:57 PM, Jiri Pirko

Re: [PATCH 00/30] Netfilter/IPVS updates for net-next

David Miller wrote: [ flow tables ] > Ok, that seems to constrain the exposure. > > We should talk at some point about how exposed conntrack itself is. Sure, we can do that. If you have specific scenarios (synflood, peer that opens 100k (legitimate) connections,

Re: [RFC net-next 2/6] driver: net: bonding: allow registration of tc offload callbacks in bond

On Wed, Mar 7, 2018 at 12:57 PM, Jiri Pirko wrote: > Mon, Mar 05, 2018 at 02:28:30PM CET, john.hur...@netronome.com wrote: >>Allow drivers to register netdev callbacks for tc offload in linux bonds. >>If a netdev has registered and is a slave of a given bond, then any tc >>rules

[PATCH net 0/1] net/iucv: fix 2018-03-13

Hi Dave, please apply one patch for af_iucv, that fixes an error path during initialization. Thanks, Julian Arvind Yadav (1): net/iucv: Free memory obtained by kzalloc net/iucv/af_iucv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.13.5

[PATCH net 1/1] net/iucv: Free memory obtained by kzalloc

From: Arvind Yadav Free memory by calling put_device(), if afiucv_iucv_init is not successful. Signed-off-by: Arvind Yadav Reviewed-by: Cornelia Huck Signed-off-by: Ursula Braun Signed-off-by:

[PATCH net-next 2/2] selftests: Add multipath tests for onlink flag

Add multipath tests for onlink flag: one test with onlink added to both nexthops, then tests with onlink added to only 1 nexthop. Signed-off-by: David Ahern --- tools/testing/selftests/net/fib-onlink-tests.sh | 92 - 1 file changed, 89 insertions(+), 3

[PATCH net-next 0/2] net/ipv6: Handle onlink flag with multipath routes

ONLINK flag is per nexthop. For multipath routes it is specified in rtnh_flags in struct rtnexthop versus rtm_flags for single path routes. Update ip6_route_multipath_add to look at rtnh_flags before the call to ip6_route_info_create. Add multipath test cases as well. David Ahern (2):

[PATCH net-next 1/2] net/ipv6: Handle onlink flag with multipath routes

For multipath routes the ONLINK flag is specified per nexthop in rtnh_flags (as opposed to rtm_flags for unicast routes). Update ip6_route_multipath_add to set fc_flags based on rtnh_flags. Fixes: fc1e64e1092f ("net/ipv6: Add support for onlink flag") Signed-off-by: David Ahern

Re: [PATCH v5 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

> Hello Andrew, > > The current driver implementation uses only a single FDB for the switch, > so it is not possible configure multiple flooding domains to accommodate > ports partitioning. Ah, O.K. Rather than break somebodies network by wrongly flooding, it would be better to return

Re: [PATCH net-next nfs 0/6] Converting pernet_operations (part #7)

From: Kirill Tkhai Date: Tue, 13 Mar 2018 13:49:05 +0300 > Hi, > > this series continues to review and to convert pernet_operations > to make them possible to be executed in parallel for several > net namespaces in the same time. There are nfs pernet_operations > in this

Re: [PATCH net-next 0/4] Converting pernet_operations (part #6)

From: Kirill Tkhai Date: Tue, 13 Mar 2018 13:36:33 +0300 > this series continues to review and to convert pernet_operations > to make them possible to be executed in parallel for several > net namespaces in the same time. There are sctp, tipc and rds > in this series.

RE: [PATCH v5 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Tuesday, March 13, 2018 4:23 PM > To: Razvan Stefanescu > Cc: gre...@linuxfoundation.org; de...@driverdev.osuosl.org; linux- > ker...@vger.kernel.org; netdev@vger.kernel.org; Alexander

Re: [PATCH V2 net 1/1] net/smc: simplify wait when closing listen socket

From: Ursula Braun Date: Tue, 13 Mar 2018 10:41:54 +0100 > Closing of a listen socket wakes up kernel_accept() of > smc_tcp_listen_worker(), and then has to wait till smc_tcp_listen_worker() > gives up the internal clcsock. The wait logic introduced with > commit

[PATCH] net: dev_forward_skb(): Scrub packet's per-netns info only when crossing netns

Before this commit, dev_forward_skb() always cleared packet's per-network-namespace info. Even if the packet doesn't cross network namespaces. The comment above dev_forward_skb() describes that this is done because the receiving device may be in another network namespace. However, this case can

Re: [pci PATCH v5 3/4] ena: Migrate over to unmanaged SR-IOV support

On Tue, 2018-03-13 at 07:51 -0700, Alexander Duyck wrote: > Actually the suggestion I had from Don Dutile was that we should be > looking at creating a pci-stub like driver specifically for those type > of devices, but without the ability to arbitrarily assign devices. > Basically we have to

Re: [PATCH] netfilter: cttimeout: remove VLA usage

On Mon, Mar 12, 2018 at 04:58:38PM -0700, Joe Perches wrote: > On Mon, 2018-03-12 at 18:14 -0500, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wvla, remove VLA and replace it > > with dynamic memory allocation. > > > > From a security viewpoint, the use of Variable Length Arrays can

Re: [PATCH net] qed: Use after free in qed_rdma_free()

From: Dan Carpenter Date: Tue, 13 Mar 2018 12:09:38 +0300 > We're dereferencing "p_hwfn->p_rdma_info" but that is freed on the line > before in qed_rdma_resc_free(p_hwfn). > > Fixes: 9de506a547c0 ("qed: Free RoCE ILT Memory on rmmod qedr") > Signed-off-by: Dan

Re: [pci PATCH v5 3/4] ena: Migrate over to unmanaged SR-IOV support

On Tue, Mar 13, 2018 at 1:12 AM, David Woodhouse wrote: > On Mon, 2018-03-12 at 10:23 -0700, Alexander Duyck wrote: >> >> - .sriov_configure = ena_sriov_configure, >> +#ifdef CONFIG_PCI_IOV >> + .sriov_configure = pci_sriov_configure_simple, >> +#endif >> }; > >

Re: [PATCH v2 1/1] net: check before dereferencing netdev_ops during busy poll

From: Josh Elsasser Date: Mon, 12 Mar 2018 22:32:00 -0700 > init_dummy_netdev() leaves its netdev_ops pointer zeroed. This leads > to a NULL pointer dereference when sk_busy_loop fires against an iwlwifi > wireless adapter and checks napi->dev->netdev_ops->ndo_busy_poll. >

Re: [PATCH net-next v2] sctp: fix error return code in sctp_sendmsg_new_asoc()

From: Wei Yongjun Date: Tue, 13 Mar 2018 03:03:30 + > Return error code -EINVAL in the address len check error handling > case since 'err' can be overwrite to 0 by 'err = sctp_verify_addr()' > in the for loop. > > Fixes: 2c0dbaa0c43d ("sctp: add support for

Re: [PATCH net-next 1/4] net: qualcomm: rmnet: Fix casting issues

From: Subash Abhinov Kasiviswanathan Date: Mon, 12 Mar 2018 20:26:06 -0600 > diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h > b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map.h > index 6ce31e2..65b074e 100644 > ---

Re: [RFC PATCH net-next 3/5] bridge: allow switchdev port to handle flooding by itself

On Mon, Mar 12, 2018 at 6:11 PM, Andrew Lunn wrote: >> The flag was introduced to enable hardware switch capabilities of >> drivers/net/wireless/quantenna/qtnfmac wifi driver. It does not have any >> switchdev functionality in upstream tree at this moment, and this patchset >> was

Re: pull request (net): ipsec 2018-03-13

From: Steffen Klassert Date: Tue, 13 Mar 2018 08:09:44 +0100 > Please pull or let me know if there are problems. Pulled, thanks!

Re: [PATCH net-next] ibmvnic: Fix recent errata commit

From: Thomas Falcon Date: Mon, 12 Mar 2018 21:05:26 -0500 > Sorry, one of the patches I sent in an earlier series > has some dumb mistakes. One was that I had changed the > parameter for the errata workaround function but forgot > to make that change in the code that

Re: [PATCH v5 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

> +/* For the moment, only flood setting needs to be updated */ > +static int port_bridge_join(struct net_device *netdev, > + struct net_device *upper_dev) > +{ > + struct ethsw_port_priv *port_priv = netdev_priv(netdev); > + struct ethsw_core *ethsw =

[PATCH iproute2 1/1] tc: print actual action for sample action

Signed-off-by: Roman Mashak --- tc/m_sample.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tc/m_sample.c b/tc/m_sample.c index ff5ee6bd1ef6..d88846c63be3 100644 --- a/tc/m_sample.c +++ b/tc/m_sample.c @@ -163,6 +163,8 @@ static int print_sample(struct action_util *au,

[PATCH v5 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

Introduce the DPAA2 Ethernet Switch driver, which manages Datapath Switch (DPSW) objects discovered on the MC bus. Suggested-by: Alexandru Marginean Signed-off-by: Razvan Stefanescu --- Changelog: v2: - fix PVID cleanup in

[PATCH v5 1/6] staging: fsl-dpaa2/ethsw: Add APIs for DPSW object

Add the command build/parse APIs for operating on DPSW objects through the DPAA2 Management Complex. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - use u8 for en parameter of dpsw_if_set_flooding/broadcast() v3: - no changes v4: - adjust to moving

[PATCH v5 0/6] staging: Introduce DPAA2 Ethernet Switch driver

This patchset introduces the Ethernet Switch Driver for Freescale/NXP SoCs with DPAA2 (DataPath Acceleration Architecture v2). The driver manages switch objects discovered on the fsl-mc bus. A description of the driver can be found in the associated README file. The patchset consists of: * A set

[PATCH v5 4/6] staging: fsl-dpaa2/ethsw: Add maintainer for Ethernet Switch driver

Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - no changes v4: - no changes v5: - no changes MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index c3c2b75..20d7bf2 100644

[PATCH v5 5/6] staging: fsl-dpaa2/ethsw: Add README

Add a README file describing the driver architecture, components and interfaces. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - no changes v4: - no changes v5: - no changes drivers/staging/fsl-dpaa2/ethsw/README | 106

[PATCH v5 3/6] staging: fsl-dpaa2/ethsw: Add ethtool support

Add driver information, link details and hardware statistics to be reported via ethtool -S. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - removed driver version v4: - no changes v5: - no changes

[PATCH v5 6/6] staging: fsl-dpaa2/ethsw: Add TODO

Add a TODO file describing what needs to be added/changed before the driver can be moved out of staging. Signed-off-by: Razvan Stefanescu --- Changelog: v2: - no changes v3: - no changes v4: - remove fsl-mc bus driver dependency as it is out of staging

RE: mmiowb() vs wmb() with write combined MMIO

> has uncovered an issue in qede NIC driver [/drivers/net/ethernet/qlogic/qede] > and > this driver is seriously broken for basic L2. That's a bit extreme. There is a race condition bug that needs fixing. > Before the series from John, driver was running fine, probably with hiding a > serious >

Re: [PATCH v4 net-next 3/4] net: macb: Add phy-handle DT support

On Mon, Mar 12, 2018 at 03:30:53PM -0700, Florian Fainelli wrote: > On 03/12/2018 02:57 PM, Andrew Lunn wrote: > >> + /* attempt to find a phy-handle */ > >> + if (!(bp->phy_node = of_parse_phandle(np, "phy-handle", > >> 0))) { > >> + > >> +

Re: [PATCH v3 net 0/5] tcp: fixes to non-SACK TCP

On Tue, Mar 13, 2018 at 3:25 AM, Ilpo Järvinen wrote: > Here is a series of fixes to issues that occur when SACK is not > enabled for a TCP connection. These are not fixes to just some > remote corner cases of recovery but many/almost all recoveries > without SACK will

Re: [PATCH 00/30] Netfilter/IPVS updates for net-next

David Miller wrote: > From: Felix Fietkau > Date: Mon, 12 Mar 2018 20:30:01 +0100 > > > It's not dead and useless. In its current state, it has a software fast > > path that significantly improves nftables routing/NAT throughput, > > especially on embedded

RE: [PATCH v3] kernel.h: Skip single-eval logic on literals in min()/max()

The amount of replicated defined could also be reduced by passing > or < to a min_max() macro. So you start off with something like: #define min(x, y) __min_max(x, <, y) #define max(x, y) __min_max(x, >, y) then have: #define __min_max(x, cond, y) ((x) cond (y) ? (x) : (y)) in all its associated

Re: [PATCH 1/2] udp: Move the udp sysctl to namespace.

On Tue, Mar 13, 2018 at 7:36 PM, Paolo Abeni wrote: > Hi, > > On Tue, 2018-03-13 at 02:57 -0700, Tonghao Zhang wrote: >> This patch moves the udp_rmem_min, udp_wmem_min >> to namespace and init the udp_l3mdev_accept explicitly. > > Can you please be a little more descriptive on

RE: [PATCH] drivers: net: wireless: ath: ath9: dfs: remove VLA usage

From: Daniel Micay > Sent: 10 March 2018 23:45 > > > Just wondering. Is this actually a VLA. FFT_NUM_SAMPLES was static const so > > not really going to show a lot of variation. This array will always have the > > same size on the stack. > > The issue is that unlike in C++, a `static const`

<    1   2   3   >