[PATCH v2 net-next 4/5] cxgb4: Support firmware rdma write with immediate work request.

2018-03-20 Thread Raju Rangoju
If FW supports RDMA WRITE_WITH_IMMEDATE functionality, then advertise that to the ULDs. This will be used by iw_cxgb4 to allow WRITE_WITH_IMMEDIATE work requests. Signed-off-by: Potnuri Bharat Teja Signed-off-by: Raju Rangoju Signed-off-by: Ganesh Goudar

[PATCH v2 net-next 5/5] cxgb4: Support firmware rdma write completion work request.

2018-03-20 Thread Raju Rangoju
If FW supports RDMA WRITE_COMPLETION functionality, then advertise that to the ULDs. This will be used by iw_cxgb4 to allow WRITE_COMPLETION work requests. Signed-off-by: Potnuri Bharat Teja Signed-off-by: Raju Rangoju Signed-off-by: Ganesh Goudar

[PATCH net-next 0/4] r8169: series with smaller improvements w/o functional changes

2018-03-20 Thread Heiner Kallweit
This series includes smaller improvements w/o intended functional changes. Heiner Kallweit (4): r8169: simplify rtl_set_mac_address r8169: change type of first argument in rtl_tx_performance_tweak r8169: change type of argument in rtl_disable/enable_clock_request r8169: add helper

[PATCH net-next 3/4] r8169: change type of argument in rtl_disable/enable_clock_request

2018-03-20 Thread Heiner Kallweit
Changing the argument type to struct rtl8169_private * is more in line with the other functions in the driver and it allows to reduce the code size. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 33 +++-- 1 file

[PATCH net-next 4/4] r8169: add helper tp_to_dev

2018-03-20 Thread Heiner Kallweit
In several places struct device is referenced by using >pci_dev->dev. Add helper tp_to_dev() to improve code readability. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 37 +--- 1 file changed, 22 insertions(+), 15

[PATCH net-next 1/4] r8169: simplify rtl_set_mac_address

2018-03-20 Thread Heiner Kallweit
Replace open-coded functionality with eth_mac_addr(). Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c

[PATCH net-next 2/4] r8169: change type of first argument in rtl_tx_performance_tweak

2018-03-20 Thread Heiner Kallweit
Changing the type of the first argument to struct rtl8169_private * is more in line with the other functions in the driver and it allows to reduce the code size. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 62

Re: [PATCH net-next 02/12] clk: sunxi-ng: r40: export a regmap to access the GMAC register

2018-03-20 Thread Chen-Yu Tsai
On Mon, Mar 19, 2018 at 5:31 AM, Maxime Ripard wrote: > On Sat, Mar 17, 2018 at 05:28:47PM +0800, Chen-Yu Tsai wrote: >> From: Icenowy Zheng >> >> There's a GMAC configuration register, which exists on A64/A83T/H3/H5 in >> the syscon part, in the CCU

Re: [bpf-next V3 PATCH 13/15] mlx5: use page_pool for xdp_return_frame call

2018-03-20 Thread Tariq Toukan
On 19/03/2018 3:12 PM, Jesper Dangaard Brouer wrote: On Mon, 12 Mar 2018 15:20:06 +0200 Tariq Toukan wrote: On 12/03/2018 12:16 PM, Tariq Toukan wrote: On 12/03/2018 12:08 PM, Tariq Toukan wrote: On 09/03/2018 10:56 PM, Jesper Dangaard Brouer wrote: This patch

[PATCH net 0/4] s390/qeth: fixes 2018-03-20

2018-03-20 Thread Julian Wiedmann
Hi Dave, Please apply one final set of qeth patches for 4.16. All of these fix long-standing bugs, so please queue them up for -stable as well. Thank you, Julian Julian Wiedmann (4): s390/qeth: free netdevice when removing a card s390/qeth: when thread completes, wake up all waiters

[PATCH net 3/4] s390/qeth: lock read device while queueing next buffer

2018-03-20 Thread Julian Wiedmann
For calling ccw_device_start(), issue_next_read() needs to hold the device's ccwlock. This is satisfied for the IRQ handler path (where qeth_irq() gets called under the ccwlock), but we need explicit locking for the initial call by the MPC initialization. Signed-off-by: Julian Wiedmann

[PATCH net 2/4] s390/qeth: when thread completes, wake up all waiters

2018-03-20 Thread Julian Wiedmann
qeth_wait_for_threads() is potentially called by multiple users, make sure to notify all of them after qeth_clear_thread_running_bit() adjusted the thread_running_mask. With no timeout, callers would otherwise stall. Signed-off-by: Julian Wiedmann ---

[PATCH net 4/4] s390/qeth: on channel error, reject further cmd requests

2018-03-20 Thread Julian Wiedmann
When the IRQ handler determines that one of the cmd IO channels has failed and schedules recovery, block any further cmd requests from being submitted. The request would inevitably stall, and prevent the recovery from making progress until the request times out. This sort of error was observed

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

2018-03-20 Thread Alexey Roslyakov
Arend, >Also I am not sure if the broken-sg-support is still needed. We added that for >omap_hsmmc, but that has since changed to scatter-gather emulation so it might >not be needed anymore. I can confirm it doesn't impact wifi performance in case of rk3288+ap6335. But I still have to set

[PATCH v2 net-next 1/5] cxgb4: Adds CPL support for Shared Receive Queues

2018-03-20 Thread Raju Rangoju
- Add srq table query cpl support for srq - Add cpl_abort_req_rss6 and cpl_abort_rpl_rss6 structs. - Add accessors, macros to get the SRQ IDX value. Signed-off-by: Raju Rangoju Reviewed-by: Steve Wise Signed-off-by: Ganesh Goudar

[PATCH v2 net-next 2/5] cxgb4: Add support to initialise/read SRQ entries

2018-03-20 Thread Raju Rangoju
- This patch adds support to initialise srq table and read srq entries Signed-off-by: Raju Rangoju Reviewed-by: Steve Wise Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/Makefile | 2 +-

[PATCH v2 net-next 3/5] cxgb4: Add support to query HW SRQ parameters

2018-03-20 Thread Raju Rangoju
This patch adds support to query FW for the HW SRQ table start/end, and advertise that for ULDs. Signed-off-by: Raju Rangoju Reviewed-by: Steve Wise Signed-off-by: Ganesh Goudar ---

Re: tg3 crashes under high load, when using 100Mbits

2018-03-20 Thread Satish Baddipadige
On Thu, Feb 15, 2018 at 7:37 PM, Siva Reddy Kallam wrote: > On Mon, Feb 12, 2018 at 10:59 AM, Siva Reddy Kallam > wrote: >> On Fri, Feb 9, 2018 at 10:41 AM, Kai Heng Feng >> wrote: >>> Hi Broadcom folks, >>> >>> We

[PATCH v2 net-next 0/5] Add support for RDMA enhancements in cxgb4

2018-03-20 Thread Raju Rangoju
Allocates the HW-resources and provide the necessary routines for the upper layer driver (rdma/iw_cxgb4) to enable the RDMA SRQ support for Chelsio adapters. Advertise support for write with immediate work request Advertise support for write with completion v2: fixed the patching issues and

[PATCH net 1/4] s390/qeth: free netdevice when removing a card

2018-03-20 Thread Julian Wiedmann
On removal, a qeth card's netdevice is currently not properly freed because the call chain looks as follows: qeth_core_remove_device(card) lx_remove_device(card) unregister_netdev(card->dev) card->dev = NULL!!!

Re: [PATCH v2 net-next 2/5] cxgb4: Add support to initialise/read SRQ entries

2018-03-20 Thread Stefano Brivio
On Tue, 20 Mar 2018 07:58:39 +0100 Stefano Brivio wrote: > On Tue, 20 Mar 2018 11:43:34 +0530 > Raju Rangoju wrote: > > > +struct srq_data *t4_init_srq(int srq_size) > > +{ > > + struct srq_data *s; > > + > > + s = kzalloc(sizeof(*s), GFP_KERNEL |

Re: [PATCH v2 net-next 2/5] cxgb4: Add support to initialise/read SRQ entries

2018-03-20 Thread Stefano Brivio
On Tue, 20 Mar 2018 11:43:34 +0530 Raju Rangoju wrote: > +struct srq_data *t4_init_srq(int srq_size) > +{ > + struct srq_data *s; > + > + s = kzalloc(sizeof(*s), GFP_KERNEL | __GFP_NOWARN); > + if (!s) > + s = kvzalloc(sizeof(*s), GFP_KERNEL); > +

Re: linux-next on x60: network manager often complains "network is disabled" after resume

2018-03-20 Thread Pavel Machek
On Mon 2018-03-19 12:45:49, Dan Williams wrote: > On Mon, 2018-03-19 at 18:33 +0100, Pavel Machek wrote: > > On Mon 2018-03-19 10:40:08, Dan Williams wrote: > > > On Mon, 2018-03-19 at 10:21 +0100, Pavel Machek wrote: > > > > On Mon 2018-03-19 05:17:45, Woody Suwalski wrote: > > > > > Pavel Machek

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

2018-03-20 Thread Arend van Spriel
On 3/20/2018 8:58 AM, Alexey Roslyakov wrote: Arend, Also I am not sure if the broken-sg-support is still needed. We added that for omap_hsmmc, but that has since changed to scatter-gather emulation so it might not be needed anymore. I can confirm it doesn't impact wifi performance in case

Re: [PATCH net-next 1/2] net: dsa: mv88e6xxx: Use the DT IRQ trigger mode

2018-03-20 Thread Uwe Kleine-König
On Mon, Mar 19, 2018 at 10:16:20PM +0100, Andrew Lunn wrote: > By calling request_threaded_irq() with the flag IRQF_TRIGGER_FALLING > we override the trigger mode provided in device tree. And the > interrupt is actually active low, which is what all the current device > tree descriptions use. > >

Re: [PATCH 0/4] net: dsa: mv88e6xxx: novice fixes and irq handling

2018-03-20 Thread Uwe Kleine-König
Hello Andrew, On Mon, Mar 19, 2018 at 05:37:13PM +0100, Andrew Lunn wrote: > > When I tested the second change however the driver still failed > > because the gpio controller doesn't support level sensitive > > irqs. :-| > > Do you have documentation for the SoC? Is it a hardware limitation, or

Re: [rds-devel] [PATCH RFC RFC] rds: Use NETDEV_UNREGISTER in rds_tcp_dev_event() (then kill NETDEV_UNREGISTER_FINAL)

2018-03-20 Thread Håkon Bugge
Hi Sowmini, A little nit below. And some spelling issues in existing commentary you can consider fixing, since you reshuffle this file considerable. Thxs, Håkon > On 18 Mar 2018, at 21:45, Sowmini Varadhan > wrote: > > On (03/18/18 00:55), Kirill Tkhai wrote:

[PATCH v2 net 6/7] net: aquantia: Implement pci shutdown callback

2018-03-20 Thread Igor Russkikh
We should close link and all NIC operations during shutdown. On some systems graceful reboot never closes NIC interface on its own, but only indicates pci device shutdown. Without explicit handler, NIC rx rings continued to transfer DMA data into prepared buffers while CPU rebooted already. That

Re: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-20 Thread Rahul Lakkireddy
On Monday, March 03/19/18, 2018 at 20:13:10 +0530, Thomas Gleixner wrote: > On Mon, 19 Mar 2018, Rahul Lakkireddy wrote: > > > Use VMOVDQU AVX CPU instruction when available to do 256-bit > > IO read and write. > > That's not what the patch does. See below. > > > Signed-off-by: Rahul Lakkireddy

Re: [RFC v2 0/2] kernel: add support to collect hardware logs in crash recovery kernel

2018-03-20 Thread Rahul Lakkireddy
On Monday, March 03/19/18, 2018 at 20:52:11 +0530, Stephen Hemminger wrote: > On Mon, 19 Mar 2018 13:25:56 +0530 > Rahul Lakkireddy wrote: > > > On Friday, March 03/16/18, 2018 at 16:42:03 +0530, Rahul Lakkireddy wrote: > > > On production servers running variety of

RE: [RFC PATCH 0/3] kernel: add support for 256-bit IO access

2018-03-20 Thread David Laight
From: Ingo Molnar > Sent: 20 March 2018 10:54 ... > Note that a generic version might still be worth trying out, if and only if > it's > safe to access those vector registers directly: modern x86 CPUs will do their > non-constant memcpy()s via the common memcpy_erms() function - which could in >

Re: HW question: i210 vs. BCM5461S over SGMII: no response from PHY to MDIO requests?

2018-03-20 Thread Frantisek Rysanek
I've taken a look inside the two SFP's. http://support.fccps.cz/download/adv/frr/ptp/inside_sfps.zip The uglier, bigger and likely older model (my SFP#2) contains two PCB's sandwiched, and the key chips are inside the sandwich. Thus, the photoes don't show much. The sexier SFP#1 = the one with

Re: [PATCH] netfilter: nfnetlink_cthelper: Remove VLA usage

2018-03-20 Thread Pablo Neira Ayuso
On Mon, Mar 12, 2018 at 07:21:38PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wvla, remove VLA and replace it > with dynamic memory allocation. > > From a security viewpoint, the use of Variable Length Arrays can be > a vector for stack overflow attacks. Also, in general, as

Re: [PATCH] netfilter: cttimeout: remove VLA usage

2018-03-20 Thread Pablo Neira Ayuso
On Mon, Mar 12, 2018 at 06:14:42PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wvla, remove VLA and replace it > with dynamic memory allocation. > > From a security viewpoint, the use of Variable Length Arrays can be > a vector for stack overflow attacks. Also, in general, as

Re: [PATCH v2] netfilter: nf_tables: remove VLA usage

2018-03-20 Thread Pablo Neira Ayuso
On Mon, Mar 12, 2018 at 10:16:17PM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wvla, remove VLA and replace it > with dynamic memory allocation. > > From a security viewpoint, the use of Variable Length Arrays can be > a vector for stack overflow attacks. Also, in general, as

[PATCH] test_bpf: Fix testing with CONFIG_BPF_JIT_ALWAYS_ON=y on other arches

2018-03-20 Thread Thadeu Lima de Souza Cascardo
Function bpf_fill_maxinsns11 is designed to not be able to be JITed on x86_64. So, it fails when CONFIG_BPF_JIT_ALWAYS_ON=y, and commit 09584b406742 ("bpf: fix selftests/bpf test_kmod.sh failure when CONFIG_BPF_JIT_ALWAYS_ON=y") makes sure that failure is detected on that case. However, it does

[PATCH v2 net 7/7] net: aquantia: driver version bump

2018-03-20 Thread Igor Russkikh
Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/ver.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/ver.h b/drivers/net/ethernet/aquantia/atlantic/ver.h index 5265b93..a445de6 100644

[PATCH v2 net 3/7] net: aquantia: Change inefficient wait loop on fw data reads

2018-03-20 Thread Igor Russkikh
B1 hardware changes behavior of mailbox interface, it has busy bit always raised. Data ready condition should be detected by increment of address register. Old code has empty `for` loop, and that caused cpu overloads on B1 hardware. aq_nic_service_timer_cb consumed ~100ms because of that.

[PATCH v2 net 2/7] net: aquantia: Fix a regression with reset on old firmware

2018-03-20 Thread Igor Russkikh
FW 1.5.58 and below needs a fixed delay even after 0x18 register is filled. Otherwise, setting MPI_INIT state too fast causes traffic hang. Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c | 4 1 file changed, 4

[PATCH v2 net 1/7] net: aquantia: Fix hardware reset when SPI may rarely hangup

2018-03-20 Thread Igor Russkikh
Under some circumstances (notably using thunderbolt interface) SPI on chip reset may be in active transaction. Here we forcibly cleanup SPI to prevent possible hangups. Signed-off-by: Igor Russkikh --- .../ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c | 20

[PATCH v2 net 0/7] Aquantia atlantic hot fixes 03-2018

2018-03-20 Thread Igor Russkikh
This is a set of atlantic driver hot fixes for various areas: Some issues with hardware reset covered, Fixed napi_poll flood happening on some traffic conditions, Allow system to change MAC address on live device, Add pci shutdown handler. patch v2: - reverse christmas tree - remove driver

[PATCH v2 net 4/7] net: aquantia: Add tx clean budget and valid budget handling logic

2018-03-20 Thread Igor Russkikh
We should report to napi full budget only when we have more job to do. Before this fix, on any tx queue cleanup we forced napi to do poll again. Thats a waste of cpu resources and caused storming with napi polls when there was at least one tx on each interrupt. With this fix we report full budget

[PATCH v2 net 5/7] net: aquantia: Allow live mac address changes

2018-03-20 Thread Igor Russkikh
There is nothing prevents us from changing MAC on the running interface. Allow this with ndev priv flag. Signed-off-by: Igor Russkikh --- drivers/net/ethernet/aquantia/atlantic/aq_nic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: HW question: i210 vs. BCM5461S over SGMII: no response from PHY to MDIO requests?

2018-03-20 Thread Andrew Lunn
> i2cdetect has found three i2c slaves (identical layout in both SFP's) > at addresses 0x50, 0x51 and 0x56. > What are they? EEPROM, DDM and "MDIO over i2c" ? > The SFP's likely lack a proper SFP MSA data structure. 0x50 and 0x51 are EEPROM like. See drivers/net/phy/sfp.c. The standard at24

Re: HW question: i210 vs. BCM5461S over SGMII: no response from PHY to MDIO requests?

2018-03-20 Thread Frantisek Rysanek
On 20 Mar 2018 at 13:09, Andrew Lunn wrote: > > i2cdetect has found three i2c slaves (identical layout in both SFP's) > > at addresses 0x50, 0x51 and 0x56. > > What are they? EEPROM, DDM and "MDIO over i2c" ? > > The SFP's likely lack a proper SFP MSA data structure. > > 0x50 and 0x51 are EEPROM

Re: DTS for our Configuration

2018-03-20 Thread Andrew Lunn
On Tue, Mar 20, 2018 at 09:12:18AM +, Alayev Michael wrote: > Hello Andrew, > > Please see my comments below in red with some important highlights. Hi Michael Please don't use html encrypted emails. Please use quoting as everybody else does on this list. > I added the ethernet parameter

Re: [PATCH bpf-next] bpf: skip unnecessary capability check

2018-03-20 Thread Lorenzo Colitti
On Tue, Mar 20, 2018 at 12:57 AM, Chenbo Feng wrote: > - if (!capable(CAP_SYS_ADMIN) && sysctl_unprivileged_bpf_disabled) > + if (sysctl_unprivileged_bpf_disabled && !capable(CAP_SYS_ADMIN)) > return -EPERM; > Acked-by: Lorenzo Colitti

Re: [PATCH] mlx5: Remove call to ida_pre_get

2018-03-20 Thread Maor Gottlieb
On 3/20/2018 5:29 AM, Saeed Mahameed wrote: On Thu, 2018-03-15 at 18:30 -0700, Matthew Wilcox wrote: On Thu, Mar 15, 2018 at 11:58:07PM +, Saeed Mahameed wrote: On Wed, 2018-03-14 at 19:57 -0700, Matthew Wilcox wrote: From: Matthew Wilcox The mlx5 driver calls

Re: linux-next on x60: network manager often complains "network is disabled" after resume

2018-03-20 Thread Dan Williams
On Tue, 2018-03-20 at 09:03 +0100, Pavel Machek wrote: > On Mon 2018-03-19 12:45:49, Dan Williams wrote: > > On Mon, 2018-03-19 at 18:33 +0100, Pavel Machek wrote: > > > On Mon 2018-03-19 10:40:08, Dan Williams wrote: > > > > On Mon, 2018-03-19 at 10:21 +0100, Pavel Machek wrote: > > > > > On Mon

Re: [rds-devel] [PATCH RFC RFC] rds: Use NETDEV_UNREGISTER in rds_tcp_dev_event() (then kill NETDEV_UNREGISTER_FINAL)

2018-03-20 Thread Sowmini Varadhan
On (03/20/18 12:37), H??kon Bugge wrote: > > A little nit below. And some spelling issues in existing commentary > you can consider fixing, since you reshuffle this file considerable. > > + if (net != _net && rtn->ctl_table) > > + kfree(rtn->ctl_table); > > Well, this comes from the

Re: [RFC PATCH 0/3] kernel: add support for 256-bit IO access

2018-03-20 Thread Thomas Gleixner
On Tue, 20 Mar 2018, Ingo Molnar wrote: > * Thomas Gleixner wrote: > > > > Useful also for code that needs AVX-like registers to do things like CRCs. > > > > x86/crypto/ has a lot of AVX optimized code. > > Yeah, that's true, but the crypto code is processing fundamentally

Re: pull request: bluetooth 2018-03-16

2018-03-20 Thread Marcel Holtmann
Hi Dave, > Here are a few more important Bluetooth driver fixes for the 4.16 > kernel. > > Please let me know if there are any issues pulling. Thanks. > > Johan > > --- > The following changes since commit 3d502067599f0db12e74e6646aee8728efe3e5be: > > net/smc: simplify wait when closing

[PATCH v3 net-next 5/5] cxgb4: Support firmware rdma write completion work request.

2018-03-20 Thread Raju Rangoju
If FW supports RDMA WRITE_COMPLETION functionality, then advertise that to the ULDs. This will be used by iw_cxgb4 to allow WRITE_COMPLETION work requests. Signed-off-by: Potnuri Bharat Teja Signed-off-by: Raju Rangoju Signed-off-by: Ganesh Goudar

[PATCH v3 net-next 1/5] cxgb4: Adds CPL support for Shared Receive Queues

2018-03-20 Thread Raju Rangoju
- Add srq table query cpl support for srq - Add cpl_abort_req_rss6 and cpl_abort_rpl_rss6 structs. - Add accessors, macros to get the SRQ IDX value. Signed-off-by: Raju Rangoju Reviewed-by: Steve Wise Signed-off-by: Ganesh Goudar

[PATCH v3 net-next 3/5] cxgb4: Add support to query HW SRQ parameters

2018-03-20 Thread Raju Rangoju
This patch adds support to query FW for the HW SRQ table start/end, and advertise that for ULDs. Signed-off-by: Raju Rangoju Reviewed-by: Steve Wise Signed-off-by: Ganesh Goudar ---

[PATCH v3 net-next 4/5] cxgb4: Support firmware rdma write with immediate work request.

2018-03-20 Thread Raju Rangoju
If FW supports RDMA WRITE_WITH_IMMEDATE functionality, then advertise that to the ULDs. This will be used by iw_cxgb4 to allow WRITE_WITH_IMMEDIATE work requests. Signed-off-by: Potnuri Bharat Teja Signed-off-by: Raju Rangoju Signed-off-by: Ganesh Goudar

[PATCH v3 net-next 2/5] cxgb4: Add support to initialise/read SRQ entries

2018-03-20 Thread Raju Rangoju
- This patch adds support to initialise srq table and read srq entries Signed-off-by: Raju Rangoju Reviewed-by: Steve Wise Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/Makefile | 2 +-

[PATCH v3 net-next 0/5] Add support for RDMA enhancements in cxgb4

2018-03-20 Thread Raju Rangoju
Allocates the HW-resources and provide the necessary routines for the upper layer driver (rdma/iw_cxgb4) to enable the RDMA SRQ support for Chelsio adapters. Advertise support for write with immediate work request Advertise support for write with completion v3: modified memory allocation as per

Re: [PATCH bpf] bpf: fix crash due to inode i_op mismatch with clang/llvm

2018-03-20 Thread Daniel Borkmann
On 03/20/2018 03:06 AM, Linus Torvalds wrote: > On Mon, Mar 19, 2018 at 6:50 PM, Linus Torvalds > wrote: >> >> Add it to everything. If it's an invalid optimization, it shouldn't be on. > > IOW, why isn't this just something like > > diff --git a/Makefile

RE: [RFC PATCH 0/3] kernel: add support for 256-bit IO access

2018-03-20 Thread David Laight
From: Thomas Gleixner > Sent: 20 March 2018 09:41 > On Tue, 20 Mar 2018, Ingo Molnar wrote: > > * Thomas Gleixner wrote: ... > > > And if we go down that road then we want a AVX based memcpy() > > > implementation which is runtime conditional on the feature bit(s) and > > >

[PATCH] Add possibility to turn off promiscuous mode

2018-03-20 Thread Stephan Mondwurf
The driver is capable of switching on the promiscuous mode. This patch adds the possibility to turn it off again. Signed-off-by: Stephan Mondwurf --- drivers/net/ethernet/altera/altera_tse_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH] Avoid interruption of multicast reception if mc list changes

2018-03-20 Thread Stephan Mondwurf
The Altera TSE driver clears the multicast hash table before reapplying the correct values. This results in an interruption of multicast reception on any change of the mc addr list. This patch recalculates the multicast hash table before applying it to the hardware. Signed-off-by: Stephan

Re: [RFC PATCH 0/3] kernel: add support for 256-bit IO access

2018-03-20 Thread Ingo Molnar
* Thomas Gleixner wrote: > On Tue, 20 Mar 2018, Ingo Molnar wrote: > > * Thomas Gleixner wrote: > > > > > > So I do think we could do more in this area to improve driver > > > > performance, if the > > > > code is correct and if there's actual

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

2018-03-20 Thread Kalle Valo
Arend van Spriel writes: >>> If I get it right, you mean something like this: >>> >>> mmc3: mmc@1c12000 { >>> ... >>> broken-sg-support; >>> sd-head-align = 4; >>> sd-sgentry-align = 512; >>> >>> brcmf: wifi@1 { >>>

Re: [bpf-next V3 PATCH 13/15] mlx5: use page_pool for xdp_return_frame call

2018-03-20 Thread Tariq Toukan
I see the issue.  I have to go over the details in the driver, but I think it should be sufficient to remove the WARN().  When the page_pool was integrated with the MM-layer, being invoked from the put_page() call itself, this would indicate a likely API misuse.  But now, with the page refcnt

Re: [RFC PATCH 0/3] kernel: add support for 256-bit IO access

2018-03-20 Thread Ingo Molnar
* Thomas Gleixner wrote: > > So I do think we could do more in this area to improve driver performance, > > if the > > code is correct and if there's actual benchmarks that are showing real > > benefits. > > If it's about hotpath performance I'm all for it, but the use

Recall: DTS for our Configuration

2018-03-20 Thread Alayev Michael
Alayev Michael would like to recall the message, "DTS for our Configuration". *** Please consider the environment before printing this email ! The information contained in this communication is proprietary

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

2018-03-20 Thread Alexey Roslyakov
Arend, Agreed. Let's dismiss these patches. Now I'm curious if I can get the information about DMA SG limitations from MMC layer, I'll try to figure out something. BTW, my specific setup (with default alignments) triggers kernel panic (I see brcm_* in backtrace). It's better if I create separate

[PATCH v2 0/3] net: dsa: mv88e6xxx: some fixes

2018-03-20 Thread Uwe Kleine-König
Hello, these patches target net-next and got approved by Andrew Lunn. Compared to (implicit) v1, I dropped the patch that I didn't know if it was right because of missing documentation on my side. But Andrew already cared for that in a patch that is now adfccf118211 in net-next. Best regards

[PATCH v2 3/3] net: dsa: mv88e6xxx: Fix interrupt name for g2 irq

2018-03-20 Thread Uwe Kleine-König
This changes the respective line in /proc/interrupts from 49: x x mv88e6xxx-g1 7 Edge mv88e6xxx-g1 to 49: x x mv88e6xxx-g1 7 Edge mv88e6xxx-g2 which makes more sense. Reviewed-by: Andrew Lunn Signed-off-by: Uwe

[PATCH v2 2/3] net: dsa: mv88e6xxx: Fix typo in a comment

2018-03-20 Thread Uwe Kleine-König
Reviewed-by: Andrew Lunn Signed-off-by: Uwe Kleine-König --- drivers/net/dsa/mv88e6xxx/chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index

[PATCH v2 1/3] net: dsa: mv88e6xxx: Fix name of switch 88E6141

2018-03-20 Thread Uwe Kleine-König
The switch name is emitted in the kernel log, so having the right name there is nice. Fixes: 1558727a1c1b ("net: dsa: mv88e6xxx: Add support for ethernet switch 88E6141") Reviewed-by: Andrew Lunn Signed-off-by: Uwe Kleine-König ---

Re: [PATCH v2 net-next 2/5] cxgb4: Add support to initialise/read SRQ entries

2018-03-20 Thread Raju Rangoju
On Tuesday, March 03/20/18, 2018 at 07:59:22 +0100, Stefano Brivio wrote: > On Tue, 20 Mar 2018 07:58:39 +0100 > Stefano Brivio wrote: > > > On Tue, 20 Mar 2018 11:43:34 +0530 > > Raju Rangoju wrote: > > > > > +struct srq_data *t4_init_srq(int srq_size) >

Re: [RFC PATCH 0/3] kernel: add support for 256-bit IO access

2018-03-20 Thread Ingo Molnar
* Thomas Gleixner wrote: > > Useful also for code that needs AVX-like registers to do things like CRCs. > > x86/crypto/ has a lot of AVX optimized code. Yeah, that's true, but the crypto code is processing fundamentally bigger blocks of data, which amortizes the cost of

Re: [RFC PATCH 0/3] kernel: add support for 256-bit IO access

2018-03-20 Thread Thomas Gleixner
On Tue, 20 Mar 2018, Ingo Molnar wrote: > * Thomas Gleixner wrote: > > > > So I do think we could do more in this area to improve driver > > > performance, if the > > > code is correct and if there's actual benchmarks that are showing real > > > benefits. > > > > If it's

Re: [RFC] ethtool: Support ETHTOOL_GSTATS2 command.

2018-03-20 Thread Michal Kubecek
On Wed, Mar 07, 2018 at 11:51:29AM -0800, gree...@candelatech.com wrote: > From: Ben Greear > > This is similar to ETHTOOL_GSTATS, but it allows you to specify > a 'level'. This level can be used by the driver to decrease the > amount of stats refreshed. In particular,

Re: [RFC PATCH 0/3] kernel: add support for 256-bit IO access

2018-03-20 Thread Rahul Lakkireddy
On Monday, March 03/19/18, 2018 at 20:57:22 +0530, Christoph Hellwig wrote: > On Mon, Mar 19, 2018 at 07:50:33PM +0530, Rahul Lakkireddy wrote: > > This series of patches add support for 256-bit IO read and write. > > The APIs are readqq and writeqq (quad quadword - 4 x 64), that read > > and

[RFC PATCH] net: phy: Added device tree binding for dev-addr and dev-addr code check-up and usage

2018-03-20 Thread Vicentiu Galanopulo
Reason for this patch is that the Inphi PHY has a vendor specific address space for accessing the C45 MDIO registers - starting from 0x1e. A new function has been added, get_phy_c45_dev_addr, which loops through all the PHY device nodes under a MDIO bus node and looks for the property. If it's

RE: interdependencies with cxgb4 and iw_cxgb4

2018-03-20 Thread Steve Wise
> From: Steve Wise > Date: Mon, 19 Mar 2018 14:50:57 -0500 > > > Let me ask a dumb question:  Why cannot one of the maintaners pull the > > commit from the other mainainer's git repo directly?  IE why have this > > third trusted/signed git repo that has to be on k.o,

Re: [bpf-next V2 PATCH 10/15] xdp: rhashtable with allocator ID to pointer mapping

2018-03-20 Thread Jesper Dangaard Brouer
On Tue, 20 Mar 2018 10:26:50 +0800 Jason Wang wrote: > On 2018年03月19日 17:48, Jesper Dangaard Brouer wrote: > > On Fri, 16 Mar 2018 16:45:30 +0800 > > Jason Wang wrote: > > > >> On 2018年03月10日 00:07, Jesper Dangaard Brouer wrote: > >>> On Fri, 9 Mar

Re: [RFC PATCH] net: phy: Added device tree binding for dev-addr and dev-addr code check-up and usage

2018-03-20 Thread Andrew Lunn
On Tue, Mar 20, 2018 at 08:46:15AM -0500, Vicentiu Galanopulo wrote: > Reason for this patch is that the Inphi PHY > has a vendor specific address space for accessing > the C45 MDIO registers - starting from 0x1e. > > A new function has been added, get_phy_c45_dev_addr, > which loops through all

Re: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-20 Thread Alexander Duyck
On Tue, Mar 20, 2018 at 6:32 AM, Rahul Lakkireddy wrote: > On Monday, March 03/19/18, 2018 at 20:13:10 +0530, Thomas Gleixner wrote: >> On Mon, 19 Mar 2018, Rahul Lakkireddy wrote: >> >> > Use VMOVDQU AVX CPU instruction when available to do 256-bit >> > IO read and

[PATCH net] ipv6: sr: fix scheduling in RCU when creating seg6 lwtunnel state

2018-03-20 Thread David Lebrun
From: David Lebrun The seg6_build_state() function is called with RCU read lock held, so we cannot use GFP_KERNEL. This patch uses GFP_ATOMIC instead. [ 92.770271] = [ 92.770628] WARNING: suspicious RCU usage [ 92.770921] 4.16.0-rc4+ #12 Not

[PATCH net] ipv6: sr: fix NULL pointer dereference when setting encap source address

2018-03-20 Thread David Lebrun
From: David Lebrun When using seg6 in encap mode, we call ipv6_dev_get_saddr() to set the source address of the outer IPv6 header, in case none was specified. Using skb->dev can lead to BUG() when it is in an inconsistent state. This patch uses the net_device attached to the

Re: [RFC PATCH 0/3] kernel: add support for 256-bit IO access

2018-03-20 Thread Andy Lutomirski
On Tue, Mar 20, 2018 at 8:26 AM, Ingo Molnar wrote: > > * Thomas Gleixner wrote: > >> > Useful also for code that needs AVX-like registers to do things like CRCs. >> >> x86/crypto/ has a lot of AVX optimized code. > > Yeah, that's true, but the crypto code

Re: [PATCH net] devlink: Remove redundant free on error path

2018-03-20 Thread David Miller
From: Arkadi Sharshevsky Date: Sun, 18 Mar 2018 17:37:22 +0200 > The current code performs unneeded free. Remove the redundant skb freeing > during the error path. > > Fixes: 1555d204e743 ("devlink: Support for pipeline debug (dpipe)") > Signed-off-by: Arkadi Sharshevsky

RE: interdependencies with cxgb4 and iw_cxgb4

2018-03-20 Thread Steve Wise
> >> > Let me ask a dumb question:  Why cannot one of the maintaners pull > the > >> > commit from the other mainainer's git repo directly?  IE why have this > >> > third trusted/signed git repo that has to be on k.o, from which both > >> > maintainers pull?  If one of you can pull it in via a

Re: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-20 Thread Andy Shevchenko
On Tue, Mar 20, 2018 at 3:32 PM, Rahul Lakkireddy wrote: > On Monday, March 03/19/18, 2018 at 20:13:10 +0530, Thomas Gleixner wrote: >> On Mon, 19 Mar 2018, Rahul Lakkireddy wrote: >> Aside of that I very much doubt that this is faster than 4 consecutive >> 64bit

Re: interdependencies with cxgb4 and iw_cxgb4

2018-03-20 Thread David Miller
From: "Steve Wise" Date: Tue, 20 Mar 2018 08:47:04 -0500 >> From: Steve Wise >> Date: Mon, 19 Mar 2018 14:50:57 -0500 >> >> > Let me ask a dumb question:  Why cannot one of the maintaners pull the >> > commit from the other mainainer's

Re: [PATCH] vmxnet3: fix LRO feature check

2018-03-20 Thread David Miller
From: kbuild test robot Date: Sun, 18 Mar 2018 14:37:35 +0800 > All warnings (new ones prefixed by >>): > >drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_rq_rx_complete': >>> drivers/net/vmxnet3/vmxnet3_drv.c:1474:8: warning: suggest parentheses >>> around operand

Re: [PATCH net] ipv6: sr: fix scheduling in RCU when creating seg6 lwtunnel state

2018-03-20 Thread Eric Dumazet
On 03/20/2018 07:44 AM, David Lebrun wrote: > From: David Lebrun > > The seg6_build_state() function is called with RCU read lock held, > so we cannot use GFP_KERNEL. This patch uses GFP_ATOMIC instead. > > > Fixes: 6c8702c60b886 ("ipv6: sr: add support for SRH

Re: interdependencies with cxgb4 and iw_cxgb4

2018-03-20 Thread Leon Romanovsky
On Tue, Mar 20, 2018 at 08:47:04AM -0500, Steve Wise wrote: > > From: Steve Wise > > Date: Mon, 19 Mar 2018 14:50:57 -0500 > > > > > Let me ask a dumb question:  Why cannot one of the maintaners pull the > > > commit from the other mainainer's git repo directly?  IE

Re: pull request: bluetooth 2018-03-16

2018-03-20 Thread David Miller
From: Marcel Holtmann Date: Tue, 20 Mar 2018 09:44:37 +0100 > any issue with this pull request? I ask since it seems to have > disappeared from patchwork. Should be pulled in now, don't know how that happened ;-) Thanks.

Re: [PATCH] Add possibility to turn off promiscuous mode

2018-03-20 Thread David Miller
From: Stephan Mondwurf Date: Tue, 20 Mar 2018 11:28:20 +0100 > The driver is capable of switching on the promiscuous mode. > > This patch adds the possibility to turn it off again. > > Signed-off-by: Stephan Mondwurf Please fix your patch

RE: [RFC PATCH 2/3] x86/io: implement 256-bit IO read and write

2018-03-20 Thread David Laight
From: Rahul Lakkireddy > Sent: 20 March 2018 13:32 ... > On High Availability Server, the logs of the failing system must be > collected as quickly as possible. So, we're concerned with the amount > of time taken to collect our large on-chip memory. We see improvement > in doing 256-bit reads at

Re: [PATCH] mlx5: Remove call to ida_pre_get

2018-03-20 Thread David Miller
From: Maor Gottlieb Date: Tue, 20 Mar 2018 14:41:49 +0200 > Saeed, Matan and I okay with this fix as well, it looks like it > shouldn't impact on the insertion rate. I've applied this to net-next, thanks everyone.

Re: [PATCH] net: dev_forward_skb(): Scrub packet's per-netns info only when crossing netns

2018-03-20 Thread David Miller
From: Liran Alon Date: Tue, 13 Mar 2018 17:07:22 +0200 > Before this commit, dev_forward_skb() always cleared packet's > per-network-namespace info. Even if the packet doesn't cross > network namespaces. There was a lot of discussion about this patch. Particularly

RE: [RFC PATCH 0/3] kernel: add support for 256-bit IO access

2018-03-20 Thread David Laight
From: Andy Lutomirski > Sent: 20 March 2018 14:57 ... > I'd rather see us finally finish the work that Rik started to rework > this differently. I'd like kernel_fpu_begin() to look like: > > if (test_thread_flag(TIF_NEED_FPU_RESTORE)) { > return; // we're already okay. maybe we need to check

linux-next: ip6tables *broken* - last base chain position %u doesn't match underflow %u (hook %u

2018-03-20 Thread valdis . kletnieks
(Resending because I haven't heard anything) Am hitting an issue with this commit: commit 0d7df906a0e78079a02108b06d32c3ef2238ad25 Author: Florian Westphal Date: Tue Feb 27 19:42:37 2018 +0100 netfilter: x_tables: ensure last rule in base chain matches underflow/policy

Re: [PATCH iproute2 net-next] bridge: add option extern_learn to set NTF_EXT_LEARNED on fdb entries

2018-03-20 Thread David Ahern
On 3/19/18 12:05 PM, Roopa Prabhu wrote: > On Mon, Mar 19, 2018 at 10:56 AM, David Ahern wrote: >> On 3/19/18 11:54 AM, Stephen Hemminger wrote: >>> On Mon, 19 Mar 2018 10:20:10 -0700 >>> Roopa Prabhu wrote: >>> From: Roopa Prabhu

  1   2   3   >