Re: [PATCH 1/2] net: phy: Helper function for reading strapped configuration values

Florian Fainelli writes: > On 04/05/2018 04:44 AM, esben.haaben...@gmail.com wrote: >> From: Esben Haabendal >> >> Add a function for use in PHY driver probe functions, reading current >> autoneg, speed and duplex configuration from BMCR register. >> >>

Re: [PATCH 2/2] net: phy: dp83640: Read strapped configuration settings

Florian Fainelli writes: > On 04/05/2018 04:44 AM, esben.haaben...@gmail.com wrote: >> From: Esben Haabendal >> >> Read configration settings, to allow automatic forced speed/duplex setup >> by hardware strapping. > > OK but why? What problem is this

Re: [PATCH 2/2] net: phy: dp83640: Read strapped configuration settings

On Thu, Apr 05, 2018 at 10:30:45PM +0200, Esben Haabendal wrote: > Florian Fainelli writes: > > > On 04/05/2018 04:44 AM, esben.haaben...@gmail.com wrote: > >> From: Esben Haabendal > >> > >> Read configration settings, to allow automatic forced

[RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF without the need to setup a bond/team between a VF and virtio net device in the guest. The hypervisor needs to enable

[RFC PATCH net-next v5 4/4] netvsc: refactor notifier/event handling code to use the bypass framework

Use the registration/notification framework supported by the generic bypass infrastructure. Signed-off-by: Sridhar Samudrala --- drivers/net/hyperv/Kconfig | 1 + drivers/net/hyperv/netvsc_drv.c | 219 2 files changed,

[RFC PATCH net-next v5 0/4] Enable virtio_net to act as a backup for a passthru device

The main motivation for this patch is to enable cloud service providers to provide an accelerated datapath to virtio-net enabled VMs in a transparent manner with no/minimal guest userspace changes. This also enables hypervisor controlled live migration to be supported with VMs that have direct

[RFC PATCH net-next v5 2/4] net: Introduce generic bypass module

This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover their datapath. The notifier and event handling code is based on the existing netvsc implementation. A paravirtual driver

[RFC PATCH net-next v5 1/4] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

This feature bit can be used by hypervisor to indicate virtio_net device to act as a backup for another device with the same MAC address. VIRTIO_NET_F_BACKUP is defined as bit 62 as it is a device feature bit. Signed-off-by: Sridhar Samudrala ---

[PATCH net] net/sched: fix NULL dereference in the error path of tcf_bpf_init()

when tcf_bpf_init_from_ops() fails (e.g. because of program having invalid number of instructions), tcf_bpf_cfg_cleanup() calls bpf_prog_put(NULL) or bpf_prog_destroy(NULL). Unless CONFIG_BPF_SYSCALL is unset, this causes the following error: BUG: unable to handle kernel NULL pointer dereference

Re: [PATCH net-next 6/6] netdevsim: Add simple FIB resource controller via devlink

On 4/5/18 11:27 AM, Jiri Pirko wrote: > Wed, Mar 28, 2018 at 03:22:00AM CEST, d...@cumulusnetworks.com wrote: >> Add devlink support to netdevsim and use it to implement a simple, >> profile based resource controller. Only one controller is needed >> per namespace, so the first netdevsim netdevice

Re: marvell switch

> > Hi Ran > > > > The Marvell driver makes each port act like a normal Linux network > > interface. So if you want to enable a port, do > > > > ip link set lan0 up > > > > Want to add an ip address to a port > > > > ip addr add 10.42.42.42/24 dev lan0 > > > > Want to bridge two ports > > > > ip

Re: [patch net] devlink: convert occ_get op to separate registration

On 4/5/18 2:55 PM, David Ahern wrote: > @@ -154,6 +155,12 @@ void *mlxsw_core_driver_priv(struct mlxsw_core > *mlxsw_core) > } > EXPORT_SYMBOL(mlxsw_core_driver_priv); > > +bool mlxsw_core_reload_in_progress(struct mlxsw_core *mlxsw_core) > +{ > + return

Re: [PATCH net 0/6] net: better validate user provided tunnel names

On 04/05/2018 12:21 PM, David Miller wrote: > From: Eric Dumazet > Date: Thu, 5 Apr 2018 06:39:25 -0700 > >> This series changes dev_valid_name() to not attempt reading >> a possibly too long user-provided device name, then use >> this helper in five different tunnel

Re: [PATCH iproute2] l2tp: no need to export session offsets in JSON output

On Thu, 5 Apr 2018 19:24:17 +0200 Guillaume Nault wrote: > The offset and peer_offset parameters are only printed to avoid > confusing external scripts that may parse "ip l2tp show session" > output. There's no reason to keep them in JSON. > > Signed-off-by: Guillaume

Enable and configure storm prevention in a network device

Hello Netdev experts, Is there a standard way to implement and configure storm prevention in a Linux network device? Our NIC firmware has the capability to enable storm prevention which is implemented using a credit based scheme. The configuration is how many number of multicast + broadcast

[PATCH v2] net: phy: marvell: Enable interrupt function on LED2 pin

From: Esben Haabendal The LED2[2]/INTn pin on Marvell 88E1318S as well as 88E1510/12/14/18 needs to be configured to be usable as interrupt not only when WOL is enabled, but whenever we rely on interrupts from the PHY. Signed-off-by: Esben Haabendal Cc: Rasmus

Re: [PATCH net] net: dsa: Discard frames from unused ports

On 04/04/2018 07:17 PM, Andrew Lunn wrote: > On Wed, Apr 04, 2018 at 05:49:10PM -0700, Florian Fainelli wrote: >> On 04/04/2018 04:56 PM, Andrew Lunn wrote: >>> The Marvell switches under some conditions will pass a frame to the >>> host with the port being the CPU port. Such frames are invalid,

Re: Enable and configure storm prevention in a network device

On 04/05/2018 01:20 PM, David Miller wrote: > From: Murali Karicheri > Date: Thu, 5 Apr 2018 16:14:49 -0400 > >> Is there a standard way to implement and configure storm prevention >> in a Linux network device? > > What kind of "storm", an interrupt storm? > I would

Re: Enable and configure storm prevention in a network device

From: Murali Karicheri Date: Thu, 5 Apr 2018 16:14:49 -0400 > Is there a standard way to implement and configure storm prevention > in a Linux network device? What kind of "storm", an interrupt storm?

[PATCH net] net/ipv6: Increment OUTxxx counters after netfilter hook

At the end of ip6_forward(), IPSTATS_MIB_OUTFORWDATAGRAMS and IPSTATS_MIB_OUTOCTETS are incremented immediately before the NF_HOOK call for NFPROTO_IPV6 / NF_INET_FORWARD. As a result, these counters get incremented regardless of whether or not the netfilter hook allows the packet to continue

Re: [iovisor-dev] Best userspace programming API for XDP features query to kernel?

On Thu, 5 Apr 2018 22:51:33 +0200, Jesper Dangaard Brouer wrote: > > What about nfp in terms of XDP > > offload capabilities, should they be included as well or is probing to load > > the program and see if it loads/JITs as we do today just fine (e.g. you'd > > otherwise end up with extra flags on

Re: [patch net] devlink: convert occ_get op to separate registration

On 4/5/18 2:13 PM, Jiri Pirko wrote: > From: Jiri Pirko > > This resolves race during initialization where the resources with > ops are registered before driver and the structures used by occ_get > op is initialized. So keep occ_get callbacks registered only when > all structs

[patch net] devlink: convert occ_get op to separate registration

From: Jiri Pirko This resolves race during initialization where the resources with ops are registered before driver and the structures used by occ_get op is initialized. So keep occ_get callbacks registered only when all structs are initialized. The example flows, as it is in

Re: [PATCH 2/2] net: phy: dp83640: Read strapped configuration settings

Florian Fainelli writes: > On 04/05/2018 04:44 AM, esben.haaben...@gmail.com wrote: >> From: Esben Haabendal >> >> Read configration settings, to allow automatic forced speed/duplex setup >> by hardware strapping. > > OK but why? What problem is this

Re: [PATCH 1/2] net: phy: Helper function for reading strapped configuration values

Florian Fainelli writes: > On 04/05/2018 04:44 AM, esben.haaben...@gmail.com wrote: >> From: Esben Haabendal >> >> Add a function for use in PHY driver probe functions, reading current >> autoneg, speed and duplex configuration from BMCR register. >> >>

Re: [iovisor-dev] Best userspace programming API for XDP features query to kernel?

On Thu, 5 Apr 2018 12:37:19 +0200 Daniel Borkmann wrote: > On 04/04/2018 02:28 PM, Jesper Dangaard Brouer via iovisor-dev wrote: > > Hi Suricata people, > > > > When Eric Leblond (and I helped) integrated XDP in Suricata, we ran > > into the issue, that at Suricata

Re: [PATCH net-next 6/6] netdevsim: Add simple FIB resource controller via devlink

On 4/5/18 2:10 PM, David Ahern wrote: > > The ASIC here is the kernel tables in a namespace. It does not make > sense to have 2 devlink instances for a single namespace. I put this example controller in netdevsim per a suggestion from Ido. The netdevsim seemed like a good idea given that modules

Re: [patch net] devlink: convert occ_get op to separate registration

Thu, Apr 05, 2018 at 10:55:58PM CEST, dsah...@gmail.com wrote: >On 4/5/18 2:13 PM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> This resolves race during initialization where the resources with >> ops are registered before driver and the structures used by occ_get >> op is

Re: [PATCH net] netns: filter uevents correctly

From: Christian Brauner Date: Thu, 05 Apr 2018 01:27:16 + > David, is it ok to queue this or would you prefer I resend when net-next > reopens? This definitely needs more discussion, and after the discussion some further clarification in the commit log

Re: [PATCH net] net: dsa: Discard frames from unused ports

From: Andrew Lunn Date: Thu, 5 Apr 2018 01:56:44 +0200 > The Marvell switches under some conditions will pass a frame to the > host with the port being the CPU port. Such frames are invalid, and > should be dropped. Not dropping them can result in a crash when > incrementing the

Re: [PATCH net-next] hv_netvsc: Add NetVSP v6 into version negotiation

From: Haiyang Zhang Date: Thu, 5 Apr 2018 11:42:22 -0700 > From: Haiyang Zhang > > This patch adds the NetVSP v6 message structures, and includes this > version into NetVSC/NetVSP version negotiation process. > > Signed-off-by: Haiyang

Re: KASAN: use-after-free Read in worker_thread (2)

On Sat, Nov 11, 2017 at 07:56:01AM -0800, syzbot wrote: > syzkaller has found reproducer for the following crash on > d9e0e63d9a6f88440eb201e1491fcf730272c706 > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw

Re: [PATCH 5/6] rhashtable: support guaranteed successful insertion.

On Fri, Apr 06, 2018 at 01:11:56PM +1000, NeilBrown wrote: > > You don't need to handle memory allocation failures at the point where > you insert into the table - adding to a linked list requires no new > memory. You do actually. The r in rhashtable stands for resizable. We cannot completely

Re: [PATCH 3/9] kbuild: Do not pass arguments to link-vmlinux.sh

2018-04-06 3:59 GMT+09:00 Jiri Olsa : > On Fri, Apr 06, 2018 at 12:50:00AM +0900, Masahiro Yamada wrote: >> 2018-04-06 0:16 GMT+09:00 Jiri Olsa : >> > There's no need to pass LD* arguments to link-vmlinux.sh, >> > because they are passed as variables. The only

Packet corrupts to guest system system from host kernel 4.16.x

Why, when using the 4.16 kernel on the host system, is there such a strange behavior of virtual machines? What is the problem? He rolled back to 4.9.c - the problem was gone. tcpdump on router: tcpdump: listening on vlan-00110013, link-type EN10MB (Ethernet), capture size 262144 bytes

Re: [PATCH v15 ] net/veth/XDP: Line-rate packet forwarding in kernel

On 4/3/18 9:15 PM, Md. Islam wrote: >> Have you looked at what I would consider a more interesting use case of >> packets into a node and delivered to a namespace via veth? >> >>+--+--- >>| Host | container >>|

Re: [PATCH 1/2] af_key: Use DIV_ROUND_UP() instead of open-coded equivalent

On Wed, Mar 28, 2018 at 09:35:26PM -0400, Kevin Easton wrote: > On Wed, Mar 28, 2018 at 07:59:25AM +0200, Steffen Klassert wrote: > > On Mon, Mar 26, 2018 at 07:39:16AM -0400, Kevin Easton wrote: > > > Several places use (x + 7) / 8 to convert from a number of bits to a > > > number > > > of

Re: [PATCH net-next 6/6] netdevsim: Add simple FIB resource controller via devlink

Thu, Apr 05, 2018 at 11:06:41PM CEST, d...@cumulusnetworks.com wrote: >On 4/5/18 2:10 PM, David Ahern wrote: >> >> The ASIC here is the kernel tables in a namespace. It does not make >> sense to have 2 devlink instances for a single namespace. > >I put this example controller in netdevsim per a

Re: [PATCH v2 bpf-next 0/3] bpf/verifier: subprog/func_call simplifications

On Thu, Apr 05, 2018 at 04:50:03PM +0100, Jiong Wang wrote: > On 03/04/2018 02:08, Alexei Starovoitov wrote: > > Combining subprog pass with do_check is going into opposite direction > > of this long term work. Divide and conquer. Combining more things into > > do_check is the opposite of this

Re: [Cluster-devel] [PATCH v2 0/2] gfs2: Stop using rhashtable_walk_peek

On Wed, Apr 04 2018, Andreas Grünbacher wrote: > Herbert Xu schrieb am Mi. 4. Apr. 2018 um > 17:51: > >> On Wed, Apr 04, 2018 at 11:46:28AM -0400, Bob Peterson wrote: >> > >> > The patches look good. The big question is whether to add them to this >> > merge window

Re: [PATCH 08/32] aio: replace kiocb_set_cancel_fn with a cancel_kiocb file operation

On Fri, Mar 30, 2018 at 05:07:45PM +0200, Christoph Hellwig wrote: > The current kiocb_set_cancel_fn implementation assumes the kiocb is > embedded into an aio_kiocb, which is fundamentally unsafe as it might > have been submitted by non-aio callers. Instead add a cancel_kiocb > file operation

Re: [PATCH net] net: mvpp2: Fix parser entry init boundary check

From: Maxime Chevallier Date: Thu, 5 Apr 2018 11:55:48 +0200 > Boundary check in mvpp2_prs_init_from_hw must be done according to the > passed "tid" parameter, not the mvpp2_prs_entry index, which is not yet > initialized at the time of the check. > > Fixes:

Re: [PATCH net-next 6/6] netdevsim: Add simple FIB resource controller via devlink

Thu, Apr 05, 2018 at 10:10:29PM CEST, d...@cumulusnetworks.com wrote: >On 4/5/18 11:27 AM, Jiri Pirko wrote: >> Wed, Mar 28, 2018 at 03:22:00AM CEST, d...@cumulusnetworks.com wrote: >>> Add devlink support to netdevsim and use it to implement a simple, >>> profile based resource controller. Only

[no subject]

Hi Netdevhttps://goo.gl/5bDZtk

Re: [PATCH 0/4] hv_netvsc: Fix shutdown issues on older Windows hosts

From: Mohammed Gamal Date: Thu, 5 Apr 2018 21:09:17 +0200 > Guests running on WS2012 hosts would not shutdown when changing network > interface setting (e.g. Number of channels, MTU ... etc). > > This patch series addresses these shutdown issues we enecountered with WS2012

Re: [PATCH net-next] netns: filter uevents correctly

Christian Brauner writes: > On Thu, Apr 05, 2018 at 05:26:59PM +0300, Kirill Tkhai wrote: >> On 05.04.2018 17:07, Christian Brauner wrote: >> > On Thu, Apr 05, 2018 at 04:01:03PM +0300, Kirill Tkhai wrote: >> >> On 04.04.2018 22:48, Christian Brauner wrote: >>

Re: [PATCH 2/2] net: phy: dp83640: Read strapped configuration settings

From: Andrew Lunn Date: Thu, 5 Apr 2018 22:40:49 +0200 > Or could it still contain whatever state the last boot of Linux, or > maybe the bootloader, left the PHY in? Right, this is my concern as well.

Re: [PATCH net] net/ipv6: Increment OUTxxx counters after netfilter hook

From: Jeff Barnhill <0xeff...@gmail.com> Date: Thu, 5 Apr 2018 21:29:47 + > At the end of ip6_forward(), IPSTATS_MIB_OUTFORWDATAGRAMS and > IPSTATS_MIB_OUTOCTETS are incremented immediately before the NF_HOOK call > for NFPROTO_IPV6 / NF_INET_FORWARD. As a result, these counters get >

[PATCH] make net_gso_ok return false when gso_type is zero(invalid)

Signed-off-by: Wenhua Shi --- include/linux/netdevice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index cf44503e..1f26cbcf 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@

Re: [PATCH net] arp: fix arp_filter on l3slave devices

From: David Ahern Date: Thu, 5 Apr 2018 08:40:48 -0600 > On 4/5/18 2:25 AM, Miguel Fadon Perlines wrote: >> arp_filter performs an ip_route_output search for arp source address and >> checks if output device is the same where the arp request was received, >> if it is not, the

Re: [PATCH 05/32] fs: introduce new ->get_poll_head and ->poll_mask methods

On Fri, Mar 30, 2018 at 05:07:42PM +0200, Christoph Hellwig wrote: > + get_poll_head: Returns the struct wait_queue_head that poll, select, > + epoll or aio poll should wait on in case this instance only has single > + waitqueue. Can return NULL to indicate polling is not supported, > + or a

[PATCH ethtool] ethtool: Add register dump support for MICROCHIP LAN78xx

This patch adds support for Microchip's lan78xx families of USB Ethernet controllers to ethtool's dump registers command. This patch is for use with the lan78xx driver. Signed-off-by: Raghuram Chary J --- Makefile.am | 2 +- ethtool.c | 1 +

Re: [PATCH v2] Bluetooth: Remove VLA usage in aes_cmac

On 04/05/2018 03:46 AM, Marcel Holtmann wrote: By the way, what is you opinion on replacing crypto_shash_descsize(ctx) with PAGE_SIZE / 8 in SHASH_DESC_ON_STACK? Does it work for you? isn’t that just waste? Agree. The macro itself is this. #define SHASH_DESC_ON_STACK(shash, ctx)

[PATCH net] net: mvpp2: Fix parser entry init boundary check

Boundary check in mvpp2_prs_init_from_hw must be done according to the passed "tid" parameter, not the mvpp2_prs_entry index, which is not yet initialized at the time of the check. Fixes: 47e0e14eb1a6 ("net: mvpp2: Make mvpp2_prs_hw_read a parser entry init function") Signed-off-by: Maxime

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

Hello, My 2c below. On 04/04/2018 03:42 PM, Andrew Lunn wrote: >> I hear you. It is more complicated this way...having all these individual >> objects vs just a single "bundle" of them that represents a NIC. But, that's >> the way the DPAA2 hardware is, and we're implementing kernel support

[PATCH 2/2] net: phy: dp83640: Read strapped configuration settings

From: Esben Haabendal Read configration settings, to allow automatic forced speed/duplex setup by hardware strapping. Signed-off-by: Esben Haabendal Cc: Rasmus Villemoes --- drivers/net/phy/dp83640.c | 5 + 1 file changed, 5

[PATCH 1/2] net: phy: Helper function for reading strapped configuration values

From: Esben Haabendal Add a function for use in PHY driver probe functions, reading current autoneg, speed and duplex configuration from BMCR register. Useful for PHY that supports hardware strapped configuration, enabling Linux to respect that configuration (i.e. strapped

Re: [iovisor-dev] Best userspace programming API for XDP features query to kernel?

On 04/04/2018 02:28 PM, Jesper Dangaard Brouer via iovisor-dev wrote: > Hi Suricata people, > > When Eric Leblond (and I helped) integrated XDP in Suricata, we ran > into the issue, that at Suricata load/start time, we cannot determine > if the chosen XDP config options, like xdp-cpu-redirect[1],

[RFC] ethtool: Support for driver private ioctl's

Hi All, I would like to know your opinion regarding adding support for driver private ioctl's in ethtool. Background: Synopsys Ethernet IP's have a certain number of features which can be reconfigured at runtime. Giving you two examples: One of the most recent one is the safety features, which

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

On Thu, Apr 05, 2018 at 10:30:01AM +, Laurentiu Tudor wrote: > Hello, > > My 2c below. > > On 04/04/2018 03:42 PM, Andrew Lunn wrote: > >> I hear you. It is more complicated this way...having all these individual > >> objects vs just a single "bundle" of them that represents a NIC. But, >

Re: [PATCH v2] Bluetooth: Remove VLA usage in aes_cmac

Hi Gustavo, > In preparation to enabling -Wvla, remove VLA and replace it > with dynamic memory allocation instead. > > The use of stack Variable Length Arrays needs to be avoided, as they > can be a vector for stack exhaustion, which can be both a runtime bug > or a security flaw. Also, in

Re: [PATCH v2 bpf-next 0/3] bpf/verifier: subprog/func_call simplifications

On 05/04/18 06:28, Alexei Starovoitov wrote: > On Thu, Apr 05, 2018 at 12:58:46AM +0100, Edward Cree wrote: >> On 04/04/18 00:37, Alexei Starovoitov wrote: >>> hmm. that doesn't fail for me and any other bots didn't complain. >>> Are you sure you're running the latest kernel and tests? >> Ah,

[PATCH net] arp: fix arp_filter on l3slave devices

arp_filter performs an ip_route_output search for arp source address and checks if output device is the same where the arp request was received, if it is not, the arp request is not answered. This route lookup is always done on main route table so l3slave devices never find the proper route and

Re: [PATCH 00/15] ARM: pxa: switch to DMA slave maps

On Thu, Apr 5, 2018 at 8:29 AM, Ulf Hansson wrote: > On 4 April 2018 at 21:56, Boris Brezillon wrote: >> On Wed, 04 Apr 2018 21:49:26 +0200 >> Robert Jarzmik wrote: >> >>> Ulf Hansson writes:

Re: [PATCH 00/15] ARM: pxa: switch to DMA slave maps

On 4 April 2018 at 21:56, Boris Brezillon wrote: > On Wed, 04 Apr 2018 21:49:26 +0200 > Robert Jarzmik wrote: > >> Ulf Hansson writes: >> >> > On 2 April 2018 at 16:26, Robert Jarzmik wrote: >>

Re: [PATCH v2] Bluetooth: Remove VLA usage in aes_cmac

Hi Gustavo, >> so I took this patch back out of bluetooth-next before sending the pull >> request. I think the discussion on how to fix SHASH_DESC_ON_STACK macro >> needs to complete first. Once that has concluded we can revisit if this >> patch is still needed or if another solution has been

Re: [PATCH v2] Bluetooth: Remove VLA usage in aes_cmac

Hi Marcel, On 04/05/2018 02:23 AM, Marcel Holtmann wrote: so I took this patch back out of bluetooth-next before sending the pull request. I think the discussion on how to fix SHASH_DESC_ON_STACK macro needs to complete first. Once that has concluded we can revisit if this patch is still

Re: marvell switch

On Thu, Apr 05, 2018 at 05:47:24AM +0300, Ran Shalit wrote: > Hello, > > I am trying to use marvell switch in linux, > Is it that the kernel drivers from marvell switch are used just to > enable all ports, or do they also provide APIs to userspace to enable > specific ports only. > I have not

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

On Thu, Apr 05, 2018 at 10:30:01AM +, Laurentiu Tudor wrote: > Hello, > > My 2c below. > > On 04/04/2018 03:42 PM, Andrew Lunn wrote: > >> I hear you. It is more complicated this way...having all these individual > >> objects vs just a single "bundle" of them that represents a NIC. But, >

Re: [PATCH 00/12] Ethernet: Add and use ether__addr globals

On 2018-04-05 15:51, Joe Perches wrote: >> You have to factor in >> not just the .text size, but the fact that referencing an exported >> symbol needs a .reloc entry as well, which also eats up some space (at >> least when the code is being built as module). > > Thanks, the modules I built got

Re: [PATCH net-next] netns: filter uevents correctly

On 04.04.2018 22:48, Christian Brauner wrote: > commit 07e98962fa77 ("kobject: Send hotplug events in all network namespaces") > > enabled sending hotplug events into all network namespaces back in 2010. > Over time the set of uevents that get sent into all network namespaces has > shrunk. We

net_dim() may use uninitialized data

Hi Tal, With gcc-4.1.2: drivers/net/ethernet/broadcom/bcmsysport.c: In function ‘bcm_sysport_poll’: include/linux/net_dim.h:354: warning: ‘curr_stats.ppms’ may be used uninitialized in this function include/linux/net_dim.h:354: warning: ‘curr_stats.bpms’ may be used uninitialized in

RE: [PATCH] net: phy: marvell: Enable interrupt function on LED2 pin

Hi Esben, -Original Message- From: netdev-ow...@vger.kernel.org On Behalf Of Esben Haabendal Sent: Thursday, April 05, 2018 7:05 PM To: netdev@vger.kernel.org Cc: Esben Haabendal ; Rasmus Villemoes ; Andrew Lunn

Re: [PATCH net-next] netns: filter uevents correctly

On 05.04.2018 17:07, Christian Brauner wrote: > On Thu, Apr 05, 2018 at 04:01:03PM +0300, Kirill Tkhai wrote: >> On 04.04.2018 22:48, Christian Brauner wrote: >>> commit 07e98962fa77 ("kobject: Send hotplug events in all network >>> namespaces") >>> >>> enabled sending hotplug events into all

Re: [PATCH net-next] netns: filter uevents correctly

On Thu, Apr 05, 2018 at 05:26:59PM +0300, Kirill Tkhai wrote: > On 05.04.2018 17:07, Christian Brauner wrote: > > On Thu, Apr 05, 2018 at 04:01:03PM +0300, Kirill Tkhai wrote: > >> On 04.04.2018 22:48, Christian Brauner wrote: > >>> commit 07e98962fa77 ("kobject: Send hotplug events in all network

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

On 04/05/2018 02:47 PM, Andrew Lunn wrote: > On Thu, Apr 05, 2018 at 10:30:01AM +, Laurentiu Tudor wrote: >> Hello, >> >> My 2c below. >> >> On 04/04/2018 03:42 PM, Andrew Lunn wrote: I hear you. It is more complicated this way...having all these individual objects vs just a

Re: [PATCH ethtool] ethtool: Add register dump support for MICROCHIP LAN78xx

On Thu, Apr 05, 2018 at 11:41:28AM +0530, Raghuram Chary J wrote: Hi Raghuram > + fprintf(stdout, "PHY Registers:\n"); > + fprintf(stdout, "--\n"); > + fprintf(stdout, "Mode Control = 0x%04X\n", *lan78xx_reg++); > + fprintf(stdout, "Mode Status = 0x%04X\n",

Re: [v2] net: thunderx: nicvf_main: Fix potential NULL pointer dereferences

Hi guys, Please give me couple days to workout solution for this. I'll post patch for this as soon as I done with my testing. WBR, Vadim On Tue, Apr 03, 2018 at 05:04:23PM -0500, Gustavo A. R. Silva wrote: > Add null check on kmalloc() return value in order to prevent > a null pointer

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

> > Hi Laurentiu > > > > So i can use switchdev without it? I can modprobe the switchdev > > driver, all the physical interfaces will appear, and i can use ip addr > > add etc. I do not need to use a user space tool at all in order to use > > the network functionality? > > Absolutely! Great.

Re: [PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address

Kalle Valo writes: > Joe Perches writes: > >> Use the new ether_broadcast_addr global instead to save some object code. >> >> Signed-off-by: Joe Perches >> --- >> drivers/net/wireless/admtek/adm8211.c | 3 +-- >>

Re: [PATCH 00/12] Ethernet: Add and use ether__addr globals

On Thu, 2018-04-05 at 15:27 +0200, Felix Fietkau wrote: > On 2018-03-31 09:05, Joe Perches wrote: > > There are many local static and non-static arrays that are used for > > Ethernet broadcast address output or comparison. > > > > Centralize the array into a single separate file and remove the

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

Hi Greg, On 04/05/2018 03:30 PM, gregkh wrote: > On Thu, Apr 05, 2018 at 10:30:01AM +, Laurentiu Tudor wrote: >> Hello, >> >> My 2c below. >> >> On 04/04/2018 03:42 PM, Andrew Lunn wrote: I hear you. It is more complicated this way...having all these individual objects vs just a

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

Ulf Hansson writes: > On 20 March 2018 at 10:55, Kalle Valo wrote: >> Arend van Spriel writes: >> > If I get it right, you mean something like this: > > mmc3: mmc@1c12000 { > ... >

Re: [PATCH 00/12] Ethernet: Add and use ether__addr globals

On 2018-03-31 09:05, Joe Perches wrote: > There are many local static and non-static arrays that are used for > Ethernet broadcast address output or comparison. > > Centralize the array into a single separate file and remove the local > arrays. I suspect that for many targets and configurations,

[PATCH] net: phy: marvell: Enable interrupt function on LED2 pin

From: Esben Haabendal The LED2[2]/INTn pin on Marvell 88E1318S as well as 88E1510/12/14/18 needs to be configured to be usable as interrupt not only when WOL is enabled, but whenever we rely on interrupts from the PHY. Signed-off-by: Esben Haabendal Cc: Rasmus

Re: [PATCH net] arp: fix arp_filter on l3slave devices

On 4/5/18 2:25 AM, Miguel Fadon Perlines wrote: > arp_filter performs an ip_route_output search for arp source address and > checks if output device is the same where the arp request was received, > if it is not, the arp request is not answered. > > This route lookup is always done on main route

Re: [PATCH net-next] netns: filter uevents correctly

On Thu, Apr 05, 2018 at 04:01:03PM +0300, Kirill Tkhai wrote: > On 04.04.2018 22:48, Christian Brauner wrote: > > commit 07e98962fa77 ("kobject: Send hotplug events in all network > > namespaces") > > > > enabled sending hotplug events into all network namespaces back in 2010. > > Over time the

Re: [PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address

Joe Perches writes: > Use the new ether_broadcast_addr global instead to save some object code. > > Signed-off-by: Joe Perches > --- > drivers/net/wireless/admtek/adm8211.c | 3 +-- > drivers/net/wireless/ath/carl9170/mac.c | 4 +--- >

[PATCH net 4/6] ip6_gre: better validate user provided tunnel names

Use dev_valid_name() to make sure user does not provide illegal device name. syzbot caught the following bug : BUG: KASAN: stack-out-of-bounds in strlcpy include/linux/string.h:300 [inline] BUG: KASAN: stack-out-of-bounds in ip6gre_tunnel_locate+0x334/0x860 net/ipv6/ip6_gre.c:339 Write of size

[PATCH net 5/6] ip6_tunnel: better validate user provided tunnel names

Use valid_name() to make sure user does not provide illegal device name. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Eric Dumazet --- net/ipv6/ip6_tunnel.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/net/ipv6/ip6_tunnel.c

[PATCH net 2/6] ip_tunnel: better validate user provided tunnel names

Use dev_valid_name() to make sure user does not provide illegal device name. syzbot caught the following bug : BUG: KASAN: stack-out-of-bounds in strlcpy include/linux/string.h:300 [inline] BUG: KASAN: stack-out-of-bounds in __ip_tunnel_create+0xca/0x6b0 net/ipv4/ip_tunnel.c:257 Write of size

[PATCH net 3/6] ipv6: sit: better validate user provided tunnel names

Use dev_valid_name() to make sure user does not provide illegal device name. syzbot caught the following bug : BUG: KASAN: stack-out-of-bounds in strlcpy include/linux/string.h:300 [inline] BUG: KASAN: stack-out-of-bounds in ipip6_tunnel_locate+0x63b/0xaa0 net/ipv6/sit.c:254 Write of size 33 at

[PATCH net 0/6] net: better validate user provided tunnel names

This series changes dev_valid_name() to not attempt reading a possibly too long user-provided device name, then use this helper in five different tunnel providers. Eric Dumazet (6): net: fool proof dev_valid_name() ip_tunnel: better validate user provided tunnel names ipv6: sit: better

[PATCH net 1/6] net: fool proof dev_valid_name()

We want to use dev_valid_name() to validate tunnel names, so better use strnlen(name, IFNAMSIZ) than strlen(name) to make sure to not upset KASAN. Signed-off-by: Eric Dumazet --- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net 6/6] vti6: better validate user provided tunnel names

Use valid_name() to make sure user does not provide illegal device name. Fixes: ed1efb2aefbb ("ipv6: Add support for IPsec virtual tunnel interfaces") Signed-off-by: Eric Dumazet Cc: Steffen Klassert --- net/ipv6/ip6_vti.c | 7 +-- 1 file

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

On Thu, Apr 05, 2018 at 02:09:47PM +, Laurentiu Tudor wrote: > Hi Greg, > > On 04/05/2018 03:30 PM, gregkh wrote: > > On Thu, Apr 05, 2018 at 10:30:01AM +, Laurentiu Tudor wrote: > >> Hello, > >> > >> My 2c below. > >> > >> On 04/04/2018 03:42 PM, Andrew Lunn wrote: > I hear you. It

Re: [PATCH] net: thunderx: rework mac addresses list to u64 array

> struct xcast_addr_list { > - struct list_head list; > int count; > + u64 mc[0]; Please use the standard C99 syntax here: u64 mc[]; > + mc_list = kmalloc(sizeof(*mc_list) + > +

Re: [virtio-dev] Re: [RFC PATCH 1/3] qemu: virtio-bypass should explicitly bind to a passthrough device

On 04/04/2018 10:02, Siwei Liu wrote: >> pci_bus_num is almost always a bug if not done within >> a context of a PCI host, bridge, etc. >> >> In particular this will not DTRT if run before guest assigns bus >> numbers. >> > I was seeking means to reserve a specific pci bus slot from drivers, > and

[PATCH] qtnfmac: pearl: pcie: fix memory leak in qtnf_fw_work_handler

In case memory resources for fw were succesfully allocated, release them before jumping to fw_load_fail. Addresses-Coverity-ID: 1466092 ("Resource leak") Fixes: c3b2f7ca4186 ("qtnfmac: implement asynchronous firmware loading") Signed-off-by: Gustavo A. R. Silva ---

[RFC 0/9] bpf: Add buildid check support

hi, eBPF programs loaded for kprobes are allowed to read kernel internal structures. We check the provided kernel version to ensure that the program is loaded for the proper kernel. The problem is that the version check is not enough, because it only follows the version setup from kernel's

  1   2   >