[PATCH] liquidio: Use %pad printk format for dma_addr_t values

2018-07-12 Thread Helge Deller
Use the existing %pad printk format to print dma_addr_t values. This avoids the following warnings when compiling on the parisc platform: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 2 has type 'dma_addr_t {aka unsigned int}' [-Wformat=] Signed-off-by: H

[PATCH net-next 0/4] Further ARM BPF jit compiler improvements

2018-07-12 Thread Russell King - ARM Linux
Four further jit compiler improves for 32-bit ARM. arch/arm/net/bpf_jit_32.c | 120 -- 1 file changed, 73 insertions(+), 47 deletions(-) -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia:

[PATCH net-next 1/4] ARM: net: bpf: improve 64-bit load immediate implementation

2018-07-12 Thread Russell King
Rather than writing each 32-bit half of the 64-bit immediate value separately when the register is on the stack: movwr6, #45056 ; 0xb000 movtr6, #60979 ; 0xee33 str r6, [fp, #-44] ; 0xffd4 mov r6, #0 str r6, [fp, #-40] ; 0xffd8 arrange to use the

[PATCH net-next 2/4] ARM: net: bpf: improve 64-bit sign-extended immediate load

2018-07-12 Thread Russell King
Improve the 64-bit sign-extended immediate from: mov r6, #1 str r6, [fp, #-52] ; 0xffcc mov r6, #0 str r6, [fp, #-48] ; 0xffd0 to: mov r6, #1 mov r7, #0 strdr6, [fp, #-52] ; 0xffcc Signed-off-by: Russell King --- arch/arm/net/bpf_jit_32

[PATCH net-next 3/4] ARM: net: bpf: improve 64-bit store implementation

2018-07-12 Thread Russell King
Improve the 64-bit store implementation from: ldr r6, [fp, #-8] str r8, [r6] ldr r6, [fp, #-8] mov r7, #4 add r7, r6, r7 str r9, [r7] to: ldr r6, [fp, #-8] str r8, [r6] str r9, [r6, #4] We leave the store as two separate STR instructions rat

[PATCH net-next 4/4] ARM: net: bpf: improve 64-bit ALU implementation

2018-07-12 Thread Russell King
Improbe the 64-bit ALU implementation from: movwr8, #65532 movtr8, #65535 movwr9, #65535 movtr9, #65535 ldr r7, [fp, #-44] addsr7, r7, r8 str r7, [fp, #-44] ldr r7, [fp, #-40] adc r7, r7, r9 str r7, [fp, #-40] to: movwr8, #65532

Re: [PATCH iproute2-next v2] net:sched: add action inheritdsfield to skbedit

2018-07-12 Thread Marcelo Ricardo Leitner
On Thu, Jul 12, 2018 at 12:09:26PM -0400, Qiaobin Fu wrote: > @@ -156,6 +162,9 @@ parse_skbedit(struct action_util *a, int *argc_p, char > ***argv_p, int tca_id, > if (flags & SKBEDIT_F_PTYPE) > addattr_l(n, MAX_MSG, TCA_SKBEDIT_PTYPE, > &ptype, sizeof(p

Re: [PATCH mlx5-next v1 1/8] net/mlx5: Add forward compatible support for the FTE match data

2018-07-12 Thread Or Gerlitz
On Wed, Jul 11, 2018 at 2:10 PM, Leon Romanovsky wrote: > From: Yishai Hadas > > Use the PRM size including the reserved when working with the FTE > match data. is this actually a bug fix? > This comes to support forward compatibility for cases that current > reserved data will be exposed by th

Re: [PATCH mlx5-next v1 2/8] net/mlx5: Add support for flow table destination number

2018-07-12 Thread Or Gerlitz
On Wed, Jul 11, 2018 at 2:10 PM, Leon Romanovsky wrote: > From: Yishai Hadas > > Add support to set a destination from a flow table number. > This functionality will be used in downstream patches from this > series by the DEVX stuff. Reading your cover letter, I still don't understand what is mi

Re: [PATCH 00/14] ARM BPF jit compiler improvements

2018-07-12 Thread Russell King - ARM Linux
On Thu, Jul 12, 2018 at 09:02:41PM +0200, Daniel Borkmann wrote: > Applied to bpf-next, thanks a lot Russell! Thanks, I've just sent four more patches, which is the sum total of what I'm intending to send for BPF improvements for the next merge window. -- RMK's Patch system: http://www.armlinux.

Re: [PATCH bpf v2] bpf: don't leave partial mangled prog in jit_subprogs error path

2018-07-12 Thread Alexei Starovoitov
On Thu, Jul 12, 2018 at 09:44:28PM +0200, Daniel Borkmann wrote: > syzkaller managed to trigger the following bug through fault injection: > > [...] > [ 141.043668] verifier bug. No program starts at insn 3 > [ 141.044648] WARNING: CPU: 3 PID: 4072 at kernel/bpf/verifier.c:1613 >

Re: [PATCH 00/14] ARM BPF jit compiler improvements

2018-07-12 Thread Daniel Borkmann
On 07/12/2018 11:02 PM, Russell King - ARM Linux wrote: > On Thu, Jul 12, 2018 at 09:02:41PM +0200, Daniel Borkmann wrote: >> Applied to bpf-next, thanks a lot Russell! > > Thanks, I've just sent four more patches, which is the sum total of > what I'm intending to send for BPF improvements for the

Re: [PATCH mlx5-next v1 2/8] net/mlx5: Add support for flow table destination number

2018-07-12 Thread Jason Gunthorpe
On Fri, Jul 13, 2018 at 12:00:41AM +0300, Or Gerlitz wrote: > On Wed, Jul 11, 2018 at 2:10 PM, Leon Romanovsky wrote: > > From: Yishai Hadas > > > > Add support to set a destination from a flow table number. > > This functionality will be used in downstream patches from this > > series by the DEV

Re: [BUG] bonded interfaces drop bpdu (stp) frames

2018-07-12 Thread महेश बंडेवार
On Thu, Jul 12, 2018 at 11:03 AM, Jay Vosburgh wrote: > Michal Soltys wrote: > >>On 07/12/2018 04:51 PM, Jay Vosburgh wrote: >>> Mahesh Bandewar (महेश बंडेवार) wrote: >>> On Wed, Jul 11, 2018 at 3:23 PM, Michal Soltys wrote: > > Hi, > > As weird as that sounds, this is what

Re: [PATCH] tcp: fix sequence numbers for repaired sockets re-using TIME-WAIT sockets

2018-07-12 Thread David Miller
From: Stefan Baranoff Date: Tue, 10 Jul 2018 17:25:20 -0400 > This patch fixes a bug where the sequence numbers of a socket created using > TCP repair functionality are lower than set after connect is called. > This occurs when the repair socket overlaps with a TIME-WAIT socket and > triggers the

Re: [PATCH] tcp: allow user to create repair socket without window probes

2018-07-12 Thread David Miller
From: Stefan Baranoff Date: Tue, 10 Jul 2018 17:31:10 -0400 > Under rare conditions where repair code may be used it is possible that > window probes are either unnecessary or undesired. If the user knows that > window probes are not wanted or needed this change allows them to skip > sending them

Re: [PATCH 00/14] ARM BPF jit compiler improvements

2018-07-12 Thread Russell King - ARM Linux
On Thu, Jul 12, 2018 at 11:12:45PM +0200, Daniel Borkmann wrote: > On 07/12/2018 11:02 PM, Russell King - ARM Linux wrote: > > On Thu, Jul 12, 2018 at 09:02:41PM +0200, Daniel Borkmann wrote: > >> Applied to bpf-next, thanks a lot Russell! > > > > Thanks, I've just sent four more patches, which is

Re: BUG: MAX_LOCK_DEPTH too low! (2)

2018-07-12 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:6e6fddc78323 bpf: fix panic due to oob in bpf_prog_test_ru.. git tree: bpf console output: https://syzkaller.appspot.com/x/log.txt?x=1364db9440 kernel config: https://syzkaller.appspot.com/x/.config?x=2ca6c7a31d4

[PATCH net] net/ipv6: Do not allow device only routes via the multipath API

2018-07-12 Thread dsahern
From: David Ahern Eric reported that reverting the patch that fixed and simplified IPv6 multipath routes means reverting back to invalid userspace notifications. eg., $ ip -6 route add 2001:db8:1::/64 nexthop dev eth0 nexthop dev eth1 only generates a single notification: 2001:db8:1::/64 dev eth

Re: [PATCH mlx5-next v1 2/8] net/mlx5: Add support for flow table destination number

2018-07-12 Thread Or Gerlitz
On Fri, Jul 13, 2018 at 12:26 AM, Jason Gunthorpe wrote: > On Fri, Jul 13, 2018 at 12:00:41AM +0300, Or Gerlitz wrote: >> On Wed, Jul 11, 2018 at 2:10 PM, Leon Romanovsky wrote: >> > From: Yishai Hadas >> > >> > Add support to set a destination from a flow table number. >> > This functionality w

Re: [PATCH net 0/2] sfc: filter locking fixes

2018-07-12 Thread David Miller
From: Bert Kenward Date: Wed, 11 Jul 2018 11:39:39 +0100 > Two fixes for sfc ef10 filter table locking. Initially spotted > by lockdep, but one issue has also been seen in normal use. Series applied, thanks.

Re: [PATCH net-next v2 0/2] net/sched: act_skbedit: lockless data path

2018-07-12 Thread David Miller
From: Davide Caratti Date: Wed, 11 Jul 2018 16:04:48 +0200 > the data path of act_skbedit can be faster if we avoid using spinlocks: > - patch 1 converts act_skbedit statistics to use per-cpu counters > - patch 2 lets act_skbedit use RCU to read/update its configuration > > test procedure (us

Re: [BUG] bonded interfaces drop bpdu (stp) frames

2018-07-12 Thread Jay Vosburgh
Mahesh Bandewar (महेश बंडेवार) wrote: >On Thu, Jul 12, 2018 at 11:03 AM, Jay Vosburgh > wrote: >> Michal Soltys wrote: >> >>>On 07/12/2018 04:51 PM, Jay Vosburgh wrote: Mahesh Bandewar (महेश बंडेवार) wrote: > On Wed, Jul 11, 2018 at 3:23 PM, Michal Soltys wrote: >> >> Hi, >

Re: [PATCH iproute2-next v2] net:sched: add action inheritdsfield to skbedit

2018-07-12 Thread Stephen Hemminger
On Thu, 12 Jul 2018 12:09:26 -0400 Qiaobin Fu wrote: > + if (*flags & SKBEDIT_F_INHERITDSFIELD) > + print_string(PRINT_ANY, "inheritdsfield", " %s", > + "inheritdsfield"); Flags should be represented in JSON output as a null value

Re: [PATCH mlx5-next v1 2/8] net/mlx5: Add support for flow table destination number

2018-07-12 Thread Jason Gunthorpe
On Fri, Jul 13, 2018 at 12:51:10AM +0300, Or Gerlitz wrote: > On Fri, Jul 13, 2018 at 12:26 AM, Jason Gunthorpe wrote: > > On Fri, Jul 13, 2018 at 12:00:41AM +0300, Or Gerlitz wrote: > >> On Wed, Jul 11, 2018 at 2:10 PM, Leon Romanovsky wrote: > >> > From: Yishai Hadas > >> > > >> > Add support

Re: [BUG] bonded interfaces drop bpdu (stp) frames

2018-07-12 Thread Michal Soltys
On 2018-07-12 23:26, Mahesh Bandewar (महेश बंडेवार) wrote: > On Thu, Jul 12, 2018 at 11:03 AM, Jay Vosburgh > wrote: >> Michal Soltys wrote: >> >>>On 07/12/2018 04:51 PM, Jay Vosburgh wrote: Mahesh Bandewar (महेश बंडेवार) wrote: > On Wed, Jul 11, 2018 at 3:23 PM, Michal Soltys wrot

Re: [PATCH net] net: Don't copy pfmemalloc flag in __copy_skb_header()

2018-07-12 Thread David Miller
From: Stefano Brivio Date: Wed, 11 Jul 2018 14:39:42 +0200 > The pfmemalloc flag indicates that the skb was allocated from > the PFMEMALLOC reserves, and the flag is currently copied on skb > copy and clone. > > However, an skb copied from an skb flagged with pfmemalloc > wasn't necessarily allo

Re: [PATCH v2 net-next 1/9] lan743x: Add support for ethtool get_drvinfo

2018-07-12 Thread Andrew Lunn
On Thu, Jul 12, 2018 at 03:04:58PM -0400, Bryan Whitehead wrote: > Implement ethtool get_drvinfo > > Signed-off-by: Bryan Whitehead Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v2 net-next 2/9] lan743x: Add support for ethtool link settings

2018-07-12 Thread Andrew Lunn
On Thu, Jul 12, 2018 at 03:04:59PM -0400, Bryan Whitehead wrote: > Use default link setting functions > > Signed-off-by: Bryan Whitehead Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v2 net-next 3/9] lan743x: Add support for ethtool statistics

2018-07-12 Thread Andrew Lunn
On Thu, Jul 12, 2018 at 03:05:00PM -0400, Bryan Whitehead wrote: > Implement ethtool statistics > > Signed-off-by: Bryan Whitehead Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v2 net-next 4/9] lan743x: Add support for ethtool message level

2018-07-12 Thread Andrew Lunn
On Thu, Jul 12, 2018 at 03:05:01PM -0400, Bryan Whitehead wrote: > Implement ethtool message level > > Signed-off-by: Bryan Whitehead Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v2 net-next 5/9] lan743x: Add support for ethtool eeprom access

2018-07-12 Thread Andrew Lunn
On Thu, Jul 12, 2018 at 03:05:02PM -0400, Bryan Whitehead wrote: > Implement ethtool eeprom access > Also provides access to OTP (One Time Programming) > > Signed-off-by: Bryan Whitehead Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v2 net-next 6/9] lan743x: Add power management support

2018-07-12 Thread Andrew Lunn
> +#ifdef CONFIG_PM > +static void lan743x_ethtool_get_wol(struct net_device *netdev, > + struct ethtool_wolinfo *wol) > +{ > + struct lan743x_adapter *adapter = netdev_priv(netdev); > + > + wol->supported = WAKE_BCAST | WAKE_UCAST | WAKE_MCAST | > +

Re: [PATCH v2 net-next 7/9] lan743x: Add EEE support

2018-07-12 Thread Andrew Lunn
> +static int lan743x_ethtool_set_eee(struct net_device *netdev, > +struct ethtool_eee *eee) > +{ > + struct lan743x_adapter *adapter = netdev_priv(netdev); > + struct phy_device *phydev = NULL; > + u32 buf = 0; > + int ret = 0; > + > + if (!netde

Proposal

2018-07-12 Thread Miss Victoria Mehmet
Hello I have a business proposal of mutual benefits i would like to discuss with you.

Re: [BUG] bonded interfaces drop bpdu (stp) frames

2018-07-12 Thread Michal Soltys
On 2018-07-13 00:03, Jay Vosburgh wrote: > Mahesh Bandewar (महेश बंडेवार) wrote: > >>On Thu, Jul 12, 2018 at 11:03 AM, Jay Vosburgh >> wrote: >>> Michal Soltys wrote: >>> On 07/12/2018 04:51 PM, Jay Vosburgh wrote: > Mahesh Bandewar (महेश बंडेवार) wrote: > >> On Wed, Jul 11, 2018

Re: [net-next PATCH] net: ipv4: fix listify ip_rcv_finish in case of forwarding

2018-07-12 Thread David Miller
From: Jesper Dangaard Brouer Date: Wed, 11 Jul 2018 17:01:20 +0200 > In commit 5fa12739a53d ("net: ipv4: listify ip_rcv_finish") calling > dst_input(skb) was split-out. The ip_sublist_rcv_finish() just calls > dst_input(skb) in a loop. > > The problem is that ip_sublist_rcv_finish() forgot to r

Re: [PATCH net-next 00/10] s390/qeth: updates 2018-07-11

2018-07-12 Thread David Miller
From: Julian Wiedmann Date: Wed, 11 Jul 2018 17:42:37 +0200 > please apply this first batch of qeth patches for net-next. It brings the > usual cleanups, and some performance improvements to the transmit paths. Series applied, thank you.

Re: [PATCH net] nsh: set mac len based on inner packet

2018-07-12 Thread David Miller
From: Willem de Bruijn Date: Wed, 11 Jul 2018 12:00:44 -0400 > From: Willem de Bruijn > > When pulling the NSH header in nsh_gso_segment, set the mac length > based on the encapsulated packet type. > > skb_reset_mac_len computes an offset to the network header, which > here still points to the

Re: [PATCH net] packet: reset network header if packet shorter than ll reserved space

2018-07-12 Thread David Miller
From: Willem de Bruijn Date: Wed, 11 Jul 2018 12:00:45 -0400 > From: Willem de Bruijn > > If variable length link layer headers result in a packet shorter > than dev->hard_header_len, reset the network header offset. Else > skb->mac_len may exceed skb->len after skb_mac_reset_len. > > packet_s

Re: [PATCH net] selftests: in udpgso_bench do not test udp zerocopy

2018-07-12 Thread David Miller
From: Willem de Bruijn Date: Wed, 11 Jul 2018 12:00:46 -0400 > From: Willem de Bruijn > > The udpgso benchmark compares various configurations of UDP and TCP. > Including one that is not upstream, udp zerocopy. This is a leftover > from the earlier RFC patchset. > > The test is part of kselfte

Re: [PATCH net-next] net: gro: properly remove skb from list

2018-07-12 Thread David Miller
From: Prashant Bhole Date: Thu, 12 Jul 2018 16:24:59 +0900 > Following crash occurs in validate_xmit_skb_list() when same skb is > iterated multiple times in the loop and consume_skb() is called. > > The root cause is calling list_del_init(&skb->list) and not clearing > skb->next in d4546c2509b1

Re: [PATCH] liquidio: Use %pad printk format for dma_addr_t values

2018-07-12 Thread Felix Manlunas
On Thu, Jul 12, 2018 at 10:36:29PM +0200, Helge Deller wrote: > Use the existing %pad printk format to print dma_addr_t values. > This avoids the following warnings when compiling on the parisc platform: > > warning: format '%llx' expects argument of type 'long long unsigned int', but > argument

Proposal

2018-07-12 Thread Miss Victoria Mehmet
Hello I have a business proposal of mutual benefits i would like to discuss with you i asked before and i still await your positive response thanks

Re: [BUG] bonded interfaces drop bpdu (stp) frames

2018-07-12 Thread महेश बंडेवार
On Thu, Jul 12, 2018 at 4:14 PM, Michal Soltys wrote: > On 2018-07-13 00:03, Jay Vosburgh wrote: >> Mahesh Bandewar (महेश बंडेवार) wrote: >> >>>On Thu, Jul 12, 2018 at 11:03 AM, Jay Vosburgh >>> wrote: Michal Soltys wrote: >On 07/12/2018 04:51 PM, Jay Vosburgh wrote: >> Mahesh B

Re: [PATCH net-next v3 00/11] devlink: Add support for region access

2018-07-12 Thread David Miller
From: Alex Vesker Date: Thu, 12 Jul 2018 15:13:07 +0300 > This is a proposal which will allow access to driver defined address > regions using devlink. Each device can create its supported address > regions and register them. A device which exposes a region will allow > access to it using devlink

Re: [PATCH net-next 1/5 v3] net: gemini: Look up L3 maxlen from table

2018-07-12 Thread David Miller
From: Linus Walleij Date: Wed, 11 Jul 2018 21:32:41 +0200 > The code to calculate the hardware register enumerator > for the maximum L3 length isn't entirely simple to read. > Use the existing defines and rewrite the function into a > table look-up. > > Acked-by: Michał Mirosław > Signed-off-by

Re: [PATCH net-next 4/5 v3] net: gemini: Move main init to port

2018-07-12 Thread David Miller
From: Linus Walleij Date: Wed, 11 Jul 2018 21:32:44 +0200 > The initialization sequence for the ethernet, setting up > interrupt routing and such things, need to be done after > both the ports are clocked and reset. Before this the > config will not "take". Move the initialization to the > port p

Re: [PATCH net-next 2/5 v3] net: gemini: Improve connection prints

2018-07-12 Thread David Miller
From: Linus Walleij Date: Wed, 11 Jul 2018 21:32:42 +0200 > Switch over to using a module parameter and debug prints > that can be controlled by this or ethtool like everyone > else. Depromote all other prints to debug messages. > > The phy_print_status() was already in place, albeit never > rea

Re: [PATCH net-next 3/5 v3] net: gemini: Allow multiple ports to instantiate

2018-07-12 Thread David Miller
From: Linus Walleij Date: Wed, 11 Jul 2018 21:32:43 +0200 > The code was not tested with two ports actually in use at > the same time. (I blame this on lack of actual hardware using > that feature.) Now after locating a system using both ports, > add necessary fix to make both ports come up. > >

Re: [PATCH net-next 5/5 v3] net: gemini: Indicate that we can handle jumboframes

2018-07-12 Thread David Miller
From: Linus Walleij Date: Wed, 11 Jul 2018 21:32:45 +0200 > The hardware supposedly handles frames up to 10236 bytes and > implements .ndo_change_mtu() so accept 10236 minus the ethernet > header for a VLAN tagged frame on the netdevices. Use > ETH_MIN_MTU as minimum MTU. > > Signed-off-by: Linu

Re: [PATCH v4 net-next 19/19] net/mlx5e: Kconfig, mutually exclude compilation of TLS and IPsec accel

2018-07-12 Thread David Miller
From: Boris Pismenny Date: Thu, 12 Jul 2018 22:25:57 +0300 > We currently have no devices that support both TLS and IPsec using the > accel framework, and the current code does not support both IPsec and > TLS. This patch prevents such combinations. > > Signed-off-by: Boris Pismenny > --- > dr

[PATCH net-next] TCP: make seq # error messages more readable

2018-07-12 Thread Randy Dunlap
cp_recvmsg+0x694/0xba0 Suggested-by: 積丹尼 Dan Jacobson Signed-off-by: Randy Dunlap --- net/ipv4/tcp.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) --- linux-next-20180712.orig/net/ipv4/tcp.c +++ linux-next-20180712/net/ipv4/tcp.c @@ -1994,9 +1994,9 @@ int tcp_recvmsg(struc

Re: [PATCH net-next v3 02/11] devlink: Add callback to query for snapshot id before snapshot create

2018-07-12 Thread Jakub Kicinski
On Thu, 12 Jul 2018 15:13:09 +0300, Alex Vesker wrote: > To restrict the driver with the snapshot ID selection a new callback > is introduced for the driver to get the snapshot ID before creating > a new snapshot. This will also allow giving the same ID for multiple > snapshots taken of different r

Re: [PATCH v2 net-next 9/9] lan743x: Add PTP support

2018-07-12 Thread Richard Cochran
On Thu, Jul 12, 2018 at 03:05:06PM -0400, Bryan Whitehead wrote: > +static int lan743x_ethtool_get_ts_info(struct net_device *netdev, > +struct ethtool_ts_info *ts_info) > +{ > + struct lan743x_adapter *adapter = netdev_priv(netdev); > + > + ts_info->so_t

Re: [PATCH net-next v6 01/11] net: sched: use rcu for action cookie update

2018-07-12 Thread Cong Wang
On Thu, Jul 5, 2018 at 7:24 AM Vlad Buslov wrote: > > Implement functions to atomically update and free action cookie > using rcu mechanism. Without stating any reason. Is this even a changelog? > > Reviewed-by: Marcelo Ricardo Leitner Dear Marcelo, how did it pass your review? See below:

Re: [PATCH net-next v6 00/11] Modify action API for implementing lockless actions

2018-07-12 Thread Cong Wang
On Sat, Jul 7, 2018 at 8:43 PM David Miller wrote: > > From: Vlad Buslov > Date: Thu, 5 Jul 2018 17:24:22 +0300 > > > Currently, all netlink protocol handlers for updating rules, actions and > > qdiscs are protected with single global rtnl lock which removes any > > possibility for parallelism.

[PATCH net] tun: Fix use-after-free on XDP_TX

2018-07-12 Thread Toshiaki Makita
On XDP_TX we need to free up the frame only when tun_xdp_tx() returns a negative value. A positive value indicates that the packet is successfully enqueued to the ptr_ring, so freeing the page causes use-after-free. Fixes: 735fc4054b3a ("xdp: change ndo_xdp_xmit API to support bulking") Signed-off

Re: [PATCH net] tun: Fix use-after-free on XDP_TX

2018-07-12 Thread Jason Wang
On 2018年07月13日 12:24, Toshiaki Makita wrote: On XDP_TX we need to free up the frame only when tun_xdp_tx() returns a negative value. A positive value indicates that the packet is successfully enqueued to the ptr_ring, so freeing the page causes use-after-free. Fixes: 735fc4054b3a ("xdp: chang

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-12 Thread Cong Wang
On Wed, Jul 11, 2018 at 11:37 AM Marcelo Ricardo Leitner wrote: > > On Tue, Jul 10, 2018 at 07:32:43PM -0700, Cong Wang wrote: > > On Mon, Jul 9, 2018 at 12:53 PM Marcelo Ricardo Leitner > > wrote: > > > > > > On Mon, Jul 09, 2018 at 02:18:33PM -0400, Michel Machado wrote: > > > > > > > >2. s

[PATCH net-next] net: ip6_gre: get ipv6hdr after skb_cow_head()

2018-07-12 Thread Prashant Bhole
A KASAN:use-after-free bug was found related to ip6-erspan while running selftests/net/ip6_gre_headroom.sh It happens because of following sequence: - ipv6hdr pointer is obtained from skb - skb_cow_head() is called, skb->head memory is reallocated - old data is accessed using ipv6hdr pointer skb_

Re: [PATCH net] tun: Fix use-after-free on XDP_TX

2018-07-12 Thread Jesper Dangaard Brouer
On Fri, 13 Jul 2018 13:05:04 +0800 Jason Wang wrote: > On 2018年07月13日 12:24, Toshiaki Makita wrote: > > On XDP_TX we need to free up the frame only when tun_xdp_tx() returns a > > negative value. A positive value indicates that the packet is > > successfully enqueued to the ptr_ring, so freeing t

Re: [PATCH v3 net-next] net/sched: add skbprio scheduler

2018-07-12 Thread Cong Wang
On Wed, Jul 11, 2018 at 12:33 PM Marcelo Ricardo Leitner wrote: > > On Tue, Jul 10, 2018 at 07:25:53PM -0700, Cong Wang wrote: > > On Mon, Jul 9, 2018 at 2:40 PM Marcelo Ricardo Leitner > > wrote: > > > > > > On Mon, Jul 09, 2018 at 05:03:31PM -0400, Michel Machado wrote: > > > >Changing TC_P

[PATCH][net-next] bridge: clean up mtu_set_by_user setting to false and comments

2018-07-12 Thread Li RongQing
Once mtu_set_by_user is set to true, br_mtu_auto_adjust will not run, and no chance to clear mtu_set_by_user. and br_mtu_auto_adjust will run only if mtu_set_by_user is false, so not need to set it to false again Cc: Nikolay Aleksandrov Signed-off-by: Li RongQing --- net/bridge/br_device.c | 1

<    1   2