Hi,
Thanks everyone for all the effort in debugging this issue.
On Mon, Sep 10, 2018 at 8:39 AM Steffen Klassert
wrote:
> The easy fix that could be backported to stable would be
> to check skb->dst for NULL and drop the packet in that case.
Thought I should just chime in and say that we
From: Intiyaz Basha
With the changes in patch 1 and 2, droq lock is not required.
So removing droq lock.
Signed-off-by: Intiyaz Basha
Acked-by: Derek Chickles
Signed-off-by: Felix Manlunas
---
.../net/ethernet/cavium/liquidio/octeon_device.c | 4 ---
After system suspend, sometimes the r8169 doesn't work when ethernet
cable gets pluggued.
This issue happens because rtl_reset_work() doesn't get called from
rtl8169_runtime_resume(), after system suspend.
In rtl_task(), RTL_FLAG_TASK_* only gets cleared if this condition is
met:
if
On Mon, Sep 10, 2018 at 08:37:39AM +0200, Steffen Klassert wrote:
...
> The other thing I wonder about is why Tobias bisected this to
>
> commit b838d5e1c5b6e57b10ec8af2268824041e3ea911
> ipv4: mark DST_NOGC and remove the operation of dst_free()
>
> from 'Jun 17 2017' and not to
>
> commit
This is v3 of WOL/EEE functionality patch for atlantic driver.
In this patchset Yana Esina and Nikita Danilov implemented:
- Upload function to interact with FW memory
- Definitions and structures necessary for the correct operation of Wake ON Lan
- The functionality Wake On Lan via ethtool
On 2018年09月10日 06:44, Willem de Bruijn wrote:
From: Willem de Bruijn
Implement ethtool .set_coalesce (-C) and .get_coalesce (-c) handlers.
Interrupt moderation is currently not supported, so these accept and
display the default settings of 0 usec and 1 frame.
Toggle tx napi through a bit
This follows David Miller advice and tries to fix coalesce timer in
multi-queue scenarios.
We are now using per-queue coalesce values and per-queue TX timer.
Coalesce timer default values was changed to 1ms and the coalesce frames
to 25.
Tested in B2B setup between XGMAC2 and GMAC5.
From: Intiyaz Basha
Removed oom task unconditional rescheduling every 250ms and created per
queue oom work queue for refilling buffers.
The oom task refills only if the available descriptors is fallen to 64.
There will be no packets coming in after hitting this level. So NAPI will
not run until
From: Intiyaz Basha
Series of patches for removing droq lock from Rx Path.
Intiyaz Basha (3):
liquidio: Disabling tasklet when NAPI is active
liquidio: Per queue oom work queue
liquidio: Removed droq lock
drivers/net/ethernet/cavium/liquidio/lio_core.c| 77 +++--
From: Intiyaz Basha
Control packets are processed in tasklet when interface is down and in
NAPI when interface is up. So tasklet can be disabled when interface up
and re-enabled when interface is down.
Signed-off-by: Intiyaz Basha
Acked-by: Derek Chickles
Signed-off-by: Felix Manlunas
---
This patch series adds AF_XDP support socionext netsec driver
- patch [1/2]: Use a different allocation scheme for Rx DMA buffers to prepare
the driver for AF_XDP support
- patch [2/2]: Add AF_XDP support without zero-copy
Ilias Apalodimas (2):
net: socionext: different approach on DMA
net:
Current driver dynamically allocates an skb and maps it as DMA rx buffer.
A following patch introduces AF_XDP functionality, so we need a
different allocation scheme. Buffers are allocated dynamically and
mapped into hardware. During the Rx operation the driver uses
build_skb() to produce the
Add basic AF_XDP support without zero-copy
Signed-off-by: Ilias Apalodimas
---
drivers/net/ethernet/socionext/netsec.c | 211 ++--
1 file changed, 202 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ethernet/socionext/netsec.c
Currently we are always setting the tail address of descriptor list to
the end of the pre-allocated list.
According to databook this is not correct. Tail address should point to
the last available descriptor + 1, which means we have to update the
tail address everytime we call the xmit function.
The fix for coalesce timer and a fix in tail address setting that impacts
XGMAC2 operation.
Cc: Jerome Brunet
Cc: Martin Blumenstingl
Cc: David S. Miller
Cc: Joao Pinto
Cc: Giuseppe Cavallaro
Cc: Alexandre Torgue
Jose Abreu (2):
net: stmmac: Rework coalesce timer and fix multi-queue
On Fri, Sep 07, 2018 at 11:10:55PM +0200, Wolfgang Walter wrote:
> Hello Steffen,
>
> in one of your emails to Thomas you wrote:
> > xfrm_lookup+0x2a is at the very beginning of xfrm_lookup(), here we
> > find:
> >
> > u16 family = dst_orig->ops->family;
> >
> > ops has an offset of 32 bytes
On 09/09/2018 04:12 PM, Willem de Bruijn wrote:
> From: Willem de Bruijn
>
> Convert pr_info to net_info_ratelimited to limit the total number of
> synflood warnings.
>
> Commit 946cedccbd73 ("tcp: Change possible SYN flooding messages")
> rate limits synflood warnings to one per listener.
>
On Fri, 7 Sep 2018 15:56:15 +0100, Lorenz Bauer wrote:
> Hello list,
>
> I'm attempting to use bpf_perf_event_output to do packet sampling from XDP.
>
> The code basically runs before our other XDP code, does a
> perf_event_output with the full packet (for now) and then tail calls
> into DDoS
From: Yana Esina
Added definitions and structures needed to support WOL.
Signed-off-by: Yana Esina
Signed-off-by: Nikita Danilov
Tested-by: Nikita Danilov
Signed-off-by: Igor Russkikh
---
drivers/net/ethernet/aquantia/atlantic/aq_nic.h| 3 +
.../aquantia/atlantic/hw_atl/hw_atl_utils.h
Signed-off-by: Igor Russkikh
---
drivers/net/ethernet/aquantia/atlantic/ver.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/aquantia/atlantic/ver.h
b/drivers/net/ethernet/aquantia/atlantic/ver.h
index 94efc6477bdc..b48260114da3 100644
---
From: Yana Esina
Add WOL support. Currently only magic packet
(ethtool -s wol g) feature is implemented.
Remove hw_set_power and move that to FW_OPS set_power:
because WOL configuration behaves differently on 1x and 2x
firmwares
Signed-off-by: Yana Esina
Signed-off-by: Nikita Danilov
From: Nikita Danilov
Removed extra characters from the names of structures to unify prefixes
used through the driver code (we normally use hw_atl for hw specifics).
HW_ATL_B0_ and HW_ATL_A0_ are the same and useless copies.
Signed-off-by: Nikita Danilov
Signed-off-by: Igor Russkikh
---
From: Yana Esina
Support of Energy-Efficient Ethernet to aQuantia NIC's via ethtool
(according to the IEEE 802.3az specifications)
Signed-off-by: Yana Esina
Signed-off-by: Nikita Danilov
Tested-by: Nikita Danilov
Signed-off-by: Igor Russkikh
---
From: Yana Esina
This patch fixes the upload function, which worked incorrectly with
some chips.
Signed-off-by: Yana Esina
Signed-off-by: Nikita Danilov
Tested-by: Nikita Danilov
Signed-off-by: Igor Russkikh
---
.../ethernet/aquantia/atlantic/hw_atl/hw_atl_llh.c | 8 +
From: Nikita Danilov
Removed extra spaces, corrected alignment.
Signed-off-by: Nikita Danilov
Signed-off-by: Igor Russkikh
---
.../net/ethernet/aquantia/atlantic/aq_ethtool.c| 4 +--
drivers/net/ethernet/aquantia/atlantic/aq_nic.c| 12
tree: git://github.com/afaerber/linux lora-next
head: 51325f8cd6dd80cba7ac6e881fe523ad0475c927
commit: 6a991b35a2fa0b75d99f03c564b40b6b9a5d2aed [14445/14606] Merge
remote-tracking branch 'net-next/master'
config: i386-randconfig-j0-09101243 (attached as .config)
compiler: gcc-4.9 (Debian
On Sun, Sep 09, 2018 at 09:26:23PM +0200, Hauke Mehrtens wrote:
> dma_zalloc_coherent() now crashes if no dev pointer is given.
> Add a dev pointer to the ltq_dma_channel structure and fill it in the
> driver using it.
>
> This fixes a bug introduced in kernel 4.19.
>
> Signed-off-by: Hauke
On Sun, Sep 09, 2018 at 10:20:39PM +0200, Hauke Mehrtens wrote:
> +static void gswip_phylink_validate(struct dsa_switch *ds, int port,
> +unsigned long *supported,
> +struct phylink_link_state *state)
> +{
> +
Hi Neil,
On 10-09-2018 12:43, Neil Armstrong wrote:
> Hi Jose,
>
> On 10/09/2018 11:14, Jose Abreu wrote:
>> This follows David Miller advice and tries to fix coalesce timer in
>> multi-queue scenarios.
>>
>> We are now using per-queue coalesce values and per-queue TX timer.
>>
>> Coalesce timer
Hi Stephen,
I just have seen this patch, hence please ignore the "bridge: Correct
json output" I sent. This one solves the issue in a way more elegant
manor.
I tested the JSON output in this series and it works as intended.
Thanks
Reviewed-by: Tobias Jungel
On Thu, 2018-09-06 at 16:30
Thank you for the fix
Reviewed-by: Martin Elshuber
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/can/usb/ucan.c: In function 'ucan_disconnect':
> drivers/net/can/usb/ucan.c:1578:21: warning:
> variable 'udev' set but not used [-Wunused-but-set-variable]
> struct
Den mån 10 sep. 2018 kl 10:26 skrev Ilias Apalodimas
:
>
> This patch series adds AF_XDP support socionext netsec driver
>
> - patch [1/2]: Use a different allocation scheme for Rx DMA buffers to prepare
> the driver for AF_XDP support
> - patch [2/2]: Add AF_XDP support without zero-copy
>
>
On 2018/09/10 17:24, Ilias Apalodimas wrote:
> Add basic AF_XDP support without zero-copy
>
> Signed-off-by: Ilias Apalodimas
> ---
...
> @@ -707,6 +731,26 @@ static int netsec_process_rx(struct netsec_priv *priv,
> int budget)
> if (unlikely(!buf_addr))
>
On Sun, Sep 09, 2018 at 10:16:44PM +0200, Hauke Mehrtens wrote:
> This adds the binding for the PMAC core between the CPU and the GSWIP
> switch found on the xrx200 / VR9 Lantiq / Intel SoC.
>
> Signed-off-by: Hauke Mehrtens
> Cc: devicet...@vger.kernel.org
> ---
>
Am Montag, 10. September 2018, 10:18:47 schrieb Kristian Evensen:
> Hi,
>
> Thanks everyone for all the effort in debugging this issue.
>
> On Mon, Sep 10, 2018 at 8:39 AM Steffen Klassert
>
> wrote:
> > The easy fix that could be backported to stable would be
> > to check skb->dst for NULL
On 2018-09-09 10:15 a.m., Al Viro wrote:
[..]
Umm... Interesting - TCA_U32_SEL is not the only thing that
gets ignored there; TCA_U32_MARK gets the same treatment.
And then there's a lovely question what to do with n->pf -
it's an array of n->sel.nkeys counters, and apparently we
want (at
Hi Jose,
On 10/09/2018 11:14, Jose Abreu wrote:
> This follows David Miller advice and tries to fix coalesce timer in
> multi-queue scenarios.
>
> We are now using per-queue coalesce values and per-queue TX timer.
>
> Coalesce timer default values was changed to 1ms and the coalesce frames
> to
On 2018-09-09 11:48 a.m., Al Viro wrote:
BTW, shouldn't we issue u32_clear_hw_hnode() every time
we destroy an hnode? It's done on u32_delete(), it's
done (for root ht) on u32_destroy(), but it's not done
for any other hnodes when you remove the entire (not shared)
filter. Looks fishy...
On 2018-09-10 8:25 a.m., Jamal Hadi Salim wrote:
On 2018-09-09 11:48 a.m., Al Viro wrote:
BTW, shouldn't we issue u32_clear_hw_hnode() every time
we destroy an hnode? It's done on u32_delete(), it's
done (for root ht) on u32_destroy(), but it's not done
for any other hnodes when you remove
On 10-09-2018 13:52, Jose Abreu wrote:
>
> Can you please try attached follow-up patch ?
Oh, please apply the whole series otherwise this will not apply
cleanly.
Thanks and Best Regards,
Jose Miguel Abreu
On Mon, Sep 10, 2018 at 2:01 AM Jason Wang wrote:
>
>
>
> On 2018年09月10日 06:44, Willem de Bruijn wrote:
> > From: Willem de Bruijn
> >
> > Implement ethtool .set_coalesce (-C) and .get_coalesce (-c) handlers.
> > Interrupt moderation is currently not supported, so these accept and
> > display
On Mon, Sep 10, 2018 at 07:56:49PM +0900, Toshiaki Makita wrote:
> On 2018/09/10 17:24, Ilias Apalodimas wrote:
> > Add basic AF_XDP support without zero-copy
> >
> > Signed-off-by: Ilias Apalodimas
> > ---
> ...
> > @@ -707,6 +731,26 @@ static int netsec_process_rx(struct netsec_priv *priv,
>
hi all,
while testing some local patches I observed that the TCP tput in the
following scenario:
# the following enable napi on veth0, so that we can trigger the
# GRO path with namespaces
ip netns add test
ip link add type veth
ip link set dev veth0 netns test
ip -n test link set lo up
ip -n
On 10-09-2018 14:46, Neil Armstrong wrote:
> hi Jose,
>
> On 10/09/2018 14:55, Jose Abreu wrote:
>> On 10-09-2018 13:52, Jose Abreu wrote:
>>> Can you please try attached follow-up patch ?
>> Oh, please apply the whole series otherwise this will not apply
>> cleanly.
> Indeed, it helps!
>
> With
On 09/10/2018 07:44 AM, Paolo Abeni wrote:
> hi all,
>
> while testing some local patches I observed that the TCP tput in the
> following scenario:
>
> # the following enable napi on veth0, so that we can trigger the
> # GRO path with namespaces
> ip netns add test
> ip link add type veth
>
hi Jose,
On 10/09/2018 14:55, Jose Abreu wrote:
> On 10-09-2018 13:52, Jose Abreu wrote:
>>
>> Can you please try attached follow-up patch ?
>
> Oh, please apply the whole series otherwise this will not apply
> cleanly.
Indeed, it helps!
With the fixups, it fails later, around 15s instead of
On Mon, Sep 10, 2018 at 12:39:30PM +0300, Igor Russkikh wrote:
> From: Yana Esina
>
> Add WOL support. Currently only magic packet
> (ethtool -s wol g) feature is implemented.
>
> Remove hw_set_power and move that to FW_OPS set_power:
> because WOL configuration behaves differently on 1x and
On Mon, Sep 10, 2018 at 12:39:29PM +0300, Igor Russkikh wrote:
> From: Yana Esina
>
> Added definitions and structures needed to support WOL.
>
> Signed-off-by: Yana Esina
> Signed-off-by: Nikita Danilov
> Tested-by: Nikita Danilov
> Signed-off-by: Igor Russkikh
Reviewed-by: Andrew Lunn
On Mon, Sep 10, 2018 at 12:39:31PM +0300, Igor Russkikh wrote:
> From: Yana Esina
>
> Support of Energy-Efficient Ethernet to aQuantia NIC's via ethtool
> (according to the IEEE 802.3az specifications)
>
> Signed-off-by: Yana Esina
> Signed-off-by: Nikita Danilov
> Tested-by: Nikita Danilov
On 10-09-2018 16:49, Neil Armstrong wrote:
> Hi Jose,
>
> On 10/09/2018 16:44, Jose Abreu wrote:
>> On 10-09-2018 14:46, Neil Armstrong wrote:
>>> hi Jose,
>>>
>>> On 10/09/2018 14:55, Jose Abreu wrote:
On 10-09-2018 13:52, Jose Abreu wrote:
> Can you please try attached follow-up patch ?
> > @@ -707,6 +731,26 @@ static int netsec_process_rx(struct netsec_priv *priv,
> > int budget)
> > if (unlikely(!buf_addr))
> > break;
> >
> > + if (xdp_prog) {
> > + xdp_result = netsec_run_xdp(desc, priv, xdp_prog,
> > +
Hi Jose,
On 10/09/2018 16:44, Jose Abreu wrote:
> On 10-09-2018 14:46, Neil Armstrong wrote:
>> hi Jose,
>>
>> On 10/09/2018 14:55, Jose Abreu wrote:
>>> On 10-09-2018 13:52, Jose Abreu wrote:
Can you please try attached follow-up patch ?
>>> Oh, please apply the whole series otherwise this
On 9/9/18 12:29 AM, Xin Long wrote:
>>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
>>> index 18e00ce..e554922 100644
>>> --- a/net/ipv6/route.c
>>> +++ b/net/ipv6/route.c
>>> @@ -4670,20 +4670,33 @@ static int rt6_fill_node(struct net *net, struct
>>> sk_buff *skb,
>>>
On Sat, 2018-09-08 at 16:12 +0200, Bjørn Mork wrote:
> Kristian Evensen writes:
>
> > Quectel EP06 (and EM06/EG06) supports dynamic configuration of USB
> > interfaces, without the device changing VID/PID or configuration
> > number.
> > When the configuration is updated and interfaces are
(sorry for the late reply, I was out all last week)
On 9/5/2018 5:55 PM, Jason Gunthorpe wrote:
> On Fri, Aug 31, 2018 at 11:52:00AM -0700, Steve Wise wrote:
>> Remove the incorrect WR_HDR field which can cause a misinterpretation
>> of this CPL by ULDs.
>
> What does that mean?
>
It means
On Mon, 2018-09-10 at 07:56 -0700, Eric Dumazet wrote:
>
> On 09/10/2018 07:44 AM, Paolo Abeni wrote:
> > hi all,
> >
> > while testing some local patches I observed that the TCP tput in the
> > following scenario:
> >
> > # the following enable napi on veth0, so that we can trigger the
> > #
From: David Ahern
After the conversion to fib6_info, rt6i_prefsrc has a single user that
reads the value and otherwise it is only set. The one reader can be
converted to use rt->from so rt6i_prefsrc can be removed, reducing
rt6_info by another 20 bytes.
Signed-off-by: David Ahern
---
From: Cong Wang
Date: Fri, 7 Sep 2018 13:29:14 -0700
> cl->leaf.q is slightly more readable than cl->un.leaf.q.
>
> Cc: Jamal Hadi Salim
> Signed-off-by: Cong Wang
Applied.
From: Cong Wang
Date: Fri, 7 Sep 2018 13:29:13 -0700
> We no longer take any spinlock on RX path for ingress qdisc,
> so this lockdep annotation is no longer needed.
>
> Cc: Jamal Hadi Salim
> Signed-off-by: Cong Wang
Applied.
From: Vlad Buslov
Date: Fri, 7 Sep 2018 17:22:21 +0300
> Change flower in_hw_count type to fixed-size u32 and dump it as
> TCA_FLOWER_IN_HW_COUNT. This change is necessary to properly test shared
> blocks and re-offload functionality.
>
> Signed-off-by: Vlad Buslov
> Acked-by: Jiri Pirko
From: dsah...@kernel.org
Date: Mon, 10 Sep 2018 09:11:28 -0700
> From: David Ahern
>
> After the conversion to fib6_info, rt6i_prefsrc has a single user that
> reads the value and otherwise it is only set. The one reader can be
> converted to use rt->from so rt6i_prefsrc can be removed,
Thank you for the fix
Reviewed-by: Martin Elshuber
Am 29.08.18 um 03:25 schrieb YueHaibing:
> Remove duplicated include.
>
> Signed-off-by: YueHaibing
> ---
> drivers/net/can/usb/ucan.c | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/can/usb/ucan.c
On Tue, Sep 11, 2018 at 12:13 AM David Ahern wrote:
>
> On 9/9/18 12:29 AM, Xin Long wrote:
> >>> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> >>> index 18e00ce..e554922 100644
> >>> --- a/net/ipv6/route.c
> >>> +++ b/net/ipv6/route.c
> >>> @@ -4670,20 +4670,33 @@ static int
On 09/10/2018 08:22 AM, Paolo Abeni wrote:
in this already heavy cost engine.
>
> Yup, even if I do not see any measurable cost added by the posted code.
Sure, micro bench marks wont show anything.
Now, if GRO receives one packet every 100 usec, as many hosts in the wild do,
there is an
From: Kristian Evensen
Date: Sat, 8 Sep 2018 13:50:48 +0200
> Quectel EP06 (and EM06/EG06) supports dynamic configuration of USB
> interfaces, without the device changing VID/PID or configuration number.
> When the configuration is updated and interfaces are added/removed, the
> interface
We are debugging an issue with netconsole and ixgbe, that ksoftirqd takes 100%
of a core. It happens with both current net and net-next.
To reproduce the issue:
1. Setup server with ixgbe and netconsole. We bind each queue to a separate
core via smp_affinity;
2. Start simple netperf
Begin forwarded message:
Date: Mon, 10 Sep 2018 04:04:37 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 201071] New: Creating a vxlan in state 'up' does not give proper
RTM_NEWLINK message
https://bugzilla.kernel.org/show_bug.cgi?id=201071
Begin forwarded message:
Date: Sun, 09 Sep 2018 13:45:28 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 201063] New: kernel panic on heavy network use
https://bugzilla.kernel.org/show_bug.cgi?id=201063
Bug ID: 201063
On Thu, 6 Sep 2018 14:01:17 -0700
Caleb Raitto wrote:
> From: Caleb Raitto
>
> Print the name of the argument that wasn't understood.
>
> Signed-off-by: Caleb Raitto
That is simpler, thanks. Applied
On 09/10/2018 02:14 AM, Jose Abreu wrote:
> This follows David Miller advice and tries to fix coalesce timer in
> multi-queue scenarios.
>
> We are now using per-queue coalesce values and per-queue TX timer.
>
> Coalesce timer default values was changed to 1ms and the coalesce frames
> to 25.
>
On Thu, 6 Sep 2018 15:31:51 +0200
Phil Sutter wrote:
> It was possible to crash ip-route by adding an IPv6 route with 37
> nexthop statements. A simple reproducer is:
>
> | for i in `seq 37`; do
> | nhs="nexthop via ::$i "$nhs
> | done
> | ip -6 route add ::/64 $nhs
>
> The
On 09/10/2018 02:14 AM, Jose Abreu wrote:
> Currently we are always setting the tail address of descriptor list to
> the end of the pre-allocated list.
>
> According to databook this is not correct. Tail address should point to
> the last available descriptor + 1, which means we have to update
On 9/10/18 11:55 AM, Xin Long wrote:
> On Tue, Sep 11, 2018 at 12:13 AM David Ahern wrote:
>>
>> On 9/9/18 12:29 AM, Xin Long wrote:
> diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> index 18e00ce..e554922 100644
> --- a/net/ipv6/route.c
> +++ b/net/ipv6/route.c
> @@
In tls_sw_sendmsg() and tls_sw_sendpage(), the variable 'ret' has
been set to return value of tls_complete_pending_work(). This allows
return of proper error code if tls_complete_pending_work() fails.
Fixes: 3c4d7559159b ("tls: kernel TLS support")
Signed-off-by: Vakul Garg
---
net/tls/tls_sw.c
Hi Jose,
On 10/09/2018 18:21, Jose Abreu wrote:
> On 10-09-2018 16:49, Neil Armstrong wrote:
>> Hi Jose,
>>
>> On 10/09/2018 16:44, Jose Abreu wrote:
>>> On 10-09-2018 14:46, Neil Armstrong wrote:
hi Jose,
On 10/09/2018 14:55, Jose Abreu wrote:
> On 10-09-2018 13:52, Jose Abreu
On (09/10/18 15:43), Santosh Shilimkar wrote:
> On 9/10/2018 3:24 PM, Cong Wang wrote:
> >When a rds sock is bound, it is inserted into the bind_hash_table
> >which is protected by RCU. But when releasing rd sock, after it
> >is removed from this hash table, it is freed immediately without
>
On (09/10/18 16:51), Cong Wang wrote:
>
> __rds_create_bind_key(key, addr, port, scope_id);
> - rs = rhashtable_lookup_fast(_hash_table, key, ht_parms);
> + rcu_read_lock();
> + rs = rhashtable_lookup(_hash_table, key, ht_parms);
> if (rs &&
On Mon, Sep 10, 2018 at 5:26 PM Santosh Shilimkar
wrote:
> Would you mind posting an updated patch please with call_rcu and
> above extended RCU grace period with rcu_read_lock. Thanks !!
If you prefer to fix _two_ problems in one patch, sure.
For the record, the bug this patch fixes is NOT
On 2018/09/11 1:21, Ilias Apalodimas wrote:
>>> @@ -707,6 +731,26 @@ static int netsec_process_rx(struct netsec_priv *priv,
>>> int budget)
>>> if (unlikely(!buf_addr))
>>> break;
>>>
>>> + if (xdp_prog) {
>>> + xdp_result =
On 09/10/2018 02:52 PM, Andrew Lunn wrote:
> ethtool can be used to enable/disable pause. Add a helper to configure
> the PHY when Pause is supported.
>
> Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
--
Florian
On 09/10/2018 02:52 PM, Andrew Lunn wrote:
> ethtool can be used to enable/disable pause. Add a helper to configure
> the PHY when asym pause is supported.
>
> Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
--
Florian
On 09/10/2018 02:52 PM, Andrew Lunn wrote:
> The PHY driver should not indicate that Pause is supported. It is upto
> the MAC drive enable it, if it supports Pause frames. So remove it
> from the ste10Xp driver.
>
> Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
--
Florian
On 09/10/2018 02:52 PM, Andrew Lunn wrote:
> The phy supported speed is being used to determine if the MAC should
> be configured to 100 or 1G. The masking logic is broken. Instead, look
> 1G supported speeds to enable 1G MAC support.
>
> Signed-off-by: Andrew Lunn
Acked-by: Florian Fainelli
On Mon, Sep 10, 2018 at 4:30 PM Sowmini Varadhan
wrote:
>
> On (09/10/18 15:43), Santosh Shilimkar wrote:
> > On 9/10/2018 3:24 PM, Cong Wang wrote:
> > >When a rds sock is bound, it is inserted into the bind_hash_table
> > >which is protected by RCU. But when releasing rd sock, after it
> > >is
On Mon, Sep 10, 2018 at 5:04 PM Sowmini Varadhan
wrote:
>
> On (09/10/18 16:51), Cong Wang wrote:
> >
> > __rds_create_bind_key(key, addr, port, scope_id);
> > - rs = rhashtable_lookup_fast(_hash_table, key, ht_parms);
> > + rcu_read_lock();
> > + rs =
From: David Ahern
The fib6_info reference in rt6_info is rcu protected. Add a helper
to extract prefsrc from and update cxgbi_check_route6 to use it.
Fixes: 0153167aebd0 ("net/ipv6: Remove rt6i_prefsrc")
Reported-by: kbuild test robot
Signed-off-by: David Ahern
---
On (09/10/18 17:16), Cong Wang wrote:
> >
> > On (09/10/18 16:51), Cong Wang wrote:
> > >
> > > __rds_create_bind_key(key, addr, port, scope_id);
> > > - rs = rhashtable_lookup_fast(_hash_table, key, ht_parms);
> > > + rcu_read_lock();
> > > + rs =
On 9/10/2018 5:16 PM, Cong Wang wrote:
On Mon, Sep 10, 2018 at 5:04 PM Sowmini Varadhan
wrote:
On (09/10/18 16:51), Cong Wang wrote:
__rds_create_bind_key(key, addr, port, scope_id);
- rs = rhashtable_lookup_fast(_hash_table, key, ht_parms);
+ rcu_read_lock();
+
On 2018/09/10 23:56, Eric Dumazet wrote:
> On 09/10/2018 07:44 AM, Paolo Abeni wrote:
>> hi all,
>>
>> while testing some local patches I observed that the TCP tput in the
>> following scenario:
>>
>> # the following enable napi on veth0, so that we can trigger the
>> # GRO path with namespaces
>>
On Mon, Sep 10, 2018 at 5:24 PM Sowmini Varadhan
wrote:
>
> On (09/10/18 17:16), Cong Wang wrote:
> > >
> > > On (09/10/18 16:51), Cong Wang wrote:
> > > >
> > > > __rds_create_bind_key(key, addr, port, scope_id);
> > > > - rs = rhashtable_lookup_fast(_hash_table, key, ht_parms);
>
On 2018年09月10日 21:35, Willem de Bruijn wrote:
On Mon, Sep 10, 2018 at 2:01 AM Jason Wang wrote:
On 2018年09月10日 06:44, Willem de Bruijn wrote:
From: Willem de Bruijn
Implement ethtool .set_coalesce (-C) and .get_coalesce (-c) handlers.
Interrupt moderation is currently not supported, so
On 9/10/2018 5:45 PM, Cong Wang wrote:
On Mon, Sep 10, 2018 at 5:26 PM Santosh Shilimkar
wrote:
Would you mind posting an updated patch please with call_rcu and
above extended RCU grace period with rcu_read_lock. Thanks !!
If you prefer to fix _two_ problems in one patch, sure.
For the
On Mon, Sep 10, 2018 at 5:56 PM Santosh Shilimkar
wrote:
>
> On 9/10/2018 5:45 PM, Cong Wang wrote:
> > On Mon, Sep 10, 2018 at 5:26 PM Santosh Shilimkar
> > wrote:
> >> Would you mind posting an updated patch please with call_rcu and
> >> above extended RCU grace period with rcu_read_lock.
On Fri, Sep 7, 2018 at 1:40 PM, Mauricio Vasquez
wrote:
>
> I read the Joe's proposal and using that for this problem looks like a nice
> solution.
>
> I think a good trade-off for now would be to go ahead with a queue/stack map
> without preallocating support (or maybe include it having always
The type of hash::nelems has been changed from size_t to atom_t
which in fact is int, so not need to check if BITS_PER_LONG, that
is bit number of size_t, is bigger than 32
and rht_grow_above_max() will be called to check if hashtable is
too big, ensure it can not bigger than 1<<31
On Mon, Sep 10, 2018 at 01:07:11PM -0600, David Ahern wrote:
> On 9/10/18 11:55 AM, Xin Long wrote:
> > On Tue, Sep 11, 2018 at 12:13 AM David Ahern
> > wrote:
> >>
> >> On 9/9/18 12:29 AM, Xin Long wrote:
> > diff --git a/net/ipv6/route.c b/net/ipv6/route.c
> > index 18e00ce..e554922
On Sat, 08 Sep 2018 13:10:01 -0700 (PDT)
David Miller wrote:
> By hand copies of SKB list handlers do not belong in individual packet
> schedulers.
>
> Signed-off-by: David S. Miller
Thanks for cleaning this up.
Signed-off-by: Stephen Hemminger
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
master
head: 11957be20ff68d7670cb979a1c3ea5482a44b370
commit: 0153167aebd0808fb90031dba07d4e696557474c [89/93] net/ipv6: Remove
rt6i_prefsrc
reproduce:
# apt-get install sparse
git checkout
On Sun, Sep 09, 2018 at 10:16:44PM +0200, Hauke Mehrtens wrote:
> This adds the binding for the PMAC core between the CPU and the GSWIP
> switch found on the xrx200 / VR9 Lantiq / Intel SoC.
>
> Signed-off-by: Hauke Mehrtens
> Cc: devicet...@vger.kernel.org
> ---
>
ethtool can be used to enable/disable pause. Add a helper to configure
the PHY when asym pause is supported.
Signed-off-by: Andrew Lunn
---
v2: Also trigger autoneg if the advertising settings have changed.
---
.../ethernet/apm/xgene/xgene_enet_ethtool.c | 26 ++
1 - 100 of 123 matches
Mail list logo