Re: [PATCH net-next 0/3] sctp: add support for sk_reuseport

2018-10-22 Thread Neil Horman
On Sun, Oct 21, 2018 at 12:43:35PM +0800, Xin Long wrote: > sctp sk_reuseport allows multiple socks to listen on the same port and > addresses, as long as these socks have the same uid. This works pretty > much as TCP/UDP does, the only difference is that sctp is multi-homing > and all the

Re: [PATCH net-next 2/4] net: phy-c45: Populate autoneg_done callback

2018-10-22 Thread Andrew Lunn
On Mon, Oct 22, 2018 at 11:32:47AM +0100, Jose Abreu wrote: > We already have this callback implemented. Use it in driver structure. > > Signed-off-by: Jose Abreu > Cc: Andrew Lunn > Cc: Florian Fainelli > Cc: "David S. Miller" > Cc: Joao Pinto > --- > drivers/net/phy/phy-c45.c | 1 + > 1

Re: [PATCH net-next 3/4] net: phy-c45: Implement reset/suspend/resume callbacks

2018-10-22 Thread Jose Abreu
Hello, On 22-10-2018 13:28, Andrew Lunn wrote: >> EXPORT_SYMBOL_GPL(gen10g_resume); >> @@ -327,7 +381,7 @@ struct phy_driver genphy_10g_driver = { >> .phy_id = 0x, >> .phy_id_mask= 0x, >> .name = "Generic 10G PHY", >> -.soft_reset =

[PATCH net-next] tls: Add maintainers

2018-10-22 Thread Dave Watson
Add John and Daniel as additional tls co-maintainers to help review patches and fix syzbot reports. Acked-by: John Fastabend Acked-by: Daniel Borkmann Signed-off-by: Dave Watson --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index

RE: [Intel-wired-lan] [PATCH] ixgbe: allow IPsec Tx offload in VEPA mode

2018-10-22 Thread Bowers, AndrewX
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > Behalf Of Shannon Nelson > Sent: Thursday, October 4, 2018 4:29 PM > To: intel-wired-...@lists.osuosl.org; Kirsher, Jeffrey T > > Cc: netdev@vger.kernel.org > Subject: [Intel-wired-lan] [PATCH]

Re: [iproute PATCH] tc: htb: Print default value in hex

2018-10-22 Thread Stephen Hemminger
On Fri, 19 Oct 2018 17:42:55 +0200 Phil Sutter wrote: > Value of 'default' is assumed to be hexadecimal when parsing, so > consequently it should be printed in hex as well. This is a regression > introduced when adding JSON output. > > Fixes: f354fa6aa5ff0 ("tc: jsonify htb qdisc") >

Re: [iproute PATCH] ip-route: Fix parse_encap_seg6() srh parsing

2018-10-22 Thread Stephen Hemminger
On Thu, 18 Oct 2018 15:44:14 +0200 Phil Sutter wrote: > In case caller did not specify 'segs' parameter, parse_srh() would read > garbage while iterating over 'segbuf'. Avoid this by initializing > 'segbuf' to an empty string. > > Fixes: e8493916a8ede ("iproute: add support for SR-IPv6 lwtunnel

Re: [PATCH v2 1/2] dt-bindings: net: add MDIO bus multiplexer driven by a regmap device

2018-10-22 Thread Florian Fainelli
On 10/21/18 9:22 PM, Pankaj Bansal wrote: > >> -Original Message- >> From: Pankaj Bansal >> Sent: Thursday, October 18, 2018 10:00 AM >> To: Florian Fainelli ; Andrew Lunn >> Cc: netdev@vger.kernel.org >> Subject: RE: [PATCH v2 1/2] dt-bindings: net: add MDIO bus multiplexer >> driven

Re: [iproute PATCH] tc: Remove pointless assignments in batch()

2018-10-22 Thread Stephen Hemminger
On Thu, 18 Oct 2018 15:48:48 +0200 Phil Sutter wrote: > All these assignments are later overwritten without reading in between, > so just drop them. > > Fixes: 485d0c6001c4a ("tc: Add batchsize feature for filter and actions") > Signed-off-by: Phil Sutter Applied

Re: [iproute PATCH] tipc: Drop unused variable 'genl'

2018-10-22 Thread Stephen Hemminger
On Thu, 18 Oct 2018 15:48:09 +0200 Phil Sutter wrote: > Although initialized by call to libmnl, the variable is used only in a > call to sizeof(). Drop it and call sizeof with its type instead. > > Fixes: f043759dd4928 ("tipc: add new TIPC configuration tool") > Signed-off-by: Phil Sutter

Re: [iproute PATCH] tc: htb: Print default value in hex

2018-10-22 Thread Phil Sutter
On Mon, Oct 22, 2018 at 09:56:23AM -0700, Stephen Hemminger wrote: > On Fri, 19 Oct 2018 17:42:55 +0200 > Phil Sutter wrote: > > > Value of 'default' is assumed to be hexadecimal when parsing, so > > consequently it should be printed in hex as well. This is a regression > > introduced when

[PATCH v2 09/17] octeontx2-af: Support for VTAG strip and capture

2018-10-22 Thread sunil . kovvuri
From: Vamsi Attunuru Added support for PF/VF drivers to configure NIX to capture and/or strip VLAN tag from ingress packets. Signed-off-by: Vamsi Attunuru Signed-off-by: Sunil Goutham --- drivers/net/ethernet/marvell/octeontx2/af/mbox.h | 35 -

[PATCH v2 07/17] octeontx2-af: Broadcast packet replication support

2018-10-22 Thread sunil . kovvuri
From: Sunil Goutham Allocate memory for mcast/bcast/mirror replication entry contexts, replication buffers (used by HW) and config HW with corresponding memory bases. Added support for installing MCEs via NIX AQ mbox. For now support is restricted to broadcast pkt replication, hence MCE table

[PATCH v2 04/17] octeontx2-af: Add NPC KPU profile

2018-10-22 Thread sunil . kovvuri
From: Hao Zheng NPC block is responsible for parsing and forwarding packets to different NIXLFs. NPC has 16 KPU engines (Kangaroo parse engine) and one iKPU which represents pkinds. Each physical port either CGX/LBK is assigned a pkind and upon receiving a packet HW takes that port's pkind and

[PATCH v2 14/17] octeontx2-af: NIX Rx flowkey configuration for RSS

2018-10-22 Thread sunil . kovvuri
From: Sunil Goutham Configure NIX RX flowkey algorithm configuration to support RSS (receive side scaling). Currently support for only L3/L4 2-tuple and 4-tuple hash of IPv4/v6/TCP/UDP/SCTP is added. HW supports upto 32 different flowkey algorithms which SW can define, this patch defines 9. NPC

[PATCH v2 15/17] octeontx2-af: Support for changing RSS algorithm

2018-10-22 Thread sunil . kovvuri
From: Sunil Goutham This patch adds support for a RVU PF/VF to change NIX Rx flowkey algorithm index in NPC RX RSS_ACTION. eg: a ethtool command changing RSS algorithm for a netdev interface would trigger this change in NPC. If PF/VF doesn't specify any MCAM entry index then default UCAST entry

[PATCH v2 16/17] octeontx2-af: Support for setting MAC address

2018-10-22 Thread sunil . kovvuri
From: Sunil Goutham Added a new mailbox message for a PF/VF to set/update it's NIXLF's MAC address. Also updates unicast NPC MCAM entry with this address as matching DMAC. Signed-off-by: Sunil Goutham --- drivers/net/ethernet/marvell/octeontx2/af/mbox.h | 8 ++-

[PATCH v2 12/17] octeontx2-af: Add LMAC channel info to NIXLF_ALLOC response

2018-10-22 Thread sunil . kovvuri
From: Stanislaw Kardach Add LMAC channel info like Rx/Tx channel base and count to NIXLF_ALLOC mailbox message response. This info is used by NIXLF attached RVU PF/VF to configure SQ's default channel, TL3_TL2_LINKX_CFG and to install MCAM rules in NPC based on matching ingress channel number.

[PATCH v2 13/17] octeontx2-af: Install ucast and bcast pkt forwarding rules

2018-10-22 Thread sunil . kovvuri
From: Sunil Goutham Upon NIXLF_ALLOC install a unicast forwarding rule in NPC MCAM like below - Match pkt DMAC with NIXLF attached PF/VF's MAC address. - Ingress channel - Action is UCAST - Forward to PF_FUNC of this NIXLF And broadcast pkt forwarding rule as - Match L2B bit in MCAM search

[PATCH v2 11/17] octeontx2-af: NPC MCAM and LDATA extract minimal configuration

2018-10-22 Thread sunil . kovvuri
From: Sunil Goutham This patch adds some minimal configuration for NPC MCAM and LDATA extraction which is sufficient enough to install ucast/bcast/promiscuous forwarding rules. Below is the config done - LDATA extraction config to extract DMAC from pkt to offset 64bit in MCAM search key. - Set

Re: Kernel oops with mlx5 and dual XDP redirect programs

2018-10-22 Thread Saeed Mahameed
On Thu, 2018-10-18 at 23:53 +0200, Toke Høiland-Jørgensen wrote: > Saeed Mahameed writes: > > > I think that the mlx5 driver doesn't know how to tell the other > > device > > to stop transmitting to it while it is resetting.. Maybe tariq or > > Jesper know more about this ? > > I will look at

[PATCH v2 03/17] octeontx2-af: Reset NIXLF's Rx/Tx stats

2018-10-22 Thread sunil . kovvuri
From: Vamsi Attunuru This patch adds a new mailbox message to reset a NIXLF's receive and transmit HW stats. Signed-off-by: Vamsi Attunuru Signed-off-by: Sunil Goutham --- drivers/net/ethernet/marvell/octeontx2/af/mbox.h | 3 ++- drivers/net/ethernet/marvell/octeontx2/af/rvu.h| 2 ++

[PATCH v2 06/17] octeontx2-af: Config pkind for CGX mapped PFs

2018-10-22 Thread sunil . kovvuri
From: Geetha sowjanya For each CGX LMAC that is mapped to a RVU PF, allocate a pkind and config the same in CGX. For a received packet at CGX LMAC interface this pkind is used by NPC block to start parsing of packet. Signed-off-by: Geetha sowjanya Signed-off-by: Sunil Goutham ---

[PATCH v2 10/17] octeontx2-af: Enable packet length and csum validation

2018-10-22 Thread sunil . kovvuri
From: Sunil Goutham Config NPC layer info from KPU profile into protocol checker to identify outer L2/IPv4/TCP/UDP headers in a packet. And enable IPv4 checksum validation. L3/L4 and L4 CSUM validation will be enabled by PF/VF drivers by configuring NIX_AF_LF(0..127)_RX_CFG via mbox i.e

[PATCH v2 02/17] octeontx2-af: NIX Tx scheduler queue config support

2018-10-22 Thread sunil . kovvuri
From: Sunil Goutham This patch adds support for a PF/VF driver to configure NIX transmit scheduler queues via mbox. Since PF/VF doesn't know the absolute HW index of the NIXLF attached to it, AF traps the register config and overwrites with the correct NIXLF index. HW supports shaping,

[PATCH v2 01/17] octeontx2-af: NIX Tx scheduler queues alloc/free

2018-10-22 Thread sunil . kovvuri
From: Sunil Goutham Added support for a PF/VF to allocate or free NIX transmit scheduler queues via mbox. For setting up pkt transmission priorities between queues, the scheduler queues have to be contiguous w.r.t their HW indices. So both contiguous and non-contiguous allocations are supported.

[PATCH v2 05/17] octeontx2-af: Config NPC KPU engines with parser profile

2018-10-22 Thread sunil . kovvuri
From: Sunil Goutham This patch configures all 16 KPUs and iKPU (pkinds) with the KPU parser profile defined in npc_profile.h. Each KPU engine has a 128 entry CAM, only CAM entries which are listed in the profile are enabled and rest are left disabled. Also - Memory is allocated for pkind's

[PATCH v2 17/17] octeontx2-af: Support for NIXLF's UCAST/PROMISC/ALLMULTI modes

2018-10-22 Thread sunil . kovvuri
From: Sunil Goutham By default NIXLF is set in UCAST mode. This patch adds a new mailbox message which when sent by a RVU PF changes this default mode. When promiscuous mode is needed, the reserved promisc entry for each of RVU PF is setup to match against ingress channel number only, so that

[PATCH v2 08/17] octeontx2-af: Update bcast list upon NIXLF alloc/free

2018-10-22 Thread sunil . kovvuri
From: Sunil Goutham Upon NIXLF ALLOC/FREE, add or remove corresponding PF_FUNC from the broadcast packet replication list of the CGX LMAC mapped RVU PF. Signed-off-by: Sunil Goutham --- .../net/ethernet/marvell/octeontx2/af/rvu_nix.c| 133 + 1 file changed, 133

Re: [RFC PATCH v2 06/10] udp: cope with UDP GRO packet misdirection

2018-10-22 Thread Subash Abhinov Kasiviswanathan
On 2018-10-19 08:25, Paolo Abeni wrote: In some scenarios, the GRO engine can assemble an UDP GRO packet that ultimately lands on a non GRO-enabled socket. This patch tries to address the issue explicitly checking for the UDP socket features before enqueuing the packet, and eventually segmenting

Re: Some suggestions for tc-tests

2018-10-22 Thread Lucas Bates
Hi Cong, > > 1. Create veth pair devices by its own. The most important thing for > tc-tests is to automate everything, it is not friendly for users to > create their own veth pair named v0p0 to just run the tests. tc-tests > should be able to create a veth pair with random names and clean up >

Re: [PATCH net 1/4] net/sched: act_gact: disallow 'goto chain' on fallback control action

2018-10-22 Thread Jiri Pirko
Sat, Oct 20, 2018 at 11:33:07PM CEST, dcara...@redhat.com wrote: >in the following command: > > # tc action add action random > >'goto chain x' is allowed only for c1: setting it for c2 makes the kernel >crash with NULL pointer dereference, since TC core doesn't initialize the >chain handle. >

[net-next:master 451/481] drivers/net/ethernet/amazon/ena/ena_com.h:1104:2: error: implicit declaration of function 'prefetchw'

2018-10-22 Thread kbuild test robot
Hi Netanel, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 21ea1d36f6dfcb1d59184937c672022d5d01902a commit: 8c590f9776386b8f697fd0b7ed6142ae6e3de79e [451/481] net: ena: Fix Kconfig dependency on X86 config:

Re: Improving accuracy of PHC readings

2018-10-22 Thread Richard Cochran
On Fri, Oct 19, 2018 at 11:51:37AM +0200, Miroslav Lichvar wrote: > A solution to this would be a new driver function that wraps the > latching register read with readings of the system clock and return > three timestamps instead of one. For example: > > ktime_get_real_ts64(_ts1); >

Re: Improving accuracy of PHC readings

2018-10-22 Thread Richard Cochran
On Fri, Oct 19, 2018 at 04:52:13PM +, Keller, Jacob E wrote: > Nice! I think this is good. I'd love to see some data to back it up, but it > makes sense to me. +1

Re: [PATCH net 2/4] net/sched: act_police: disallow 'goto chain' on fallback control action

2018-10-22 Thread Jiri Pirko
Sat, Oct 20, 2018 at 11:33:08PM CEST, dcara...@redhat.com wrote: >in the following command: > > # tc action add action police rate burst conform-exceed / > >'goto chain x' is allowed only for c1: setting it for c2 makes the kernel >crash with NULL pointer dereference, since TC core doesn't

Re: [PATCH net-next 3/4] net: phy-c45: Implement reset/suspend/resume callbacks

2018-10-22 Thread Florian Fainelli
On 10/22/18 8:48 AM, Russell King - ARM Linux wrote: > On Mon, Oct 22, 2018 at 01:47:48PM +0100, Jose Abreu wrote: >> Hello, >> >> On 22-10-2018 13:28, Andrew Lunn wrote: EXPORT_SYMBOL_GPL(gen10g_resume); @@ -327,7 +381,7 @@ struct phy_driver genphy_10g_driver = { .phy_id

Re: [iproute2 PATCH] bridge: fix vlan show stats formatting

2018-10-22 Thread Stephen Hemminger
On Sat, 20 Oct 2018 15:42:33 +0200 Tobias Jungel wrote: > The output of -statistics vlan show was broken previous change for json > output. This aligns the format to vlan show. > > Signed-off-by: Tobias Jungel This patch causes new warning: CC vlan.o vlan.c: In function

Re: [PATCH iproute2 1/1] DEBUG: Fix make check when need build generate_nlmsg

2018-10-22 Thread Petr Vorel
Hi Stephen, > Applied, it seem to have gotten lost somewhere between my laptop and the repo. Thanks a lot for merging :). There is a patchset "Minor shell code cleanup", which has state Accepted, but not in git https://patchwork.ozlabs.org/project/netdev/list/?series=67063=* Did they got lost as

Re: [PATCH net-next 1/4] net: phy: Use C45 Helpers when forcing PHY

2018-10-22 Thread Florian Fainelli
On 10/22/18 3:32 AM, Jose Abreu wrote: > If PHY is in force state and we have a C45 phy we need to use the > standard C45 helpers and not the C22 ones. > > Signed-off-by: Jose Abreu > Cc: Andrew Lunn > Cc: Florian Fainelli > Cc: "David S. Miller" > Cc: Joao Pinto > --- >

Re: [PATCH net 0/4] net/sched: forbid 'goto_chain' on fallback actions

2018-10-22 Thread Jamal Hadi Salim
On 2018-10-20 5:33 p.m., Davide Caratti wrote: the following command: # tc actions add action police rate 1mbit burst 1k conform-exceed \ > pass / goto chain 42 generates a NULL pointer dereference when packets exceed the configured rate. Similarly, the following command: # tc actions

Re: [iproute PATCH] ip-route: Fix for memleak in error path

2018-10-22 Thread Stephen Hemminger
On Thu, 18 Oct 2018 14:30:31 +0200 Phil Sutter wrote: > If call to rta_addattr_l() failed, parse_encap_seg6() would leak memory. > Fix this by making sure calls to free() are not skipped. > > Fixes: bd59e5b1517b0 ("ip-route: Fix segfault with many nexthops") > Signed-off-by: Phil Sutter

Re: [iproute PATCH] rdma: Fix for ineffective check in add_filter()

2018-10-22 Thread Stephen Hemminger
On Thu, 18 Oct 2018 13:41:54 +0200 Phil Sutter wrote: > With 'name' field defined as array in struct filters, it will always > contain a value irrespective of whether a name was assigned or not. > > Fix this by turning the field into a const char pointer. > > Fixes: 8cd644095842a ("devlink:

Re: [PATCH 0/9] net: simplify getting .driver_data

2018-10-22 Thread Florian Fainelli
On 10/21/18 1:00 PM, Wolfram Sang wrote: > I got tired of fixing this in Renesas drivers manually, so I took the big > hammer. Remove this cumbersome code pattern which got copy-pasted too much > already: > > - struct platform_device *pdev = to_platform_device(dev); > - struct

Re: [iproute PATCH] rdma: Don't pass garbage to rd_check_is_filtered()

2018-10-22 Thread Stephen Hemminger
On Thu, 18 Oct 2018 14:35:50 +0200 Phil Sutter wrote: > Variables 'src_port' and 'dst_port' are initialized only if attributes > RDMA_NLDEV_ATTR_RES_SRC_ADDR or RDMA_NLDEV_ATTR_RES_DST_ADDR are > present. Make sure to pass them over to rd_check_is_filtered() only if > that is the case. > >

Re: [PATCH bpf-next] selftests/bpf: enable (uncomment) all tests in test_libbpf.sh

2018-10-22 Thread Jesper Dangaard Brouer
On Mon, 22 Oct 2018 11:00:27 +0100 Quentin Monnet wrote: > 2018-10-21 23:04 UTC+0200 ~ Jesper Dangaard Brouer > > On Sun, 21 Oct 2018 16:37:08 +0100 > > Quentin Monnet wrote: > > > >> 2018-10-21 11:57 UTC+0200 ~ Jesper Dangaard Brouer > >>> On Sat, 20 Oct 2018 23:00:24 +0100 > >>>

Re: [PATCH iproute2 1/1] DEBUG: Fix make check when need build generate_nlmsg

2018-10-22 Thread Stephen Hemminger
On Mon, 22 Oct 2018 19:03:41 +0200 Petr Vorel wrote: > Hi Stephen, > > > Applied, it seem to have gotten lost somewhere between my laptop and the > > repo. > Thanks a lot for merging :). > > There is a patchset "Minor shell code cleanup", which has state Accepted, but > not in git >

[PATCH v2 00/17] octeontx2-af: NPC parser and NIX blocks initialization

2018-10-22 Thread sunil . kovvuri
From: Sunil Goutham This patchset is a continuation to earlier submitted two patch series to add a new driver for Marvell's OcteonTX2 SOC's Resource virtualization unit (RVU) admin function driver. 1. octeontx2-af: Add RVU Admin Function driver

Re: [PATCH net-next 0/6 v2] qed*: Doorbell overflow recovery

2018-10-22 Thread David Miller
From: Ariel Elior Date: Tue, 23 Oct 2018 08:35:43 +0300 > Please consider applying to net-next. Sorry, net-next is closed.

<    1   2