Re: [RFC PATCH] convert ebt_ulog to nfnetlink_log

2005-08-07 Thread Bart De Schuymer
Op zo, 07-08-2005 te 23:33 +0200, schreef Harald Welte: > > indev->br_port->br->dev->ifindex points to the ifindex of the bridge br0 > > when indev is a bridge port (eth0). So you need this to fill in the > > input device (assuming we agree that the bridge is called the input > > device, and the b

Re: lockups with netconsole on e1000 on media insertion

2005-08-07 Thread Steven Rostedt
On Sun, 2005-08-07 at 23:12 +0200, John Bäckstrand wrote: > Steven Rostedt wrote: > > I don't have the card, so I can't test it. But if this works (after > > removing the previous patch) then this is the better solution. > > I can confirm that this alone does not work for the simple > unplug/re-

Re: ANNOUNCE: Linux DCCP implementation merged

2005-08-07 Thread Arnaldo Carvalho de Melo
On 8/7/05, Ian McDonald <[EMAIL PROTECTED]> wrote: > Arnaldo Carvalho de Melo wrote: > > Hi Guys, > > > > I'm very pleased to announce that the Linux 2.6 DCCP implementation > > has been merged in David Miller's net-2.6.14.git tree, and should appear > > shortly on Andrew Morton's 2.6.13-rcLA

Re: ANNOUNCE: Linux DCCP implementation merged

2005-08-07 Thread Ian McDonald
Arnaldo Carvalho de Melo wrote: > Hi Guys, > > I'm very pleased to announce that the Linux 2.6 DCCP implementation > has been merged in David Miller's net-2.6.14.git tree, and should appear > shortly on Andrew Morton's 2.6.13-rcLATEST-mm tree and finally in mainline > when Linus starts 2.6.1

Re: [RFC] Netlink subscription/multicasting.

2005-08-07 Thread Patrick McHardy
Thomas Graf wrote: Anyways, your idea of having 32bit identifiers rather than a bitmask makes sense to me, however I think we should not lose the ability to do multicasting for event notifications so we might need a slightly more complex solution. I guess Patrick is taking care of this though.

Re: [PATCH] Fix erroneous ICMP corruption with iptable_nat and NOTRACK (was Re: ICMP broken in 2.6.13-rc5)

2005-08-07 Thread Patrick McHardy
Harald Welte wrote: > On Sun, Aug 07, 2005 at 08:42:56PM +0200, Patrick McHardy wrote: > >>The conntrack reference is manually attached to locally generated ICMP >>errors and icmp_reply_translation() doesn't check if NAT mappings have >>been set up but simply replaces IP/port by what is stored in

Re: [PATCH] Fix erroneous ICMP corruption with iptable_nat and NOTRACK (was Re: ICMP broken in 2.6.13-rc5)

2005-08-07 Thread Harald Welte
On Sun, Aug 07, 2005 at 08:42:56PM +0200, Patrick McHardy wrote: > Harald Welte wrote: > > On Sun, Aug 07, 2005 at 05:18:06PM +0200, Harald Welte wrote: > > > >>The following trivial patch was confirmed to solve the problem. Patrick > >>also has no objections, so please apply this to mainline. >

[PATCH] split net/core/netfilter.c into net/netfilter/*.c

2005-08-07 Thread Harald Welte
Hi Dave, please apply to net-2.6.14 -- - Harald Welte <[EMAIL PROTECTED]> http://gnumonks.org/ "Privacy in residential applications is a desirable marketing option."

[PATCH] add autoloading support to nfnetlink_log

2005-08-07 Thread Harald Welte
Please apply, thanks -- - Harald Welte <[EMAIL PROTECTED]> http://gnumonks.org/ "Privacy in residential applications is a desirable marketing option."

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-07 Thread Thomas Graf
* Harald Welte <[EMAIL PROTECTED]> 2005-08-07 17:03 > On Sun, Aug 07, 2005 at 01:20:39PM +0200, Thomas Graf wrote: > > Same very minor issues as nfnetlink regarding some of the > > new netlink message construction policies. I'll "fix" them > > during the conversion to the generic netlink attributes

Moving... please wait

2005-08-07 Thread Jeff Garzik
On Sun, Aug 07, 2005 at 01:51:52PM -0700, Ravinandan Arakali wrote: > Jeff, > The entire set of patches have been resent and an additional > patch13 to address earlier comments. > Pls confirm if these patches apply correctly. I'm in the process of moving to a new house, and getting a new computer

Re: 2.6.13-rc4-mm1: iptables DROP crashes the computer

2005-08-07 Thread Espen Fjellvær Olsen
On 07/08/05, Patrick McHardy <[EMAIL PROTECTED]> wrote: > Could be related to the refcnt underflow with conntrack event > notifications enabled. If you have CONFIG_IP_NF_CONNTRACK_EVENTS > enabled please try this patch. > I can confirm that that patch solved my problems, thank you :) -- Mvh / B

Re: [RFC PATCH] convert ebt_ulog to nfnetlink_log

2005-08-07 Thread Harald Welte
On Sun, Aug 07, 2005 at 09:27:56PM +, Bart De Schuymer wrote: > > I really hate to have those CONFIG_BRIDGE_NETFILTER ifdef's all over the > > code - but for now we have them almost everywhere, so two more doesn't > > hurt. At some point we need to get rid of this ugliness and have something >

Re: assertion (cnt <= tp->packets_out) failed

2005-08-07 Thread Herbert Xu
On Sun, Aug 07, 2005 at 03:25:55PM +0200, John B?ckstrand wrote: > > [148475.651000] [ cut here ] > [148475.651050] kernel BUG at net/ipv4/tcp_output.c:918! Yes, as Andrew said, this bug should be fixed in the latest git tree. So please test with that plus the debugging pa

Re: [RFC PATCH] convert ebt_ulog to nfnetlink_log

2005-08-07 Thread Bart De Schuymer
Op vr, 05-08-2005 te 19:10 +0200, schreef Harald Welte: > What about the following (only compile-tested) patch ? > > [NETFILTER] add phys{in,out}dev support to nfnetlink_log and nfnetlink_queue > > Since bridges don't have a 'reasonable' input and output net_device > (e.g. 'br0'), we need to add

Re: lockups with netconsole on e1000 on media insertion

2005-08-07 Thread John Bäckstrand
Steven Rostedt wrote: I don't have the card, so I can't test it. But if this works (after removing the previous patch) then this is the better solution. I can confirm that this alone does not work for the simple unplug/re-plug cycle I described, it still locks up hard. Tried this alone on -r

[-mm patch] fix PHYCONTROL=n compilation

2005-08-07 Thread Adrian Bunk
On Sun, Aug 07, 2005 at 11:51:23AM -0700, Avuton Olrich wrote: > On 8/7/05, Andrew Morton <[EMAIL PROTECTED]> wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc5/2.6.13-rc5-mm1/ > > I probably don't need/want phy stuff anyhow, but when I tried it: > > Problem: > dr

Re: ICMP debugging

2005-08-07 Thread Vladimir B. Savkin
On Sun, Aug 07, 2005 at 07:09:55PM +0200, Harald Welte wrote: > hi! > > could you please revert my patch adding the check, and rather apply the > following patch? > > This way we should find out where/when/how this "impossible" > configuration happens? I really need to understand what's going on

Fw: [Bugme-new] [Bug 5015] New: rp_filter documentation error in Kconfig

2005-08-07 Thread Andrew Morton
Kconfig help needs fixing? Begin forwarded message: Date: Sun, 7 Aug 2005 11:25:01 -0700 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 5015] New: rp_filter documentation error in Kconfig http://bugzilla.kernel.org/show_bug.cgi?id=5015 Summary: rp_filter d

Re: [PATCH] Fix erroneous ICMP corruption with iptable_nat and NOTRACK (was Re: ICMP broken in 2.6.13-rc5)

2005-08-07 Thread Patrick McHardy
Harald Welte wrote: > On Sun, Aug 07, 2005 at 05:18:06PM +0200, Harald Welte wrote: > >>The following trivial patch was confirmed to solve the problem. Patrick >>also has no objections, so please apply this to mainline. > > Please hold it back for another minute. I'm still puzzled by this > pro

Re: 2.6.13-rc4-mm1: iptables DROP crashes the computer

2005-08-07 Thread Patrick McHardy
Adrian Bunk wrote: > On Sun, Aug 07, 2005 at 07:12:00PM +0200, Espen Fjellvær Olsen wrote: > > >>After execing "iptables -A INPUT -j DROP" my computer crashes hard. It >>dosent hang immediately, but after a couple of seconds. >>The machine is an amd64, running a clean x86_64 environment. >>uname

Re: [PATCH] xfrm: do not use large arrays in BSS

2005-08-07 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Sun, 07 Aug 2005 20:33:38 +0200), Balazs Scheidler <[EMAIL PROTECTED]> says: > Commit log says it all. > + xfrm_state_bydst = (struct list_head *) __get_free_pages(GFP_KERNEL, > get_order(sizeof(struct list_head) * XFRM_DST_HSIZE * 2)); Please check the

[PATCH] xfrm: do not use large arrays in BSS

2005-08-07 Thread Balazs Scheidler
Hi, Commit log says it all. Signed-off-by: Balazs Scheidler <[EMAIL PROTECTED]> diff-tree a262e285077cb1604c25c5de99d71bbf739823e2 (from 684a28105211367d9040ee945cead597912cc49e) Author: Balazs Scheidler <[EMAIL PROTECTED](none)> Date: Sun Aug 7 20:23:59 2005 +0200 As discussed [1] in a

Re: 2.6.13-rc4-mm1: iptables DROP crashes the computer

2005-08-07 Thread Espen Fjellvær Olsen
On 07/08/05, Adrian Bunk <[EMAIL PROTECTED]> wrote: > On Sun, Aug 07, 2005 at 07:12:00PM +0200, Espen Fjellvær Olsen wrote: > > > After execing "iptables -A INPUT -j DROP" my computer crashes hard. It > > dosent hang immediately, but after a couple of seconds. > > The machine is an amd64, running

Re: 2.6.13-rc4-mm1: iptables DROP crashes the computer

2005-08-07 Thread Adrian Bunk
On Sun, Aug 07, 2005 at 07:12:00PM +0200, Espen Fjellvær Olsen wrote: > After execing "iptables -A INPUT -j DROP" my computer crashes hard. It > dosent hang immediately, but after a couple of seconds. > The machine is an amd64, running a clean x86_64 environment. > uname -a: Linux gentoo 2.6.13-rc

ICMP debugging

2005-08-07 Thread Harald Welte
hi! could you please revert my patch adding the check, and rather apply the following patch? This way we should find out where/when/how this "impossible" configuration happens? I really need to understand what's going on, and I cannot reproduce the bug here. Thanks! -- - Harald Welte <[EMAIL

Fw: [Bugme-new] [Bug 5014] New: rp_filter proc interface generate oops when enable

2005-08-07 Thread Andrew Morton
Begin forwarded message: Date: Sun, 7 Aug 2005 07:12:40 -0700 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 5014] New: rp_filter proc interface generate oops when enable http://bugzilla.kernel.org/show_bug.cgi?id=5014 Summary: rp_filter proc interface gen

Re: assertion (cnt <= tp->packets_out) failed

2005-08-07 Thread Andrew Morton
John Bäckstrand <[EMAIL PROTECTED]> wrote: > > Someone asked if I could try to trigger this assertion again, and I'm > afraid I probably cannot, I didnt do anything special at the time. But > I've got something even better for you all, got a BUG from something > tcp-related. Mind you, I am t

Re: [PATCH] Fix erroneous ICMP corruption with iptable_nat and NOTRACK (was Re: ICMP broken in 2.6.13-rc5)

2005-08-07 Thread Vladimir B. Savkin
On Sun, Aug 07, 2005 at 06:44:15PM +0200, Harald Welte wrote: > On Sun, Aug 07, 2005 at 05:18:06PM +0200, Harald Welte wrote: > > Hi Dave! > > > > The following trivial patch was confirmed to solve the problem. Patrick > > also has no objections, so please apply this to mainline. > > Please hold

Re: [PATCH] Fix erroneous ICMP corruption with iptable_nat and NOTRACK (was Re: ICMP broken in 2.6.13-rc5)

2005-08-07 Thread Harald Welte
On Sun, Aug 07, 2005 at 05:18:06PM +0200, Harald Welte wrote: > Hi Dave! > > The following trivial patch was confirmed to solve the problem. Patrick > also has no objections, so please apply this to mainline. Please hold it back for another minute. I'm still puzzled by this problem. I can neit

[-mm patch] drivers/net/phy/phy_device.c: fix compilation

2005-08-07 Thread Adrian Bunk
On Sun, Aug 07, 2005 at 01:42:14AM -0700, Andrew Morton wrote: >... > Changes since 2.6.13-rc4-mm1: >... > git-netdev-upstream.patch >... > Subsystem trees >... gcc 4.0 correctly rejects this code: <-- snip --> ... CC drivers/net/phy/phy_device.o drivers/net/phy/phy_device.c:659: erro

Re: [PATCH] reorganize include/linux/dccp.h

2005-08-07 Thread Arnaldo Carvalho de Melo
On 8/7/05, Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote: > Em Sun, Aug 07, 2005 at 04:59:27PM +0200, Harald Welte escreveu: > > On Sun, Aug 07, 2005 at 04:13:16AM -0300, Arnaldo Carvalho de Melo wrote: > > > > you cannot include linux/in.h from the top of the file, I think I tried > > > > tha

Re: [PATCH] reorganize include/linux/dccp.h

2005-08-07 Thread Arnaldo Carvalho de Melo
Em Sun, Aug 07, 2005 at 04:59:27PM +0200, Harald Welte escreveu: > On Sun, Aug 07, 2005 at 04:13:16AM -0300, Arnaldo Carvalho de Melo wrote: > > > you cannot include linux/in.h from the top of the file, I think I tried > > > that and ran into problems (the definitions collide with glibc > > > defin

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-07 Thread Harald Welte
On Sun, Aug 07, 2005 at 01:20:39PM +0200, Thomas Graf wrote: > * Harald Welte <[EMAIL PROTECTED]> 2005-07-30 12:30 > > This (long-awaited) patch adds the generic nfnetlink-based userspace > > logging. nfnetlink_log can be used for any protocol family, and > > supports upt to 65535 logging groups (

Re: atheros driver - desc

2005-08-07 Thread Harald Welte
On Sun, Aug 07, 2005 at 10:32:07AM +0300, Kalle Valo wrote: > Harald Welte <[EMAIL PROTECTED]> writes: > > > I don't want to turn this list into a list of legal discussion, but > > since I'm heavily dealing with exactly those issues during my > > gpl-violations.org efforts, I thought I share some

[PATCH] Fix erroneous ICMP corruption with iptable_nat and NOTRACK (was Re: ICMP broken in 2.6.13-rc5)

2005-08-07 Thread Harald Welte
Hi Dave! The following trivial patch was confirmed to solve the problem. Patrick also has no objections, so please apply this to mainline. I'm undecided whether it should go into 2.6.12.x, since the problem only occurs in very rare usage cases. OTOTH, the fix is very trivial... so I leave it up

Re: [PATCH] reorganize include/linux/dccp.h

2005-08-07 Thread Harald Welte
On Sun, Aug 07, 2005 at 04:13:16AM -0300, Arnaldo Carvalho de Melo wrote: > > you cannot include linux/in.h from the top of the file, I think I tried > > that and ran into problems (the definitions collide with glibc > > definitions e.g. of sockaddr_in, etc.) > > > > So if possible, move that incl

Re: assertion (cnt <= tp->packets_out) failed

2005-08-07 Thread John Bäckstrand
Someone asked if I could try to trigger this assertion again, and I'm afraid I probably cannot, I didnt do anything special at the time. But I've got something even better for you all, got a BUG from something tcp-related. Mind you, I am trying to find a possibly hardware-related issue here, so

Re: [RFC] Netlink subscription/multicasting.

2005-08-07 Thread Evgeniy Polyakov
On Sun, Aug 07, 2005 at 01:50:22PM +0200, Thomas Graf ([EMAIL PROTECTED]) wrote: > * Evgeniy Polyakov <[EMAIL PROTECTED]> 2005-08-07 15:19 > > On Sun, Aug 07, 2005 at 01:12:19PM +0200, Thomas Graf ([EMAIL PROTECTED]) > > wrote: > > > I don't get this, you introduce a new option which basically > >

Re: assertion (cnt <= tp->packets_out) failed

2005-08-07 Thread Herbert Xu
On Sat, Aug 06, 2005 at 02:06:53PM +0200, John B?ckstrand wrote: > > Yes, I have no other patches in, so if it was not in -RC5, I was not > running it. OK having looked at it briefly I have a hunch that it may be the fackets_out issue (when the effective MSS is reduced tcp_tso_acked may increase

Re: [RFC] Netlink subscription/multicasting.

2005-08-07 Thread Thomas Graf
* Evgeniy Polyakov <[EMAIL PROTECTED]> 2005-08-07 15:19 > On Sun, Aug 07, 2005 at 01:12:19PM +0200, Thomas Graf ([EMAIL PROTECTED]) > wrote: > > I don't get this, you introduce a new option which basically > > changes the subscription schema from a bitmask to a single > > identifier. I don't see a

Re: [RFC] Netlink subscription/multicasting.

2005-08-07 Thread Evgeniy Polyakov
On Sun, Aug 07, 2005 at 01:12:19PM +0200, Thomas Graf ([EMAIL PROTECTED]) wrote: > * Evgeniy Polyakov <[EMAIL PROTECTED]> 2005-07-29 14:45 > > Subscription is a netlink socket option, which, if enabled, ends up > > in direct message delivering, but not multicast one. > > I don't get this, you intr

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-07 Thread Thomas Graf
* Harald Welte <[EMAIL PROTECTED]> 2005-07-30 12:30 > This (long-awaited) patch adds the generic nfnetlink-based userspace > logging. nfnetlink_log can be used for any protocol family, and > supports upt to 65535 logging groups (that could go to separate logging > daemons, e.g.). Same very minor

Re: [RFC] Netlink subscription/multicasting.

2005-08-07 Thread Thomas Graf
* Evgeniy Polyakov <[EMAIL PROTECTED]> 2005-07-29 14:45 > Subscription is a netlink socket option, which, if enabled, ends up > in direct message delivering, but not multicast one. I don't get this, you introduce a new option which basically changes the subscription schema from a bitmask to a sing

Re: QoS for web traffic

2005-08-07 Thread Thomas Graf
* Anand SVR <[EMAIL PROTECTED]> 2005-07-27 23:17 > As a starting point, I would like to define classification rules such > that web access to > *.edu OR *.net OR *.org can be put under one bandwidth chunk. Public > mail sites such as *.yahoo.com OR gmail.com OR *hotmail.com under a > different ch

Re: atheros driver - desc

2005-08-07 Thread Kalle Valo
Harald Welte <[EMAIL PROTECTED]> writes: > I don't want to turn this list into a list of legal discussion, but > since I'm heavily dealing with exactly those issues during my > gpl-violations.org efforts, I thought I share some of the facts. Thanks for your answer, it cleared up things. I also do

Re: [PATCH] reorganize include/linux/dccp.h

2005-08-07 Thread Arnaldo Carvalho de Melo
Em Sun, Aug 07, 2005 at 08:58:34AM +0200, Harald Welte escreveu: > On Sat, Aug 06, 2005 at 06:34:40PM -0300, Arnaldo Carvalho de Melo wrote: > > On 8/6/05, Harald Welte <[EMAIL PROTECTED]> wrote: > > > Hi Arnaldo! > > > > > > The protocol header files in are usually structured in a > > > way to b

Re: [PATCH] reorganize include/linux/dccp.h

2005-08-07 Thread Harald Welte
On Sat, Aug 06, 2005 at 06:34:40PM -0300, Arnaldo Carvalho de Melo wrote: > On 8/6/05, Harald Welte <[EMAIL PROTECTED]> wrote: > > Hi Arnaldo! > > > > The protocol header files in are usually structured in a > > way to be included by userspace code. The top section consists of > > general protoc