On Tue, Aug 30, 2005 at 10:45:54PM +0200, Jesper Juhl wrote:
I've posted similar patches in the past, but was asked to first until the
short-circuit patch moved from -mm to mainline - and since it is now
firmly there in 2.6.13 I assume there's no problem there anymore.
I was also asked
Vlad Yasevich wrote:
Declares ip_tos2prio as an exported symbol, so that modules
wishing to use rt_tos2priority() call, may do so.
And which ones would that be? We usually don't export symbols
unless there is an in-kernel user that needs it.
-
To unsubscribe from this list: send the line
Vlad Yasevich wrote:
I am trying to teach SCTP about the TOS settings on a per-association
basis. While trying to do that, I was using rt_tos2priority call.
Everything worked great while sctp was built into the kernel, but
builds failed when building as a module.
I tracked it down to this
Francois Romieu [EMAIL PROTECTED] writes:
Arnaud Patard [EMAIL PROTECTED] :
[...]
Btw it would be nice if you could give a quick test to the three
attached patches against 2.6.13-git: #0, #0 + #1, #0 + #1 + #2.
The first patch 160 works as expected.
I've also tested the two others patches
Ok. I'll hold off on this till the full patch is complete.
Thanks
-vlad
Patrick McHardy wrote:
Vlad Yasevich wrote:
I am trying to teach SCTP about the TOS settings on a per-association
basis. While trying to do that, I was using rt_tos2priority call.
Everything worked great while sctp was
Hi,
I have encountered a bug in the pskb_expand_head procedure in
net/core/skbuff.h. The following chunk is wrong i think.
skb_release_data(skb);
off = (data+nhead) - skb-head;
The data of skb is first released and then skb-head is used in the
very next statement.
regards,
Qasim Javed
-
To
Daniel Drake wrote:
Hi,
A gentoo user reported these messages on boot:
eth0: resetting device...
eth0: uploading firmware...
eth0: firmware version: 1.0.4.3
eth0: firmware upload complete
eth0: interface reset complete
spurious 8259A interrupt: IRQ7.
eth0: islpci_close ()
eth0:
Qasim Javed wrote:
Hi,
I have encountered a bug in the pskb_expand_head procedure in
net/core/skbuff.h. The following chunk is wrong i think.
skb_release_data(skb);
off = (data+nhead) - skb-head;
The data of skb is first released and then skb-head is used in the
very next statement.
On Wed, 31 Aug 2005 11:57:15 -0400, Peter Jones wrote:
I don't think that's really right either. For one thing, things like
DHCP's timeout start counting at about the same time as ifconfig up,
and association can take some time.
You're right, thanks for pointing this out.
But why don't we
Jouni Malinen [EMAIL PROTECTED] writes:
applied, but let us know when the root cause is found...
local-hw_priv was initialized only after the interrupt handler was
registered. This could trigger a NULL pointer dereference in
prism2_pccard_card_present() that assumed that local-hw_priv is
Hi!
What other changes are required in userspace after your patches are
applied?
AFAIK none.
Really?
AFAICS, with your patches ifconfig shows counts of wifi packets. How
do I get ethernet packet counts? Will tcpdump wlan0 work on ethernet
or wifi level?
I agree. Don't know who
From: Vlad Yasevich [EMAIL PROTECTED]
Date: Wed, 31 Aug 2005 09:16:32 -0400
Declares ip_tos2prio as an exported symbol, so that modules
wishing to use rt_tos2priority() call, may do so.
Signed-off-by: Vlad Yasevich [EMAIL PROTECTED]
When you add an in-tree legitimate use, we'll export the
From: Vlad Yasevich [EMAIL PROTECTED]
Date: Wed, 31 Aug 2005 10:10:48 -0400
I am trying to teach SCTP about the TOS settings on a per-association
basis. While trying to do that, I was using rt_tos2priority call.
Everything worked great while sctp was built into the kernel, but
builds failed
From: Qasim Javed [EMAIL PROTECTED]
Date: Wed, 31 Aug 2005 21:04:26 +0500
I have encountered a bug in the pskb_expand_head procedure in
net/core/skbuff.h. The following chunk is wrong i think.
You mean net/core/skbuff.c
skb_release_data(skb);
off = (data+nhead) - skb-head;
The data of
On Wed, 2005-08-31 at 19:08 +0200, Jiri Benc wrote:
But is it really needed? Imagine the situation when computer is started
with unplugged ethernet cable which is plugged in later. I know, this is
rare, but - shouldn't be the right approach that DHCP is started by
hotplug when the carrier is
On Wed, 2005-08-31 at 10:52 -0700, Jean Tourrilhes wrote:
Peter Jones [EMAIL PROTECTED] wrote :
I don't think that's really right either. For one thing, things like
DHCP's timeout start counting at about the same time as ifconfig up,
and association can take some time.
That's
Arnaud Patard [EMAIL PROTECTED] :
[...]
I've also tested the two others patches as suggested but I didn't
notice any difference (I got only eth0: GMII mode). Unfortunately,
I'm not sure that the test is reliable as the PHY
transceiver of my card is unknow to the driver...
The test is very
Fixes for packet split related issues
* On platforms where PAGE_SIZE 4K, driver will use only required number of
pages compared to always using 3 pages.
* Packet split won't be used if the PAGE_SIZE is 16K
* Adds a statistics counter to splits.
* Setting the non Null ptr to zero
Enable custom configuration bits for 82571/2 controllers. The bits are
required for correct functionality of these controllers.
Signed-off-by: Mallikarjuna R Chilakala [EMAIL PROTECTED]
Signed-off-by: Ganesh Venkatesan [EMAIL PROTECTED]
Signed-off-by: John Ronciak [EMAIL PROTECTED]
diff -up
On Wed, Aug 31, 2005 at 05:43:32PM -0400, Peter Jones wrote:
On Wed, 2005-08-31 at 10:52 -0700, Jean Tourrilhes wrote:
Peter Jones [EMAIL PROTECTED] wrote :
I don't think that's really right either. For one thing, things like
DHCP's timeout start counting at about the same time as
* Alexey Kuznetsov ([EMAIL PROTECTED]) wrote:
Hello!
Thanks for that explanation - it helps somewhat - one thing I was
confused by was why the timer mechanism for the garbage collection
was so elaborate; why does it do all that back off stuff and
adjusting itself? Why not just run at
Hi,
This is a series of patches for the iseries_veth driver. Most of these are
pretty much unchanged since I posted them earlier:
http://www.uwsg.iu.edu/hypermail/linux/kernel/0506.3/1837.html
I've added patches to add sysfs support, and do some further code cleanups.
Please merge if they look
Currently the iseries_veth driver prints the file name and line number in its
error messages. This isn't very useful for most users, so just print
iseries_veth: message instead.
- convert uses of veth_printk() to veth_debug()/veth_error()/veth_info()
- make terminology consistent, ie. always
The iseries_veth driver unconditionally calls dma_unmap_single() even
when the corresponding dma_map_single() may have failed.
Rework the code a bit to keep the return value from dma_unmap_single()
around, and then check if it's a dma_mapping_error() before we do
the dma_unmap_single().
The iseries_veth driver tells sysfs that it's called 'iseries_veth', but if
you ask it via ethtool it thinks it's called 'veth'. I think this comes from
2.4 when the driver was called 'veth', but it's definitely called
'iseries_veth' now, so fix it.
To make sure we don't do it again define
This patch makes veth_init_connection() and veth_destroy_connection()
symmetrical in that they allocate/deallocate the same data.
Currently if there's an error while initialising connections (ie. ENOMEM)
we call veth_module_cleanup(), however this will oops because we call
driver_unregister()
Having merged iseries_veth.h, let's remove some of the studly caps that came
with it.
Signed-off-by: Michael Ellerman [EMAIL PROTECTED]
---
drivers/net/iseries_veth.c | 74 ++---
1 files changed, 37 insertions(+), 37 deletions(-)
Index:
Also to aid debugging, add sysfs support for iseries_veth's port structures.
Signed-off-by: Michael Ellerman [EMAIL PROTECTED]
---
drivers/net/iseries_veth.c | 67 +
1 files changed, 67 insertions(+)
Index: veth-dev2/drivers/net/iseries_veth.c
Currently the iseries_veth driver contravenes the specification in
Documentation/networking/driver.txt, in that if packets are not acked by
the other LPAR they will sit around forever.
This patch adds a per-connection timer which fires if we've had no acks for
five seconds. This is superior to
The iseries_veth driver contains a state machine which is used to manage
how connections are setup and neogotiated between LPARs.
If one side of a connection resets for some reason, the two LPARs can get
stuck in a race to re-setup the connection. This can lead to the connection
being declared
The iseries_veth driver keeps a stack of messages for each connection
and a lock to protect the stack. However there is also a per-connection lock
which makes the message stack lock redundant.
Remove the message stack lock and document the fact that callers of the
stack-manipulation functions
The iseries_veth driver has a timer which we use to send acks. When the
connection is reset or stopped we need to delete the timer.
Currently we only call del_timer() when resetting a connection, which means
the timer might run again while the connection is being re-setup. As it turns
out that's
The iseries_veth driver uses the generic TX timeout watchdog, however a better
solution is in the works, so remove this code.
Signed-off-by: Michael Ellerman [EMAIL PROTECTED]
---
drivers/net/iseries_veth.c | 48 -
1 files changed, 48 deletions(-)
The iseries_veth driver can attach to multiple vlans, which correspond to
multiple net devices. However there is only 1 connection between each LPAR,
so the connection structure may be shared by multiple net devices.
This makes module removal messy, because we can't deallocate the connections
To aid in field debugging, add sysfs support for iseries_veth's connection
structures. At the moment this is all read-only, however we could think about
adding write support for some attributes in future.
Signed-off-by: Michael Ellerman [EMAIL PROTECTED]
---
drivers/net/iseries_veth.c | 94
35 matches
Mail list logo
