Re: (2nd try) [PATCH] corruption during e100 MDI register access

2006-01-07 Thread Jesse Brandeburg
On 1/6/06, ODonnell, Michael <[EMAIL PROTECTED]> wrote: > [ 2nd transmission. Microsoft mailer "helpfully" > reformatted the patch in the last one... :-(] > > Greetings, > > We have identified two related bugs in the e100 driver and we request > that they be repaired in the official Intel v

mv643xx_eth_start_xmit: calls skb_linearize with interrupts off

2006-01-07 Thread Paul Janzen
Hi, I am seeing backtraces on 2.6.15-rc7 on NFS traffic that are similar to this one: Badness in local_bh_enable at kernel/softirq.c:140 Call trace: [c0005340] check_bug_trap+0xb0/0xd0 [c0005bb4] program_check_exception+0x174/0x4f0 [c0004f04] ret_from_except_full+0x0/0x4c [c0021b8c] local_bh

[PATCH] Change some "if (x) BUG();" to "BUG_ON(x);"

2006-01-07 Thread Kris Katterjohn
This changes some simple "if (x) BUG();" statements to "BUG_ON(x);" Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> This is a diff from 2.6.15. Obviously I wasn't able to test these changes per se, but is there a reason they wouldn't work correctly? Thanks! --- x/net/core/dev.c2006-01-0

Re: [PATCH 6/6][PKT_SCHED]: Prefix tc actions with act_

2006-01-07 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Sun, 08 Jan 2006 00:38:03 +0100 > This patch prefixes the tc actions with act_. I didn't include > the actual renames in the patch because I think it makes git > loose its history, please execute these commands when applying > the patch: Note that w

[W1]: Remove incorrect MODULE_ALIAS

2006-01-07 Thread Patrick McHardy
[W1]: Remove incorrect MODULE_ALIAS The w1 netlink socket is created by a hardware specific driver calling w1_add_master_device, so there is no point in including a module alias for netlink autoloading in the core. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit a8657adb8c04bbe305

[PATCH 3/6][PKT_SCHED]: Convert tc action functions to single skb pointers

2006-01-07 Thread Patrick McHardy
[PKT_SCHED]: Convert tc action functions to single skb pointers tcf_action_exec only gets a single skb pointer and doesn't own the skb, but passes double skb pointers (to a local variable) to the action functions. Change to use single skb pointers everywhere. Signed-off-by: Patrick McHardy <[EMA

[PATCH 4/6][PKT_SCHED]: Remove some obsolete policer exports

2006-01-07 Thread Patrick McHardy
[PKT_SCHED]: Remove some obsolete policer exports Also make sure the legacy code is only built when CONFIG_NET_CLS_ACT is not set. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 913c3439802f049aa6938116a662875d0ba1b62f tree e14e9413ea0732e397932459545134fcd0f9adf7 parent c69c8677

[PATCH 5/6][PKT_SCHED]: Fix memory leak when dumping in pedit action

2006-01-07 Thread Patrick McHardy
[PKT_SCHED]: Fix memory leak when dumping in pedit action Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit b73952761225e41cb81afe157cb312a594a95693 tree be5312ebbabc4f10c9e08a00b34adaec3c636088 parent 0aec63e67c69545ca757a73a66f5dcf05fa484bf author Patrick McHardy <[EMAIL PROTECTED]

[PATCH 6/6][PKT_SCHED]: Prefix tc actions with act_

2006-01-07 Thread Patrick McHardy
This patch prefixes the tc actions with act_. I didn't include the actual renames in the patch because I think it makes git loose its history, please execute these commands when applying the patch: git-rename net/sched/mirred.c net/sched/act_mirred.c git-rename net/sched/ipt.c net/sched/act_ipt.c

[PATCH 1/6][NET]: Convert net/{ipv4,ipv6,sched} to netdev_priv

2006-01-07 Thread Patrick McHardy
Hi Dave, following are a couple of assorted patches I found while cleaning out old trees. Please apply, thanks. [NET]: Convert net/{ipv4,ipv6,sched} to netdev_priv Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 763b3dea377647e2eb0d7638143b9a22d32fb989 tree d4932b5cfe487c8d6e4ca

[PATCH 2/6][PKT_SCHED]: Use USEC_PER_SEC

2006-01-07 Thread Patrick McHardy
[PKT_SCHED]: Use USEC_PER_SEC Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit ab1afff516ec3ea3fa2afa8fcf94afdc0c2f6464 tree 6e41ef25fd8994436d1ab32c9503f46470e9e985 parent 0aec63e67c69545ca757a73a66f5dcf05fa484bf author Patrick McHardy <[EMAIL PROTECTED]> Sat, 07 Jan 2006 22:47:18

Re: [PATCH] Endian-annotate struct iphdr

2006-01-07 Thread Al Viro
On Sat, Jan 07, 2006 at 01:05:53PM -0800, David S. Miller wrote: > Why are you shifting "addr" instead of "n"? Because of a braino done when (re)typing it? ;-) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: SiS190 on ASUS. monodirectional traffic

2006-01-07 Thread Marco Atzeri
On Sat, Jan 07, 2006 at 03:45:14PM +0100, Francois Romieu wrote: > Marco Atzeri <[EMAIL PROTECTED]> : > [...] > > > Asus motherboard K8SMV with integrated SIS190 ethernet driver > > vanilla kernel 2.6.15 (but the same also for .14) on Fedora 4 > > > > out 37.68 MB at 6.32 MB/s OK > > re

[RFC: 2.6 patch] kernel/posix-timers.c: remove do_posix_clock_notimer_create()

2006-01-07 Thread Adrian Bunk
Is there any reason for this function that is neither used nor has any real contents? Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- include/linux/posix-timers.h |1 - kernel/posix-timers.c|6 -- 2 files changed, 7 deletions(-) --- linux-2.6.15-mm2-full/include/linux/

Re: Multicast using bound socket

2006-01-07 Thread Jori Liesenborgs
On Saturday 07 January 2006 23:10, you wrote: > > Then does this mean that there is no way to ensure that a particular > > socket can only receive multicast packets which arrived on a specific > > interface? > Try SO_BINDTODEVICE. Ok, thanks! Bye, Jori - To unsubscribe from this list: send the lin

Re: Multicast using bound socket

2006-01-07 Thread David S. Miller
From: Jori Liesenborgs <[EMAIL PROTECTED]> Date: Sat, 7 Jan 2006 23:04:06 +0100 > Then does this mean that there is no way to ensure that a particular socket > can only receive multicast packets which arrived on a specific interface? Try SO_BINDTODEVICE. - To unsubscribe from this list: send the

Re: Multicast using bound socket

2006-01-07 Thread Jori Liesenborgs
On Saturday 07 January 2006 22:04, you wrote: > A bound socket will only receive packets that match the binding. > If you want to receive packets sent to a particular multicast address, > you need to bind to that address. > Group membership is per-interface, not per-socket. You can

Re: State of the Union: Wireless

2006-01-07 Thread Danny van Dyk
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Stefan Rompf schrieb: | so, can we agree on this: | | a)we want to distinguish between physical devices and virtual devices. | Physical devices represent a network card, virtual devices a function based | on the card (access point, sta, ...). Some car

Fw: [Bugme-new] [Bug 5848] New: pcmcia novatel merlin u530 not working properly on 2.6.13 and up

2006-01-07 Thread Andrew Morton
The card seems to be sending and receiving OK. I'm wondering if this is a ppp problem? Begin forwarded message: Date: Sat, 7 Jan 2006 08:29:54 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 5848] New: pcmcia novatel merlin u530 not working properly on 2.6.13 and

Re: [2.6 patch] net/ipv6/: small cleanups

2006-01-07 Thread David S. Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Sat, 7 Jan 2006 19:17:23 +0100 > This patch contains the following cleanups: > - addrconf.c: make addrconf_dad_stop() static > - inet6_connection_sock.c should #include > for getting the prototypes of it's global functions > > Signed-off-by: Adrian B

Re: [RFC: 2.6 patch] net/ipv4/ip_output.c: make ip_fragment() static

2006-01-07 Thread David S. Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Sat, 7 Jan 2006 19:15:33 +0100 > Since there's no longer any external user of ip_fragment() we can make > it static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Works for me, applied. Thanks. - To unsubscribe from this list: send the line "uns

Re: Multicast using bound socket

2006-01-07 Thread David S. Miller
From: David Stevens <[EMAIL PROTECTED]> Date: Sat, 7 Jan 2006 13:04:51 -0800 > A bound socket will only receive packets that match the > binding. If you want to receive packets sent to a particular > multicast address, you need to bind to that address. That's how I see this as well. - T

Re: [PATCH] Endian-annotate struct iphdr

2006-01-07 Thread David S. Miller
From: Al Viro <[EMAIL PROTECTED]> Date: Sat, 7 Jan 2006 12:26:06 + > OK. Another question: do you have any objections against > static inline void ip_eth_mc_map(__be32 addr, char *buf) > { > __u32 n=ntohl(addr); > buf[0]=0x01; > buf[1]=0x00; > buf[2]=0x5e; >

Re: Multicast using bound socket

2006-01-07 Thread David Stevens
[EMAIL PROTECTED] wrote on 01/07/2006 08:13:17 AM: > I've encountered the following problem: when a UDP socket was bound > to a specific interface and a multicast group was joined, no packets > sent to that multicast group were delivered to the application. If the > socket was not bound to a spec

Re: [PATCH, RFC] RCU : OOM avoidance and lower latency

2006-01-07 Thread Paul E. McKenney
On Sat, Jan 07, 2006 at 12:36:25AM -0800, David S. Miller wrote: > From: Eric Dumazet <[EMAIL PROTECTED]> > Date: Sat, 07 Jan 2006 08:53:52 +0100 > > > I have no problem with this, since the biggest server I have is 4 > > way, but are you sure big machines wont suffer from this single > > spinlock

Re: State of the Union: Wireless

2006-01-07 Thread Stefan Rompf
Hi, so, can we agree on this: a)we want to distinguish between physical devices and virtual devices. Physical devices represent a network card, virtual devices a function based on the card (access point, sta, ...). Some cards can handle multiple functions parallel, we support it this way. Cav

Re: [PATCH] Endian-annotate struct iphdr

2006-01-07 Thread Linus Torvalds
On Sat, 7 Jan 2006, Al Viro wrote: > > [following is for people familiar with sparse internals; everybody else > can safely skip it] > > ... > > Objections? Basically, from C POV any fouled value is int or unsigned int > and we avoid generating a warning only if its upper bits will eventually

[RFC: 2.6 patch] net/ipv4/ip_output.c: make ip_fragment() static

2006-01-07 Thread Adrian Bunk
Since there's no longer any external user of ip_fragment() we can make it static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- include/net/ip.h |1 - net/ipv4/ip_output.c |5 +++-- 2 files changed, 3 insertions(+), 3 deletions(-) --- linux-2.6.15-mm2-full/include/net/ip.h.o

[2.6 patch] net/ipv6/: small cleanups

2006-01-07 Thread Adrian Bunk
This patch contains the following cleanups: - addrconf.c: make addrconf_dad_stop() static - inet6_connection_sock.c should #include for getting the prototypes of it's global functions Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- net/ipv6/addrconf.c |2 +- net/ipv6/ine

[PATCH] Additional options for resetting packet statistics

2006-01-07 Thread Kris Katterjohn
This adds some setsockopt(SOL_PACKET) options for changing the behavior when getting packet statistics from the kernel. Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]> This is a diff from 2.6.15 and I AM subscribed to netdev, so you dont' need to CC me anymore. I sent this to the linux-kernel

Re: State of the Union: Wireless

2006-01-07 Thread Denis Vlasenko
ayer: * Broadcom 43xx driver" but Broadcom driver page at ftp://ftp.berlios.de/pub/bcm43xx/snapshots/softmac/ has ftp://ftp.berlios.de/pub/bcm43xx/snapshots/softmac/ieee80211softmac-20060107.tar.bz2 which is not the same. For example, ieee80211softmac.h file exists in both tarballs but is not id

Re: SiS190 on ASUS. monodirectional traffic

2006-01-07 Thread Francois Romieu
Marco Atzeri <[EMAIL PROTECTED]> : [...] > first tentative to write a bug report You are welcome. > Asus motherboard K8SMV with integrated SIS190 ethernet driver > vanilla kernel 2.6.15 (but the same also for .14) on Fedora 4 > > The SIS190 works sending data out but hangs around 90K when > rece

Re: [PATCH] Endian-annotate struct iphdr

2006-01-07 Thread Al Viro
On Sat, Jan 07, 2006 at 02:03:42AM -0800, David S. Miller wrote: > From: Al Viro <[EMAIL PROTECTED]> > Date: Sat, 7 Jan 2006 09:39:10 + > > > BTW, is there any reason why > > static inline void ip_eth_mc_map(u32 addr, char *buf) > > { > > addr=ntohl(addr); > > buf[0]=0x01; > >

Re: [PATCH] Endian-annotate struct iphdr

2006-01-07 Thread David S. Miller
From: Al Viro <[EMAIL PROTECTED]> Date: Sat, 7 Jan 2006 09:39:10 + > BTW, is there any reason why > static inline void ip_eth_mc_map(u32 addr, char *buf) > { > addr=ntohl(addr); > buf[0]=0x01; > buf[1]=0x00; > buf[2]=0x5e; > buf[5]=addr&0xFF; > a

Re: [PATCH] Endian-annotate struct iphdr

2006-01-07 Thread Al Viro
On Sat, Jan 07, 2006 at 12:59:15AM -0800, David S. Miller wrote: > Why not just make some kind of "negate()" macro that hides away all of > the typing issues? Another way to describe the operation is as a > xor of X with an all-1's bitmask the same size of X. Maybe that helps > describe it better

Re: [PATCH] Endian-annotate struct iphdr

2006-01-07 Thread David S. Miller
From: Al Viro <[EMAIL PROTECTED]> Date: Sat, 7 Jan 2006 08:44:42 + [ BTW Al, I noticed you subscribed to netdev, you don't need to do that if all you want to do is make a posting and be involved in that particular discussion. If you really are interested in everything else that goes on

SiS190 on ASUS. monodirectional traffic

2006-01-07 Thread Marco Atzeri
Hi All, first tentative to write a bug report Asus motherboard K8SMV with integrated SIS190 ethernet driver vanilla kernel 2.6.15 (but the same also for .14) on Fedora 4 The SIS190 works sending data out but hangs around 90K when receiving data in. No problem at all with the additional 8139 board

Re: [PATCH] Endian-annotate struct iphdr

2006-01-07 Thread Al Viro
BTW, why does csum_tcpudp_nofold() have such a prototype? It takes IP addresses as unsigned long and proto as unsigned short; the former is bloody odd on 64bit boxen and the latter is bloody odd, period. The value we are interested in is 8bit; all callers pass either an explicit constant

Re: [PATCH, RFC] RCU : OOM avoidance and lower latency

2006-01-07 Thread David S. Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Sat, 07 Jan 2006 08:53:52 +0100 > I have no problem with this, since the biggest server I have is 4 > way, but are you sure big machines wont suffer from this single > spinlock ? It is the main question. > Also I dont understand what you want to do af

Re: [PATCH, RFC] RCU : OOM avoidance and lower latency

2006-01-07 Thread Eric Dumazet
David S. Miller a écrit : Eric, how important do you honestly think the per-hashchain spinlocks are? That's the big barrier from making rt_secret_rebuild() a simple rehash instead of flushing the whole table as it does now. No problem for me in going to a single spinlock. I did the hashed sp