Hi all,
The attached patch is a follow up to a post made earlier to this site
with regard to 32 bit (socket layer) ioctl emulation for 64 bit kernels.
I needed to implement 32 bit userland ioctl support for modular (x.25)
socket ioctls in a 64 bit kernel. With the removal of the
register_ioctl32_c
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Mon, 09 Jan 2006 01:01:27 +0100
> I noticed IPv6 only sets skb->priority in raw.c but not in
> ip6_output.c, which seems to be a mistake.
Applied, thanks Patrick.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a m
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Sun, 08 Jan 2006 22:56:35 +0100
> This patch fixes a warning from my IPsec patches:
>
>CC net/ipv4/ip_output.o
> net/ipv4/ip_output.c: In function 'ip_finish_output':
> net/ipv4/ip_output.c:208: warning: implicit declaration of function
>
From: Jamal Hadi Salim <[EMAIL PROTECTED]>
Date: Sun, 08 Jan 2006 14:34:03 -0500
> Ok, heres a resubmit after discussion with Patrick.
Applied, thanks Jamal.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at h
From: Jamal Hadi Salim <[EMAIL PROTECTED]>
Date: Sun, 08 Jan 2006 12:43:20 -0500
> Heres a resubmit of the IFB device. Updates from latest comments (much
> much thanks Patrick).
> Dave please apply this one. Any further comments that come up after this
> go in as separate patches.
Applied, thank
From: Ralf Baechle <[EMAIL PROTECTED]>
Date: Sun, 8 Jan 2006 10:43:19 +0100
> No, with your patch the spinlock is dropped only after the
> tty->driver->write() call which might sleep.
>
> Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]>
Applied, thanks Ralf.
-
To unsubscribe from this list: send
From: "Kris Katterjohn" <[EMAIL PROTECTED]>
Date: Sat, 7 Jan 2006 18:49:17 -0800
> This changes some simple "if (x) BUG();" statements to "BUG_ON(x);"
>
> Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]>
Applied, thanks Kris.
-
To unsubscribe from this list: send the line "unsubscribe netdev"
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Sun, 08 Jan 2006 00:38:03 +0100
> [PKT_SCHED]: Prefix tc actions with act_
>
> Clean up the net/sched directory a bit by prefix all actions with act_.
>
> Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
Applied, with the appropriate rename comm
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Sun, 08 Jan 2006 00:37:56 +0100
> [PKT_SCHED]: Fix memory leak when dumping in pedit action
>
> Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
Applied, thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Sun, 08 Jan 2006 00:37:51 +0100
> [PKT_SCHED]: Remove some obsolete policer exports
>
> Also make sure the legacy code is only built when CONFIG_NET_CLS_ACT
> is not set.
>
> Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
Applied, thanks.
-
To
Applied, thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Sun, 08 Jan 2006 00:37:28 +0100
> following are a couple of assorted patches I found while
> cleaning out old trees. Please apply, thanks.
...
> [NET]: Convert net/{ipv4,ipv6,sched} to netdev_priv
>
> Signed-off-by: Patrick McHardy <[EMAIL PROTECTED
Paul Janzen <[EMAIL PROTECTED]> writes:
> In mv643xx_eth_start_xmit:
> [...]
> spin_lock_irqsave(&mp->lock, flags);
> [...]
> /* Since hardware can't handle unaligned fragments smaller
>* than 9 bytes, if we find any, we linearize the skb
>* and
I noticed IPv6 only sets skb->priority in raw.c but not in
ip6_output.c, which seems to be a mistake.
[IPV6]: Set skb->priority in ip6_output.c
Set skb->priority = sk->sk_priority as in raw.c and IPv4.
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
---
commit 6c35e681553b3faf9c98d0b983c3e9
Marco Atzeri <[EMAIL PROTECTED]> :
[...]
> In both the two directions I noted that from 1469 and over the loss is 100%
4 bytes too soon. Sh*t.
Can you try the patch below and send the dump of a simple
for i in $(seq 1467 1473); do ping -c 1 -s $i 192.168.1.2; done
Not that it should need a lot o
This patch fixes a warning from my IPsec patches:
CC net/ipv4/ip_output.o
net/ipv4/ip_output.c: In function 'ip_finish_output':
net/ipv4/ip_output.c:208: warning: implicit declaration of function
'xfrm4_output_finish'
Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]>
diff --git a/net/
All accessor's different methods are now selected with C code and unused
ones statically optimized away at compile time instead of being selected
with #if's and #ifdef's. This has many advantages such as allowing the
compiler to validate the syntax of the whole code, making it cleaner and
easi
There's an ifdef in cs89x0.c that seems to have been the wrong way round
since it was merged (and noone seems to have noticed) -- the IXDP2x01
doesn't support ISA-style DMA, but when building for IXDP2x01, cs89x0's
ALLOW_DMA is set to 1, and when building for another platform, ALLOW_DMA
is set to 0
Jamal Hadi Salim wrote:
On Sun, 2006-08-01 at 20:34 +0100, Patrick McHardy wrote:
Looking at it again, I think you should not change the existing return
code but just use NET_XMIT_BYPASS for the TC_ACT_SHOT (TC_POLICE_SHOT)
case. Otherwise you will also return it if the packet couldn't be
class
On Sun, 2006-08-01 at 20:34 +0100, Patrick McHardy wrote:
> Jamal Hadi Salim wrote:
> > Maybe no need to worry about both situations for now, i will resubmit
> > the patch without worrying about NET_XMIT_DROP.
>
> Looking at it again, I think you should not change the existing return
> code but j
Jamal Hadi Salim wrote:
Maybe no need to worry about both situations for now, i will resubmit
the patch without worrying about NET_XMIT_DROP.
Looking at it again, I think you should not change the existing return
code but just use NET_XMIT_BYPASS for the TC_ACT_SHOT (TC_POLICE_SHOT)
case. Othe
Ok, heres a resubmit after discussion with Patrick.
cheers,
jamal
The mapping between TC_ACTION_SHOT and the qdisc return codes is better
suited to NET_XMIT_BYPASS so as not to confuse TCP
Signed-off-by: Jamal Hadi Salim <[EMAIL PROTECTED]>
---
diff --git a/net/sched/sch_cbq.c b/net/sched/sch_c
On Sun, 2006-08-01 at 20:01 +0100, Patrick McHardy wrote:
> Jamal Hadi Salim wrote:
[..]
> > I could get rid of that - but there is one dilemma:
> > There are really two reasons to ask the qdisc to drop
> > 1) policy said so
> > 2) an error happened
>
> In both cases NET_XMIT_DROP can not happen.
Jamal Hadi Salim wrote:
On Sun, 2006-08-01 at 19:35 +0100, Patrick McHardy wrote:
Jamal Hadi Salim wrote:
[..]
if (cl == NULL) {
- if (ret == NET_XMIT_DROP)
+ if (ret == NET_XMIT_DROP || ret == NET_XMIT_BYPASS)
No objections to the new mapping, but the
On Sun, 2006-08-01 at 19:35 +0100, Patrick McHardy wrote:
> Jamal Hadi Salim wrote:
[..]
> > if (cl == NULL) {
> > - if (ret == NET_XMIT_DROP)
> > + if (ret == NET_XMIT_DROP || ret == NET_XMIT_BYPASS)
>
> No objections to the new mapping, but the NET_XMIT_DROP handling
> he
On Sun, 2006-08-01 at 19:32 +0100, Patrick McHardy wrote:
> Jamal Hadi Salim wrote:
> >It seems to be a big
> > change at glance and normally i would like to run some serious tests
> > on something like this (this one you can actually test with a series of
> > mirred, pedit and gact while tcpdump i
Jamal Hadi Salim wrote:
The little discussion going on reminds me of this other patch i was
sitting on. Patrick made the last changes to this area.
Dave please apply if ACK from Patrick.
--- a/net/sched/sch_cbq.c
+++ b/net/sched/sch_cbq.c
@@ -257,7 +257,7 @@ cbq_classify(struct sk_buff *skb, str
Jamal Hadi Salim wrote:
On Sun, 2006-08-01 at 18:46 +0100, Patrick McHardy wrote:
[..]
Anyway, why do you want to keep this obvious broken behaviour?
I dont wanna keep it if it is broken Patrick;-> It seems to be a big
change at glance and normally i would like to run some serious tests
on so
The little discussion going on reminds me of this other patch i was
sitting on. Patrick made the last changes to this area.
Dave please apply if ACK from Patrick.
cheers,
jamal
The mapping between TC_ACTION_SHOT and the qdisc return codes is better
suited to NET_XMIT_BYPASS so as not to confuse
On Sun, 2006-08-01 at 18:46 +0100, Patrick McHardy wrote:
[..]
> >>int tcf_action_exec(struct sk_buff *skb, struct tc_action *act,
> >> struct tcf_result *res)
> >>{
> >>...
> >> ret = a->ops->act(&skb, a, res);
> >>
> >>The caller later continues to use
Jamal Hadi Salim wrote:
On Sun, 2006-08-01 at 18:10 +0100, Patrick McHardy wrote:
[..]
That discussion had nothing to do with this patch, you actually
already agreed to doing this. Passing double skb pointers is broken:
int tcf_action_exec(struct sk_buff *skb, struct tc_action *act,
Heres a resubmit of the IFB device. Updates from latest comments (much
much thanks Patrick).
Dave please apply this one. Any further comments that come up after this
go in as separate patches.
cheers,
jamal
A new device to do intermidiate functional block in a system shared manner.
To use the n
On Sun, 2006-08-01 at 18:10 +0100, Patrick McHardy wrote:
[..]
> That discussion had nothing to do with this patch, you actually
> already agreed to doing this. Passing double skb pointers is broken:
>
>
> int tcf_action_exec(struct sk_buff *skb, struct tc_action *act,
> stru
On Sun, Jan 08, 2006 at 01:58:24AM +0100, Francois Romieu wrote:
> Marco Atzeri <[EMAIL PROTECTED]> :
> [...]
> > everything uploaded at
> >
> > http://www.geocities.com/marco_atzeri/sis190/
>
uploaded again. The previous moved to subdirectory old_01
>
> Can you add a '-x' to the main tethereal
Jamal Hadi Salim wrote:
We've had this discussion before, Patrick;->
Heres one i was able to find:
http://marc.theaimsgroup.com/?t=11061115951&r=1&w=2
So NACK this spefic patch please.
That discussion had nothing to do with this patch, you actually
already agreed to doing this. Passing d
We've had this discussion before, Patrick;->
Heres one i was able to find:
http://marc.theaimsgroup.com/?t=11061115951&r=1&w=2
So NACK this spefic patch please.
cheers,
jamal
PS:- Please CC me on stuff like this so it doesnt get buried by my
filters for congestion control reasoning.
-
To
Hi,
My system freezes (crashes) when I run tcpdump on the interface
connected to a 3c905b card. I've tried swapping the card for an other
3c905b card but that did not help. 2 out of 3 times the last message on
the console is "Transmit error, Tx status register 82". sysreq+t doesn't
work. Not only
On Sat, Jan 07, 2006 at 03:22:43AM +0100, Francois Romieu wrote:
> The unlocking disappeared during commit
> 5793f4be23f0171b4999ca68a39a9157b44139f3.
>
> Signed-off-by: Francois Romieu <[EMAIL PROTECTED]>
>
> diff --git a/drivers/net/hamradio/mkiss.c b/drivers/net/hamradio/mkiss.c
> index 3e9ac
On Sun, Jan 08, 2006 at 12:44:15AM +0100, Patrick McHardy ([EMAIL PROTECTED])
wrote:
> [W1]: Remove incorrect MODULE_ALIAS
>
> The w1 netlink socket is created by a hardware specific driver calling
> w1_add_master_device, so there is no point in including a module alias
> for netlink autoloading
39 matches
Mail list logo
