Re: [Comment] sizeof(struct tcp_sock) is above 1024 on x86 since linux-2.6.15

2006-03-24 Thread David S. Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Tue, 21 Mar 2006 15:17:17 +0100 I would like to point out that struct tcp_sock was enlarged in 2.6.15, and the 'TCP' kmem_cache now needs order-1 allocations instead of order-0 Thanks for pointing this out Eric, I'll see what I can do to trim it down

Re: [patch 2/6] s390: qeth driver statistics fixes

2006-03-24 Thread Frank Pavlic
On Wed, 22 Mar 2006 20:30:31 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: Frank Pavlic wrote: [patch 2/6] s390: qeth driver statistics fixes From: Ursula Braun [EMAIL PROTECTED] - display unsigned int values in /proc/qeth_perf with %u instead of %i - omit qdio header length

[RESEND patch 6/6] s390: remove tty support from ctc network device driver [2/2]

2006-03-24 Thread Frank Pavlic
[patch 6/6] s390: remove tty support from ctc network device driver [2/2] From: Peter Tiedemann [EMAIL PROTECTED] [2/2]: remove ctctty.c and ctctty.h files . Signed-off-by: Frank Pavlic [EMAIL PROTECTED] diffstat: drivers/s390/net/ctctty.c | 1259

[RESEND patch 5/6] s390: remove tty support from ctc network device driver [1/2]

2006-03-24 Thread Frank Pavlic
[patch 5/6] s390: remove tty support from ctc network device driver [1/2] From: Peter Tiedemann [EMAIL PROTECTED] [1/2]: tty support code will be removed from the ctc network device driver. Today we have a couple of alternatives which are performing much better.

Re: [RFC] lmc wan driver rewrite

2006-03-24 Thread Krzysztof Halasa
David Boggs [EMAIL PROTECTED] writes: If you insist, I will run it through scripts/Lindent before submitting. I will not but others may do. Standard formatting is just better and the cost is near zero. The same two source files compile on Linux, FreeBSD, NetBSD and OpenBSD. I intend to

Re: [2.6.16-gitX] heavy performance regression in ipw2200 wireless driver

2006-03-24 Thread Alessandro Suardi
On 3/24/06, Zhu Yi [EMAIL PROTECTED] wrote: On Thu, 2006-03-23 at 15:02 +0100, Alessandro Suardi wrote: That scp test shows 50%ish - but that was a quickie. The VNC client even reported a 719Kbps throughput down from the more usual 11500Kbps it starts off with. The first scp I tried when

Re: ebt_ulog: not logging via ulog since somebody else already registered for PF_BRIDGE

2006-03-24 Thread Patrick McHardy
David S. Miller wrote: From: Andrew Morton [EMAIL PROTECTED] Date: Thu, 23 Mar 2006 21:51:24 -0800 How come? Because you can't enable ebt_ulog and ebt_log at the same time. All of the ULOG targets are obsolete, but are kept around for compatability. It's problematic when these

[PATCH 2.6.16-git7] AT91RM9200 Ethernet driver

2006-03-24 Thread Andrew Victor
This patch adds support for the Ethernet controller integrated in the Atmel AT91RM9200 SoC processor. Changes since the previous submission (01/02/2006) are: - Make use of the clk.h clock infrastructure. - The multicast hash function is not crc32. [Patch by Pedro Perez] Signed-off-by: Andrew

Re: [SOFTMAC] Reduce scan dwell time

2006-03-24 Thread David Woodhouse
On Thu, 2006-03-23 at 20:16 -0500, Dan Williams wrote: Ok, that's cool. Wasn't apparent to me from the initial message. But does that mean that softmac is doing the scanning with _probe_ requests on each channel? It's not doing passive scanning? Right. It's an active scan. -- dwmw2 - To

Re: [PATCH] ip6_tunnel: fix a soft lockup when there is no active tunnel for an encapsulated packet

2006-03-24 Thread Hugo Santos
When xfrm6_tunnel is in use you've just made it use a freed skb. Also IPv4 has the same problem so we shold fix them both. I didn't hit this since i'm not currently using xfrm6_tunnel (which is also why i got the soft lockup). I'll consider the case when xfrm6_tunnel is being used, and

[PATCH] ip6_tunnel: fix a soft lockup when there is no active tunnel for an encapsulated packet

2006-03-24 Thread Hugo Santos
Hi, This patch fixes a soft lockup in ip6_tunnel when not using xfrm6_tunnel (CONFIG_INET6_TUNNEL). It is triggered when an encapsula- ted packet reaches ip6ip6_rcv() and there is no tunnel associated with it. The error path returns a positive value (1) which will trigger ip6_input to

Re: [PATCH] [IPV4] PMTU issues due to TOS field manipulation

2006-03-24 Thread Herbert Xu
On Thu, Feb 16, 2006 at 10:04:14PM +0200, Ilia Sotnikov wrote: Here it is, against 2.6.16-rc3. OK, I've brought this patch up-to-date with 2.6.16 and got rid of a few more references to tos in ip_rt_redirect. Please note that the author of this patch is Ilia Sotnikov [EMAIL PROTECTED]. From:

Re: tg3 breakage this morning

2006-03-24 Thread walt
Michael Chan wrote: On Thu, 2006-03-23 at 14:16 -0800, walt wrote: tg3.c:v3.53 (Mar 22, 2006) PCI: Enabling device :00:09.0 (0014 - 0016) ACPI: PCI Interrupt :00:09.0[A] - GSI 18 (level, low) - IRQ 17 tg3: Could not obtain valid ethernet address, aborting. ACPI: PCI interrupt for

still regarding ip6_tunnel and xfrm6_tunnel

2006-03-24 Thread Hugo Santos
Hi, When ip6_tunnel discards a packet because there is no tunnel associated with it, it sends a ICMPV6_DEST_UNREACH error to the packet source. However, when using ip6_tunnel and xfrm6_tunnel, if there is a a tunnel spi allocated for it, it may be processed dispite ip6_tunnel having

Re: [SOFTMAC] Reduce scan dwell time

2006-03-24 Thread Johannes Berg
On Fri, 2006-03-24 at 07:58 -0500, Dan Williams wrote: Ok, so why is softmac doing an active scan, per my previous email message? Why is it not doing passive scan for normal SIOCSIWSCAN like most every other driver? (to be honest, I'm not entirely sure what ipw is doing here, but I think

Re: wireless-2.6-softmac patch: prism54usb update

2006-03-24 Thread John W. Linville
On Thu, Mar 23, 2006 at 09:05:24PM -0800, Pete Zaitcev wrote: On Thu, 23 Mar 2006 14:06:24 -0500, John W. Linville [EMAIL PROTECTED] wrote: Pete, I couldn't get this to apply. It seemed like there was a mismatch between your codebase and mine. I removed my repository and cloned your

Re: wireless-2.6-softmac patch: prism54usb update

2006-03-24 Thread John W. Linville
On Fri, Mar 24, 2006 at 08:15:24AM -0500, John W. Linville wrote: If you think it is ready, go ahead and post the master-based branches here. s/branches/patches/ -- John W. Linville [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting

2006-03-24 Thread jamal
On Thu, 2006-23-03 at 21:11 +0530, Balbir Singh wrote: On Thu, Mar 23, 2006 at 09:04:46AM -0500, jamal wrote: Should there be at least either a pid or tgid? If yes, you need to validate here... Yes, you are correct. One of my test cases caught it too.. But I did not want to untidy the

Re: [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting

2006-03-24 Thread jamal
On Fri, 2006-24-03 at 07:02 +0530, Balbir Singh wrote: On Thu, Mar 23, 2006 at 09:04:46AM -0500, jamal wrote: 3. nlmsg_new() now allocates for 2*u32 + sizeof(taskstats) Not the right size; the u32 covers the V part of TLV. The T = 16 bits and L = 16 bits. And if you nest TLVs, then it gets

Re: [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting

2006-03-24 Thread Balbir Singh
On Fri, Mar 24, 2006 at 09:04:21AM -0500, jamal wrote: On Thu, 2006-23-03 at 21:11 +0530, Balbir Singh wrote: On Thu, Mar 23, 2006 at 09:04:46AM -0500, jamal wrote: Should there be at least either a pid or tgid? If yes, you need to validate here... Yes, you are correct. One of

Re: [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting

2006-03-24 Thread Balbir Singh
On Fri, Mar 24, 2006 at 09:11:58AM -0500, jamal wrote: On Fri, 2006-24-03 at 07:02 +0530, Balbir Singh wrote: On Thu, Mar 23, 2006 at 09:04:46AM -0500, jamal wrote: 3. nlmsg_new() now allocates for 2*u32 + sizeof(taskstats) Not the right size; the u32 covers the V part of TLV. The T = 16

Re: [SOFTMAC] Reduce scan dwell time

2006-03-24 Thread Dan Williams
On Fri, 2006-03-24 at 14:08 +0100, Johannes Berg wrote: On Fri, 2006-03-24 at 07:58 -0500, Dan Williams wrote: Ok, so why is softmac doing an active scan, per my previous email message? Why is it not doing passive scan for normal SIOCSIWSCAN like most every other driver? (to be honest,

Re: tg3 breakage this morning

2006-03-24 Thread Michael Chan
Walt wrote: Nope, it was the second one: Skip phy power down... Let me know if can test any patches, etc. It doesn't make sense. This code should have no effect on your 5702. With or without this patch, the 5702 will be powered down the same with tg3_writephy(tp, MII_BMCR, BMCR_PDOWN) if WOL

via_rhine modules error on 2.6.16 with mii-tool

2006-03-24 Thread Marco Berizzi
Hello evebody. I get this error on linux vanilla 2.6.16 with via_rhine module loaded when I run mii-tool: cheduling while atomic: mii-tool/0x0001/923 [c02bfca2] schedule+0x632/0x640 [c02c0577] schedule_timeout+0x57/0xb0 [c011c100] process_timeout+0x0/0x10 [c011c378] msleep+0x28/0x30

[patch] net/ieee80211: report hidden ESSIDs as zero-length, not hidden

2006-03-24 Thread Dan Williams
hidden this is something that ieee80211 does that's completely wrong. Drivers need to report the _exact_ ESSID from the air in their scan results. It's up to the user space app to deal with ESSID length of 0. Signed-off-by: Dan Williams [EMAIL PROTECTED] --- net/ieee80211/ieee80211_wx.c

Re: about cached dst in ip6_tunnel

2006-03-24 Thread Jean-Mickael Guerin
Sorry the patch looks corrupted so I repost with attachment. Jean-Mickael -- [IPV6] ip6ip6_tnl_dst_check() : invalidate dst cache whenever xfrm policies change Signed-off-by: [EMAIL PROTECTED] diff --git a/include/net/ip6_tunnel.h b/include/net/ip6_tunnel.h index 29c9da7..5bc6e98 100644 ---

Re: [SOFTMAC] Reduce default rate to 11Mbps.

2006-03-24 Thread Jouni Malinen
On Thu, Mar 23, 2006 at 10:43:38PM +, David Woodhouse wrote: This patch makes us default to 11M, which ought to work for most people. Is this code supposed to work with IEEE 802.11a (which would also use OFDM modulation)? If yes, please note that 11 Mbps is not a valid IEEE 802.11a TX rate.

Re: [SOFTMAC] Reduce scan dwell time

2006-03-24 Thread Jouni Malinen
On Thu, Mar 23, 2006 at 08:16:04PM -0500, Dan Williams wrote: fixed it. Active scanning has been out of vogue as the default scan method for like 2 years with wireless-tools/WE, I'm not sure why softmac thinks it should be different here. Active scanning takes more power anyway, since you

Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length, nothidden

2006-03-24 Thread Jouni Malinen
On Fri, Mar 24, 2006 at 10:57:22AM -0500, Dan Williams wrote: hidden this is something that ieee80211 does that's completely wrong. Drivers need to report the _exact_ ESSID from the air in their scan results. It's up to the user space app to deal with ESSID length of 0. I agree that hidden

[PATCH] set default max TCP buffers from memory pool size

2006-03-24 Thread John Heffner
This patch sets the maximum TCP buffer sizes (available to automatic buffer tuning, not to setsockopt) based on the TCP memory pool size. The maximum sndbuf and rcvbuf each will be up to 4 MB, but no more than 1/128 of the memory pressure threshold. Signed-off-by: John Heffner [EMAIL

Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length, not hidden

2006-03-24 Thread David Woodhouse
On Fri, 2006-03-24 at 10:57 -0500, Dan Williams wrote: hidden this is something that ieee80211 does that's completely wrong. Drivers need to report the _exact_ ESSID from the air in their scan results. It's up to the user space app to deal with ESSID length of 0. That makes a lot of sense.

Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length, not hidden

2006-03-24 Thread James Ketrenos
Dan Williams wrote: hidden this is something that ieee80211 does that's completely wrong. Because it is not a part of the 802.11 specification, AP vendors have each implemented their own method for disguising the SSID. Some set the length to the actual SSID length but put fill the SSID with

[2.6 patch] PCMCIA_SPECTRUM must select FW_LOADER

2006-03-24 Thread Adrian Bunk
On Fri, Mar 24, 2006 at 09:36:09PM +0500, Alexander E. Patrakov wrote: In linux-2.6.16, it is possible to compile spectrum_cs.ko without enabling firmware loader. Result: WARNING: /lib/modules/2.6.16/kernel/drivers/net/wireless/spectrum_cs.ko needs unknown symbol request_firmware Thanks

Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length, not hidden

2006-03-24 Thread Dan Williams
On Fri, 2006-03-24 at 11:05 -0600, James Ketrenos wrote: Dan Williams wrote: hidden this is something that ieee80211 does that's completely wrong. See (untested) attached to change ieee80211 to expose the SSID as received. Patch looks good to me in principle. All I'm objecting to is the

Re: [PATCH] set default max TCP buffers from memory pool size

2006-03-24 Thread Stephen Hemminger
On Fri, 24 Mar 2006 11:47:29 -0500 John Heffner [EMAIL PROTECTED] wrote: This patch sets the maximum TCP buffer sizes (available to automatic buffer tuning, not to setsockopt) based on the TCP memory pool size. The maximum sndbuf and rcvbuf each will be up to 4 MB, but no more than 1/128 of

sky2: hangs on 2.6.16

2006-03-24 Thread michael
transfer of data hangs with sky2 very often on a :02:00.0 Ethernet controller: Marvell Technology Group Ltd. 88E8036 Fast Ethernet Controller (rev 10) found on toshiba laptops, when using 2.6.16, which proves a critical problem since the proprietary driver does not support .16 at the

Re: sky2: hangs on 2.6.16

2006-03-24 Thread Stephen Hemminger
On Fri, 24 Mar 2006 17:14:49 + michael [EMAIL PROTECTED] wrote: transfer of data hangs with sky2 very often on a :02:00.0 Ethernet controller: Marvell Technology Group Ltd. 88E8036 Fast Ethernet Controller (rev 10) found on toshiba laptops, when using 2.6.16, which proves a

Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length, not hidden

2006-03-24 Thread Jouni Malinen
On Fri, Mar 24, 2006 at 11:05:02AM -0600, James Ketrenos wrote: Since the scan results are supposed to report networks found; the first agreement we need to make between user space and the kernel is how we define a 'network', and how do we determine when a network has been updated? Whenever

Re: [SOFTMAC] Reduce scan dwell time

2006-03-24 Thread Dan Williams
On Fri, 2006-03-24 at 08:28 -0800, Jouni Malinen wrote: On Thu, Mar 23, 2006 at 08:16:04PM -0500, Dan Williams wrote: fixed it. Active scanning has been out of vogue as the default scan method for like 2 years with wireless-tools/WE, I'm not sure why softmac thinks it should be different

Re: [PATCH] set default max TCP buffers from memory pool size

2006-03-24 Thread Rick Jones
Stephen Hemminger wrote: On Fri, 24 Mar 2006 11:47:29 -0500 John Heffner [EMAIL PROTECTED] wrote: This patch sets the maximum TCP buffer sizes (available to automatic buffer tuning, not to setsockopt) based on the TCP memory pool size. The maximum sndbuf and rcvbuf each will be up to 4 MB,

Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length, not hidden

2006-03-24 Thread James Ketrenos
James Ketrenos wrote: In light of the above, I started playing with a raw packet interface on the ipw2200 and ipw3945 projects that export all frames to user space in radiotap format through a 2nd network device. I am working on changing the way the raw packet interface is configured to be

Re: [SOFTMAC] Reduce scan dwell time

2006-03-24 Thread Jouni Malinen
On Fri, Mar 24, 2006 at 12:38:40PM -0500, Dan Williams wrote: However, the problem with active scanning is that you have to power up the transmit components of the radio, while passive scanning, even though it takes a bit longer, doesn't necessarily require that. Active scanning takes more

Re: sky2: hangs on 2.6.16

2006-03-24 Thread michael
On Fri, Mar 24, 2006 at 09:38:44AM -0800, Stephen Hemminger wrote: On Fri, 24 Mar 2006 17:14:49 + michael [EMAIL PROTECTED] wrote: transfer of data hangs with sky2 very often on a :02:00.0 Ethernet controller: Marvell Technology Group Ltd. 88E8036 Fast Ethernet Controller

Re: sky2: hangs on 2.6.16

2006-03-24 Thread Stephen Hemminger
On Fri, 24 Mar 2006 18:18:57 + michael [EMAIL PROTECTED] wrote: On Fri, Mar 24, 2006 at 09:38:44AM -0800, Stephen Hemminger wrote: On Fri, 24 Mar 2006 17:14:49 + michael [EMAIL PROTECTED] wrote: transfer of data hangs with sky2 very often on a :02:00.0 Ethernet

Re: sky2: hangs on 2.6.16

2006-03-24 Thread fs
On Fri, Mar 24, 2006 at 10:40:00AM -0800, Stephen Hemminger wrote: Maybe the hang I notice is different because it stays with this patch and appears primarily after using multiple connections. An easy way to reproduce it here is this axel -n 40 http://..file (a downloader that opens

RE: [RFC] new qla3xxx NIC Driver v2.02.00b01

2006-03-24 Thread Ron Mercer
* Use existing MII code and interface Do you mean support for the get/set IOCTLS SIOCGMIIREG/SIOCSMIIREG? - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Two comments on the H.323 conntrack/NAT helper

2006-03-24 Thread Jing Min Zhao
- Original Message - From: Patrick McHardy [EMAIL PROTECTED] To: Adrian Bunk [EMAIL PROTECTED] Cc: netdev@vger.kernel.org; [EMAIL PROTECTED]; [EMAIL PROTECTED]; Jing Min Zhao [EMAIL PROTECTED]; linux-kernel@vger.kernel.org Sent: Thursday, March 23, 2006 9:02 PM Subject: Re: Two

Re: [RFC] new qla3xxx NIC Driver v2.02.00b01

2006-03-24 Thread Stephen Hemminger
On Fri, 24 Mar 2006 10:58:44 -0800 Ron Mercer [EMAIL PROTECTED] wrote: * Use existing MII code and interface Do you mean support for the get/set IOCTLS SIOCGMIIREG/SIOCSMIIREG? If you can look at using mii.c and include/linux/mii.h. Not all drivers can, and the interface is poorly

Re: sky2: hangs on 2.6.16

2006-03-24 Thread Stephen Hemminger
On Fri, 24 Mar 2006 18:48:37 + fs [EMAIL PROTECTED] wrote: On Fri, Mar 24, 2006 at 10:40:00AM -0800, Stephen Hemminger wrote: Maybe the hang I notice is different because it stays with this patch and appears primarily after using multiple connections. An easy way to reproduce it

Re: sky2: hangs on 2.6.16

2006-03-24 Thread fs
On Fri, Mar 24, 2006 at 11:24:35AM -0800, Stephen Hemminger wrote: On Fri, 24 Mar 2006 18:48:37 + fs [EMAIL PROTECTED] wrote: On Fri, Mar 24, 2006 at 10:40:00AM -0800, Stephen Hemminger wrote: Maybe the hang I notice is different because it stays with this patch and appears

Re: Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length, not

2006-03-24 Thread Jean Tourrilhes
Jouni Malinen wrote : On Fri, Mar 24, 2006 at 10:57:22AM -0500, Dan Williams wrote: hidden this is something that ieee80211 does that's completely wrong. Drivers need to report the _exact_ ESSID from the air in their scan results. It's up to the user space app to deal with ESSID length

Re: Re: [SOFTMAC] Reduce scan dwell time

2006-03-24 Thread Jean Tourrilhes
Jouni Malinen wrote : On Thu, Mar 23, 2006 at 08:16:04PM -0500, Dan Williams wrote: That's why wireless-tools and Wireless Extensions switched to passive scanning. Can you please point to some documentation/email thread/etc. describing this preference to use passive scanning? I was not

Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length, not

2006-03-24 Thread Jouni Malinen
On Fri, Mar 24, 2006 at 11:41:14AM -0800, Jean Tourrilhes wrote: I've seen time where people said SSID when referring to the BSSID, so I just wanted the terminology to be without ambiguity. Well.. It is just somewhat funny to see ESSID being used in Linux wireless discussion when most

Re: wireless-2.6-softmac patch: prism54usb update

2006-03-24 Thread Pete Zaitcev
On Fri, 24 Mar 2006 08:15:24 -0500, John W. Linville [EMAIL PROTECTED] wrote: Yes, sorry. I renamed the softmac branch as devel -- it has the stuff that was on the softmac branch, other than softmac component itself. Aww dang, I already sent it to you diffed against master. With softmac

Re: Re: [SOFTMAC] Reduce scan dwell time

2006-03-24 Thread Jean Tourrilhes
On Fri, Mar 24, 2006 at 03:38:50PM -0500, Dan Williams wrote: On Fri, 2006-03-24 at 12:12 -0800, Jean Tourrilhes wrote: Jouni Malinen wrote : On Thu, Mar 23, 2006 at 08:16:04PM -0500, Dan Williams wrote: That's why wireless-tools and Wireless Extensions switched to passive

Re: [PATCH] ip6_tunnel: fix a soft lockup when there is no active tunnel for an encapsulated packet

2006-03-24 Thread Herbert Xu
Hugo Santos [EMAIL PROTECTED] wrote: This patch fixes a soft lockup in ip6_tunnel when not using xfrm6_tunnel (CONFIG_INET6_TUNNEL). It is triggered when an encapsula- ted packet reaches ip6ip6_rcv() and there is no tunnel associated with it. The error path returns a positive value (1)

Re: tg3 breakage this morning

2006-03-24 Thread walt
Michael Chan wrote: Walt wrote: Nope, it was the second one: Skip phy power down... It doesn't make sense. This code should have no effect on your 5702. With or without this patch, the 5702 will be powered down the same with tg3_writephy(tp, MII_BMCR, BMCR_PDOWN) if WOL is not enabled

[PATCH] PCI Error Recovery: e1000 network device driver

2006-03-24 Thread Linas Vepstas
Jeff, Can you please review and forward this patch upstream? A previous version of this patch has been ack'ed by Jesse Brandeburg, one of the e1000 maintainers. --linas [PATCH] PCI Error Recovery: e1000 network device driver Various PCI bus errors can be signaled by newer PCI controllers.

Re: sky2: hangs on 2.6.16

2006-03-24 Thread Michael Menegakis
On Fri, Mar 24, 2006 at 07:29:33PM +, fs wrote: On Fri, Mar 24, 2006 at 11:24:35AM -0800, Stephen Hemminger wrote: On Fri, 24 Mar 2006 18:48:37 + fs [EMAIL PROTECTED] wrote: On Fri, Mar 24, 2006 at 10:40:00AM -0800, Stephen Hemminger wrote: Maybe the hang I notice is

Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length,not hidden

2006-03-24 Thread Jouni Malinen
On Fri, Mar 24, 2006 at 09:31:56PM +, David Woodhouse wrote: wpa_supplicant appears to be aware of none of this -- it expects the SSID to be precisely correct in the scan results after it does an active probe for a specific SSID. Thus, it doesn't work when SSID broadcasting is turned off

Re: [SOFTMAC] Reduce scan dwell time

2006-03-24 Thread Johannes Berg
On Fri, 2006-03-24 at 09:48 -0800, Jouni Malinen wrote: Is battery use more important than accuracy of results and the amount of time needed to perform the operation? You're going to be using *more* battery when doing a passive scan because the dwell time is much much larger, and you can't

Re: sky2: hangs on 2.6.16

2006-03-24 Thread Stephen Hemminger
On Fri, 24 Mar 2006 22:13:54 + Michael Menegakis [EMAIL PROTECTED] wrote: were they any helpfull? The first thing to look for is are packets showing up (and being transmitted) by doing ethtool -S eth0 Since in this driver stats come out of the PHY, it is possible for the PHY to be

Re: wireless-2.6-softmac patch: prism54usb update

2006-03-24 Thread John W. Linville
On Fri, Mar 24, 2006 at 01:13:12PM -0800, Pete Zaitcev wrote: Would you just keep it on master without pushing to Linus? They way you manipulate branches of wireless-2.6 is bewildering for me, and softmac I'm trying to get away from excessive branching. It gets to be a big PITA, and it

rtnetlink compile failure.

2006-03-24 Thread Dave Jones
I accidentally ended up with a config that set NET_RADIO off, and NET_WIRELESS_RTNETLINK on, which blew up thus.. net/built-in.o: In function `do_setlink':net/core/rtnetlink.c:479: undefined reference to `wireless_rtnetlink_set' net/built-in.o: In function `do_getlink':net/core/rtnetlink.c:521:

Re: tg3 breakage this morning

2006-03-24 Thread Bill Fink
On Fri, 24 Mar 2006, walt wrote: Michael Chan wrote: Walt wrote: Nope, it was the second one: Skip phy power down... It doesn't make sense. This code should have no effect on your 5702. With or without this patch, the 5702 will be powered down the same with tg3_writephy(tp,

Re: tg3 breakage this morning

2006-03-24 Thread Michael Chan
On Fri, 2006-03-24 at 14:06 -0800, walt wrote: I confess I'm a bit confused by your question. I have no idea why an ifdown would be executed during boot, but the startup scripts are so complicated that I can't understand what they do. The best thing to do is probably to disable all the

Re: rtnetlink compile failure.

2006-03-24 Thread David S. Miller
From: Dave Jones [EMAIL PROTECTED] Date: Fri, 24 Mar 2006 18:04:28 -0500 I accidentally ended up with a config that set NET_RADIO off, and NET_WIRELESS_RTNETLINK on, which blew up thus.. net/built-in.o: In function `do_setlink':net/core/rtnetlink.c:479: undefined reference to

Re: rtnetlink compile failure.

2006-03-24 Thread Jean Tourrilhes
Dave Jones wrote : I accidentally ended up with a config that set NET_RADIO off, and NET_WIRELESS_RTNETLINK on, which blew up thus.. Good catch ! Actually, in 2.6.17, NET_RADIO and WIRELESS_EXT were separated. So, I would suggest the following instead :

Re: [PATCH] ip6_tunnel: fix a soft lockup when there is no active tunnel for an encapsulated packet

2006-03-24 Thread Hugo Santos
OK this is a bit ugly but will do for now. Could you please do it for the ICMP packet and IPv4 as well? I find it ugly that the same function, in this case ip6ip6_rcv(), is used in two contexts where the expected behaviour differs. Also, using the current #ifdefs, ip6_tunnel is only

Re: [patch] net/ieee80211: report hidden ESSIDs as zero-length,not hidden

2006-03-24 Thread David Woodhouse
On Fri, 2006-03-24 at 14:14 -0800, Jouni Malinen wrote: wpa_supplicant does indeed require that the scan results are reported correctly. I don't see much point in the results if they are not correct.. It is unfortunate if you need to use this kind of patch since it would not work very well in

Re: [PATCH] ip6_tunnel: fix a soft lockup when there is no active tunnel for an encapsulated packet

2006-03-24 Thread David S. Miller
From: Hugo Santos [EMAIL PROTECTED] Date: Sat, 25 Mar 2006 00:18:04 + I find it ugly that the same function, in this case ip6ip6_rcv(), is used in two contexts where the expected behaviour differs. It would have been even worse, IMHO, to have two copies of nearly identical code sitting

Re: [PATCH] ip6_tunnel: fix a soft lockup when there is no active tunnel for an encapsulated packet

2006-03-24 Thread Herbert Xu
On Fri, Mar 24, 2006 at 04:31:15PM -0800, David S. Miller wrote: It would have been even worse, IMHO, to have two copies of nearly identical code sitting around which is basically what the alternative is. Actually, it might be cleaner to have wrappers around a common (possibly inline as

Re: [PATCH] ip6_tunnel: fix a soft lockup when there is no active tunnel for an encapsulated packet

2006-03-24 Thread David S. Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Sat, 25 Mar 2006 11:36:36 +1100 On Fri, Mar 24, 2006 at 04:31:15PM -0800, David S. Miller wrote: It would have been even worse, IMHO, to have two copies of nearly identical code sitting around which is basically what the alternative is.

Re: [PATCH] ip6_tunnel: fix a soft lockup when there is no active tunnel for an encapsulated packet

2006-03-24 Thread Hugo Santos
It would have been even worse, IMHO, to have two copies of nearly identical code sitting around which is basically what the alternative is. We don't need two copies. We just need a function that does the real work if there is a tunnel to be used (what xfrm6_tunnel needs), and another one

[PATCH 2.6.16] zd1201 wireless stat update

2006-03-24 Thread Jean Tourrilhes
Hi all, The dev-get_wireless_stats field is deprecated and slowly be surely going away. Most drivers have been updated months ago. Actually, there is an annoying message for driver still using it, but it seems that user of zd1201 were not annoyed enough ;-) Patch was

Re: [SOFTMAC] Reduce default rate to 11Mbps.

2006-03-24 Thread David Woodhouse
On Fri, 2006-03-24 at 08:18 -0800, Jouni Malinen wrote: On Thu, Mar 23, 2006 at 10:43:38PM +, David Woodhouse wrote: This patch makes us default to 11M, which ought to work for most people. Is this code supposed to work with IEEE 802.11a (which would also use OFDM modulation)? If yes,

2.6.16: assertion (!sk-sk_forward_alloc) failed

2006-03-24 Thread Phil Oester
Upgraded a number of heavily used squid boxes to 2.6.16 from 2.6.13 this week, and noticed these errors in the logs: KERNEL: assertion (!sk-sk_forward_alloc) failed at net/core/stream.c (279) KERNEL: assertion (!sk-sk_forward_alloc) failed at net/ipv4/af_inet.c (148) but then looked through the

Re: 2.6.16: assertion (!sk-sk_forward_alloc) failed

2006-03-24 Thread David S. Miller
From: Phil Oester [EMAIL PROTECTED] Date: Fri, 24 Mar 2006 17:03:35 -0800 Upgraded a number of heavily used squid boxes to 2.6.16 from 2.6.13 this week, and noticed these errors in the logs: KERNEL: assertion (!sk-sk_forward_alloc) failed at net/core/stream.c (279) KERNEL: assertion

Re: rtnetlink compile failure.

2006-03-24 Thread David S. Miller
From: Jean Tourrilhes [EMAIL PROTECTED] Date: Fri, 24 Mar 2006 15:47:51 -0800 Actually, in 2.6.17, NET_RADIO and WIRELESS_EXT were separated. So, I would suggest the following instead : - config NET_WIRELESS_RTNETLINK bool Wireless

Re: [PATCH] PCI Error Recovery: e1000 network device driver

2006-03-24 Thread Greg KH
On Fri, Mar 24, 2006 at 04:00:02PM -0600, Linas Vepstas wrote: + /* Perform card reset only on one instance of the card */ + if(0 != PCI_FUNC (pdev-devfn)) + return PCI_ERS_RESULT_RECOVERED; You seem to have forgotton to put a ' ' after the 'if' in a number of different

Re: [PATCH] PCI Error Recovery: e1000 network device driver

2006-03-24 Thread Linas Vepstas
On Fri, Mar 24, 2006 at 06:22:06PM -0800, Greg KH wrote: ... a bit different from the traditional kernel coding style. Sorry, this is due to inattention on my part; I get cross-eyed after staring at the same code for too long. The patch below should fix things. --linas [PATCH] PCI Error

nf_conntrack_l3proto_ipv6.c Kconfig confusion

2006-03-24 Thread Andrew Morton
x86 allmodconfig: bix:/usr/src/25 make net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.o CC net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.o net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c: In function `ipv6_conntrack_in': net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c:254: error: structure has

[NET]: Take RTNL when unregistering notifier

2006-03-24 Thread Herbert Xu
Hi Dave: The netdev notifier call chain is currently unregistered without taking any locks outside the notifier system. Because the notifier system itself does not synchronise unregistration with respect to the calling of the chain, we as its user need to do our own locking. We are supposed to

[PATCH 0/2] Host AP driver update

2006-03-24 Thread Jouni Malinen
Please apply following two patches to Host AP driver in wireless-2.6. The second patch (Fix EAPOL frame encryption) is a trivial bug fix for a somewhat unfortunate bug and it could be a good candidate for a 2.6.16.x stable release ([EMAIL PROTECTED] cc'ed). -- Jouni Malinen

[PATCH 2/2] hostap: Fix EAPOL frame encryption

2006-03-24 Thread Jouni Malinen
Fixed encrypted of EAPOL frames from wlan#ap interface (hostapd). This was broken when moving to use new frame control field defines in net/ieee80211.h. hostapd uses Protected flag, not protocol version (which was cleared in this function anyway). This fixes WPA group key handshake and

[PATCH 1/2] hostap: Make hostap_tx_encrypt() static

2006-03-24 Thread Jouni Malinen
hostap_tx_encrypt() is used only inside hostap_80211_tx.c and there are no plans to use it elsewhere in the future either, so let's make it static. As a bonus, this should silence Coverity scanner from complaining about bogus FORWARD_NULL case (CID: 274). Signed-off-by: Jouni Malinen [EMAIL

Re: Stretch ACKs, etc. (was TSO and IPoIB performance degradation)

2006-03-24 Thread Mark Butler
Wouldn't the appropriate place to add the tunable for Stretch ACKs be as a route attribute similar to RTAX_ADVMSS? Then system administrators who are aware of the local network topology, netfilters, etc, could use an ip route or whatever command to enable it on the route entry for the

[SCTP]: Fix up sctp_rcv return value

2006-03-24 Thread Herbert Xu
Hi Dave: I was working on the ipip/xfrm problem and as usual I get side-tracked by other problems. As part of an attempt to change the IPv4 protocol handler calling convention I found that SCTP violated the existing convention. It's returning non-zero values after freeing the skb. This is