Re: [PATCH 20/20] iscsi: support for swapping over iSCSI.

2006-09-13 Thread Peter Zijlstra
On Wed, 2006-09-13 at 15:50 -0500, Mike Christie wrote: > Peter Zijlstra wrote: > > Implement sht->swapdev() for iSCSI. This method takes care of reserving > > the extra memory needed and marking all relevant sockets with SOCK_VMIO. > > > > When used for swapping, TCP socket creation is done under

Re: ipip and ip_gre encapsulation bugs

2006-09-13 Thread David Miller
From: Al Viro <[EMAIL PROTECTED]> Date: Thu, 14 Sep 2006 02:16:37 +0100 > OK, after rereading the RFC... Pointer field is one octet, indeed. > Avoiding all swapping will be tough - icmp_send() takes 32bit argument, > net-endian. Thanks for the fix Al, but did you notice that this code is totally

Re: netdevice name corruption is still present in 2.6.18-rc6-mm1

2006-09-13 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Sun, 10 Sep 2006 11:40:11 +0200 > Dave, please apply the attached patch to net-2.6.19, it fixes the > netdevice name corruption reported by multiple people. Applied, thanks a lot. - To unsubscribe from this list: send the line "unsubscribe netdev" i

Re: [PATCH]:[XFRM] BEET mode

2006-09-13 Thread Randy.Dunlap
On Wed, 13 Sep 2006 19:26:19 +0300 Diego Beltrami wrote: Looks like IMP (? or something else along the way?) split a long line into 2 lines for you (same thing in 2 places). See below. > diff --git a/net/ipv4/xfrm4_mode_beet.c b/net/ipv4/xfrm4_mode_beet.c > new file mode 100644 > index 000.

[PATCH] Mark frame diverter for future removal.

2006-09-13 Thread Stephen Hemminger
The code for frame diverter is unmaintained and has bitrotted. The number of users is very small and the code has lots of problems. If anyone is using it, they maybe exposing themselves to bad packet attacks. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- Documentation/feature-removal

[PATCH 3/4] IP100A: Correct initial and close hardware step. 2006-08-24

2006-09-13 Thread Jesse Huang
From: Jesse Huang <[EMAIL PROTECTED]> Change Logs: - Correct initial and close hardware step. Signed-off-by: Jesse Huang <[EMAIL PROTECTED]> --- drivers/net/sundance.c |8 1 files changed, 8 insertions(+), 0 deletions(-) 419599b10f1253ccd7224bbd369924307e1e5bb6 diff --git a/dr

[PATCH 4/4] IP100A: Solve host error problem in low performance embedded system when continune down and up. 2006-08-24

2006-09-13 Thread Jesse Huang
From: Jesse Huang <[EMAIL PROTECTED]> Change Logs: - Solve host error problem in low performance embedded system when continune down and up. Signed-off-by: Jesse Huang <[EMAIL PROTECTED]> --- drivers/net/sundance.c | 28 1 files changed, 24 insertions(+)

[PATCH 1/4] IP100A: Fix TX Pause bug (reset_tx, intr_handler) 2006-08-24

2006-09-13 Thread Jesse Huang
From: Jesse Huang <[EMAIL PROTECTED]> Change Logs: - Fix TX Pause bug (reset_tx, intr_handler) Signed-off-by: Jesse Huang <[EMAIL PROTECTED]> --- drivers/net/sundance.c | 53 +++- 1 files changed, 30 insertions(+), 23 deletions(-) fb301c4464188

Re: [patch 3/3] Add tsi108 On Chip Ethernet device driver support

2006-09-13 Thread Zang Roy-r61911
On Tue, 2006-09-12 at 22:43, Jeff Garzik wrote: > Roland Dreier wrote: > > > +struct tsi108_prv_data { > > > + volatile u32 regs; /* Base of normal regs */ > > > + volatile u32 phyregs; /* Base of register bank used for PHY > access */ > > > > Why volatile? This looks really wrong her

Re: What is current sundance.c status?

2006-09-13 Thread Jesse Huang
OK! I will resend my patchset. Thanks! Jesse - Original Message - From: "Jeff Garzik" <[EMAIL PROTECTED]> To: "Jesse Huang" <[EMAIL PROTECTED]> Cc: ; ; <[EMAIL PROTECTED]> Sent: Wednesday, September 13, 2006 12:05 AM Subject: Re: What is current sundance.c status? Jesse Huang wrote: >

Re: netdev tx timeouts

2006-09-13 Thread Larry Finger
Stephen Hemminger wrote: On Wed, 13 Sep 2006 21:04:02 -0500 Larry Finger <[EMAIL PROTECTED]> wrote: Stephen Hemminger wrote: On Wed, 13 Sep 2006 15:49:23 +0200 Michael Buesch <[EMAIL PROTECTED]> wrote: Simple. Reading the code of synchronize_net() and netif_stop_queue() and thinking about why

Re: netdev tx timeouts

2006-09-13 Thread Stephen Hemminger
On Wed, 13 Sep 2006 21:04:02 -0500 Larry Finger <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > On Wed, 13 Sep 2006 15:49:23 +0200 > > Michael Buesch <[EMAIL PROTECTED]> wrote: > >> Simple. Reading the code of synchronize_net() and > >> netif_stop_queue() and thinking about why it breaks

Re: netdev tx timeouts

2006-09-13 Thread Larry Finger
Stephen Hemminger wrote: On Wed, 13 Sep 2006 15:49:23 +0200 Michael Buesch <[EMAIL PROTECTED]> wrote: Simple. Reading the code of synchronize_net() and netif_stop_queue() and thinking about why it breaks, instead of committing bugfixes that only substitute one bug by another. ;) I'll take a look

Re: [PATCH 1/2] ethtool: allow const ethtool_ops

2006-09-13 Thread Stephen Hemminger
On Wed, 13 Sep 2006 13:45:42 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > applied, then I fixed up all the drivers > > Otherwise, it was a half-complete job that would take years to get > cleaned up. > > Thanks, I did the same effective patch last night but doing a "make allmodconfig" buil

Re: examples to model ethernet driver off of?

2006-09-13 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 14 Sep 2006 10:26:10 +0900 > sorry to pick on e1000, but the code is too verbose and > split over too many files. The e100 code is much cleaner. I totally agree, I would never use e1000 as a model driver for someone writing some new code. -

Re: [PATCH] EtherIP tunnel driver (RFC 3378)

2006-09-13 Thread Stephen Hemminger
On Thu, 14 Sep 2006 11:21:22 +1000 Philip Craig <[EMAIL PROTECTED]> wrote: > Joerg Roedel wrote: > > +To configure tunnels an extra tool is required. You can download > > +it from http://zlug.fh-zwickau.de/~joro/projects/ under the > > +EtherIP section. If unsure, say N. > > To obtain

Re: examples to model ethernet driver off of?

2006-09-13 Thread Stephen Hemminger
On Wed, 13 Sep 2006 13:11:07 -0700 Auke Kok <[EMAIL PROTECTED]> wrote: > Francois Romieu wrote: > > Kumar Gala <[EMAIL PROTECTED]> : > >> What are good examples of simple/basic ethernet drivers one should > >> use to model a new driver off of? > > > > tg3/bnx2/sky2/b44/8139cp > > Can I add e10

Re: TCP Pacing

2006-09-13 Thread Stephen Hemminger
On Wed, 13 Sep 2006 10:18:31 +0200 Daniele Lacamera <[EMAIL PROTECTED]> wrote: > On Wednesday 13 September 2006 05:41, Stephen Hemminger wrote: > > Pacing in itself isn't a bad idea, but: > > > * Since it is most useful over long delay links, maybe it should be a > route parameter. > Look into

Re: netdev tx timeouts

2006-09-13 Thread Stephen Hemminger
On Wed, 13 Sep 2006 15:49:23 +0200 Michael Buesch <[EMAIL PROTECTED]> wrote: > On Wednesday 13 September 2006 15:25, Larry Finger wrote: > > Michael Buesch wrote: > > > On Wednesday 13 September 2006 04:25, Larry Finger wrote: > > >> Michael, > > >> > > >> I still have not gotten a network guru to

Re: [PATCH] EtherIP tunnel driver (RFC 3378)

2006-09-13 Thread Philip Craig
Joerg Roedel wrote: > + To configure tunnels an extra tool is required. You can download > + it from http://zlug.fh-zwickau.de/~joro/projects/ under the > + EtherIP section. If unsure, say N. To obtain a list of tunnels, this tool calls SIOCGETTUNNEL (SIOCDEVPRIVATE + 0) for every d

Re: ipip and ip_gre encapsulation bugs

2006-09-13 Thread Al Viro
On Thu, Sep 14, 2006 at 10:23:42AM +1000, Herbert Xu wrote: > > - if (skb->h.icmph->un.gateway < (iph->ihl<<2)) > > + n = ntohl(skb->h.icmph->un.gateway); > > + if (n < (iph->ihl<<2)) > >return; > > I don't think this is right. The

Re: NIC interrupt assignments under UltraSPARC-T1

2006-09-13 Thread David Miller
From: Rick Jones <[EMAIL PROTECTED]> Date: Wed, 13 Sep 2006 17:47:27 -0700 > Is it indeed not possible to alter the interrupt assignments or have I > (as I'm wont to do) missed something quasi-obvious? It should work, perhaps there is a bug somewhere. I think it's a bad idea, btw, to asking spa

Re: [PATCH] make ipv4 multicast packets only get delivered to sockets that are joined to group

2006-09-13 Thread David Miller
From: Jeff Layton <[EMAIL PROTECTED]> Date: Wed, 13 Sep 2006 12:12:23 -0400 > Most of the RFC's I've looked at don't seem to have much to say about > how multicasting works at the socket level. Is there an RFC or > specification that spells this out, or is this one of those situations > where thin

Re: 802.1D/Linux STP issue

2006-09-13 Thread Stephen Hemminger
On Wed, 13 Sep 2006 15:58:49 -0700 Brian Braunstein <[EMAIL PROTECTED]> wrote: > hi stephen and tony, > > i have been in contact with both of you and i figured it would make > sense to get you to in contact on this issue, so here's the story: > > stephen is the maintainer of the linux spanning

NIC interrupt assignments under UltraSPARC-T1

2006-09-13 Thread Rick Jones
From time to time I "play" with netperf on different systems. I happen to have occasion to play with a T2000. Under Solaris 10 I am able to coerce the interrupts of the different core GbEs to be on different cores rather than strands of the same core. Under a 2.6.15 kernel (Ubuntu Dapper) it

Re: ipip and ip_gre encapsulation bugs

2006-09-13 Thread Herbert Xu
Al Viro <[EMAIL PROTECTED]> wrote: > Handling of ipip and ip_gre ICMP error relaying is b0rken; it accesses > 32bit net-endian field as host-endian, does comparison, subtraction and > stuffs the result to 32bit net-endian. Without any conversions. Thanks for spotting this. > @@ -422,14 +423,16 @

Re: ieee80211 and devices which decrypt in hardware

2006-09-13 Thread Daniel Drake
Daniel Drake wrote: adding IEEE802.11 header parsing code to zd1211rw rx path (currently there is none, which is nice) Oops, that's obviously a lie. Anyway, I still think it's easier/better to do in the stack, would you agree? That just leaves questions about whether it should be a new flag,

Re: ieee80211 and devices which decrypt in hardware

2006-09-13 Thread Daniel Drake
Michael Buesch wrote: Does it strip ICV and FCS? The driver always strips FCS (unconditionally). The device does not strip ICV even when hardware decryption is in use, it gets included at the end of the frame, and I guess we should also handle that. in bcm43xx-softmac we use memmove to mo

Re: examples to model ethernet driver off of?

2006-09-13 Thread Francois Romieu
Kumar Gala <[EMAIL PROTECTED]> : [...] > What is the feeling about e100.c? > > I'm looking for something that is just basic tx/rx with no real fancy > features. - a bit too much of 'if(' (missing space) and 'if (evil_statement' - some 'return' which are not on a line of their own - a few local

[d80211] some issues regarding iwconfig parameters sequence

2006-09-13 Thread mabbas
Hi I have some problem connecting if I don't follow some parameters sequence in iwconfig command for example if I issues the following # iwconfig wlan0 essid test ap xx:xx:xx:xx:xx:xx #iwconfif wlan0 channel 9 in d80211 if essid and bssid set it will start authentication with default channel

Re: examples to model ethernet driver off of?

2006-09-13 Thread Auke Kok
Kumar Gala wrote: On Sep 13, 2006, at 3:11 PM, Auke Kok wrote: Francois Romieu wrote: Kumar Gala <[EMAIL PROTECTED]> : What are good examples of simple/basic ethernet drivers one should use to model a new driver off of? tg3/bnx2/sky2/b44/8139cp Can I add e1000/ixgb to that? ;) What is

Re: examples to model ethernet driver off of?

2006-09-13 Thread Francois Romieu
Auke Kok <[EMAIL PROTECTED]> : [...] > >tg3/bnx2/sky2/b44/8139cp > > Can I add e1000/ixgb to that? ;) Assume I have not noticed the smiley... - $ grep int32 drivers/net/e1000/* - $ grep ' if(' drivers/net/e1000/* - tabs and spaces damage - forward declarations (are not a substitute for documenta

Re: [PATCH 20/20] iscsi: support for swapping over iSCSI.

2006-09-13 Thread Mike Christie
Peter Zijlstra wrote: > Implement sht->swapdev() for iSCSI. This method takes care of reserving > the extra memory needed and marking all relevant sockets with SOCK_VMIO. > > When used for swapping, TCP socket creation is done under GFP_MEMALLOC and > the TCP connect is done with SOCK_VMIO to ensu

Re: [PATCH] make ipv4 multicast packets only get delivered to sockets that are joined to group

2006-09-13 Thread David Stevens
Alexey Kuznetsov <[EMAIL PROTECTED]> wrote on 09/13/2006 01:20:29 PM: > Hello! > > > IPv6 behaves the same way. > > Actually, Linux IPv6 filters received multicasts, inet6_mc_check() does > this. No, it returns 1 (allow) if there are no filters to explicitly filter it. I wrote that code

Re: examples to model ethernet driver off of?

2006-09-13 Thread Kumar Gala
On Sep 13, 2006, at 3:11 PM, Auke Kok wrote: Francois Romieu wrote: Kumar Gala <[EMAIL PROTECTED]> : What are good examples of simple/basic ethernet drivers one should use to model a new driver off of? tg3/bnx2/sky2/b44/8139cp Can I add e1000/ixgb to that? ;) What is the feeling about

Re: [PATCH] make ipv4 multicast packets only get delivered to sockets that are joined to group

2006-09-13 Thread Alexey Kuznetsov
Hello! > IPv6 behaves the same way. Actually, Linux IPv6 filters received multicasts, inet6_mc_check() does this. IPv4 does not. I remember that attempts to do this were made in the past and failed, because some applications, related to multicast routing, did expect to receive all the multicasts

Re: examples to model ethernet driver off of?

2006-09-13 Thread Auke Kok
Francois Romieu wrote: Kumar Gala <[EMAIL PROTECTED]> : What are good examples of simple/basic ethernet drivers one should use to model a new driver off of? tg3/bnx2/sky2/b44/8139cp Can I add e1000/ixgb to that? ;) Cheers, Auke - To unsubscribe from this list: send the line "unsubscribe n

Re: examples to model ethernet driver off of?

2006-09-13 Thread Francois Romieu
Kumar Gala <[EMAIL PROTECTED]> : > What are good examples of simple/basic ethernet drivers one should > use to model a new driver off of? tg3/bnx2/sky2/b44/8139cp Shake, average, procrastinate. It depends on what the hardware can do though. -- Ueimor - To unsubscribe from this list: send the

examples to model ethernet driver off of?

2006-09-13 Thread Kumar Gala
What are good examples of simple/basic ethernet drivers one should use to model a new driver off of? thanks - kumar - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.ht

Re: [PATCH 2/12] smc911x: Fix SMC_WRITE_EEPROM_CMD macro

2006-09-13 Thread Francois Romieu
[EMAIL PROTECTED] <[EMAIL PROTECTED]> : [...] > #define SMC_WRITE_EEPROM_CMD(cmd, addr) > \ > do {\ > - while (SMC_GET_E2P_CMD() & MAC_CSR_CMD_CSR_BUSY_); \ > - SMC_

Re: [PATCH 12/12] smc911x: afc_cfg calculation is wrong at case 5

2006-09-13 Thread Francois Romieu
[EMAIL PROTECTED] <[EMAIL PROTECTED]> : [...] > BACKDUR calculation is wrong at case 5. Also some cosmetic around > smc911x_probe... If you are in a mood for cosmetic, feel free to turn some unsigned long ioaddr into something more void __iomem *ioaddr and store it in the private part of the devi

Re: [PATCH 10/12] smc911x: phy_configure releases spinlocks before grabing

2006-09-13 Thread Francois Romieu
[EMAIL PROTECTED] <[EMAIL PROTECTED]> : [...] > @@ -1040,6 +1037,7 @@ > > smc911x_phy_configure_exit: > spin_unlock_irqrestore(&lp->lock, flags); The change is fine but I'd rename this one as ${some_random_string_}out_unlock as well. -- Ueimor - To unsubscribe from this list: send the l

Re: [PATCH 8/12] smc911x: Fix external phy detect routine

2006-09-13 Thread Francois Romieu
[EMAIL PROTECTED] <[EMAIL PROTECTED]> : > > > 9115-an1212.pdf, page 23 -> http://www.smsc.com/main/anpdf/an1212.pdf > > "The existence of external PHYs is determined by reading > the same two PHY registers at PHY addresses 0x02 through 0x30. If values of [...] > - f

Re: [PATCH 11/12] smc911x: Undocumented interrupt now reserved

2006-09-13 Thread Francois Romieu
[EMAIL PROTECTED] <[EMAIL PROTECTED]> : [...] > @@ -1127,7 +1125,7 @@ > lp->stats.rx_dropped+=SMC_GET_RX_DROP(); >} > /* Undocumented interrupt-what is the right thing to do here? */ > - if (status & INT_STS_RXDF_INT_) { > +

Re: [PATCH 4/12] smc911x: PRINT_PKT doesnt count on odd remainder

2006-09-13 Thread Francois Romieu
[EMAIL PROTECTED] <[EMAIL PROTECTED]> : [...] > @@ -202,6 +202,7 @@ > b = *buf++; > printk("%02x%02x ", a, b); > } > + if (remainder & 1) printk("%02x", *buf); printk should be on the next line. -- Ueimor - To unsubscribe from this list: send the line "unsub

Re: [PATCH 6/12] smc911x: Unneeded spinlocks around smc911x_enable

2006-09-13 Thread Francois Romieu
[EMAIL PROTECTED] <[EMAIL PROTECTED]> : [...] > is unneeded... [...] > - spin_lock_irqsave(&lp->lock, flags); The variable "flags" is not used any more. -- Ueimor - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: 2.6.18-rc6 memory mapped pcap truncates outgoing TCP packets, but not icmp

2006-09-13 Thread Patrick McHardy
bert hubert wrote: > Hi people, > > I like to use memory mapped pcap (PACKET_MMAP) since off the shelf, linux is > a tad prone to drop packets while capturing these days. It used to be lots > better at it, but right now memory mapped pcap is the only way to get things > working a bit. I've noticed

[PATCH 2/12] smc911x: Fix SMC_WRITE_EEPROM_CMD macro

2006-09-13 Thread bora . sahin
SMC_WRITE_EEPROM_CMD macro is wrong Signed-off-by: Bora Sahin <[EMAIL PROTECTED]> Index: linux-2.6.18-rc4/drivers/net/smc911x.h === --- linux-2.6.18-rc4.orig/drivers/net/smc911x.h 2006-08-06 21:20:11.0 +0300 +++ linux-2.6.1

[PATCH 4/12] smc911x: PRINT_PKT doesnt count on odd remainder

2006-09-13 Thread bora . sahin
PRINT_PKT doesnt count on odd remainder... Signed-off-by: Bora Sahin <[EMAIL PROTECTED]> Index: linux-2.6.18-rc4/drivers/net/smc911x.c === --- linux-2.6.18-rc4.orig/drivers/net/smc911x.c 2006-08-06 21:20:11.0 +0300 +++ linu

[PATCH 5/12] smc911x: SMC_SET_IRQ_CFG is arch specific

2006-09-13 Thread bora . sahin
SMC_SET_IRQ_CFG macro is PXA specific... Signed-off-by: Bora Sahin <[EMAIL PROTECTED]> Index: linux-2.6.18-rc4/drivers/net/smc911x.c === --- linux-2.6.18-rc4.orig/drivers/net/smc911x.c 2006-08-06 21:20:11.0 +0300 +++ linux-

[PATCH 12/12] smc911x: afc_cfg calculation is wrong at case 5

2006-09-13 Thread bora . sahin
BACKDUR calculation is wrong at case 5. Also some cosmetic around smc911x_probe... AFC_HI is about ((Rx Data Fifo Size)*2/3)/64 AFC_LO is AFC_HI/2 BACK_DUR is about 5uS*(AFC_LO) rounded down Rx Data Fifo Size = 10560 AFC_HI = 110 AFC_LO = 55 BACK_DUR = 55 * 5 = 275 Signed-off-by: Bora Sahin <

[PATCH 8/12] smc911x: Fix external phy detect routine

2006-09-13 Thread bora . sahin
9115-an1212.pdf, page 23 -> http://www.smsc.com/main/anpdf/an1212.pdf "The existence of external PHYs is determined by reading the same two PHY registers at PHY addresses 0x02 through 0x30. If values of 0x and 0x are obtained, there is no PHY at the given PHY address". And according t

[PATCH 9/12] smc911x: phy_check_media reverses MAC duplex settings

2006-09-13 Thread bora . sahin
Datasheet says, page: 98 -> http://www.smsc.com/main/datasheets/9115.pdf "MAC_CR_RCVOWN_ should be reset when the Full Duplex Mode bit is set" and "When MAC_CR_FDPX_ set, the MAC operates in Full-Duplex mode, in which it can transmit and receive simultaneously." Signed-off-by: Bora Sahin <[EM

[PATCH 3/12] smc911x: Use SET_ETHTOOL_OPS macro

2006-09-13 Thread bora . sahin
Use SET_ETHTOOL_OPS macro... Signed-off-by: Bora Sahin <[EMAIL PROTECTED]> Index: linux-2.6.18-rc4/drivers/net/smc911x.c === --- linux-2.6.18-rc4.orig/drivers/net/smc911x.c 2006-08-06 21:20:11.0 +0300 +++ linux-2.6.18-rc4/d

[PATCH 1/12] smc911x: Fix a few accessor SMC_* routines

2006-09-13 Thread bora . sahin
When in 16 bit mode, SMC_outl incorrectly simulates the situation and plus in 32 bit mode SMC_outw is missing... Signed-off-by: Bora Sahin <[EMAIL PROTECTED]> Index: linux-2.6.18-rc4/drivers/net/smc911x.h === --- linux-2.6.18-rc4.o

[PATCH 10/12] smc911x: phy_configure releases spinlocks before grabing

2006-09-13 Thread bora . sahin
phy_configure releases spinlocks before grabing... Signed-off-by: Bora Sahin <[EMAIL PROTECTED]> Index: linux-2.6.18-rc4/drivers/net/smc911x.c === --- linux-2.6.18-rc4.orig/drivers/net/smc911x.c 2006-08-06 21:20:11.0 +0300

[PATCH 6/12] smc911x: Unneeded spinlocks around smc911x_enable

2006-09-13 Thread bora . sahin
smc911x_enable, which enables irqs as a last task, is called with irqs disabled. There is no any other concurrent access at that phase so spinlock protection is unneeded... Signed-off-by: Bora Sahin <[EMAIL PROTECTED]> Index: linux-2.6.18-rc4/drivers/net/smc911x.c =

[PATCH 11/12] smc911x: Undocumented interrupt now reserved

2006-09-13 Thread bora . sahin
In Rev B silicon #defineINT_STS_RXDF_INT_   (0x0040)  /* R/WC */ seems reserved. Signed-off-by: Bora Sahin <[EMAIL PROTECTED]> Index: linux-2.6.18-rc4/drivers/net/smc911x.c === --- linux-2.6.18-rc4.orig

[PATCH 7/12] smc911x: Fix a few DBG macros

2006-09-13 Thread bora . sahin
Some cosmetic around DBG macros... Signed-off-by: Bora Sahin <[EMAIL PROTECTED]> Index: linux-2.6.18-rc4/drivers/net/smc911x.c === --- linux-2.6.18-rc4.orig/drivers/net/smc911x.c 2006-08-06 21:20:11.0 +0300 +++ linux-2.6.18

Re: TCP Pacing

2006-09-13 Thread Ian McDonald
On 9/13/06, Daniele Lacamera <[EMAIL PROTECTED]> wrote: On Tuesday 12 September 2006 23:26, Ian McDonald wrote: > Where is the published research? If you are going to mention research > you need URLs to papers and please put this in source code too so > people can check. I added the main referen

Re: [PATCH 1/2] ethtool: allow const ethtool_ops

2006-09-13 Thread Jeff Garzik
applied, then I fixed up all the drivers Otherwise, it was a half-complete job that would take years to get cleaned up. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-in

Re: [PATCH 1/3] sky2: tx pause bug fix

2006-09-13 Thread Jeff Garzik
since I didn't hear back on my question from yesterday, and since 2.6.18 is very close, I applied this series to netdev#upstream Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.k

Re: [PATCH 1/5] pcnet32: remove unnecessary save/restore register accesses.

2006-09-13 Thread Jeff Garzik
applied patches 1-5, thanks. Now, if any problems appear, a 'git bisect' will quickly and easily narrow down the problem source. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/maj

Re: [PATCH 2.6.17 0/9] NetXen: 1G/10G Ethernet Driver

2006-09-13 Thread Pradeep Dalvi
Jeff, Thanks for your comments. We are incorporating these suggestions and will resubmit an updated driver asap. -- pradeep On Tue, 12 Sep 2006, Jeff Garzik wrote: More updates needed: 1) diff against 2.6.18-rcX (currently -rc6) 2) remove ifdefs around NETIF_F_TSO 3) remove ifdefs aroun

[PATCH] vlan support for pktgen

2006-09-13 Thread Francesco Fondelli
Hi all, The attached patch allows pktgen to produce 802.1Q and Q-in-Q tagged frames. I have used it for stress test a bridge and seems ok to me. Unfortunately I have no access to net-2.6.x git tree so the diff is against 2.6.17.13. If you have a moment look over it, I think this feature could be

[PATCH 3/5] pcnet32: move/create receive and transmit routines

2006-09-13 Thread Don Fry
Move the receive routine and create the transmit routine. Tested ia32 and ppc64. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.18-rc6/drivers/net/pcnet32.c.magicTue Sep 12 10:25:20 2006 +++ linux-2.6.18-rc6/drivers/net/pcnet32.c Tue Sep 12 11:37:43 2006 @@ -299,7 +299,6

[PATCH 5/5] pcnet32: NAPI implementation

2006-09-13 Thread Don Fry
Implement NAPI changes to pcnet32 driver. Compile default is off. Listed as experimental. Len and Don both worked on a NAPI implementation and have both tested these changes. An e1000 blasting short packets to the pcnet32 will lockup Don's system until the receive storm stops. Without NAPI Len

[PATCH 4/5] pcnet32: break receive routine into two pieces.

2006-09-13 Thread Don Fry
Breaking the receive frame processing into two routines for greater clarity. Tested ia32 and ppc64. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.18-rc6/drivers/net/pcnet32.c.move Tue Sep 12 11:37:43 2006 +++ linux-2.6.18-rc6/drivers/net/pcnet32.c Tue Sep 12 14:21:18 2006 @@ -

[PATCH 2/5] pcnet32: magic number cleanup

2006-09-13 Thread Don Fry
Change some magic numbers to clearer names. A few whitespace changes. Tested ia32 and ppc64. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.18-rc6/drivers/net/pcnet32.c.rap Tue Sep 12 10:09:12 2006 +++ linux-2.6.18-rc6/drivers/net/pcnet32.c Tue Sep 12 10:25:09 2006 @@ -207,7 +2

[PATCH 1/5] pcnet32: remove unnecessary save/restore register accesses.

2006-09-13 Thread Don Fry
Delete unnecessary save/restore of rap in interrupt handler and statistics. tested ia32 and ppc64. Signed-off-by: Don Fry <[EMAIL PROTECTED]> --- linux-2.6.18-rc6/drivers/net/pcnet32.c.orig Fri Sep 8 14:02:12 2006 +++ linux-2.6.18-rc6/drivers/net/pcnet32.c Tue Sep 12 10:09:12 2006 @@ -226

[PATCH 0/5] pcnet32: NAPI implementation (one more try)

2006-09-13 Thread Don Fry
These patches to the pcnet32 driver implement NAPI and respond to some other suggestions found during NAPI development and testing. The first patch deletes a couple of unnecessary save/restore operations. The second patch replaces some magic numbers with hopefully more clear defines. The third pat

Re: [PATCH] make ipv4 multicast packets only get delivered to sockets that are joined to group

2006-09-13 Thread David Stevens
Jeff Layton <[EMAIL PROTECTED]> wrote on 09/13/2006 09:12:23 AM: > Most of the RFC's I've looked at don't seem to have much to say about > how multicasting works at the socket level. Is there an RFC or > specification that spells this out, or is this one of those situations > where things are some

Re: [PATCH] EtherIP tunnel driver (RFC 3378)

2006-09-13 Thread Patrick McHardy
There are lots of whitespace errors (trailing whitespace, whitespace following opening parens, no whitespace after comma, ...) which I'm going to ignore below, please fix them anyway. Joerg Roedel wrote: > diff -uprN -X linux-2.6.17.13/Documentation/dontdiff > linux-2.6.17.13-vanilla/net/ipv4/eth

[git patches] net driver fixes

2006-09-13 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/e1000/e1000_main.c |8 ++-- drivers/net/mv643xx_eth.c |2 + drivers/net/wireless/zd1211rw/z

[PATCH]:[XFRM] BEET mode

2006-09-13 Thread Diego Beltrami
Hi all, here you can find the patch rebased to the current tree net-2.6.19 which introduces the BEET mode (Bound End-to-End Tunnel) as specified by the ietf draft at the following link: http://www.ietf.org/internet-drafts/draft-nikander-esp-beet-mode-06.txt A BEET mode Security Associations reco

PATCH mv643xx_eth: Unmap DMA buffers in receive path

2006-09-13 Thread Dale Farnsworth
From: Dale Farnsworth <[EMAIL PROTECTED]> Fix a missing call to dma_unmap_single() in the receive path. Without this call, errors have been observed on non-cache-coherent systems. Signed-off-by Dale Farnsworth <[EMAIL PROTECTED]> --- > ACK, but > error: patch failed: drivers/net/mv643xx_eth.c:

Re: [PATCH] make ipv4 multicast packets only get delivered to sockets that are joined to group

2006-09-13 Thread Jeff Layton
On Wed, 2006-09-13 at 07:32 -0700, David Stevens wrote: > [EMAIL PROTECTED] wrote on 09/13/2006 07:13:55 AM: > > This is not true on any OS I'm aware of, including the > original sockets multicast implementation on early BSD. > The current Linux behavior does seem to be consistent with th

Re: TCP Pacing

2006-09-13 Thread Daniele Lacamera
As Ian requested, some of the papers published about Pacing. * Main reference: - Amit Aggarwal, Stefan Savage, and Thomas Anderson. "Understanding the Performance of TCP Pacing". Proc. of the IEEE INFOCOM 2000 Conference on Computer Communications, March 2000, pages 1157 - 11

Re: [PATCH] make ipv4 multicast packets only get delivered to sockets that are joined to group

2006-09-13 Thread David Stevens
[EMAIL PROTECTED] wrote on 09/13/2006 07:13:55 AM: > Only > the socket that is bound to the group address to which the packet was > sent should get it. This is not true on any OS I'm aware of, including the original sockets multicast implementation on early BSD. Multicast group m

Re: ieee80211 and devices which decrypt in hardware

2006-09-13 Thread Michael Buesch
On Wednesday 13 September 2006 04:51, Daniel Drake wrote: > Hi, > > I'm working on support for hardware-based frame decryption in zd1211rw. > While doing so I encountered some strange behaviour in ieee80211 which > I'm wondering if someone can clarify. Alternatively if someone could > just conf

[PATCH] make ipv4 multicast packets only get delivered to sockets that are joined to group

2006-09-13 Thread Jeff Layton
The situation is this: Two programs have opened IPv4 UDP sockets, set SO_REUSEADDR on them, and are bound to INADDR_ANY on the same port. One program joins a multicast group address, the other program joins a different one. When a multicast packet is sent to this port on one of the group addresses

Re: netdev tx timeouts

2006-09-13 Thread Michael Buesch
On Wednesday 13 September 2006 15:49, Michael Buesch wrote: > On Wednesday 13 September 2006 15:25, Larry Finger wrote: > > Michael Buesch wrote: > > > On Wednesday 13 September 2006 04:25, Larry Finger wrote: > > >> Michael, > > >> > > >> I still have not gotten a network guru to answer any questi

Re: netdev tx timeouts

2006-09-13 Thread Michael Buesch
On Wednesday 13 September 2006 15:25, Larry Finger wrote: > Michael Buesch wrote: > > On Wednesday 13 September 2006 04:25, Larry Finger wrote: > >> Michael, > >> > >> I still have not gotten a network guru to answer any questions about > >> synchronize_net, but I have been testing the patch below

[PATCH] natsemi: Messages being noisy

2006-09-13 Thread Ingo Oeser
Hi there, I get the following message when trying to transfer big files (via FTP or SCP) since Linux 2.6.16.27. It didn't happen with Linux 2.6.13.4. [702238.242237] eth1: increased tx threshold, txcfg 0xd0f01008. [702238.242649] eth1: increased tx threshold, txcfg 0xd0f0100a. What about putti

Re: netdev tx timeouts

2006-09-13 Thread Larry Finger
Michael Buesch wrote: On Wednesday 13 September 2006 04:25, Larry Finger wrote: Michael, I still have not gotten a network guru to answer any questions about synchronize_net, but I have been testing the patch below: I'd say this is racy. Did you test this on SMP? No - I don't have the hard

Re: [PATCH] bcm43xx-softmac: improve wrong firmware message

2006-09-13 Thread Michael Buesch
On Wednesday 13 September 2006 00:06, Larry Finger wrote: > Martin Langer wrote: > > > > Why not writing both (ucode rev and driver version)? Something like > > > > "from version 4.x binary drivers (rev>0x128).\n" > > > > BTW, if anybody needs the relationship between ucode revsion and driv

Re: netdev tx timeouts

2006-09-13 Thread Michael Buesch
On Wednesday 13 September 2006 04:25, Larry Finger wrote: > Michael, > > I still have not gotten a network guru to answer any questions about > synchronize_net, but I have been testing the patch below: I'd say this is racy. Did you test this on SMP? > Index: wireless-2.6/drivers/net/wireless/bc

2.6.18-rc6 memory mapped pcap truncates outgoing TCP packets, but not icmp

2006-09-13 Thread bert hubert
Hi people, I like to use memory mapped pcap (PACKET_MMAP) since off the shelf, linux is a tad prone to drop packets while capturing these days. It used to be lots better at it, but right now memory mapped pcap is the only way to get things working a bit. I've noticed this on many machines. Howeve

Re: TCP Pacing

2006-09-13 Thread Daniele Lacamera
On Tuesday 12 September 2006 23:26, Ian McDonald wrote: > Where is the published research? If you are going to mention research > you need URLs to papers and please put this in source code too so > people can check. I added the main reference to the code. I am going to give you all the pointers o

Re: TCP Pacing

2006-09-13 Thread Daniele Lacamera
On Wednesday 13 September 2006 05:41, Stephen Hemminger wrote: > Pacing in itself isn't a bad idea, but: > * Since it is most useful over long delay links, maybe it should be a route parameter. What does this mean? Should I move the sysctl switch elsewhere? A new (cleaner) patch follows. Thanks

Re: Pull request for '8139cp-20060912-00' branch

2006-09-13 Thread Francois Romieu
Jeff Garzik <[EMAIL PROTECTED]> : > Francois Romieu wrote: > >Please pull from tag '8139cp-20060912-00' in repository > > > >git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git > > > >to get the change below: > > > >(patch applies to jeff#upstream-linus) > > Pulled, but there are some git p