Re: [PATCH 0/3] netpoll/netconsole fixes

2006-10-20 Thread Andrew Morton
On Thu, 19 Oct 2006 10:15:41 -0700 Stephen Hemminger [EMAIL PROTECTED] wrote: The netpoll transmit skb management is a mess, it has two paths and it's on Txq. These patches try and clean this up. I got a reject storm when applying the third patch then screwed it up rather than fixing it up.

Re: [PATCH 1/3] netpoll: initialize skb for UDP

2006-10-20 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 19 Oct 2006 10:15:42 -0700 Need to fully initialize skb to keep lower layers and queueing happy. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Applied, thanks Stephen. - To unsubscribe from this list: send the line unsubscribe netdev

Re: smallish review of acx1xx-wireless-driver.patch

2006-10-20 Thread Christoph Hellwig
On Fri, Oct 20, 2006 at 06:37:04AM +0400, Alexey Dobriyan wrote: Main griefs: a) home-grown lock debugger (what can it do what lockdep can't?) b) lack of endian annotations. I have a 95% patch for that. let me dig it up again. it depends on a previous patch to kill the (huge) remainders of

Re: [PATCH] [NET] One NET_INC_STATS() could be NET_INC_STATS_BH in tcp_v4_err()

2006-10-20 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Thu, 19 Oct 2006 17:45:26 +0200 I believe this NET_INC_STATS() call can be replaced by NET_INC_STATS_BH(), a little bit cheaper. Signed-off-by: Eric Dumazet [EMAIL PROTECTED] Applied, although I hope tcp_v4_err() never becomes a fast path :-) -

[PATCH] [NET] can use __get_cpu_var() instead of per_cpu() in loopback driver

2006-10-20 Thread Eric Dumazet
As BHs are off in loopback_xmit(), preemption cannot occurs, so we can use __get_cpu_var() instead of per_cpu() (and avoid a preempt_enable()/preempt_disable() pair) Signed-off-by: Eric Dumazet [EMAIL PROTECTED] --- net-2.6/drivers/net/loopback.c 2006-10-19 16:46:27.0 +0200 +++

Re: [PATCH] [NET] Size listen hash tables using backlog hint

2006-10-20 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Thu, 19 Oct 2006 11:27:50 +0200 Here is the second try for this patch. Many thanks for your feedback. [PATCH] [NET] Size listen hash tables using backlog hint This version looks very good. It's not a major bug fix (obviously) so we'll have to defer

Re: [PATCH] [NET] inet_peer : group together avl_left, avl_right, v4daddr to speedup lookups on some CPUS

2006-10-20 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Thu, 19 Oct 2006 12:57:42 +0200 Lot of routers/embedded devices still use CPUS with 16/32 bytes cache lines. (486, Pentium, ... PIII) It makes sense to group together fields used at lookup time so they fit in one cache line. This reduce cache

Re: [PATCH] [NET] can use __get_cpu_var() instead of per_cpu() in loopback driver

2006-10-20 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 09:18:35 +0200 As BHs are off in loopback_xmit(), preemption cannot occurs, so we can use __get_cpu_var() instead of per_cpu() (and avoid a preempt_enable()/preempt_disable() pair) Signed-off-by: Eric Dumazet [EMAIL PROTECTED]

Bluetooth update for 2.6

2006-10-20 Thread Marcel Holtmann
Hi Dave, here are another three bugfixes for the 2.6.19 kernel. Please forward them to Linus as soon as possible. Regards Marcel Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git This will update the following files:

Re: Bluetooth update for 2.6

2006-10-20 Thread David Miller
From: Marcel Holtmann [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 09:49:48 +0200 Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/holtmann/bluetooth-2.6.git I've pulled these patches into my tree, thanks a lot! - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 2/3] netpoll: rework skb transmit queue

2006-10-20 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 19 Oct 2006 10:15:43 -0700 The original skb management for netpoll was a mess, it had two queue paths and a callback. This changes it to have a per-instance transmit queue and use a tasklet rather than a work queue for the congested case.

Re: [PATCH 0/3] netpoll/netconsole fixes

2006-10-20 Thread David Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Thu, 19 Oct 2006 23:57:19 -0700 I got a reject storm when applying the third patch then screwed it up rather than fixing it up. A rediff and resend is needed, please. Make sure it's against the latest -linus or -davem, thanks. And I got rejects

Re: [PATCH REPOST 1/2] NET: Accurate packet scheduling for ATM/ADSL (kernel)

2006-10-20 Thread Patrick McHardy
jamal wrote: The poor guy has been persistent and has some good ideas and we need to encourage him to stick around. Why dont you help him get the patch in the shape you think is reasonable? I know you are busy elsewhere and your patch has been a while since you last promised. I will try to

Re: AF_KEY extended xfrm_state selector handling

2006-10-20 Thread Michal Růžička
BTW, why not use xfrm instead? Then you dont have to worry about racoon. What do you mean by this? - Do you suggest that there is another IKE implemetation for Linux 2.6 IPSec stack which uses netlink socket (XFRM) for kernel communication? If so, would you please point me to it? Or - Do

[patch 1/2]d80211: hardware TKIP support for ipw3945

2006-10-20 Thread Hong Liu
ipw3945 TKIP hwcrypto only support RC4 encryption, so the stack needs to pre compute the michael MIC and the RC4key for it. Signed-off-by: Hong Liu [EMAIL PROTECTED] --- include/net/d80211.h |7 +++ net/d80211/tkip.c| 25 +++-- net/d80211/tkip.h|2 ++

[patch 2/2] d80211: fix wep_tfm race

2006-10-20 Thread Hong Liu
The TX/RX path all use the local-wep_tfm to encrypt and decrypt packets. Each {en|de}crypt operation need set a new RC4key, this may corrupt the previous set key that is still being used. Thus cause a lot of decrypton error or encryption with the wrong key. Use two tfm (tx_tfm and rx_tfm) to avoid

[patch 2/2] d80211: fix wep_tfm race

2006-10-20 Thread Hong Liu
The TX/RX path all use the local-wep_tfm to encrypt and decrypt packets. Each {en|de}crypt operation need set a new RC4key, this may corrupt the previous set key that is still being used. Thus cause a lot of decrypton error or encryption with the wrong key. Use two tfm (tx_tfm and rx_tfm) to avoid

Re: AF_KEY extended xfrm_state selector handling

2006-10-20 Thread David Miller
From: Michal Růžička [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 10:56:13 +0200 - Do you suggest that there is another IKE implemetation for Linux 2.6 IPSec stack which uses netlink socket (XFRM) for kernel communication? If so, would you please point me to it? OpenSWAN is an IKE

[Announce] New netchannels implementation. Userspace network stack.

2006-10-20 Thread Evgeniy Polyakov
Netchannel [1] is pure bridge between low-level hardware and user, without any special protocol processing involved between them. Users are not limited to userspace only - I will use this netchannel infrastructure for fast NAT implementation, which is purely kernelspace user (although it is

Re: [PATCH 4/6] net: use bitrev8

2006-10-20 Thread Michael Tokarev
Andrew Morton wrote: On Thu, 19 Oct 2006 01:46:47 +0900 Akinobu Mita [EMAIL PROTECTED] wrote: Use bitrev8 for bmac, mace, macmace, macsonic, and skfp drivers. [] === --- work-fault-inject.orig/drivers/net/Kconfig +++

Re: [Announce] New netchannels implementation. Userspace network stack.

2006-10-20 Thread Evgeniy Polyakov
Netchannels implementation. Patch is against 2.6.17-rc3 tree. If there will be any interest to have such subsystem in vanila tree I will regenerate patch against appropriate git tree. Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED] diff --git a/arch/i386/kernel/syscall_table.S

[IPv6] fib: initialize tb6_lock in common place to give lockdep a key

2006-10-20 Thread Thomas Graf
Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6/net/ipv6/ip6_fib.c === --- net-2.6.orig/net/ipv6/ip6_fib.c 2006-10-20 12:33:57.0 +0200 +++ net-2.6/net/ipv6/ip6_fib.c 2006-10-20 12:39:13.0 +0200 @@

[PATCH] [NET] reduce sizeof(struct flowi) by 20 bytes

2006-10-20 Thread Eric Dumazet
Hi all As suggested by David, just kill off some unused fields in dnports to reduce sizef(struct flowi). If they come back, they should be moved to nl_u.dn_u in order not to enlarge again struct flowi Signed-off-by: Eric Dumazet [EMAIL PROTECTED] diff --git a/include/net/dn.h

Re: [PATCH] [NET] One NET_INC_STATS() could be NET_INC_STATS_BH in tcp_v4_err()

2006-10-20 Thread Arnaldo Carvalho de Melo
On 10/20/06, David Miller [EMAIL PROTECTED] wrote: From: Eric Dumazet [EMAIL PROTECTED] Date: Thu, 19 Oct 2006 17:45:26 +0200 I believe this NET_INC_STATS() call can be replaced by NET_INC_STATS_BH(), a little bit cheaper. Signed-off-by: Eric Dumazet [EMAIL PROTECTED] Applied, although I

[PATCH 0/2] [NET]: RFC-compliant UDP-Lite support (RFC 3828)

2006-10-20 Thread Gerrit Renker
[UDP] This is a finalised, polished and tidied up revision of the full UDP-Lite patch. It features: * RFC 3828 - compliant support for UDP-Lite over IPv4 and IPv6 * consolidated and shared generic code between UDP and UDP-Lite (thanks to the help of Dave Miller)

[PATCH 2/2] [IPv6]: UDP-Lite support

2006-10-20 Thread Gerrit Renker
[UDPv6]: Support for UDP-Litev6 (RFC 3828). * consolidated with UDP basis * basic xfrm/netfilter support Signed-off-by: Gerrit Renker [EMAIL PROTECTED] -- include/net/ipv6.h| 12 + include/net/transp_v6.h |2 net/ipv6/af_inet6.c | 21 ++

Re: watchdog timeout panic in e1000 driver

2006-10-20 Thread Auke Kok
Kenzo Iwami wrote: Hi, Thank you for your comment. A watchdog timeout panic occurred in e1000 driver (7.2.9-NAPI). where's the panic message ? attached the panic message (e1000_panic). [...] This problem only occurs on a server using ethernet controller inside 631xESB/632xESB, and NMI

Re: [PATCH 2/3] netpoll: rework skb transmit queue

2006-10-20 Thread Stephen Hemminger
On Fri, 20 Oct 2006 00:15:30 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 19 Oct 2006 10:15:43 -0700 The original skb management for netpoll was a mess, it had two queue paths and a callback. This changes it to have a per-instance

[PATCH 2/3] netpoll: rework skb transmit queue

2006-10-20 Thread Stephen Hemminger
Change netpoll to use a skb queue for transmit. This solves problems where there are two tx paths that can cause things to get out of order and different semantics when netconsole output goes through fast and slow paths. The only user of the drop hook was netconsole, and I fixed that path. This

Re: [PATCH] bcm43xx-softmac: add PCI-E code

2006-10-20 Thread Daniel Drake
Hi Larry, Larry Finger wrote: From: Stefano Brivio [EMAIL PROTECTED] The current bcm43xx driver does not contain code to handle PCI-E interfaces such as the BCM4311 and BCM4312. This patch, originally written by Stefano Brivio adds the necessary code to enable these interfaces. I am testing

Re: [PATCH] bcm43xx-softmac: add PCI-E code

2006-10-20 Thread Michael Buesch
On Friday 20 October 2006 17:46, Daniel Drake wrote: Hi Larry, Larry Finger wrote: From: Stefano Brivio [EMAIL PROTECTED] The current bcm43xx driver does not contain code to handle PCI-E interfaces such as the BCM4311 and BCM4312. This patch, originally written by Stefano Brivio

Re: [PATCH] bcm43xx-softmac: add PCI-E code

2006-10-20 Thread Daniel Drake
Michael Buesch wrote: Which kernel are you using exactly? 2.6.19-rc2 bcm43xx: Radio turned off bcm43xx: DMA-32 0x0200 (RX) max used slots: 7/64 bcm43xx: DMA-32 0x02A0 (TX) max used slots: 0/512 bcm43xx: DMA-32 0x0280 (TX) max used slots: 0/512 bcm43xx: DMA-32 0x0260 (TX) max used slots:

Re: [PATCH 2/3] netpoll: rework skb transmit queue

2006-10-20 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 08:18:57 -0700 Netdump is not in the tree, so I can't fix it. Also netdump is pretty much superseded by kdump. Unless kdump is %100 ready you can be sure vendors will ship netdump for a little while longer. I think gratuitously

Re: [PATCH 2/3] netpoll: rework skb transmit queue

2006-10-20 Thread Stephen Hemminger
On Fri, 20 Oct 2006 12:24:27 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 08:18:57 -0700 Netdump is not in the tree, so I can't fix it. Also netdump is pretty much superseded by kdump. Unless kdump is %100 ready you

Re: [PATCH 2/3] netpoll: rework skb transmit queue

2006-10-20 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 08:40:15 -0700 The only user of the drop hook was netconsole, and I fixed that path. This probably breaks netdump, but that is out of tree, so it needs to fix itself. I believe that netdump needs to requeue things because

Re: [PATCH 2/3] netpoll: rework skb transmit queue

2006-10-20 Thread Stephen Hemminger
On Fri, 20 Oct 2006 12:27:53 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 08:40:15 -0700 The only user of the drop hook was netconsole, and I fixed that path. This probably breaks netdump, but that is out of tree, so it

Re: [RFC] wrr (weighted round-robin) bonding

2006-10-20 Thread Dawid Ciezarkiewicz
On Thursday, 19 October 2006 21:04, Andy Gospodarek wrote: It would seem to me that extending an existing mode would be more desirable than adding yet another mode to worry about. I don't even like the fact that there are as many as there are, but I understand why they are there. Ack. I

Re: [RFC] Ethernet Cheap Cryptography

2006-10-20 Thread Dawid Ciezarkiewicz
On Thursday, 19 October 2006 05:57, Stephen J. Bevan wrote: And if the packets come out of order i.e. you get a packet with a new key followed by a packet with the old key? As IV from invalid frames are saved ccrypt will synchronize anyway, but I was wrong in one aspect - in current

Re: [RFC] wrr (weighted round-robin) bonding

2006-10-20 Thread Jay Vosburgh
Dawid Ciezarkiewicz [EMAIL PROTECTED] wrote: On Thursday, 19 October 2006 21:04, Andy Gospodarek wrote: It would seem to me that extending an existing mode would be more desirable than adding yet another mode to worry about. I don't even like the fact that there are as many as there are, but

Re: [RFC] Ethernet Cheap Cryptography

2006-10-20 Thread Pawel Foremski
Stephen J. Bevan wrote: Pawel Foremski writes: Secondly, IPsec won't decrease MSS in TCP encapsulated in PPPoE traffic, for example. Various, commercial, IPsec products decrease the MSS for TCP encapsulated in PPPoE. I've not checked the Linux 2.6 IPsec code to see if it does or if

Re: [RFC] wrr (weighted round-robin) bonding

2006-10-20 Thread Dawid Ciezarkiewicz
On Friday, 20 October 2006 21:53, Jay Vosburgh wrote: Dawid Ciezarkiewicz [EMAIL PROTECTED] wrote: On Thursday, 19 October 2006 21:04, Andy Gospodarek wrote: It would seem to me that extending an existing mode would be more desirable than adding yet another mode to worry about. I don't

Re: [RFC] wrr (weighted round-robin) bonding

2006-10-20 Thread Andy Gospodarek
On Fri, Oct 20, 2006 at 10:52:00PM +0200, Dawid Ciezarkiewicz wrote: Oh. I'm quite puzzled here. What is current policy? I'd like sysfs interfaces better than ioctl - they are much cleaner etc. - but I thought ioctl will be better here because current bonding control uses ioctl and

Re: [patch 3/6] 2.6.18: sb1250-mac: Phylib IRQ handling fixes

2006-10-20 Thread Andy Fleming
On Oct 3, 2006, at 10:18, Maciej W. Rozycki wrote: Hello, This patch fixes a couple of problems discovered with interrupt handling in the phylib core, namely: 1. The driver uses timer and workqueue calls, but does not include linux/timer.h nor linux/workqueue.h. Good catch. 2.

[patch 7/9] com20020 build fix

2006-10-20 Thread akpm
From: Randy Dunlap [EMAIL PROTECTED] com20020.c needs to export functions if either of the ISA or PCI modules are built as loadable modules. Or they could always be exported. WARNING: com20020_found [drivers/net/arcnet/com20020-pci.ko] undefined! WARNING: com20020_check

[patch 8/8] e1000: Reset all functions after a PCI error

2006-10-20 Thread akpm
From: Linas Vepstas [EMAIL PROTECTED] During the handling of the PCI error recovery sequence, the current e1000 driver erroneously blocks a device reset for any but the first PCI function. It shouldn't -- this is a cut-n-paste error from a different driver (which tolerated only one hardware

[patch 3/8] sundance: remove TxStartThresh and RxEarlyThresh

2006-10-20 Thread akpm
From: Jesse Huang [EMAIL PROTECTED] For patent issue need to remove TxStartThresh and RxEarlyThresh. This patent is cut-through patent. If use this function, Tx will start to transmit after few data be move in to Tx FIFO. We are not allow to use those function in

[patch 4/9] atm/firestream: handle thrown error

2006-10-20 Thread akpm
From: Jeff Garzik [EMAIL PROTECTED] gcc emits the following warning: drivers/atm/firestream.c: In function ‘fs_open’: drivers/atm/firestream.c:870: warning: ‘tmc0’ may be used uninitialized in this function This indicates a real bug. We should check make_rate() return value for

[patch 4/8] subdance: fix TX Pause bug (reset_tx, intr_handler)

2006-10-20 Thread akpm
From: Jesse Huang [EMAIL PROTECTED] Fix TX Pause bug (reset_tx, intr_handler). When MaxCollisions occurred, need to re-enable Tx. But just after re-enable, MaxCollisions maybe occurred again and with TxStatusOverflow. This will cause driver can't check new MaxCollisions to re-enable Tx again,

[patch 2/8] 8139too: force media setting cleanup

2006-10-20 Thread akpm
From: Bernard Lee [EMAIL PROTECTED] Setting bit 4 5 alone in 8139too module media option does not really force 100Mbps full-duplex mode. When media option bit 0-3 is cleared, 8139too module does not force media setting. Therefore, bit 0-3 requires to be set for bit 4 5 to take effect. The

[patch 8/9] nicstar: Fix a bogus casting warning

2006-10-20 Thread akpm
From: Alan Cox [EMAIL PROTECTED] Not enough to make Nicstar 64bit friendly but got squashed in passing so might as well be applied Signed-off-by: Alan Cox [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/atm/nicstar.c |4 ++-- 1 files changed, 2 insertions(+), 2

[patch 5/9] WAN/pc300: handle, propagate minor errors

2006-10-20 Thread akpm
From: Jeff Garzik [EMAIL PROTECTED] - move definition of 'tmc' and 'br' locals closer to usage - handle clock_rate_calc() error - propagate errors back to upper level open routine Signed-off-by: Jeff Garzik [EMAIL PROTECTED] Cc: Krzysztof Halasa [EMAIL PROTECTED] Signed-off-by: Andrew Morton

[patch 1/8] Update smc91x driver with ARM Versatile board info

2006-10-20 Thread akpm
From: Deepak Saxena [EMAIL PROTECTED] We need to specify a Versatile-specific SMC_IRQ_FLAGS value or the new generic IRQ layer will complain thusly: No IRQF_TRIGGER set_type function for IRQ 25 (NULL) Signed-off-by: Deepak Saxena [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Cc: Russell

[patch 6/9] NET/atm: handle sysfs errors

2006-10-20 Thread akpm
From: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- net/atm/atm_sysfs.c | 15 --- 1 files changed, 12 insertions(+), 3 deletions(-) diff -puN net/atm/atm_sysfs.c~net-atm-handle-sysfs-errors

[patch 6/8] subdance: correct initial and close hardware step.

2006-10-20 Thread akpm
From: Jesse Huang [EMAIL PROTECTED] Correct initial and close hardware step. In some embedded system down and up IP100A will cause DMA crash. We add some for safe down and up IP100A. Signed-off-by: Jesse Huang [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] ---

[patch 9/9] iPhase: 64bit cleanup

2006-10-20 Thread akpm
From: Alan Cox [EMAIL PROTECTED] Signed-off-by: Alan Cox [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/atm/Kconfig |2 +- drivers/atm/iphase.c | 23 ++- 2 files changed, 11 insertions(+), 14 deletions(-) diff -puN

[patch 1/9] bonding: lockdep annotation

2006-10-20 Thread akpm
From: Peter Zijlstra [EMAIL PROTECTED] = [ INFO: possible recursive locking detected ] 2.6.17-1.2600.fc6 #1 - ifconfig/2411 is trying to acquire lock: (dev-_xmit_lock){-...}, at: [80429b9f]

[patch 3/9] drivers/atm: No need to return void

2006-10-20 Thread akpm
From: Tobias Klauser [EMAIL PROTECTED] The module_exit function has return-type void and pci_unregister_driver() returns void anyway. Signed-off-by: Tobias Klauser [EMAIL PROTECTED] Cc: chas williams [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/atm/ambassador.c

[patch 2/9] IPv6/DCCP: fix memory leak in dccp_v6_do_rcv()

2006-10-20 Thread akpm
From: Jesper Juhl [EMAIL PROTECTED] Coverity found what looks like a real leak in net/dccp/ipv6.c::dccp_v6_do_rcv() We may leave via the return inside if (sk-sk_state == DCCP_OPEN) { but at that point we may have allocated opt_skb, but we never free it in that path before the return. (akpm:

Re: [patch 1/8] Update smc91x driver with ARM Versatile board info

2006-10-20 Thread Russell King
On Fri, Oct 20, 2006 at 02:42:04PM -0700, [EMAIL PROTECTED] wrote: We need to specify a Versatile-specific SMC_IRQ_FLAGS value or the new generic IRQ layer will complain thusly: I don't think I heard anything back from my previous suggestion that the IRQ flags are passed through the platform

Re: [patch 3/6] 2.6.18: sb1250-mac: Phylib IRQ handling fixes

2006-10-20 Thread Andrew Morton
On Fri, 20 Oct 2006 16:40:20 -0500 Andy Fleming [EMAIL PROTECTED] wrote: The solution is to ignore phy_interrupt() calls if the reported device has already been halted and calling flush_scheduled_work() from phy_stop_interrupts() (but guarded with current_is_keventd() in

[PATCH] hostap_plx: fix CIS verification

2006-10-20 Thread Pavel Roskin
hostap_plx: fix CIS verification The record length for numerical manufacturer ID should be at least 4 bytes (two 16-bit words). The code required 5 bytes, which would break for most (if not all) cards. Reported by [EMAIL PROTECTED] Signed-off-by: Pavel Roskin [EMAIL PROTECTED] --- This is an

wake on LAN with sky2

2006-10-20 Thread Tino Keitel
Hi folks, I saw that the wake on LAN function was removed from sky2 in kernel 2.6.17. It was also mentioned that this happened because it didn't work and also couldn't be tested but that it will be put back later. Is there some progress regarding this? I have a Mac mini core duo that can do

Re: [patch 1/1] r8169 driver: corega support

2006-10-20 Thread Francois Romieu
[EMAIL PROTECTED] [EMAIL PROTECTED] : [Corega adapter support] It's queued in the r8169 branch at: git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git r8169 I have sent Jeff a pull request for it (and I'll probably send one more for the patch below). Darren, can you check if the patch

Re: [PATCH 2/3] netpoll: rework skb transmit queue

2006-10-20 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 12:25:27 -0700 Sorry, but why should we treat out-of-tree vendor code any differently than out-of-tree other code. I think what netdump was trying to do, provide a way to requeue instead of fully drop the SKB, is quite

Re: [PATCH 2/3] netpoll: rework skb transmit queue

2006-10-20 Thread Stephen Hemminger
On Fri, 20 Oct 2006 12:52:26 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 12:25:27 -0700 Sorry, but why should we treat out-of-tree vendor code any differently than out-of-tree other code. I think what netdump was

Re: [PATCH 2/3] netpoll: rework skb transmit queue

2006-10-20 Thread Stephen Hemminger
On Fri, 20 Oct 2006 12:52:26 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 12:25:27 -0700 Sorry, but why should we treat out-of-tree vendor code any differently than out-of-tree other code. I think what netdump was

Re: [PATCH 2/3] netpoll: rework skb transmit queue

2006-10-20 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 08:40:15 -0700 -static void queue_process(void *p) +static void netpoll_run(unsigned long arg) { ... - spin_unlock_irqrestore(queue_lock, flags); + netif_tx_lock(dev); + if

Re: [PATCH 2/3] netpoll: rework skb transmit queue

2006-10-20 Thread Stephen Hemminger
On Fri, 20 Oct 2006 13:42:09 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 08:40:15 -0700 -static void queue_process(void *p) +static void netpoll_run(unsigned long arg) { ... -

Re: [PATCH] e100_shutdown: netif_poll_disable hang

2006-10-20 Thread Auke Kok
Daniel Walker wrote: My machine annoyingly hangs while rebooting. I tracked it down to e100-fix-reboot-f-with-netconsole-enabled.patch in 2.6.18-rc2-mm2 I review the changes and it seemed to be calling netif_poll_disable one too many time. Once in e100_down(), and again in e100_shutdown(). The

Re: [PATCH 2/3] netpoll: rework skb transmit queue

2006-10-20 Thread Andi Kleen
But, it also violates the assumptions of the network devices. It calls NAPI poll back with IRQ's disabled and potentially doesn't obey the semantics about only running on the same CPU as the received packet. netpoll always played a little fast'n'lose with various locking rules. Also often

Re: [PATCH 2/3] netpoll: rework skb transmit queue

2006-10-20 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 13:48:26 -0700 On Fri, 20 Oct 2006 13:42:09 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: We really can't handle TX stopped this way from the netpoll_send_skb() path. All that old retry logic in netpoll_send_skb() is

Re: [PATCH] e100_shutdown: netif_poll_disable hang

2006-10-20 Thread Auke Kok
Auke Kok wrote: Daniel Walker wrote: My machine annoyingly hangs while rebooting. I tracked it down to e100-fix-reboot-f-with-netconsole-enabled.patch in 2.6.18-rc2-mm2 I review the changes and it seemed to be calling netif_poll_disable one too many time. Once in e100_down(), and again in

Re: [PATCH 2/3] netpoll: rework skb transmit queue

2006-10-20 Thread David Miller
From: Andi Kleen [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 23:01:29 +0200 netpoll always played a little fast'n'lose with various locking rules. The current code is fine, it never reenters -poll, because it maintains a -poll_owner which it checks in netpoll_send_skb() before trying to call back

Re: [PATCH 2/3] netpoll: rework skb transmit queue

2006-10-20 Thread Andi Kleen
On Friday 20 October 2006 23:08, David Miller wrote: From: Andi Kleen [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 23:01:29 +0200 netpoll always played a little fast'n'lose with various locking rules. The current code is fine, it never reenters -poll, because it maintains a -poll_owner which

Re: [PATCH 2/3] netpoll: rework skb transmit queue

2006-10-20 Thread Stephen Hemminger
On Fri, 20 Oct 2006 23:16:03 +0200 Andi Kleen [EMAIL PROTECTED] wrote: On Friday 20 October 2006 23:08, David Miller wrote: From: Andi Kleen [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 23:01:29 +0200 netpoll always played a little fast'n'lose with various locking rules. The current

[PATCH 2/3] netpoll: use device xmit directly

2006-10-20 Thread Stephen Hemminger
For most normal sends, the netpoll code was using the dev-hard_start_xmit directly. If it got busy, it would process later, but this code path uses dev_queue_xmit() and that code would send the skb through NIT and other stuff that netpoll doesn't want. Signed-off-by: Stephen Hemminger [EMAIL

[PATCH 1/3] netpoll: use sk_buff_head for txq

2006-10-20 Thread Stephen Hemminger
This is similar in spirit to earlier patches with less changes. Get rid of DIY queue for skb's used in netpoll. Add missing code to cleanup queue on shutdown. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- netpoll.orig/net/core/netpoll.c +++ netpoll/net/core/netpoll.c @@ -37,10 +37,7 @@

[PATCH 3/3] netpoll: retry logic cleanup

2006-10-20 Thread Stephen Hemminger
Change retry logic of netpoll. Always requeue if unable to send instead of dropping. Make retry counter per send rather than causing mass migration when tries gets less than zero. Since callers are either netpoll_send_arp or netpoll_send_udp, we knwo that np and np-dev can't be null.

[PATCH] sky2: 88E803X transmit lockup

2006-10-20 Thread Stephen Hemminger
The reason sky2 driver was locking up on transmit on the Yukon-FE chipset is that it was misconfiguring the internal RAM buffer so the transmitter and receiver were sharing the same space. The code assumed there was 16K of RAM on Yukon-FE (taken from vendor driver sk98lin which is even more

Re: [PATCH] hostap_plx: fix CIS verification

2006-10-20 Thread Jouni Malinen
On Fri, Oct 20, 2006 at 06:20:15PM -0400, Pavel Roskin wrote: The record length for numerical manufacturer ID should be at least 4 bytes (two 16-bit words). The code required 5 bytes, which would break for most (if not all) cards. Reported by [EMAIL PROTECTED] case

Re: [RFC] Ethernet Cheap Cryptography

2006-10-20 Thread Stephen J. Bevan
Pawel Foremski writes: Consider such an example: our task is to bridge two LANs managed by a third-party ISP over a wireless link, with the highest performance possible for such medium. The ISP has its clients on one LAN and a PPPoE concentrator on the second one. Because the ISP doesn't

Re: [RFC] Ethernet Cheap Cryptography

2006-10-20 Thread Stephen J. Bevan
David Miller writes: From: [EMAIL PROTECTED] (Stephen J. Bevan) Date: Thu, 19 Oct 2006 19:18:41 -0700 Pawel Foremski writes: Secondly, IPsec won't decrease MSS in TCP encapsulated in PPPoE traffic, for example. Various, commercial, IPsec products decrease the MSS for

Re: [RFC] Ethernet Cheap Cryptography

2006-10-20 Thread David Miller
From: [EMAIL PROTECTED] (Stephen J. Bevan) Date: Fri, 20 Oct 2006 19:17:42 -0700 path-MTU gets interesting[1] in the context of an an IPsec gateway (i.e. tunnel mode IPsec) and there is definitely variability as to how reliably an ICMP will be returned in the case that the MTU is exceeded

Re: [patch 2/9] IPv6/DCCP: fix memory leak in dccp_v6_do_rcv()

2006-10-20 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 14:43:02 -0700 (akpm: does opt_skb actually do anything?) This is a clone of similar code in net/ipv6/tcp_ipv6.c, it's just missing the bits at label ipv6_pktoptions: :-) No offence to the original patch, it's correct, but I'm going to fix this by

Re: [RFC] Ethernet Cheap Cryptography

2006-10-20 Thread Stephen Hemminger
Ethernet encrypted bridging is old stuff: http://kerneltrap.org/node/167 http://www.arnor.net/encryptingbridge/ It never got accepted, mostly for the same reasons this proposal is a dead end. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [patch 6/9] NET/atm: handle sysfs errors

2006-10-20 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 14:43:16 -0700 From: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] Applied, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [patch 3/9] drivers/atm: No need to return void

2006-10-20 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 14:43:03 -0700 From: Tobias Klauser [EMAIL PROTECTED] The module_exit function has return-type void and pci_unregister_driver() returns void anyway. Signed-off-by: Tobias Klauser [EMAIL PROTECTED] Cc: chas williams [EMAIL PROTECTED]

Re: [patch 4/9] atm/firestream: handle thrown error

2006-10-20 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 14:43:14 -0700 From: Jeff Garzik [EMAIL PROTECTED] gcc emits the following warning: drivers/atm/firestream.c: In function $,1rx(Bfs_open$,1ry(B: drivers/atm/firestream.c:870: warning: $,1rx(Btmc0$,1ry(B may be used uninitialized in

Re: [patch 8/9] nicstar: Fix a bogus casting warning

2006-10-20 Thread David Miller
From: [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 14:43:18 -0700 From: Alan Cox [EMAIL PROTECTED] Not enough to make Nicstar 64bit friendly but got squashed in passing so might as well be applied Signed-off-by: Alan Cox [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED]

Re: [PATCH] bcm43xx-softmac: add PCI-E code

2006-10-20 Thread Michael Buesch
On Friday 20 October 2006 20:25, Daniel Drake wrote: Michael Buesch wrote: Which kernel are you using exactly? 2.6.19-rc2 Please try 2.6.18.1 or wireless-2.6. -- Greetings Michael. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH] bcm43xx: Readd dropped assignment

2006-10-20 Thread Dave Jones
On Wed, Oct 18, 2006 at 04:40:00PM +0200, Michael Buesch wrote: On Wednesday 18 October 2006 01:12, Daniel Drake wrote: Larry Finger pointed out a problem with my ieee80211 IV/ICV stripping patch, which I forgot about. Sorry about that. The patch readds the frame_ctl assignment

Re: [PATCH] bcm43xx: Readd dropped assignment

2006-10-20 Thread Daniel Drake
Dave Jones wrote: Is that one for -stable too? That file looks similar enough between .18.1 and .19rc that it should be the case ? No. The IV/ICV stripping change was only merged into John's tree very recently (the day I sent the fix). Daniel - To unsubscribe from this list: send the line

Re: [PATCH 2/3] netpoll: rework skb transmit queue

2006-10-20 Thread Dave Jones
On Fri, Oct 20, 2006 at 01:25:32PM -0700, Stephen Hemminger wrote: On Fri, 20 Oct 2006 12:52:26 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 20 Oct 2006 12:25:27 -0700 Sorry, but why should we treat out-of-tree vendor