Re: [PATCH] Fix race condition about network device name allocation

2007-06-13 Thread Dan Aloni
On Wed, Jun 13, 2007 at 09:36:31AM -0700, Stephen Hemminger wrote: > On Wed, 13 Jun 2007 12:45:21 +0300 > Dan Aloni <[EMAIL PROTECTED]> wrote: > > > On Mon, May 14, 2007 at 08:58:40AM -0700, Stephen Hemminger wrote: > > > Kenji Kaneshige found this race between device removal and > > > registratio

[PATCH UPDATED] bonding: Fix 802.3ad no carrier on "no partner found" instance

2007-06-13 Thread Jay Vosburgh
Modify carrier state determination for 802.3ad mode to comply with section 43.3.9 of IEEE 802.3, which requires that "Links that are not successful candidates for aggregation (e.g., links that are attached to other devices that cannot perform aggregation or links that have been manually co

Re: [PATCH] Fix race condition about network device name allocation

2007-06-13 Thread Jay Vosburgh
The following patch (based on a patch from Stephen Hemminger <[EMAIL PROTECTED]>) removes use after free conditions in the unregister path for the bonding master. Without this patch, an operation of the form "echo -bond0 > /sys/class/net/bonding_masters" would trigger a NULL pointer deref

RE: [PATCH 2/2] qdisc_restart - couple of optimizations.

2007-06-13 Thread Krishna Kumar2
Hi Peter, Thanks for your feedback. > > - netif_queue_stopped need not be called inside qdisc_restart as > > it has been called already in qdisc_run() before the first skb > > is sent, and in __qdisc_run() after each intermediate skb is > > sent (note : we are the only sender, so the queue

Re: [PATCH] TCP: remove initial_ssthresh from Cubic

2007-06-13 Thread Bill Fink
On Wed, 13 Jun 2007, David Miller wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Wed, 13 Jun 2007 11:31:49 -0700 > > > Maybe it is time to remove BIC? > > I don't see any compelling reason, the same could be said > of the other experimental protocols we include in the tree. I agre

Re: cannot set IP for ethernet

2007-06-13 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Thu, 14 Jun 2007 13:53:41 +1000 > Actually in his case it's because 2.6.22-rc4-git2 doesn't have the > following changeset. It's on the way, it just hasn't been picked up yet. - To unsubscribe from this list: send the line "unsubscribe netdev" in the bod

Re: cannot set IP for ethernet

2007-06-13 Thread Herbert Xu
On Tue, Jun 12, 2007 at 04:06:25PM +0200, Patrick McHardy wrote: > Oliver Neukum wrote: > > with 2.6.22-rc4-git2 I am getting errors when setting IP for ethernet > > interfaces: > > > > ioctl(4, SIOCSIFADDR, 0x7fff94931600) = -1 ENOBUFS (No buffer space > > available) > > > > The error is inde

Re: [PATCH] NET: Multiqueue network device support.

2007-06-13 Thread Zhu Yi
On Wed, 2007-06-13 at 08:32 -0400, jamal wrote: > The key arguement i make (from day one actually) is to leave the > majority of the work to the driver. But it seems not feasible the Qdisc needs to know nothing about the hardware rings. > My view of wireless WMM etc is it is a different media beh

Re: IC Plus Corp IC Plus IP1000

2007-06-13 Thread linux
The following hacks to bring it up to date got the vendor-supplied driver working for me. This is just fixing the things the compiler complained about; there may be other issues, but they don't seem to interfere with basic funtionality. diff --git a/Makefile b/Makefile index c91b384..31e4172 100

Re: [2/2] 2.6.22-rc4: known regressions v3

2007-06-13 Thread William Lee Irwin III
On Wed, Jun 13, 2007 at 11:25:20PM +0100, Mark Fortescue wrote: > The random seg faults on x86_64 is interesting as I have been getting > random illegal instruction faults on sparc (sun4c) with 2.6.22-rc3. I have > not yet tried to track it down. All I know at present is that it is not a > probl

Re: [PATCH] NET: Multiqueue network device support.

2007-06-13 Thread Zhu Yi
On Wed, 2007-06-13 at 13:34 +0200, Patrick McHardy wrote: > > The key argument for Jamal's solution is the NIC will send out 32 > > packets in the full PHL in a reasonably short time (a few microsecs > per > > Jamal's calculation). But for wireless, the PHL hardware has low > > probability to seize

Re: [ANNOUNCE] new driver ixgbe for Intel(R) 10GbE PCI Express adapters.

2007-06-13 Thread Ayyappan Veeraiyan
On 6/13/07, Francois Romieu <[EMAIL PROTECTED]> wrote: Please ignore my previous response. Forgot to reply_all.. o ixgbe_clean_tx_irq() is issued from the NAPI poll handler (as the name suggests...). Its locking will probably cause a deadlock if it is interrupted and a call to netpoll_send

Re: [Cbe-oss-dev] [PATCH 0/15] spidernet driver bug fixes

2007-06-13 Thread Michael Ellerman
On Wed, 2007-06-13 at 21:01 +0200, Segher Boessenkool wrote: > > I wish there was a git option to "just make my shit look like the > > remote, dammit!" The above is the "easiest" way I know how to do that. > > git-fetch -f remote:local ? There's always "git reset --hard " cheers -- Michael El

Re: [2/2] 2.6.22-rc4: known regressions v3

2007-06-13 Thread Mark Fortescue
Hi all, The random seg faults on x86_64 is interesting as I have been getting random illegal instruction faults on sparc (sun4c) with 2.6.22-rc3. I have not yet tried to track it down. All I know at present is that it is not a problem on 2.6.20.9. Regards Mark Fortescue. On Wed, 13

Re: [ANNOUNCE] new driver ixgbe for Intel(R) 10GbE PCI Express adapters.

2007-06-13 Thread Kok, Auke
Francois Romieu wrote: [EMAIL PROTECTED] <[EMAIL PROTECTED]> : [...] Please review and provide comments. o ixgbe_call_func and the ton of wrappers which go along with it should go. hmmm good point, this is a bit too verbose perhaps ;) o boolean_t duplicates the existing 'bool' yes, tha

Re: Realtek r8168 slow outbound transfer - potential fix/workaround

2007-06-13 Thread Francois Romieu
David Gundersen <[EMAIL PROTECTED]> : [...] > I've been doing a bit of investigation work into a problem that I've > been experiencing with the latest available r8168 driver from realtek > ('r8168-8.001.00') & linux kernel 2.6.21.1. > > I have been experiencing wierd problems with slow outbound

Re: [ANNOUNCE] new driver ixgbe for Intel(R) 10GbE PCI Express adapters.

2007-06-13 Thread Francois Romieu
[EMAIL PROTECTED] <[EMAIL PROTECTED]> : [...] > Please review and provide comments. o ixgbe_call_func and the ton of wrappers which go along with it should go. o boolean_t duplicates the existing 'bool' o The options below {should be/are} handled through ethtool: - TxDescriptors - RxDescri

Re: [PATCH] Fix race condition about network device name allocation

2007-06-13 Thread Stephen Hemminger
Bonding refers to device after unregistering. This has always been a dangerous thing. The following UNTESTED should fix the problem. --- a/drivers/net/bonding/bond_sysfs.c 2007-06-13 15:48:37.0 -0700 +++ b/drivers/net/bonding/bond_sysfs.c 2007-06-13 15:49:17.0 -0700 @@ -164,9 +16

Re: [PATCH] NET: Multiqueue network device support.

2007-06-13 Thread jamal
On Wed, 2007-13-06 at 11:20 -0700, David Miller wrote: > From: jamal <[EMAIL PROTECTED]> > Date: Wed, 13 Jun 2007 09:33:22 -0400 > > > So in such a case (assuming 8 rings), One model is creating 4 netdev > > devices each based on single tx/rx ring and register set and then > > having a mother netd

[GIT PATCHES] SCTP bugfixes

2007-06-13 Thread Vlad Yasevich
David Please pull the following SCTP patches from master.kernel.org:/pub/scm/linux/kernel/git/vxy/lksctp-dev.git Thanks -vlad The following changes since commit 66e1e3b20cbbf99da63e6c1af0fc6d39c2ed099a: David S. Miller (1): [TCP]: Set initial_ssthresh default to zero in Cubic and BIC

Re: r8169 tx problem (1s pause with ping)

2007-06-13 Thread Francois Romieu
Benjamin LaHaise <[EMAIL PROTECTED]> : [...] > I'm seeing something odd with r8169 on FC7: doing a ping -s 1600 alternates > between a 1s latency and sub 1ms. Has anyone else seen anything like this? > The system in question is an Asus M2A-VM with an onboard RTL8111 (I think). > NAPI doesn't

Re: [Cbe-oss-dev] [PATCH 0/15] spidernet driver bug fixes

2007-06-13 Thread Arnd Bergmann
On Wednesday 13 June 2007, Jeff Garzik wrote: > Segher Boessenkool wrote: > >> I wish there was a git option to "just make my shit look like the > >> remote, dammit!"  The above is the "easiest" way I know how to do that. > > > > git-fetch -f remote:local ? > > If that works... great :)  Much bet

Re: [2/2] 2.6.22-rc4: known regressions v3

2007-06-13 Thread Michal Piotrowski
On 13/06/07, Björn Steinbrink <[EMAIL PROTECTED]> wrote: On 2007.06.13 21:57:56 +0200, Michal Piotrowski wrote: > TTY > > Subject: OOPS (NULL pointer dereference) in v2.6.22-rc3 > References : http://lkml.org/lkml/2007/6/1/389 > http://bugzilla.kernel.org/show_bug.cgi?id=8473 >

Re: [Cbe-oss-dev] [PATCH 12/15] spidernet: increase the NAPI weight

2007-06-13 Thread Arnd Bergmann
On Wednesday 13 June 2007, Jeff Garzik wrote: > > +/* We really really want to empty the ring buffer every time, > > + * so as to avoid the RX ram full bug. So set te napi wieght > > + * to the ring size. > > + */ > > +#define SPIDER_NET_NAPI_WEIGHT   SPIDER_NET_RX_DESCRIPTORS_DEFAULT > > I do

Re: IC Plus Corp IC Plus IP1000

2007-06-13 Thread Peter Rasmussen
Thank you for your suggestion. I do however, have the following issues, which is also why I searched Google for help on it. 1.The Sundance driver is in the 100mbit section, implying that it won't work with 1gbit. 2.When I first started up the server I am using with the ethernet device, it di

Re: [PATCH 1/7] sky2: avoid reserved regions on ethtool reg dump

2007-06-13 Thread Jeff Garzik
Stephen Hemminger wrote: On Yukon EX reading some of the undocumented places in the memory space will cause a hang. Since they don't provide useful information, just skip the reserved areas. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/net/sky2.c | 14 +- 1 fi

Re: [RFC][PATCH -mm take5 6/7] add ioctls for adding/removing target

2007-06-13 Thread Satyam Sharma
Hi Keiichi, On 6/13/07, Keiichi KII <[EMAIL PROTECTED]> wrote: From: Keiichi KII <[EMAIL PROTECTED]> We add ioctls for adding/removing target. If we use NETCONSOLE_ADD_TARGET ioctl, we can dynamically add netconsole target. If we use NETCONSOLE_REMOVE_TARGET ioctl, we can dynamically remoe netc

Re: small forcedeth WoL fix

2007-06-13 Thread Jeff Garzik
Tim Mann wrote: I happened to notice that a system with an NVidia NIC using the forcedeth driver won't wake-on-LAN if the interface was in promiscuous mode when you power off. By experiment, it looks like the hardware needs to have NvRegPacketFilterFlags set to NVREG_PFF_ALWAYS|NVREG_PFF_MYADDR

Re: [PATCH 0/7] sky2 version 1.15 (88e8071) support

2007-06-13 Thread Stephen Hemminger
On Wed, 13 Jun 2007 16:05:23 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Stephen Hemminger wrote: > > These changes are to enable the Yukon Extreme (88e8071) > > chipset. This chip is similar to earlier chip but has a different > > set of offloading operations and some other minor quirks. > >

Re: [2/2] 2.6.22-rc4: known regressions with patches v3

2007-06-13 Thread Greg KH
On Wed, Jun 13, 2007 at 09:58:05PM +0200, Michal Piotrowski wrote: > USB > > Subject: list_add corruption. prev->next should be next (f7d28794), but > was f0df8ed4 (prev=f0df8ed4) Kernel Bug at lib/list_debug.c:33 > References : http://bugzilla.kernel.org/show_bug.cgi?id=8561 > Submitter

Re: [PATCH]: ps3: gigabit ethernet driver for PS3

2007-06-13 Thread Jeff Garzik
MOKUNO Masakazu wrote: Hi Jeff, The following patch adds support for the gigabit ethernet device of PS3. It was sent out before as RFC, now I submit it for 2.6.23. Signed-off-by: Masakazu Mokuno <[EMAIL PROTECTED]> Signed-off-by: Geoff Levand <[EMAIL PROTECTED]> --- drivers/net/Kconfig |

Re: [2/2] 2.6.22-rc4: known regressions v3

2007-06-13 Thread Björn Steinbrink
On 2007.06.13 21:57:56 +0200, Michal Piotrowski wrote: > TTY > > Subject: OOPS (NULL pointer dereference) in v2.6.22-rc3 > References : http://lkml.org/lkml/2007/6/1/389 > http://bugzilla.kernel.org/show_bug.cgi?id=8473 > http://bugzilla.kernel.org/show_bug.cgi?id=8574

Re: [PATCH]is_power_of_2-myri10ge/myri10ge.c

2007-06-13 Thread Jeff Garzik
vignesh babu wrote: Replacing (n & (n-1)) in the context of power of 2 checks with is_power_of_2 Signed-off-by: vignesh babu <[EMAIL PROTECTED]> Patches look OK, but please * CC relevant driver maintainers, and * combined all drivers/net/* patches of this nature into a single patch - To uns

Re: [PATCH 8/15] spidernet: beautify error messages

2007-06-13 Thread Jeff Garzik
Linas Vepstas wrote: Use dev_err() to print device error messages. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> drivers/net/spider_net.c | 64 --- 1 file changed, 34 insertions(+), 30 deletions(-) applied 8-11, 13-15 to #upstream (2.6.23

Re: [PATCH 12/15] spidernet: increase the NAPI weight

2007-06-13 Thread Jeff Garzik
Linas Vepstas wrote: Another way of minimizing the likelyhood of RX ram from overflowing is to empty out the entire rx ring every chance we get. Change the crazy watchdog timeout from 50 seconds to 3 seconds, while we're here. Signed-off-by: Linas Vepstas <[EMAIL PROTECTED]> drivers/net/s

Re: [PATCH 4/15] spidernet: silence the ramfull messages

2007-06-13 Thread Jeff Garzik
Linas Vepstas wrote: --- linux-2.6.22-rc1.orig/drivers/net/spider_net.c 2007-06-11 10:02:34.0 -0500 +++ linux-2.6.22-rc1/drivers/net/spider_net.c 2007-06-11 11:45:25.0 -0500 @@ -1172,7 +1172,7 @@ spider_net_decode_one_descr(struct spide goto bad_desc;

Re: [PATCH 1/15] spidernet: null out skb pointer after its been used.

2007-06-13 Thread Jeff Garzik
Linas Vepstas wrote: Avoid kernel crash in mm/slab.c due to double-free of pointer. If the ethernet interface is brought down while there is still RX traffic in flight, the device shutdown routine can end up trying to double-free an skb, leading to a crash in mm/slab.c Avoid the double-free by n

Re: [PATCH 0/7] sky2 version 1.15 (88e8071) support

2007-06-13 Thread Jeff Garzik
Stephen Hemminger wrote: These changes are to enable the Yukon Extreme (88e8071) chipset. This chip is similar to earlier chip but has a different set of offloading operations and some other minor quirks. Marvell has given me some evaluation boards with the 88e8071 chip set. The chip is availabl

Re: [PATCH 2/3] qla3xxx: cleanup checksum offload code

2007-06-13 Thread Jeff Garzik
Stephen Hemminger wrote: The code for checksum is more complex than needed when dealing with VLAN's; the higher layers already pass down the location of the IP header. Compile tested only, no hardware available. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> applied to #upstream (2.6.23

Re: Please pull 'rtl8187' branch of wireless-2.6

2007-06-13 Thread Jeff Garzik
John W. Linville wrote: Jeff, This is the second round for the new mac80211-based rtl8187 driver. Michael and Ivo responded to many of the original review comments, and I have added a couple of patches to minimally address some remaining issues. Please look at the comments I added to the header

Re: [2/2] 2.6.22-rc4: known regressions with patches v3

2007-06-13 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.22-rc4 with patches available. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions Networking Subject: no irda0 interface (2.6.21 was OK), smsc does not find chip References : http://lkml.or

Re: [2/2] 2.6.22-rc4: known regressions v3

2007-06-13 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.22-rc4. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions Networking Subject: commit 9093bbb2d96d0184f037cea9b4e952a44ebe7c32 broke the bonding driver References : http://lkml.org/lkml/20

Re: Please pull 'libertas-upstream' branch of wireless-2.6

2007-06-13 Thread Jeff Garzik
John W. Linville wrote: Patches identified by the libertas team as suitable for 2.6.23... --- The following changes since commit 82fde74b94f11eee1e9c30e43fb162f80a5e63c0: Luis Carlos (1): libertas: convert libertas_mpp into anycast_mask are found in the git repository at: git://gi

RE: [PATCH 2/3] qla3xxx: cleanup checksum offload code

2007-06-13 Thread Ron Mercer
ACK patch #2, not patch 3. I will add patch 3 at a later date. Signed-off-by: Ron Mercer <[EMAIL PROTECTED]> > -Original Message- > From: Jeff Garzik [mailto:[EMAIL PROTECTED] > Sent: Wednesday, June 13, 2007 12:44 PM > To: Stephen Hemminger > Cc: Linux Driver; netdev@vger.kernel.org >

Re: [PATCH] add return value check of request_irq()

2007-06-13 Thread Jeff Garzik
Yoichi Yuasa wrote: Hi, This patch has added return value check of request_irq() to pcmcia net drivers. Yoichi Signed-off-by: Yoichi Yuasa <[EMAIL PROTECTED]> applied to #upstream (2.6.23) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAI

Re: [PATCH] acenic: SET_NETDEV_DEV is always there these days

2007-06-13 Thread Jeff Garzik
Geert Uytterhoeven wrote: acenic: SET_NETDEV_DEV is always there these days Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]> applied to #upstream - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at htt

Re: [PATCH 1/4] b44: timer power saving

2007-06-13 Thread Jeff Garzik
Stephen Hemminger wrote: Make the PHY and statistic timer run on one second boundary for powersaving. On resume, the driver should check for link up immediately, to get online faster (rather than waiting for the next second). Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- drivers/n

Re: [PATCH] tulip: Convert to generic boolean

2007-06-13 Thread Jeff Garzik
Richard Knutsson wrote: Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64) Diffed against Linus' git-tree. de4x5.c | 98 de4x5.h |9 - 2 files chan

Re: [PATCH][RFC] network splice receive v2

2007-06-13 Thread Jens Axboe
On Wed, Jun 13 2007, Evgeniy Polyakov wrote: > On Tue, Jun 12, 2007 at 08:17:32PM +0200, Jens Axboe ([EMAIL PROTECTED]) > wrote: > > On Tue, Jun 12 2007, Evgeniy Polyakov wrote: > > > On Mon, Jun 11, 2007 at 01:59:26PM +0200, Jens Axboe ([EMAIL PROTECTED]) > > > wrote: > > > > Patches are against

Re: [IPROUTE 00/02]: rtnl_link support

2007-06-13 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 13 Jun 2007 20:11:58 +0200 > Stephen Hemminger wrote: > > On Wed, 13 Jun 2007 19:02:32 +0200 (MEST) > > Patrick McHardy <[EMAIL PROTECTED]> wrote: > > > >>Please apply, thanks. > > > > > > I'm putting out a new iproute2 next week. IF this is

Re: [NET 00/18]: Netlink link creation API + driver conversions

2007-06-13 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Wed, 13 Jun 2007 18:50:42 +0200 (MEST) > The patches are against net-2.6, but AFAICS the only thing in net-2.6.23 > conflicting with them is the previous series. > > Please apply/replace, thanks :) I've respun my tree up at: kernel.org:/pu

Re: [PATCH 1/2] ehea: Whitespace cleanup

2007-06-13 Thread Jeff Garzik
Thomas Klein wrote: This patch fixes several whitespace issues. Signed-off-by: Thomas Klein <[EMAIL PROTECTED]> Patch is obviously OK, but needs rediffing since I had to apply fixes before cleanups (standard patch ordering) - To unsubscribe from this list: send the line "unsubscribe netdev

Re: [PATCH 1/3] cxgb3 - sge page management

2007-06-13 Thread Jeff Garzik
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Streamline sge page management. Fix dma mappings when buffers are recycled. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/adapter.h | 38 ++-- drivers/net/cxgb3/sge.c | 423 ++---

Re: [PATCH] drivers/net: fix comparisons of unsigned < 0

2007-06-13 Thread Jeff Garzik
Bill Nottingham wrote: Recent gcc versions emit warnings when unsigned variables are compared < 0 or >= 0. Signed-off-by: Bill Nottingham <[EMAIL PROTECTED]> --- mlx4/qp.c |3 +-- netxen/netxen_nic_niu.c |6 +++--- tulip/de2104x.c |1 - 3 files changed, 4 ins

Re: [PATCH 2/3] qla3xxx: cleanup checksum offload code

2007-06-13 Thread Jeff Garzik
Stephen Hemminger wrote: The code for checksum is more complex than needed when dealing with VLAN's; the higher layers already pass down the location of the IP header. Compile tested only, no hardware available. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> Ron, do you ACK patch #2 and

Re: [PATCH] Blackfin ethernet driver: on chip ethernet MAC controller driver

2007-06-13 Thread Jeff Garzik
Bryan Wu wrote: From: "Wu, Bryan" <[EMAIL PROTECTED]> This patch implements the driver necessary use the Analog Devices Blackfin processor's on-chip ethernet MAC controller. Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROT

Re: [RFC][PATCH -mm take5 4/7] using symlink for the net_device

2007-06-13 Thread Satyam Sharma
Hi again, Ok, so sysfs_create_link() would be illegal from inside spin_lock_irqsave(), and this is why we have to use the dual-list mechanism to react to the net device rename. This isn't so obvious, a comment at the point where you declare modify_target_list would be nice? (BTW temporary_list wo

Re: [Cbe-oss-dev] [PATCH 0/15] spidernet driver bug fixes

2007-06-13 Thread Jeff Garzik
Segher Boessenkool wrote: I wish there was a git option to "just make my shit look like the remote, dammit!" The above is the "easiest" way I know how to do that. git-fetch -f remote:local ? If that works... great :) Much better than what I described. Jeff - To unsubscribe from

Re: [Cbe-oss-dev] [PATCH 0/15] spidernet driver bug fixes

2007-06-13 Thread Segher Boessenkool
I wish there was a git option to "just make my shit look like the remote, dammit!" The above is the "easiest" way I know how to do that. git-fetch -f remote:local ? Segher - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More m

Re: [PATCH 0/15] spidernet driver bug fixes

2007-06-13 Thread Jeff Garzik
As of this moment there are -no- spidernet patches in netdev. I just rebased 'upstream', and dropped the existing spidernet patches. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://v

Re: [PATCH 0/15] spidernet driver bug fixes

2007-06-13 Thread Jeff Garzik
Linas Vepstas wrote: "git branch" shows that I'm on "upstream". So I performed a "git pull" (without any additional arguments) assuming that it would sync to your "upstream" branch. And so my email was based on this. Some googling seems to show that "git pull" has a bug/feature of ignoring th

Re: [PATCH] TCP: remove initial_ssthresh from Cubic

2007-06-13 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 13 Jun 2007 11:31:49 -0700 > Maybe it is time to remove BIC? I don't see any compelling reason, the same could be said of the other experimental protocols we include in the tree. - To unsubscribe from this list: send the line "unsubscribe net

Re: [PATCH 0/15] spidernet driver bug fixes

2007-06-13 Thread Jeff Garzik
Michael Ellerman wrote: I was just keen to see the "major bugfixes" get into 22, rather than waiting another few months for 23. Agreed. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http:

Re: arp-scan triggers via-velocity "eth0: excessive work at interrupt"

2007-06-13 Thread Stephen Hemminger
On 12 Jun 2007 21:56:38 -0400 [EMAIL PROTECTED] wrote: > It kind of surprised me that sending 254 arp packets by using the arp-scan > tool (http://www.nta-monitor.com/tools/arp-scan/) on a /24 consistently > triggers a burst of "eth0: excessive work at interrupt." > > This is a 600 MHz PIII, 2.6.

RE: [PATCH] NET: Multiqueue network device support.

2007-06-13 Thread Waskiewicz Jr, Peter P
> PJ Waskiewicz wrote: > > diff --git a/net/sched/sch_generic.c > b/net/sched/sch_generic.c index > > f28bb2d..b9dc2a6 100644 > > --- a/net/sched/sch_generic.c > > +++ b/net/sched/sch_generic.c > > @@ -123,7 +123,8 @@ static inline int qdisc_restart(struct > net_device *dev) > >

Re: [PATCH] TCP: remove initial_ssthresh from Cubic

2007-06-13 Thread Stephen Hemminger
On Wed, 13 Jun 2007 11:26:52 -0700 (PDT) David Miller <[EMAIL PROTECTED]> wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Wed, 13 Jun 2007 10:27:18 -0700 > > Please make patches against my net-2.6 tree, I already > made changes in this area. > > > Remove the initial slow start overr

Re: IC Plus Corp IC Plus IP1000

2007-06-13 Thread linux
> Use the 'sundance' driver that's been in the kernel for quite a while. Er... that driver specifically does not list the IP1000's PCI device ID (13f0:1023), nor does it support anything over 100 Mbit/s. Are you *quite* sure that adding 13f0:1023 to the sundance_pci_tbl is all that's required? -

Re: [PATCH] TCP: remove initial_ssthresh from Cubic

2007-06-13 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Wed, 13 Jun 2007 10:27:18 -0700 Please make patches against my net-2.6 tree, I already made changes in this area. > Remove the initial slow start override from TCP cubic. > The old code caused Cubic to start out in slow start mode, which > is less

RE: [PATCH] NET: Multiqueue network device support.

2007-06-13 Thread Waskiewicz Jr, Peter P
> From: jamal <[EMAIL PROTECTED]> > Date: Wed, 13 Jun 2007 09:33:22 -0400 > > > So in such a case (assuming 8 rings), One model is creating > 4 netdev > > devices each based on single tx/rx ring and register set and then > > having a mother netdev (what you call the bond) that feeds these > >

Re: [PATCH] NET: Multiqueue network device support.

2007-06-13 Thread David Miller
From: jamal <[EMAIL PROTECTED]> Date: Wed, 13 Jun 2007 09:33:22 -0400 > So in such a case (assuming 8 rings), One model is creating 4 netdev > devices each based on single tx/rx ring and register set and then > having a mother netdev (what you call the bond) that feeds these > children netdev base

Re: [IPROUTE 00/02]: rtnl_link support

2007-06-13 Thread Patrick McHardy
Stephen Hemminger wrote: > On Wed, 13 Jun 2007 19:02:32 +0200 (MEST) > Patrick McHardy <[EMAIL PROTECTED]> wrote: > >>Please apply, thanks. > > > I'm putting out a new iproute2 next week. IF this is in mainline, it will > go in then. If not, then there will be a development branch Thanks. The

RE: [PATCH 2/2] qdisc_restart - couple of optimizations.

2007-06-13 Thread Waskiewicz Jr, Peter P
> - netif_queue_stopped need not be called inside qdisc_restart as > it has been called already in qdisc_run() before the first skb > is sent, and in __qdisc_run() after each intermediate skb is > sent (note : we are the only sender, so the queue cannot get > stopped while the tx lock was g

Re: [IPROUTE 00/02]: rtnl_link support

2007-06-13 Thread Stephen Hemminger
On Wed, 13 Jun 2007 19:02:32 +0200 (MEST) Patrick McHardy <[EMAIL PROTECTED]> wrote: > Hi Stephen, > > these patches add support for the rtnl_link stuff and VLAN configuration > to iproute. Since the old link configuration was entirely ioctl based and > mixing the two would be really ugly, this p

[PATCH] TCP: remove initial_ssthresh from Cubic

2007-06-13 Thread Stephen Hemminger
Remove the initial slow start override from TCP cubic. The old code caused Cubic to start out in slow start mode, which is less agressive but caused slow performance. The administrator can override initial slow start threshold on any TCP congestion control method via the TCP route metrics. Signed

Re: [RFC][PATCH -mm take5 7/7] update documentation

2007-06-13 Thread Satyam Sharma
Hi, On 6/13/07, Keiichi KII <[EMAIL PROTECTED]> wrote: From: Keiichi KII <[EMAIL PROTECTED]> update Documentation/networking/netconsole.txt - how to use sysfs for dynamic configurability - how to use ioctl for dynamic configurability Signed-off-by: Keiichi KII <[EMAIL PROTECTED]> Ah, so he

Re: [patch 1/6] 8139too: force media setting cleanup

2007-06-13 Thread Jeff Garzik
Kyuma Ohta wrote: Hi, I was testing 2.6.22-rc4 from yesterday, but communication speed of 8139 side is very slower than 2.6.21.* (less than 10kbytes/sec at 100MBPS,FULL-DUPLEX). I was not test from 2.6.22-rc ,yesterday I started to test 2.6.22-rc. So, I *must* set HALF-DUPLEX to 8139 side b

Re: [RFC][PATCH -mm take5 5/7] switch function of netpoll

2007-06-13 Thread Satyam Sharma
Hi Keiichi, On 6/13/07, Keiichi KII <[EMAIL PROTECTED]> wrote: From: Keiichi KII <[EMAIL PROTECTED]> This patch contains switch function of netpoll. If "enabled" attribute of certain port is '1', this port is used and the configurations of this port are unable to change. If "enabled" attribut

[IPROUTE 01/02]: iplink: use netlink for link configuration

2007-06-13 Thread Patrick McHardy
[IPROUTE]: iplink: use netlink for link configuration Add support for using netlink for link configuration. Kernel-support is probed, when not available it falls back to using ioctls. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 4feb48d12295eb41850c39996f3a8c1dd7909ed5 tree dbb3

[IPROUTE 02/02]: VLAN support

2007-06-13 Thread Patrick McHardy
[IPROUTE]: VLAN support --- commit 90727b2bf5b4a7ef9d0638ca80206083b965a0b5 tree 173722acd855b7fe1eb1a5f22cf7706814f72c8f parent 4feb48d12295eb41850c39996f3a8c1dd7909ed5 author Patrick McHardy <[EMAIL PROTECTED]> Wed, 13 Jun 2007 18:46:21 +0200 committer Patrick McHardy <[EMAIL PROTECTED]> Wed, 13

[IPROUTE 00/02]: rtnl_link support

2007-06-13 Thread Patrick McHardy
Hi Stephen, these patches add support for the rtnl_link stuff and VLAN configuration to iproute. Since the old link configuration was entirely ioctl based and mixing the two would be really ugly, this patch keeps the old ioctl stuff guarded by an ifdef (defaults to enabled) and probes for support

Re: [patch 1/6] 8139too: force media setting cleanup

2007-06-13 Thread Kyuma Ohta
Hi, I was testing 2.6.22-rc4 from yesterday, but communication speed of 8139 side is very slower than 2.6.21.* (less than 10kbytes/sec at 100MBPS,FULL-DUPLEX). I was not test from 2.6.22-rc ,yesterday I started to test 2.6.22-rc. So, I *must* set HALF-DUPLEX to 8139 side below: ethtool -s ethx

[VLAN 18/18]: Use rtnl_link API

2007-06-13 Thread Patrick McHardy
[VLAN]: Use rtnl_link API Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit b4bb367897c114980367013f1a636bb6a9630a11 tree 8f1904816e27d07df5a7a910dc1e81a08215b490 parent 84bb1e021b6c3567bebccfc5e3dd4ab7d8f5bfae author Patrick McHardy <[EMAIL PROTECTED]> Wed, 06 Jun 2007 14:47:07 +0200

[VLAN 17/18]: Introduce symbolic constants for flag values

2007-06-13 Thread Patrick McHardy
[VLAN]: Introduce symbolic constants for flag values Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 84bb1e021b6c3567bebccfc5e3dd4ab7d8f5bfae tree 74f71648d2821cc86765694a7d41d94b39bffce4 parent fc3fa5f1275ec357ae719066eef18c51c186c2b9 author Patrick McHardy <[EMAIL PROTECTED]> Wed,

[VLAN 16/18]: Keep track of number of QoS mappings

2007-06-13 Thread Patrick McHardy
[VLAN]: Keep track of number of QoS mappings Keep track of the number of configured ingress/egress QoS mappings to avoid iteration while calculating the netlink attribute size. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit fc3fa5f1275ec357ae719066eef18c51c186c2b9 tree c1b3f59a240

[VLAN 15/18]: Use 32 bit value for skb->priority mapping

2007-06-13 Thread Patrick McHardy
[VLAN]: Use 32 bit value for skb->priority mapping skb->priority has only 32 bits and even VLAN uses 32 bit values in its API. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit a285e1ab7cfb856fc9e503eefd507eb7958b7524 tree 0f95eb6c73eedc66a305bb0ca5cd1ee1391b47d3 parent 5924a55528b3a

[VLAN 14/18]: Return proper error codes in register_vlan_device

2007-06-13 Thread Patrick McHardy
[VLAN]: Return proper error codes in register_vlan_device The returned device is unused, return proper error codes instead and avoid having the ioctl handler guess the error. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 5924a55528b3a6897ea49f4af9fa7dcefc50fd57 tree 5fe3152d604de

[VLAN 10/18]: Move some device intialization code to dev->init callback

2007-06-13 Thread Patrick McHardy
[VLAN]: Move some device intialization code to dev->init callback Move some device initialization code to new dev->init callback to make it shareable with netlink. Additionally this fixes a minor bug, dev->iflink is set after registration, which causes an incorrect value in the initial netlink mes

[VLAN 11/18]: Move vlan_group allocation to seperate function

2007-06-13 Thread Patrick McHardy
[VLAN]: Move vlan_group allocation to seperate function Move group allocation to a seperate function to clean up the code a bit and allocate groups before registering the device. Device registration is globally visible and causes netlink events, so we shouldn't fail afterwards. Signed-off-by: Pat

[VLAN 12/18]: Split up device checks

2007-06-13 Thread Patrick McHardy
[VLAN]: Split up device checks Move the checks of the underlying device to a seperate function. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 8defb0af6d2f31cfa6180b0b4c83124f5d90cb32 tree a460163ea31c953a60b894a24051deee5f401006 parent db130c75de212df303702758f553a7f4349ae56a aut

[VLAN 13/18]: Move device registation to seperate function

2007-06-13 Thread Patrick McHardy
[VLAN]: Move device registation to seperate function Move device registration and configuration of the underlying device to a seperate function. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 0bd5a42a938a42aa15a4e9ac01777d74653e7c8d tree e7ddfd00b19f52f1e04ad955fa3e4037485e0cdc pa

[VLAN 09/18]: Convert name-based configuration functions to struct netdevice *

2007-06-13 Thread Patrick McHardy
[VLAN]: Convert name-based configuration functions to struct netdevice * Move the device lookup and checks to the ioctl handler under the RTNL and change all name-based interfaces to take a struct net_device * instead. This allows to use them from a netlink interface, which identifies devices bas

[IFB 07/18]: Keep ifb devices on list

2007-06-13 Thread Patrick McHardy
[IFB]: Keep ifb devices on list Use a list instead of an array to allow creating new devices. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit cfbc876235237d990af80b7fc396f4458b5a1657 tree 1ebce533598ae9220b8e3edef269bd4f054961e7 parent 379884fb0587cd4832ecf8785467209885204124 autho

[IFB 08/18]: Use rtnl_link API

2007-06-13 Thread Patrick McHardy
[IFB]: Use rtnl_link API Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 7cd41b2caa4f124f84d6f458fe913de8e3b492a3 tree c62fa740c7e41ab388da72b67a4e4538ad97eda7 parent cfbc876235237d990af80b7fc396f4458b5a1657 author Patrick McHardy <[EMAIL PROTECTED]> Wed, 06 Jun 2007 14:46:22 +0200

[DUMMY 06/18]: Use rtnl_link API

2007-06-13 Thread Patrick McHardy
[DUMMY]: Use rtnl_link API Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 379884fb0587cd4832ecf8785467209885204124 tree 8bce1ffae7d2b2afabba9bc5ab2c7b06402c51c1 parent 18094391f33349687e35eaf0e768b18a71523100 author Patrick McHardy <[EMAIL PROTECTED]> Wed, 06 Jun 2007 14:46:12 +020

[DUMMY 05/18]: Keep dummy devices on list

2007-06-13 Thread Patrick McHardy
[DUMMY]: Keep dummy devices on list Use a list instead of an array to allow creating new devices. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 18094391f33349687e35eaf0e768b18a71523100 tree 8697434fd6ce5c2d16b4e823482ba9cf7ee8cea2 parent af03e9fd45eb64f27bcc2ac79d0d615e563100a9 a

[RTNETLINK 03/18]: Link creation API

2007-06-13 Thread Patrick McHardy
[RTNETLINK]: Link creation API Add rtnetlink API for creating, changing and deleting software devices. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 8a4171f86c516a43a7ed07f198c6cad2273ce2a7 tree 6bab9e96dd04c4ea13654fcda6a402a20a4f43c1 parent 806243b51e1f1607cec07f320dc9a8c3a70a8

[DUMMY 04/18]: Use dev->stats

2007-06-13 Thread Patrick McHardy
[DUMMY]: Use dev->stats Use dev->stats instead of netdev_priv(). Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit af03e9fd45eb64f27bcc2ac79d0d615e563100a9 tree 9a1aa56016d17805dd2b41e955fbb41d46d9c3f5 parent 8a4171f86c516a43a7ed07f198c6cad2273ce2a7 author Patrick McHardy <[EMAIL PRO

[RTNETLINK 02/18]: Split up rtnl_setlink

2007-06-13 Thread Patrick McHardy
[RTNETLINK]: Split up rtnl_setlink Split up rtnl_setlink into a function performing validation and a function performing the actual changes. This allows to share the modifcation logic with rtnl_newlink, which is introduced by the next patch. Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> ---

[NET 01/18]: Mark struct net_device * argument to netdev_priv const

2007-06-13 Thread Patrick McHardy
[NET]: Mark struct net_device * argument to netdev_priv const Signed-off-by: Patrick McHardy <[EMAIL PROTECTED]> --- commit 2c029e7d78d67b07e6cc138ded377021555a tree 415a297754ec7f62f3dfe46f22171de88aa22d2e parent 14e26eae98ec9a02ebb4b17ddb689f9b92d76ad7 author Patrick McHardy <[EMAIL PROTECT

[NET 00/18]: Netlink link creation API + driver conversions

2007-06-13 Thread Patrick McHardy
Hi Dave, these are the updated rtnl_link API patches and dummy, ifb and VLAN conversions. The documentation is not quite done yet, I'll finish it when I find some spare time. Changes since the last post: - fix attribute parsing after module load - fix module aliases - refuse all unsupported opti

  1   2   >