Re: [NET]: Share correct feature code between bridging and bonding

2007-08-21 Thread Herbert Xu
Hi: Here's the back-port for 2.6.22. [NET]: Share correct feature code between bridging and bonding http://bugzilla.kernel.org/show_bug.cgi?id=8797 shows that the bonding driver may produce bogus combinations of the checksum flags and SG/TSO. For example, if you bond devices with

[patch 03/20] sky2: restore workarounds for lost interrupts

2007-08-21 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Stephen Hemminger [EMAIL PROTECTED] Backport of commit c59697e06058fc2361da8cefcfa3de85ac107582 This patch restores a couple of workarounds from 2.6.16: * restart transmit moderation timer in case

[patch 04/20] sky2: carrier management

2007-08-21 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Stephen Hemminger [EMAIL PROTECTED] backport of commit 55d7b4e6ed6ad3ec5e5e30b3b4515a0a6a53e344 Make sky2 handle carrier similar to other drivers, eliminate some possible races in carrier state

[patch 05/20] sky2: check for more work before leaving NAPI

2007-08-21 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Stephen Hemminger [EMAIL PROTECTED] Backport of commit 5c11ce700f77fada15b6264417d72462da4bbb1c This patch avoids generating another IRQ if more packets arrive while in the NAPI poll routine.

[patch 06/20] sky2: check drop truncated packets

2007-08-21 Thread Greg KH
-stable review patch. If anyone has any objections, please let us know. -- From: Stephen Hemminger [EMAIL PROTECTED] Backport of commit 71749531f2d1954137a1a77422ef4ff29eb102dd If packet larger than MTU is received, the driver uses hardware to truncate the packet. Use the

Re: [ofa-general] Re: [PATCH RFC] RDMA/CMA: Allocate PS_TCP ports from the host TCP port space.

2007-08-21 Thread David Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Mon, 20 Aug 2007 18:16:54 -0700 And direct data placement really does give you a factor of two at least, because otherwise you're stuck receiving the data in one buffer, looking at some of the data at least, and then figuring out where to copy it.

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-21 Thread David Miller
From: Linus Torvalds [EMAIL PROTECTED] Date: Mon, 20 Aug 2007 22:46:47 -0700 (PDT) Ie a barrier() is likely _cheaper_ than the code generation downside from using volatile. Assuming GCC were ever better about the code generation badness with volatile that has been discussed here, I much

Re: [NET]: Share correct feature code between bridging and bonding

2007-08-21 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Tue, 21 Aug 2007 14:22:55 +0800 Hi: Here's the back-port for 2.6.22. [NET]: Share correct feature code between bridging and bonding http://bugzilla.kernel.org/show_bug.cgi?id=8797 shows that the bonding driver may produce bogus combinations of

Re: [PATCH] IPv6: Fix kernel panic while send SCTP data with IP fragments

2007-08-21 Thread David Miller
From: Wei Yongjun [EMAIL PROTECTED] Date: Mon, 20 Aug 2007 10:27:36 +0800 Hi Arnaldo Carvalho de Melo: Em Mon, Aug 20, 2007 at 09:28:27AM +0800, Wei Yongjun escreveu: If ICMP6 message with Packet Too Big is received after send SCTP DATA, kernel panic will occur when SCTP DATA is send

Re: [PATCH 2.6.22.3] ppp: fix output buffer size in ppp_decompress_frame

2007-08-21 Thread David Miller
From: Konstantin Sharlaimov [EMAIL PROTECTED] Date: Fri, 17 Aug 2007 20:45:51 +1100 This patch addresses the issue with osize too small errors in mppe encryption. The patch fixes the issue with wrong output buffer size being passed to ppp decompression routine. Signed-off-by: Konstantin

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

2007-08-21 Thread David Miller
From: Krishna Kumar2 [EMAIL PROTECTED] Date: Fri, 17 Aug 2007 11:36:03 +0530 I ran 3 iterations of 45 sec tests (total 1 hour 16 min, but I will run a longer one tonight). The results are (results in KB/s, and %): I ran a 8.5 hours run with no batching + another 8.5 hours run with

Re: [PATCH 1/1] ipv6: corrects sended rtnetlink message

2007-08-21 Thread David Miller
From: Milan Kocian [EMAIL PROTECTED] Date: Wed, 15 Aug 2007 16:33:22 +0200 ipv6 sends a RTM_DELLINK netlink message on both events: NETDEV_DOWN, NETDEV_UNREGISTER. Corrected by sending RTM_NEWLINK on NETDEV_DOWN event and RTM_DELLINK on NETDEV_UNREGISTER event. Why would we indicate that a

Re: [PATCH] improved xfrm_audit_log() patch

2007-08-21 Thread David Miller
From: Joy Latten [EMAIL PROTECTED] Date: Wed, 15 Aug 2007 11:16:29 -0500 On Tue, 2007-08-07 at 18:32 -0700, David Miller wrote: From: Joy Latten [EMAIL PROTECTED] Date: Thu, 2 Aug 2007 15:56:47 -0500 @@ -426,10 +426,15 @@ struct xfrm_audit }; #ifdef CONFIG_AUDITSYSCALL -extern

ppp dependency on slhc

2007-08-21 Thread Andrew Morton
ERROR: slhc_init [drivers/net/ppp_generic.ko] undefined! ERROR: slhc_free [drivers/net/ppp_generic.ko] undefined! ERROR: slhc_uncompress [drivers/net/ppp_generic.ko] undefined! ERROR: slhc_compress [drivers/net/ppp_generic.ko] undefined! ERROR: slhc_toss [drivers/net/ppp_generic.ko] undefined!

Re: [PATCH 6/7 v2] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

2007-08-21 Thread Vitaly Bordug
On Fri, 17 Aug 2007 13:17:18 -0500 Scott Wood wrote: The existing OF glue code was crufty and broken. Rather than fix it, it will be removed, and the ethernet driver now talks to the device tree directly. A bit short description, I'd rather expect some specific improvements list, that are

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-21 Thread Russell King
On Tue, Aug 21, 2007 at 01:02:01AM +0200, Segher Boessenkool wrote: And no, RMW on MMIO isn't problematic at all, either. An RMW op is a read op, a modify op, and a write op, all rolled into one opcode. But three actual operations. Maybe for some CPUs, but not all. ARM for instance can't

still not properly working multicast receiving at rtk8110SC (with 23rc3+ your patches)

2007-08-21 Thread Reither Robert
Hi Francois, i just tested the new kernel 2.6.23rc3 with and without your patches, i cannot find a difference to the behaviour of the previous state ... (22 + your patches) I still have a very unreliable receiving of multicast packets, only for about 1/3 of my join mc attempts or so i receive

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-21 Thread Russell King
On Mon, Aug 20, 2007 at 05:05:18PM -0700, Paul E. McKenney wrote: On Tue, Aug 21, 2007 at 01:02:01AM +0200, Segher Boessenkool wrote: And no, RMW on MMIO isn't problematic at all, either. An RMW op is a read op, a modify op, and a write op, all rolled into one opcode. But three actual

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-21 Thread Paul Mackerras
Russell King writes: Let me say it more clearly: On ARM, it is impossible to perform atomic operations on MMIO space. Actually, no one is suggesting that we try to do that at all. The discussion about RMW ops on MMIO space started with a comment attributed to the gcc developers that one

Re: ATA over ethernet swapping

2007-08-21 Thread Pavel Machek
Hi! But I'm able to compile kernel (-j 10) on 128MB machine, and I tried cat /dev/zero | grep foo to exhaust memory... and could not reproduce the deadlock. Should I pingflood? Tweak down ammount of atomic memory avaialable to make deadlocks easier to reproduce? I usually test swap

Re: [PATCH 2/4 - rev2] Add new timeval_to_sec function

2007-08-21 Thread Bob Beers
What if the name of the function was more descriptive of what the function actually does? Maybe timeval_ceil_sec()? - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-21 Thread Andi Kleen
On Tue, Aug 21, 2007 at 07:33:49PM +1000, Paul Mackerras wrote: So the whole discussion is irrelevant to ARM, PowerPC and any other architecture except x86[-64]. It's even irrelevant on x86 because all modifying operations on atomic_t are coded in inline assembler and will always be RMW no

Re: [PATCH 3/4 - rev 2] Initilize and populate age field

2007-08-21 Thread Thomas Graf
* Varun Chandramohan [EMAIL PROTECTED] 2007-08-20 13:46 The age field is filled with the current time at the time of creation of the route. When the routes are dumped then the age value stored in the route structure is subtracted from the current time value and the difference is the age

Re: PROBLEM: 2.6.23-rc NETDEV WATCHDOG: eth0: transmit timed out

2007-08-21 Thread Karl Meyer
fyi: I do not know whether it is related to the problem, but since using the version you told me there are these entries is my log: frege Hangcheck: hangcheck value past margin! frege Hangcheck: hangcheck value past margin! frege Hangcheck: hangcheck value past margin! 2007/8/16, Francois

ipv4_get_l4proto: Frag of proto 17

2007-08-21 Thread Meelis Roos
Yesterdays git snapsot on a normal home PC spams dmesg with the following line: ipv4_get_l4proto: Frag of proto 17 -- Meelis Roos ([EMAIL PROTECTED]) - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 2/4 - rev2] Add new timeval_to_sec function

2007-08-21 Thread Varun Chandramohan
Bob Beers wrote: What if the name of the function was more descriptive of what the function actually does? Maybe timeval_ceil_sec()? Looks ok, it can be done if everyone is ok with it. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH 3/4 - rev 2] Initilize and populate age field

2007-08-21 Thread Varun Chandramohan
Thomas Graf wrote: * Varun Chandramohan [EMAIL PROTECTED] 2007-08-20 13:46 The age field is filled with the current time at the time of creation of the route. When the routes are dumped then the age value stored in the route structure is subtracted from the current time value and the

Re: [PATCH 3/4 - rev 2] Initilize and populate age field

2007-08-21 Thread Thomas Graf
* Varun Chandramohan [EMAIL PROTECTED] 2007-08-21 16:52 I know its a bit confusing but let me explain the reason. In my first version patch i used fn_hash_insert() (place where alias is created)as place to insert my current time in the age field. This will eventually call fib_dump_info() for

Re: [PATCH 3/4 - rev 2] Initilize and populate age field

2007-08-21 Thread Varun Chandramohan
Thomas Graf wrote: * Varun Chandramohan [EMAIL PROTECTED] 2007-08-21 16:52 I know its a bit confusing but let me explain the reason. In my first version patch i used fn_hash_insert() (place where alias is created)as place to insert my current time in the age field. This will eventually

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

2007-08-21 Thread jamal
On Tue, 2007-21-08 at 00:18 -0700, David Miller wrote: Using 16K buffer size really isn't going to keep the pipe full enough for TSO. Why the comparison with TSO (or GSO for that matter)? Seems to me that is only valid/fair if you have a single flow. Batching is multi-flow focused (or i

[PATCH 1/2] qla3xxx: bugfix: Add memory barrier before accessing rx completion.

2007-08-21 Thread Ron Mercer
Signed-off-by: Ron Mercer [EMAIL PROTECTED] --- drivers/net/qla3xxx.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c index 69da95b..c3fe1c7 100755 --- a/drivers/net/qla3xxx.c +++ b/drivers/net/qla3xxx.c @@ -2248,6 +2248,7 @@

[PATCH 2/2] qla3xxx: bugfix: Fix VLAN rx completion handling.

2007-08-21 Thread Ron Mercer
Fix 4032 chip undocumented feature where bit-8 is set if the inbound completion is for a VLAN. Signed-off-by: Ron Mercer [EMAIL PROTECTED] --- drivers/net/qla3xxx.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/net/qla3xxx.c b/drivers/net/qla3xxx.c index

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-21 Thread Chris Snook
David Miller wrote: From: Linus Torvalds [EMAIL PROTECTED] Date: Mon, 20 Aug 2007 22:46:47 -0700 (PDT) Ie a barrier() is likely _cheaper_ than the code generation downside from using volatile. Assuming GCC were ever better about the code generation badness with volatile that has been

2.6.22 dev_base changes info request

2007-08-21 Thread Fortier,Vincent [Montreal]
Hi all, Sadly I have to use the Apani/Nortel cvc contivity linux client. The latest version (3.5) stopped being compatible with the latest stable 2.6.22 kernel. Since there will most probably not be a new release from apani until year 2013 we have hack the linux_wrapper.c file to try to keep

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-21 Thread Segher Boessenkool
And no, RMW on MMIO isn't problematic at all, either. An RMW op is a read op, a modify op, and a write op, all rolled into one opcode. But three actual operations. Maybe for some CPUs, but not all. ARM for instance can't use the load exclusive and store exclusive instructions to MMIO space.

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-21 Thread Segher Boessenkool
Let me say it more clearly: On ARM, it is impossible to perform atomic operations on MMIO space. Actually, no one is suggesting that we try to do that at all. The discussion about RMW ops on MMIO space started with a comment attributed to the gcc developers that one reason why gcc on x86

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-21 Thread Segher Boessenkool
At some point in the future, barrier() will be universally regarded as a hammer too big for most purposes. Whether or not removing it now You can't just remove it, it is needed in some places; you want to replace it in most places with a more fine-grained compiler barrier, I presume?

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-21 Thread Satyam Sharma
On Tue, 21 Aug 2007, Chris Snook wrote: David Miller wrote: From: Linus Torvalds [EMAIL PROTECTED] Date: Mon, 20 Aug 2007 22:46:47 -0700 (PDT) Ie a barrier() is likely _cheaper_ than the code generation downside from using volatile. Assuming GCC were ever better about the

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-21 Thread Paul E. McKenney
On Tue, Aug 21, 2007 at 04:48:51PM +0200, Segher Boessenkool wrote: Let me say it more clearly: On ARM, it is impossible to perform atomic operations on MMIO space. Actually, no one is suggesting that we try to do that at all. The discussion about RMW ops on MMIO space started with a

[PATCH 0/1] net/core: Crash in dev_mc_sync() when putting macvlan interface up

2007-08-21 Thread Benjamin Thery
Hi, My kernel crashed while testing macvlan interfaces on 2.6.23-rc2. (See kernel panic below) The culprit is dev_mc_sync(). In this routine, we delete elements from 'from-mc_list' unsafely. While going through the list, we may delete one of the element (__dev_addr_delete(from-mc_list,...)),

[PATCH 1/1] net/core: Fix crash in dev_mc_sync()/dev_mc_unsync()

2007-08-21 Thread Benjamin Thery
This patch fixes a crash that may occur when the routine dev_mc_sync() deletes an address from the list it is currently going through. It saves the pointer to the next element before deleting the current one. The problem may also exist in dev_mc_unsync(). Signed-off-by: Benjamin Thery [EMAIL

Re: [PATCH 6/7 v2] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

2007-08-21 Thread Scott Wood
Vitaly Bordug wrote: On Fri, 17 Aug 2007 13:17:18 -0500 Scott Wood wrote: The existing OF glue code was crufty and broken. Rather than fix it, it will be removed, and the ethernet driver now talks to the device tree directly. A bit short description, I'd rather expect some specific

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-21 Thread Linus Torvalds
On Tue, 21 Aug 2007, Chris Snook wrote: Moore's law is definitely working against us here. Register counts, pipeline depths, core counts, and clock multipliers are all increasing in the long run. At some point in the future, barrier() will be universally regarded as a hammer too big for

[RFT] sky2: yukon-ec-u phy power problems

2007-08-21 Thread Stephen Hemminger
The sky2 driver clears some bits in the PHY control register, that cause the PHY interface to get changed. Some of these deal with voltage and power savings as well. This may explain some of the failures on Gigabyte DS-3 motherboard. The clue to possible problem was looking at why

[PATCH] sky2: don't clear phy power bits

2007-08-21 Thread Stephen Hemminger
There are special PHY settings available on Yukon EC-U chip that should not get cleared. The reset bits are in the least significant bits, so that is all that needs to be set. This should solve mysterious errors on some motherboards (like Gigabyte DS-3). Signed-off-by: Stephen Hemminger [EMAIL

[PATCH] sky2: don't clear phy power bits

2007-08-21 Thread Stephen Hemminger
There are special PHY settings available on Yukon EC-U chip that should not get cleared. This should solve mysterious errors on some motherboards (like Gigabyte DS-3). Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/drivers/net/sky2.c2007-08-21 11:08:27.0 -0700 +++

Re: [PATCH] sky2: don't clear phy power bits

2007-08-21 Thread Linus Torvalds
On Tue, 21 Aug 2007, Stephen Hemminger wrote: There are special PHY settings available on Yukon EC-U chip that should not get cleared. This should solve mysterious errors on some motherboards (like Gigabyte DS-3). Ok, applied. However: - now all accesses to GPHY_CTRL are 8-bit (it used

Re: [Bugme-new] [Bug 8914] New: filter attached to prio qdisc breaks priomap handling of packets it does _not_ match

2007-08-21 Thread Andrew Morton
On Tue, 21 Aug 2007 05:32:57 -0700 (PDT) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=8914 Summary: filter attached to prio qdisc breaks priomap handling of packets it does _not_ match Product: Networking Version:

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

2007-08-21 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Tue, 21 Aug 2007 08:30:22 -0400 On Tue, 2007-21-08 at 00:18 -0700, David Miller wrote: Using 16K buffer size really isn't going to keep the pipe full enough for TSO. Why the comparison with TSO (or GSO for that matter)? Because TSO does batching

Re: [PATCH] sky2: don't clear phy power bits

2007-08-21 Thread Stephen Hemminger
On Tue, 21 Aug 2007 11:26:23 -0700 (PDT) Linus Torvalds [EMAIL PROTECTED] wrote: On Tue, 21 Aug 2007, Stephen Hemminger wrote: There are special PHY settings available on Yukon EC-U chip that should not get cleared. This should solve mysterious errors on some motherboards (like

[RFT] r8169 changes against 2.6.23-rc3

2007-08-21 Thread Bruce Cole
On 8/20/07, Dirk wrote: So it seems that when the driver tries to queue a packet while the controller is busy processing the queue, the newly queued packet does not get noticed by the controller (until further packet activity occurs). Perhaps there is a problem with the memory barriers when

Oops in 2.6.22.1: skb_copy_and_csum_datagram_iovec()

2007-08-21 Thread Chuck Ebbert
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=253290 18:57:54 osama kernel: BUG: unable to handle kernel NULL pointer dereference at virtual address 0004 18:57:54 osama kernel: printing eip: 18:57:54 osama kernel: c05c4026 18:57:54 osama kernel: *pde = 1d860067 18:57:54 osama kernel:

Re: Linksys Gigabit USB2.0 adapter (asix) regression

2007-08-21 Thread David Hollis
On Mon, 2007-08-20 at 18:23 +0200, Erik Slagter wrote: /* if ((eeprom 8) != 1) { asix_write_gpio(dev, 0x003c, 30); asix_write_gpio(dev, 0x001c, 300); asix_write_gpio(dev, 0x003c, 30); } else { */

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

2007-08-21 Thread jamal
On Tue, 2007-21-08 at 11:51 -0700, David Miller wrote: Because TSO does batching already, so it's a very good tit for tat comparison of the new batching scheme vs. an existing one. Fair enough - I may have read too much into your email then;- For bulk type of apps (where TSO will make a

[PATCH 3/3] sky2 1.17

2007-08-21 Thread Stephen Hemminger
Mark new version to track if current driver is in use. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/drivers/net/sky2.c2007-08-21 10:36:58.0 -0700 +++ b/drivers/net/sky2.c2007-08-21 10:44:22.0 -0700 @@ -51,7 +51,7 @@ #include sky2.h #define DRV_NAME

[PATCH 1/3] sky2: clear PCI power control reg at startup

2007-08-21 Thread Stephen Hemminger
Make sure PCI register for PHY power gets cleared on boot, and make sure to avoid any PCI posting problems. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/drivers/net/sky2.c2007-08-21 10:17:59.0 -0700 +++ b/drivers/net/sky2.c2007-08-21 10:18:02.0 -0700

[PATCH 0/3] sky2 update for 2.6.23

2007-08-21 Thread Stephen Hemminger
These patches address some issues that got listed as regressions in 2.6.23. -- Stephen Hemminger [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/3] sky2: only bring up watchdog if link is active

2007-08-21 Thread Stephen Hemminger
This fixes the extra timer overhead that people were whining about as a 2.6.23 regression. Running the watchdog timer all the time is unneeded. Change it to run only if link is up, and reduce frequency to save power. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- a/drivers/net/sky2.c

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

2007-08-21 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Tue, 21 Aug 2007 17:09:12 -0400 Examples, a busy ssh or irc server and you could go as far as looking at the most pre-dominant app on the wild west, http (average page size from a few years back was in the range of 10-20K and can be simulated with good ole

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-21 Thread Valdis . Kletnieks
On Tue, 21 Aug 2007 09:16:43 PDT, Paul E. McKenney said: I agree that instant gratification is hard to come by when synching up compiler and kernel versions. Nonetheless, it should be possible to create APIs that are are conditioned on the compiler version. We've tried that, sort of. See

[NET]: Don't do netpoll on per cpu backlog napi struct

2007-08-21 Thread Thomas Graf
The per cpu backlog napi struct can't do netpoll and has the dev member set to NULL. Fixes an oops on boot when netpoll is enabled. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Index: net-2.6.24/include/linux/netpoll.h === ---

Re: [NET]: Don't do netpoll on per cpu backlog napi struct

2007-08-21 Thread David Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 01:08:51 +0200 The per cpu backlog napi struct can't do netpoll and has the dev member set to NULL. Fixes an oops on boot when netpoll is enabled. Signed-off-by: Thomas Graf [EMAIL PROTECTED] Applied, thanks a lot Thomas. - To

Re: [Cbe-oss-dev] [PATCH] spidernet: fix interrupt reason recognition

2007-08-21 Thread Ishizaki Kou
Linas Vepstas wrote: On Mon, Aug 20, 2007 at 10:13:27PM +0900, Ishizaki Kou wrote: Please apply this to 2.6.23. I'll review and forward shortly. Kick me if you don't see a formal reply in a few days. And also, please apply the following Arnd-san's patch to fix a problem that

[PATCH] spidernet: enable poll() before registering interrupts

2007-08-21 Thread Ishizaki Kou
We must not call netif_poll_enable after enabling interrupts, because an interrupt might come in and set the __LINK_STATE_RX_SCHED bit before we get to clear that bit again. If that happens, the next call to the -poll() function will oops. Signed-off-by: Arnd Bergmann [EMAIL PROTECTED]

Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures

2007-08-21 Thread Paul E. McKenney
On Tue, Aug 21, 2007 at 06:51:16PM -0400, [EMAIL PROTECTED] wrote: On Tue, 21 Aug 2007 09:16:43 PDT, Paul E. McKenney said: I agree that instant gratification is hard to come by when synching up compiler and kernel versions. Nonetheless, it should be possible to create APIs that are are

[PATCH 0/11] cxgb3 - driver updates

2007-08-21 Thread Divy Le Ray
Jeff, I'm resubmitting the last cxgb3 patch series against netdev-2.6#upstream, minus the first patch that you already applied and the last patch. Here is a brief description: - Modify max HW Rx coalescing size - Log SGE doorbell Fifo overflow - Use Tx immediate data for

[PATCH 1/11 RESEND] cxgb3 - Update rx coalescing length

2007-08-21 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Reduce Rx coalescing length to 12288 Large bursts from the adapter to the host create back pressure on the chip. Reducing the burst size avoids the issue. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/common.h |2 +- 1 files changed,

[PATCH 2/11 RESEND] cxgb3 - SGE doorbell overflow warning

2007-08-21 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Log doorbell Fifo overflow Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/regs.h |8 drivers/net/cxgb3/sge.c |4 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/net/cxgb3/regs.h

[PATCH 3/11 RESEND] cxgb3 - use immediate data for offload Tx

2007-08-21 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Send small TX_DATA work requests as immediate data even when there are fragments. this avoids doing multiple DMAs for small fragmented packets. The driver already implements this optimization for small contiguous packets. Signed-off-by: Divy Le Ray [EMAIL

[PATCH 4/11 RESEND] cxgb3 - Expose HW memory page info

2007-08-21 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] A HW issue requires limiting the receive window size to 23 pages of internal memory. These pages can be configured to different sizes, thus the RDMA driver needs to know the page size to enforce the upper limit. Also assign explicit enum values.

[PATCH 5/11 RESEND] cxgb3 - tighten checks on TID values

2007-08-21 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Enforce validity checks on connection ids Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/cxgb3_defs.h| 20 ++-- drivers/net/cxgb3/cxgb3_offload.c | 28 +++- 2 files changed, 41

[PATCH 6/11 RESEND] cxgb3 - Fatal error update

2007-08-21 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Stop the MAC when a fatal error is detected. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/cxgb3_main.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/net/cxgb3/cxgb3_main.c

[PATCH 7/11 RESEND] cxgb3 - log adapter serial number

2007-08-21 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Log HW serial number when cxgb3 module is loaded. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/common.h |2 ++ drivers/net/cxgb3/cxgb3_main.c |6 -- drivers/net/cxgb3/t3_hw.c |3 ++- 3 files changed, 8

[PATCH 8/11] cxgb3 - Update internal memory management

2007-08-21 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Set PM1 internal memory to round robin mode It balances access to this internal memory for multiport adapters. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/regs.h |2 ++ drivers/net/cxgb3/t3_hw.c |2 ++ 2 files changed, 4

[PATCH 9/11] cxgb3 - engine microcode update

2007-08-21 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Load microcode engine when the interface is configured up. Bump up version to 1.1.0. Allow the driver to be and running with older microcode images. Allow ethtool to log the microcode version. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] ---

[PATCH 10/11] cxgb3 - Firmware update

2007-08-21 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Update firmware version Allow the driver to be up and running with older FW image Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/common.h |2 +- drivers/net/cxgb3/cxgb3_main.c |9 + drivers/net/cxgb3/t3_hw.c |

[PATCH 11/11] cxgb3 - log and clear PEX errors

2007-08-21 Thread Divy Le Ray
From: Divy Le Ray [EMAIL PROTECTED] Clear pciE PEX errors late at module load time. Log details when PEX errors occur. Signed-off-by: Divy Le Ray [EMAIL PROTECTED] --- drivers/net/cxgb3/t3_hw.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

2007-08-21 Thread Krishna Kumar2
David Miller [EMAIL PROTECTED] wrote on 08/22/2007 12:21:43 AM: From: jamal [EMAIL PROTECTED] Date: Tue, 21 Aug 2007 08:30:22 -0400 On Tue, 2007-21-08 at 00:18 -0700, David Miller wrote: Using 16K buffer size really isn't going to keep the pipe full enough for TSO. Why the

Re: [PATCH 0/9 Rev3] Implement batching skb API and support in IPoIB

2007-08-21 Thread David Miller
From: Krishna Kumar2 [EMAIL PROTECTED] Date: Wed, 22 Aug 2007 09:41:52 +0530 David Miller [EMAIL PROTECTED] wrote on 08/22/2007 12:21:43 AM: From: jamal [EMAIL PROTECTED] Date: Tue, 21 Aug 2007 08:30:22 -0400 On Tue, 2007-21-08 at 00:18 -0700, David Miller wrote: Using 16K

Re: [RFT] r8169 changes against 2.6.23-rc3

2007-08-21 Thread Bruce Cole
So I did some experimenting with locking, but eventually found that this chunk: @@ -2677,10 +2681,18 @@ static void rtl8169_tx_interrupt(struct net_device *dev, if (tp-dirty_tx != dirty_tx) { tp-dirty_tx = dirty_tx; - -smp_wmb(); - -if (netif_queue_stopped(dev) -