Re: [RFC PATCH 8/8] [PKTGEN]: uninline getCurUs

2008-01-13 Thread David Miller
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> Date: Mon, 14 Jan 2008 09:43:08 +0200 (EET) > So which test case you prefer? :-) Is iso-8859-1 from+content ok? Or > should I keep trying to live with mixed utf-8 which I didn't got even > fully working last time because git-send-email is probably either

Re: [RFC PATCH 8/8] [PKTGEN]: uninline getCurUs

2008-01-13 Thread Ilpo Järvinen
On Sat, 12 Jan 2008, David Miller wrote: > From: "Ilpo_Järvinen" <[EMAIL PROTECTED]> > Date: Sat, 12 Jan 2008 14:59:50 +0200 (EET) > > > ...Maybe I just fall-back to changing my last name, it's the only > > full-proof solution... ;-) > > Don't do this! Otherwise I won't have a frequent test ca

Re: [PATCH 1/8] [TCP]: Uninline tcp_set_state

2008-01-13 Thread Ilpo Järvinen
On Sat, 12 Jan 2008, Stephen Hemminger wrote: > On Sat, 12 Jan 2008 11:40:10 +0200 > "Ilpo Järvinen" <[EMAIL PROTECTED]> wrote: ...snip... > > built-in.o: > > 12 functions changed, 250 bytes added, 1695 bytes removed, diff: -1445 ...snip... > > include/net/tcp.h | 35 +-

Re: [TOKENRING]: rif_timer not initialized properly

2008-01-13 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Mon, 14 Jan 2008 07:30:00 +0100 > Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> Applied to net-2.6, thanks Eric. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [FIB]: full_children & empty_children should be uint, not ushort

2008-01-13 Thread David Miller
From: Robert Olsson <[EMAIL PROTECTED]> Date: Sun, 13 Jan 2008 23:02:11 +0100 > > Eric Dumazet writes: > > Eric Dumazet a écrit : > > > 4) full_children & empty_children being 'unsigned short', > > >we probably are limited to 2^15 elements, but I could not > > >find this limit enforce

[TOKENRING]: rif_timer not initialized properly

2008-01-13 Thread Eric Dumazet
Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> diff --git a/net/802/tr.c b/net/802/tr.c index a2bd0f2..1e115e5 100644 --- a/net/802/tr.c +++ b/net/802/tr.c @@ -642,7 +642,7 @@ struct net_device *alloc_trdev(int sizeof_priv) static int __init rif_init(void) { init_timer(&rif_timer); -

Re: [AX25]: sparse cleanups

2008-01-13 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Sun, 13 Jan 2008 12:01:28 +0100 > net/ax25/ax25_route.c:251:13: warning: context imbalance in > 'ax25_rt_seq_start' - wrong count at exit > net/ax25/ax25_route.c:276:13: warning: context imbalance in > 'ax25_rt_seq_stop' > - unexpected unlock > net/a

Re: [X25]: Avoid divides and sparse warnings

2008-01-13 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Sun, 13 Jan 2008 11:33:01 +0100 >CHECK net/x25/af_x25.c > net/x25/af_x25.c:117:46: warning: expensive signed divide >CHECK net/x25/x25_facilities.c > net/x25/x25_facilities.c:209:30: warning: expensive signed divide >CHECK net/x25/x25_

Re: sparc oops in ip_fast_csum

2008-01-13 Thread David Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Mon, 14 Jan 2008 07:09:22 +0100 > But I agree to your suggestion, that will allow us to properly > handle packets with IP options. I'll take care of this. Thanks a lot Patrick. -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: sparc oops in ip_fast_csum

2008-01-13 Thread Patrick McHardy
Herbert Xu wrote: Patrick, please have a look at the former. In fact it's not just that ihl may be bogus (which might be harmless as long as the REJECT hook only gets called from within the IP stack), I think REJECT would also do the wrong thing if the packet had IP options. So perhaps we shoul

Re: Netperf TCP_RR(loopback) 10% regression in 2.6.24-rc6, comparing with 2.6.22

2008-01-13 Thread Zhang, Yanmin
On Fri, 2008-01-11 at 09:56 -0800, Rick Jones wrote: > >>The test command is: > >>#sudo taskset -c 7 ./netserver > >>#sudo taskset -c 0 ./netperf -t TCP_RR -l 60 -H 127.0.0.1 -i 50,3 -I 99,5 > >>-- -r 1,1 > > A couple of comments/questions on the command lines: Thanks for your kind comments. >

Re: Netconf at conf.au 2008?

2008-01-13 Thread David Miller
From: martin f krafft <[EMAIL PROTECTED]> Date: Sun, 13 Jan 2008 19:17:51 +0100 > also sprach Andy Johnson <[EMAIL PROTECTED]> [2008.01.12.0752 +0100]: > > I saw somewhere (maybe in this mailing list a while ago) that > > there might be a Linux Kernel Developers' Netconf conference at > > conf.a

Re: [PATCH] fib_semantics: prevent long hash chains in access server config

2008-01-13 Thread David Miller
From: Benjamin LaHaise <[EMAIL PROTECTED]> Date: Sun, 13 Jan 2008 12:58:49 -0500 > Ah, you're right indeed. It's probably easier for me to change how the > daemon adds the local ip address for these point to point interfaces. I guess you didn't understand, I checked in the following patch which

Re: Netconf at conf.au 2008?

2008-01-13 Thread David Miller
From: Glen Turner <[EMAIL PROTECTED]> Date: Mon, 14 Jan 2008 01:23:45 +1030 > > On Sat, 2008-01-12 at 08:52 +0200, Andy Johnson wrote: > > I saw somewhere (maybe in this mailing list a while ago) that there > > might be a Linux Kernel Developers' Netconf conference at conf.au > > 2008. > > > >

Re: Top 10 kernel oopses for the week ending January 5th, 2008

2008-01-13 Thread Neil Brown
On Thursday January 10, [EMAIL PROTECTED] wrote: > On Thu, Jan 10, 2008 at 03:13:48PM +1100, Neil Brown wrote: > > > What guarantees that it doesn't happen before we get to callback? AFAICS, > > > nothing whatsoever... > > > > Yes, that's bad isn't it :-) > > > > I think I should be using sysfs_

Re: [Bugme-new] [Bug 9721] New: wake on lan fails with sky2 module

2008-01-13 Thread supersud501
Rafael J. Wysocki wrote: I wonder if commit 84cd2dfb04d23a961c5f537baa243fa54d0987ac "sky2: remove check for PCI wakeup setting from BIOS" has anything to do with it, btw. supersud501, can you please check if the bug is still present in the current Linus' tree? I checked it (after git pulli

Re: [PATCH 0/4] Pull request for 'ipg-fixes' branch

2008-01-13 Thread Francois Romieu
Francois Romieu <[EMAIL PROTECTED]> : > Jeff Garzik <[EMAIL PROTECTED]> : > > Francois Romieu wrote: > [...] > >> Distance from 'net-2.6/master' (27d1cba21fcc50c37eef5042c6be9fa7135e88fc) > >> - > [...] > > hrm... tried to pull

[FIB]: full_children & empty_children should be uint, not ushort

2008-01-13 Thread Robert Olsson
Eric Dumazet writes: > Eric Dumazet a écrit : > > 4) full_children & empty_children being 'unsigned short', > >we probably are limited to 2^15 elements, but I could not > >find this limit enforced somewhere. > Two fixes are possible : Enlarge full_children & empty_children to 32bits,

Re: 2.6.24-rc6-mm1 - oddness with IPv4/v6 mapped sockets hanging...

2008-01-13 Thread Herbert Xu
[EMAIL PROTECTED] wrote: > > Any ideas? Please provide a packet dump on both sides (or at least the sender side). Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.or

Re: [PATCH v2] Documentation: add a guideline for hard_start_xmit method

2008-01-13 Thread Herbert Xu
Matti Linnanvuori <[EMAIL PROTECTED]> wrote: > > -3) Do not forget that once you return 0 from your hard_start_xmit > +3) A hard_start_xmit method must not modify the shared parts of the SKB. Only if it's cloned. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~}

Re: [Bugme-new] [Bug 9721] New: wake on lan fails with sky2 module

2008-01-13 Thread Rafael J. Wysocki
I wonder if commit 84cd2dfb04d23a961c5f537baa243fa54d0987ac "sky2: remove check for PCI wakeup setting from BIOS" has anything to do with it, btw. supersud501, can you please check if the bug is still present in the current Linus' tree? -- To unsubscribe from this list: send the line "unsubscribe

Re: [Bugme-new] [Bug 9721] New: wake on lan fails with sky2 module

2008-01-13 Thread Rafael J. Wysocki
On Sunday, 13 of January 2008, Andrew Morton wrote: > > 2.6.23 also has this warning in sky2_err_intr() but it doesn't trigger > there. Rafael, I think we'd have to class this as a post-2.6.23 > regression. Yes, it's been being tracked already. -- To unsubscribe from this list: send the line "un

Re: [Bugme-new] [Bug 9721] New: wake on lan fails with sky2 module

2008-01-13 Thread Andrew Morton
On Sun, 13 Jan 2008 21:27:40 +0100 supersud501 <[EMAIL PROTECTED]> wrote: > > > Andrew Morton wrote: > > > > So simply reverting this: > > > > commit ac93a3946b676025fa55356180e8321639744b31 > > Author: Stephen Hemminger <[EMAIL PROTECTED]> > > Date: Mon Nov 5 15:52:08 2007 -0800 > > > >

Re: [Bugme-new] [Bug 9721] New: wake on lan fails with sky2 module

2008-01-13 Thread supersud501
Andrew Morton wrote: So simply reverting this: commit ac93a3946b676025fa55356180e8321639744b31 Author: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon Nov 5 15:52:08 2007 -0800 sky2: enable PCI config writes On some boards, PCI configuration space access is turned off by defau

Re: [PATCH 2.6.23+] ingress classify to [nf]mark

2008-01-13 Thread jamal
Hi, Please CC me in your responses (the way i do when i respond to you), that way my filters prioritize your email. On Sat, 2008-12-01 at 15:56 -0200, Dzianis Kahanovich wrote: > I in doubts only about "action continue". > To "and/or" behaviour one of best usage are (example): I dont think you

Re: [Bugme-new] [Bug 9721] New: wake on lan fails with sky2 module

2008-01-13 Thread Andrew Morton
On Sun, 13 Jan 2008 16:08:38 +0100 supersud501 <[EMAIL PROTECTED]> wrote: > > > supersud501 wrote: > > > > > > Rafael J. Wysocki wrote: > > > >> > >> Since it seems to be 100% reproducible, it would be very helpful if > >> you could > >> use git-bisect to identify the offending commit. > >>

Re: Netconf at conf.au 2008?

2008-01-13 Thread martin f krafft
also sprach Andy Johnson <[EMAIL PROTECTED]> [2008.01.12.0752 +0100]: > I saw somewhere (maybe in this mailing list a while ago) that > there might be a Linux Kernel Developers' Netconf conference at > conf.au 2008. I think you may be mixing things up, and it may be my fault in ways. I am develo

[FIB]: full_children & empty_children should be uint, not ushort

2008-01-13 Thread Eric Dumazet
Eric Dumazet a écrit : 4) full_children & empty_children being 'unsigned short', we probably are limited to 2^15 elements, but I could not find this limit enforced somewhere. Hi David In my testings, I found that once a tnode is built with 2^16 slots (or more), it cannot be freed. Ext

Re: [PATCH] fib_semantics: prevent long hash chains in access server config

2008-01-13 Thread Benjamin LaHaise
On Sat, Jan 12, 2008 at 09:38:57PM -0800, David Miller wrote: > And guess why we don't do this? Because it's not part of > the key. Other aspects of the base fib_info and nexthops > provide the uniqueness, not the devindex of the first hop. > > So you'll need to find another way to do this. Ah,

Re: [PATCH 0/4] Pull request for 'ipg-fixes' branch

2008-01-13 Thread Francois Romieu
Jeff Garzik <[EMAIL PROTECTED]> : > Francois Romieu wrote: [...] >> Distance from 'net-2.6/master' (27d1cba21fcc50c37eef5042c6be9fa7135e88fc) >> - [...] > hrm... tried to pull this, but received non-ipg stuff too It is based o

possible recursive locking, 2.6.24-rc7

2008-01-13 Thread Denys Fedoryshchenko
Hi, got in dmesg Not sure where to send (there is TCP), so sending netdev@ and kernel@ [159859.491752] [159859.491755] = [159859.492021] [ INFO: possible recursive locking detected ] [159859.492156] 2.6.24-rc7-devel #2 [159859.492284] --

Re: [PATCH/RFC] synchronize_rcu(): high latency on idle system

2008-01-13 Thread Andi Kleen
> I think it should be in netdev_unregister_kobject(). But that would > only get rid of one of the two calls to synchronize_rcu() in the > unregister_netdev. Would be already an improvement. > The other synchronize_rcu() is for qdisc's and not sure if that one can > be removed? The standard w

Re: [Bugme-new] [Bug 9721] New: wake on lan fails with sky2 module

2008-01-13 Thread supersud501
supersud501 wrote: Rafael J. Wysocki wrote: Since it seems to be 100% reproducible, it would be very helpful if you could use git-bisect to identify the offending commit. allright, bisect found the offending commit, here's what i've done: first i started bisect with the following com

Re: Netconf at conf.au 2008?

2008-01-13 Thread Glen Turner
On Sat, 2008-01-12 at 08:52 +0200, Andy Johnson wrote: > I saw somewhere (maybe in this mailing list a while ago) that there > might be a Linux Kernel Developers' Netconf conference at conf.au > 2008. > > Does anyone here know if such a thing is planned ? Hi Andy, I don't know. However this

Re: [Bugme-new] [Bug 9721] New: wake on lan fails with sky2 module

2008-01-13 Thread supersud501
Rafael J. Wysocki wrote: Since it seems to be 100% reproducible, it would be very helpful if you could use git-bisect to identify the offending commit. allright, bisect found the offending commit, here's what i've done: first i started bisect with the following command (since i assumed it

[RFC][PATCH] Fixing SA/SP dumps on netlink/af_key

2008-01-13 Thread Timo Teräs
Hi all, The problem with IPsec SP/SA dumping is that they don't work well with large SPD/SADB:s. In netlink the dumping code is O(n^2) and can miss some entries/dump duplicates if the DB is changed between the recv() calls to read the dump entries. This is due to the entry index counting done i

[AX25]: sparse cleanups

2008-01-13 Thread Eric Dumazet
net/ax25/ax25_route.c:251:13: warning: context imbalance in 'ax25_rt_seq_start' - wrong count at exit net/ax25/ax25_route.c:276:13: warning: context imbalance in 'ax25_rt_seq_stop' - unexpected unlock net/ax25/ax25_std_timer.c:65:25: warning: expensive signed divide net/ax25/ax25_uid.c:46:1: war

[X25]: Avoid divides and sparse warnings

2008-01-13 Thread Eric Dumazet
CHECK net/x25/af_x25.c net/x25/af_x25.c:117:46: warning: expensive signed divide CHECK net/x25/x25_facilities.c net/x25/x25_facilities.c:209:30: warning: expensive signed divide CHECK net/x25/x25_in.c net/x25/x25_in.c:250:26: warning: expensive signed divide CHECK net/x25/x25_proc.

Re: [PATCH] Add me as maintainer of the RDC r6040 driver

2008-01-13 Thread Florian Fainelli
Hi Jeff, Le samedi 12 janvier 2008, Jeff Garzik a écrit : > applied Thank you. I think you will get this change twice when you pull Francoi's netdev-2.6 repository which has the r6040 patches I sent already. -- Cordialement, Florian Fainelli -- -- To unsubscribe fro

Re: sky2 driver stopped working after upgrading from 2.6.18-4

2008-01-13 Thread Andrew Paprocki
It appears this problem might be caused by the system HPET timer not functioning properly. I was noticing strange behavior in my rc0.d shutdown scripts where the script would freeze in a 'sleep 1'. Sure enough, even running a 'sleep 1' form a normal prompt just made the system hang indefinitely (un

Re: [FIB]: removes a memset() call in tnode_new()

2008-01-13 Thread David Miller
From: Eric Dumazet <[EMAIL PROTECTED]> Date: Sun, 13 Jan 2008 08:35:07 +0100 > tnode_alloc() already clears allocated memory, using kcalloc() > or alloc_pages(GFP_KERNEL|__GFP_ZERO, ...) > > Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]> Applied, thanks Eric. -- To unsubscribe from this list: s

sky2 driver stopped working after upgrading from 2.6.18-4

2008-01-13 Thread Andrew Paprocki
I have never been able to get my Yukon-EC Ultra (0xb4) rev 2 working on anything past 2.6.18-4 that I've tried. (All ~.20+) Below is the debug output from the driver on both versions. Notice the 'phy interrupt status' that each version prints out in case it is involved in the problem: 2.6.18-4: