Re: [PATCH v4 net-next 04/11] net: Get skb hash over flow_keys structure

2015-05-21 Thread Jiri Pirko
Fri, May 22, 2015 at 02:11:39AM CEST, t...@herbertland.com wrote: >This patch changes flow hashing to use jhash2 over the flow_keys >structure instead just doing jhash_3words over src, dst, and ports. >This method will allow us take more input into the hashing function >so that we can include full

Re: [PATCH 5/7] esp6: Switch to new AEAD interface

2015-05-21 Thread Herbert Xu
On Fri, May 22, 2015 at 08:40:25AM +0200, Stephan Mueller wrote: > > If I may ask, where in your initial patch set is now decided that the IV > generator is used (i.e. so that the givcrypt API is not needed any more)? Please see https://www.mail-archive.com/linux-crypto@vger.kernel.org/msg14270.

Re: [PATCH 5/7] esp6: Switch to new AEAD interface

2015-05-21 Thread Stephan Mueller
Am Donnerstag, 21. Mai 2015, 18:44:03 schrieb Herbert Xu: Hi Herbert, >- aead_givcrypt_set_callback(req, 0, esp_output_done, skb); >- aead_givcrypt_set_crypt(req, sg, sg, clen, iv); >- aead_givcrypt_set_assoc(req, asg, assoclen); >- aead_givcrypt_set_giv(req, esph->enc_data, >

Re: [PATCH v4 net-next 03/11] net: Remove superfluous setting of key_basic

2015-05-21 Thread Jiri Pirko
Fri, May 22, 2015 at 02:11:38AM CEST, t...@herbertland.com wrote: >key_basic is set twice in __skb_flow_dissect which seems unnecessary. >Remove second one. > >Signed-off-by: Tom Herbert I have the same patch in my queue :) Acked-by: Jiri Pirko -- To unsubscribe from this list: send the line "u

Re: [PATCH v4 net-next 02/11] mpls: Add definition for IPPROTO_MPLS

2015-05-21 Thread Jiri Pirko
Fri, May 22, 2015 at 02:11:37AM CEST, t...@herbertland.com wrote: >Add uapi define for MPLS over IP. > >Signed-off-by: Tom Herbert Acked-by: Jiri Pirko -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info a

Re: [PATCH v4 net-next 01/11] net: Simplify GRE case in flow_dissector

2015-05-21 Thread Jiri Pirko
Fri, May 22, 2015 at 02:11:36AM CEST, t...@herbertland.com wrote: >Do break when we see routing flag or a non-zero version number in GRE >header. > >Signed-off-by: Tom Herbert Acked-by: Jiri Pirko -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to ma

[PATCH net-next] tcp: fix a potential deadlock in tcp_get_info()

2015-05-21 Thread Eric Dumazet
From: Eric Dumazet Taking socket spinlock in tcp_get_info() can deadlock, as inet_diag_dump_icsk() holds the &hashinfo->ehash_locks[i], while packet processing can use the reverse locking order. We could avoid this locking for TCP_LISTEN states, but lockdep would certainly get confused as all TC

Re: [PATCH net-next] Better handling of transition to NUD_PROBE state

2015-05-21 Thread Erik Kline
> Please, in the future, put a proper subsystem prefix in the Subject > line of your patch submissions. In this particular case "neigh: " > would have been appropriate and is what I added when applying your > patch. My apologies. > Applied, thanks. Appreciated. -ek -- To unsubscribe from this l

Re: [PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow_keys

2015-05-21 Thread Cong Wang
On Thu, May 21, 2015 at 5:11 PM, Tom Herbert wrote: > static inline void ip6_set_txhash(struct sock *sk) > { > @@ -700,8 +714,11 @@ static inline void ip6_set_txhash(struct sock *sk) > > memset(&keys, 0, sizeof(keys)); > > - keys.addrs.src = (__force __be32)ipv6_addr_hash(&np->sadd

Re: [PATCH 7/7] mac80211: Switch to new AEAD interface

2015-05-21 Thread Herbert Xu
On Thu, May 21, 2015 at 02:17:44PM +0200, Johannes Berg wrote: > > Do you have a branch somewhere with all of that? OK the prerequisite patches are now in cryptodev. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.

Re: [PATCH v5] ixgbe: Add module parameter to disable VLAN filter

2015-05-21 Thread David Miller
From: Hiroshi Shimamoto Date: Fri, 22 May 2015 00:54:31 + >> Subject: Re: [PATCH v5] ixgbe: Add module parameter to disable VLAN filter >> >> From: Hiroshi Shimamoto >> Date: Thu, 21 May 2015 13:10:49 + >> >> > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c >> > b/drivers/

Re: [PATCH net-next] tcp: add tcpi_segs_in and tcpi_segs_out to tcp_info

2015-05-21 Thread Eric Dumazet
On Thu, 2015-05-21 at 23:25 -0400, David Miller wrote: > From: Eric Dumazet > Date: Wed, 20 May 2015 16:35:41 -0700 > > > From: Marcelo Ricardo Leitner > > > > This patch tracks the total number of inbound and outbound segments on a > > TCP socket. One may use this number to have an idea on con

Re: [net-next PATCH v3 00/10] pktgen: cleanups and introducing new samples/pktgen scripts

2015-05-21 Thread David Miller
From: Jesper Dangaard Brouer Date: Thu, 21 May 2015 12:15:35 +0200 > This patchset is focused on making pktgen easier to use and better > documented. It contains a number of documentation updates and minor > changes to pktgen. The major contribution is introduction of common > helper function fo

Re: [PATCH net-next] rocker: move netevent neigh update to processes context

2015-05-21 Thread David Miller
From: sfel...@gmail.com Date: Wed, 20 May 2015 22:05:07 -0700 > From: Scott Feldman > > In review of Simon's patchset "rocker: transaction fixes". it was noted > that rocker->neigh_tbl_next_index was unprotected in the call path below > and could race with other contexts calling rocker_port_ipv4

Re: [PATCH net-next] bridge: allow setting hash_max + multicast_router if interface is down

2015-05-21 Thread Cong Wang
On Thu, May 21, 2015 at 8:17 PM, Herbert Xu wrote: > On Thu, May 21, 2015 at 08:11:32PM -0700, Cong Wang wrote: >> >> For me it looks like we do use p->rlist in BH context, but I could easily >> miss something here. > > Because the caller disables BH for us. > Right, I thought port attr setting

Re: [PATCH -next] net: sched: pkt_cls: remove unused macros from uapi

2015-05-21 Thread David Miller
From: Florian Westphal Date: Thu, 21 May 2015 02:26:24 +0200 > Jamal points out that this header also contains kernel internal magic that > cannot be used from userspace for anything meaningful. > > Lets remove what the kernel doesn't use anymore and wrap remainder with > __KERNEL__. > > Sugges

Re: [PATCH net-next] tcp: add tcpi_segs_in and tcpi_segs_out to tcp_info

2015-05-21 Thread David Miller
From: Eric Dumazet Date: Wed, 20 May 2015 16:35:41 -0700 > From: Marcelo Ricardo Leitner > > This patch tracks the total number of inbound and outbound segments on a > TCP socket. One may use this number to have an idea on connection > quality when compared against the retransmissions. > > RFC

Re: [PATCH -next] ipv6: reject locally assigned nexthop addresses

2015-05-21 Thread David Miller
From: Florian Westphal Date: Thu, 21 May 2015 00:25:41 +0200 > ip -6 addr add dead::1/128 dev eth0 > sleep 5 > ip -6 route add default via dead::1/128 > -> fails > ip -6 addr add dead::1/128 dev eth0 > ip -6 route add default via dead::1/128 > -> succeeds > > reason is that if (nonsensensical) r

Re: [PATCH net-next 1/3] net: Flush all skbs related to an unregistered device

2015-05-21 Thread David Miller
From: Francesco Ruggeri Date: Thu, 21 May 2015 17:28:47 -0700 > One can change flush_backlog to also handle a list of net_devices > instead. Then make it do so. Because that is the driving design of all of the bulk deregister/etc. facilities, they operate on a list of objects and the top-level

Re: [PATCH net] rename RTNH_F_EXTERNAL to RTNH_F_OFFLOAD

2015-05-21 Thread David Miller
From: Stephen Hemminger Date: Thu, 21 May 2015 16:46:30 -0700 > On Thu, 21 May 2015 18:40:10 -0400 (EDT) > David Miller wrote: > >> From: Stephen Hemminger >> Date: Thu, 21 May 2015 15:16:18 -0700 >> >> > On Thu, 14 May 2015 22:45:54 -0400 (EDT) >> > David Miller wrote: >> > >> >> From: ro.

Re: [PATCH net-next] bridge: allow setting hash_max + multicast_router if interface is down

2015-05-21 Thread Herbert Xu
On Thu, May 21, 2015 at 08:11:32PM -0700, Cong Wang wrote: > > For me it looks like we do use p->rlist in BH context, but I could easily > miss something here. Because the caller disables BH for us. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gon

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

2015-05-21 Thread Marcel Holtmann
Hi Laura, > Then avoiding the failed firmware is no solution, indeed. > If it's a new probe, it should be never executed during resume. Can you expand this comment? What's wrong with probing during resume? The USB stack does carry out probes during resume under certa

Re: [PATCH net-next] bridge: allow setting hash_max + multicast_router if interface is down

2015-05-21 Thread Herbert Xu
On Fri, May 22, 2015 at 02:56:01AM +0200, Linus Lüssing wrote: > Network managers like netifd (used in OpenWRT for instance) try to > configure interface options after creation but before setting the > interface up. > > Unfortunately the sysfs / bridge currently only allows to configure the > hash

Re: [PATCH net-next] bridge: allow setting hash_max + multicast_router if interface is down

2015-05-21 Thread Cong Wang
On Thu, May 21, 2015 at 5:56 PM, Linus Lüssing wrote: > diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c > index 2d69d5c..066199e 100644 > --- a/net/bridge/br_multicast.c > +++ b/net/bridge/br_multicast.c > @@ -1775,8 +1775,6 @@ int br_multicast_set_router(struct net_bridge *br,

RE: [PATCH v5 3/3] ixgbe: Add new ndo to trust VF

2015-05-21 Thread Hiroshi Shimamoto
> > -Original Message- > > From: Hiroshi Shimamoto [mailto:h-shimam...@ct.jp.nec.com] > > Sent: Wednesday, May 20, 2015 9:13 PM > > To: Skidmore, Donald C; Kirsher, Jeffrey T; intel-wired-...@lists.osuosl.org > > Cc: Or Gerlitz; David Miller; Linux Netdev List; nhor...@redhat.com; > > sassm

Re: [PATCH net-next] bridge: allow setting hash_max + multicast_router if interface is down

2015-05-21 Thread roopa
On 5/21/15, 5:56 PM, Linus Lüssing wrote: Network managers like netifd (used in OpenWRT for instance) try to configure interface options after creation but before setting the interface up. Unfortunately the sysfs / bridge currently only allows to configure the hash_max and multicast_router optio

[PATCH net-next] bridge: allow setting hash_max + multicast_router if interface is down

2015-05-21 Thread Linus Lüssing
Network managers like netifd (used in OpenWRT for instance) try to configure interface options after creation but before setting the interface up. Unfortunately the sysfs / bridge currently only allows to configure the hash_max and multicast_router options when the bridge interface is up. But sinc

RE: [PATCH v5] ixgbe: Add module parameter to disable VLAN filter

2015-05-21 Thread Hiroshi Shimamoto
> Subject: Re: [PATCH v5] ixgbe: Add module parameter to disable VLAN filter > > From: Hiroshi Shimamoto > Date: Thu, 21 May 2015 13:10:49 + > > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > > b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c > > index 263cb40..b45570f 100644

Re: [RFC PATCH net-next] bridge: allow setting hash_max + multicast_router if interface is down

2015-05-21 Thread Linus Lüssing
On Thu, May 21, 2015 at 11:49:21AM +0800, Herbert Xu wrote: > The timer operations are all supposed to be idempotent. So enabling > a port twice or stopping it twice should be OK. Oki doki. > > > * Might calls to br_multicast_add_router() via br_multicast_enable_port() > > cause unintended si

Re: [PATCH net-next 1/3] net: Flush all skbs related to an unregistered device

2015-05-21 Thread Francesco Ruggeri
On Thu, May 21, 2015 at 2:02 PM, David Miller wrote: > > From: Baptiste Covolato > Date: Tue, 19 May 2015 16:24:51 -0700 > > > Update flush_backlog to flush all packets in the backlog queue belonging > > to a device being unregistered. Accordingly on_each_cpu no longer needs > > to pass a device

Re: [PATCH 0/7] crypto: Convert all AEAD users to new interface

2015-05-21 Thread Herbert Xu
On Thu, May 21, 2015 at 12:03:47PM -0400, David Miller wrote: > > No objections on my end. > > I assume since the dependencies exist in the crypto tree, you'll > want to merge this series there right? Yes that's probably the easiest path. Thanks, -- Email: Herbert Xu Home Page: http://gondor.a

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

2015-05-21 Thread Laura Abbott
On 05/21/2015 08:26 AM, Alan Stern wrote: On Thu, 21 May 2015, Marcel Holtmann wrote: Hi Alan, Then avoiding the failed firmware is no solution, indeed. If it's a new probe, it should be never executed during resume. Can you expand this comment? What's wrong with probing during resume? Th

Re: [PATCH 0/7] crypto: Convert all AEAD users to new interface

2015-05-21 Thread Herbert Xu
On Thu, May 21, 2015 at 02:29:10PM +0200, Stephan Mueller wrote: > > Wouldn't algif_aead be also a candiate for the transition? The current > implementation of aead_recvmsg() splits the one SGL it received from user > space into two: one for AD and one for the ciphertext. Yes of course, that's w

[PATCH v4 net-next 00/11] net: Increase inputs to flow_keys hashing

2015-05-21 Thread Tom Herbert
This patch set adds new fields to the flow_keys structure and hashes over these fields to get a better flow hash. In particular, these patches now include hashing over the full IPv6 addresses in order to defend against address spoofing that always results in the same hash. The new input also includ

[PATCH v4 net-next 10/11] net: Add GRE keyid in flow_keys

2015-05-21 Thread Tom Herbert
In flow dissector if a GRE header contains a keyid this is saved in the new keyid field of flow_keys. The GRE keyid is then represented in the flow hash function input. Signed-off-by: Tom Herbert --- include/net/flow_dissector.h | 6 ++ net/core/flow_dissector.c| 25

[PATCH v4 net-next 11/11] mpls: Add MPLS entropy label in flow_keys

2015-05-21 Thread Tom Herbert
In flow dissector if an MPLS header contains an entropy label this is saved in the new keyid field of flow_keys. The entropy label is then represented in the flow hash function input. Signed-off-by: Tom Herbert --- include/net/flow_dissector.h | 1 + net/core/flow_dissector.c| 37 ++

[PATCH v4 net-next 02/11] mpls: Add definition for IPPROTO_MPLS

2015-05-21 Thread Tom Herbert
Add uapi define for MPLS over IP. Signed-off-by: Tom Herbert --- include/uapi/linux/in.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/in.h b/include/uapi/linux/in.h index 589ced0..641338b 100644 --- a/include/uapi/linux/in.h +++ b/include/uapi/linux/in.h @@ -69,6 +69,

[PATCH v4 net-next 04/11] net: Get skb hash over flow_keys structure

2015-05-21 Thread Tom Herbert
This patch changes flow hashing to use jhash2 over the flow_keys structure instead just doing jhash_3words over src, dst, and ports. This method will allow us take more input into the hashing function so that we can include full IPv6 addresses, VLAN, flow labels etc. without needing to resort to xo

[PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow_keys

2015-05-21 Thread Tom Herbert
This patch adds full IPv6 addresses into flow_keys and uses them as input to the flow hash function. The implementation supports either IPv4 or IPv6 addresses in a union, and selector is used to determine how may words to input to jhash2. We also add flow_get_u32_dst and flow_get_u32_src functions

[PATCH v4 net-next 09/11] net: Add IPv6 flow label to flow_keys

2015-05-21 Thread Tom Herbert
In flow_dissector set the flow label in flow_keys for IPv6. This also removes the shortcircuiting of flow dissection when a non-zero label is present, the flow label can be considered to provide additional entropy for a hash. Signed-off-by: Tom Herbert --- include/net/flow_dissector.h | 4 +++-

[PATCH v4 net-next 06/11] net: Add keys for TIPC address

2015-05-21 Thread Tom Herbert
Add a new flow key for TIPC addresses. Signed-off-by: Tom Herbert --- include/net/flow_dissector.h | 10 ++ net/core/flow_dissector.c| 20 ++-- 2 files changed, 24 insertions(+), 6 deletions(-) diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h

[PATCH v4 net-next 01/11] net: Simplify GRE case in flow_dissector

2015-05-21 Thread Tom Herbert
Do break when we see routing flag or a non-zero version number in GRE header. Signed-off-by: Tom Herbert --- net/core/flow_dissector.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/net/core/flow_dissector.c b/net/core/flow_diss

[PATCH v4 net-next 07/11] net: Get rid of IPv6 hash addresses flow keys

2015-05-21 Thread Tom Herbert
We don't need to return the IPv6 address hash as part of flow keys. In general, using the IPv6 address hash is risky in a hash value since the underlying use of xor provides no entropy. If someone really needs the hash value they can get it from the full IPv6 addresses in flow keys (e.g. from flow_

[PATCH v4 net-next 08/11] net: Add VLAN ID to flow_keys

2015-05-21 Thread Tom Herbert
In flow_dissector set vlan_id in flow_keys when VLAN is found. Signed-off-by: Tom Herbert --- include/net/flow_dissector.h | 6 ++ net/core/flow_dissector.c| 14 ++ 2 files changed, 20 insertions(+) diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h in

[PATCH v4 net-next 03/11] net: Remove superfluous setting of key_basic

2015-05-21 Thread Tom Herbert
key_basic is set twice in __skb_flow_dissect which seems unnecessary. Remove second one. Signed-off-by: Tom Herbert --- net/core/flow_dissector.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index 4a2cb93..6aebe99 100644 --- a/net

Re: [PATCH iproute2] tc: bpf: add initial man page

2015-05-21 Thread Alexei Starovoitov
On 5/21/15 3:17 PM, Daniel Borkmann wrote: Add a start of a man-page to the misc section as a reference and guide on (e)BPF classifier and actions. Given that tc is only tersely documented, this is provided in the hope that users will have an easier getting started with tc and (e)BPF. And, that t

Re: [PATCH net] rename RTNH_F_EXTERNAL to RTNH_F_OFFLOAD

2015-05-21 Thread Stephen Hemminger
On Thu, 21 May 2015 18:40:10 -0400 (EDT) David Miller wrote: > From: Stephen Hemminger > Date: Thu, 21 May 2015 15:16:18 -0700 > > > On Thu, 14 May 2015 22:45:54 -0400 (EDT) > > David Miller wrote: > > > >> From: ro...@cumulusnetworks.com > >> Date: Wed, 13 May 2015 21:17:41 -0700 > >> > >>

Re: [PATCH net-next v4 01/10] ipv6: Remove external dependency on rt6i_dst and rt6i_src

2015-05-21 Thread David Miller
From: Martin KaFai Lau Date: Wed, 20 May 2015 15:52:20 -0700 > This patch removes the assumptions that the returned rt is always > a RTF_CACHE entry with the rt6i_dst and rt6i_src containing the > destination and source address. The dst and src can be recovered from > the calling site. > > We m

Re: [PATCH net-next 0/4] stmmac: probe code refactoring and clean up part 1

2015-05-21 Thread David Miller
From: Joachim Eastwood Date: Wed, 20 May 2015 20:03:05 +0200 > This patch set refactor the code in stmmac_pci_probe and stmmac_pltfr_probe > and moves the common bits into stmmac_dvr_probe. Along the way some clean- > ups are applied to stmmac_pltfr_probe. > > The code has been tested on the LPC

Re: [PATCH net-next 0/2] tcp: improve source port selection

2015-05-21 Thread David Miller
From: Eric Dumazet Date: Wed, 20 May 2015 10:59:00 -0700 > With increase of TCP sockets in hosts, we often hit limitations > caused by port selection, due to randomization and poor strategy. This looks fine, nice work, applied. Thanks Eric! -- To unsubscribe from this list: send the line "unsub

Re: [PATCH net-next v2] tcp: ensure epoll edge trigger wakeup when write queue is empty

2015-05-21 Thread David Miller
From: Jason Baron Date: Wed, 20 May 2015 15:52:53 + (GMT) > From: Jason Baron > > We currently rely on the setting of SOCK_NOSPACE in the write() > path to ensure that we wake up any epoll edge trigger waiters when > acks return to free space in the write queue. However, if we fail > to all

Re: [PATCH net-next v2 0/4] sfc: add MCDI tracing

2015-05-21 Thread David Miller
From: Edward Cree Date: Wed, 20 May 2015 16:49:09 +0100 > This patchset adds support for logging MCDI (Management-Controller-to- > Driver Interface) interactions between the sfc driver and a bound device, > to aid in debugging. > Solarflare has a tool to decode the resulting traces and will loo

Re: [PATCH net] net: sched: fix call_rcu() race on classifier module unloads

2015-05-21 Thread David Miller
From: Daniel Borkmann Date: Wed, 20 May 2015 17:13:33 +0200 > Vijay reported that a loop as simple as ... ... > ... will panic the kernel. Moreover, he bisected the change > apparently introducing it to 78fd1d0ab072 ("netlink: Re-add > locking to netlink_lookup() and seq walker"). > > The remov

Re: [PATCH net-next 0/2] cxgb4: Cleanup and update T4/T4 register ranges

2015-05-21 Thread David Miller
From: Hariprasad Shenai Date: Wed, 20 May 2015 17:53:44 +0530 > This series cleans and optimizes setup_memwin function and also updates > T4/T5 adapter register ranges by removing incorrect register addresses > > This patch series has been created against net-next tree and includes > patches on

Re: [PATCH net-next v3 00/16] sfc: Get/Set MAC address and ndo_[set/get]_vf_* entrypoint functions

2015-05-21 Thread David Miller
From: Shradha Shah Date: Wed, 20 May 2015 11:06:09 +0100 > This is the second instalment of patches towards supporting EF10 SRIOV. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo inf

[PATCH v3 -next] ipv6: don't increase size when refragmenting forwarded ipv6 skbs

2015-05-21 Thread Florian Westphal
since commit 6aafeef03b9d ("netfilter: push reasm skb through instead of original frag skbs") we will end up sometimes re-fragmenting skbs that we've reassembled. ipv6 defrag preserves the original skbs using the skb frag list, i.e. as long as the skb frag list is preserved there is no problem sin

Re: [PATCH] stmmac: replace open coded __netdev_alloc_skb_ip_align() with actual call

2015-05-21 Thread David Miller
From: Vineet Gupta Date: Wed, 20 May 2015 12:04:40 +0530 > This also matches with the sibling call netdev_alloc_skb_ip_align() made in > rx fast path. > > Signed-off-by: Vineet Gupta Applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body o

Re: [PATCH net] rename RTNH_F_EXTERNAL to RTNH_F_OFFLOAD

2015-05-21 Thread David Miller
From: Stephen Hemminger Date: Thu, 21 May 2015 15:16:18 -0700 > On Thu, 14 May 2015 22:45:54 -0400 (EDT) > David Miller wrote: > >> From: ro...@cumulusnetworks.com >> Date: Wed, 13 May 2015 21:17:41 -0700 >> >> > From: Roopa Prabhu >> > >> > RTNH_F_EXTERNAL today is printed as "offload" in i

Re: [PATCH iproute2 v3 net-next] iplink_bond: add support for ad_actor and port_key options

2015-05-21 Thread Stephen Hemminger
On Sat, 9 May 2015 00:01:59 -0700 Jonathan Toppins wrote: > This adds support for setting and displaying the following bonding > options: > * ad_user_port_key > * ad_actor_sys_prio > * ad_actor_system > > Signed-off-by: Jonathan Toppins Applied to net-next branch -- To unsubscribe from this l

Re: [PATCH iproute2] codel: add ce_threshold support to codel & fc_codel

2015-05-21 Thread Stephen Hemminger
On Mon, 11 May 2015 10:44:55 -0700 Eric Dumazet wrote: > From: Eric Dumazet > > codel & fq_codel packet schedulers are now able to have a threshold > for CE marking packets, regardless of the drop/nodrop decision taken by > CoDel. > > This is particularly useful for dctcp and variants, that do

Re: [patch iproute2] tc: add support for Flower classifier

2015-05-21 Thread Stephen Hemminger
On Fri, 15 May 2015 13:34:04 +0200 Jiri Pirko wrote: > Signed-off-by: Jiri Pirko > --- > include/linux/pkt_cls.h | 30 +++ > tc/Makefile | 1 + > tc/f_flower.c | 540 > > 3 files changed, 571 insertions(+) > create mode

Re: [PATCH iproute2] ss: add support for bytes_acked & bytes_received

2015-05-21 Thread Stephen Hemminger
On Mon, 11 May 2015 10:03:49 -0700 Eric Dumazet wrote: > From: Eric Dumazet > > tcp_info has 2 new fields : bytes_acked & bytes_received > > $ ss -ti src :22 > ... >cubic wscale:7,6 rto:234 rtt:33.199/17.225 ato:17.225 mss:1418 cwnd:9 > ssthresh:9 send 3.1Mbps lastsnd:3 lastrcv:4 lasta

Re: [PATCH v3] iproute2: GENEVE support

2015-05-21 Thread Stephen Hemminger
On Wed, 13 May 2015 13:02:28 -0400 "John W. Linville" wrote: > Signed-off-by: John W. Linville Applied. Please send update to man pages as well. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at htt

[PATCH iproute2] tc: bpf: add initial man page

2015-05-21 Thread Daniel Borkmann
Add a start of a man-page to the misc section as a reference and guide on (e)BPF classifier and actions. Given that tc is only tersely documented, this is provided in the hope that users will have an easier getting started with tc and (e)BPF. And, that there's now more incentive for others to also

Re: [PATCH net] rename RTNH_F_EXTERNAL to RTNH_F_OFFLOAD

2015-05-21 Thread Stephen Hemminger
On Thu, 14 May 2015 22:45:54 -0400 (EDT) David Miller wrote: > From: ro...@cumulusnetworks.com > Date: Wed, 13 May 2015 21:17:41 -0700 > > > From: Roopa Prabhu > > > > RTNH_F_EXTERNAL today is printed as "offload" in iproute2 output. > > > > This patch renames the flag to be consistent with w

Re: [PATCH] net: macb: Disable half duplex gigabit on Zynq

2015-05-21 Thread Sören Brinkmann
On Thu, 2015-05-21 at 04:47PM -0500, Nathan Sullivan wrote: > According to the Zynq TRM, gigabit half duplex is not supported. Add a > new cap and compatible string so Zynq can avoid advertising that mode. > > Signed-off-by: Nathan Sullivan > --- > drivers/net/ethernet/cadence/macb.c | 12 +++

[PATCH v3 -next] ip: reject too-big defragmented DF-skb when forwarding

2015-05-21 Thread Florian Westphal
Send icmp pmtu error if we find that the largest fragment of df-skb exceeded the output path mtu. The ip output path will still catch this later on but we can avoid the forward/postrouting hook traversal by rejecting right away. This is what ipv6 already does. Acked-by: Hannes Frederic Sowa Sig

Re: [PATCH net-next] tcp: add tcpi_segs_in and tcpi_segs_out to tcp_info

2015-05-21 Thread Marcelo Ricardo Leitner
On Thu, May 21, 2015 at 12:41:21PM -0700, Yuchung Cheng wrote: > On Wed, May 20, 2015 at 4:35 PM, Eric Dumazet wrote: ... > > diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c > > index > > b6575d6655681e8e84993a5db929c7309d47d4d3..beac6bf840b9a9d1e2f281d2b1c71b5a3414b824 > > 100644 > > ---

[PATCH] net: macb: Disable half duplex gigabit on Zynq

2015-05-21 Thread Nathan Sullivan
According to the Zynq TRM, gigabit half duplex is not supported. Add a new cap and compatible string so Zynq can avoid advertising that mode. Signed-off-by: Nathan Sullivan --- drivers/net/ethernet/cadence/macb.c | 12 drivers/net/ethernet/cadence/macb.h |1 + 2 files changed

Re: [PATCH iproute2 0/2] Run tests forcely in separated netns

2015-05-21 Thread Stephen Hemminger
On Tue, 12 May 2015 17:40:14 +0300 Vadim Kochan wrote: > From: Vadim Kochan > > Changed to run each test in separated network namespace by using > 'unshare' tool from util-linux tools set, it allows to do not affect > network setup on the host machine, 'unshare' tool is required by default. >

Re: [PATCH iproute2] tipc: introduce TIPC configuration tool

2015-05-21 Thread Stephen Hemminger
On Thu, 7 May 2015 15:07:35 +0200 wrote: > From: Richard Alpe > > This is the new tipc tool that utilizes the relativly new TIPC netlink API in > the kernel. Introducing this tool into iproute2 has been discussed previously. > > For more information about the design decisions of this tool, see

Re: [PATCH iproute2 01/10] tc: red, gred: Rename overloaded variable wlog

2015-05-21 Thread Stephen Hemminger
On Mon, 18 May 2015 11:35:05 -0400 David Ward wrote: > It is used when parsing three different parameters, only one of > which is Wlog. Change the name to make the code less confusing. > > Signed-off-by: David Ward All applied, and I went ahead and fixed a couple of old style issues in RED/GR

Re: Looking for a lost patch

2015-05-21 Thread David Miller
From: Steffen Klassert Date: Wed, 20 May 2015 08:32:23 +0200 > On Tue, May 19, 2015 at 11:32:15AM -0700, Alexander Duyck wrote: >> On 05/19/2015 12:57 AM, Steffen Klassert wrote: >> >The MTU should be 1500. All the IPsec overhead is handled by PMTU >> >discovery, just like in the case we use IPse

Re: [PATCH] qlge: Move jiffies_to_usecs immediately before loop

2015-05-21 Thread David Miller
From: Joe Perches Date: Tue, 19 May 2015 21:44:52 -0700 > 30 usecs (or really, 1 jiffy) can go by pretty fast. > > Move the set of the timeout immediately before the loop. > > Remove the unnecessary max(1ul, usecs_to_jiffies(30)) as > usecs_to_jiffies with a non-zero constant is guaranteed > to

Re: [PATCH v4 net-next 0/4] rocker: transaction fixes

2015-05-21 Thread David Miller
From: Simon Horman Date: Thu, 21 May 2015 12:40:13 +0900 > this series addresses what appear to be errors in the handling of > prepare and then commit transactions in the rocker driver. Series applied, thanks a lot Simon. -- To unsubscribe from this list: send the line "unsubscribe netdev" in th

Re: [PATCH 07/12] spider_net: Use DECLARE_BITMAP

2015-05-21 Thread David Miller
From: Joe Perches Date: Tue, 19 May 2015 18:37:55 -0700 > Use the generic mechanism to declare a bitmap instead of unsigned long. > > Signed-off-by: Joe Perches Applied to net-next, thanks Joe. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to maj

Re: [PATCH net-next 0/4] bpf: introduce bpf_tail_call() helper

2015-05-21 Thread David Miller
From: Alexei Starovoitov Date: Tue, 19 May 2015 16:59:02 -0700 > introduce bpf_tail_call(ctx, &jmp_table, index) helper function Since we dispatch often by IDs like syscall numbers and protocol IDs, this seems very useful. Series applied, thanks Alexei. -- To unsubscribe from this list: send th

Re: [PATCH net-next 1/3] net: Flush all skbs related to an unregistered device

2015-05-21 Thread David Miller
From: Baptiste Covolato Date: Tue, 19 May 2015 16:24:51 -0700 > Update flush_backlog to flush all packets in the backlog queue belonging > to a device being unregistered. Accordingly on_each_cpu no longer needs > to pass a device to flush_backlog since it handles any device in the > NETREG_UNREGI

Re: [PATCH net-next] net: dev: reduce both ingress hook ifdefs

2015-05-21 Thread David Miller
From: Daniel Borkmann Date: Tue, 19 May 2015 22:33:25 +0200 > Reduce ifdef pollution slightly, no functional change. We can simply > remove the extra alternative definition of handle_ing() and nf_ingress(). > > Signed-off-by: Daniel Borkmann Applied, thanks Daniel. -- To unsubscribe from this

Re: [PATCH net-next] tcp: add a force_schedule argument to sk_stream_alloc_skb()

2015-05-21 Thread David Miller
From: Eric Dumazet Date: Tue, 19 May 2015 13:26:55 -0700 > From: Eric Dumazet > > In commit 8e4d980ac215 ("tcp: fix behavior for epoll edge trigger") > we fixed a possible hang of TCP sockets under memory pressure, > by allowing sk_stream_alloc_skb() to use sk_forced_mem_schedule() > if no pack

Re: [PATCH net-next] Better handling of transition to NUD_PROBE state

2015-05-21 Thread David Miller
From: Erik Kline Date: Mon, 18 May 2015 19:44:41 +0900 > [1] When entering NUD_PROBE state via neigh_update(), perhaps received > from userspace, correctly (re)initialize the probes count to zero. > > This is useful for forcing revalidation of a neighbor (for example > if the host is

Re: [PATCH] net: phy: Make sure phy_start() always re-enables the phy interrupts

2015-05-21 Thread David Miller
From: Tim Beale Date: Mon, 18 May 2015 15:38:38 +1200 > This is an alternative way of fixing: > commit db9683fb412d ("net: phy: Make sure PHY_RESUMING state change > is always processed") > > When the PHY state transitions from PHY_HALTED to PHY_RESUMING, there are > two t

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

2015-05-21 Thread Arend van Spriel
On 05/21/15 19:32, Takashi Iwai wrote: At Thu, 21 May 2015 19:27:41 +0200, Arend van Spriel wrote: On 05/21/15 17:35, Takashi Iwai wrote: At Thu, 21 May 2015 11:26:17 -0400 (EDT), Alan Stern wrote: On Thu, 21 May 2015, Takashi Iwai wrote: At Thu, 21 May 2015 10:18:08 -0400 (EDT), Alan Ster

Re: [PATCH net-next 2/2] tcp: improve REUSEADDR/NOREUSEADDR cohabitation

2015-05-21 Thread Flavio Leitner
On Wed, May 20, 2015 at 10:59:02AM -0700, Eric Dumazet wrote: > inet_csk_get_port() randomization effort tends to spread > sockets on all the available range (ip_local_port_range) > > This is unfortunate because SO_REUSEADDR sockets have > less requirements than non SO_REUSEADDR ones. > > If an a

[PATCH net] bridge: fix lockdep splat

2015-05-21 Thread Eric Dumazet
From: Eric Dumazet Following lockdep splat was reported : [ 29.382286] === [ 29.382315] [ INFO: suspicious RCU usage. ] [ 29.382344] 4.1.0-0.rc0.git11.1.fc23.x86_64 #1 Not tainted [ 29.382380] --- [ 29.382409] net/bridge/br_privat

Re: [RFC PATCH 0/4] Make iSCSI network namespace aware

2015-05-21 Thread Chris Leech
On Wed, May 20, 2015 at 11:45:43AM -0700, Andy Grover wrote: > On 05/13/2015 03:12 PM, Chris Leech wrote: > >This is only about the structures and functionality involved in maintaining > >the > >iSCSI session, the SCSI host along with it's discovered targets and devices > >has > >no association w

Re: [PATCH net-next 1/2] inet_hashinfo: remove bsocket counter

2015-05-21 Thread Flavio Leitner
On Wed, May 20, 2015 at 10:59:01AM -0700, Eric Dumazet wrote: > We no longer need bsocket atomic counter, as inet_csk_get_port() > calls bind_conflict() regardless of its value, after commit > 2b05ad33e1e624e ("tcp: bind() fix autoselection to share ports") > > This patch removes overhead of maint

Re: Suspicious RCU usage in bridge with Linux v4.0-9362-g1fc149933fd4

2015-05-21 Thread Eric Dumazet
On Thu, 2015-05-21 at 15:22 -0400, Josh Boyer wrote: > I'm still seeing this with Linus' tree as of yesterday. Is this > queued anywhere for 4.1? I'll send the patch, thanks for the heads up. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord

Re: [PATCH net-next] tcp: add tcpi_segs_in and tcpi_segs_out to tcp_info

2015-05-21 Thread Eric Dumazet
On Thu, 2015-05-21 at 12:41 -0700, Yuchung Cheng wrote: > It'd be nice to count SYN and SYNACKs for apps tracking the handshake stats. > For syn-cookies we can't do much. But for the rest we can account > req->num_retrans for SYN-ACKs sent, and perhaps track SYN received in > request sock? Well,

Re: [PATCH net-next] tcp: add tcpi_segs_in and tcpi_segs_out to tcp_info

2015-05-21 Thread Yuchung Cheng
On Wed, May 20, 2015 at 4:35 PM, Eric Dumazet wrote: > > From: Marcelo Ricardo Leitner > > This patch tracks the total number of inbound and outbound segments on a > TCP socket. One may use this number to have an idea on connection > quality when compared against the retransmissions. > > RFC4898

Re: [PATCH net-next 1/3] cxgb4: Add support for loopback between VI of same port

2015-05-21 Thread David Miller
From: Casey Leedom Date: Thu, 21 May 2015 16:36:00 + > I definitely understand the issue of wanting to avoid randomly > different module parameters in various drivers which do similar > things. What we're looking for is a list of the acceptable ways for > doing things ― especially when they

Re: Suspicious RCU usage in bridge with Linux v4.0-9362-g1fc149933fd4

2015-05-21 Thread Josh Boyer
On Tue, May 12, 2015 at 2:27 PM, Dominick Grift wrote: > On Mon, May 11, 2015 at 07:53:06AM -0700, Eric Dumazet wrote: >> >> Hi Dominick >> >> Have you tried this patch I sent last monday ? >> >> I will submit formally when I get a test result. >> >> Thanks > > Eric, > > I have tested the below pa

Re: ingress policying for realtime protocol

2015-05-21 Thread Uwe Kleine-König
Hello, On Thu, May 21, 2015 at 09:36:28AM -0400, Jamal Hadi Salim wrote: > On 05/21/15 03:07, Uwe Kleine-König wrote: > >On Wed, May 20, 2015 at 05:30:40PM -0700, Eric Dumazet wrote: > >>On Wed, 2015-05-20 at 16:46 -0700, Cong Wang wrote: > >> > >>>There is very little to do on ingress side since

Re: Cause of Large Latency Difference Between 1179-byte and 1180-byte UDP Frames?

2015-05-21 Thread Todd Bezenek
(solution below) The time to send that extra byte over the wire is 8 nsec. It seems unlikely that would produce such a clean-cut difference, but I've been surprised before. :) The "idle=poll" parameter sounds like a good idea for any application which tries to maintain real-time behavior. I'm

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

2015-05-21 Thread Laura Abbott
On 05/21/2015 11:11 AM, Takashi Iwai wrote: At Thu, 21 May 2015 13:37:56 -0400 (EDT), Alan Stern wrote: On Thu, 21 May 2015, Takashi Iwai wrote: At Thu, 21 May 2015 11:26:17 -0400 (EDT), Alan Stern wrote: On Thu, 21 May 2015, Takashi Iwai wrote: At Thu, 21 May 2015 10:18:08 -0400 (EDT), A

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

2015-05-21 Thread Takashi Iwai
At Thu, 21 May 2015 13:37:56 -0400 (EDT), Alan Stern wrote: > > On Thu, 21 May 2015, Takashi Iwai wrote: > > > At Thu, 21 May 2015 11:26:17 -0400 (EDT), > > Alan Stern wrote: > > > > > > On Thu, 21 May 2015, Takashi Iwai wrote: > > > > > > > At Thu, 21 May 2015 10:18:08 -0400 (EDT), > > > > Ala

Re: [PATCH net-next v3] tcp: add rfc3168, section 6.1.1.1. fallback

2015-05-21 Thread Vijay Subramanian
> > Please do not top post. My fault. Will be more careful in future. > > No problem here. I do not see obvious reasons for breaking your setup. > It was a problem with my network driver not getting installed due to some symbol mismatch after a compile. It got sorted out after I cleaned up every

Re: [PATCH v4 for-next 05/12] IB/cm: Share listening CM IDs

2015-05-21 Thread Jason Gunthorpe
On Thu, May 21, 2015 at 11:08:31AM +0300, Haggai Eran wrote: > > The more I look at this, the more I think it is sketchy. Don't try and > > merge sharecount and refcount together, > I'm not sure what you mean here. The way I was thinking about it was > that sharecount = num of rdma_cm_ids sharing

Re: [PATCH v4 for-next 04/12] IB/ipoib: Return IPoIB devices matching connection parameters

2015-05-21 Thread Jason Gunthorpe
On Thu, May 21, 2015 at 08:33:53AM +0300, Haggai Eran wrote: > To create a new child interface on the default P_Key, its possible to > use iproute: > # ip link add link ib0 name ib0.1 type ipoib Uh.. A key invariant of the IP stack is that is it possible to uniquely identify the ingress device.

Re: [RESEND][PATCH] Bluetooth: Make request workqueue freezable

2015-05-21 Thread Alan Stern
On Thu, 21 May 2015, Takashi Iwai wrote: > At Thu, 21 May 2015 11:26:17 -0400 (EDT), > Alan Stern wrote: > > > > On Thu, 21 May 2015, Takashi Iwai wrote: > > > > > At Thu, 21 May 2015 10:18:08 -0400 (EDT), > > > Alan Stern wrote: > > > > > > > > On Thu, 21 May 2015, Takashi Iwai wrote: > > > >

  1   2   3   >