Re: [PATCH 1/2] sctp: SCTP_SOCKOPT_PEELOFF return socket pointer for kernel users

2015-07-13 Thread Neil Horman
On Fri, Jul 10, 2015 at 06:21:14PM -0700, David Miller wrote: From: Marcelo Ricardo Leitner marcelo.leit...@gmail.com Date: Thu, 9 Jul 2015 11:15:19 -0300 SCTP has this operation to peel off associations from a given socket and create a new socket using this association. We currently have

[net-next 02/16] i40e/i40evf: Add stats to track FD ATR and SB dynamic enable state

2015-07-13 Thread Jeff Kirsher
From: Anjali Singhai Jain anjali.sing...@intel.com Since the driver can dynamically enable/disable FD ATR and SB features, these stats help keep track of the current state and along with fd_flush count provide a means to debug what could be going on with the flow director filters. This will take

[net-next 04/16] i40e/i40evf: improve Tx performance with a small tweak

2015-07-13 Thread Jeff Kirsher
From: Jesse Brandeburg jesse.brandeb...@intel.com Add a prefetch for the next Tx descriptor to be used when we know there are more coming. Change-ID: Ibb9acab11d508eec2db7da795df74debc16eeacb Signed-off-by: Jesse Brandeburg jesse.brandeb...@intel.com Tested-by: Jim Young james.m.yo...@intel.com

[net-next 01/16] i40e: Implement ndo_features_check()

2015-07-13 Thread Jeff Kirsher
From: Joe Stringer joestrin...@nicira.com i40e supports UDP tunnel headers up to 80 bytes in length, so this adds a check to ensure that it doesn't try to offload packets that exceed that. Signed-off-by: Joe Stringer joestrin...@nicira.com Signed-off-by: Jesse Gross je...@nicira.com Acked-by:

[net-next 05/16] i40evf: Allow for an abundance of vectors

2015-07-13 Thread Jeff Kirsher
From: Mitch Williams mitch.a.willi...@intel.com The driver currently only maps TX and RX queues to a single MSI-X vector per queue pair if there are exactly enough vectors for this. Unfortunately, if we have too many vectors it will fail and allocate queues to vectors in a suboptimal manner.

Re: [PATCH net-next v2] ipv6: Do not iterate over all interfaces when finding source address on specific interface.

2015-07-13 Thread Erik Kline
On 13 July 2015 at 15:32, YOSHIFUJI Hideaki hideaki.yoshif...@miraclelinux.com wrote: Hi, Erik Kline wrote: Hmm, when I run a UML linux with this patch (which, I'm ashamed to say, I failed to do before) I get these kinds of errors: unregister_netdevice: waiting for TAPdevice to become

Re: [PATCH] netlink: enable skb header refcounting before sending first broadcast

2015-07-13 Thread Konstantin Khlebnikov
On 13.07.2015 10:23, Herbert Xu wrote: On Fri, Jul 10, 2015 at 02:51:41PM +0300, Konstantin Khlebnikov wrote: This fixes race between non-atomic updates of adjacent bit-fields: skb-cloned could be lost because netlink broadcast clones skb after sending it to the first listener who sets

RE: [PATCH] bnx2x: Update to FW version 7.12.30

2015-07-13 Thread Yuval Mintz
The new FW will allow us to utilize some new features in our driver, mainly adding vlan filtering offload and vxlan offload support. In addition, this fixes several issues: 1. Packets from a VF with pvid configured which were sent with a different vlan were transmitted instead

[net-next 03/16] i40e/i40evf: Update Flex-10 related device/function capabilities

2015-07-13 Thread Jeff Kirsher
From: Pawel Orlowski pawel.orlow...@intel.com The Flex10 device/function capability has been upgraded to include information needed to support Flex-10 configurations. This patch adds new fields to the i40e_hw_capabilities structure and updates i40e_parse_discover_capabilities functions to extract

[net-next 06/16] i40e: ignore duplicate port VLAN requests

2015-07-13 Thread Jeff Kirsher
From: Mitch Williams mitch.a.willi...@intel.com If user attempts to set a port VLAN on a VF that already has the same port VLAN configured, the driver will go through a completely unnecessary flurry of filter removals and filter adds. Just check for this condition and return success instead of

[net-next 12/16] i40evf: don't delete all the filters

2015-07-13 Thread Jeff Kirsher
From: Mitch Williams mitch.a.willi...@intel.com Due to an inverted conditional, the driver was marking all of its MAC filters for deletion every time set_rx_mode was called. Depending upon the timing of the calls to set_rx_mode and the processing of the admin queue, the driver would

[net-next 00/16][pull request] Intel Wired LAN Driver Updates 2015-07-13

2015-07-13 Thread Jeff Kirsher
This series contains updates to i40e and i40evf only. Joe Stringer and Jesse Gross add a ndo_features_check function to ensure that the i40e driver does not try to offload packets that exceed 80 bytes in length. Anjali adds additional stats to track flow director ATR and SB current state and

[net-next 10/16] i40e: do a proper reset when disabling a VF

2015-07-13 Thread Jeff Kirsher
From: Mitch Williams mitch.a.willi...@intel.com The VF disable code was just whanging on the reset bit without properly cleaning up the VF, which would leave the VF in an indeterminate state from which it could not recover. Fix this by notifying the VF and then by calling the normal VF reset

[net-next 14/16] i40e/i40evf: Add support for pre-allocated pages for PD

2015-07-13 Thread Jeff Kirsher
From: Faisal Latif faisal.la...@intel.com The i40e_add_pd_table_entry() routine is being modified to handle both cases where a backing page is passed and where backing page is allocated in i40e_add_pd_table_entry(). For PBLE resource management, it is more efficient for it to manage its backing

[net-next 11/16] i40e: un-disable VF after reset

2015-07-13 Thread Jeff Kirsher
From: Mitch Williams mitch.a.willi...@intel.com When a VF is disabled, there is no way for it to recover until either the PF driver is reloaded or SR-IOV is disabled and enabled. To correct this, enable the VF after a successful reset. Change-ID: I9e0788476c4d53d5407961b503febdfff2b8a7c6

[net-next 08/16] i40e/i40evf: Update the admin queue command header

2015-07-13 Thread Jeff Kirsher
From: Greg Rose gregory.v.r...@intel.com Make the necessary updates to i40e_adminq_cmd.h. Change-ID: Ib031c86cc6cab78e5aa44c64d8ce5474be8d7e42 Signed-off-by: Greg Rose gregory.v.r...@intel.com Tested-by: Jim Young james.m.yo...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com

[net-next 16/16] i40e/i40evf: Bump version to 1.3.6 for i40e and 1.3.2 for i40evf

2015-07-13 Thread Jeff Kirsher
From: Catherine Sullivan catherine.sulli...@intel.com Bump. Change-ID: I84573d9fa51effc5b29bf5b8c74e3cc8b2673f48 Signed-off-by: Catherine Sullivan catherine.sulli...@intel.com Tested-by: Jim Young james.m.yo...@intel.com Signed-off-by: Jeff Kirsher jeffrey.t.kirs...@intel.com ---

[net-next 13/16] i40evf: add MAC address filter in open, not init

2015-07-13 Thread Jeff Kirsher
From: Mitch Williams mitch.a.willi...@intel.com During close, all of the MAC filters are cleared, so the driver would be unable to receive unicast packets after being closed and reopened. Add the adapter's hardware MAC address filter in open, not init. This ensures that the correct filter is

[PATCH] NET: AX.25: Stop heartbeat timer on disconnect.

2015-07-13 Thread Ralf Baechle
This may result in a kernel panic. The bug has always existed but somehow we've run out of luck now and it bites. Signed-off-by: Richard Stearn rich...@rns-stearn.demon.co.uk Cc: sta...@vger.kernel.org # all branches Signed-off-by: Ralf Baechle r...@linux-mips.org --- net/ax25/ax25_subr.c

[PATCH] Revert net: fec: Ensure clocks are enabled while using mdio bus

2015-07-13 Thread Fabio Estevam
This reverts commit 6c3e921b18edca290099adfddde8a50236bf2d80. commit 6c3e921b18ed (net: fec: Ensure clocks are enabled while using mdio bus) prevents the kernel to boot on mx6 boards, so let's revert it. Reported-by: Tyler Baker tyler.ba...@linaro.org Signed-off-by: Fabio Estevam

net: Fix skb csum races when peeking

2015-07-13 Thread Herbert Xu
On Mon, Jul 13, 2015 at 04:31:00PM +0800, Herbert Xu wrote: On Mon, Jul 13, 2015 at 10:28:19AM +0200, Eric Dumazet wrote: Except that udp checksum are checked outside of spinlock protection. Good point. I wonder when this got broken. I'll do some digging. OK looks like I can claim

Re: [PATCH v2 0/2] net: enable inband link state negotiation only when explicitly requested

2015-07-13 Thread Sebastien Rannou
Hi Stas, On Fri, 10 Jul 2015, Stas Sergeev wrote: Those who were affected by the change, please send your Tested-by, Thanks! I also confirm that this version of the patch solves the issue: Tested-by: Sebastien Rannou m...@sbrk.org -- Sébastien

linux-4.2-rc2/drivers/net/ethernet/brocade/bna/bfa_ioc.c:2843: out of bounds string access ?

2015-07-13 Thread David Binderman
Hello there, [linux-4.2-rc2/drivers/net/ethernet/brocade/bna/bfa_ioc.c:2843]: (error) Buffer is accessed out of bounds. Source code is     memcpy(manufacturer, BFA_MFG_NAME, BFA_ADAPTER_MFG_NAME_LEN); and #define BFA_MFG_NAME QLogic and $ fgrep BFA_ADAPTER_MFG_NAME_LEN `find

[PATCH net] bridge: multicast: treat igmpv3 report with INCLUDE and no sources as a leave

2015-07-13 Thread Nikolay Aleksandrov
From: Satish Ashok sas...@cumulusnetworks.com A report with INCLUDE/Change_to_include and empty source list should be treated as a leave, specified by RFC 3376, section 3.1: If the requested filter mode is INCLUDE *and* the requested source list is empty, then the entry corresponding to the

Re: [PATCH net-next v2] ipv6: Do not iterate over all interfaces when finding source address on specific interface.

2015-07-13 Thread Hajime Tazaki
Yoshifuji-san, At Mon, 13 Jul 2015 17:38:48 +0900, Erik Kline wrote: On 13 July 2015 at 15:32, YOSHIFUJI Hideaki hideaki.yoshif...@miraclelinux.com wrote: Hi, Erik Kline wrote: Hmm, when I run a UML linux with this patch (which, I'm ashamed to say, I failed to do before) I get

Re: [PATCH] KVM: Add Kconfig option to signal cross-endian guests

2015-07-13 Thread Greg Kurz
On Thu, 9 Jul 2015 09:49:05 +0200 Thomas Huth th...@redhat.com wrote: The option for supporting cross-endianness legacy guests in the vhost and tun code should only be available on systems that support cross-endian guests. Signed-off-by: Thomas Huth th...@redhat.com Acked-by: Greg Kurz

[PATCH v2] NET: AX.25: Stop heartbeat timer on disconnect.

2015-07-13 Thread Ralf Baechle
From: Richard Stearn rich...@rns-stearn.demon.co.uk This may result in a kernel panic. The bug has always existed but somehow we've run out of luck now and it bites. Signed-off-by: Richard Stearn rich...@rns-stearn.demon.co.uk Cc: sta...@vger.kernel.org # all branches Signed-off-by: Ralf

[net-next 07/16] i40e: Remove incorrect #ifdef's

2015-07-13 Thread Jeff Kirsher
From: Carolyn Wyborny carolyn.wybo...@intel.com This patch removes some #ifdef's that should not be there. They were stopping code that is needed from being compiled in. With these #ifdef's removed, changes are needed in the driver to fix some compile errors: adding missing parameters to the

linux-4.2-rc2/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1993: possible bad error checking ?

2015-07-13 Thread David Binderman
Hello there, [linux-4.2-rc2/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1993]: (style) Checking if unsigned variable 'entry' is less than zero. Source code is     entry = priv-hw-mode-jumbo_frm(priv, skb, csum_insertion);     if (unlikely(entry 0))     goto dma_map_err;

Re: [PATCH v2 0/2] net: enable inband link state negotiation only when explicitly requested

2015-07-13 Thread Stas Sergeev
13.07.2015 12:54, Sebastien Rannou пишет: Hi Stas, On Fri, 10 Jul 2015, Stas Sergeev wrote: Those who were affected by the change, please send your Tested-by, Thanks! I also confirm that this version of the patch solves the issue: Tested-by: Sebastien Rannou m...@sbrk.org Thanks

RE: GFIT

2015-07-13 Thread Cunliffe Bryan (RW3) CMFT Manchester
From: Cunliffe Bryan (RW3) CMFT Manchester Sent: 12 July 2015 21:11 To: Cunliffe Bryan (RW3) CMFT Manchester Subject: GFIT Donation has been made to you Email mrs.gloriamacke...@outlook.commailto:mrs.gloriamacke...@outlook.com for more Details Privacy and

Re: [PATCH 4/6] net: ieee802154: Remove redundant spi driver bus initialization

2015-07-13 Thread Marcel Holtmann
Hi Antonio, In ancient times it was necessary to manually initialize the bus field of an spi_driver to spi_bus_type. These days this is done in spi_register_driver(), so we can drop the manual assignment. Signed-off-by: Antonio Borneo borneo.anto...@gmail.com To: Alan Ott a...@signal11.us

Re: [RFC PATCH 0/2] net: macb: Add mdio driver for accessing multiple phy devices

2015-07-13 Thread punnaiah choudary kalluri
On Tue, Jul 14, 2015 at 12:13 AM, Florian Fainelli f.faine...@gmail.com wrote: On 12/07/15 21:48, Punnaiah Choudary Kalluri wrote: This patch is to add support for the design that has multiple ethernet mac controllers and single mdio bus connected to multiple phy devices. i.e mdio lines are

Re: [PATCH net] bridge: mdb: fix double add notification

2015-07-13 Thread Cong Wang
On Mon, Jul 13, 2015 at 6:36 AM, Nikolay Aleksandrov niko...@cumulusnetworks.com wrote: Since the mdb add/del code was introduced there have been 2 br_mdb_notify calls when doing br_mdb_add() resulting in 2 notifications on each add. Example: Command: bridge mdb add dev br0 port eth1 grp

[PATCH] e1000e: Move e1000e_disable_aspm_locked() inside CONFIG_PM

2015-07-13 Thread Michael Ellerman
e1000e_disable_aspm_locked() is only used in __e1000_resume() which is inside CONFIG_PM. So when CONFIG_PM=n we get a defined but not used warning for e1000e_disable_aspm_locked(). Move it inside the existing CONFIG_PM block to avoid the warning. Signed-off-by: Michael Ellerman

[rhashtable] WARNING: CPU: 0 PID: 1 at lib/debugobjects.c:301 __debug_object_init()

2015-07-13 Thread Fengguang Wu
f760b87f8f12eb262f14603e65042996fe03720e # 10:33 66+ 0 Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net # extra tests on tree/branch next/master git bisect good 2eb62d762a2112579f259903e62ba18d16c51f66 # 10:36 66+ 20 Add linux-next specific files for 20150713 This script may

Re: mmap()ed AF_NETLINK: lockdep and sleep-in-atomic warnings

2015-07-13 Thread Cong Wang
On Mon, Jul 13, 2015 at 6:18 AM, Kirill A. Shutemov kir...@shutemov.name wrote: Hi, This simple test-case trigers few locking asserts in kernel: #define _GNU_SOURCE #include stdlib.h #include stdio.h #include string.h #include sys/mman.h #include sys/socket.h #include sys/types.h

add some more infomation RE: Issue with active-backup mode bond and bridge

2015-07-13 Thread pengyi Peng(Yi)
I test this issue in kernel 3.0.93. This issue is a reproduction problem. Step 1. Create a active-backup mode bond with two nics and make sure the IP is in the bond. Step 2. Create a bridge with brctl command Step 3. Join the bond to the bridge and make the IP in the bridge device Step 4. use

[PATCH] ipv6: Fix finding best source address in ipv6_dev_get_saddr().

2015-07-13 Thread YOSHIFUJI Hideaki/吉藤英明
Commit 9131f3de2 (ipv6: Do not iterate over all interfaces when finding source address on specific interface.) did not properly update best source address available. Plus, it introduced possible NULL pointer dereference. Bug was reported by Erik Kline e...@google.com. Based on patch proposed by

[PATCH net-next 4/4 v2] gianfar: Add paged allocation and Rx S/G

2015-07-13 Thread Claudiu Manoil
The eTSEC h/w is capable of scatter/gather on the receive side too if MAXFRM MRBLR, when the allowed maximum Rx frame size is set to be greater than the maximum Rx buffer size (MRBLR). It's about time the driver makes use of this h/w capability, by supporting fixed buffer sizes and Rx S/G. The

[PATCH net-next 3/4 v2] gianfar: Use ndev, more Rx path cleanup

2015-07-13 Thread Claudiu Manoil
Use ndev instead of dev, as the rx queue back pointer to a net_device struct, to avoid name clashing with a struct device reference. This prepares the addition of a struct device back pointer to the rx queue structure. Remove duplicated rxq registration in the process. Move napi_gro_receive()

[PATCH net-next 2/4 v2] gianfar: Fix and cleanup rxbd status handling

2015-07-13 Thread Claudiu Manoil
There are several (long standing) problems about how the status field of the rx buffer descriptor (rxbd) is currently handled on the error path: - too many unnecessary 16bit reads of the two halves of the rxbd status field (32bit), also resulting in overuse of endianness convesion macros; -

[PATCH net-next 0/4 v2] gianfar: Add Rx S/G

2015-07-13 Thread Claudiu Manoil
Hi David, This patch-set introduces scatter/gather support on the Rx side, addressing Rx path performance issues in the driver. Thanks. As an example, two boards connected back-to-back were used to measure the throughput, running the same kernel 4.1, before and after applying these patches. The

Re: [PATCH net-next v2] ipv6: Do not iterate over all interfaces when finding source address on specific interface.

2015-07-13 Thread YOSHIFUJI Hideaki
Hi, Hajime Tazaki wrote: Yoshifuji-san, At Mon, 13 Jul 2015 17:38:48 +0900, Erik Kline wrote: On 13 July 2015 at 15:32, YOSHIFUJI Hideaki hideaki.yoshif...@miraclelinux.com wrote: Hi, Erik Kline wrote: Hmm, when I run a UML linux with this patch (which, I'm ashamed to say, I failed

Re: [PATCH net v4] rtnl/bond: don't send rtnl msg for unregistered iface

2015-07-13 Thread Kristian Evensen
Hello, I have a quick question about this patch. On Wed, May 13, 2015 at 2:19 PM, Nicolas Dichtel nicolas.dich...@6wind.com wrote: diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 837d30b5ffed..7b25f1ef3d75 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@

Re: net: Fix skb csum races when peeking

2015-07-13 Thread Herbert Xu
On Mon, Jul 13, 2015 at 08:01:42PM +0800, Herbert Xu wrote: PS we seem to no longer use the hardware checksum in case of CHECKSUM_COMPLETE, I wonder why that is? Nevermind, it's still there. I was just looking in the wrong place. -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page:

Re: [PATCH v2] add stealth mode

2015-07-13 Thread Austin S Hemmelgarn
On 2015-07-12 19:13, Matteo Croce wrote: 2015-07-08 15:32 GMT+02:00 Austin S Hemmelgarn ahferro...@gmail.com: On 2015-07-06 15:44, Matteo Croce wrote: Just to name a few that I know of off the top of my head: 1. IP packets with any protocol number not supported by your current kernel (these

[PATCH net] bridge: mdb: fix double add notification

2015-07-13 Thread Nikolay Aleksandrov
Since the mdb add/del code was introduced there have been 2 br_mdb_notify calls when doing br_mdb_add() resulting in 2 notifications on each add. Example: Command: bridge mdb add dev br0 port eth1 grp 239.0.0.1 permanent Before patch: root@debian:~# bridge monitor all [MDB]dev br0 port eth1

Re: [PATCH 1/2] sctp: SCTP_SOCKOPT_PEELOFF return socket pointer for kernel users

2015-07-13 Thread Marcelo Ricardo Leitner
On 13-07-2015 07:39, Neil Horman wrote: On Fri, Jul 10, 2015 at 06:21:14PM -0700, David Miller wrote: From: Marcelo Ricardo Leitner marcelo.leit...@gmail.com Date: Thu, 9 Jul 2015 11:15:19 -0300 SCTP has this operation to peel off associations from a given socket and create a new socket

Re: [PATCH] nf: IDLETIMER: fix lockdep warning

2015-07-13 Thread Dmitry Torokhov
On Mon, Jul 13, 2015 at 6:20 AM, Pablo Neira Ayuso pa...@netfilter.org wrote: On Thu, Jul 09, 2015 at 05:15:01PM -0700, Dmitry Torokhov wrote: Dynamically allocated sysfs attributes should be initialized with sysfs_attr_init() otherwise lockdep will be angry with us: [ 45.468653] BUG: key

mmap()ed AF_NETLINK: lockdep and sleep-in-atomic warnings

2015-07-13 Thread Kirill A. Shutemov
Hi, This simple test-case trigers few locking asserts in kernel: #define _GNU_SOURCE #include stdlib.h #include stdio.h #include string.h #include sys/mman.h #include sys/socket.h #include sys/types.h #include linux/netlink.h #define SOL_NETLINK 270 int main(int argc, char **argv) {

[PATCH net-next 1/4 v2] gianfar: Bundle Rx allocation, cleanup

2015-07-13 Thread Claudiu Manoil
Use a more common consumer/ producer index design to improve rx buffer allocation. Instead of allocating a single new buffer (skb) on each iteration, bundle the allocation of several rx buffers at a time. This also opens the path for further memory optimizations. Remove useless check of

Re: [PATCH net-next] tc: fix tc actions in case of shared skb

2015-07-13 Thread Jamal Hadi Salim
On 07/10/15 20:10, Alexei Starovoitov wrote: TC actions need to check for very unlikely event skb-users != 1, otherwise subsequent pskb_may_pull/pskb_expand_head will crash. When skb_shared() just drop the packet, since in the middle of actions it's too late to call skb_share_check(), since

Re: [PATCH] nf: IDLETIMER: fix lockdep warning

2015-07-13 Thread Pablo Neira Ayuso
On Thu, Jul 09, 2015 at 05:15:01PM -0700, Dmitry Torokhov wrote: Dynamically allocated sysfs attributes should be initialized with sysfs_attr_init() otherwise lockdep will be angry with us: [ 45.468653] BUG: key ffc030fad4e0 not in .data! [ 45.468655] [ cut here

Re: [net-next 12/16] i40evf: don't delete all the filters

2015-07-13 Thread Sergei Shtylyov
Hello. On 7/13/2015 12:08 PM, Jeff Kirsher wrote: From: Mitch Williams mitch.a.willi...@intel.com Due to an inverted conditional, the driver was marking all of its MAC filters for deletion every time set_rx_mode was called. Depending upon the timing of the calls to set_rx_mode and the

Re: [rhashtable] WARNING: CPU: 0 PID: 1 at lib/debugobjects.c:301 __debug_object_init()

2015-07-13 Thread Fengguang Wu
+ 20 Add linux-next specific files for 20150713 This script may reproduce the error. #!/bin/bash kernel=$1 initrd=yocto-minimal-x86_64.cgz wget --no-clobber https://github.com/fengguang/reproduce-kernel

RE: [PATCH v3] Add support for driver cross-timestamp to PTP_SYS_OFFSET ioctl

2015-07-13 Thread Hall, Christopher S
I am assuming the patch is rejected at this point. I will re-submit later as soon as I am able to post a full end to end solution. Chris -Original Message- From: Richard Cochran [mailto:richardcoch...@gmail.com] Sent: Thursday, July 09, 2015 7:58 AM To: Hall, Christopher S Cc:

Re: [PATCH 4/6] net: ieee802154: Remove redundant spi driver bus initialization

2015-07-13 Thread Alexander Aring
On Tue, Jun 23, 2015 at 10:52:52PM +0800, Antonio Borneo wrote: In ancient times it was necessary to manually initialize the bus field of an spi_driver to spi_bus_type. These days this is done in spi_register_driver(), so we can drop the manual assignment. Marcel, I don't see this patch in

[PATCH V4 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-07-13 Thread Mark D Rustad
From: Mark Rustad mark.d.rus...@intel.com Add a dev_flags bit, PCI_DEV_FLAGS_VPD_REF_F0, to access VPD through function 0 to provide VPD access on other functions. This is for hardware devices that provide copies of the same VPD capability registers in multiple functions. Because the kernel

[PATCH V4 2/2] pci: Add VPD quirk for Intel Ethernet devices

2015-07-13 Thread Mark D Rustad
From: Mark Rustad mark.d.rus...@intel.com This quirk sets the PCI_DEV_FLAGS_VPD_REF_F0 flag on all Intel Ethernet device functions other than function 0. Signed-off-by: Mark Rustad mark.d.rus...@intel.com --- Changes in V3: - Added a multifunction device check --- drivers/pci/quirks.c |9

[Patch net] fq_codel: fix a use-after-free

2015-07-13 Thread Cong Wang
Fixes: 25331d6ce42b (net: sched: implement qstat helper routines) Cc: John Fastabend john.fastab...@gmail.com Signed-off-by: Cong Wang xiyou.wangc...@gmail.com Signed-off-by: Cong Wang cw...@twopensource.com --- net/sched/sch_fq_codel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH v2 18/22] fjes: unshare_watch_task

2015-07-13 Thread Yasuaki Ishimatsu
Hi Izumi-san, On Wed, 24 Jun 2015 11:55:50 +0900 Taku Izumi izumi.t...@jp.fujitsu.com wrote: This patch adds unshare_watch_task. Shared buffer's status can be changed into unshared. This task is used to monitor shared buffer's status. Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com

Re: [PATCH net-next] ebpf: remove self-assignment in interpreter's tail call

2015-07-13 Thread Alexei Starovoitov
On 7/13/15 11:49 AM, Daniel Borkmann wrote: ARG1 = BPF_R1 as it stands, evaluates to regs[BPF_REG_1] = regs[BPF_REG_1] and thus has no effect. Add a comment instead, explaining what happens and why it's okay to just remove it. Since from user space side, a tail call is invoked as a pseudo helper

Re: [PATCH 1/2] sctp: SCTP_SOCKOPT_PEELOFF return socket pointer for kernel users

2015-07-13 Thread David Miller
From: Neil Horman nhor...@tuxdriver.com Date: Mon, 13 Jul 2015 06:39:11 -0400 Initially Marcelo had created duplicate code paths, one to return an fd, one to return a file struct. If you would rather go in that direction, I'm sure he can propose it again, but that seems less correct to me

[PATCH] net/bonding: Add function bond_remove_proc_entry at __bond_release_one

2015-07-13 Thread clsoto
From: Carol L Soto cls...@linux.vnet.ibm.com Add function bond_remove_proc_entry at __bond_release_one to avoid stack trace at rmmod bonding. [68830.202239] remove_proc_entry: removing non-empty directory 'net/bonding', leaking at least 'bond0' [68830.202257] [ cut here

Re: [PATCH 1/2] sctp: SCTP_SOCKOPT_PEELOFF return socket pointer for kernel users

2015-07-13 Thread Marcelo Ricardo Leitner
On 13-07-2015 15:59, David Miller wrote: From: Neil Horman nhor...@tuxdriver.com Date: Mon, 13 Jul 2015 06:39:11 -0400 Initially Marcelo had created duplicate code paths, one to return an fd, one to return a file struct. If you would rather go in that direction, I'm sure he can propose it

Re: Fighting out-of-order reception with RPS?

2015-07-13 Thread Tom Herbert
On Sun, Jul 12, 2015 at 12:15 PM, Oliver Hartkopp socket...@hartkopp.net wrote: Hello Eric, On 07/11/2015 06:35 AM, Eric Dumazet wrote: On Fri, 2015-07-10 at 22:36 +0200, Oliver Hartkopp wrote: Hm. Doesn't sound like a good solution when there's a difference between NAPI and non-NAPI

[PATCH net] tcp: don't use F-RTO on non-recurring timeouts

2015-07-13 Thread Yuchung Cheng
Currently F-RTO may repeatedly send new data packets on non-recurring timeouts in CA_Loss mode. This is a bug because F-RTO (RFC5682) should only be used on either new recovery or recurring timeouts. This exacerbates the recovery progress during frequent timeout repair, because we prioritize

RE: [PATCH] bnx2:Make various functions to have a return type of void in the file bnx2.c

2015-07-13 Thread Sony Chacko
Sony, I also sent this patch and was wondering if I can get a reply on it. From 4a607447562bec161fd947caae5eb02c2365c58a Mon Sep 17 00:00:00 2001 From: Nicholas Krause xerofo...@gmail.com Date: Wed, 8 Jul 2015 08:29:07 -0400 Subject: [PATCH] bnx2i:Fix backwards locking scenario in the

[PATCH V4 0/2] pci: Provide a flag to access VPD through function 0

2015-07-13 Thread Mark D Rustad
Many multi-function devices provide shared registers in extended config space for accessing VPD. The behavior of these registers means that the state must be tracked and access locked correctly for accesses not to hang or worse. One way to meet these needs is to always perform the accesses through

[PATCH net-next] hv_netvsc: Add close of RNDIS filter into change mtu call

2015-07-13 Thread Haiyang Zhang
The current change mtu call only stops tx before removing RNDIS filter. In case ringbufer is not empty, the rndis_filter_device_remove() may hang on removing the buffers. This patch adds close of RNDIS filter before removing it, also a gradual waiting loop until the ring is empty. The change_mtu

[PATCH net-next] ebpf: remove self-assignment in interpreter's tail call

2015-07-13 Thread Daniel Borkmann
ARG1 = BPF_R1 as it stands, evaluates to regs[BPF_REG_1] = regs[BPF_REG_1] and thus has no effect. Add a comment instead, explaining what happens and why it's okay to just remove it. Since from user space side, a tail call is invoked as a pseudo helper function via bpf_tail_call_proto, the

Re: [PATCH v1 08/12] IB/cma: Add net_dev and private data checks to RDMA CM

2015-07-13 Thread Jason Gunthorpe
On Mon, Jun 22, 2015 at 03:42:37PM +0300, Haggai Eran wrote: + switch (ib_event-event) { + case IB_CM_REQ_RECEIVED: + req-device = req_param-listen_id-device; + req-port = req_param-port; + req-local_gid = req_param-primary_path-sgid; +

Re: Linux 4.2 build error in net/netfilter/ipset/ip_set_hash_netnet.c

2015-07-13 Thread Cong Wang
On Mon, Jul 13, 2015 at 9:13 AM, Akemi Yagi amy...@gmail.com wrote: On Sun, 05 Jul 2015 08:35:20 -0700, Guenter Roeck wrote: On Sat, Jul 04, 2015 at 12:44:36AM -0700, Vinson Lee wrote: Hi. With the latest Linux 4.2-rc1, I am hitting this build error with GCC 4.4.7 on CentOS 6. CC

request for -stable: route: Use ipv4_mtu instead of raw rt_pmtu

2015-07-13 Thread Timo Teras
Hi, Can you queue for active older -stables up to 3.18: commit 3cdaa5be9e81 ipv4: Don't increase PMTU with Datagram Too Big message commit cb6ccf09d6b9 route: Use ipv4_mtu instead of raw rt_pmtu commit 3cdaa5be9e81 made it to 3.19.y and was later fixed additionally with conversion to ipv4_mtu()

Re: [PATCH v1 05/12] IB/cm: Share listening CM IDs

2015-07-13 Thread Jason Gunthorpe
On Mon, Jun 22, 2015 at 03:42:34PM +0300, Haggai Eran wrote: spin_lock_irq(cm.lock); + if (--cm_id_priv-listen_sharecount 0) { + /* The id is still shared. */ + atomic_dec(cm_id_priv-refcount); Nit: This looks very strange not

Re: [PATCH v1 11/12] IB/cma: Share ib_cm_ids between rdma_cm_ids

2015-07-13 Thread Jason Gunthorpe
On Mon, Jun 22, 2015 at 03:42:40PM +0300, Haggai Eran wrote: Use ib_cm_id_create_and_listen to create listening IB CM IDs or share ^^^ Is that the wrong name? ib_cm_insert_listen perhaps? I think I've looked at the details in this series I was concerned about, Sean

Re: [PATCH] ipv6: Fix finding best source address in ipv6_dev_get_saddr().

2015-07-13 Thread Hajime Tazaki
At Mon, 13 Jul 2015 23:28:10 +0900, YOSHIFUJI Hideaki/吉藤英明 wrote: Commit 9131f3de2 (ipv6: Do not iterate over all interfaces when finding source address on specific interface.) did not properly update best source address available. Plus, it introduced possible NULL pointer dereference.

[PATCH net-next] net: Build IPv6 into kernel by default

2015-07-13 Thread Tom Herbert
This patch makes the default to build IPv6 into the kernel. IPv6 now has significant traction and any remaining vestiges of IPv6 not being provided parity with IPv4 should be swept away. IPv6 is now core to the Internet and kernel. Points on IPv6 adoption: - Per Google statistics, IPv6 usage has

Re: [PATCH] ipv6: Fix finding best source address in ipv6_dev_get_saddr().

2015-07-13 Thread Tom Herbert
I am testing this patch which may be a little simpler. Also idev needs to be checked after __in6_dev_get Tom diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 4ab74d5..d631ac3 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -1363,9 +1363,10 @@ static void

Re: [PATCH v2 15/22] fjes: net_device_ops.ndo_vlan_rx_add/kill_vid

2015-07-13 Thread Yasuaki Ishimatsu
Hi Izumi-san, On Wed, 24 Jun 2015 11:55:47 +0900 Taku Izumi izumi.t...@jp.fujitsu.com wrote: This patch adds net_device_ops.ndo_vlan_rx_add_vid and net_device_ops.ndo_vlan_rx_kill_vid callback. Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com --- drivers/net/fjes/fjes_hw.c | 27

Re: [PATCH] nf: IDLETIMER: fix lockdep warning

2015-07-13 Thread Pablo Neira Ayuso
On Mon, Jul 13, 2015 at 08:02:36AM -0700, Dmitry Torokhov wrote: On Mon, Jul 13, 2015 at 6:20 AM, Pablo Neira Ayuso pa...@netfilter.org wrote: On Thu, Jul 09, 2015 at 05:15:01PM -0700, Dmitry Torokhov wrote: Dynamically allocated sysfs attributes should be initialized with

Re: Linux 4.2 build error in net/netfilter/ipset/ip_set_hash_netnet.c

2015-07-13 Thread Akemi Yagi
On Sun, 05 Jul 2015 08:35:20 -0700, Guenter Roeck wrote: On Sat, Jul 04, 2015 at 12:44:36AM -0700, Vinson Lee wrote: Hi. With the latest Linux 4.2-rc1, I am hitting this build error with GCC 4.4.7 on CentOS 6. CC net/netfilter/ipset/ip_set_hash_netnet.o

Re: [PATCH v2 10/22] fjes: tx_stall_task

2015-07-13 Thread Yasuaki Ishimatsu
Hi Izum-san, On Wed, 24 Jun 2015 11:55:42 +0900 Taku Izumi izumi.t...@jp.fujitsu.com wrote: This patch adds tx_stall_task. When receiver's buffer is full, sender stops its tx queue. This task is used to monitor receiver's status and when receiver's buffer is avairable, it resumes tx queue.

[PATCH] net: qlcnic: Deletion of unnecessary memset

2015-07-13 Thread Christophe JAILLET
There is no need to memset memory allocated with vzalloc. Signed-off-by: Christophe JAILLET christophe.jail...@wanadoo.fr --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c

virtio-net TSO Lockup

2015-07-13 Thread Brian Rak
We've been encountering an issue in the virtio-net driver that cause it to become unresponsive after a period of high load. This issue goes away if we disable TSO on the interface. Once this issue has been triggered, the interface can still receive traffic, but will not transmit anything.

Re: [PATCH] net/bonding: Add function bond_remove_proc_entry at __bond_release_one

2015-07-13 Thread Nikolay Aleksandrov
On 07/13/2015 11:05 PM, Nikolay Aleksandrov wrote: On 07/13/2015 08:57 PM, cls...@linux.vnet.ibm.com wrote: From: Carol L Soto cls...@linux.vnet.ibm.com Add function bond_remove_proc_entry at __bond_release_one to avoid stack trace at rmmod bonding. [68830.202239] remove_proc_entry:

Re: [PATCH 1/2] sctp: SCTP_SOCKOPT_PEELOFF return socket pointer for kernel users

2015-07-13 Thread David Miller
From: Marcelo Ricardo Leitner marcelo.leit...@gmail.com Date: Mon, 13 Jul 2015 16:05:27 -0300 On 13-07-2015 15:59, David Miller wrote: From: Neil Horman nhor...@tuxdriver.com Date: Mon, 13 Jul 2015 06:39:11 -0400 Initially Marcelo had created duplicate code paths, one to return an fd, one

Re: [PATCH net-next] tc: fix tc actions in case of shared skb

2015-07-13 Thread Alexei Starovoitov
On 7/11/15 9:29 PM, David Miller wrote: From: Alexei Starovoitov a...@plumgrid.com Date: Fri, 10 Jul 2015 17:10:11 -0700 TC actions need to check for very unlikely event skb-users != 1, otherwise subsequent pskb_may_pull/pskb_expand_head will crash. When skb_shared() just drop the packet,

Re: [PATCH net-next] net: Build IPv6 into kernel by default

2015-07-13 Thread David Miller
From: Tom Herbert t...@herbertland.com Date: Mon, 13 Jul 2015 08:48:00 -0700 This patch makes the default to build IPv6 into the kernel. IPv6 now has significant traction and any remaining vestiges of IPv6 not being provided parity with IPv4 should be swept away. IPv6 is now core to the

Re: [PATCH net-next] ebpf: remove self-assignment in interpreter's tail call

2015-07-13 Thread David Miller
From: Daniel Borkmann dan...@iogearbox.net Date: Mon, 13 Jul 2015 20:49:32 +0200 ARG1 = BPF_R1 as it stands, evaluates to regs[BPF_REG_1] = regs[BPF_REG_1] and thus has no effect. Add a comment instead, explaining what happens and why it's okay to just remove it. Since from user space side, a

Re: [PATCH 1/2] sctp: SCTP_SOCKOPT_PEELOFF return socket pointer for kernel users

2015-07-13 Thread Marcelo Ricardo Leitner
On 13-07-2015 16:58, David Miller wrote: From: Marcelo Ricardo Leitner marcelo.leit...@gmail.com Date: Mon, 13 Jul 2015 16:05:27 -0300 On 13-07-2015 15:59, David Miller wrote: From: Neil Horman nhor...@tuxdriver.com Date: Mon, 13 Jul 2015 06:39:11 -0400 Initially Marcelo had created

Re: [PATCH] Logically DeadCode

2015-07-13 Thread Rafał Miłecki
On 3 July 2015 at 06:52, Rahul Jain rahul.j...@samsung.com wrote: From 0c34030166a150d6d9f1ab52e7bb40a5440a68c2 Mon Sep 17 00:00:00 2001 From: Rahul Jain rahul.j...@samsung.com Date: Fri, 3 Jul 2015 10:19:12 +0530 Subject: [PATCH] Logically DeadCode You didn't use any prefix for the commit

Re: [PATCH] Revert net: fec: Ensure clocks are enabled while using mdio bus

2015-07-13 Thread David Miller
From: Fabio Estevam fabio.este...@freescale.com Date: Mon, 13 Jul 2015 08:13:52 -0300 This reverts commit 6c3e921b18edca290099adfddde8a50236bf2d80. commit 6c3e921b18ed (net: fec: Ensure clocks are enabled while using mdio bus) prevents the kernel to boot on mx6 boards, so let's revert it.

Re: [PATCH net-next] tc: fix tc actions in case of shared skb

2015-07-13 Thread Alexei Starovoitov
On 7/13/15 1:04 PM, David Miller wrote: From: Alexei Starovoitov a...@plumgrid.com Date: Mon, 13 Jul 2015 12:47:42 -0700 In all normal cases skb-users == 1, but pktgen is using trick: atomic_add(burst, skb-users); so when testing something like: You can want pktgen rx (which is the only

Re: [PATCH net-next] tc: fix tc actions in case of shared skb

2015-07-13 Thread David Miller
From: Alexei Starovoitov a...@plumgrid.com Date: Mon, 13 Jul 2015 12:47:42 -0700 In all normal cases skb-users == 1, but pktgen is using trick: atomic_add(burst, skb-users); so when testing something like: You can want pktgen rx (which is the only buggy case as far as I can see, TX is fine)

Re: [RFC PATCH 0/2] net: macb: Add mdio driver for accessing multiple phy devices

2015-07-13 Thread Florian Fainelli
On 12/07/15 21:48, Punnaiah Choudary Kalluri wrote: This patch is to add support for the design that has multiple ethernet mac controllers and single mdio bus connected to multiple phy devices. i.e mdio lines are connected to any of the ethernet mac controller and all the phy devices will be

Re: [PATCH net-next] tc: fix tc actions in case of shared skb

2015-07-13 Thread Daniel Borkmann
On 07/13/2015 10:17 PM, Alexei Starovoitov wrote: ... We cannot check tc actions from pktgen, since they can be added dynamically. So I see three options: 1 get rid of burst hack for both RX and TX in pktgen (kills performance) 2 add unlikely(skb_shread) check to few tc actions 3 do nothing I

Re: [PATCH] net/bonding: Add function bond_remove_proc_entry at __bond_release_one

2015-07-13 Thread Nikolay Aleksandrov
On 07/13/2015 08:57 PM, cls...@linux.vnet.ibm.com wrote: From: Carol L Soto cls...@linux.vnet.ibm.com Add function bond_remove_proc_entry at __bond_release_one to avoid stack trace at rmmod bonding. [68830.202239] remove_proc_entry: removing non-empty directory 'net/bonding', leaking at

Re: [RFC net-next 18/22] openvswitch: Make tunnel set action attach a metadata dst

2015-07-13 Thread Joe Stringer
Hi Thomas, On 10 July 2015 at 07:19, Thomas Graf tg...@suug.ch wrote: diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c index ecfa530..05fe46b 100644 --- a/net/openvswitch/flow_netlink.c +++ b/net/openvswitch/flow_netlink.c @@ -1548,11 +1548,45 @@ static struct

  1   2   >