Re: [PATCH net-next] rocker: forward packets to CPU when port is joined to openvswitch

2015-07-15 Thread Jiri Pirko
Thu, Jul 16, 2015 at 08:40:31AM CEST, sfel...@gmail.com wrote: >On Wed, Jul 15, 2015 at 6:39 PM, Simon Horman > wrote: >> Teach rocker to forward packets to CPU when a port is joined to Open vSwitch. >> There is scope to later refine what is passed up as per Open vSwitch flows >> on a port. >> >> T

Re: [PATCH net-next] rocker: forward packets to CPU when port is joined to openvswitch

2015-07-15 Thread Scott Feldman
On Wed, Jul 15, 2015 at 6:39 PM, Simon Horman wrote: > Teach rocker to forward packets to CPU when a port is joined to Open vSwitch. > There is scope to later refine what is passed up as per Open vSwitch flows > on a port. > > This does not change the behaviour of rocker ports that are > not joine

Re: "ss -p" segfaults

2015-07-15 Thread Marc Dietrich
Am Donnerstag, 16. Juli 2015, 01:22:38 schrieb Vadim Kochan: > On Wed, Jul 15, 2015 at 09:57:51PM +0300, Vadim Kochan wrote: > > On Wed, Jul 15, 2015 at 06:52:49PM +, Rustad, Mark D wrote: > > > > On Jul 15, 2015, at 9:49 AM, Rustad, Mark D wrote: > > > >> On Jul 15, 2015, at 8:12 AM, Vadim K

Re: [PATCH net] bonding: fix destruction of bond with devices different from arphrd_ether

2015-07-15 Thread Veaceslav Falico
On Thu, Jul 16, 2015 at 12:54:06AM +0200, Nikolay Aleksandrov wrote: ...snip... My personal opinion would be to disable non-ethernet devices, but support was already added and has been there for a long time so we have to fix this for the older releases, I don't mind removing non-ethernet device s

Re: pull request: bluetooth 2015-07-15

2015-07-15 Thread David Miller
From: Johan Hedberg Date: Wed, 15 Jul 2015 11:43:55 +0300 > Here's a regression fix for Broadcom Bluetooth adapters found at least > in certain Apple laptops. The issue was introduced in 4.1 so there's the > appropriate "Cc: stable" entry for it. > > Let me know if there are any issues pulling.

Re: [PATCH net-next v7 0/4] net: Introduce protodown flag.

2015-07-15 Thread David Miller
From: anurad...@cumulusnetworks.com Date: Tue, 14 Jul 2015 13:43:18 -0700 > User space daemons can detect errors in the network that need to be > notified to the switch device drivers. > > Drivers can react to this error state by doing a phy-down on the > switch-port which would result in a carri

Re: [PATCH net] tc: act_bpf: fix memory leak

2015-07-15 Thread David Miller
From: Alexei Starovoitov Date: Tue, 14 Jul 2015 12:15:19 -0700 > prog->bpf_ops is populated when act_bpf is used with classic BPF and > prog->bpf_name is optionally used with extended BPF. > Fix memory leak when act_bpf is released. > > Fixes: d23b8ad8ab23 ("tc: add BPF based action") > Fixes: a

Re: [Patch net] net_sched: fix a use-after-free in sfq

2015-07-15 Thread David Miller
From: Cong Wang Date: Tue, 14 Jul 2015 11:21:57 -0700 > Fixes: 25331d6ce42b ("net: sched: implement qstat helper routines") > Cc: John Fastabend > Signed-off-by: Cong Wang > Signed-off-by: Cong Wang Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: [Patch net] fq_codel: fix return value of fq_codel_drop()

2015-07-15 Thread David Miller
From: Cong Wang Date: Tue, 14 Jul 2015 11:21:58 -0700 > The ->drop() is supposed to return the number of bytes it dropped, > however fq_codel_drop() returns the index of the flow where it drops > a packet from. > > Fix this by introducing a helper to wrap fq_codel_drop(). > > Cc: Eric Dumazet

Re: [PATCH net-next] ibmveth: add support for TSO6

2015-07-15 Thread David Miller
From: Thomas Falcon Date: Tue, 14 Jul 2015 10:51:51 -0500 > This patch adds support for a new method of signalling the firmware > that TSO packets are being sent. The new method removes the need to > alter the ip and tcp checksums and allows TSO6 support. > > Signed-off-by: Thomas Falcon Appli

Re: [PATCH v3 0/5] ipvlan: cleanups and fixes

2015-07-15 Thread David Miller
From: Konstantin Khlebnikov Date: Tue, 14 Jul 2015 16:35:49 +0300 > v1: http://comments.gmane.org/gmane.linux.network/363346 > v2: http://comments.gmane.org/gmane.linux.network/369086 > > v3 has reduced set of patches from "ipvlan: fix ipv6 autoconfiguration". > Here just cleanups and patch whic

Re: [PATCH V2 net-next 2/3] net: introduce socket family constants

2015-07-15 Thread David Miller
From: Ursula Braun Date: Tue, 14 Jul 2015 14:42:34 +0200 > diff --git a/net/Kconfig b/net/Kconfig > index 57a7c5a..d829694 100644 > --- a/net/Kconfig > +++ b/net/Kconfig > @@ -54,6 +54,7 @@ source "net/packet/Kconfig" > source "net/unix/Kconfig" > source "net/xfrm/Kconfig" > source "net/iucv/K

Re: [PATCH V2 net-next 1/3] tcp: introduce TCP experimental option for SMC

2015-07-15 Thread David Miller
From: Ursula Braun Date: Tue, 14 Jul 2015 14:42:33 +0200 > diff --git a/include/linux/tcp.h b/include/linux/tcp.h > index 48c3696..1b9a698 100644 > --- a/include/linux/tcp.h > +++ b/include/linux/tcp.h > @@ -90,15 +90,28 @@ struct tcp_options_received { > sack_ok : 4,/* SACK see

Re: [V2 6/7] hvsock: introduce Hyper-V VM Sockets feature

2015-07-15 Thread David Miller
From: Dexuan Cui Date: Tue, 14 Jul 2015 03:00:48 -0700 > + pr_debug("hvsock_sk_destruct: called\n"); Debug logging just to state that a function is called is not appropriate, we have very sophisticated tracing facilities in the kernel that can do that transparently, and more. PLease remove

Re: [V2 3/7] Drivers: hv: vmbus: add APIs to send/recv hvsock packet and get the r/w-ability

2015-07-15 Thread David Miller
From: Dexuan Cui Date: Tue, 14 Jul 2015 02:58:56 -0700 > +int vmbus_sendpacket_hvsock(struct vmbus_channel *channel, void *buf, u32 > len) > +{ > + struct vmpacket_descriptor desc; > + struct vmpipe_proto_header pipe_hdr; > + u32 packetlen; > + u32 packetlen_aligned; > + stru

Re: [V2 1/7] Drivers: hv: vmbus: define the new offer type for Hyper-V socket (hvsock)

2015-07-15 Thread David Miller
From: Dexuan Cui Date: Tue, 14 Jul 2015 02:58:03 -0700 > A helper function is also added. > > Signed-off-by: Dexuan Cui > --- > include/linux/hyperv.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h > index 30d3a1f..aa21814 10064

Re: [PATCH net-next] hv_netvsc: Add close of RNDIS filter into change mtu call

2015-07-15 Thread David Miller
From: Haiyang Zhang Date: Mon, 13 Jul 2015 13:09:16 -0700 > The current change mtu call only stops tx before removing RNDIS filter. > In case ringbufer is not empty, the rndis_filter_device_remove() may > hang on removing the buffers. > > This patch adds close of RNDIS filter before removing it,

Re: [PATCH] ipv6: Fix finding best source address in ipv6_dev_get_saddr().

2015-07-15 Thread David Miller
From: Tom Herbert Date: Mon, 13 Jul 2015 08:31:05 -0700 > I am testing this patch which may be a little simpler. Also idev needs > to be checked after __in6_dev_get Tom, I'm applying Hideaki's fix for now. If you want to simplify the code, feel free to submit that as a follow-up, thank you! --

Re: [PATCH] ipv6: Fix finding best source address in ipv6_dev_get_saddr().

2015-07-15 Thread David Miller
From: YOSHIFUJI Hideaki/吉藤英明 Date: Mon, 13 Jul 2015 23:28:10 +0900 > Commit 9131f3de2 ("ipv6: Do not iterate over all interfaces when > finding source address on specific interface.") did not properly > update best source address available. Plus, it introduced > possible NULL pointer dereference

[PATCH 1/1] ath10k: fixing wrong initialization of struct channel

2015-07-15 Thread Maninder Singh
chandef is initialized with NULL and on the very next line, we are using it to get channel, which is not correct. channel should be initialized after obtaining chandef. Signed-off-by: Maninder Singh --- drivers/net/wireless/ath/ath10k/mac.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(

[RFC] show socket info in fdinfo

2015-07-15 Thread Josh Hunt
When sockets are unhashed they are no longer visible through the normal methods. Provide a way to see all sockets in the system by dumping some basic socket information in fdinfo. Signed-off-by: Josh Hunt --- When trying to debug an application issue which wound up not closing sockets properly w

[PATCH nf 4/6] ipvs: skb_orphan in case of forwarding

2015-07-15 Thread Simon Horman
From: Alex Gartrell It is possible that we bind against a local socket in early_demux when we are actually going to want to forward it. In this case, the socket serves no purpose and only serves to confuse things (particularly functions which implicitly expect sk_fullsock to be true, like ip_loc

[PATCH nf 0/6] IPVS Fixes for v4.2

2015-07-15 Thread Simon Horman
Hi Pablo, please consider this fix for v4.2. For reasons that are not clear to me it is a bumper crop. It seems to me that they are all relevant to stable. Please let me know if you need my help to get the fixes into stable. * ipvs: fix ipv6 route unreach panic This problem appears to be pres

[PATCH nf 5/6] ipvs: fix crash with sync protocol v0 and FTP

2015-07-15 Thread Simon Horman
From: Julian Anastasov Fix crash in 3.5+ if FTP is used after switching sync_version to 0. Fixes: 749c42b620a9 ("ipvs: reduce sync rate with time thresholds") Signed-off-by: Julian Anastasov Signed-off-by: Simon Horman --- net/netfilter/ipvs/ip_vs_sync.c | 2 +- 1 file changed, 1 insertion(+)

[PATCH nf 1/6] ipvs: fix ipv6 route unreach panic

2015-07-15 Thread Simon Horman
From: Alex Gartrell Previously there was a trivial panic unshare -n /bin/bash

[PATCH nf 3/6] ipvs: fix crash if scheduler is changed

2015-07-15 Thread Simon Horman
From: Julian Anastasov I overlooked the svc->sched_data usage from schedulers when the services were converted to RCU in 3.10. Now the rare ipvsadm -E command can change the scheduler but due to the reverse order of ip_vs_bind_scheduler and ip_vs_unbind_scheduler we provide new sched_data to the

[PATCH nf 2/6] ipvs: do not use random local source address for tunnels

2015-07-15 Thread Simon Horman
From: Julian Anastasov Michael Vallaly reports about wrong source address used in rare cases for tunneled traffic. Looks like __ip_vs_get_out_rt in 3.10+ is providing uninitialized dest_dst->dst_saddr.ip because ip_vs_dest_dst_alloc uses kmalloc. While we retry after seeing EINVAL from routing fo

[PATCH nf 6/6] ipvs: call skb_sender_cpu_clear

2015-07-15 Thread Simon Horman
From: Julian Anastasov Reset XPS's sender_cpu on forwarding. Signed-off-by: Julian Anastasov Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices") Signed-off-by: Simon Horman --- net/netfilter/ipvs/ip_vs_xmit.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/netfilter/ipvs/ip

Re: [PATCH/RFC net-next] rocker: forward packets to CPU when a port in promiscuous mode

2015-07-15 Thread Simon Horman
On Wed, Jul 15, 2015 at 07:50:32AM -0700, Scott Feldman wrote: > On Wed, Jul 15, 2015 at 12:54 AM, Simon Horman > wrote: > > On Wed, Jul 15, 2015 at 12:18:20AM -0700, Scott Feldman wrote: > >> On Tue, Jul 14, 2015 at 11:34 PM, Simon Horman > >> wrote: > >> > On Tue, Jul 14, 2015 at 10:32:54PM -07

[PATCH net-next] rocker: forward packets to CPU when port is joined to openvswitch

2015-07-15 Thread Simon Horman
Teach rocker to forward packets to CPU when a port is joined to Open vSwitch. There is scope to later refine what is passed up as per Open vSwitch flows on a port. This does not change the behaviour of rocker ports that are not joined to Open vSwitch. Signed-off-by: Simon Horman --- drivers/net

Re: [PATCH] Revert "net: fec: Ensure clocks are enabled while using mdio bus"

2015-07-15 Thread David Miller
From: Clemens Gruber Date: Thu, 16 Jul 2015 02:04:04 +0200 > This reverts commit 6c3e921b18edca290099adfddde8a50236bf2d80. > > The change did break ethernet support on the i.MX6Q and possibly also on > other platforms: The PHY was not detected anymore and eth0 was not found. > > Signed-off-by:

Re: [net-next v2 00/16][pull request] Intel Wired LAN Driver Updates 2015-07-14

2015-07-15 Thread David Miller
From: Jeff Kirsher Date: Tue, 14 Jul 2015 18:30:24 -0700 > This series contains updates to i40e and i40evf only. Pulled, thanks Jeff. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ker

Re: [PATCH] net: mvneta: fix refilling for Rx DMA buffers

2015-07-15 Thread David Miller
From: Simon Guinot Date: Thu, 16 Jul 2015 02:25:30 +0200 > On Wed, Jul 15, 2015 at 03:52:56PM -0700, David Miller wrote: >> Failed memory allocations, are normal and if necessary kernel log >> messages will be triggered by the core memory allocator. So there is >> zero reason to do anything othe

[PATCH] Revert "net: fec: Ensure clocks are enabled while using mdio bus"

2015-07-15 Thread Clemens Gruber
This reverts commit 6c3e921b18edca290099adfddde8a50236bf2d80. The change did break ethernet support on the i.MX6Q and possibly also on other platforms: The PHY was not detected anymore and eth0 was not found. Signed-off-by: Clemens Gruber Cc: Andrew Lunn Cc: Fugang Duan Cc: David S. Miller -

Re: pull-request: can 2015-07-15

2015-07-15 Thread David Miller
From: Marc Kleine-Budde Date: Wed, 15 Jul 2015 09:09:37 +0200 > this is a pull request of 12 patches by me. > > This series fixes the use of the skb after netif_receive_skb() / > netif_rx() which exists in several drivers. Pulled, thanks Marc. -- To unsubscribe from this list: send the line "un

Re: [PATCH net] ipv6: lock socket in ip6_datagram_connect()

2015-07-15 Thread David Miller
From: Eric Dumazet Date: Tue, 14 Jul 2015 08:10:22 +0200 > From: Eric Dumazet > > ip6_datagram_connect() is doing a lot of socket changes without > socket being locked. > > This looks wrong, at least for udp_lib_rehash() which could corrupt > lists because of concurrent udp_sk(sk)->udp_portadd

Re: [PATCH 0/2] Fix long-standing regression in ser_gigaset ISDN driver

2015-07-15 Thread David Miller
From: Tilman Schmidt Date: Tue, 14 Jul 2015 00:37:13 +0200 (CEST) > This series fixes a serious regression in the Gigaset M101 driver > introduced in kernel release 3.10 and removes some unneeded code. > > Please also queue up patch 1 of the series for inclusion in the > stable/longterm releases

Re: [PATCH] net: mvneta: fix refilling for Rx DMA buffers

2015-07-15 Thread Simon Guinot
On Wed, Jul 15, 2015 at 03:52:56PM -0700, David Miller wrote: > From: Simon Guinot > Date: Mon, 13 Jul 2015 00:04:57 +0200 > > > On some Armada 370-based NAS, I have experimented kernel bugs and > > crashes when the mvneta Ethernet driver fails to refill Rx DMA buffers > > due to memory shortage.

sit: Set SKB_GSO_SIT bit when performing GRO

2015-07-15 Thread Herbert Xu
On Wed, Jul 15, 2015 at 02:25:59PM +0200, Wolfgang Walter wrote: > > Yes. Switching TSO off and leaving GRO on works, too. OK, could you please try this patch? ---8<--- We need to set the SKB_GSO_SIT bit if we detect a 6-in-4 tunnel when doing GRO. Otherwise we may throw a packet at TSO hardware

Re: [PATCH] pkt_sched: sch_qfq: remove unused member of struct qfq_sched

2015-07-15 Thread David Miller
From: Andrea Parri Date: Tue, 14 Jul 2015 00:12:05 +0200 > The member (u32) "num_active_agg" of struct qfq_sched has been unused > since its introduction in 462dbc9101acd38e92eda93c0726857517a24bbd > "pkt_sched: QFQ Plus: fair-queueing service at DRR cost" and (AFAICT) > there is no active plan t

Re: [PATCH] net: qlcnic: Deletion of unnecessary memset

2015-07-15 Thread David Miller
From: Christophe JAILLET Date: Mon, 13 Jul 2015 21:51:38 +0200 > There is no need to memset memory allocated with vzalloc. > > Signed-off-by: Christophe JAILLET Applied and queued up for -stable, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a mess

Re: [Patch net] fq_codel: fix a use-after-free

2015-07-15 Thread David Miller
From: Cong Wang Date: Mon, 13 Jul 2015 12:30:07 -0700 > Fixes: 25331d6ce42b ("net: sched: implement qstat helper routines") > Cc: John Fastabend > Signed-off-by: Cong Wang > Signed-off-by: Cong Wang Applied and queued up for -stable, thanks. -- To unsubscribe from this list: send the line "un

Re: [PATCH net] tcp: don't use F-RTO on non-recurring timeouts

2015-07-15 Thread David Miller
From: Yuchung Cheng Date: Mon, 13 Jul 2015 12:10:20 -0700 > Currently F-RTO may repeatedly send new data packets on non-recurring > timeouts in CA_Loss mode. This is a bug because F-RTO (RFC5682) > should only be used on either new recovery or recurring timeouts. > > This exacerbates the recover

Re: [PATCH net] bridge: mdb: fix double add notification

2015-07-15 Thread David Miller
From: Nikolay Aleksandrov Date: Mon, 13 Jul 2015 06:36:19 -0700 > Since the mdb add/del code was introduced there have been 2 br_mdb_notify > calls when doing br_mdb_add() resulting in 2 notifications on each add. > > Example: > Command: bridge mdb add dev br0 port eth1 grp 239.0.0.1 permanent

Re: [PATCH net-next 0/4 v2] gianfar: Add Rx S/G

2015-07-15 Thread David Miller
From: Claudiu Manoil Date: Mon, 13 Jul 2015 16:22:02 +0300 > This patch-set introduces scatter/gather support > on the Rx side, addressing Rx path performance > issues in the driver. Series applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a mes

Re: [PATCH net] bridge: multicast: treat igmpv3 report with INCLUDE and no sources as a leave

2015-07-15 Thread David Miller
From: Nikolay Aleksandrov Date: Mon, 13 Jul 2015 05:28:37 -0700 > From: Satish Ashok > > A report with INCLUDE/Change_to_include and empty source list should be > treated as a leave, specified by RFC 3376, section 3.1: > "If the requested filter mode is INCLUDE *and* the requested source > lis

[PATCH net-next iproute2] support batching of ip route get commands

2015-07-15 Thread Roopa Prabhu
From: Roopa Prabhu This patch replaces exits with returns in ip route get command handling. This allows batching of ip route get commands. $cat route_get_batch.txt route get 10.0.14.2 route get 12.0.14.2 route get 10.0.14.4 $ip -batch route_get_batch.txt local 10.0.14.2 dev lo src 10.0.14.2

Re: net: Clone skb before setting peeked flag

2015-07-15 Thread David Miller
From: Herbert Xu Date: Mon, 13 Jul 2015 16:04:13 +0800 > Shared skbs must not be modified and this is crucial for broadcast > and/or multicast paths where we use it as an optimisation to avoid > unnecessary cloning. > > The function skb_recv_datagram breaks this rule by setting peeked > without

Re: [PATCH v2] NET: AX.25: Stop heartbeat timer on disconnect.

2015-07-15 Thread David Miller
From: Ralf Baechle Date: Mon, 13 Jul 2015 11:38:24 +0200 > From: Richard Stearn > > This may result in a kernel panic. The bug has always existed but > somehow we've run out of luck now and it bites. > > Signed-off-by: Richard Stearn > Cc: sta...@vger.kernel.org# all branches > Signed-of

Re: net: Fix skb csum races when peeking

2015-07-15 Thread David Miller
From: Herbert Xu Date: Mon, 13 Jul 2015 20:01:42 +0800 > When we calculate the checksum on the recv path, we store the > result in the skb as an optimisation in case we need the checksum > again down the line. > > This is in fact bogus for the MSG_PEEK case as this is done without > any locking.

Re: [PATCH] Revert "net: fec: Ensure clocks are enabled while using mdio bus"

2015-07-15 Thread David Miller
From: Fabio Estevam Date: Mon, 13 Jul 2015 08:13:52 -0300 > This reverts commit 6c3e921b18edca290099adfddde8a50236bf2d80. > > commit 6c3e921b18ed ("net: fec: Ensure clocks are enabled while using mdio > bus") prevents the kernel to boot on mx6 boards, so let's revert it. > > Reported-by: Tyler

[PATCH net] net: dsa: bcm_sf2: do not use indirect reads and writes for 7445E0

2015-07-15 Thread Florian Fainelli
7445E0 contains an ECO which disconnected the internal SF2 pseudo-PHY which was known to conflict with the external pseudo-PHY of BCM53125 switches. This motivated the need to utilize the internal SF2 MDIO controller via indirect register reads/writes to control external Broadcom switches due to th

Re: [PATCH net] bonding: fix destruction of bond with devices different from arphrd_ether

2015-07-15 Thread Carol Soto
On 7/15/2015 5:54 PM, Nikolay Aleksandrov wrote: On 07/16/2015 12:39 AM, Eric W. Biederman wrote: Nikolay Aleksandrov writes: From: Nikolay Aleksandrov When the bonding is being unloaded and the netdevice notifier is unregistered it executes NETDEV_UNREGISTER for each device which should

Re: [PATCH net] rtnetlink: reject non-IFLA_VF_PORT attributes inside IFLA_VF_PORTS

2015-07-15 Thread David Miller
From: Daniel Borkmann Date: Mon, 13 Jul 2015 00:06:02 +0200 > Similarly as in commit 4f7d2cdfdde7 ("rtnetlink: verify IFLA_VF_INFO > attributes before passing them to driver"), we have a double nesting > of netlink attributes, i.e. IFLA_VF_PORTS only contains IFLA_VF_PORT > that is nested itself.

Re: [PATCH net] bonding: fix destruction of bond with devices different from arphrd_ether

2015-07-15 Thread Nikolay Aleksandrov
On 07/16/2015 12:39 AM, Eric W. Biederman wrote: > Nikolay Aleksandrov writes: > >> From: Nikolay Aleksandrov >> >> When the bonding is being unloaded and the netdevice notifier is >> unregistered it executes NETDEV_UNREGISTER for each device which should >> remove the bond's proc entry but if t

Re: [PATCH] net: mvneta: fix refilling for Rx DMA buffers

2015-07-15 Thread David Miller
From: Simon Guinot Date: Mon, 13 Jul 2015 00:04:57 +0200 > On some Armada 370-based NAS, I have experimented kernel bugs and > crashes when the mvneta Ethernet driver fails to refill Rx DMA buffers > due to memory shortage. > > With the actual code, if the memory allocation fails while refilling

Re: [PATCH net] bonding: fix destruction of bond with devices different from arphrd_ether

2015-07-15 Thread Eric W. Biederman
Nikolay Aleksandrov writes: > From: Nikolay Aleksandrov > > When the bonding is being unloaded and the netdevice notifier is > unregistered it executes NETDEV_UNREGISTER for each device which should > remove the bond's proc entry but if the device enslaved is not of > ARPHRD_ETHER type and is in

Re: "ss -p" segfaults

2015-07-15 Thread Vadim Kochan
On Wed, Jul 15, 2015 at 09:57:51PM +0300, Vadim Kochan wrote: > On Wed, Jul 15, 2015 at 06:52:49PM +, Rustad, Mark D wrote: > > > On Jul 15, 2015, at 9:49 AM, Rustad, Mark D > > > wrote: > > > > > >> On Jul 15, 2015, at 8:12 AM, Vadim Kochan wrote: > > >> Would you please check this fix ? >

Sending IPv6 packets broken in net-next

2015-07-15 Thread Phil Sutter
Hi, Commit 9131f3d ("ipv6: Do not iterate over all interfaces when finding source address on specific interface") breaks local output of IPv6 packets. Here is a simple reproducer: 8< - ip link add eth6 type veth peer name eth7 ip netns add test ip link set eth7 netns test ip netns exec t

dccp related oops in inet_csk_listen_start

2015-07-15 Thread Dave Jones
While experimenting with some dccp fuzzing, I hit this.. Oops: 0010 [#1] PREEMPT SMP DEBUG_PAGEALLOC CPU: 3 PID: 19269 Comm: trinity-c22 Not tainted 4.2.0-rc2-think+ #2 task: 88006f3954c0 ti: 8802b89b task.ti: 8802b89b RIP: 0010:[<>] [< (null)>]

Re: [PATCH net-next 2/2] ebpf: add helper to retrieve net_cls's classid cookie

2015-07-15 Thread Alexei Starovoitov
On 7/15/15 5:21 AM, Daniel Borkmann wrote: It would be very useful to retrieve the net_cls's classid from an eBPF program to allow for a more fine-grained classification, it could be directly used or in conjunction with additional policies. I.e. docker, but also tooling such as cgexec, can easily

Re: [PATCH v1 08/12] IB/cma: Add net_dev and private data checks to RDMA CM

2015-07-15 Thread Jason Gunthorpe
On Wed, Jul 15, 2015 at 08:27:06PM +, Liran Liss wrote: > If you want to restrict a container to a specific set of pkeys, use > cgroups. Ideally yes, but in the absence of a cgroup the set of pkeys assigned to the container via ipoib is a reasonable alternate. > This would apply both to CM MA

Re: [PATCH net] bonding: fix destruction of bond with devices different from arphrd_ether

2015-07-15 Thread Carol Soto
On 7/15/2015 2:52 PM, Nikolay Aleksandrov wrote: From: Nikolay Aleksandrov When the bonding is being unloaded and the netdevice notifier is unregistered it executes NETDEV_UNREGISTER for each device which should remove the bond's proc entry but if the device enslaved is not of ARPHRD_ETHER ty

Re: [PATCH net-next v7 0/4] net: Introduce protodown flag.

2015-07-15 Thread David Miller
From: Andy Gospodarek Date: Wed, 15 Jul 2015 12:24:35 -0400 > If it is switchdev-only that would prevent people from using commodity > hardware (classic servers + NICs) from being able to build something > similar to what can be done with rocker. Agreed, this isn't switchdev specific at all. --

Re: [PATCH v2 0/2] Avoid link dependency of dlm on sctp module

2015-07-15 Thread David Miller
From: Neil Horman Date: Wed, 15 Jul 2015 09:57:14 -0400 > Series > Acked-by: Neil Horman I don't like this at all. I know it's a pain in the ass to have this dependency on SCTP, but calling exported functions is absolutely the right way to handle this kind of situation. -- To unsubscribe from

Re: [PATCH v2 1/2] sctp: add new getsockopt option SCTP_SOCKOPT_PEELOFF_KERNEL

2015-07-15 Thread David Miller
From: Neil Horman Date: Wed, 15 Jul 2015 09:18:28 -0400 > Do we need to do something here to prevent user space calls from inadvertently > accessing this option? And this is also not what I had anticipated was the implementation. I didn't mean that adding a new option number specially for the k

[PATCH net] bonding: correctly handle bonding type change on enslave failure

2015-07-15 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov If the bond is enslaving a device with different type it will be setup by it, but if after being setup the enslave fails the bond doesn't switch back its type and also keeps pointers to foreign structures that can be long gone. Thus revert back any type changes if the en

Re: [PATCH net] bonding: fix bond dev flags after convert to arphrd_ether

2015-07-15 Thread Nikolay Aleksandrov
On 07/15/2015 10:09 PM, Nikolay Aleksandrov wrote: > From: Nikolay Aleksandrov > > If a bonding device enslaves devices != arphrd_ether it'll change types > and if later these devices are released, it can enslave an arphrd_ether > device and switch back calling ether_setup() which resets dev->fla

RE: [PATCH v1 08/12] IB/cma: Add net_dev and private data checks to RDMA CM

2015-07-15 Thread Liran Liss
> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > > > What is really missing here I guess is a mechanism that would > > enforce containers to only use certain pkeys - perhaps with > > something like an RDMA cgroup. It could force containers to only > > use approved pkeys not on

Re: [PATCH nf-next] netfilter: nf_ct_sctp: minimal multihoming support

2015-07-15 Thread Marcelo Ricardo Leitner
Hi, On Tue, Jul 14, 2015 at 06:42:25PM +0200, Michal Kubecek wrote: > On Tue, Jul 14, 2015 at 03:42:03PM +0200, Florian Westphal wrote: > > Michal Kubecek wrote: > > > + case SCTP_CID_HEARTBEAT: > > > + pr_debug("SCTP_CID_HEARTBEAT"); > > > + i = 9; > > > + break; > > > +

Re: [PATCH net] bonding: fix bond dev flags after convert to arphrd_ether

2015-07-15 Thread Nikolay Aleksandrov
On 07/15/2015 10:32 PM, Jay Vosburgh wrote: > Nikolay Aleksandrov wrote: > >> From: Nikolay Aleksandrov >> >> If a bonding device enslaves devices != arphrd_ether it'll change types >> and if later these devices are released, it can enslave an arphrd_ether >> device and switch back calling ether

Re: [PATCH net] bonding: fix bond dev flags after convert to arphrd_ether

2015-07-15 Thread Jay Vosburgh
Nikolay Aleksandrov wrote: >From: Nikolay Aleksandrov > >If a bonding device enslaves devices != arphrd_ether it'll change types >and if later these devices are released, it can enslave an arphrd_ether >device and switch back calling ether_setup() which resets dev->flags to >IFF_BROADCAST|IFF_MU

Re: [PATCH -next 5/6] netfilter: Per network namespace netfilter hooks.

2015-07-15 Thread Eric W. Biederman
Pablo Neira Ayuso writes: > On Fri, Jul 10, 2015 at 06:15:06PM -0500, Eric W. Biederman wrote: >> @@ -102,13 +112,35 @@ int nf_register_hook(struct nf_hook_ops *reg) >> #endif >> return 0; >> } >> -EXPORT_SYMBOL(nf_register_hook); >> +EXPORT_SYMBOL(nf_register_net_hook); >> >> -void nf_u

Re: [PATCH -next 0/6] Per network namespace netfilter chains

2015-07-15 Thread Eric W. Biederman
Pablo Neira Ayuso writes: > On Fri, Jul 10, 2015 at 06:11:46PM -0500, Eric W. Biederman wrote: >> >> By maintining a set of functions to register and unregister netfilter >> hooks both globally and per network namespace I have managed to write a >> compact patchset that maintain per network netf

[PATCH net] bonding: fix bond dev flags after convert to arphrd_ether

2015-07-15 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov If a bonding device enslaves devices != arphrd_ether it'll change types and if later these devices are released, it can enslave an arphrd_ether device and switch back calling ether_setup() which resets dev->flags to IFF_BROADCAST|IFF_MULTICAST and clears IFF_MASTER which

[PATCH net-next] net/ipv6: update flowi6_oif in ip6_dst_lookup_flow if not set

2015-07-15 Thread Phil Sutter
Newly created flows don't have flowi6_oif set (at least if the associated socket is not interface-bound). This leads to a mismatch in __xfrm6_selector_match() for policies which specify an interface in the selector (sel->ifindex != 0). Backtracing shows this happens in code-paths originating from

[PATCH net] bonding: fix destruction of bond with devices different from arphrd_ether

2015-07-15 Thread Nikolay Aleksandrov
From: Nikolay Aleksandrov When the bonding is being unloaded and the netdevice notifier is unregistered it executes NETDEV_UNREGISTER for each device which should remove the bond's proc entry but if the device enslaved is not of ARPHRD_ETHER type and is in front of the bonding, it may execute bon

Re: [PATCH v2 net-next 2/3] rhashtable: Add a function for in order insertion and lookup in buckets

2015-07-15 Thread Tom Herbert
On Tue, Jul 14, 2015 at 10:54 PM, Herbert Xu wrote: > On Tue, Jul 14, 2015 at 04:45:48PM -0700, Tom Herbert wrote: >> The obj_orderfn function may be specified in the parameters for a >> rhashtable. When inserting an element this function is used to order >> objects in a bucket list (greatest to l

Re: [net-next v2 06/16] i40e: ignore duplicate port VLAN requests

2015-07-15 Thread Sergei Shtylyov
Hello. On 07/15/2015 04:30 AM, Jeff Kirsher wrote: From: Mitch Williams If user attempts to set a port VLAN on a VF that already has the same port VLAN configured, the driver will go through a completely unnecessary flurry of filter removals and filter adds. Just check for this condition an

Re: [RFC PATCH net-next] sctp: fix src address selection if using secondary addresses

2015-07-15 Thread Marcelo Ricardo Leitner
On Fri, Jul 10, 2015 at 03:27:02PM -0300, Marcelo Ricardo Leitner wrote: > On Fri, Jul 10, 2015 at 01:14:21PM -0400, Vlad Yasevich wrote: > > On 07/10/2015 12:17 PM, Marcelo Ricardo Leitner wrote: > > > On Fri, Jul 10, 2015 at 11:35:28AM -0400, Vlad Yasevich wrote: ... > > >> have been numerous tim

Re: [PATCH net-next v7 0/4] net: Introduce protodown flag.

2015-07-15 Thread Andy Gospodarek
On Wed, Jul 15, 2015 at 11:29:55AM -0700, Scott Feldman wrote: [...] > > On the iproute2 part, do we expect users to manually toggle this flag > from the cmdline? Seems kind of weird to walk up to a box and say "ip > link set dev DEV protodown on". Isn't this more intended for external > agents

Re: "ss -p" segfaults

2015-07-15 Thread Vadim Kochan
On Wed, Jul 15, 2015 at 06:52:49PM +, Rustad, Mark D wrote: > > On Jul 15, 2015, at 9:49 AM, Rustad, Mark D wrote: > > > >> On Jul 15, 2015, at 8:12 AM, Vadim Kochan wrote: > >> Would you please check this fix ? > >> > >> diff --git a/misc/ss.c b/misc/ss.c > >> index 03f92fa..3a826e4 100644

Re: [PATCH net-next v7 0/4] net: Introduce protodown flag.

2015-07-15 Thread Anuradha Karuppiah
On Wed, Jul 15, 2015 at 11:46 AM, Scott Feldman wrote: > On Wed, Jul 15, 2015 at 11:36 AM, Anuradha Karuppiah > wrote: >> On Wed, Jul 15, 2015 at 11:29 AM, Scott Feldman wrote: >>> On Wed, Jul 15, 2015 at 8:53 AM, Anuradha Karuppiah >>> wrote: On Tue, Jul 14, 2015 at 10:08 PM, Scott Feldma

Re: [PATCH -next 5/6] netfilter: Per network namespace netfilter hooks.

2015-07-15 Thread Pablo Neira Ayuso
On Fri, Jul 10, 2015 at 06:15:06PM -0500, Eric W. Biederman wrote: > @@ -102,13 +112,35 @@ int nf_register_hook(struct nf_hook_ops *reg) > #endif > return 0; > } > -EXPORT_SYMBOL(nf_register_hook); > +EXPORT_SYMBOL(nf_register_net_hook); > > -void nf_unregister_hook(struct nf_hook_ops *re

Re: "ss -p" segfaults

2015-07-15 Thread Rustad, Mark D
> On Jul 15, 2015, at 9:49 AM, Rustad, Mark D wrote: > >> On Jul 15, 2015, at 8:12 AM, Vadim Kochan wrote: >> Would you please check this fix ? >> >> diff --git a/misc/ss.c b/misc/ss.c >> index 03f92fa..3a826e4 100644 >> --- a/misc/ss.c >> +++ b/misc/ss.c >> @@ -683,8 +683,8 @@ static inline vo

Re: [PATCH v1 08/12] IB/cma: Add net_dev and private data checks to RDMA CM

2015-07-15 Thread Jason Gunthorpe
On Wed, Jul 15, 2015 at 01:57:48PM +0300, Haggai Eran wrote: > On 13/07/2015 21:14, Jason Gunthorpe wrote: > > On Mon, Jun 22, 2015 at 03:42:37PM +0300, Haggai Eran wrote: > >> + switch (ib_event->event) { > >> + case IB_CM_REQ_RECEIVED: > >> + req->device = req_param->listen_id->dev

Re: [PATCH net-next v7 0/4] net: Introduce protodown flag.

2015-07-15 Thread Scott Feldman
On Wed, Jul 15, 2015 at 11:36 AM, Anuradha Karuppiah wrote: > On Wed, Jul 15, 2015 at 11:29 AM, Scott Feldman wrote: >> On Wed, Jul 15, 2015 at 8:53 AM, Anuradha Karuppiah >> wrote: >>> On Tue, Jul 14, 2015 at 10:08 PM, Scott Feldman wrote: On Tue, Jul 14, 2015 at 1:43 PM, wrote: > F

Re: [PATCH net-next v7 0/4] net: Introduce protodown flag.

2015-07-15 Thread Anuradha Karuppiah
On Wed, Jul 15, 2015 at 11:29 AM, Scott Feldman wrote: > On Wed, Jul 15, 2015 at 8:53 AM, Anuradha Karuppiah > wrote: >> On Tue, Jul 14, 2015 at 10:08 PM, Scott Feldman wrote: >>> On Tue, Jul 14, 2015 at 1:43 PM, wrote: From: Anuradha Karuppiah User space daemons can detect err

Re: [PATCH net-next v7 0/4] net: Introduce protodown flag.

2015-07-15 Thread Scott Feldman
On Wed, Jul 15, 2015 at 8:53 AM, Anuradha Karuppiah wrote: > On Tue, Jul 14, 2015 at 10:08 PM, Scott Feldman wrote: >> On Tue, Jul 14, 2015 at 1:43 PM, wrote: >>> From: Anuradha Karuppiah >>> >>> User space daemons can detect errors in the network that need to be >>> notified to the switch dev

Re: [PATCH net-next v4 1/4] net core: Add protodown support.

2015-07-15 Thread Anuradha Karuppiah
On Wed, Jul 15, 2015 at 10:31 AM, Stephen Hemminger wrote: > On Wed, 8 Jul 2015 14:04:22 -0700 > anurad...@cumulusnetworks.com wrote: > >> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h >> index e20979d..99ebb01 100644 >> --- a/include/linux/netdevice.h >> +++ b/include/linux/

Re: [PATCH net-next v7 0/4] net: Introduce protodown flag.

2015-07-15 Thread Andy Gospodarek
On Wed, Jul 15, 2015 at 10:34:04AM -0700, Scott Feldman wrote: > On Wed, Jul 15, 2015 at 9:24 AM, Andy Gospodarek > wrote: > > On Tue, Jul 14, 2015 at 10:08:35PM -0700, Scott Feldman wrote: > >> On Tue, Jul 14, 2015 at 1:43 PM, wrote: > >> > From: Anuradha Karuppiah > >> > > >> > User space dae

RE: [PATCH net-next v7 2/4] netlink: changes for setting and clearing protodown via netlink.

2015-07-15 Thread Anuradha Karuppiah
-Original Message- From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Wednesday, July 15, 2015 10:32 AM To: anurad...@cumulusnetworks.com Cc: da...@davemloft.net; sfel...@gmail.com; netdev@vger.kernel.org; ro...@cumulusnetworks.com; go...@cumulusnetworks.com; w...@cumulusnetw

Re: [PATCH] net/bonding: Add function bond_remove_proc_entry at __bond_release_one

2015-07-15 Thread Nikolay Aleksandrov
On 07/13/2015 11:10 PM, Nikolay Aleksandrov wrote: > On 07/13/2015 11:05 PM, Nikolay Aleksandrov wrote: >> On 07/13/2015 08:57 PM, cls...@linux.vnet.ibm.com wrote: >>> From: Carol L Soto >>> >>> Add function bond_remove_proc_entry at __bond_release_one to avoid stack >>> trace at rmmod bonding. >

Re: [PATCH] iwlwifi: Deinline iwl_{read,write}{8,32}

2015-07-15 Thread Emmanuel Grumbach
On Tue, Jul 14, 2015 at 3:41 PM, Denys Vlasenko wrote: > On Tue, Jul 14, 2015 at 2:38 PM, Sergei Shtylyov > wrote: >>> +#define IWL_READ_WRITE(static_inline) \ >>> +static_inline void iwl_write8(struct iwl_trans *trans, u32 ofs, u8 val) \ >>> +{ \ >>> + trace_iwlwifi_dev_iowrite8(trans->dev

Re: [PATCH net-next v7 2/4] netlink: changes for setting and clearing protodown via netlink.

2015-07-15 Thread Stephen Hemminger
On Tue, 14 Jul 2015 13:43:20 -0700 anurad...@cumulusnetworks.com wrote: > From: Anuradha Karuppiah > > Signed-off-by: Anuradha Karuppiah > Signed-off-by: Andy Gospodarek > Signed-off-by: Roopa Prabhu > Signed-off-by: Wilson Kok > --- > include/uapi/linux/if_link.h |1 + > net/core/rtnet

Re: [PATCH net-next v7 0/4] net: Introduce protodown flag.

2015-07-15 Thread Scott Feldman
On Wed, Jul 15, 2015 at 9:24 AM, Andy Gospodarek wrote: > On Tue, Jul 14, 2015 at 10:08:35PM -0700, Scott Feldman wrote: >> On Tue, Jul 14, 2015 at 1:43 PM, wrote: >> > From: Anuradha Karuppiah >> > >> > User space daemons can detect errors in the network that need to be >> > notified to the sw

Re: [PATCH net-next v4 1/4] net core: Add protodown support.

2015-07-15 Thread Stephen Hemminger
On Wed, 8 Jul 2015 14:04:22 -0700 anurad...@cumulusnetworks.com wrote: > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index e20979d..99ebb01 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -1041,6 +1041,11 @@ typedef u16 (*select_queue_fallb

Re: [PATCH -next 0/6] Per network namespace netfilter chains

2015-07-15 Thread Pablo Neira Ayuso
On Fri, Jul 10, 2015 at 06:11:46PM -0500, Eric W. Biederman wrote: > > By maintining a set of functions to register and unregister netfilter > hooks both globally and per network namespace I have managed to write a > compact patchset that maintain per network netfilter chains, and > registers the

Re: [PATCH nf-next] net-ipvs: Delete an unnecessary check before the function call "module_put"

2015-07-15 Thread Pablo Neira Ayuso
On Fri, Jul 10, 2015 at 03:42:49PM +0900, Simon Horman wrote: > From: Markus Elfring > > The module_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Si

Re: "ss -p" segfaults

2015-07-15 Thread Rustad, Mark D
> On Jul 15, 2015, at 8:12 AM, Vadim Kochan wrote: > Would you please check this fix ? > > diff --git a/misc/ss.c b/misc/ss.c > index 03f92fa..3a826e4 100644 > --- a/misc/ss.c > +++ b/misc/ss.c > @@ -683,8 +683,8 @@ static inline void sock_addr_set_str(inet_prefix *prefix, > char **ptr) > > sta

  1   2   >